[jira] [Work logged] (TEXT-197) Replace statement lambda with expression lambda
[ https://issues.apache.org/jira/browse/TEXT-197?focusedWorklogId=584877=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584877 ] ASF GitHub Bot logged work on TEXT-197: --- Author: ASF GitHub Bot Created on: 19/Apr/21 04:59 Start Date: 19/Apr/21 04:59 Worklog Time Spent: 10m Work Description: arturobernalg commented on pull request #219: URL: https://github.com/apache/commons-text/pull/219#issuecomment-822166214 > > > Can you take a look at the Java 8 failures, please @arturobernalg ? > > > ``` > > > Error: Failures: > > > Error:DnsStringLookupTest.testCanonicalNameFromHostAddress:48 expected: <10.1.0.197> but was: > > > ``` > > > > > > Hi @kinow > > It's quite strange. especially because InetAddress is a native java object. Can we re launch the job? > > Seems there is no change in this clase. Weird > > TY > > I haven't had time to look more into the error, sorry. Will try to review it again tomorrow. For now I've re-triggered the jobs It's weird, now it's worked and have finish OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584877) Time Spent: 40m (was: 0.5h) > Replace statement lambda with expression lambda > --- > > Key: TEXT-197 > URL: https://issues.apache.org/jira/browse/TEXT-197 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > Change code block bodies with expression-style bodies -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] arturobernalg commented on pull request #219: TEXT-197 - Replace statement lambda with expression lambda
arturobernalg commented on pull request #219: URL: https://github.com/apache/commons-text/pull/219#issuecomment-822166214 > > > Can you take a look at the Java 8 failures, please @arturobernalg ? > > > ``` > > > Error: Failures: > > > Error:DnsStringLookupTest.testCanonicalNameFromHostAddress:48 expected: <10.1.0.197> but was: > > > ``` > > > > > > Hi @kinow > > It's quite strange. especially because InetAddress is a native java object. Can we re launch the job? > > Seems there is no change in this clase. Weird > > TY > > I haven't had time to look more into the error, sorry. Will try to review it again tomorrow. For now I've re-triggered the jobs It's weird, now it's worked and have finish OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (JCS-220) Java8 improvement
[ https://issues.apache.org/jira/browse/JCS-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated JCS-220: -- Description: * -Use Comparator.comparingLong- * Use method reference * Use lambda was: * Use Comparator.comparingLong * Use method reference * Use lambda > Java8 improvement > - > > Key: JCS-220 > URL: https://issues.apache.org/jira/browse/JCS-220 > Project: Commons JCS > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > > * -Use Comparator.comparingLong- > * Use method reference > * Use lambda -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-jcs] arturobernalg commented on a change in pull request #62: JCS-220 - Java8 improvement
arturobernalg commented on a change in pull request #62:
URL: https://github.com/apache/commons-jcs/pull/62#discussion_r615541987
##
File path:
commons-jcs-core/src/main/java/org/apache/commons/jcs3/auxiliary/disk/indexed/IndexedDiskCache.java
##
@@ -1259,7 +1259,7 @@ private long defragFile(final
IndexedDiskElementDescriptor[] defragList, final l
private IndexedDiskElementDescriptor[] createPositionSortedDescriptorList()
{
final List defragList = new
ArrayList<>(keyHash.values());
-Collections.sort(defragList, (ded1, ded2) -> Long.compare(ded1.pos,
ded2.pos));
+Collections.sort(defragList, Comparator.comparingLong(ded -> ded.pos));
Review comment:
Hi @tvand
I don't know why but i prefer using comparator. Of course it's a personal
choice. I rollback this change
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-jcs] arturobernalg commented on pull request #61: JCS-219 - Unnecessary boxing
arturobernalg commented on pull request #61: URL: https://github.com/apache/commons-jcs/pull/61#issuecomment-822163137 > This was intentional, actually. I consider this easier to read. I'm a bit hesitant to merge this. Sounds completely fair. Not a big fan but I understood the meaning. If you are agree i can close the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-197) Replace statement lambda with expression lambda
[ https://issues.apache.org/jira/browse/TEXT-197?focusedWorklogId=584865=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584865 ] ASF GitHub Bot logged work on TEXT-197: --- Author: ASF GitHub Bot Created on: 19/Apr/21 04:39 Start Date: 19/Apr/21 04:39 Worklog Time Spent: 10m Work Description: kinow commented on pull request #219: URL: https://github.com/apache/commons-text/pull/219#issuecomment-822160429 > > > > Can you take a look at the Java 8 failures, please @arturobernalg ? > > ``` > > Error: Failures: > > Error:DnsStringLookupTest.testCanonicalNameFromHostAddress:48 expected: <10.1.0.197> but was: > > ``` > > Hi @kinow > It's quite strange. especially because InetAddress is a native java object. Can we re launch the job? > Seems there is no change in this clase. Weird > TY I haven't had time to look more into the error, sorry. Will try to review it again tomorrow. For now I've re-triggered the jobs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584865) Time Spent: 0.5h (was: 20m) > Replace statement lambda with expression lambda > --- > > Key: TEXT-197 > URL: https://issues.apache.org/jira/browse/TEXT-197 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > Change code block bodies with expression-style bodies -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] kinow commented on pull request #219: TEXT-197 - Replace statement lambda with expression lambda
kinow commented on pull request #219: URL: https://github.com/apache/commons-text/pull/219#issuecomment-822160429 > > > > Can you take a look at the Java 8 failures, please @arturobernalg ? > > ``` > > Error: Failures: > > Error:DnsStringLookupTest.testCanonicalNameFromHostAddress:48 expected: <10.1.0.197> but was: > > ``` > > Hi @kinow > It's quite strange. especially because InetAddress is a native java object. Can we re launch the job? > Seems there is no change in this clase. Weird > TY I haven't had time to look more into the error, sorry. Will try to review it again tomorrow. For now I've re-triggered the jobs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-197) Replace statement lambda with expression lambda
[ https://issues.apache.org/jira/browse/TEXT-197?focusedWorklogId=584863=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584863 ] ASF GitHub Bot logged work on TEXT-197: --- Author: ASF GitHub Bot Created on: 19/Apr/21 04:38 Start Date: 19/Apr/21 04:38 Worklog Time Spent: 10m Work Description: arturobernalg commented on pull request #219: URL: https://github.com/apache/commons-text/pull/219#issuecomment-822160022 > Can you take a look at the Java 8 failures, please @arturobernalg ? > > ``` > Error: Failures: > Error:DnsStringLookupTest.testCanonicalNameFromHostAddress:48 expected: <10.1.0.197> but was: > ``` Hi @kinow It's quite strange. especially because InetAddress is a native java object. Can we re launch the job? Seems there is no change in this clase. Weird TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584863) Time Spent: 20m (was: 10m) > Replace statement lambda with expression lambda > --- > > Key: TEXT-197 > URL: https://issues.apache.org/jira/browse/TEXT-197 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Change code block bodies with expression-style bodies -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] arturobernalg commented on pull request #219: TEXT-197 - Replace statement lambda with expression lambda
arturobernalg commented on pull request #219: URL: https://github.com/apache/commons-text/pull/219#issuecomment-822160022 > Can you take a look at the Java 8 failures, please @arturobernalg ? > > ``` > Error: Failures: > Error:DnsStringLookupTest.testCanonicalNameFromHostAddress:48 expected: <10.1.0.197> but was: > ``` Hi @kinow It's quite strange. especially because InetAddress is a native java object. Can we re launch the job? Seems there is no change in this clase. Weird TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-200) Simplify statements
[
https://issues.apache.org/jira/browse/TEXT-200?focusedWorklogId=584860=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584860
]
ASF GitHub Bot logged work on TEXT-200:
---
Author: ASF GitHub Bot
Created on: 19/Apr/21 04:22
Start Date: 19/Apr/21 04:22
Worklog Time Spent: 10m
Work Description: arturobernalg commented on a change in pull request
#222:
URL: https://github.com/apache/commons-text/pull/222#discussion_r615534203
##
File path:
src/main/java/org/apache/commons/text/translate/UnicodeUnpairedSurrogateRemover.java
##
@@ -31,12 +31,9 @@
*/
@Override
public boolean translate(final int codepoint, final Writer writer) throws
IOException {
-if (codepoint >= Character.MIN_SURROGATE && codepoint <=
Character.MAX_SURROGATE) {
-// It's a surrogate. Write nothing and say we've translated.
-return true;
-}
+// It's a surrogate. Write nothing and say we've translated.
Review comment:
Agree. Changed.
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 584860)
Time Spent: 40m (was: 0.5h)
> Simplify statements
> ---
>
> Key: TEXT-200
> URL: https://issues.apache.org/jira/browse/TEXT-200
> Project: Commons Text
> Issue Type: Sub-task
>Reporter: Arturo Bernal
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-text] arturobernalg commented on a change in pull request #222: TEXT-200 - Simplify statements
arturobernalg commented on a change in pull request #222:
URL: https://github.com/apache/commons-text/pull/222#discussion_r615534203
##
File path:
src/main/java/org/apache/commons/text/translate/UnicodeUnpairedSurrogateRemover.java
##
@@ -31,12 +31,9 @@
*/
@Override
public boolean translate(final int codepoint, final Writer writer) throws
IOException {
-if (codepoint >= Character.MIN_SURROGATE && codepoint <=
Character.MAX_SURROGATE) {
-// It's a surrogate. Write nothing and say we've translated.
-return true;
-}
+// It's a surrogate. Write nothing and say we've translated.
Review comment:
Agree. Changed.
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] dependabot[bot] closed pull request #740: Bump actions/setup-java from v1.4.3 to v2
dependabot[bot] closed pull request #740: URL: https://github.com/apache/commons-lang/pull/740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] dependabot[bot] commented on pull request #740: Bump actions/setup-java from v1.4.3 to v2
dependabot[bot] commented on pull request #740: URL: https://github.com/apache/commons-lang/pull/740#issuecomment-822075300 Looks like actions/setup-java is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #739: Bump checkstyle from 8.41 to 8.41.1
garydgregory merged pull request #739: URL: https://github.com/apache/commons-lang/pull/739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #744: Bump spotbugs from 4.2.2 to 4.2.3
garydgregory merged pull request #744: URL: https://github.com/apache/commons-lang/pull/744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #742: Bump actions/cache from v2.1.4 to v2.1.5
garydgregory merged pull request #742: URL: https://github.com/apache/commons-lang/pull/742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-198) Replace lambda with method reference
[ https://issues.apache.org/jira/browse/TEXT-198?focusedWorklogId=584817=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584817 ] ASF GitHub Bot logged work on TEXT-198: --- Author: ASF GitHub Bot Created on: 18/Apr/21 20:55 Start Date: 18/Apr/21 20:55 Worklog Time Spent: 10m Work Description: kinow commented on pull request #220: URL: https://github.com/apache/commons-text/pull/220#issuecomment-822059816 Merged. Thanks!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584817) Time Spent: 40m (was: 0.5h) > Replace lambda with method reference > > > Key: TEXT-198 > URL: https://issues.apache.org/jira/browse/TEXT-198 > Project: Commons Text > Issue Type: Sub-task >Affects Versions: 1.9 >Reporter: Arturo Bernal >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.10 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TEXT-198) Replace lambda with method reference
[ https://issues.apache.org/jira/browse/TEXT-198?focusedWorklogId=584816=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584816 ] ASF GitHub Bot logged work on TEXT-198: --- Author: ASF GitHub Bot Created on: 18/Apr/21 20:55 Start Date: 18/Apr/21 20:55 Worklog Time Spent: 10m Work Description: kinow closed pull request #220: URL: https://github.com/apache/commons-text/pull/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584816) Time Spent: 0.5h (was: 20m) > Replace lambda with method reference > > > Key: TEXT-198 > URL: https://issues.apache.org/jira/browse/TEXT-198 > Project: Commons Text > Issue Type: Sub-task >Affects Versions: 1.9 >Reporter: Arturo Bernal >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.10 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] kinow commented on pull request #220: TEXT-198 - Replace lambda with method reference
kinow commented on pull request #220: URL: https://github.com/apache/commons-text/pull/220#issuecomment-822059816 Merged. Thanks!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow closed pull request #220: TEXT-198 - Replace lambda with method reference
kinow closed pull request #220: URL: https://github.com/apache/commons-text/pull/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (TEXT-198) Replace lambda with method reference
[ https://issues.apache.org/jira/browse/TEXT-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved TEXT-198. - Resolution: Fixed > Replace lambda with method reference > > > Key: TEXT-198 > URL: https://issues.apache.org/jira/browse/TEXT-198 > Project: Commons Text > Issue Type: Sub-task >Affects Versions: 1.9 >Reporter: Arturo Bernal >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.10 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEXT-199) Remove redundant local variable
[ https://issues.apache.org/jira/browse/TEXT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated TEXT-199: Assignee: Bruno P. Kinoshita > Remove redundant local variable > --- > > Key: TEXT-199 > URL: https://issues.apache.org/jira/browse/TEXT-199 > Project: Commons Text > Issue Type: Sub-task >Affects Versions: 1.9 >Reporter: Arturo Bernal >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.10 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEXT-198) Replace lambda with method reference
[ https://issues.apache.org/jira/browse/TEXT-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated TEXT-198: Assignee: Bruno P. Kinoshita > Replace lambda with method reference > > > Key: TEXT-198 > URL: https://issues.apache.org/jira/browse/TEXT-198 > Project: Commons Text > Issue Type: Sub-task >Affects Versions: 1.9 >Reporter: Arturo Bernal >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.10 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEXT-198) Replace lambda with method reference
[ https://issues.apache.org/jira/browse/TEXT-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated TEXT-198: Fix Version/s: 1.10 > Replace lambda with method reference > > > Key: TEXT-198 > URL: https://issues.apache.org/jira/browse/TEXT-198 > Project: Commons Text > Issue Type: Sub-task >Affects Versions: 1.9 >Reporter: Arturo Bernal >Priority: Minor > Fix For: 1.10 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEXT-198) Replace lambda with method reference
[ https://issues.apache.org/jira/browse/TEXT-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated TEXT-198: Affects Version/s: 1.9 > Replace lambda with method reference > > > Key: TEXT-198 > URL: https://issues.apache.org/jira/browse/TEXT-198 > Project: Commons Text > Issue Type: Sub-task >Affects Versions: 1.9 >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (TEXT-199) Remove redundant local variable
[ https://issues.apache.org/jira/browse/TEXT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved TEXT-199. - Resolution: Fixed > Remove redundant local variable > --- > > Key: TEXT-199 > URL: https://issues.apache.org/jira/browse/TEXT-199 > Project: Commons Text > Issue Type: Sub-task >Affects Versions: 1.9 >Reporter: Arturo Bernal >Priority: Minor > Fix For: 1.10 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TEXT-199) Remove redundant local variable
[ https://issues.apache.org/jira/browse/TEXT-199?focusedWorklogId=584815=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584815 ] ASF GitHub Bot logged work on TEXT-199: --- Author: ASF GitHub Bot Created on: 18/Apr/21 20:38 Start Date: 18/Apr/21 20:38 Worklog Time Spent: 10m Work Description: kinow commented on pull request #221: URL: https://github.com/apache/commons-text/pull/221#issuecomment-822057322 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584815) Time Spent: 40m (was: 0.5h) > Remove redundant local variable > --- > > Key: TEXT-199 > URL: https://issues.apache.org/jira/browse/TEXT-199 > Project: Commons Text > Issue Type: Sub-task >Affects Versions: 1.9 >Reporter: Arturo Bernal >Priority: Minor > Fix For: 1.10 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] kinow commented on pull request #221: TEXT-199 - Remove redundant local variable
kinow commented on pull request #221: URL: https://github.com/apache/commons-text/pull/221#issuecomment-822057322 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-199) Remove redundant local variable
[ https://issues.apache.org/jira/browse/TEXT-199?focusedWorklogId=584814=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584814 ] ASF GitHub Bot logged work on TEXT-199: --- Author: ASF GitHub Bot Created on: 18/Apr/21 20:37 Start Date: 18/Apr/21 20:37 Worklog Time Spent: 10m Work Description: kinow closed pull request #221: URL: https://github.com/apache/commons-text/pull/221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584814) Time Spent: 0.5h (was: 20m) > Remove redundant local variable > --- > > Key: TEXT-199 > URL: https://issues.apache.org/jira/browse/TEXT-199 > Project: Commons Text > Issue Type: Sub-task >Affects Versions: 1.9 >Reporter: Arturo Bernal >Priority: Minor > Fix For: 1.10 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] kinow closed pull request #221: TEXT-199 - Remove redundant local variable
kinow closed pull request #221: URL: https://github.com/apache/commons-text/pull/221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (TEXT-199) Remove redundant local variable
[ https://issues.apache.org/jira/browse/TEXT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated TEXT-199: Affects Version/s: 1.9 > Remove redundant local variable > --- > > Key: TEXT-199 > URL: https://issues.apache.org/jira/browse/TEXT-199 > Project: Commons Text > Issue Type: Sub-task >Affects Versions: 1.9 >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEXT-199) Remove redundant local variable
[ https://issues.apache.org/jira/browse/TEXT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated TEXT-199: Fix Version/s: 1.10 > Remove redundant local variable > --- > > Key: TEXT-199 > URL: https://issues.apache.org/jira/browse/TEXT-199 > Project: Commons Text > Issue Type: Sub-task >Affects Versions: 1.9 >Reporter: Arturo Bernal >Priority: Minor > Fix For: 1.10 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TEXT-200) Simplify statements
[
https://issues.apache.org/jira/browse/TEXT-200?focusedWorklogId=584811=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584811
]
ASF GitHub Bot logged work on TEXT-200:
---
Author: ASF GitHub Bot
Created on: 18/Apr/21 20:26
Start Date: 18/Apr/21 20:26
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #222:
URL: https://github.com/apache/commons-text/pull/222#discussion_r615449277
##
File path:
src/main/java/org/apache/commons/text/translate/UnicodeUnpairedSurrogateRemover.java
##
@@ -31,12 +31,9 @@
*/
@Override
public boolean translate(final int codepoint, final Writer writer) throws
IOException {
-if (codepoint >= Character.MIN_SURROGATE && codepoint <=
Character.MAX_SURROGATE) {
-// It's a surrogate. Write nothing and say we've translated.
-return true;
-}
+// It's a surrogate. Write nothing and say we've translated.
Review comment:
@arturobernalg I think this comment here doesn't relate to the single
return statement now (it is, and it is not, true and false now).
Maybe change it to `// If true, it is a surrogate. Write nothing and say
we've translated. Otherwise return false, and don't translate it.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 584811)
Time Spent: 0.5h (was: 20m)
> Simplify statements
> ---
>
> Key: TEXT-200
> URL: https://issues.apache.org/jira/browse/TEXT-200
> Project: Commons Text
> Issue Type: Sub-task
>Reporter: Arturo Bernal
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-text] kinow commented on a change in pull request #222: TEXT-200 - Simplify statements
kinow commented on a change in pull request #222:
URL: https://github.com/apache/commons-text/pull/222#discussion_r615449277
##
File path:
src/main/java/org/apache/commons/text/translate/UnicodeUnpairedSurrogateRemover.java
##
@@ -31,12 +31,9 @@
*/
@Override
public boolean translate(final int codepoint, final Writer writer) throws
IOException {
-if (codepoint >= Character.MIN_SURROGATE && codepoint <=
Character.MAX_SURROGATE) {
-// It's a surrogate. Write nothing and say we've translated.
-return true;
-}
+// It's a surrogate. Write nothing and say we've translated.
Review comment:
@arturobernalg I think this comment here doesn't relate to the single
return statement now (it is, and it is not, true and false now).
Maybe change it to `// If true, it is a surrogate. Write nothing and say
we've translated. Otherwise return false, and don't translate it.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-geometry] darkma773r opened a new pull request #151: GEOMETRY-120: adding SimpleTriangleMesh.Builder.addFace(int[]) method
darkma773r opened a new pull request #151: URL: https://github.com/apache/commons-geometry/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (GEOMETRY-120) SimpleTriangleMesh.Builder add face from index array
Matt Juntunen created GEOMETRY-120:
--
Summary: SimpleTriangleMesh.Builder add face from index array
Key: GEOMETRY-120
URL: https://issues.apache.org/jira/browse/GEOMETRY-120
Project: Apache Commons Geometry
Issue Type: Improvement
Reporter: Matt Juntunen
The {{SimpleTriangleMesh.Builder}} class has an {{addFace(int, int, int)}}
method but not an {{addFacet(int[])}} method. This would be good to add,
especially since it matches the {{Face.getVertexIndices()}} method, which
returns an {{int[]}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEOMETRY-120) SimpleTriangleMesh.Builder add face from index array
[
https://issues.apache.org/jira/browse/GEOMETRY-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Juntunen updated GEOMETRY-120:
---
Description: The {{SimpleTriangleMesh.Builder}} class has an {{addFace(int,
int, int)}} method but not an {{addFace(int[])}} method. This would be good to
add, especially since it matches the {{Face.getVertexIndices()}} method, which
returns an {{int[]}}. (was: The {{SimpleTriangleMesh.Builder}} class has an
{{addFace(int, int, int)}} method but not an {{addFacet(int[])}} method. This
would be good to add, especially since it matches the
{{Face.getVertexIndices()}} method, which returns an {{int[]}}.)
> SimpleTriangleMesh.Builder add face from index array
>
>
> Key: GEOMETRY-120
> URL: https://issues.apache.org/jira/browse/GEOMETRY-120
> Project: Apache Commons Geometry
> Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Minor
>
> The {{SimpleTriangleMesh.Builder}} class has an {{addFace(int, int, int)}}
> method but not an {{addFace(int[])}} method. This would be good to add,
> especially since it matches the {{Face.getVertexIndices()}} method, which
> returns an {{int[]}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEOMETRY-95) CSG Examples
[ https://issues.apache.org/jira/browse/GEOMETRY-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324582#comment-17324582 ] Matt Juntunen commented on GEOMETRY-95: --- Blah! Those were changes from a previous iteration. I'll put those in a different PR. > CSG Examples > > > Key: GEOMETRY-95 > URL: https://issues.apache.org/jira/browse/GEOMETRY-95 > Project: Apache Commons Geometry > Issue Type: New Feature >Reporter: Matt Juntunen >Priority: Major > > Adding Constructive Solid Geometry examples and userguide entries to help new > users to the library use these features. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEOMETRY-95) CSG Examples
[ https://issues.apache.org/jira/browse/GEOMETRY-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324568#comment-17324568 ] Gilles Sadowski commented on GEOMETRY-95: - Hi [~mattjuntunen]. It seems that PR#150 does more than adding/modifying the tutorial files. > CSG Examples > > > Key: GEOMETRY-95 > URL: https://issues.apache.org/jira/browse/GEOMETRY-95 > Project: Apache Commons Geometry > Issue Type: New Feature >Reporter: Matt Juntunen >Priority: Major > > Adding Constructive Solid Geometry examples and userguide entries to help new > users to the library use these features. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEOMETRY-95) CSG Examples
[ https://issues.apache.org/jira/browse/GEOMETRY-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324553#comment-17324553 ] Matt Juntunen commented on GEOMETRY-95: --- New PR is in: https://github.com/apache/commons-geometry/pull/150 > CSG Examples > > > Key: GEOMETRY-95 > URL: https://issues.apache.org/jira/browse/GEOMETRY-95 > Project: Apache Commons Geometry > Issue Type: New Feature >Reporter: Matt Juntunen >Priority: Major > > Adding Constructive Solid Geometry examples and userguide entries to help new > users to the library use these features. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-geometry] darkma773r opened a new pull request #150: GEOMETRY-95: adding solid geometry tutorial
darkma773r opened a new pull request #150: URL: https://github.com/apache/commons-geometry/pull/150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (COMMONSRDF-85) commons-rdf-jena is no longer compatible with the incoming Jena (4.1.x)
[ https://issues.apache.org/jira/browse/COMMONSRDF-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Brandizi updated COMMONSRDF-85: - Summary: commons-rdf-jena is no longer compatible with the incoming Jena (4.1.x) (was: commons-rdf-jena is no longer compatible with the incoming Jena () > commons-rdf-jena is no longer compatible with the incoming Jena (4.1.x) > --- > > Key: COMMONSRDF-85 > URL: https://issues.apache.org/jira/browse/COMMONSRDF-85 > Project: Apache Commons RDF > Issue Type: Bug > Components: jena >Affects Versions: 0.6.0 > Environment: $ mvn -version > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: /usr/local/Cellar/maven/3.6.3/libexec > Java version: 11.0.10, vendor: AdoptOpenJDK, runtime: > /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home > Default locale: en_GB, platform encoding: UTF-8 > OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac" > (My Mac UI reports version 11.2.3) >Reporter: Marco Brandizi >Priority: Major > > I'm trying the [current Jena > snapshot|https://repository.apache.org/content/groups/snapshots/org/apache/jena/apache-jena-libs/4.1.0-SNAPSHOT/] > with a project of mine, I need the latest snapshot due to this bug. > My project uses commonsrdf-jena and I found that version 0.5.0 has a couple > of Jena's method invocations and class references that were removed from the > current code base. > [This|https://github.com/marco-brandizi/commons-rdf/commit/d51ba56dd42541d81b8df7e43b39f9df8d088386] > is a fix for it. I don't think I can send in a pull request, since I had a > lot of problems with making the fork working with Java 11, including some > failing plugins like Javadoc or japicmp. > Manual copy-pasting of my changes from .java files should be easier to do. > I hope this project is still alive and this issue will be addressed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COMMONSRDF-85) commons-rdf-jena is no longer compatible with the incoming Jena (
Marco Brandizi created COMMONSRDF-85: Summary: commons-rdf-jena is no longer compatible with the incoming Jena ( Key: COMMONSRDF-85 URL: https://issues.apache.org/jira/browse/COMMONSRDF-85 Project: Apache Commons RDF Issue Type: Bug Components: jena Affects Versions: 0.6.0 Environment: $ mvn -version Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /usr/local/Cellar/maven/3.6.3/libexec Java version: 11.0.10, vendor: AdoptOpenJDK, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home Default locale: en_GB, platform encoding: UTF-8 OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac" (My Mac UI reports version 11.2.3) Reporter: Marco Brandizi I'm trying the [current Jena snapshot|https://repository.apache.org/content/groups/snapshots/org/apache/jena/apache-jena-libs/4.1.0-SNAPSHOT/] with a project of mine, I need the latest snapshot due to this bug. My project uses commonsrdf-jena and I found that version 0.5.0 has a couple of Jena's method invocations and class references that were removed from the current code base. [This|https://github.com/marco-brandizi/commons-rdf/commit/d51ba56dd42541d81b8df7e43b39f9df8d088386] is a fix for it. I don't think I can send in a pull request, since I had a lot of problems with making the fork working with Java 11, including some failing plugins like Javadoc or japicmp. Manual copy-pasting of my changes from .java files should be easier to do. I hope this project is still alive and this issue will be addressed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TEXT-200) Simplify statements
[ https://issues.apache.org/jira/browse/TEXT-200?focusedWorklogId=584758=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584758 ] ASF GitHub Bot logged work on TEXT-200: --- Author: ASF GitHub Bot Created on: 18/Apr/21 10:59 Start Date: 18/Apr/21 10:59 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #222: URL: https://github.com/apache/commons-text/pull/222#issuecomment-821973057 [](https://coveralls.io/builds/38911181) Coverage decreased (-0.001%) to 97.983% when pulling **3db666e47536bd28b2e172c6d8b3632b2b7eb482 on arturobernalg:feature/TEXT-200** into **a55195ee787b7065c9799bde421acf5fd8526621 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584758) Time Spent: 20m (was: 10m) > Simplify statements > --- > > Key: TEXT-200 > URL: https://issues.apache.org/jira/browse/TEXT-200 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] coveralls commented on pull request #222: TEXT-200 - Simplify statements
coveralls commented on pull request #222: URL: https://github.com/apache/commons-text/pull/222#issuecomment-821973057 [](https://coveralls.io/builds/38911181) Coverage decreased (-0.001%) to 97.983% when pulling **3db666e47536bd28b2e172c6d8b3632b2b7eb482 on arturobernalg:feature/TEXT-200** into **a55195ee787b7065c9799bde421acf5fd8526621 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-199) Remove redundant local variable
[ https://issues.apache.org/jira/browse/TEXT-199?focusedWorklogId=584757=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584757 ] ASF GitHub Bot logged work on TEXT-199: --- Author: ASF GitHub Bot Created on: 18/Apr/21 10:57 Start Date: 18/Apr/21 10:57 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #221: URL: https://github.com/apache/commons-text/pull/221#issuecomment-821972898 [](https://coveralls.io/builds/38911166) Coverage decreased (-0.001%) to 97.983% when pulling **0db3360b7b2b4ad61bb3085d2a94a8ca03e4dbb8 on arturobernalg:feature/TEXT-199** into **a55195ee787b7065c9799bde421acf5fd8526621 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584757) Time Spent: 20m (was: 10m) > Remove redundant local variable > --- > > Key: TEXT-199 > URL: https://issues.apache.org/jira/browse/TEXT-199 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] coveralls commented on pull request #221: TEXT-199 - Remove redundant local variable
coveralls commented on pull request #221: URL: https://github.com/apache/commons-text/pull/221#issuecomment-821972898 [](https://coveralls.io/builds/38911166) Coverage decreased (-0.001%) to 97.983% when pulling **0db3360b7b2b4ad61bb3085d2a94a8ca03e4dbb8 on arturobernalg:feature/TEXT-199** into **a55195ee787b7065c9799bde421acf5fd8526621 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-200) Simplify statements
[ https://issues.apache.org/jira/browse/TEXT-200?focusedWorklogId=584756=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584756 ] ASF GitHub Bot logged work on TEXT-200: --- Author: ASF GitHub Bot Created on: 18/Apr/21 10:55 Start Date: 18/Apr/21 10:55 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #222: URL: https://github.com/apache/commons-text/pull/222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584756) Remaining Estimate: 0h Time Spent: 10m > Simplify statements > --- > > Key: TEXT-200 > URL: https://issues.apache.org/jira/browse/TEXT-200 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] arturobernalg opened a new pull request #222: TEXT-200 - Simplify statements
arturobernalg opened a new pull request #222: URL: https://github.com/apache/commons-text/pull/222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-198) Replace lambda with method reference
[ https://issues.apache.org/jira/browse/TEXT-198?focusedWorklogId=584755=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584755 ] ASF GitHub Bot logged work on TEXT-198: --- Author: ASF GitHub Bot Created on: 18/Apr/21 10:53 Start Date: 18/Apr/21 10:53 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #220: URL: https://github.com/apache/commons-text/pull/220#issuecomment-821972409 [](https://coveralls.io/builds/38911144) Coverage remained the same at 97.985% when pulling **fafd548f9429dd573898b380240f70ebb2132a39 on arturobernalg:feature/TEXT-198** into **a55195ee787b7065c9799bde421acf5fd8526621 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584755) Time Spent: 20m (was: 10m) > Replace lambda with method reference > > > Key: TEXT-198 > URL: https://issues.apache.org/jira/browse/TEXT-198 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TEXT-200) Simplify statements
Arturo Bernal created TEXT-200: -- Summary: Simplify statements Key: TEXT-200 URL: https://issues.apache.org/jira/browse/TEXT-200 Project: Commons Text Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] coveralls commented on pull request #220: TEXT-198 - Replace lambda with method reference
coveralls commented on pull request #220: URL: https://github.com/apache/commons-text/pull/220#issuecomment-821972409 [](https://coveralls.io/builds/38911144) Coverage remained the same at 97.985% when pulling **fafd548f9429dd573898b380240f70ebb2132a39 on arturobernalg:feature/TEXT-198** into **a55195ee787b7065c9799bde421acf5fd8526621 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-199) Remove redundant local variable
[ https://issues.apache.org/jira/browse/TEXT-199?focusedWorklogId=584753=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584753 ] ASF GitHub Bot logged work on TEXT-199: --- Author: ASF GitHub Bot Created on: 18/Apr/21 10:52 Start Date: 18/Apr/21 10:52 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #221: URL: https://github.com/apache/commons-text/pull/221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584753) Remaining Estimate: 0h Time Spent: 10m > Remove redundant local variable > --- > > Key: TEXT-199 > URL: https://issues.apache.org/jira/browse/TEXT-199 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] arturobernalg opened a new pull request #221: TEXT-199 - Remove redundant local variable
arturobernalg opened a new pull request #221: URL: https://github.com/apache/commons-text/pull/221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (TEXT-199) Remove redundant local variable
Arturo Bernal created TEXT-199: -- Summary: Remove redundant local variable Key: TEXT-199 URL: https://issues.apache.org/jira/browse/TEXT-199 Project: Commons Text Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TEXT-198) Replace lambda with method reference
[ https://issues.apache.org/jira/browse/TEXT-198?focusedWorklogId=584751=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584751 ] ASF GitHub Bot logged work on TEXT-198: --- Author: ASF GitHub Bot Created on: 18/Apr/21 10:49 Start Date: 18/Apr/21 10:49 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #220: URL: https://github.com/apache/commons-text/pull/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584751) Remaining Estimate: 0h Time Spent: 10m > Replace lambda with method reference > > > Key: TEXT-198 > URL: https://issues.apache.org/jira/browse/TEXT-198 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] arturobernalg opened a new pull request #220: TEXT-198 - Replace lambda with method reference
arturobernalg opened a new pull request #220: URL: https://github.com/apache/commons-text/pull/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (TEXT-198) Replace lambda with method reference
Arturo Bernal created TEXT-198: -- Summary: Replace lambda with method reference Key: TEXT-198 URL: https://issues.apache.org/jira/browse/TEXT-198 Project: Commons Text Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TEXT-197) Replace statement lambda with expression lambda
[ https://issues.apache.org/jira/browse/TEXT-197?focusedWorklogId=584747=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584747 ] ASF GitHub Bot logged work on TEXT-197: --- Author: ASF GitHub Bot Created on: 18/Apr/21 10:46 Start Date: 18/Apr/21 10:46 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #219: URL: https://github.com/apache/commons-text/pull/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 584747) Remaining Estimate: 0h Time Spent: 10m > Replace statement lambda with expression lambda > --- > > Key: TEXT-197 > URL: https://issues.apache.org/jira/browse/TEXT-197 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Change code block bodies with expression-style bodies -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] arturobernalg opened a new pull request #219: TEXT-197 - Replace statement lambda with expression lambda
arturobernalg opened a new pull request #219: URL: https://github.com/apache/commons-text/pull/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (TEXT-197) Replace statement lambda with expression lambda
[ https://issues.apache.org/jira/browse/TEXT-197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated TEXT-197: --- Description: Change code block bodies with expression-style bodies > Replace statement lambda with expression lambda > --- > > Key: TEXT-197 > URL: https://issues.apache.org/jira/browse/TEXT-197 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > > Change code block bodies with expression-style bodies -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEXT-197) Replace statement lambda with expression lambda
[ https://issues.apache.org/jira/browse/TEXT-197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated TEXT-197: --- Summary: Replace statement lambda with expression lambda (was: Replace with expression lambda) > Replace statement lambda with expression lambda > --- > > Key: TEXT-197 > URL: https://issues.apache.org/jira/browse/TEXT-197 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEXT-197) Replace with expression lambda
[ https://issues.apache.org/jira/browse/TEXT-197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated TEXT-197: --- Summary: Replace with expression lambda (was: java8 lambda improvements) > Replace with expression lambda > -- > > Key: TEXT-197 > URL: https://issues.apache.org/jira/browse/TEXT-197 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TEXT-196) Minor improvements
Arturo Bernal created TEXT-196: -- Summary: Minor improvements Key: TEXT-196 URL: https://issues.apache.org/jira/browse/TEXT-196 Project: Commons Text Issue Type: Improvement Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TEXT-197) java8 lambda improvements
Arturo Bernal created TEXT-197: -- Summary: java8 lambda improvements Key: TEXT-197 URL: https://issues.apache.org/jira/browse/TEXT-197 Project: Commons Text Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (COMPRESS-574) Byte range support in archive creation
[ https://issues.apache.org/jira/browse/COMPRESS-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324467#comment-17324467 ] Gaël Lalire commented on COMPRESS-574: -- _> We can avoid creating a file, by creating the zip in memory_ Yes but I mentioned in the description that _if you need an InputStream things get a lot harder_. I did not enter in the details, maybe you can get it to work with PipedIS & PipedOS or your own rolling buffer at the cost of one additional thread. Anyway I did not go that way because of very poor resuming (byte range) behavior of this solution. > _With closeArchiveEntry() called ..._ Yes with the hard solution before, this problem is solved. Again byte range support is poor hence my ticket name. > Byte range support in archive creation > -- > > Key: COMPRESS-574 > URL: https://issues.apache.org/jira/browse/COMPRESS-574 > Project: Commons Compress > Issue Type: Improvement > Components: Archivers >Reporter: Gaël Lalire >Priority: Minor > Attachments: DynamicZip.java, DynamicZipTest.java > > > When you have a ZIP which contains _N_ components and you want to let the > user choose which components it needs, you need to create _2^N - 1_ ZIP. > So the idea is to store each component once (or twice if you want both > deflated and stored version), and create the ZIP on the fly. > For the moment you can stream with a ZipOutputStream but if you need an > InputStream things get a lot harder. I guess programs are writing the ZIP to > a file system and read from it after, so not really a streaming anymore. > Also ZipOutputStream will never allow you to resume from a byte range, you > need to generate all previous data. > So I made a class to do that, I think such functionality has its place in > commons compress. > You can see my code attached and adapt it for better integration / other > archive type support or simply to get inspired. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-jcs] tvand merged pull request #63: JCS-221 - Fix typo
tvand merged pull request #63: URL: https://github.com/apache/commons-jcs/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] tvand commented on a change in pull request #62: JCS-220 - Java8 improvement
tvand commented on a change in pull request #62:
URL: https://github.com/apache/commons-jcs/pull/62#discussion_r615372186
##
File path:
commons-jcs-core/src/main/java/org/apache/commons/jcs3/auxiliary/disk/indexed/IndexedDiskCache.java
##
@@ -1259,7 +1259,7 @@ private long defragFile(final
IndexedDiskElementDescriptor[] defragList, final l
private IndexedDiskElementDescriptor[] createPositionSortedDescriptorList()
{
final List defragList = new
ArrayList<>(keyHash.values());
-Collections.sort(defragList, (ded1, ded2) -> Long.compare(ded1.pos,
ded2.pos));
+Collections.sort(defragList, Comparator.comparingLong(ded -> ded.pos));
Review comment:
Don't you think the previous version is easier to understand?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-jcs] tvand merged pull request #60: JCS-218 - Redundant operation:
tvand merged pull request #60: URL: https://github.com/apache/commons-jcs/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] tvand merged pull request #59: Bump actions/cache from v2.1.4 to v2.1.5
tvand merged pull request #59: URL: https://github.com/apache/commons-jcs/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-logging] arturobernalg opened a new pull request #48: LOGGING-179 - Redundant type cast and boxing
arturobernalg opened a new pull request #48: URL: https://github.com/apache/commons-logging/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LOGGING-179) Redundant type cast and boxing
Arturo Bernal created LOGGING-179: - Summary: Redundant type cast and boxing Key: LOGGING-179 URL: https://issues.apache.org/jira/browse/LOGGING-179 Project: Commons Logging Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-logging] arturobernalg opened a new pull request #47: LOGGING-178 - Use final variables
arturobernalg opened a new pull request #47: URL: https://github.com/apache/commons-logging/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LOGGING-178) Use final variables
Arturo Bernal created LOGGING-178: - Summary: Use final variables Key: LOGGING-178 URL: https://issues.apache.org/jira/browse/LOGGING-178 Project: Commons Logging Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-logging] arturobernalg opened a new pull request #46: LOGGING-177 - Remove redundant initializer
arturobernalg opened a new pull request #46: URL: https://github.com/apache/commons-logging/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-logging] arturobernalg commented on pull request #45: LOGGING-176 - Replace construction of FileOutputStream objects with Files NIO APIs.
arturobernalg commented on pull request #45: URL: https://github.com/apache/commons-logging/pull/45#issuecomment-821946765 Won't fix because toPaht it's from @since 1.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-logging] arturobernalg closed pull request #45: LOGGING-176 - Replace construction of FileOutputStream objects with Files NIO APIs.
arturobernalg closed pull request #45: URL: https://github.com/apache/commons-logging/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (LOGGING-176) Replace construction of FileOutputStream objects with Files NIO APIs.
[ https://issues.apache.org/jira/browse/LOGGING-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed LOGGING-176. - Resolution: Won't Fix Won't fix because toPaht it's from @since 1.7 > Replace construction of FileOutputStream objects with Files NIO APIs. > -- > > Key: LOGGING-176 > URL: https://issues.apache.org/jira/browse/LOGGING-176 > Project: Commons Logging > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LOGGING-177) Remove redundant initializer
Arturo Bernal created LOGGING-177: - Summary: Remove redundant initializer Key: LOGGING-177 URL: https://issues.apache.org/jira/browse/LOGGING-177 Project: Commons Logging Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-logging] arturobernalg opened a new pull request #45: LOGGING-176 - Replace construction of FileOutputStream objects with Files NIO APIs.
arturobernalg opened a new pull request #45: URL: https://github.com/apache/commons-logging/pull/45 …iles NIO APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LOGGING-176) Replace construction of FileOutputStream objects with Files NIO APIs.
Arturo Bernal created LOGGING-176: - Summary: Replace construction of FileOutputStream objects with Files NIO APIs. Key: LOGGING-176 URL: https://issues.apache.org/jira/browse/LOGGING-176 Project: Commons Logging Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-logging] arturobernalg opened a new pull request #44: LOGGING-175 - Change Deprecated API usage
arturobernalg opened a new pull request #44: URL: https://github.com/apache/commons-logging/pull/44 Change deprecated File.toURL and use `new File(filename).toURI().toURL(); ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LOGGING-175) Change Deprecated API usage
Arturo Bernal created LOGGING-175:
-
Summary: Change Deprecated API usage
Key: LOGGING-175
URL: https://issues.apache.org/jira/browse/LOGGING-175
Project: Commons Logging
Issue Type: Sub-task
Reporter: Arturo Bernal
Change deprecated File.toURL and use
{code:java}
new File(filename).toURI().toURL();
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (LOGGING-174) Minor improvements
[ https://issues.apache.org/jira/browse/LOGGING-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated LOGGING-174: -- Affects Version/s: 1.2.1 > Minor improvements > -- > > Key: LOGGING-174 > URL: https://issues.apache.org/jira/browse/LOGGING-174 > Project: Commons Logging > Issue Type: Improvement >Affects Versions: 1.2.1 >Reporter: Arturo Bernal >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LOGGING-174) Minor improvements
Arturo Bernal created LOGGING-174: - Summary: Minor improvements Key: LOGGING-174 URL: https://issues.apache.org/jira/browse/LOGGING-174 Project: Commons Logging Issue Type: Improvement Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
