[GitHub] [commons-text] coveralls commented on pull request #227: Bump graalvm.version from 21.0.0.2 to 21.1.0
coveralls commented on pull request #227: URL: https://github.com/apache/commons-text/pull/227#issuecomment-823785595 [](https://coveralls.io/builds/38994827) Coverage remained the same at 97.982% when pulling **65a1693a44ee74f60481ea828db3183d1c0a82b1 on dependabot/maven/graalvm.version-21.1.0** into **857a3ed9eeda0b197ebe57035d7de52cdf551b60 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-792) Minor Performances improvements
[ https://issues.apache.org/jira/browse/COLLECTIONS-792?focusedWorklogId=586335=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586335 ] ASF GitHub Bot logged work on COLLECTIONS-792: -- Author: ASF GitHub Bot Created on: 21/Apr/21 05:24 Start Date: 21/Apr/21 05:24 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #232: URL: https://github.com/apache/commons-collections/pull/232#issuecomment-823785031 [](https://coveralls.io/builds/38994766) Coverage decreased (-0.03%) to 90.112% when pulling **471e34ecffe9968295c1b50df8942ef3fe4b0e2a on arturobernalg:feature/COLLECTIONS-792** into **e1f23b035d7caeab8333e8df6739eb143b64affb on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586335) Time Spent: 0.5h (was: 20m) > Minor Performances improvements > --- > > Key: COLLECTIONS-792 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-792 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > * Use bulk operations > * Use Collections.singletonList > * Simplify Class comparator -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] coveralls edited a comment on pull request #232: COLLECTIONS-792 - Minor Performances improvements
coveralls edited a comment on pull request #232: URL: https://github.com/apache/commons-collections/pull/232#issuecomment-823785031 [](https://coveralls.io/builds/38994766) Coverage decreased (-0.03%) to 90.112% when pulling **471e34ecffe9968295c1b50df8942ef3fe4b0e2a on arturobernalg:feature/COLLECTIONS-792** into **e1f23b035d7caeab8333e8df6739eb143b64affb on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-792) Minor Performances improvements
[ https://issues.apache.org/jira/browse/COLLECTIONS-792?focusedWorklogId=586333=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586333 ] ASF GitHub Bot logged work on COLLECTIONS-792: -- Author: ASF GitHub Bot Created on: 21/Apr/21 05:23 Start Date: 21/Apr/21 05:23 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #232: URL: https://github.com/apache/commons-collections/pull/232#issuecomment-823785031 [](https://coveralls.io/builds/38994735) Coverage decreased (-0.03%) to 90.112% when pulling **471e34ecffe9968295c1b50df8942ef3fe4b0e2a on arturobernalg:feature/COLLECTIONS-792** into **e1f23b035d7caeab8333e8df6739eb143b64affb on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586333) Time Spent: 20m (was: 10m) > Minor Performances improvements > --- > > Key: COLLECTIONS-792 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-792 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > * Use bulk operations > * Use Collections.singletonList > * Simplify Class comparator -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] coveralls commented on pull request #232: COLLECTIONS-792 - Minor Performances improvements
coveralls commented on pull request #232: URL: https://github.com/apache/commons-collections/pull/232#issuecomment-823785031 [](https://coveralls.io/builds/38994735) Coverage decreased (-0.03%) to 90.112% when pulling **471e34ecffe9968295c1b50df8942ef3fe4b0e2a on arturobernalg:feature/COLLECTIONS-792** into **e1f23b035d7caeab8333e8df6739eb143b64affb on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request #227: Bump graalvm.version from 21.0.0.2 to 21.1.0
dependabot[bot] opened a new pull request #227:
URL: https://github.com/apache/commons-text/pull/227
Bumps `graalvm.version` from 21.0.0.2 to 21.1.0.
Updates `js` from 21.0.0.2 to 21.1.0
Release notes
Sourced from https://github.com/graalvm/graaljs/releases;>js's releases.
GraalJS - GraalVM Community Edition 21.1.0
GraalVM provides an ECMAScript-compliant runtime to execute JavaScript
and Node.js applications.
It is fully standard compliant, execute applications with high performance,
and provide all benefits from the GraalVM stack, including language
interoperability and common tooling.
More information is available on the GraalVM website:
http://www.graalvm.org/docs/reference-manual/js/;>http://www.graalvm.org/docs/reference-manual/js/
Changelog
Sourced from https://github.com/oracle/graaljs/blob/master/CHANGELOG.md;>js's
changelog.
Version 21.1.0
Updated Node.js to version 14.16.1.
Prototype of WebAssembly JavaScript Interface implemented. It is
available behind the --js.webassembly flag.
Implemented iterator interop support, enabling foreign objects that have
an iterator to be used where JS expects iterables, as well as JS iterables to
be used in other languages and via the https://www.graalvm.org/sdk/javadoc/org/graalvm/polyglot/Value.html#getIterator--;>Value
API.
Adopted new buffer interop support, allowing foreign buffers to be used
with typed arrays and DataView, without copying. Likewise enables
ArrayBuffer to be used in other languages.
Experimental option js.array-sort-inherited was removed.
Values visible through holes in array(-like) object are always sorted according
to the latest version of ECMAScript specification.
Updated ICU4J library to version 68.2.
Implemented the https://github.com/tc39/proposal-atomics-wait-async;>Atomics.waitAsync
proposal. It is available in ECMAScript 2022 mode
(--js.ecmascript-version=2022).
Implemented hash map interop support. Allows foreign hash maps to be
iterated using for in/of loops, new Map(hash),
Array.from(hash), etc. If the
--js.foreign-hash-properties option is enabled (default), foreign
hash maps can also be accessed using hash[key],
hash.key, and used in {...hash}. If the
--js.foreign-object-prototype option is enabled, foreign hash maps
also have Map.prototype methods.
Moved GraalVM-Node.js to a separate installable component. In a GraalVM
distribution it needs to be manually installed with $GRAALVM/bin/gu
install nodejs.
Version 21.0.0
ECMAScript 2021 mode/features enabled by default.
Updated Node.js to version 12.20.1.
Adopted new interop exception handling and made JS exceptions extend
AbstractTruffleException.
Implemented interop identity messages.
Expose Graal.versionECMAScript instead of
Graal.versionJS.
Implemented the https://tc39.es/proposal-relative-indexing-method/;>relative indexing
method proposal. It is available in ECMAScript 2022 mode
(--js.ecmascript-version=2022).
Version 20.3.0
Updated Node.js to version 12.18.4.
Fixed field/getter/setter access order in nashorn-compat mode, see
[issue https://github-redirect.dependabot.com/graalvm/graaljs/issues/343;>#343](https://github-redirect.dependabot.com/graalvm/graaljs/issues/343;>graalvm/graaljs#343).
ScriptEngine: Fixed Multiple applicable overloads found
error in nashorn-compat mode, see [issue https://github-redirect.dependabot.com/graalvm/graaljs/issues/286;>#286](https://github-redirect.dependabot.com/graalvm/graaljs/issues/286;>graalvm/graaljs#286).
ScriptEngine: Enabled low precedence lossy number, string-to-boolean,
and number-to-boolean conversions in nashorn-compat mode.
Fixed Java.extend to respect
HostAccess.Builder.allowImplementations, see [issue https://github-redirect.dependabot.com/graalvm/graaljs/issues/294;>#294](https://github-redirect.dependabot.com/graalvm/graaljs/issues/294;>graalvm/graaljs#294).
Added Java host interop support for mapping JS objects to abstract
classes (if HostAccess allows it).
js.foreign-object-prototype is a supported option to set
JavaScript prototypes for foreign objects mimicing JavaScript types. It was
renamed from js.experimental-foreign-object-prototype.
Changed ToPrimitive abstract operation to follow the
specification for foreign objects. InteropLibrary.toDisplayString
is not used by ToPrimitive/ToString conversions anymore.
Version 20.2.0
Implemented the https://github.com/tc39/proposal-unified-intl-numberformat;>Intl.NumberFormat
Unified API proposal.
Implemented the https://github.com/tc39/proposal-logical-assignment;>Logical Assignment
Operators proposal.
Implemented the https://github.com/tc39/proposal-top-level-await;>Top-level Await
proposal.
Implemented the https://github.com/tc39/proposal-promise-any;>Promise.any proposal.
It is available in ECMAScript 2021 mode
(--js.ecmascript-version=2021).
[jira] [Work logged] (COLLECTIONS-793) Simplify Assertion
[ https://issues.apache.org/jira/browse/COLLECTIONS-793?focusedWorklogId=586330=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586330 ] ASF GitHub Bot logged work on COLLECTIONS-793: -- Author: ASF GitHub Bot Created on: 21/Apr/21 05:15 Start Date: 21/Apr/21 05:15 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #233: URL: https://github.com/apache/commons-collections/pull/233#issuecomment-823782136 [](https://coveralls.io/builds/38994555) Coverage decreased (-0.03%) to 90.112% when pulling **47d0a5107a8937245b3bb5c0b9e20b7ddaa3e6ef on arturobernalg:feature/COLLECTIONS-793** into **e1f23b035d7caeab8333e8df6739eb143b64affb on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586330) Time Spent: 20m (was: 10m) > Simplify Assertion > -- > > Key: COLLECTIONS-793 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-793 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] coveralls commented on pull request #233: COLLECTIONS-793 - Simplify Assertion
coveralls commented on pull request #233: URL: https://github.com/apache/commons-collections/pull/233#issuecomment-823782136 [](https://coveralls.io/builds/38994555) Coverage decreased (-0.03%) to 90.112% when pulling **47d0a5107a8937245b3bb5c0b9e20b7ddaa3e6ef on arturobernalg:feature/COLLECTIONS-793** into **e1f23b035d7caeab8333e8df6739eb143b64affb on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-793) Simplify Assertion
[ https://issues.apache.org/jira/browse/COLLECTIONS-793?focusedWorklogId=586325=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586325 ] ASF GitHub Bot logged work on COLLECTIONS-793: -- Author: ASF GitHub Bot Created on: 21/Apr/21 05:09 Start Date: 21/Apr/21 05:09 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #233: URL: https://github.com/apache/commons-collections/pull/233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586325) Remaining Estimate: 0h Time Spent: 10m > Simplify Assertion > -- > > Key: COLLECTIONS-793 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-793 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] arturobernalg opened a new pull request #233: COLLECTIONS-793 - Simplify Assertion
arturobernalg opened a new pull request #233: URL: https://github.com/apache/commons-collections/pull/233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COLLECTIONS-793) Simplify Assertion
Arturo Bernal created COLLECTIONS-793: - Summary: Simplify Assertion Key: COLLECTIONS-793 URL: https://issues.apache.org/jira/browse/COLLECTIONS-793 Project: Commons Collections Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COLLECTIONS-792) Minor Performances improvements
[ https://issues.apache.org/jira/browse/COLLECTIONS-792?focusedWorklogId=586322=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586322 ] ASF GitHub Bot logged work on COLLECTIONS-792: -- Author: ASF GitHub Bot Created on: 21/Apr/21 04:54 Start Date: 21/Apr/21 04:54 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #232: URL: https://github.com/apache/commons-collections/pull/232 * Use bulk operations * Use Collections.singletonList * Simplify Class comparator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586322) Remaining Estimate: 0h Time Spent: 10m > Minor Performances improvements > --- > > Key: COLLECTIONS-792 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-792 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > * Use bulk operations > * Use Collections.singletonList > * Simplify Class comparator -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] arturobernalg opened a new pull request #232: COLLECTIONS-792 - Minor Performances improvements
arturobernalg opened a new pull request #232: URL: https://github.com/apache/commons-collections/pull/232 * Use bulk operations * Use Collections.singletonList * Simplify Class comparator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-791) Simplify boolean expressions
[ https://issues.apache.org/jira/browse/COLLECTIONS-791?focusedWorklogId=586321=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586321 ] ASF GitHub Bot logged work on COLLECTIONS-791: -- Author: ASF GitHub Bot Created on: 21/Apr/21 04:53 Start Date: 21/Apr/21 04:53 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #231: URL: https://github.com/apache/commons-collections/pull/231#issuecomment-823774937 [](https://coveralls.io/builds/38994253) Coverage remained the same at 90.142% when pulling **84fa7ecffb72f8d575e0372ecf6b8a8125bab0cb on arturobernalg:feature/COLLECTIONS-791** into **e1f23b035d7caeab8333e8df6739eb143b64affb on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586321) Time Spent: 20m (was: 10m) > Simplify boolean expressions > > > Key: COLLECTIONS-791 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-791 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COLLECTIONS-792) Minor Performances improvements
Arturo Bernal created COLLECTIONS-792: - Summary: Minor Performances improvements Key: COLLECTIONS-792 URL: https://issues.apache.org/jira/browse/COLLECTIONS-792 Project: Commons Collections Issue Type: Sub-task Reporter: Arturo Bernal * Use bulk operations * Use Collections.singletonList * Simplify Class comparator -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] coveralls commented on pull request #231: COLLECTIONS-791 - Simplify boolean expressions
coveralls commented on pull request #231: URL: https://github.com/apache/commons-collections/pull/231#issuecomment-823774937 [](https://coveralls.io/builds/38994253) Coverage remained the same at 90.142% when pulling **84fa7ecffb72f8d575e0372ecf6b8a8125bab0cb on arturobernalg:feature/COLLECTIONS-791** into **e1f23b035d7caeab8333e8df6739eb143b64affb on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-789) Redundant 'if' statement
[ https://issues.apache.org/jira/browse/COLLECTIONS-789?focusedWorklogId=586319=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586319 ] ASF GitHub Bot logged work on COLLECTIONS-789: -- Author: ASF GitHub Bot Created on: 21/Apr/21 04:52 Start Date: 21/Apr/21 04:52 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #229: URL: https://github.com/apache/commons-collections/pull/229#issuecomment-823774649 [](https://coveralls.io/builds/38994224) Coverage decreased (-0.03%) to 90.109% when pulling **3bba0a40cdcf3df93ff5ff0ae78af4bf7a18a7a7 on arturobernalg:feature/COLLECTIONS-789** into **e1f23b035d7caeab8333e8df6739eb143b64affb on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586319) Time Spent: 20m (was: 10m) > Redundant 'if' statement > > > Key: COLLECTIONS-789 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-789 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Simplified to a single return statement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COLLECTIONS-790) Simplify conditional expression
[ https://issues.apache.org/jira/browse/COLLECTIONS-790?focusedWorklogId=586320=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586320 ] ASF GitHub Bot logged work on COLLECTIONS-790: -- Author: ASF GitHub Bot Created on: 21/Apr/21 04:52 Start Date: 21/Apr/21 04:52 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #230: URL: https://github.com/apache/commons-collections/pull/230#issuecomment-823774695 [](https://coveralls.io/builds/38994244) Coverage decreased (-0.03%) to 90.112% when pulling **e289efb9cced10839be197fd9defb19b6d9d329c on arturobernalg:feature/COLLECTIONS-790** into **e1f23b035d7caeab8333e8df6739eb143b64affb on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586320) Time Spent: 20m (was: 10m) > Simplify conditional expression > --- > > Key: COLLECTIONS-790 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-790 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] coveralls commented on pull request #230: COLLECTIONS-790 - Simplify conditional expression
coveralls commented on pull request #230: URL: https://github.com/apache/commons-collections/pull/230#issuecomment-823774695 [](https://coveralls.io/builds/38994244) Coverage decreased (-0.03%) to 90.112% when pulling **e289efb9cced10839be197fd9defb19b6d9d329c on arturobernalg:feature/COLLECTIONS-790** into **e1f23b035d7caeab8333e8df6739eb143b64affb on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] coveralls commented on pull request #229: COLLECTIONS-789 - Redundant 'if' statement
coveralls commented on pull request #229: URL: https://github.com/apache/commons-collections/pull/229#issuecomment-823774649 [](https://coveralls.io/builds/38994224) Coverage decreased (-0.03%) to 90.109% when pulling **3bba0a40cdcf3df93ff5ff0ae78af4bf7a18a7a7 on arturobernalg:feature/COLLECTIONS-789** into **e1f23b035d7caeab8333e8df6739eb143b64affb on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-791) Simplify boolean expressions
[ https://issues.apache.org/jira/browse/COLLECTIONS-791?focusedWorklogId=586316=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586316 ] ASF GitHub Bot logged work on COLLECTIONS-791: -- Author: ASF GitHub Bot Created on: 21/Apr/21 04:47 Start Date: 21/Apr/21 04:47 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #231: URL: https://github.com/apache/commons-collections/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586316) Remaining Estimate: 0h Time Spent: 10m > Simplify boolean expressions > > > Key: COLLECTIONS-791 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-791 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] arturobernalg opened a new pull request #231: COLLECTIONS-791 - Simplify boolean expressions
arturobernalg opened a new pull request #231: URL: https://github.com/apache/commons-collections/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COLLECTIONS-791) Simplify boolean expressions
Arturo Bernal created COLLECTIONS-791: - Summary: Simplify boolean expressions Key: COLLECTIONS-791 URL: https://issues.apache.org/jira/browse/COLLECTIONS-791 Project: Commons Collections Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COLLECTIONS-790) Simplify conditional expression
[ https://issues.apache.org/jira/browse/COLLECTIONS-790?focusedWorklogId=586315=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586315 ] ASF GitHub Bot logged work on COLLECTIONS-790: -- Author: ASF GitHub Bot Created on: 21/Apr/21 04:45 Start Date: 21/Apr/21 04:45 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #230: URL: https://github.com/apache/commons-collections/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586315) Remaining Estimate: 0h Time Spent: 10m > Simplify conditional expression > --- > > Key: COLLECTIONS-790 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-790 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] arturobernalg opened a new pull request #230: COLLECTIONS-790 - Simplify conditional expression
arturobernalg opened a new pull request #230: URL: https://github.com/apache/commons-collections/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (COLLECTIONS-790) Simplify conditional expression
[ https://issues.apache.org/jira/browse/COLLECTIONS-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated COLLECTIONS-790: -- Summary: Simplify conditional expression (was: Simplifiable conditional expression) > Simplify conditional expression > --- > > Key: COLLECTIONS-790 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-790 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COLLECTIONS-790) Simplifiable conditional expression
Arturo Bernal created COLLECTIONS-790: - Summary: Simplifiable conditional expression Key: COLLECTIONS-790 URL: https://issues.apache.org/jira/browse/COLLECTIONS-790 Project: Commons Collections Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COLLECTIONS-789) Redundant 'if' statement
[ https://issues.apache.org/jira/browse/COLLECTIONS-789?focusedWorklogId=586312=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586312 ] ASF GitHub Bot logged work on COLLECTIONS-789: -- Author: ASF GitHub Bot Created on: 21/Apr/21 04:40 Start Date: 21/Apr/21 04:40 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #229: URL: https://github.com/apache/commons-collections/pull/229 * Simplified to a single return statement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586312) Remaining Estimate: 0h Time Spent: 10m > Redundant 'if' statement > > > Key: COLLECTIONS-789 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-789 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Simplified to a single return statement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] arturobernalg opened a new pull request #229: COLLECTIONS-789 - Redundant 'if' statement
arturobernalg opened a new pull request #229: URL: https://github.com/apache/commons-collections/pull/229 * Simplified to a single return statement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COLLECTIONS-789) Redundant 'if' statement
Arturo Bernal created COLLECTIONS-789: - Summary: Redundant 'if' statement Key: COLLECTIONS-789 URL: https://issues.apache.org/jira/browse/COLLECTIONS-789 Project: Commons Collections Issue Type: Sub-task Reporter: Arturo Bernal Simplified to a single return statement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COLLECTIONS-788) java8 improvements
[ https://issues.apache.org/jira/browse/COLLECTIONS-788?focusedWorklogId=586310=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586310 ] ASF GitHub Bot logged work on COLLECTIONS-788: -- Author: ASF GitHub Bot Created on: 21/Apr/21 04:37 Start Date: 21/Apr/21 04:37 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #228: URL: https://github.com/apache/commons-collections/pull/228 - Replace Collections.sort() with List.sort() - Replace lambda with method reference - Replace Loop with Collection.removeIf() - Use lambda -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586310) Time Spent: 20m (was: 10m) > java8 improvements > -- > > Key: COLLECTIONS-788 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-788 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > * Replace Collections.sort() with List.sort() > * Replace lambda with method reference > * Replace Loop with Collection.removeIf() > * Use lambda -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] arturobernalg opened a new pull request #228: COLLECTIONS-788 - java8 improvements
arturobernalg opened a new pull request #228: URL: https://github.com/apache/commons-collections/pull/228 - Replace Collections.sort() with List.sort() - Replace lambda with method reference - Replace Loop with Collection.removeIf() - Use lambda -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-202) Extract duplicate code
[ https://issues.apache.org/jira/browse/TEXT-202?focusedWorklogId=586308=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586308 ] ASF GitHub Bot logged work on TEXT-202: --- Author: ASF GitHub Bot Created on: 21/Apr/21 04:32 Start Date: 21/Apr/21 04:32 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #225: URL: https://github.com/apache/commons-text/pull/225#issuecomment-823001272 [](https://coveralls.io/builds/38994005) Coverage decreased (-0.002%) to 97.979% when pulling **5a793fdde5e5e83fb9a02f8108017baaa8e945b3 on arturobernalg:feature/TEXT-202** into **857a3ed9eeda0b197ebe57035d7de52cdf551b60 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586308) Time Spent: 2h (was: 1h 50m) > Extract duplicate code > -- > > Key: TEXT-202 > URL: https://issues.apache.org/jira/browse/TEXT-202 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Extract duplicate code in conditions and reused -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] coveralls edited a comment on pull request #225: TEXT-202 - Extract duplicate code
coveralls edited a comment on pull request #225: URL: https://github.com/apache/commons-text/pull/225#issuecomment-823001272 [](https://coveralls.io/builds/38994005) Coverage decreased (-0.002%) to 97.979% when pulling **5a793fdde5e5e83fb9a02f8108017baaa8e945b3 on arturobernalg:feature/TEXT-202** into **857a3ed9eeda0b197ebe57035d7de52cdf551b60 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-202) Extract duplicate code
[ https://issues.apache.org/jira/browse/TEXT-202?focusedWorklogId=586307=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586307 ] ASF GitHub Bot logged work on TEXT-202: --- Author: ASF GitHub Bot Created on: 21/Apr/21 04:29 Start Date: 21/Apr/21 04:29 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #225: URL: https://github.com/apache/commons-text/pull/225#issuecomment-823001272 [](https://coveralls.io/builds/38993996) Coverage decreased (-0.002%) to 97.979% when pulling **5a793fdde5e5e83fb9a02f8108017baaa8e945b3 on arturobernalg:feature/TEXT-202** into **857a3ed9eeda0b197ebe57035d7de52cdf551b60 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586307) Time Spent: 1h 50m (was: 1h 40m) > Extract duplicate code > -- > > Key: TEXT-202 > URL: https://issues.apache.org/jira/browse/TEXT-202 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Extract duplicate code in conditions and reused -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] coveralls edited a comment on pull request #225: TEXT-202 - Extract duplicate code
coveralls edited a comment on pull request #225: URL: https://github.com/apache/commons-text/pull/225#issuecomment-823001272 [](https://coveralls.io/builds/38993996) Coverage decreased (-0.002%) to 97.979% when pulling **5a793fdde5e5e83fb9a02f8108017baaa8e945b3 on arturobernalg:feature/TEXT-202** into **857a3ed9eeda0b197ebe57035d7de52cdf551b60 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-788) java8 improvements
[ https://issues.apache.org/jira/browse/COLLECTIONS-788?focusedWorklogId=586306=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586306 ] ASF GitHub Bot logged work on COLLECTIONS-788: -- Author: ASF GitHub Bot Created on: 21/Apr/21 04:28 Start Date: 21/Apr/21 04:28 Worklog Time Spent: 10m Work Description: arturobernalg closed pull request #227: URL: https://github.com/apache/commons-collections/pull/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586306) Remaining Estimate: 0h Time Spent: 10m > java8 improvements > -- > > Key: COLLECTIONS-788 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-788 > Project: Commons Collections > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > * Replace Collections.sort() with List.sort() > * Replace lambda with method reference > * Replace Loop with Collection.removeIf() > * Use lambda -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] arturobernalg closed pull request #227: COLLECTIONS-788 - java8 improvements
arturobernalg closed pull request #227: URL: https://github.com/apache/commons-collections/pull/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-202) Extract duplicate code
[ https://issues.apache.org/jira/browse/TEXT-202?focusedWorklogId=586303=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586303 ] ASF GitHub Bot logged work on TEXT-202: --- Author: ASF GitHub Bot Created on: 21/Apr/21 04:26 Start Date: 21/Apr/21 04:26 Worklog Time Spent: 10m Work Description: arturobernalg commented on a change in pull request #225: URL: https://github.com/apache/commons-text/pull/225#discussion_r617190574 ## File path: src/main/java/org/apache/commons/text/StringTokenizer.java ## @@ -848,11 +844,9 @@ private int readWithQuotes(final char[] srcChars, final int start, final int len pos += trimmedLen; continue; } - -// copy regular character from outside quotes -workArea.append(srcChars[pos++]); -trimStart = workArea.size(); } +workArea.append(srcChars[pos++]); Review comment: changed. TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586303) Time Spent: 1h 40m (was: 1.5h) > Extract duplicate code > -- > > Key: TEXT-202 > URL: https://issues.apache.org/jira/browse/TEXT-202 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Extract duplicate code in conditions and reused -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TEXT-202) Extract duplicate code
[ https://issues.apache.org/jira/browse/TEXT-202?focusedWorklogId=586302=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586302 ] ASF GitHub Bot logged work on TEXT-202: --- Author: ASF GitHub Bot Created on: 21/Apr/21 04:26 Start Date: 21/Apr/21 04:26 Worklog Time Spent: 10m Work Description: arturobernalg commented on a change in pull request #225: URL: https://github.com/apache/commons-text/pull/225#discussion_r617190541 ## File path: src/main/java/org/apache/commons/text/StrTokenizer.java ## @@ -842,10 +838,9 @@ private int readWithQuotes(final char[] srcChars, final int start, final int len continue; } -// copy regular character from outside quotes -workArea.append(srcChars[pos++]); -trimStart = workArea.size(); } +workArea.append(srcChars[pos++]); Review comment: changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586302) Time Spent: 1.5h (was: 1h 20m) > Extract duplicate code > -- > > Key: TEXT-202 > URL: https://issues.apache.org/jira/browse/TEXT-202 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Extract duplicate code in conditions and reused -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] arturobernalg commented on a change in pull request #225: TEXT-202 - Extract duplicate code
arturobernalg commented on a change in pull request #225: URL: https://github.com/apache/commons-text/pull/225#discussion_r617190574 ## File path: src/main/java/org/apache/commons/text/StringTokenizer.java ## @@ -848,11 +844,9 @@ private int readWithQuotes(final char[] srcChars, final int start, final int len pos += trimmedLen; continue; } - -// copy regular character from outside quotes -workArea.append(srcChars[pos++]); -trimStart = workArea.size(); } +workArea.append(srcChars[pos++]); Review comment: changed. TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] arturobernalg commented on a change in pull request #225: TEXT-202 - Extract duplicate code
arturobernalg commented on a change in pull request #225: URL: https://github.com/apache/commons-text/pull/225#discussion_r617190541 ## File path: src/main/java/org/apache/commons/text/StrTokenizer.java ## @@ -842,10 +838,9 @@ private int readWithQuotes(final char[] srcChars, final int start, final int len continue; } -// copy regular character from outside quotes -workArea.append(srcChars[pos++]); -trimStart = workArea.size(); } +workArea.append(srcChars[pos++]); Review comment: changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (GEOMETRY-118) AffineTransformMatrix2D should support direct transformation of x/y values
[
https://issues.apache.org/jira/browse/GEOMETRY-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326202#comment-17326202
]
Matt Juntunen commented on GEOMETRY-118:
Added a PR for this: https://github.com/apache/commons-geometry/pull/153
I added new methods to all 3 {{AffineTransformMatrixXD}} classes for applying
the transform to a set of coordinates and returning a double value for a
specified component. For example, the {{AffineTransformMatrix3D}} class now has
{{applyX}}, {{applyY}}, and {{applyZ}}, as well as {{applyVectorX}},
{{applyVectorY}}, and {{applyVectorZ}}. These correspond to the existing
{{apply}} and {{applyVector}} methods.
I also added some benchmark tests. There is a consistent performance boost when
using the non-Vector methods to transform values stored in double arrays. The
table below shows a typical result with JDK 8. Both tests accept an array of
random double values representing point coordinates which are then transformed
in-place. The {{transformArrayAsVectors3D}} test constructs a {{Vector3D}}
instance for each triplet of values, transforms this vector, and then unpacks
the results back into the array. The {{transformArrayComponents3D}} test uses
the new {{applyX}}, etc methods to perform the transformation directly without
creating {{Vector3D}} instances.
||Benchmark||(size)||Mode||Cnt||Score||Error||Units||
|AffineTransformMatrixPerformance.transformArrayAsVectors3D|6000|avgt|5|48270.474|±512.041|ns/op
|AffineTransformMatrixPerformance.transformArrayAsVectors3D|60|avgt|5|4953753.812|
±73952.368 |ns/op|
|AffineTransformMatrixPerformance.transformArrayComponents3D|6000|avgt|5|42049.154|±688.317|ns/op|
|AffineTransformMatrixPerformance.transformArrayComponents3D|60|avgt|5|4301789.439|±59713.465|ns/op|
> AffineTransformMatrix2D should support direct transformation of x/y values
> --
>
> Key: GEOMETRY-118
> URL: https://issues.apache.org/jira/browse/GEOMETRY-118
> Project: Apache Commons Geometry
> Issue Type: Improvement
>Reporter: Christoph Läubrich
>Priority: Major
>
> [~mattjuntunen] as discussed on the mailinglist, it would be convenient if
> there would be methods to directly transform a single x/y value instead of
> using vectors and/or export the matrix as an array and perform it manually.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-geometry] darkma773r opened a new pull request #153: GEOMETRY-118: Component-specific transform methods
darkma773r opened a new pull request #153: URL: https://github.com/apache/commons-geometry/pull/153 Adding component-specific transform methods to AffineTransformMatrixXD classes, ex: AffineTransformMatrix3D.applyX(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (GEOMETRY-95) CSG Examples
[ https://issues.apache.org/jira/browse/GEOMETRY-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Juntunen closed GEOMETRY-95. - > CSG Examples > > > Key: GEOMETRY-95 > URL: https://issues.apache.org/jira/browse/GEOMETRY-95 > Project: Apache Commons Geometry > Issue Type: New Feature >Reporter: Matt Juntunen >Priority: Major > > Adding Constructive Solid Geometry examples and userguide entries to help new > users to the library use these features. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEOMETRY-95) CSG Examples
[ https://issues.apache.org/jira/browse/GEOMETRY-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Juntunen resolved GEOMETRY-95. --- Resolution: Done > CSG Examples > > > Key: GEOMETRY-95 > URL: https://issues.apache.org/jira/browse/GEOMETRY-95 > Project: Apache Commons Geometry > Issue Type: New Feature >Reporter: Matt Juntunen >Priority: Major > > Adding Constructive Solid Geometry examples and userguide entries to help new > users to the library use these features. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-jexl] henrib merged pull request #46: Bump actions/cache from v2.1.4 to v2.1.5
henrib merged pull request #46: URL: https://github.com/apache/commons-jexl/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow merged pull request #130: Add oss-fuzz badge to README
kinow merged pull request #130: URL: https://github.com/apache/commons-imaging/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow opened a new pull request #130: Add oss-fuzz badge to README
kinow opened a new pull request #130: URL: https://github.com/apache/commons-imaging/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (GEOMETRY-95) CSG Examples
[ https://issues.apache.org/jira/browse/GEOMETRY-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326111#comment-17326111 ] Gilles Sadowski commented on GEOMETRY-95: - As you wish. > CSG Examples > > > Key: GEOMETRY-95 > URL: https://issues.apache.org/jira/browse/GEOMETRY-95 > Project: Apache Commons Geometry > Issue Type: New Feature >Reporter: Matt Juntunen >Priority: Major > > Adding Constructive Solid Geometry examples and userguide entries to help new > users to the library use these features. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-beanutils] melloware commented on pull request #37: BEANUTILS-539/BEANUTILS-509: Switch WeakFastHashMap for ConcurrentWeakKeyHashMap
melloware commented on pull request #37: URL: https://github.com/apache/commons-beanutils/pull/37#issuecomment-823600682 Nope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] bitwiseman commented on pull request #37: BEANUTILS-539/BEANUTILS-509: Switch WeakFastHashMap for ConcurrentWeakKeyHashMap
bitwiseman commented on pull request #37: URL: https://github.com/apache/commons-beanutils/pull/37#issuecomment-823599219 @melloware Do you have it back ported to 1.x? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (GEOMETRY-95) CSG Examples
[ https://issues.apache.org/jira/browse/GEOMETRY-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326106#comment-17326106 ] Matt Juntunen commented on GEOMETRY-95: --- [~erans], I'd like to close this issue if you don't have any objections. The tutorial I just merged doesn't include exactly some of the things we've described above but I think we should create new, more focused issues for other tutorials, enhancements, etc. that are needed. > CSG Examples > > > Key: GEOMETRY-95 > URL: https://issues.apache.org/jira/browse/GEOMETRY-95 > Project: Apache Commons Geometry > Issue Type: New Feature >Reporter: Matt Juntunen >Priority: Major > > Adding Constructive Solid Geometry examples and userguide entries to help new > users to the library use these features. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEOMETRY-95) CSG Examples
[ https://issues.apache.org/jira/browse/GEOMETRY-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326103#comment-17326103 ] Matt Juntunen commented on GEOMETRY-95: --- Tutorial added in commit cc0d312bdc1d8225b94d2493167ba55fa41427b5. > CSG Examples > > > Key: GEOMETRY-95 > URL: https://issues.apache.org/jira/browse/GEOMETRY-95 > Project: Apache Commons Geometry > Issue Type: New Feature >Reporter: Matt Juntunen >Priority: Major > > Adding Constructive Solid Geometry examples and userguide entries to help new > users to the library use these features. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-beanutils] melloware commented on pull request #37: BEANUTILS-539/BEANUTILS-509: Switch WeakFastHashMap for ConcurrentWeakKeyHashMap
melloware commented on pull request #37: URL: https://github.com/apache/commons-beanutils/pull/37#issuecomment-823572730 I have a version of Commons Beanutils published using this PR. ```xml com.melloware commons-beanutils2 2.0.0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #37: BEANUTILS-539/BEANUTILS-509: Switch WeakFastHashMap for ConcurrentWeakKeyHashMap
melloware commented on pull request #37: URL: https://github.com/apache/commons-beanutils/pull/37#issuecomment-823572277 Yes that is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] bitwiseman commented on pull request #37: BEANUTILS-539/BEANUTILS-509: Switch WeakFastHashMap for ConcurrentWeakKeyHashMap
bitwiseman commented on pull request #37: URL: https://github.com/apache/commons-beanutils/pull/37#issuecomment-823571090 The new PR is #56 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] arturobernalg opened a new pull request #227: Feature/collections 788
arturobernalg opened a new pull request #227: URL: https://github.com/apache/commons-collections/pull/227 - Replace Collections.sort() with List.sort() - Replace lambda with method reference - Replace Loop with Collection.removeIf() - Use lambda -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COLLECTIONS-788) java8 improvements
Arturo Bernal created COLLECTIONS-788: - Summary: java8 improvements Key: COLLECTIONS-788 URL: https://issues.apache.org/jira/browse/COLLECTIONS-788 Project: Commons Collections Issue Type: Sub-task Reporter: Arturo Bernal * Replace Collections.sort() with List.sort() * Replace lambda with method reference * Replace Loop with Collection.removeIf() * Use lambda -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TEXT-202) Extract duplicate code
[ https://issues.apache.org/jira/browse/TEXT-202?focusedWorklogId=586153=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586153 ] ASF GitHub Bot logged work on TEXT-202: --- Author: ASF GitHub Bot Created on: 20/Apr/21 20:07 Start Date: 20/Apr/21 20:07 Worklog Time Spent: 10m Work Description: kinow commented on a change in pull request #225: URL: https://github.com/apache/commons-text/pull/225#discussion_r616997571 ## File path: src/main/java/org/apache/commons/text/StringTokenizer.java ## @@ -848,11 +844,9 @@ private int readWithQuotes(final char[] srcChars, final int start, final int len pos += trimmedLen; continue; } - -// copy regular character from outside quotes -workArea.append(srcChars[pos++]); -trimStart = workArea.size(); } +workArea.append(srcChars[pos++]); Review comment: Ditto here about the comment that was removed :+1: ## File path: src/main/java/org/apache/commons/text/StrTokenizer.java ## @@ -842,10 +838,9 @@ private int readWithQuotes(final char[] srcChars, final int start, final int len continue; } -// copy regular character from outside quotes -workArea.append(srcChars[pos++]); -trimStart = workArea.size(); } +workArea.append(srcChars[pos++]); Review comment: @arturobernalg can you add back the comment above these lines, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586153) Time Spent: 1h 20m (was: 1h 10m) > Extract duplicate code > -- > > Key: TEXT-202 > URL: https://issues.apache.org/jira/browse/TEXT-202 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Extract duplicate code in conditions and reused -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] kinow commented on a change in pull request #225: TEXT-202 - Extract duplicate code
kinow commented on a change in pull request #225: URL: https://github.com/apache/commons-text/pull/225#discussion_r616997571 ## File path: src/main/java/org/apache/commons/text/StringTokenizer.java ## @@ -848,11 +844,9 @@ private int readWithQuotes(final char[] srcChars, final int start, final int len pos += trimmedLen; continue; } - -// copy regular character from outside quotes -workArea.append(srcChars[pos++]); -trimStart = workArea.size(); } +workArea.append(srcChars[pos++]); Review comment: Ditto here about the comment that was removed :+1: ## File path: src/main/java/org/apache/commons/text/StrTokenizer.java ## @@ -842,10 +838,9 @@ private int readWithQuotes(final char[] srcChars, final int start, final int len continue; } -// copy regular character from outside quotes -workArea.append(srcChars[pos++]); -trimStart = workArea.size(); } +workArea.append(srcChars[pos++]); Review comment: @arturobernalg can you add back the comment above these lines, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COLLECTIONS-787) Minor improvements
Arturo Bernal created COLLECTIONS-787: - Summary: Minor improvements Key: COLLECTIONS-787 URL: https://issues.apache.org/jira/browse/COLLECTIONS-787 Project: Commons Collections Issue Type: Improvement Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] arturobernalg closed pull request #221: Minor improvement
arturobernalg closed pull request #221: URL: https://github.com/apache/commons-collections/pull/221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-203) Remove redundant initializer
[ https://issues.apache.org/jira/browse/TEXT-203?focusedWorklogId=586026=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586026 ] ASF GitHub Bot logged work on TEXT-203: --- Author: ASF GitHub Bot Created on: 20/Apr/21 17:26 Start Date: 20/Apr/21 17:26 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #226: URL: https://github.com/apache/commons-text/pull/226#issuecomment-823465145 [](https://coveralls.io/builds/38977838) Coverage decreased (-0.004%) to 97.977% when pulling **83fa1524f778291ad96958d6c9371f48ab39d475 on arturobernalg:feature/TEXT-203** into **857a3ed9eeda0b197ebe57035d7de52cdf551b60 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586026) Time Spent: 20m (was: 10m) > Remove redundant initializer > > > Key: TEXT-203 > URL: https://issues.apache.org/jira/browse/TEXT-203 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] coveralls commented on pull request #226: TEXT-203 - Remove redundant initializer
coveralls commented on pull request #226: URL: https://github.com/apache/commons-text/pull/226#issuecomment-823465145 [](https://coveralls.io/builds/38977838) Coverage decreased (-0.004%) to 97.977% when pulling **83fa1524f778291ad96958d6c9371f48ab39d475 on arturobernalg:feature/TEXT-203** into **857a3ed9eeda0b197ebe57035d7de52cdf551b60 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-203) Remove redundant initializer
[ https://issues.apache.org/jira/browse/TEXT-203?focusedWorklogId=586004=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586004 ] ASF GitHub Bot logged work on TEXT-203: --- Author: ASF GitHub Bot Created on: 20/Apr/21 16:55 Start Date: 20/Apr/21 16:55 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #226: URL: https://github.com/apache/commons-text/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 586004) Remaining Estimate: 0h Time Spent: 10m > Remove redundant initializer > > > Key: TEXT-203 > URL: https://issues.apache.org/jira/browse/TEXT-203 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] arturobernalg opened a new pull request #226: TEXT-203 - Remove redundant initializer
arturobernalg opened a new pull request #226: URL: https://github.com/apache/commons-text/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (TEXT-203) Remove redundant initializer
Arturo Bernal created TEXT-203: -- Summary: Remove redundant initializer Key: TEXT-203 URL: https://issues.apache.org/jira/browse/TEXT-203 Project: Commons Text Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-jexl] coveralls edited a comment on pull request #46: Bump actions/cache from v2.1.4 to v2.1.5
coveralls edited a comment on pull request #46: URL: https://github.com/apache/commons-jexl/pull/46#issuecomment-818664066 [](https://coveralls.io/builds/38970623) Coverage decreased (-0.02%) to 86.8% when pulling **ad2b8e62cfb0d953131f253f824ffc37ddb50bea on dependabot/github_actions/actions/cache-v2.1.5** into **4e6a2f273e85bfba2b521d31b914361ae90a48c1 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FILEUPLOAD-309) Release version 2.0.0
[ https://issues.apache.org/jira/browse/FILEUPLOAD-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325778#comment-17325778 ] Martin Tzvetanov Grigorov commented on FILEUPLOAD-309: -- Apache Wicket team also needs a new release of commons-fileupload based on Jakarta APIs! Even a milestone release would be great! > Release version 2.0.0 > - > > Key: FILEUPLOAD-309 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-309 > Project: Commons FileUpload > Issue Type: Wish >Reporter: Thiago Henrique Hupner >Priority: Major > > At Piranha, we've migrated to use the new Jakarta namespace. > One of our dependencies is the Commons File Upload, but the latest version > available is 1.4. > Looking around at the source code, I've found that the code is already > prepared for the new Jakarta namespace. > So, I want to know if there's a plan to release a new version soon. Or at > least a 2.0.0 milestone. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TEXT-202) Extract duplicate code
[
https://issues.apache.org/jira/browse/TEXT-202?focusedWorklogId=585756=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-585756
]
ASF GitHub Bot logged work on TEXT-202:
---
Author: ASF GitHub Bot
Created on: 20/Apr/21 12:16
Start Date: 20/Apr/21 12:16
Worklog Time Spent: 10m
Work Description: arturobernalg commented on a change in pull request
#225:
URL: https://github.com/apache/commons-text/pull/225#discussion_r616626079
##
File path: src/main/java/org/apache/commons/text/StrBuilder.java
##
@@ -319,15 +319,14 @@ public StrBuilder append(final boolean value) {
buffer[size++] = 't';
buffer[size++] = 'r';
buffer[size++] = 'u';
-buffer[size++] = 'e';
} else {
ensureCapacity(size + 5);
buffer[size++] = 'f';
buffer[size++] = 'a';
buffer[size++] = 'l';
buffer[size++] = 's';
-buffer[size++] = 'e';
}
+buffer[size++] = 'e';
Review comment:
Yep. Agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 585756)
Time Spent: 1h 10m (was: 1h)
> Extract duplicate code
> --
>
> Key: TEXT-202
> URL: https://issues.apache.org/jira/browse/TEXT-202
> Project: Commons Text
> Issue Type: Sub-task
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Extract duplicate code in conditions and reused
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-text] arturobernalg commented on a change in pull request #225: TEXT-202 - Extract duplicate code
arturobernalg commented on a change in pull request #225:
URL: https://github.com/apache/commons-text/pull/225#discussion_r616626079
##
File path: src/main/java/org/apache/commons/text/StrBuilder.java
##
@@ -319,15 +319,14 @@ public StrBuilder append(final boolean value) {
buffer[size++] = 't';
buffer[size++] = 'r';
buffer[size++] = 'u';
-buffer[size++] = 'e';
} else {
ensureCapacity(size + 5);
buffer[size++] = 'f';
buffer[size++] = 'a';
buffer[size++] = 'l';
buffer[size++] = 's';
-buffer[size++] = 'e';
}
+buffer[size++] = 'e';
Review comment:
Yep. Agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-jexl] henrib commented on pull request #46: Bump actions/cache from v2.1.4 to v2.1.5
henrib commented on pull request #46: URL: https://github.com/apache/commons-jexl/pull/46#issuecomment-823225086 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-202) Extract duplicate code
[
https://issues.apache.org/jira/browse/TEXT-202?focusedWorklogId=585712=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-585712
]
ASF GitHub Bot logged work on TEXT-202:
---
Author: ASF GitHub Bot
Created on: 20/Apr/21 11:15
Start Date: 20/Apr/21 11:15
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #225:
URL: https://github.com/apache/commons-text/pull/225#discussion_r616587084
##
File path: src/main/java/org/apache/commons/text/StrBuilder.java
##
@@ -319,15 +319,14 @@ public StrBuilder append(final boolean value) {
buffer[size++] = 't';
buffer[size++] = 'r';
buffer[size++] = 'u';
-buffer[size++] = 'e';
} else {
ensureCapacity(size + 5);
buffer[size++] = 'f';
buffer[size++] = 'a';
buffer[size++] = 'l';
buffer[size++] = 's';
-buffer[size++] = 'e';
}
+buffer[size++] = 'e';
Review comment:
I agree with @kinow, you have to think about maintainers reading the
code, not just applying changes mechanically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 585712)
Time Spent: 1h (was: 50m)
> Extract duplicate code
> --
>
> Key: TEXT-202
> URL: https://issues.apache.org/jira/browse/TEXT-202
> Project: Commons Text
> Issue Type: Sub-task
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Extract duplicate code in conditions and reused
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-text] garydgregory commented on a change in pull request #225: TEXT-202 - Extract duplicate code
garydgregory commented on a change in pull request #225:
URL: https://github.com/apache/commons-text/pull/225#discussion_r616587084
##
File path: src/main/java/org/apache/commons/text/StrBuilder.java
##
@@ -319,15 +319,14 @@ public StrBuilder append(final boolean value) {
buffer[size++] = 't';
buffer[size++] = 'r';
buffer[size++] = 'u';
-buffer[size++] = 'e';
} else {
ensureCapacity(size + 5);
buffer[size++] = 'f';
buffer[size++] = 'a';
buffer[size++] = 'l';
buffer[size++] = 's';
-buffer[size++] = 'e';
}
+buffer[size++] = 'e';
Review comment:
I agree with @kinow, you have to think about maintainers reading the
code, not just applying changes mechanically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-jexl] coveralls edited a comment on pull request #46: Bump actions/cache from v2.1.4 to v2.1.5
coveralls edited a comment on pull request #46: URL: https://github.com/apache/commons-jexl/pull/46#issuecomment-818664066 [](https://coveralls.io/builds/38965826) Coverage decreased (-0.02%) to 86.8% when pulling **95d9440281e44afde558b81c8377412415023ebb on dependabot/github_actions/actions/cache-v2.1.5** into **693961abadf236a31ea8a77f07431b31ded7916f on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jexl] henrib commented on pull request #46: Bump actions/cache from v2.1.4 to v2.1.5
henrib commented on pull request #46: URL: https://github.com/apache/commons-jexl/pull/46#issuecomment-823159930 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jexl] coveralls edited a comment on pull request #46: Bump actions/cache from v2.1.4 to v2.1.5
coveralls edited a comment on pull request #46: URL: https://github.com/apache/commons-jexl/pull/46#issuecomment-818664066 [](https://coveralls.io/builds/38963247) Coverage decreased (-0.03%) to 86.784% when pulling **4df3315bef4972f173a06bfc7eecae02be13736d on dependabot/github_actions/actions/cache-v2.1.5** into **385f1ffcaed80734f385401635155c9853ba0f6f on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jexl] henrib commented on pull request #46: Bump actions/cache from v2.1.4 to v2.1.5
henrib commented on pull request #46: URL: https://github.com/apache/commons-jexl/pull/46#issuecomment-823102628 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-202) Extract duplicate code
[ https://issues.apache.org/jira/browse/TEXT-202?focusedWorklogId=585587=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-585587 ] ASF GitHub Bot logged work on TEXT-202: --- Author: ASF GitHub Bot Created on: 20/Apr/21 06:42 Start Date: 20/Apr/21 06:42 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #225: URL: https://github.com/apache/commons-text/pull/225#issuecomment-823001272 [](https://coveralls.io/builds/38958933) Coverage decreased (-0.002%) to 97.979% when pulling **69e8cfb40596b921e333f8efebb91b4e93254b33 on arturobernalg:feature/TEXT-202** into **857a3ed9eeda0b197ebe57035d7de52cdf551b60 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 585587) Time Spent: 50m (was: 40m) > Extract duplicate code > -- > > Key: TEXT-202 > URL: https://issues.apache.org/jira/browse/TEXT-202 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Extract duplicate code in conditions and reused -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] coveralls edited a comment on pull request #225: TEXT-202 - Extract duplicate code
coveralls edited a comment on pull request #225: URL: https://github.com/apache/commons-text/pull/225#issuecomment-823001272 [](https://coveralls.io/builds/38958933) Coverage decreased (-0.002%) to 97.979% when pulling **69e8cfb40596b921e333f8efebb91b4e93254b33 on arturobernalg:feature/TEXT-202** into **857a3ed9eeda0b197ebe57035d7de52cdf551b60 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-202) Extract duplicate code
[
https://issues.apache.org/jira/browse/TEXT-202?focusedWorklogId=585582=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-585582
]
ASF GitHub Bot logged work on TEXT-202:
---
Author: ASF GitHub Bot
Created on: 20/Apr/21 06:26
Start Date: 20/Apr/21 06:26
Worklog Time Spent: 10m
Work Description: arturobernalg commented on a change in pull request
#225:
URL: https://github.com/apache/commons-text/pull/225#discussion_r616378178
##
File path: src/main/java/org/apache/commons/text/StrBuilder.java
##
@@ -319,15 +319,14 @@ public StrBuilder append(final boolean value) {
buffer[size++] = 't';
buffer[size++] = 'r';
buffer[size++] = 'u';
-buffer[size++] = 'e';
} else {
ensureCapacity(size + 5);
buffer[size++] = 'f';
buffer[size++] = 'a';
buffer[size++] = 'l';
buffer[size++] = 's';
-buffer[size++] = 'e';
}
+buffer[size++] = 'e';
Review comment:
HI @kinow
sound fair. Changed
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 585582)
Time Spent: 40m (was: 0.5h)
> Extract duplicate code
> --
>
> Key: TEXT-202
> URL: https://issues.apache.org/jira/browse/TEXT-202
> Project: Commons Text
> Issue Type: Sub-task
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Extract duplicate code in conditions and reused
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-text] arturobernalg commented on a change in pull request #225: TEXT-202 - Extract duplicate code
arturobernalg commented on a change in pull request #225:
URL: https://github.com/apache/commons-text/pull/225#discussion_r616378178
##
File path: src/main/java/org/apache/commons/text/StrBuilder.java
##
@@ -319,15 +319,14 @@ public StrBuilder append(final boolean value) {
buffer[size++] = 't';
buffer[size++] = 'r';
buffer[size++] = 'u';
-buffer[size++] = 'e';
} else {
ensureCapacity(size + 5);
buffer[size++] = 'f';
buffer[size++] = 'a';
buffer[size++] = 'l';
buffer[size++] = 's';
-buffer[size++] = 'e';
}
+buffer[size++] = 'e';
Review comment:
HI @kinow
sound fair. Changed
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (TEXT-202) Extract duplicate code
[ https://issues.apache.org/jira/browse/TEXT-202?focusedWorklogId=585578=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-585578 ] ASF GitHub Bot logged work on TEXT-202: --- Author: ASF GitHub Bot Created on: 20/Apr/21 06:10 Start Date: 20/Apr/21 06:10 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #225: URL: https://github.com/apache/commons-text/pull/225#issuecomment-823001272 [](https://coveralls.io/builds/38958393) Coverage decreased (-0.003%) to 97.979% when pulling **38c1739984d2b7709cd8b63b051db5610114440e on arturobernalg:feature/TEXT-202** into **857a3ed9eeda0b197ebe57035d7de52cdf551b60 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 585578) Time Spent: 0.5h (was: 20m) > Extract duplicate code > -- > > Key: TEXT-202 > URL: https://issues.apache.org/jira/browse/TEXT-202 > Project: Commons Text > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Extract duplicate code in conditions and reused -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] coveralls commented on pull request #225: TEXT-202 - Extract duplicate code
coveralls commented on pull request #225: URL: https://github.com/apache/commons-text/pull/225#issuecomment-823001272 [](https://coveralls.io/builds/38958393) Coverage decreased (-0.003%) to 97.979% when pulling **38c1739984d2b7709cd8b63b051db5610114440e on arturobernalg:feature/TEXT-202** into **857a3ed9eeda0b197ebe57035d7de52cdf551b60 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
