[GitHub] [commons-geometry] arturobernalg closed pull request #182: Simplify assertions with equivalent but more simple.
arturobernalg closed pull request #182: URL: https://github.com/apache/commons-geometry/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Deleted] (MODELER-34) 3D game modeling
[ https://issues.apache.org/jira/browse/MODELER-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles Sadowski deleted MODELER-34: --- > 3D game modeling > > > Key: MODELER-34 > URL: https://issues.apache.org/jira/browse/MODELER-34 > Project: Commons Modeler > Issue Type: Task >Reporter: developerIT >Priority: Major > > Computer 3D modeling is the process of creating a model of a > three-dimensional object in virtual space. There are several types of 3D > modeling, which are fundamentally different. The first type - polygonal - is > the construction of the model using polygons with three or four vertices. > These polygons, connected to form a single 3D shape, form a polygon mesh or > object. > The more polygons will be used when building the model, the more accurately > the object will be modeled. In this case, we talk about high-poly modeling. > Conversely, low poly modeling with a small number of polygons takes place. > Such models have a more faceted look. Spline modeling involves the use of > so-called splines - flexible three-dimensional patterns. 3D modeling of this > type comes down to creating a spline wireframe that will bend around a > geometric surface. In software specializing in this type of modeling, there > are basic parametric objects used to operate. > 3D Game Modeling Services > [https://kevurugames.com/game-art/3d-game-modeling/|https://kevurugames.com/game-art/3d-game-modeling/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] coveralls commented on pull request #261: Bump mockito-inline from 3.11.2 to 3.12.0
coveralls commented on pull request #261: URL: https://github.com/apache/commons-io/pull/261#issuecomment-902345118 [](https://coveralls.io/builds/42286192) Coverage increased (+0.04%) to 89.122% when pulling **0d7950bc1b3b133cacd769856009dbee3c55cc22 on dependabot/maven/org.mockito-mockito-inline-3.12.0** into **5111e23b01eb9e8e44361438395658d815aa0d3b on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MODELER-34) 3D game modeling
developerIT created MODELER-34: -- Summary: 3D game modeling Key: MODELER-34 URL: https://issues.apache.org/jira/browse/MODELER-34 Project: Commons Modeler Issue Type: Task Reporter: developerIT Computer 3D modeling is the process of creating a model of a three-dimensional object in virtual space. There are several types of 3D modeling, which are fundamentally different. The first type - polygonal - is the construction of the model using polygons with three or four vertices. These polygons, connected to form a single 3D shape, form a polygon mesh or object. The more polygons will be used when building the model, the more accurately the object will be modeled. In this case, we talk about high-poly modeling. Conversely, low poly modeling with a small number of polygons takes place. Such models have a more faceted look. Spline modeling involves the use of so-called splines - flexible three-dimensional patterns. 3D modeling of this type comes down to creating a spline wireframe that will bend around a geometric surface. In software specializing in this type of modeling, there are basic parametric objects used to operate. 3D Game Modeling Services [https://kevurugames.com/game-art/3d-game-modeling/|https://kevurugames.com/game-art/3d-game-modeling/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] dependabot[bot] opened a new pull request #261: Bump mockito-inline from 3.11.2 to 3.12.0
dependabot[bot] opened a new pull request #261: URL: https://github.com/apache/commons-io/pull/261 Bumps [mockito-inline](https://github.com/mockito/mockito) from 3.11.2 to 3.12.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-inline's releases. v3.12.0 Changelog generated by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog Gradle Plugin 3.12.0 2021-08-19 - https://github.com/mockito/mockito/compare/v3.11.2...v3.12.0;>31 commit(s) by EugeneLesnov, Lars Vogel, Logan Rosen, Rafael Winterhalter, Rob Pridham, Tim van der Lippe, dependabot[bot], saurabh7248 Add checks for sealed types [(https://github-redirect.dependabot.com/mockito/mockito/issues/2392;>#2392)](https://github-redirect.dependabot.com/mockito/mockito/pull/2392;>mockito/mockito#2392) Bump versions.bytebuddy from 1.11.10 to 1.11.12 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2388;>#2388)](https://github-redirect.dependabot.com/mockito/mockito/pull/2388;>mockito/mockito#2388) Bump versions.bytebuddy from 1.11.9 to 1.11.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2387;>#2387)](https://github-redirect.dependabot.com/mockito/mockito/pull/2387;>mockito/mockito#2387) Bump versions.errorprone from 2.8.0 to 2.8.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2386;>#2386)](https://github-redirect.dependabot.com/mockito/mockito/pull/2386;>mockito/mockito#2386) Update StaticMockTest to use unified verify method [(https://github-redirect.dependabot.com/mockito/mockito/issues/2385;>#2385)](https://github-redirect.dependabot.com/mockito/mockito/pull/2385;>mockito/mockito#2385) Reorder InjectMock Javadoc to fit the order of injection [(https://github-redirect.dependabot.com/mockito/mockito/issues/2383;>#2383)](https://github-redirect.dependabot.com/mockito/mockito/pull/2383;>mockito/mockito#2383) Bump core-ktx from 1.5.0 to 1.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2382;>#2382)](https://github-redirect.dependabot.com/mockito/mockito/pull/2382;>mockito/mockito#2382) Bump google-java-format from 1.10.0 to 1.11.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2381;>#2381)](https://github-redirect.dependabot.com/mockito/mockito/pull/2381;>mockito/mockito#2381) Downgrade Android gradle plugin [(https://github-redirect.dependabot.com/mockito/mockito/issues/2380;>#2380)](https://github-redirect.dependabot.com/mockito/mockito/pull/2380;>mockito/mockito#2380) Applied https://github.com/CheckReturnValue;>@CheckReturnValue to some classes [(https://github-redirect.dependabot.com/mockito/mockito/issues/2379;>#2379)](https://github-redirect.dependabot.com/mockito/mockito/pull/2379;>mockito/mockito#2379) how to solve gradle sync failed after 'Add basic Android instrumented and unit tests' [(https://github-redirect.dependabot.com/mockito/mockito/issues/2378;>#2378)](https://github-redirect.dependabot.com/mockito/mockito/issues/2378;>mockito/mockito#2378) Bump junit from 1.1.2 to 1.1.3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2377;>#2377)](https://github-redirect.dependabot.com/mockito/mockito/pull/2377;>mockito/mockito#2377) Bump appcompat from 1.3.0 to 1.3.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2376;>#2376)](https://github-redirect.dependabot.com/mockito/mockito/pull/2376;>mockito/mockito#2376) Bump kotlin-gradle-plugin from 1.5.20 to 1.5.21 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2374;>#2374)](https://github-redirect.dependabot.com/mockito/mockito/pull/2374;>mockito/mockito#2374) Bump material from 1.3.0 to 1.4.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2373;>#2373)](https://github-redirect.dependabot.com/mockito/mockito/pull/2373;>mockito/mockito#2373) Bump espresso-core from 3.3.0 to 3.4.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2372;>#2372)](https://github-redirect.dependabot.com/mockito/mockito/pull/2372;>mockito/mockito#2372) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2331;>#2331 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2369;>#2369)](https://github-redirect.dependabot.com/mockito/mockito/pull/2369;>mockito/mockito#2369) Fix typo in exception [(https://github-redirect.dependabot.com/mockito/mockito/issues/2368;>#2368)](https://github-redirect.dependabot.com/mockito/mockito/pull/2368;>mockito/mockito#2368) Bump versions.bytebuddy from 1.11.8 to 1.11.9 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2367;>#2367)](https://github-redirect.dependabot.com/mockito/mockito/pull/2367;>mockito/mockito#2367) Bump versions.errorprone from 2.7.1 to 2.8.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2365;>#2365)](https://github-redirect.dependabot.com/mockito/mockito/pull/2365;>mockito/mockito#2365) Bump versions.bytebuddy
[GitHub] [commons-text] coveralls commented on pull request #258: Bump mockito-inline from 3.11.2 to 3.12.0
coveralls commented on pull request #258: URL: https://github.com/apache/commons-text/pull/258#issuecomment-902289690 [](https://coveralls.io/builds/42282365) Coverage remained the same at 97.865% when pulling **853e36a130735430fc2c4d814ec109d97906e1e3 on dependabot/maven/org.mockito-mockito-inline-3.12.0** into **5eb7240d7a36032b0d9c893d5dc6b8381b298ddc on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow closed pull request #258: Bump mockito-inline from 3.11.2 to 3.12.0
kinow closed pull request #258: URL: https://github.com/apache/commons-text/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] commented on pull request #258: Bump mockito-inline from 3.11.2 to 3.12.0
dependabot[bot] commented on pull request #258: URL: https://github.com/apache/commons-text/pull/258#issuecomment-902268292 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw closed pull request #105: Bump spotbugs from 4.2.3 to 4.4.0
jochenw closed pull request #105: URL: https://github.com/apache/commons-fileupload/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #105: Bump spotbugs from 4.2.3 to 4.4.0
jochenw commented on pull request #105: URL: https://github.com/apache/commons-fileupload/pull/105#issuecomment-902208223 Travis build failures, so closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] commented on pull request #105: Bump spotbugs from 4.2.3 to 4.4.0
dependabot[bot] commented on pull request #105: URL: https://github.com/apache/commons-fileupload/pull/105#issuecomment-902208243 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request #258: Bump mockito-inline from 3.11.2 to 3.12.0
dependabot[bot] opened a new pull request #258: URL: https://github.com/apache/commons-text/pull/258 Bumps [mockito-inline](https://github.com/mockito/mockito) from 3.11.2 to 3.12.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-inline's releases. v3.12.0 Changelog generated by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog Gradle Plugin 3.12.0 2021-08-19 - https://github.com/mockito/mockito/compare/v3.11.2...v3.12.0;>31 commit(s) by EugeneLesnov, Lars Vogel, Logan Rosen, Rafael Winterhalter, Rob Pridham, Tim van der Lippe, dependabot[bot], saurabh7248 Add checks for sealed types [(https://github-redirect.dependabot.com/mockito/mockito/issues/2392;>#2392)](https://github-redirect.dependabot.com/mockito/mockito/pull/2392;>mockito/mockito#2392) Bump versions.bytebuddy from 1.11.10 to 1.11.12 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2388;>#2388)](https://github-redirect.dependabot.com/mockito/mockito/pull/2388;>mockito/mockito#2388) Bump versions.bytebuddy from 1.11.9 to 1.11.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2387;>#2387)](https://github-redirect.dependabot.com/mockito/mockito/pull/2387;>mockito/mockito#2387) Bump versions.errorprone from 2.8.0 to 2.8.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2386;>#2386)](https://github-redirect.dependabot.com/mockito/mockito/pull/2386;>mockito/mockito#2386) Update StaticMockTest to use unified verify method [(https://github-redirect.dependabot.com/mockito/mockito/issues/2385;>#2385)](https://github-redirect.dependabot.com/mockito/mockito/pull/2385;>mockito/mockito#2385) Reorder InjectMock Javadoc to fit the order of injection [(https://github-redirect.dependabot.com/mockito/mockito/issues/2383;>#2383)](https://github-redirect.dependabot.com/mockito/mockito/pull/2383;>mockito/mockito#2383) Bump core-ktx from 1.5.0 to 1.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2382;>#2382)](https://github-redirect.dependabot.com/mockito/mockito/pull/2382;>mockito/mockito#2382) Bump google-java-format from 1.10.0 to 1.11.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2381;>#2381)](https://github-redirect.dependabot.com/mockito/mockito/pull/2381;>mockito/mockito#2381) Downgrade Android gradle plugin [(https://github-redirect.dependabot.com/mockito/mockito/issues/2380;>#2380)](https://github-redirect.dependabot.com/mockito/mockito/pull/2380;>mockito/mockito#2380) Applied https://github.com/CheckReturnValue;>@CheckReturnValue to some classes [(https://github-redirect.dependabot.com/mockito/mockito/issues/2379;>#2379)](https://github-redirect.dependabot.com/mockito/mockito/pull/2379;>mockito/mockito#2379) how to solve gradle sync failed after 'Add basic Android instrumented and unit tests' [(https://github-redirect.dependabot.com/mockito/mockito/issues/2378;>#2378)](https://github-redirect.dependabot.com/mockito/mockito/issues/2378;>mockito/mockito#2378) Bump junit from 1.1.2 to 1.1.3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2377;>#2377)](https://github-redirect.dependabot.com/mockito/mockito/pull/2377;>mockito/mockito#2377) Bump appcompat from 1.3.0 to 1.3.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2376;>#2376)](https://github-redirect.dependabot.com/mockito/mockito/pull/2376;>mockito/mockito#2376) Bump kotlin-gradle-plugin from 1.5.20 to 1.5.21 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2374;>#2374)](https://github-redirect.dependabot.com/mockito/mockito/pull/2374;>mockito/mockito#2374) Bump material from 1.3.0 to 1.4.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2373;>#2373)](https://github-redirect.dependabot.com/mockito/mockito/pull/2373;>mockito/mockito#2373) Bump espresso-core from 3.3.0 to 3.4.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2372;>#2372)](https://github-redirect.dependabot.com/mockito/mockito/pull/2372;>mockito/mockito#2372) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2331;>#2331 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2369;>#2369)](https://github-redirect.dependabot.com/mockito/mockito/pull/2369;>mockito/mockito#2369) Fix typo in exception [(https://github-redirect.dependabot.com/mockito/mockito/issues/2368;>#2368)](https://github-redirect.dependabot.com/mockito/mockito/pull/2368;>mockito/mockito#2368) Bump versions.bytebuddy from 1.11.8 to 1.11.9 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2367;>#2367)](https://github-redirect.dependabot.com/mockito/mockito/pull/2367;>mockito/mockito#2367) Bump versions.errorprone from 2.7.1 to 2.8.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2365;>#2365)](https://github-redirect.dependabot.com/mockito/mockito/pull/2365;>mockito/mockito#2365) Bump versions.bytebuddy
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=640004=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640004 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 19:26 Start Date: 19/Aug/21 19:26 Worklog Time Spent: 10m Work Description: martin-g edited a comment on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901915469 Wicket does not use reflection, so no need to `open` (at least for Wicket). @GedMarc Please check this PR. ``` // use JDK 9+ mvn package -Prelease cd target unzip commons-fileupload2-2.0-SNAPSHOT.jar javap META-INF/versions/9/module-info.class cat META-INF/MANIFEST.MF (and look for `Multi-Release: true`) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640004) Time Spent: 2h 20m (was: 2h 10m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] martin-g edited a comment on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g edited a comment on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901915469 Wicket does not use reflection, so no need to `open` (at least for Wicket). @GedMarc Please check this PR. ``` // use JDK 9+ mvn package -Prelease cd target unzip commons-fileupload2-2.0-SNAPSHOT.jar javap META-INF/versions/9/module-info.class cat META-INF/MANIFEST.MF (and look for `Multi-Release: true`) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #792: Simplify assertions with equivalent but more simple.
coveralls edited a comment on pull request #792: URL: https://github.com/apache/commons-lang/pull/792#issuecomment-901663987 [](https://coveralls.io/builds/42277165) Coverage remained the same at 94.985% when pulling **09f54a9e1ac082962124b12da1aced7283ca5e2d on arturobernalg:feature/simplify_assert** into **ce477d9140f1439c44c7a852d7df1e069e21cb85 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #793: Simplify bitwise operations with equivalent and simple.
coveralls edited a comment on pull request #793: URL: https://github.com/apache/commons-lang/pull/793#issuecomment-901664909 [](https://coveralls.io/builds/42277012) Coverage decreased (-0.01%) to 94.972% when pulling **c54e8dc84722085a4fdda5704625bf8f5e491d6a on arturobernalg:feature/simplify_bitwise** into **ce477d9140f1439c44c7a852d7df1e069e21cb85 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1593) Common behaviour for StringUtils join APIs when called with char or String delimiter
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=639980=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639980
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
Created on: 19/Aug/21 18:09
Start Date: 19/Aug/21 18:09
Worklog Time Spent: 10m
Work Description: coveralls edited a comment on pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#issuecomment-893057654
[](https://coveralls.io/builds/42276554)
Coverage increased (+0.009%) to 94.994% when pulling
**f18c98ef594fb9cc09ad0cb83eddb0f767e1437e on
HubertWo:fix/LANG-1593-join-string-delimiter** into
**ce477d9140f1439c44c7a852d7df1e069e21cb85 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 639980)
Time Spent: 4h 10m (was: 4h)
> Common behaviour for StringUtils join APIs when called with char or String
> delimiter
>
>
> Key: LANG-1593
> URL: https://issues.apache.org/jira/browse/LANG-1593
> Project: Commons Lang
> Issue Type: Improvement
>Affects Versions: 3.4, 3.11
>Reporter: Kiruahxh
>Priority: Minor
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> For now, join(int[], char) is working well.
> However, the same join method called with a string delimiter behaves
> differently : it returns a single memory address which is not the desired
> behavior.
> I think that, for coherence, calling StringUtils with a char or String
> delimiter should return the exact same value.
> Ex :
> {code:java}
> CLASSPATH="./commons-lang3-3.11.jar" jshell
> | Welcome to JShell -- Version 11.0.8
> jshell> import org.apache.commons.lang3.StringUtils
> jshell> int[] arr = {1, 2, 3, 4, 5, 6, 7};
> jshell> String result = StringUtils.join(arr, '-');
> result ==> "1-2-3-4-5-6-7"
> jshell> String result = StringUtils.join(arr, "-");
> result ==> "[I@69663380-"
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter
coveralls edited a comment on pull request #784: URL: https://github.com/apache/commons-lang/pull/784#issuecomment-893057654 [](https://coveralls.io/builds/42276554) Coverage increased (+0.009%) to 94.994% when pulling **f18c98ef594fb9cc09ad0cb83eddb0f767e1437e on HubertWo:fix/LANG-1593-join-string-delimiter** into **ce477d9140f1439c44c7a852d7df1e069e21cb85 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (VALIDATOR-482) ISBN validator validates false for existing book
[ https://issues.apache.org/jira/browse/VALIDATOR-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401758#comment-17401758 ] Eugen Hanussek edited comment on VALIDATOR-482 at 8/19/21, 5:18 PM: Hi [~paulspeijers], the format you use is not valid for the validator. Use one of the following formats to check: "978-0-19-982823-4", // see Attachment "978 0 19 982823 4", "9780199828234", !image-2021-08-19-19-01-20-512.png! regards EUGen was (Author: homebeaver): Hi [~paulspeijers], the format you use is not valid for the validator. Use one of the following formats to check: "978-0-19-982823-4", // https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-482 "978 0 19 982823 4", "9780199828234", !image-2021-08-19-19-01-20-512.png! regards EUGen > ISBN validator validates false for existing book > > > Key: VALIDATOR-482 > URL: https://issues.apache.org/jira/browse/VALIDATOR-482 > Project: Commons Validator > Issue Type: Bug >Reporter: Paul Speijers >Priority: Major > Attachments: 482.PNG > > > For instance the following ISBN number exists but the validator returns false: > 978-0199828234 > https://www.worldcat.org/search?q=978-0199828234 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (VALIDATOR-482) ISBN validator validates false for existing book
[ https://issues.apache.org/jira/browse/VALIDATOR-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugen Hanussek updated VALIDATOR-482: - Attachment: 482.PNG > ISBN validator validates false for existing book > > > Key: VALIDATOR-482 > URL: https://issues.apache.org/jira/browse/VALIDATOR-482 > Project: Commons Validator > Issue Type: Bug >Reporter: Paul Speijers >Priority: Major > Attachments: 482.PNG > > > For instance the following ISBN number exists but the validator returns false: > 978-0199828234 > https://www.worldcat.org/search?q=978-0199828234 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (VALIDATOR-482) ISBN validator validates false for existing book
[ https://issues.apache.org/jira/browse/VALIDATOR-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401758#comment-17401758 ] Eugen Hanussek commented on VALIDATOR-482: -- Hi [~paulspeijers], the format you use is not valid for the validator. Use one of the following formats to check: "978-0-19-982823-4", // https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-482 "978 0 19 982823 4", "9780199828234", !image-2021-08-19-19-01-20-512.png! regards EUGen > ISBN validator validates false for existing book > > > Key: VALIDATOR-482 > URL: https://issues.apache.org/jira/browse/VALIDATOR-482 > Project: Commons Validator > Issue Type: Bug >Reporter: Paul Speijers >Priority: Major > > For instance the following ISBN number exists but the validator returns false: > 978-0199828234 > https://www.worldcat.org/search?q=978-0199828234 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] arturobernalg commented on pull request #793: Simplify bitwise operations with equivalent and simple.
arturobernalg commented on pull request #793: URL: https://github.com/apache/commons-lang/pull/793#issuecomment-902054847 > May you please rebase on master to pick up the recent Java 16 fix. Hi @garydgregory Done TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on pull request #792: Simplify assertions with equivalent but more simple.
arturobernalg commented on pull request #792: URL: https://github.com/apache/commons-lang/pull/792#issuecomment-902054487 > May you please rebase on master to pick up the recent Java 16 fix. HI @garydgregory Done TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #786: Lang-1657: Diff Result Type Constraint
coveralls edited a comment on pull request #786: URL: https://github.com/apache/commons-lang/pull/786#issuecomment-894606002 [](https://coveralls.io/builds/42272674) Coverage increased (+0.006%) to 94.991% when pulling **24e8f735272c915123cf58c9469fcfc2867c626d on greatmastermario:LANG-1657-DiffResult-Type-Constraint** into **ce477d9140f1439c44c7a852d7df1e069e21cb85 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1663) Wrong exception in various NumberUtils method documentations
[ https://issues.apache.org/jira/browse/LANG-1663?focusedWorklogId=639920=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639920 ] ASF GitHub Bot logged work on LANG-1663: Author: ASF GitHub Bot Created on: 19/Aug/21 15:54 Start Date: 19/Aug/21 15:54 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #785: URL: https://github.com/apache/commons-lang/pull/785#issuecomment-89455 [](https://coveralls.io/builds/42272655) Coverage remained the same at 94.985% when pulling **ba577cacc5355c830a013e73c431a8382ee717a7 on greatmastermario:LANG-1663-Wrong-Exception-Docs** into **ce477d9140f1439c44c7a852d7df1e069e21cb85 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639920) Time Spent: 1h 20m (was: 1h 10m) > Wrong exception in various NumberUtils method documentations > > > Key: LANG-1663 > URL: https://issues.apache.org/jira/browse/LANG-1663 > Project: Commons Lang > Issue Type: Bug > Components: lang.math.* >Affects Versions: 3.12.0 >Reporter: Tobias Helms >Priority: Minor > Labels: documentation > Time Spent: 1h 20m > Remaining Estimate: 0h > > The documentation of various methods in _NumberUtils_ says an > _IllegalArgumentException_ is thrown in case of a _null_ argument , e.g., see > [https://github.com/apache/commons-lang/blob/197d50434748bfb2db935266cfe740fc01a607ee/src/main/java/org/apache/commons/lang3/math/NumberUtils.java#L1194] > > However, these methods throw a _NullPointerException_ in this case. The > following methods are affected: > * long min(final long... array) > * int min(final int... array) > * short min(final short... array) > * byte min(final byte... array) > * static double min(final double... array) > * float min(final float... array) > * long max(final long... array) > * int max(final int... array) > * short max(final short... array) > * byte max(final byte... array) > * double max(final double... array) > * float max(final float... array) > * void validateArray(final Object array) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
coveralls edited a comment on pull request #785: URL: https://github.com/apache/commons-lang/pull/785#issuecomment-89455 [](https://coveralls.io/builds/42272655) Coverage remained the same at 94.985% when pulling **ba577cacc5355c830a013e73c431a8382ee717a7 on greatmastermario:LANG-1663-Wrong-Exception-Docs** into **ce477d9140f1439c44c7a852d7df1e069e21cb85 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (LANG-1669) Known Failure in Java 16 When Parsing sq_MK Locale
[ https://issues.apache.org/jira/browse/LANG-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1669. --- Fix Version/s: 3.13.0 Resolution: Fixed [~greatmastermario] Thank you for the PR. Merged. Please verify and close this ticket if ok. > Known Failure in Java 16 When Parsing sq_MK Locale > -- > > Key: LANG-1669 > URL: https://issues.apache.org/jira/browse/LANG-1669 > Project: Commons Lang > Issue Type: Bug > Components: lang.time.* >Affects Versions: 3.12.0 > Environment: OpenJDK 16 >Reporter: Andrew Thomas >Priority: Major > Fix For: 3.13.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > There is a known issue that I do not see tracked already. In Java 16, there > is a failure when parsing sq_MK locale. This is not an issue with Apache > Commons-Lang, but an issue with the addition of day period support in OpenJDK > version 16. This is resolved in JDK 17, but there are still build failures in > JDK 16 due to this bug with OpenJDK. > See [[JDK-8262108] SimpleDateFormat formatting broken for sq_MK Locale - Java > Bug System|https://bugs-stage.openjdk.java.net/browse/JDK-8262108] > and [8262108: SimpleDateFormat formatting broken for sq_MK Locale · > openjdk/jdk@64e2130 > (github.com)|https://github.com/openjdk/jdk/commit/64e21307] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639867=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639867 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 13:57 Start Date: 19/Aug/21 13:57 Worklog Time Spent: 10m Work Description: jochenw merged pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639867) Time Spent: 2h 10m (was: 2h) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] jochenw merged pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
jochenw merged pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639865=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639865 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 13:55 Start Date: 19/Aug/21 13:55 Worklog Time Spent: 10m Work Description: jochenw commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901936387 > About CI: I could preserve the JDK 8 in GHA and TravisCi and run just `mvn test` when JDK==1.8. Is this OK ? Go for it, please! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639865) Time Spent: 2h (was: 1h 50m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] jochenw commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
jochenw commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901936387 > About CI: I could preserve the JDK 8 in GHA and TravisCi and run just `mvn test` when JDK==1.8. Is this OK ? Go for it, please! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639846=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639846 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 13:27 Start Date: 19/Aug/21 13:27 Worklog Time Spent: 10m Work Description: martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901915469 Wicket does not use reflection, so no need to `open` (at least for Wicket). @GedMarc Please check this PR. ``` // use JDK 9+ mvn package cd target unzip commons-fileupload2-2.0-SNAPSHOT.jar javap META-INF/versions/9/module-info.class ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639846) Time Spent: 1h 50m (was: 1h 40m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901915469 Wicket does not use reflection, so no need to `open` (at least for Wicket). @GedMarc Please check this PR. ``` // use JDK 9+ mvn package cd target unzip commons-fileupload2-2.0-SNAPSHOT.jar javap META-INF/versions/9/module-info.class ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1663) Wrong exception in various NumberUtils method documentations
[ https://issues.apache.org/jira/browse/LANG-1663?focusedWorklogId=639840=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639840 ] ASF GitHub Bot logged work on LANG-1663: Author: ASF GitHub Bot Created on: 19/Aug/21 13:14 Start Date: 19/Aug/21 13:14 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #785: URL: https://github.com/apache/commons-lang/pull/785#issuecomment-901905417 May you please rebase on master to pick up the recent Java 16 fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639840) Time Spent: 1h 10m (was: 1h) > Wrong exception in various NumberUtils method documentations > > > Key: LANG-1663 > URL: https://issues.apache.org/jira/browse/LANG-1663 > Project: Commons Lang > Issue Type: Bug > Components: lang.math.* >Affects Versions: 3.12.0 >Reporter: Tobias Helms >Priority: Minor > Labels: documentation > Time Spent: 1h 10m > Remaining Estimate: 0h > > The documentation of various methods in _NumberUtils_ says an > _IllegalArgumentException_ is thrown in case of a _null_ argument , e.g., see > [https://github.com/apache/commons-lang/blob/197d50434748bfb2db935266cfe740fc01a607ee/src/main/java/org/apache/commons/lang3/math/NumberUtils.java#L1194] > > However, these methods throw a _NullPointerException_ in this case. The > following methods are affected: > * long min(final long... array) > * int min(final int... array) > * short min(final short... array) > * byte min(final byte... array) > * static double min(final double... array) > * float min(final float... array) > * long max(final long... array) > * int max(final int... array) > * short max(final short... array) > * byte max(final byte... array) > * double max(final double... array) > * float max(final float... array) > * void validateArray(final Object array) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639839=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639839 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 13:13 Start Date: 19/Aug/21 13:13 Worklog Time Spent: 10m Work Description: GedMarc commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901904644 So to give an idea - I was asked to move all the apache commons libraries to be compatible for JPMS - https://github.com/GedMarc/JPMSPendingParent/issues/1 I completed the entire suite (https://github.com/GedMarc/GuicedEE-Services) everything that starts with "commons-" JPMS compatible means being native build compatible (JLink,JPackage, JMod) so automatic-module-names aren't allowed and you have to include a module-info.class I've completed them all (except maths4 which has some not-deployed dependencies?), And believe I can help out with experience of doing them all, and getting it working -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639839) Time Spent: 1h 40m (was: 1.5h) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory commented on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
garydgregory commented on pull request #785: URL: https://github.com/apache/commons-lang/pull/785#issuecomment-901905417 May you please rebase on master to pick up the recent Java 16 fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #786: Lang-1657: Diff Result Type Constraint
garydgregory commented on pull request #786: URL: https://github.com/apache/commons-lang/pull/786#issuecomment-901905299 May you please rebase on master to pick up the recent Java 16 fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #792: Simplify assertions with equivalent but more simple.
garydgregory commented on pull request #792: URL: https://github.com/apache/commons-lang/pull/792#issuecomment-901904921 May you please rebase on master to pick up the recent Java 16 fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #793: Simplify bitwise operations with equivalent and simple.
garydgregory commented on pull request #793: URL: https://github.com/apache/commons-lang/pull/793#issuecomment-901904784 May you please rebase on master to pick up the recent Java 16 fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] GedMarc commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
GedMarc commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901904644 So to give an idea - I was asked to move all the apache commons libraries to be compatible for JPMS - https://github.com/GedMarc/JPMSPendingParent/issues/1 I completed the entire suite (https://github.com/GedMarc/GuicedEE-Services) everything that starts with "commons-" JPMS compatible means being native build compatible (JLink,JPackage, JMod) so automatic-module-names aren't allowed and you have to include a module-info.class I've completed them all (except maths4 which has some not-deployed dependencies?), And believe I can help out with experience of doing them all, and getting it working -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1669) Known Failure in Java 16 When Parsing sq_MK Locale
[ https://issues.apache.org/jira/browse/LANG-1669?focusedWorklogId=639838=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639838 ] ASF GitHub Bot logged work on LANG-1669: Author: ASF GitHub Bot Created on: 19/Aug/21 13:11 Start Date: 19/Aug/21 13:11 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #791: URL: https://github.com/apache/commons-lang/pull/791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639838) Time Spent: 0.5h (was: 20m) > Known Failure in Java 16 When Parsing sq_MK Locale > -- > > Key: LANG-1669 > URL: https://issues.apache.org/jira/browse/LANG-1669 > Project: Commons Lang > Issue Type: Bug > Components: lang.time.* >Affects Versions: 3.12.0 > Environment: OpenJDK 16 >Reporter: Andrew Thomas >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > There is a known issue that I do not see tracked already. In Java 16, there > is a failure when parsing sq_MK locale. This is not an issue with Apache > Commons-Lang, but an issue with the addition of day period support in OpenJDK > version 16. This is resolved in JDK 17, but there are still build failures in > JDK 16 due to this bug with OpenJDK. > See [[JDK-8262108] SimpleDateFormat formatting broken for sq_MK Locale - Java > Bug System|https://bugs-stage.openjdk.java.net/browse/JDK-8262108] > and [8262108: SimpleDateFormat formatting broken for sq_MK Locale · > openjdk/jdk@64e2130 > (github.com)|https://github.com/openjdk/jdk/commit/64e21307] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #791: LANG-1669: OpenJDK 16 Day Period Parsing
garydgregory merged pull request #791: URL: https://github.com/apache/commons-lang/pull/791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639835=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639835 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 13:07 Start Date: 19/Aug/21 13:07 Worklog Time Spent: 10m Work Description: GedMarc commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901900197 @martin-g Yes but that's closer to improperly placed classes? Exporting all is fine, opens clauses for things like wicket that reflect into the library will also need to be considered, invalid access will come about, and on JDK 17 when its disallowed completely, the library will be considered broken? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639835) Time Spent: 1.5h (was: 1h 20m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] GedMarc commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
GedMarc commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901900197 @martin-g Yes but that's closer to improperly placed classes? Exporting all is fine, opens clauses for things like wicket that reflect into the library will also need to be considered, invalid access will come about, and on JDK 17 when its disallowed completely, the library will be considered broken? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639833=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639833 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 13:05 Start Date: 19/Aug/21 13:05 Worklog Time Spent: 10m Work Description: martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901898390 > You should pre-build your module file and include it moditect, but definitely do not auto generate from it @GedMarc You mean we should not include the `impl` package (added by the auto-generation) ? I am afraid this will break many applications which already use classes from `impl`. I know that Apache Wicket does use them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639833) Time Spent: 1h 20m (was: 1h 10m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901898390 > You should pre-build your module file and include it moditect, but definitely do not auto generate from it @GedMarc You mean we should not include the `impl` package (added by the auto-generation) ? I am afraid this will break many applications which already use classes from `impl`. I know that Apache Wicket does use them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639830=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639830 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 13:04 Start Date: 19/Aug/21 13:04 Worklog Time Spent: 10m Work Description: jochenw commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901897548 I like the idea of having a profile, that is activated by JDK >= 9, and keeping the JDK 8 build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639830) Time Spent: 1h (was: 50m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639831=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639831 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 13:04 Start Date: 19/Aug/21 13:04 Worklog Time Spent: 10m Work Description: GedMarc commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901897526 There will be heavy things for Jakarta servlet compatibility, transitive and static clauses to support both eventually, Hiding internal classes and packages when sealed/non-sealed come along, There's a lot more to think about than just auto generate, and from the experience with jackson json, it is almost guaranteed you will need to customize it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639831) Time Spent: 1h 10m (was: 1h) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] GedMarc commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
GedMarc commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901897526 There will be heavy things for Jakarta servlet compatibility, transitive and static clauses to support both eventually, Hiding internal classes and packages when sealed/non-sealed come along, There's a lot more to think about than just auto generate, and from the experience with jackson json, it is almost guaranteed you will need to customize it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
jochenw commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901897548 I like the idea of having a profile, that is activated by JDK >= 9, and keeping the JDK 8 build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639828=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639828 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 13:02 Start Date: 19/Aug/21 13:02 Worklog Time Spent: 10m Work Description: GedMarc commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901895975 it is not that simple at all though - https://github.com/GedMarc/GuicedEE-Services/blob/master/commons-fileupload/src/moditect/module-info.java You should pre-build your module file and include it moditect, but definitely do not auto generate from it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639828) Time Spent: 50m (was: 40m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] GedMarc commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
GedMarc commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901895975 it is not that simple at all though - https://github.com/GedMarc/GuicedEE-Services/blob/master/commons-fileupload/src/moditect/module-info.java You should pre-build your module file and include it moditect, but definitely do not auto generate from it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639827=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639827 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 13:00 Start Date: 19/Aug/21 13:00 Worklog Time Spent: 10m Work Description: martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901894181 Actually, I could disable the moditect plugin by default. This way everyone could build with JDK 1.8. But the release manager will have to enable it. I see there is a `release` profile in the parent pom already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639827) Time Spent: 40m (was: 0.5h) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901894181 Actually, I could disable the moditect plugin by default. This way everyone could build with JDK 1.8. But the release manager will have to enable it. I see there is a `release` profile in the parent pom already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639823=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639823 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 12:55 Start Date: 19/Aug/21 12:55 Worklog Time Spent: 10m Work Description: martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901891128 About CI: I could preserve the JDK 8 in GHA and TravisCi and run just `mvn test` when JDK==1.8. Is this OK ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639823) Time Spent: 0.5h (was: 20m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901891128 About CI: I could preserve the JDK 8 in GHA and TravisCi and run just `mvn test` when JDK==1.8. Is this OK ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639822=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639822 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 12:54 Start Date: 19/Aug/21 12:54 Worklog Time Spent: 10m Work Description: martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901890506 > Besides, please add yourself to the contributors list In the pom.xml ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639822) Time Spent: 20m (was: 10m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-901890506 > Besides, please add yourself to the contributors list In the pom.xml ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-graph] coderodde opened a new pull request #6: Load balance the bidirectional Dijkstra's algorithm
coderodde opened a new pull request #6: URL: https://github.com/apache/commons-graph/pull/6 Since bidirectional Dijkstra's algorithm grows two search areas growing towards each other, it makes sense to remove the next node to settle from the smaller search area. (In the opposite case, it would degrade to a unidirectional Dijkstra's algorithm). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639816=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639816 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 19/Aug/21 12:35 Start Date: 19/Aug/21 12:35 Worklog Time Spent: 10m Work Description: martin-g opened a new pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107 Use moditect-maven-plugin to add auto-generated module-info.class into META-INF/versions/9/ IMPORTANT: Now the build requires JDK 9+! The produced jar is JDK 1.8 compatible! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 639816) Remaining Estimate: 0h Time Spent: 10m > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401670#comment-17401670 ] Martin Tzvetanov Grigorov commented on FILEUPLOAD-340: -- https://github.com/apache/commons-fileupload/pull/107 > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] martin-g opened a new pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g opened a new pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107 Use moditect-maven-plugin to add auto-generated module-info.class into META-INF/versions/9/ IMPORTANT: Now the build requires JDK 9+! The produced jar is JDK 1.8 compatible! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SANDBOX-512) Load balance the bidirectional Dijkstra's algorithm
Rodion Efremov created SANDBOX-512: -- Summary: Load balance the bidirectional Dijkstra's algorithm Key: SANDBOX-512 URL: https://issues.apache.org/jira/browse/SANDBOX-512 Project: Commons Sandbox Issue Type: Improvement Components: Graph Reporter: Rodion Efremov When iterating the outer loop, pop the new vertex from the smaller search frontiers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401641#comment-17401641 ] Martin Tzvetanov Grigorov commented on FILEUPLOAD-340: -- OK! I will work on PR then! > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401638#comment-17401638 ] Jochen Wiedmann commented on FILEUPLOAD-340: Not for 2.0. We're being incompatible anyways. > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401637#comment-17401637 ] Martin Tzvetanov Grigorov edited comment on FILEUPLOAD-340 at 8/19/21, 11:24 AM: - Before preparing a Pull Request I'd like to ask you whether you see any problem with making releases with JDK 9+ and javac -release=1.8 ? was (Author: mgrigorov): Before prepare a Pull Request I'd like to ask you whether you see any problem with making releases with JDK 9+ and javac -release=1.8 ? > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401637#comment-17401637 ] Martin Tzvetanov Grigorov commented on FILEUPLOAD-340: -- Before prepare a Pull Request I'd like to ask you whether you see any problem with making releases with JDK 9+ and javac -release=1.8 ? > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401636#comment-17401636 ] Jochen Wiedmann commented on FILEUPLOAD-340: Patches welcome! > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COLLECTIONS-797) An indexed, doubly-linked list data structure running some operations in O(sqrt(n)) time instead of O(n)
[ https://issues.apache.org/jira/browse/COLLECTIONS-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rodion Efremov updated COLLECTIONS-797: --- Description: The data structure in question lives in [GitHub|https://github.com/coderodde/LinkedList]. The idea is that we maintain sqrt(N/2) so called "fingers" along the actual list. Each finger contains a reference to a list node and an index of that node. Now, when we need to access a node via an index, we don't have to scan through the entire linked list, but, instead, only consult all the finger, choose the closest finger, and iterate from the respective node towards the target node. If the fingers are distributely evenly, also traversal from the node pointed by a finger to the target node will require O(sqrt(N)) time. While not (quite) as efficient as the TreeList, my LinkedList requires less memory: where TreeList requires 3 references, 2 ints and 2 booleans per node, my list requires only 3 references per node + ceil(sqrt(N/2)) fingers, one reference and one int per finger. was: The data structure in question lives in [GitHub|https://github.com/coderodde/LinkedList]. The idea is that we maintain sqrt(N/2) so called "fingers" along the actual list. Each finger contains a reference to a list node and an index of that node. Now, when we need to access a node via an index, we don't have to scan through the entire linked list, but, instead, only consult all the finger, choose the closest finger, and iterate from the respective node towards the target node. If the fingers are distributely evenly, also traversal from the node pointed by a finger to the target node will require O(sqrt(N)) time. While not as efficient as the TreeList, my LinkedList requires less memory: where TreeList requires 3 references, 2 ints and 2 booleans per node, my list requires only 3 references per node + ceil(sqrt(N/2)) fingers, one reference and one int per finger. > An indexed, doubly-linked list data structure running some operations in > O(sqrt(n)) time instead of O(n) > > > Key: COLLECTIONS-797 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-797 > Project: Commons Collections > Issue Type: Improvement > Components: Collection >Reporter: Rodion Efremov >Priority: Minor > Labels: beginner, newbie, performance > > The data structure in question lives in > [GitHub|https://github.com/coderodde/LinkedList]. > > The idea is that we maintain sqrt(N/2) so called "fingers" along the actual > list. Each finger contains a reference to a list node and an index of that > node. Now, when we need to access a node via an index, we don't have to scan > through the entire linked list, but, instead, only consult all the finger, > choose the closest finger, and iterate from the respective node towards the > target node. > > If the fingers are distributely evenly, also traversal from the node pointed > by a finger to the target node will require O(sqrt(N)) time. > > While not (quite) as efficient as the TreeList, my LinkedList requires less > memory: where TreeList requires 3 references, 2 ints and 2 booleans per node, > my list requires only 3 references per node + ceil(sqrt(N/2)) fingers, one > reference and one int per finger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COLLECTIONS-797) An indexed, doubly-linked list data structure running some operations in O(sqrt(n)) time instead of O(n)
[ https://issues.apache.org/jira/browse/COLLECTIONS-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rodion Efremov updated COLLECTIONS-797: --- Description: The data structure in question lives in [GitHub|https://github.com/coderodde/LinkedList]. The idea is that we maintain sqrt(N/2) so called "fingers" along the actual list. Each finger contains a reference to a list node and an index of that node. Now, when we need to access a node via an index, we don't have to scan through the entire linked list, but, instead, only consult all the finger, choose the closest finger, and iterate from the respective node towards the target node. If the fingers are distributely evenly, also traversal from the node pointed by a finger to the target node will require O(sqrt(N)) time. While not as efficient as the TreeList, my LinkedList requires less memory: where TreeList requires 3 references, 2 ints and 2 booleans per node, my list requires only 3 references per node + ceil(sqrt(N/2)) fingers, one reference and one int per finger. was: The data structure in question lives in [GitHub|https://github.com/coderodde/LinkedList]. The idea is that we maintain sqrt(N/2) so called "fingers" along the actual list. Each finger contains a reference to a list node and an index of that node. Now, when we need to access a node via an index, we don't have to scan through the entire linked list, but, instead, only consult all the finger, choose the closest finger, and iterate from the respective node towards the target node. If the fingers are distributely evenly, also traversal from the node pointed by a finger to the target node will require O(sqrt(N)) time. While not as efficient as the TreeList, my LinkedList requires less memory: where TreeList requires 3 references, 2 ints and 2 booleans per node, my list requires only 3 references per node + ceil(N/2) fingers, one reference and one int per finger. > An indexed, doubly-linked list data structure running some operations in > O(sqrt(n)) time instead of O(n) > > > Key: COLLECTIONS-797 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-797 > Project: Commons Collections > Issue Type: Improvement > Components: Collection >Reporter: Rodion Efremov >Priority: Minor > Labels: beginner, newbie, performance > > The data structure in question lives in > [GitHub|https://github.com/coderodde/LinkedList]. > > The idea is that we maintain sqrt(N/2) so called "fingers" along the actual > list. Each finger contains a reference to a list node and an index of that > node. Now, when we need to access a node via an index, we don't have to scan > through the entire linked list, but, instead, only consult all the finger, > choose the closest finger, and iterate from the respective node towards the > target node. > > If the fingers are distributely evenly, also traversal from the node pointed > by a finger to the target node will require O(sqrt(N)) time. > > While not as efficient as the TreeList, my LinkedList requires less memory: > where TreeList requires 3 references, 2 ints and 2 booleans per node, my list > requires only 3 references per node + ceil(sqrt(N/2)) fingers, one reference > and one int per finger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COLLECTIONS-797) An indexed, doubly-linked list data structure running some operations in O(sqrt(n)) time instead of O(n)
[ https://issues.apache.org/jira/browse/COLLECTIONS-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rodion Efremov updated COLLECTIONS-797: --- Description: The data structure in question lives in [GitHub|https://github.com/coderodde/LinkedList]. The idea is that we maintain sqrt(N/2) so called "fingers" along the actual list. Each finger contains a reference to a list node and an index of that node. Now, when we need to access a node via an index, we don't have to scan through the entire linked list, but, instead, only consult all the finger, choose the closest finger, and iterate from the respective node towards the target node. If the fingers are distributely evenly, also traversal from the node pointed by a finger to the target node will require O(sqrt(N)) time. While not as efficient as the TreeList, my LinkedList requires less memory: where TreeList requires 3 references, 2 ints and 2 booleans per node, my list requires only 3 references per node + ceil(N/2) fingers, one reference and one int per finger. was: The data structure in question lives in [GitHub|https://github.com/coderodde/LinkedList]. The idea is that we maintain sqrt(N/2) so called "fingers" along the actual list. Each finger contains a reference to a list node and an index of that node. Now, when we need to access a node via an index, we don't have to scan through the entire linked list, but, instead, only consult all the finger, choose the closest finger, and iterate from the respective node towards the target node. If the fingers are distributely evenly, also traversal from the node pointed by a finger to the target node will require O(sqrt(N)) time. While not as efficient as the TreeList, my LinkedList requires less memory: where TreeList requires 3 references, 2 ints and 2 booleans per node, my list requires only 3 references + ceil(N/2) fingers, one reference and one int per finger. > An indexed, doubly-linked list data structure running some operations in > O(sqrt(n)) time instead of O(n) > > > Key: COLLECTIONS-797 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-797 > Project: Commons Collections > Issue Type: Improvement > Components: Collection >Reporter: Rodion Efremov >Priority: Minor > Labels: beginner, newbie, performance > > The data structure in question lives in > [GitHub|https://github.com/coderodde/LinkedList]. > > The idea is that we maintain sqrt(N/2) so called "fingers" along the actual > list. Each finger contains a reference to a list node and an index of that > node. Now, when we need to access a node via an index, we don't have to scan > through the entire linked list, but, instead, only consult all the finger, > choose the closest finger, and iterate from the respective node towards the > target node. > > If the fingers are distributely evenly, also traversal from the node pointed > by a finger to the target node will require O(sqrt(N)) time. > > While not as efficient as the TreeList, my LinkedList requires less memory: > where TreeList requires 3 references, 2 ints and 2 booleans per node, my list > requires only 3 references per node + ceil(N/2) fingers, one reference and > one int per finger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COLLECTIONS-797) An indexed, doubly-linked list data structure running some operations in O(sqrt(n)) time instead of O(n)
[ https://issues.apache.org/jira/browse/COLLECTIONS-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rodion Efremov updated COLLECTIONS-797: --- Description: The data structure in question lives in [GitHub|https://github.com/coderodde/LinkedList]. The idea is that we maintain sqrt(N/2) so called "fingers" along the actual list. Each finger contains a reference to a list node and an index of that node. Now, when we need to access a node via an index, we don't have to scan through the entire linked list, but, instead, only consult all the finger, choose the closest finger, and iterate from the respective node towards the target node. If the fingers are distributely evenly, also traversal from the node pointed by a finger to the target node will require O(sqrt(N)) time. While not as efficient as the TreeList, my LinkedList requires less memory: where TreeList requires 3 references, 2 ints and 2 booleans per node, my list requires only 3 references + ceil(N/2) fingers, one reference and one int per finger. was: The data structure in question lives in [GitHub|https://github.com/coderodde/LinkedList]. The idea is that we maintain sqrt(N/2) so called "fingers" along the actual list. Each finger contains a reference to a list node and an index of that node. Now, when we need to access a node via an index, we don't have to scan through the entire linked list, but, instead, only consult all the finger, choose the closest finger, and iterate from the respective node towards the target node. If the fingers are distributely evenly, also traversal from the node pointed by a finger to the target node will require O(sqrt(N)) time. > An indexed, doubly-linked list data structure running some operations in > O(sqrt(n)) time instead of O(n) > > > Key: COLLECTIONS-797 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-797 > Project: Commons Collections > Issue Type: Improvement > Components: Collection >Reporter: Rodion Efremov >Priority: Minor > Labels: beginner, newbie, performance > > The data structure in question lives in > [GitHub|https://github.com/coderodde/LinkedList]. > > The idea is that we maintain sqrt(N/2) so called "fingers" along the actual > list. Each finger contains a reference to a list node and an index of that > node. Now, when we need to access a node via an index, we don't have to scan > through the entire linked list, but, instead, only consult all the finger, > choose the closest finger, and iterate from the respective node towards the > target node. > > If the fingers are distributely evenly, also traversal from the node pointed > by a finger to the target node will require O(sqrt(N)) time. > > While not as efficient as the TreeList, my LinkedList requires less memory: > where TreeList requires 3 references, 2 ints and 2 booleans per node, my list > requires only 3 references + ceil(N/2) fingers, one reference and one int > per finger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COLLECTIONS-797) An indexed, doubly-linked list data structure running some operations in O(sqrt(n)) time instead of O(n)
Rodion Efremov created COLLECTIONS-797: -- Summary: An indexed, doubly-linked list data structure running some operations in O(sqrt(n)) time instead of O(n) Key: COLLECTIONS-797 URL: https://issues.apache.org/jira/browse/COLLECTIONS-797 Project: Commons Collections Issue Type: Improvement Components: Collection Reporter: Rodion Efremov The data structure in question lives in [GitHub|https://github.com/coderodde/LinkedList]. The idea is that we maintain sqrt(N/2) so called "fingers" along the actual list. Each finger contains a reference to a list node and an index of that node. Now, when we need to access a node via an index, we don't have to scan through the entire linked list, but, instead, only consult all the finger, choose the closest finger, and iterate from the respective node towards the target node. If the fingers are distributely evenly, also traversal from the node pointed by a finger to the target node will require O(sqrt(N)) time. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
Martin Tzvetanov Grigorov created FILEUPLOAD-340: Summary: Make commons-fileupload a proper JPMS module Key: FILEUPLOAD-340 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 Project: Commons FileUpload Issue Type: Improvement Affects Versions: 2.0 Reporter: Martin Tzvetanov Grigorov It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. At the moment the project uses JDK 1.8 for the builds. To add module-info.java it would have to use JDK 9+ (probably 11) with -release=1.8. An easy way to introduce module-info.java is by using [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #793: Simplify bitwise operations with equivalent and simple.
coveralls commented on pull request #793: URL: https://github.com/apache/commons-lang/pull/793#issuecomment-901664909 [](https://coveralls.io/builds/42259812) Coverage remained the same at 94.984% when pulling **f19bf13230d9631215457c05d6f559a64f15b0b1 on arturobernalg:feature/simplify_bitwise** into **a6df7f74564b9432bf38fe33c4adc0bc529bf7c9 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COLLECTIONS-796) SetUniqueList.createSetBasedOnList doesn't add list elements to return value
Owen Mansel-Chan created COLLECTIONS-796: Summary: SetUniqueList.createSetBasedOnList doesn't add list elements to return value Key: COLLECTIONS-796 URL: https://issues.apache.org/jira/browse/COLLECTIONS-796 Project: Commons Collections Issue Type: Bug Components: List Affects Versions: 4.4, 4.3 Reporter: Owen Mansel-Chan SetUniqueList.createSetBasedOnList doesn't add list elements to the return value any more. The documentation says it does, and it used to up to version 4.2, but a call to `addAll` was accidentally deleted. I found where the mistake was introduced on github: https://github.com/apache/commons-collections/commit/b1c45ac691d46a8c609f2534d2adfa59c0599527#diff-8e53271d5d8299a76d43b0e3c81740fbe660083ae71c5bf2be63846d52156f23L344 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #792: Simplify assertions with equivalent but more simple.
coveralls commented on pull request #792: URL: https://github.com/apache/commons-lang/pull/792#issuecomment-901663987 [](https://coveralls.io/builds/42259783) Coverage remained the same at 94.984% when pulling **404c79979c88fd48323bdce2981b3388d5e5dceb on arturobernalg:feature/simplify_assert** into **a6df7f74564b9432bf38fe33c4adc0bc529bf7c9 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] owen-mc commented on pull request #49: [SetUniqueList] avoid use of deprecated newInstance
owen-mc commented on pull request #49: URL: https://github.com/apache/commons-collections/pull/49#issuecomment-901659018 I'm pretty sure this call to `addAll` shouldn't have been deleted: https://github.com/apache/commons-collections/commit/b1c45ac691d46a8c609f2534d2adfa59c0599527#diff-8e53271d5d8299a76d43b0e3c81740fbe660083ae71c5bf2be63846d52156f23L344 I don't see how the elements of `list` are added to the returned set without it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
