[jira] [Updated] (GEOMETRY-70) Use MathJax
[ https://issues.apache.org/jira/browse/GEOMETRY-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Juntunen updated GEOMETRY-70: -- Fix Version/s: (was: 1.0) 1.1 > Use MathJax > --- > > Key: GEOMETRY-70 > URL: https://issues.apache.org/jira/browse/GEOMETRY-70 > Project: Apache Commons Geometry > Issue Type: Task >Reporter: Matt Juntunen >Priority: Minor > Labels: easytask, newbie > Fix For: 1.1 > > > Use MathJax in JavaDocs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] kinow closed pull request #259: Bump mockito-inline from 3.12.0 to 3.12.1
kinow closed pull request #259: URL: https://github.com/apache/commons-text/pull/259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] commented on pull request #259: Bump mockito-inline from 3.12.0 to 3.12.1
dependabot[bot] commented on pull request #259: URL: https://github.com/apache/commons-text/pull/259#issuecomment-902968524 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] coveralls commented on pull request #259: Bump mockito-inline from 3.12.0 to 3.12.1
coveralls commented on pull request #259: URL: https://github.com/apache/commons-text/pull/259#issuecomment-902963022 [](https://coveralls.io/builds/42309186) Coverage remained the same at 97.865% when pulling **509b11997920050fcbaa50c2264948524a69eb23 on dependabot/maven/org.mockito-mockito-inline-3.12.1** into **a8fc10dccb4750e8add23fe9ee5ba494c9aa7305 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request #259: Bump mockito-inline from 3.12.0 to 3.12.1
dependabot[bot] opened a new pull request #259: URL: https://github.com/apache/commons-text/pull/259 Bumps [mockito-inline](https://github.com/mockito/mockito) from 3.12.0 to 3.12.1. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-inline's releases. v3.12.1 Changelog generated by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog Gradle Plugin 3.12.1 2021-08-20 - https://github.com/mockito/mockito/compare/v3.12.0...v3.12.1;>2 commit(s) by Tim van der Lippe, dependabot[bot] Fix verifyNoMoreInteractions inOrder invocations for spies [(https://github-redirect.dependabot.com/mockito/mockito/issues/2395;>#2395)](https://github-redirect.dependabot.com/mockito/mockito/pull/2395;>mockito/mockito#2395) Regression with InOrder verification after https://github-redirect.dependabot.com/mockito/mockito/issues/2369;>#2369 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2394;>#2394)](https://github-redirect.dependabot.com/mockito/mockito/issues/2394;>mockito/mockito#2394) Bump versions.bytebuddy from 1.11.12 to 1.11.13 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2393;>#2393)](https://github-redirect.dependabot.com/mockito/mockito/pull/2393;>mockito/mockito#2393) Commits https://github.com/mockito/mockito/commit/da6e8f73d805b8ed845bae32e745e3d6bf35a261;>da6e8f7 Fix verifyNoMoreInteractions inOrder invocations for spies (https://github-redirect.dependabot.com/mockito/mockito/issues/2395;>#2395) https://github.com/mockito/mockito/commit/a53c3d451e756b51a96700624f517f4fcdd07aed;>a53c3d4 Bump versions.bytebuddy from 1.11.12 to 1.11.13 (https://github-redirect.dependabot.com/mockito/mockito/issues/2393;>#2393) See full diff in https://github.com/mockito/mockito/compare/v3.12.0...v3.12.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COMPRESS-588) String comparison using == instead of .equals() in SegmentConstantPoolArrayCache
Haakon M created COMPRESS-588: - Summary: String comparison using == instead of .equals() in SegmentConstantPoolArrayCache Key: COMPRESS-588 URL: https://issues.apache.org/jira/browse/COMPRESS-588 Project: Commons Compress Issue Type: Bug Affects Versions: 1.21 Environment: Veracode Static code analysis Reporter: Haakon M Hi We use Commons Compress as a dependency in our application. Our static scan tool picked up a String comparison in SegmentConstantPoolArray:61 using == instead of .equals. I had a quick look at the file in question, and it seems that you're trying to actually check if the two objects are the same, and so are using == in the correct manner. But I wasn't certain, so I'm making this issue anyways, just to be sure. The file and line in question: [https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=blob;f=src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentConstantPoolArrayCache.java;h=2f6a7f06f3fb8c8c57fd5875090c9624b767e681;hb=HEAD#l61] Thanks -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-pool] coveralls commented on pull request #96: Bump junit-bom from 5.8.0-M1 to 5.8.0-RC1
coveralls commented on pull request #96: URL: https://github.com/apache/commons-pool/pull/96#issuecomment-902763870 [](https://coveralls.io/builds/42300620) Coverage decreased (-0.06%) to 85.026% when pulling **1a837cfb6dad7ad71dd2cedaa79c33931ee9ec14 on dependabot/maven/org.junit-junit-bom-5.8.0-RC1** into **ce4a44e56bbedca9ba54d7a0348067d97b3c4318 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=640217=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640217 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 20/Aug/21 12:19 Start Date: 20/Aug/21 12:19 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902651897 [](https://coveralls.io/builds/42296738) Coverage decreased (-0.02%) to 78.1% when pulling **79d91fd9f5b803dca23ca269b073361de051e6e3 on martin-g:FILEUPLOAD-342-remove-deprecated-methods-in-FileUploadBase** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640217) Time Spent: 0.5h (was: 20m) > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] coveralls commented on pull request #109: FILEUPLOAD-342 Remove methods which use javax|jakarta classes from FileUploadBase
coveralls commented on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902651897 [](https://coveralls.io/builds/42296738) Coverage decreased (-0.02%) to 78.1% when pulling **79d91fd9f5b803dca23ca269b073361de051e6e3 on martin-g:FILEUPLOAD-342-remove-deprecated-methods-in-FileUploadBase** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] dependabot[bot] opened a new pull request #96: Bump junit-bom from 5.8.0-M1 to 5.8.0-RC1
dependabot[bot] opened a new pull request #96: URL: https://github.com/apache/commons-pool/pull/96 Bumps [junit-bom](https://github.com/junit-team/junit5) from 5.8.0-M1 to 5.8.0-RC1. Release notes Sourced from https://github.com/junit-team/junit5/releases;>junit-bom's releases. JUnit 5.8.0-RC1 = Platform 1.8.0-RC1 + Jupiter 5.8.0-RC1 + Vintage 5.8.0-RC1 See http://junit.org/junit5/docs/5.8.0-RC1/release-notes/;>Release Notes. Commits https://github.com/junit-team/junit5/commit/f79262d889c03a0adb66055489001cab0054af9d;>f79262d Release 5.8.0-RC1 https://github.com/junit-team/junit5/commit/c2783ac9d567ddff8b91a3799b5632181e43ac1e;>c2783ac Upgradle to 7.2 https://github.com/junit-team/junit5/commit/44e2a3c747d03f3e293ec9a984fb37d4747e7d0f;>44e2a3c Prepare scope for release notes for 5.8 RC1 https://github.com/junit-team/junit5/commit/ffebb548c8d977badd5ba0d533c39146972aa06b;>ffebb54 Prepare release notes for 5.8 RC1 https://github.com/junit-team/junit5/commit/8b5387c5bef050730d8feb52a5292a32530f65cd;>8b5387c Support declarative extension registration on fields and parameters https://github.com/junit-team/junit5/commit/b8e44fac9d525303792bd20f864916fc836c4318;>b8e44fa Document support for https://github.com/ExtendWith;>@ExtendWith on parameters and fields https://github.com/junit-team/junit5/commit/e4804cba6ef66b9742e0197d060ca50e879d9b80;>e4804cb Disallow duplicate registration via https://github.com/RegisterExtension;>@RegisterExtension and https://github.com/ExtendWith;>@ExtendWith https://github.com/junit-team/junit5/commit/f149ad675da45f0e951b2b1951d6c2fcda73cf1d;>f149ad6 Allow @RegisterExtension/https://github.com/ExtendWith;>@ExtendWith fields to be sorted relative to each other https://github.com/junit-team/junit5/commit/cc9690bd9581c10443d70367d8493c0f1bb9f1f4;>cc9690b Allow https://github.com/ExtendWith;>@ExtendWith to be declared directly on fields and parameters https://github.com/junit-team/junit5/commit/3480fc80bb2bda415f875b1ac0de8b671d332b1d;>3480fc8 Allow https://github.com/RegisterExtension;>@RegisterExtension fields to be private Additional commits viewable in https://github.com/junit-team/junit5/compare/r5.8.0-M1...r5.8.0-RC1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=640203=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640203 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 20/Aug/21 11:16 Start Date: 20/Aug/21 11:16 Worklog Time Spent: 10m Work Description: martin-g commented on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902621364 With this improvement Apache Wicket 10.x file upload functionality is fully functional with Jakarta Servlet API 5.0! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640203) Time Spent: 20m (was: 10m) > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] martin-g commented on pull request #109: FILEUPLOAD-342 Remove methods which use javax|jakarta classes from FileUploadBase
martin-g commented on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902621364 With this improvement Apache Wicket 10.x file upload functionality is fully functional with Jakarta Servlet API 5.0! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=640202=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640202 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 20/Aug/21 11:14 Start Date: 20/Aug/21 11:14 Worklog Time Spent: 10m Work Description: martin-g opened a new pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109 It should be neutral. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640202) Remaining Estimate: 0h Time Spent: 10m > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] martin-g opened a new pull request #109: FILEUPLOAD-342 Remove methods which use javax|jakarta classes from FileUploadBase
martin-g opened a new pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109 It should be neutral. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
Martin Tzvetanov Grigorov created FILEUPLOAD-342: Summary: FileUploadBase should not import HttpServletRequest Key: FILEUPLOAD-342 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 Project: Commons FileUpload Issue Type: Improvement Affects Versions: 2.0 Reporter: Martin Tzvetanov Grigorov FileUploadBase has few deprecated methods which use 'javax.servlet.http.HttpServletRequest`. This causes class loading problem when using the new Jakarta based `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because javax.servlet.** in not on the classpath. Would it be OK to remove the deprecated methods in 2.0 ? The applications should use org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() or org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-341) Move exceptions out of .impl package
[ https://issues.apache.org/jira/browse/FILEUPLOAD-341?focusedWorklogId=640184=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640184 ] ASF GitHub Bot logged work on FILEUPLOAD-341: - Author: ASF GitHub Bot Created on: 20/Aug/21 09:55 Start Date: 20/Aug/21 09:55 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #108: URL: https://github.com/apache/commons-fileupload/pull/108#issuecomment-902578744 [](https://coveralls.io/builds/42293956) Coverage remained the same at 78.117% when pulling **4f26f288bf5141791a232ee915b0f9938776b6c8 on martin-g:FILEUPLOAD-341-add-migration-notes-for-340-and-341** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640184) Remaining Estimate: 0h Time Spent: 10m > Move exceptions out of .impl package > > > Key: FILEUPLOAD-341 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-341 > Project: Commons FileUpload > Issue Type: Wish >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Assignee: Jochen Wiedmann >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > With FILEUPLOAD-340 commons-fileupload2 now provides a module-info.class that > exports all packages but org.apache.commons.fileupload2.impl. > > Would it be OK to move all **Exception classes to the parent package so that > they are visible by users ? > **Impl classes should stay in org.apache.commons.fileupload2.impl! > > In Apache Wicket we use few of the exception classes to report specific > errors: > * > [https://github.com/apache/wicket/blob/43bc9b112ee43fac80f830632415cd8060b3d1a2/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java#L505] > * > [https://github.com/apache/wicket/blob/270a5a43970cd975539331b21a34bd83a59c9c39/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java#L1504] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] coveralls commented on pull request #108: FILEUPLOAD-341 Add a section the the migration guide
coveralls commented on pull request #108: URL: https://github.com/apache/commons-fileupload/pull/108#issuecomment-902578744 [](https://coveralls.io/builds/42293956) Coverage remained the same at 78.117% when pulling **4f26f288bf5141791a232ee915b0f9938776b6c8 on martin-g:FILEUPLOAD-341-add-migration-notes-for-340-and-341** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (VALIDATOR-482) ISBN validator validates false for existing book
[ https://issues.apache.org/jira/browse/VALIDATOR-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17402112#comment-17402112 ] Eugen Hanussek commented on VALIDATOR-482: -- Hi [~paulspeijers] for me the format is a question of definiton. And according to the current definition it is not a bug. Of course you can require to change the definition. This will be a new feature. regards > ISBN validator validates false for existing book > > > Key: VALIDATOR-482 > URL: https://issues.apache.org/jira/browse/VALIDATOR-482 > Project: Commons Validator > Issue Type: Bug >Reporter: Paul Speijers >Priority: Major > Attachments: 482.PNG > > > For instance the following ISBN number exists but the validator returns false: > 978-0199828234 > https://www.worldcat.org/search?q=978-0199828234 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-341) Move exceptions out of .impl package
[ https://issues.apache.org/jira/browse/FILEUPLOAD-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17402110#comment-17402110 ] Martin Tzvetanov Grigorov commented on FILEUPLOAD-341: -- Works just fine! Thank you! > Move exceptions out of .impl package > > > Key: FILEUPLOAD-341 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-341 > Project: Commons FileUpload > Issue Type: Wish >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Assignee: Jochen Wiedmann >Priority: Minor > > With FILEUPLOAD-340 commons-fileupload2 now provides a module-info.class that > exports all packages but org.apache.commons.fileupload2.impl. > > Would it be OK to move all **Exception classes to the parent package so that > they are visible by users ? > **Impl classes should stay in org.apache.commons.fileupload2.impl! > > In Apache Wicket we use few of the exception classes to report specific > errors: > * > [https://github.com/apache/wicket/blob/43bc9b112ee43fac80f830632415cd8060b3d1a2/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java#L505] > * > [https://github.com/apache/wicket/blob/270a5a43970cd975539331b21a34bd83a59c9c39/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java#L1504] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=640168=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640168 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 20/Aug/21 08:48 Start Date: 20/Aug/21 08:48 Worklog Time Spent: 10m Work Description: jochenw commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-902538960 With 2.0, a migration will be needed anyways. And, this is still in the range of "easy to migrate". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640168) Time Spent: 2h 40m (was: 2.5h) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] jochenw commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
jochenw commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-902538960 With 2.0, a migration will be needed anyways. And, this is still in the range of "easy to migrate". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FILEUPLOAD-341) Move exceptions out of .impl package
[ https://issues.apache.org/jira/browse/FILEUPLOAD-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17402103#comment-17402103 ] Jochen Wiedmann commented on FILEUPLOAD-341: [~mgrigorov]: Please verify, whether 8fa525dd420dcfcec0341a445b0d06c811731d99 works for you. > Move exceptions out of .impl package > > > Key: FILEUPLOAD-341 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-341 > Project: Commons FileUpload > Issue Type: Wish >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Assignee: Jochen Wiedmann >Priority: Minor > > With FILEUPLOAD-340 commons-fileupload2 now provides a module-info.class that > exports all packages but org.apache.commons.fileupload2.impl. > > Would it be OK to move all **Exception classes to the parent package so that > they are visible by users ? > **Impl classes should stay in org.apache.commons.fileupload2.impl! > > In Apache Wicket we use few of the exception classes to report specific > errors: > * > [https://github.com/apache/wicket/blob/43bc9b112ee43fac80f830632415cd8060b3d1a2/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java#L505] > * > [https://github.com/apache/wicket/blob/270a5a43970cd975539331b21a34bd83a59c9c39/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java#L1504] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FILEUPLOAD-341) Move exceptions out of .impl package
[ https://issues.apache.org/jira/browse/FILEUPLOAD-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Wiedmann updated FILEUPLOAD-341: --- Assignee: Jochen Wiedmann > Move exceptions out of .impl package > > > Key: FILEUPLOAD-341 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-341 > Project: Commons FileUpload > Issue Type: Wish >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Assignee: Jochen Wiedmann >Priority: Minor > > With FILEUPLOAD-340 commons-fileupload2 now provides a module-info.class that > exports all packages but org.apache.commons.fileupload2.impl. > > Would it be OK to move all **Exception classes to the parent package so that > they are visible by users ? > **Impl classes should stay in org.apache.commons.fileupload2.impl! > > In Apache Wicket we use few of the exception classes to report specific > errors: > * > [https://github.com/apache/wicket/blob/43bc9b112ee43fac80f830632415cd8060b3d1a2/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java#L505] > * > [https://github.com/apache/wicket/blob/270a5a43970cd975539331b21a34bd83a59c9c39/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java#L1504] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (VALIDATOR-482) ISBN validator validates false for existing book
[ https://issues.apache.org/jira/browse/VALIDATOR-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17402100#comment-17402100 ] Paul Speijers commented on VALIDATOR-482: - Hi [~homebeaver] I saw that was the actual problem. But it is a valid format right? It does resolve in worldcat? > ISBN validator validates false for existing book > > > Key: VALIDATOR-482 > URL: https://issues.apache.org/jira/browse/VALIDATOR-482 > Project: Commons Validator > Issue Type: Bug >Reporter: Paul Speijers >Priority: Major > Attachments: 482.PNG > > > For instance the following ISBN number exists but the validator returns false: > 978-0199828234 > https://www.worldcat.org/search?q=978-0199828234 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=640159=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640159 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 20/Aug/21 08:00 Start Date: 20/Aug/21 08:00 Worklog Time Spent: 10m Work Description: martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-902510502 > I am afraid this will break many applications which already use classes from `impl`. I know that Apache Wicket does use them. https://issues.apache.org/jira/browse/FILEUPLOAD-341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640159) Time Spent: 2.5h (was: 2h 20m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-902510502 > I am afraid this will break many applications which already use classes from `impl`. I know that Apache Wicket does use them. https://issues.apache.org/jira/browse/FILEUPLOAD-341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FILEUPLOAD-341) Move exceptions out of .impl package
Martin Tzvetanov Grigorov created FILEUPLOAD-341: Summary: Move exceptions out of .impl package Key: FILEUPLOAD-341 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-341 Project: Commons FileUpload Issue Type: Wish Affects Versions: 2.0 Reporter: Martin Tzvetanov Grigorov With FILEUPLOAD-340 commons-fileupload2 now provides a module-info.class that exports all packages but org.apache.commons.fileupload2.impl. Would it be OK to move all **Exception classes to the parent package so that they are visible by users ? **Impl classes should stay in org.apache.commons.fileupload2.impl! In Apache Wicket we use few of the exception classes to report specific errors: * [https://github.com/apache/wicket/blob/43bc9b112ee43fac80f830632415cd8060b3d1a2/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java#L505] * [https://github.com/apache/wicket/blob/270a5a43970cd975539331b21a34bd83a59c9c39/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java#L1504] -- This message was sent by Atlassian Jira (v8.3.4#803005)
