Re: [PR] Bump actions/upload-artifact from 4.2.0 to 4.3.0 [commons-compress]
garydgregory merged PR #470: URL: https://github.com/apache/commons-compress/pull/470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 3.1.4 to 3.1.5 [commons-compress]
garydgregory merged PR #469: URL: https://github.com/apache/commons-compress/pull/469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 3.1.4 to 3.1.5 [commons-digester]
garydgregory merged PR #123: URL: https://github.com/apache/commons-digester/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/upload-artifact from 4.2.0 to 4.3.0 [commons-digester]
garydgregory merged PR #122: URL: https://github.com/apache/commons-digester/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 3.1.4 to 3.1.5 [commons-jci]
garydgregory merged PR #83: URL: https://github.com/apache/commons-jci/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/upload-artifact from 4.2.0 to 4.3.0 [commons-jci]
garydgregory merged PR #84: URL: https://github.com/apache/commons-jci/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/upload-artifact from 4.2.0 to 4.3.0 [commons-dbcp]
garydgregory merged PR #341: URL: https://github.com/apache/commons-dbcp/pull/341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 3.1.4 to 3.1.5 [commons-dbcp]
garydgregory merged PR #342: URL: https://github.com/apache/commons-dbcp/pull/342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove references to very old JDK and commons logging versions [commons-logging]
garydgregory commented on PR #201: URL: https://github.com/apache/commons-logging/pull/201#issuecomment-1911335655 CC: @ppkarwasz How does this look to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 3.1.4 to 3.1.5 [commons-net]
garydgregory merged PR #211: URL: https://github.com/apache/commons-net/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/upload-artifact from 4.2.0 to 4.3.0 [commons-net]
garydgregory merged PR #210: URL: https://github.com/apache/commons-net/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (CRYPTO-181) CryptoRandom should use a security random
[
https://issues.apache.org/jira/browse/CRYPTO-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811094#comment-17811094
]
Gary D. Gregory edited comment on CRYPTO-181 at 1/26/24 2:41 AM:
-
[~chaijunjie]
Note there is also {{java.security.SecureRandom.getInstanceStrong()}}
We could also create a new class {{JavaCryptoStrongRandom}} that uses
{{java.security.SecureRandom.getInstanceStrong()}} while using the current
class alone.
was (Author: garydgregory):
[~chaijunjie]
Note there is also {{java.security.SecureRandom.getInstanceStrong()}}
> CryptoRandom should use a security random
> -
>
> Key: CRYPTO-181
> URL: https://issues.apache.org/jira/browse/CRYPTO-181
> Project: Commons Crypto
> Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: chaijunjie
>Priority: Major
>
> when i do security check... i find the random used in
> JavaCryptoRandom not strong..it just use SHA1PRNG
> [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java]
> maybe we can use DRBG instead of SHA1PRNG?
> or any other solution?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CRYPTO-181) CryptoRandom should use a security random
[
https://issues.apache.org/jira/browse/CRYPTO-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811094#comment-17811094
]
Gary D. Gregory commented on CRYPTO-181:
[~chaijunjie]
Note there is also {{java.security.SecureRandom.getInstanceStrong()}}
> CryptoRandom should use a security random
> -
>
> Key: CRYPTO-181
> URL: https://issues.apache.org/jira/browse/CRYPTO-181
> Project: Commons Crypto
> Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: chaijunjie
>Priority: Major
>
> when i do security check... i find the random used in
> JavaCryptoRandom not strong..it just use SHA1PRNG
> [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java]
> maybe we can use DRBG instead of SHA1PRNG?
> or any other solution?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (TEXT-232) WordUtils.containsAllWords() may throw PatternSyntaxException
[
https://issues.apache.org/jira/browse/TEXT-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved TEXT-232.
--
Fix Version/s: 1.11.1
Resolution: Fixed
A fix is in git master.
> WordUtils.containsAllWords() may throw PatternSyntaxException
> --
>
> Key: TEXT-232
> URL: https://issues.apache.org/jira/browse/TEXT-232
> Project: Commons Text
> Issue Type: Wish
>Reporter: Arnout Engelen
>Priority: Minor
> Fix For: 1.11.1
>
>
> {{WordUtils.containsAllWords()}} checks if the String contains all words in
> the given array.
> Surprisingly, it interprets the words to be searched for as regular
> expressions, so for example searching for ")" would throw a
> PatternSyntaxException. Nothing in the javadoc nor the testcases suggests
> this is intentional.
> We could fix this by applying "{{{}Pattern.quote(){}}}" to the parameters, or
> by rejecting non-word characters outright.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (TEXT-232) WordUtils.containsAllWords() may throw PatternSyntaxException
[
https://issues.apache.org/jira/browse/TEXT-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated TEXT-232:
-
Description:
{{WordUtils.containsAllWords()}} checks if the String contains all words in the
given array.
Surprisingly, it interprets the words to be searched for as regular
expressions, so for example searching for ")" would throw a
PatternSyntaxException. Nothing in the javadoc nor the testcases suggests this
is intentional.
We could fix this by applying "{{{}Pattern.quote(){}}}" to the parameters, or
by rejecting non-word characters outright.
was:
WordUtils.containsAllWords checks if the String contains all words in the given
array.
Surprisingly, it interprets the words to be searched for as regular
expressions, so for example searching for ")" would throw a
PatternSyntaxException. Nothing in the javadoc nor the testcases suggests this
is intentional.
We could fix this by applying "{{{}Pattern.quote(){}}}" to the parameters, or
by rejecting non-word characters outright.
> WordUtils.containsAllWords() may throw PatternSyntaxException
> --
>
> Key: TEXT-232
> URL: https://issues.apache.org/jira/browse/TEXT-232
> Project: Commons Text
> Issue Type: Wish
>Reporter: Arnout Engelen
>Priority: Minor
>
> {{WordUtils.containsAllWords()}} checks if the String contains all words in
> the given array.
> Surprisingly, it interprets the words to be searched for as regular
> expressions, so for example searching for ")" would throw a
> PatternSyntaxException. Nothing in the javadoc nor the testcases suggests
> this is intentional.
> We could fix this by applying "{{{}Pattern.quote(){}}}" to the parameters, or
> by rejecting non-word characters outright.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (TEXT-232) WordUtils.containsAllWords() may throw PatternSyntaxException
[
https://issues.apache.org/jira/browse/TEXT-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated TEXT-232:
-
Summary: WordUtils.containsAllWords() may throw PatternSyntaxException
(was: containsAllWords may throw PatternSyntaxException)
> WordUtils.containsAllWords() may throw PatternSyntaxException
> --
>
> Key: TEXT-232
> URL: https://issues.apache.org/jira/browse/TEXT-232
> Project: Commons Text
> Issue Type: Wish
>Reporter: Arnout Engelen
>Priority: Minor
>
> WordUtils.containsAllWords checks if the String contains all words in the
> given array.
> Surprisingly, it interprets the words to be searched for as regular
> expressions, so for example searching for ")" would throw a
> PatternSyntaxException. Nothing in the javadoc nor the testcases suggests
> this is intentional.
> We could fix this by applying "{{{}Pattern.quote(){}}}" to the parameters, or
> by rejecting non-word characters outright.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (LOGGING-163) BufferedReader is not closed properly
[
https://issues.apache.org/jira/browse/LOGGING-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811083#comment-17811083
]
Gary D. Gregory commented on LOGGING-163:
-
I changed the version 1.3.0.
> BufferedReader is not closed properly
> -
>
> Key: LOGGING-163
> URL: https://issues.apache.org/jira/browse/LOGGING-163
> Project: Commons Logging
> Issue Type: Bug
>Affects Versions: 1.1.1, 1.2
>Reporter: Kaloyan Spiridonov
>Assignee: Gary D. Gregory
>Priority: Major
> Fix For: 1.3.0
>
>
> In LogFactory class at line 552 there is BufferedReader that is not closed
> properly. For example if rd.readLine(); throw an exception then the Reader
> will remain open.
> {code}
> BufferedReader rd;
> try {
> rd = new BufferedReader(new InputStreamReader(is, "UTF-8"));
> } catch (java.io.UnsupportedEncodingException e) {
> rd = new BufferedReader(new InputStreamReader(is));
> }
> String factoryClassName = rd.readLine();
> rd.close();
> {code}
> In SimpleLog class at line 163 there is InputStream that is not closed
> properly.
> {code}
> InputStream in = getResourceAsStream("simplelog.properties");
> if(null != in) {
> try {
> simpleLogProps.load(in);
> in.close();
> } catch(java.io.IOException e) {
> // ignored
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (LOGGING-163) BufferedReader is not closed properly
[
https://issues.apache.org/jira/browse/LOGGING-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated LOGGING-163:
Fix Version/s: 1.3.0
(was: 1.3.1)
> BufferedReader is not closed properly
> -
>
> Key: LOGGING-163
> URL: https://issues.apache.org/jira/browse/LOGGING-163
> Project: Commons Logging
> Issue Type: Bug
>Affects Versions: 1.1.1, 1.2
>Reporter: Kaloyan Spiridonov
>Assignee: Gary D. Gregory
>Priority: Major
> Fix For: 1.3.0
>
>
> In LogFactory class at line 552 there is BufferedReader that is not closed
> properly. For example if rd.readLine(); throw an exception then the Reader
> will remain open.
> {code}
> BufferedReader rd;
> try {
> rd = new BufferedReader(new InputStreamReader(is, "UTF-8"));
> } catch (java.io.UnsupportedEncodingException e) {
> rd = new BufferedReader(new InputStreamReader(is));
> }
> String factoryClassName = rd.readLine();
> rd.close();
> {code}
> In SimpleLog class at line 163 there is InputStream that is not closed
> properly.
> {code}
> InputStream in = getResourceAsStream("simplelog.properties");
> if(null != in) {
> try {
> simpleLogProps.load(in);
> in.close();
> } catch(java.io.IOException e) {
> // ignored
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Clarify and correct EndianUtils API doc [commons-io]
garydgregory commented on code in PR #566:
URL: https://github.com/apache/commons-io/pull/566#discussion_r1467148185
##
src/main/java/org/apache/commons/io/EndianUtils.java:
##
@@ -261,7 +275,8 @@ public static float swapFloat(final float value) {
}
/**
- * Converts an "int" value between endian systems.
+ * Converts an {@code int} value between endian systems.
Review Comment:
We should be clear that the toggle is between big and little-endian. We'll
then avoid the shadow of even thinking about middle-endian madness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CSV-63] CSVPrinter always quotes empty string if it is the first on a [commons-csv]
garydgregory commented on PR #14: URL: https://github.com/apache/commons-csv/pull/14#issuecomment-1911274518 This PR needs to be rebased on `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 3.1.4 to 3.1.5 [commons-scxml]
garydgregory merged PR #184: URL: https://github.com/apache/commons-scxml/pull/184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/upload-artifact from 4.2.0 to 4.3.0 [commons-scxml]
garydgregory merged PR #183: URL: https://github.com/apache/commons-scxml/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/upload-artifact from 4.2.0 to 4.3.0 [commons-io]
garydgregory merged PR #568: URL: https://github.com/apache/commons-io/pull/568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 3.1.4 to 3.1.5 [commons-io]
garydgregory merged PR #567: URL: https://github.com/apache/commons-io/pull/567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clarify and correct EndianUtils API doc [commons-io]
elharo commented on PR #566: URL: https://github.com/apache/commons-io/pull/566#issuecomment-1911254305 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CSV-63] CSVPrinter always quotes empty string if it is the first on a [commons-csv]
georgeneto commented on PR #14: URL: https://github.com/apache/commons-csv/pull/14#issuecomment-193581 is this going to be merged any time soon? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NET-728) SubnetUtils.isInRange(String address) is not working with CIDR input
[ https://issues.apache.org/jira/browse/NET-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated NET-728: Affects Version/s: 3.10.0 > SubnetUtils.isInRange(String address) is not working with CIDR input > > > Key: NET-728 > URL: https://issues.apache.org/jira/browse/NET-728 > Project: Commons Net > Issue Type: Bug >Affects Versions: 3.10.0 > Environment: Windows application using commons-net library (version > 3.10). >Reporter: Jared Perkins >Priority: Major > Attachments: SubNetUtilsTest.java, mira_screenshot_of_CIDR.png > > > I checked this website for CIDR notation to ensure it was accurrate: > [https://account.arin.net/public/cidrCalculator] > I utilized the IP address 10.65.0.151 and the prefix of 32. From that > website, it shows the only address available was 10.65.0.151. > I instantiated SubnetUtils using CIDR notation "10.65.0.151/32". I expected > true to be returned when using the SubnetUtils.isInRange(String address) for > "10.65.0.151". However it does not return true, and it will only return true > using prefix "30". > I attached a crude unit test to demonstrate the issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Moved] (NET-728) SubnetUtils.isInRange(String address) is not working with CIDR input
[ https://issues.apache.org/jira/browse/NET-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory moved COMMONSSITE-168 to NET-728: - Component/s: (was: Commons Build) Key: NET-728 (was: COMMONSSITE-168) Affects Version/s: (was: 30) Project: Commons Net (was: Apache Commons All) > SubnetUtils.isInRange(String address) is not working with CIDR input > > > Key: NET-728 > URL: https://issues.apache.org/jira/browse/NET-728 > Project: Commons Net > Issue Type: Bug > Environment: Windows application using commons-net library (version > 3.10). >Reporter: Jared Perkins >Priority: Major > Attachments: SubNetUtilsTest.java, mira_screenshot_of_CIDR.png > > > I checked this website for CIDR notation to ensure it was accurrate: > [https://account.arin.net/public/cidrCalculator] > I utilized the IP address 10.65.0.151 and the prefix of 32. From that > website, it shows the only address available was 10.65.0.151. > I instantiated SubnetUtils using CIDR notation "10.65.0.151/32". I expected > true to be returned when using the SubnetUtils.isInRange(String address) for > "10.65.0.151". However it does not return true, and it will only return true > using prefix "30". > I attached a crude unit test to demonstrate the issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (COMMONSSITE-168) SubnetUtils.isInRange(String address) is not working with CIDR input
Jared Perkins created COMMONSSITE-168: - Summary: SubnetUtils.isInRange(String address) is not working with CIDR input Key: COMMONSSITE-168 URL: https://issues.apache.org/jira/browse/COMMONSSITE-168 Project: Apache Commons All Issue Type: Bug Components: Commons Build Affects Versions: 30 Environment: Windows application using commons-net library (version 3.10). Reporter: Jared Perkins Attachments: SubNetUtilsTest.java, mira_screenshot_of_CIDR.png I checked this website for CIDR notation to ensure it was accurrate: [https://account.arin.net/public/cidrCalculator] I utilized the IP address 10.65.0.151 and the prefix of 32. From that website, it shows the only address available was 10.65.0.151. I instantiated SubnetUtils using CIDR notation "10.65.0.151/32". I expected true to be returned when using the SubnetUtils.isInRange(String address) for "10.65.0.151". However it does not return true, and it will only return true using prefix "30". I attached a crude unit test to demonstrate the issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MATH-1656) Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) are missing
[ https://issues.apache.org/jira/browse/MATH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810950#comment-17810950 ] Gilles Sadowski commented on MATH-1656: --- Hi. Before being diverted, I performed several local changes, following the discussion about incremental modification and overall current design of the "optim" package. I'm afraid that your new patch will likely be quite incompatible with what I intended to commit. I'll try to sort that out ASAP, and we'll then resume from there. Sorry for the inconvenience! > Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) > are missing > -- > > Key: MATH-1656 > URL: https://issues.apache.org/jira/browse/MATH-1656 > Project: Commons Math > Issue Type: Wish > Components: legacy >Affects Versions: 4.0-beta1 >Reporter: François Laferrière >Priority: Major > Labels: features > Attachments: MATH-1656-GradientDescent-Newton-BFGS-v2.0.zip, > MATH-1656-GradientDescent-Newton-BFGS-v4.0.patch.zip, > MATH-1658-GradientDescent-Newton-BFGS-v3.0.patch, > MATH-1658-GradientDescent-Newton-BFGS-v3.1.patch.zip, > MATH-1658-GradientDescent-Newton-BFGS.patch, Screenshot from 2023-07-10 > 12-13-38.png > > > Some classical multivariate such as > * gradient descent, > * Raphson-Newton, > * BFGS > are missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MATH-1656) Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) are missing
[ https://issues.apache.org/jira/browse/MATH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810939#comment-17810939 ] François Laferrière commented on MATH-1656: --- Hello, I prepared a new patch [^MATH-1656-GradientDescent-Newton-BFGS-v4.0.patch.zip]that remove OptimizationStatus to replace it by exception based behaviour in case of error. Gilles, don't be too sorry for the delay, I had problems on my side and would not had the time to take review remarks into account. But I am back to work. > Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) > are missing > -- > > Key: MATH-1656 > URL: https://issues.apache.org/jira/browse/MATH-1656 > Project: Commons Math > Issue Type: Wish > Components: legacy >Affects Versions: 4.0-beta1 >Reporter: François Laferrière >Priority: Major > Labels: features > Attachments: MATH-1656-GradientDescent-Newton-BFGS-v2.0.zip, > MATH-1656-GradientDescent-Newton-BFGS-v4.0.patch.zip, > MATH-1658-GradientDescent-Newton-BFGS-v3.0.patch, > MATH-1658-GradientDescent-Newton-BFGS-v3.1.patch.zip, > MATH-1658-GradientDescent-Newton-BFGS.patch, Screenshot from 2023-07-10 > 12-13-38.png > > > Some classical multivariate such as > * gradient descent, > * Raphson-Newton, > * BFGS > are missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Clarify and correct EndianUtils API doc [commons-io]
elharo commented on code in PR #566: URL: https://github.com/apache/commons-io/pull/566#discussion_r1466548537 ## src/main/java/org/apache/commons/io/EndianUtils.java: ## @@ -78,19 +84,20 @@ public static double readSwappedDouble(final InputStream input) throws IOExcepti } /** - * Reads a "float" value from a byte array at a given offset. The value is - * converted to the opposed endian system while reading. + * Reads a little endian "float" value from a byte array at a given offset. Review Comment: Maybe. What's really confusing here is we need to distinguish two different "floats": 1. The Java float primitive in memory in the VM. 2. A 4 byte chunk read from an input stream or an array. I'm not sure I've got this distinction clear enough yet. Let me play with it a bit more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clarify and correct EndianUtils API doc [commons-io]
garydgregory commented on code in PR #566:
URL: https://github.com/apache/commons-io/pull/566#discussion_r1466531754
##
src/main/java/org/apache/commons/io/EndianUtils.java:
##
@@ -78,19 +84,20 @@ public static double readSwappedDouble(final InputStream
input) throws IOExcepti
}
/**
- * Reads a "float" value from a byte array at a given offset. The value is
- * converted to the opposed endian system while reading.
+ * Reads a little endian "float" value from a byte array at a given offset.
Review Comment:
I think that using `{@code _type_}` would be better here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (LOGGING-163) BufferedReader is not closed properly
[
https://issues.apache.org/jira/browse/LOGGING-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810933#comment-17810933
]
Elliotte Rusty Harold commented on LOGGING-163:
---
Not sure why fix version is 1.3.1. Given the dates, I'd expect 1.3.0
> BufferedReader is not closed properly
> -
>
> Key: LOGGING-163
> URL: https://issues.apache.org/jira/browse/LOGGING-163
> Project: Commons Logging
> Issue Type: Bug
>Affects Versions: 1.1.1, 1.2
>Reporter: Kaloyan Spiridonov
>Assignee: Gary D. Gregory
>Priority: Major
> Fix For: 1.3.1
>
>
> In LogFactory class at line 552 there is BufferedReader that is not closed
> properly. For example if rd.readLine(); throw an exception then the Reader
> will remain open.
> {code}
> BufferedReader rd;
> try {
> rd = new BufferedReader(new InputStreamReader(is, "UTF-8"));
> } catch (java.io.UnsupportedEncodingException e) {
> rd = new BufferedReader(new InputStreamReader(is));
> }
> String factoryClassName = rd.readLine();
> rd.close();
> {code}
> In SimpleLog class at line 163 there is InputStream that is not closed
> properly.
> {code}
> InputStream in = getResourceAsStream("simplelog.properties");
> if(null != in) {
> try {
> simpleLogProps.load(in);
> in.close();
> } catch(java.io.IOException e) {
> // ignored
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MATH-1656) Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) are missing
[ https://issues.apache.org/jira/browse/MATH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Laferrière updated MATH-1656: -- Attachment: MATH-1656-GradientDescent-Newton-BFGS-v4.0.patch.zip > Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) > are missing > -- > > Key: MATH-1656 > URL: https://issues.apache.org/jira/browse/MATH-1656 > Project: Commons Math > Issue Type: Wish > Components: legacy >Affects Versions: 4.0-beta1 >Reporter: François Laferrière >Priority: Major > Labels: features > Attachments: MATH-1656-GradientDescent-Newton-BFGS-v2.0.zip, > MATH-1656-GradientDescent-Newton-BFGS-v4.0.patch.zip, > MATH-1658-GradientDescent-Newton-BFGS-v3.0.patch, > MATH-1658-GradientDescent-Newton-BFGS-v3.1.patch.zip, > MATH-1658-GradientDescent-Newton-BFGS.patch, Screenshot from 2023-07-10 > 12-13-38.png > > > Some classical multivariate such as > * gradient descent, > * Raphson-Newton, > * BFGS > are missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (IO-843) Deprecate EndianUtils constructor
[ https://issues.apache.org/jira/browse/IO-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-843. Fix Version/s: 2.16.0 Assignee: Gary D. Gregory Resolution: Fixed > Deprecate EndianUtils constructor > - > > Key: IO-843 > URL: https://issues.apache.org/jira/browse/IO-843 > Project: Commons IO > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Gary D. Gregory >Priority: Minor > Fix For: 2.16.0 > > > It's a static utility class. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MATH-1656) Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) are missing
[ https://issues.apache.org/jira/browse/MATH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Laferrière updated MATH-1656: -- Attachment: (was: MATH-1658-GradientDescent-Newton-BFGS-v4.0.patch.zip) > Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) > are missing > -- > > Key: MATH-1656 > URL: https://issues.apache.org/jira/browse/MATH-1656 > Project: Commons Math > Issue Type: Wish > Components: legacy >Affects Versions: 4.0-beta1 >Reporter: François Laferrière >Priority: Major > Labels: features > Attachments: MATH-1656-GradientDescent-Newton-BFGS-v2.0.zip, > MATH-1658-GradientDescent-Newton-BFGS-v3.0.patch, > MATH-1658-GradientDescent-Newton-BFGS-v3.1.patch.zip, > MATH-1658-GradientDescent-Newton-BFGS.patch, Screenshot from 2023-07-10 > 12-13-38.png > > > Some classical multivariate such as > * gradient descent, > * Raphson-Newton, > * BFGS > are missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MATH-1656) Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) are missing
[ https://issues.apache.org/jira/browse/MATH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Laferrière updated MATH-1656: -- Attachment: MATH-1658-GradientDescent-Newton-BFGS-v4.0.patch.zip > Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) > are missing > -- > > Key: MATH-1656 > URL: https://issues.apache.org/jira/browse/MATH-1656 > Project: Commons Math > Issue Type: Wish > Components: legacy >Affects Versions: 4.0-beta1 >Reporter: François Laferrière >Priority: Major > Labels: features > Attachments: MATH-1656-GradientDescent-Newton-BFGS-v2.0.zip, > MATH-1658-GradientDescent-Newton-BFGS-v3.0.patch, > MATH-1658-GradientDescent-Newton-BFGS-v3.1.patch.zip, > MATH-1658-GradientDescent-Newton-BFGS.patch, Screenshot from 2023-07-10 > 12-13-38.png > > > Some classical multivariate such as > * gradient descent, > * Raphson-Newton, > * BFGS > are missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MATH-1656) Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) are missing
[ https://issues.apache.org/jira/browse/MATH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Laferrière updated MATH-1656: -- Attachment: MATH-1658-GradientDescent-Newton-BFGS-v4.0.zip > Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) > are missing > -- > > Key: MATH-1656 > URL: https://issues.apache.org/jira/browse/MATH-1656 > Project: Commons Math > Issue Type: Wish > Components: legacy >Affects Versions: 4.0-beta1 >Reporter: François Laferrière >Priority: Major > Labels: features > Attachments: MATH-1656-GradientDescent-Newton-BFGS-v2.0.zip, > MATH-1658-GradientDescent-Newton-BFGS-v3.0.patch, > MATH-1658-GradientDescent-Newton-BFGS-v3.1.patch.zip, > MATH-1658-GradientDescent-Newton-BFGS.patch, Screenshot from 2023-07-10 > 12-13-38.png > > > Some classical multivariate such as > * gradient descent, > * Raphson-Newton, > * BFGS > are missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MATH-1656) Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) are missing
[ https://issues.apache.org/jira/browse/MATH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Laferrière updated MATH-1656: -- Attachment: (was: MATH-1658-GradientDescent-Newton-BFGS-v4.0.zip) > Classical multivariate optimizers (gradient descent, Raphson-Newton, BFGS) > are missing > -- > > Key: MATH-1656 > URL: https://issues.apache.org/jira/browse/MATH-1656 > Project: Commons Math > Issue Type: Wish > Components: legacy >Affects Versions: 4.0-beta1 >Reporter: François Laferrière >Priority: Major > Labels: features > Attachments: MATH-1656-GradientDescent-Newton-BFGS-v2.0.zip, > MATH-1658-GradientDescent-Newton-BFGS-v3.0.patch, > MATH-1658-GradientDescent-Newton-BFGS-v3.1.patch.zip, > MATH-1658-GradientDescent-Newton-BFGS.patch, Screenshot from 2023-07-10 > 12-13-38.png > > > Some classical multivariate such as > * gradient descent, > * Raphson-Newton, > * BFGS > are missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (TEXT-232) containsAllWords may throw PatternSyntaxException
Arnout Engelen created TEXT-232:
---
Summary: containsAllWords may throw PatternSyntaxException
Key: TEXT-232
URL: https://issues.apache.org/jira/browse/TEXT-232
Project: Commons Text
Issue Type: Wish
Reporter: Arnout Engelen
WordUtils.containsAllWords checks if the String contains all words in the given
array.
Surprisingly, it interprets the words to be searched for as regular
expressions, so for example searching for ")" would throw a
PatternSyntaxException. Nothing in the javadoc nor the testcases suggests this
is intentional.
We could fix this by applying "{{{}Pattern.quote(){}}}" to the parameters, or
by rejecting non-word characters outright.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Clarify and correct API doc [commons-io]
elharo opened a new pull request, #566:
URL: https://github.com/apache/commons-io/pull/566
Most of the methods in this class are badly named. Except for the swap
method they all just read and write in little endian order. E.g. consider
readSwappedInteger
```
public static int readSwappedInteger(final InputStream input) throws
IOException {
final int value1 = read(input);
final int value2 = read(input);
final int value3 = read(input);
final int value4 = read(input);
return ((value1 & 0xff) << 0) + ((value2 & 0xff) << 8) + ((value3 &
0xff) << 16) + ((value4 & 0xff) << 24);
}
```
This always reads four bytes from an input stream and always considers the
first byte read to be the least significant. It would have been better named
readLittleEndianInteger.
I'm tempted to deprecate the whole thing and replace it with something
better named, but for now at least let's correct the Java doc.
@garydgregory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (IO-843) Deprecate EndianUtils constructor
Elliotte Rusty Harold created IO-843: Summary: Deprecate EndianUtils constructor Key: IO-843 URL: https://issues.apache.org/jira/browse/IO-843 Project: Commons IO Issue Type: Improvement Reporter: Elliotte Rusty Harold It's a static utility class. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [CSV-302] CSVFormat.duplicateHeaderMode requires default DISALLOW [commons-csv]
spannm closed pull request #276: [CSV-302] CSVFormat.duplicateHeaderMode requires default DISALLOW URL: https://github.com/apache/commons-csv/pull/276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CSV-303] Add revapi to fail build on breaking API changes [commons-csv]
spannm closed pull request #252: [CSV-303] Add revapi to fail build on breaking API changes URL: https://github.com/apache/commons-csv/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
