[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-543221367 And somehow we are back to failing builds on Java >= 11 https://travis-ci.org/apache/commons-vfs/builds/599194873 arg. @woonsan May you take a look SVP? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-543220858 Is there a version of JR 1.x that would avoid: ``` Running org.apache.commons.vfs2.provider.webdav.test.WebdavProviderTestCase SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-log4j12/1.5.11/slf4j-log4j12-1.5.11.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/home/travis/.m2/repository/org/apache/jackrabbit/jackrabbit-standalone/1.6.5/jackrabbit-standalone-1.6.5.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. 2019-10-17 09:08:58,002 [main] ERROR unavailable java.lang.ClassCastException: class jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to class java.net.URLClassLoader (jdk.internal.loader.ClassLoaders$AppClassLoader and java.net.URLClassLoader are in module java.base of loader 'bootstrap') at org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:174) at org.apache.jasper.servlet.JspServlet.init(JspServlet.java:150) at org.mortbay.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:431) at org.mortbay.jetty.servlet.ServletHolder.doStart(ServletHolder.java:263) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) at org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:643) at org.mortbay.jetty.servlet.Context.startContext(Context.java:140) at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1234) at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:517) at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:460) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130) at org.mortbay.jetty.handler.RequestLogHandler.doStart(RequestLogHandler.java:115) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130) at org.mortbay.jetty.Server.doStart(Server.java:222) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) at org.apache.commons.vfs2.provider.webdav.test.JackrabbitMain.run(JackrabbitMain.java:232) at org.apache.commons.vfs2.provider.webdav.test.WebdavProviderTestCase.startJackrabbit(WebdavProviderTestCase.java:237) at org.apache.commons.vfs2.provider.webdav.test.WebdavProviderTestCase.setUpClass(WebdavProviderTestCase.java:216) at org.apache.commons.vfs2.provider.webdav.test.WebdavProviderTestCase.access$100(WebdavProviderTestCase.java:55) at org.apache.commons.vfs2.provider.webdav.test.WebdavProviderTestCase$1.setUp(WebdavProviderTestCase.java:245) at org.apache.commons.vfs2.test.AbstractTestSuite.lambda$run$0(AbstractTestSuite.java:129) at junit.framework.TestResult.runProtected(TestResult.java:142) at org.apache.commons.vfs2.test.AbstractTestSuite.run(AbstractTestSuite.java:134) at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121) VfsClassLoaderTests no layered .jar provider, skipping. created threads still running: #2: main MultiThreadedHttpConnectionManager cleanup WAITING daemon null ``` See https://travis-ci.org/apache/commons-vfs/jobs/599058150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-543147684 Hi @woonsan Thank you for the update, I think the hopefully last item to take care of is to update new `@since` tags to `2.5.0`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-497160437 Sounds good. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-488096381 @woonsan Thank you. WRT the patch. could there might still be conflicts: ``` C:\git\commons-vfs>git apply \temp\52.patch.txt /temp/52.patch.txt:1685: trailing whitespace. /* /temp/52.patch.txt:1686: trailing whitespace. * Licensed to the Apache Software Foundation (ASF) under one or more /temp/52.patch.txt:1687: trailing whitespace. * contributor license agreements. See the NOTICE file distributed with /temp/52.patch.txt:1688: trailing whitespace. * this work for additional information regarding copyright ownership. /temp/52.patch.txt:1689: trailing whitespace. * The ASF licenses this file to You under the Apache License, Version 2.0 error: patch failed: pom.xml:179 error: pom.xml: patch does not apply error: patch failed: pom.xml:554 error: pom.xml: patch does not apply error: patch failed: pom.xml:36 error: pom.xml: patch does not apply error: patch failed: pom.xml:194 error: pom.xml: patch does not apply error: patch failed: pom.xml:194 error: pom.xml: patch does not apply error: patch failed: pom.xml:194 error: pom.xml: patch does not apply ``` Can you try to apply the patch locally to your master to see what happens? I wanted to review it in Eclipse instead of here... Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-487942620 Hi @woonsan, So sorry I got side tracked. May you please rebase on master so we can get a fresh set of Travis CI builds. Gary This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the
latest Jackrabbit 2.x
URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-482997438
Hi @woonsan
Please refresh my memory if you've already explained this before:
in pom.xml I see:
```
1.6.5
2.19.2
```
and in a module:
```
commons-vfs2-jackrabbit2
Apache Commons VFS is a Virtual File System library -
Jackrabbit2-based WebDAV provider.
...
org.apache.jackrabbit
jackrabbit-webdav
${jackrabbit2.version}
```
Why are we calling JR1 support "2" and JR2 support "3"?
It's a bit confusing.
Thoughts?
Gary
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-479299314 Hi @woonsan, What is the status of this PR? Is it still "Not ready for merge"? Gary This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-478964021 Hi @woonsan , To be clear, the tests are still failing :-( Gary This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-478694212 Travis says at https://api.travis-ci.org/v3/job/514209997/log.txt says: ``` Failed tests: VfsClassLoaderTests>AbstractProviderTestCase.runTest:198->testGetResourcesNoLayerLocal:161 subdir4.jar/ is required for testing file:///home/travis/build/apache/commons-vfs/commons-vfs2-jackrabbit2/target/test-classes/test-data/read-tests/dir1/subdir4.jar ContentTests>AbstractProviderTestCase.runTest:198->testAllContent:39->assertSameContent:53->assertSameContent:49 webdav://admin@localhost:42383/repository/default/read-tests/dir1/subdir4.jar ProviderReadTests>AbstractProviderTestCase.runTest:198->testDotJarFolderName:329 ProviderReadTests>AbstractProviderTestCase.runTest:198->testDotJarFolderNameLayer:339 subdir4.jar/ must exist as folder, check test setup. ProviderReadTests>AbstractProviderTestCase.runTest:198->testFindFiles:311 expected:<0> but was:<1> ProviderReadTests>AbstractProviderTestCase.runTest:198->testSort:165 expected:<0> but was:<1> ProviderReadTests>AbstractProviderTestCase.runTest:198->testStructure:64->assertSameStructure:105 count children of "webdav://admin@localhost:42383/repository/default/read-tests/dir1" expected:<7> but was:<6> Tests run: 84, Failures: 7, Errors: 0, Skipped: 0 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-478683587 What happens in a local build for you? Do see failures like https://travis-ci.org/apache/commons-vfs/builds/514209996?utm_source=github_status_medium=notification This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
