[jira] [Commented] (CB-9721) Set ENABLE_BITCODE to NO in build.xcconfig
[ https://issues.apache.org/jira/browse/CB-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937743#comment-14937743 ] ASF subversion and git services commented on CB-9721: - Commit ca07a7153e2afd6e5a1239806151c69d80758245 in cordova-ios's branch refs/heads/master from [~macdonst] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=ca07a71 ] CB-9721 Set ENABLE_BITCODE to NO in build.xcconfig This closes #169 > Set ENABLE_BITCODE to NO in build.xcconfig > -- > > Key: CB-9721 > URL: https://issues.apache.org/jira/browse/CB-9721 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > Labels: cordova-ios-4.0.x > > By default in Xcode 7, it is set to YES. > This means that all libs/frameworks etc must have been built with > ENABLE_BITCODE = YES as well. > Setting this to NO will ensure backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9723) Cant access Jquery cdns from windows universal app and googlemap api also not working
tanveer created CB-9723: --- Summary: Cant access Jquery cdns from windows universal app and googlemap api also not working Key: CB-9723 URL: https://issues.apache.org/jira/browse/CB-9723 Project: Apache Cordova Issue Type: Bug Components: Windows, Windows 8 Affects Versions: 5.2.0 Reporter: tanveer Assignee: Jesse MacFadyen Priority: Critical -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9691) Blank page in a in app browser
[ https://issues.apache.org/jira/browse/CB-9691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936436#comment-14936436 ] Salvatore Iovene commented on CB-9691: -- Hi, just jumping in to provide a little better report. The issue only presents itself on iOS 9. The output on the console is: "An SSL error occurred". Indeed the issue is only with HTTPS links. All HTTPS requests will fail. The fix would be to add the following to the project's plist file: NSAppTransportSecurity NSAllowsArbitraryLoads Hope this helps! Salvatore > Blank page in a in app browser > -- > > Key: CB-9691 > URL: https://issues.apache.org/jira/browse/CB-9691 > Project: Apache Cordova > Issue Type: Bug > Environment: iOS 9.0 >Reporter: Philipp Bräutigam > > When i use the $cordovaAuth component I get a blank page when the in-app > browser opens. After I tried the fix > (http://forum.ionicframework.com/t/cordovaoauth-facebook-ios-9-gm-issue/32477) > it worked like expected. Hopefully it can be fixed as fast as possible. > Thanks in advance. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9704) Apache Cordova 5 does not support using a custom nexus repository for android builds
[ https://issues.apache.org/jira/browse/CB-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936417#comment-14936417 ] Ajay Gupta commented on CB-9704: Is there any progress on this issue? > Apache Cordova 5 does not support using a custom nexus repository for android > builds > > > Key: CB-9704 > URL: https://issues.apache.org/jira/browse/CB-9704 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Ajay Gupta > > We are using AngularJS and Ionic for writing a mobile application supported > both on IOS and Android. When we do "ionic build android --release", it > creates a build.gradle file in both platforms/android directory and > platforms/android/CordovaLib directory. Both of these files point to > mavenCentral() as the repository which tries to download artifacts directly > from the maven central repo (http://repo1.maven.org/maven2). We are trying > to build our mobile apps as part of a Jenkins build behind company proxy and > would like to have gradle reach out to our internal Maven nexus repository > instead of reaching out to the central maven repository directly. Our > internal Neux repository would then proxy everything to the maven central > repository. > We cannot hand edit the build.gradle file as it is a generated file and so > any custom changes made to it would be lost in the next build. Cordova 5 > supports adding custom extensions using build-extras.gradle file but it does > not support overriding repositories. > As a workaround, we have defined a pre-build Cordova hook to search replace > mavenCentral() references to our local maven repository before doing an > android build. It works but is a unnecessary workaround and not a very clean > solution. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9727) AddressBook.framework deprecated in iOS 9, use Contacts.framework
Shazron Abdullah created CB-9727: Summary: AddressBook.framework deprecated in iOS 9, use Contacts.framework Key: CB-9727 URL: https://issues.apache.org/jira/browse/CB-9727 Project: Apache Cordova Issue Type: Bug Components: Plugin Contacts Environment: iOS Reporter: Shazron Abdullah Since it's deprecated, we have time I suppose to migrate to the new Contacts.framework. We will have to bump up the major version and include an tag that it will require iOS 9, when the time comes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9616) Plugins need support for Android M run-time permissions
[ https://issues.apache.org/jira/browse/CB-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14938883#comment-14938883 ] ASF GitHub Bot commented on CB-9616: Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/222#issuecomment-144543404 Check out #223 for the new API updates, it's a lot of the same code, but abstracts the permission checking code out of the individual plugins. > Plugins need support for Android M run-time permissions > > > Key: CB-9616 > URL: https://issues.apache.org/jira/browse/CB-9616 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Affects Versions: 4.1.1 >Reporter: Olivier Goguel > > To implement the new Android M run-time permission support, an application > activity needs to call requestPermission() and get the user result by > overriding onRequestPermissionsResult() > Unfortunately, if a plugin can call the requestPermission() on its Cordova > Activity, it has no way to be notified when the onRequestPermissionResult is > being received > Similar to the onPause or onResult implementation, the Cordova Activity > should pass this event to to the pluginManager/ (through the > CordovaWebViewImpl) in order to let developers override > onRequestPermissionResult() in their plugin code if need be -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9726) Update minimum Deployment Target to iOS 8.0
Shazron Abdullah created CB-9726: Summary: Update minimum Deployment Target to iOS 8.0 Key: CB-9726 URL: https://issues.apache.org/jira/browse/CB-9726 Project: Apache Cordova Issue Type: Bug Components: iOS Reporter: Shazron Abdullah Update to 8.0 https://github.com/apache/cordova-ios/blob/ca07a7153e2afd6e5a1239806151c69d80758245/bin/templates/scripts/cordova/build.xcconfig#L26 This is per ML consensus -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9616) Plugins need support for Android M run-time permissions
[ https://issues.apache.org/jira/browse/CB-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14938783#comment-14938783 ] ASF GitHub Bot commented on CB-9616: Github user ogoguel commented on the pull request: https://github.com/apache/cordova-android/pull/222#issuecomment-144527463 Good to know :) I had to implement this feature to test my plugin, and I've though it could be helpful to other people until the official release is out. Keep up the good work! > Plugins need support for Android M run-time permissions > > > Key: CB-9616 > URL: https://issues.apache.org/jira/browse/CB-9616 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Affects Versions: 4.1.1 >Reporter: Olivier Goguel > > To implement the new Android M run-time permission support, an application > activity needs to call requestPermission() and get the user result by > overriding onRequestPermissionsResult() > Unfortunately, if a plugin can call the requestPermission() on its Cordova > Activity, it has no way to be notified when the onRequestPermissionResult is > being received > Similar to the onPause or onResult implementation, the Cordova Activity > should pass this event to to the pluginManager/ (through the > CordovaWebViewImpl) in order to let developers override > onRequestPermissionResult() in their plugin code if need be -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9616) Plugins need support for Android M run-time permissions
[ https://issues.apache.org/jira/browse/CB-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14938741#comment-14938741 ] ASF GitHub Bot commented on CB-9616: Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/222#issuecomment-144519164 We're already working on a more robust way of handling the permission requests. > Plugins need support for Android M run-time permissions > > > Key: CB-9616 > URL: https://issues.apache.org/jira/browse/CB-9616 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Affects Versions: 4.1.1 >Reporter: Olivier Goguel > > To implement the new Android M run-time permission support, an application > activity needs to call requestPermission() and get the user result by > overriding onRequestPermissionsResult() > Unfortunately, if a plugin can call the requestPermission() on its Cordova > Activity, it has no way to be notified when the onRequestPermissionResult is > being received > Similar to the onPause or onResult implementation, the Cordova Activity > should pass this event to to the pluginManager/ (through the > CordovaWebViewImpl) in order to let developers override > onRequestPermissionResult() in their plugin code if need be -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-9724) StatusBar in iOS: Size of the status bar is calculated incorrectly after a orientation change
[ https://issues.apache.org/jira/browse/CB-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronny Schleicher updated CB-9724: - Summary: StatusBar in iOS: Size of the status bar is calculated incorrectly after a orientation change (was: StatusBa iOSr: Size of the status bar is calculated incorrectly after a orientation change) > StatusBar in iOS: Size of the status bar is calculated incorrectly after a > orientation change > - > > Key: CB-9724 > URL: https://issues.apache.org/jira/browse/CB-9724 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0, 4.1.0 > Environment: iPhone with iOS version 8 or 9. >Reporter: Ronny Schleicher > > Steps to reproduce: > 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. > 2. Start yout App in Portrait. > 4. Now remove the statusbar in the runtime of your app (with a button click > or somethink else) with 'StatusBar.hide();' > 5. Now turn the iPhone 90 degrees in landscape mode. > 6. After this enable the StatusBar in the runtime of your app (with a button > click or somethink else) with 'StatusBar.show();' > 7. Error -> the StatusBar size in incorrect. > My Workaround --- > Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow > two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line > 204 and 373. > - (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView > { > // we only care about the latest iOS version or a change in setting > if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == > _statusBarOverlaysWebView) { > return; > } > CGRect bounds = [[UIScreen mainScreen] bounds]; > if (statusBarOverlaysWebView) { > [_statusBarBackgroundView removeFromSuperview]; > if > (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && > !IsAtLeastiOSVersion(@"8.0")) { > self.webView.frame = CGRectMake(0, 0, bounds.size.height, > bounds.size.width); > } else { > self.webView.frame = bounds; > } > } else { > CGRect statusBarFrame = [UIApplication > sharedApplication].statusBarFrame; > statusBarFrame = [self invertFrameIfNeeded:statusBarFrame > orientation:self.viewController.interfaceOrientation]; > [self initializeStatusBarBackgroundView]; > CGRect frame = self.webView.frame; > frame.origin.y = statusBarFrame.size.height; > frame.size.height -= statusBarFrame.size.height; > self.webView.frame = frame; > [self.webView.superview addSubview:_statusBarBackgroundView]; > } > _statusBarOverlaysWebView = statusBarOverlaysWebView; > } > - (void) hide:(CDVInvokedUrlCommand*)command > { > UIApplication* app = [UIApplication sharedApplication]; > if (!app.isStatusBarHidden) > { > self.viewController.wantsFullScreenLayout = YES; > CGRect statusBarFrame = [UIApplication > sharedApplication].statusBarFrame; > [self hideStatusBar]; > if (IsAtLeastiOSVersion(@"7.0")) { > [_statusBarBackgroundView removeFromSuperview]; > } > if (!_statusBarOverlaysWebView) { > CGRect frame = self.webView.frame; > frame.origin.y = 0; > if (!self.statusBarOverlaysWebView) { > if > (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && > !IsAtLeastiOSVersion(@"8.0")) { > frame.size.height += statusBarFrame.size.width; > } else { > frame.size.height += statusBarFrame.size.height; > } > } > self.webView.frame = frame; > } > _statusBarBackgroundView.hidden = YES; > } > } -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9724) StatusBa iOSr: Size of the status bar is calculated incorrectly after a orientation change
Ronny Schleicher created CB-9724: Summary: StatusBa iOSr: Size of the status bar is calculated incorrectly after a orientation change Key: CB-9724 URL: https://issues.apache.org/jira/browse/CB-9724 Project: Apache Cordova Issue Type: Bug Components: CordovaLib Affects Versions: 3.5.0, 4.1.0 Environment: iPhone with iOS version 8 or 9. Reporter: Ronny Schleicher Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start yout App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line 204 and 373. - (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && !IsAtLeastiOSVersion(@"8.0")) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect frame = self.webView.frame; frame.origin.y = statusBarFrame.size.height; frame.size.height -= statusBarFrame.size.height; self.webView.frame = frame; [self.webView.superview addSubview:_statusBarBackgroundView]; } _statusBarOverlaysWebView = statusBarOverlaysWebView; } - (void) hide:(CDVInvokedUrlCommand*)command { UIApplication* app = [UIApplication sharedApplication]; if (!app.isStatusBarHidden) { self.viewController.wantsFullScreenLayout = YES; CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; [self hideStatusBar]; if (IsAtLeastiOSVersion(@"7.0")) { [_statusBarBackgroundView removeFromSuperview]; } if (!_statusBarOverlaysWebView) { CGRect frame = self.webView.frame; frame.origin.y = 0; if (!self.statusBarOverlaysWebView) { if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && !IsAtLeastiOSVersion(@"8.0")) { frame.size.height += statusBarFrame.size.width; } else { frame.size.height += statusBarFrame.size.height; } } self.webView.frame = frame; } _statusBarBackgroundView.hidden = YES; } } -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-9724) StatusBar in iOS: Size of the status bar is calculated incorrectly after a orientation change
[ https://issues.apache.org/jira/browse/CB-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronny Schleicher updated CB-9724: - Description: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a *&& !IsAtLeastiOSVersion(@"8.0")*. In my m-file is it in line 204 and 373. {code:title=CDVStatusBar.m|borderStyle=solid} - (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect frame = self.webView.frame; frame.origin.y = statusBarFrame.size.height; frame.size.height -= statusBarFrame.size.height; self.webView.frame = frame; [self.webView.superview addSubview:_statusBarBackgroundView]; } _statusBarOverlaysWebView = statusBarOverlaysWebView; } - (void) hide:(CDVInvokedUrlCommand*)command { UIApplication* app = [UIApplication sharedApplication]; if (!app.isStatusBarHidden) { self.viewController.wantsFullScreenLayout = YES; CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; [self hideStatusBar]; if (IsAtLeastiOSVersion(@"7.0")) { [_statusBarBackgroundView removeFromSuperview]; } if (!_statusBarOverlaysWebView) { CGRect frame = self.webView.frame; frame.origin.y = 0; if (!self.statusBarOverlaysWebView) { if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { frame.size.height += statusBarFrame.size.width; } else { frame.size.height += statusBarFrame.size.height; } } self.webView.frame = frame; } _statusBarBackgroundView.hidden = YES; } } {code} was: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a *&& !IsAtLeastiOSVersion(@"8.0")*. In my m-file is it in line 204 and 373. {quote} (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self
[jira] [Updated] (CB-9724) StatusBar in iOS: Size of the status bar is calculated incorrectly after a orientation change
[ https://issues.apache.org/jira/browse/CB-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronny Schleicher updated CB-9724: - Description: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a && !IsAtLeastiOSVersion(@"8.0"). In my m-file is it in line 204 and 373. {code:title=CDVStatusBar.m|borderStyle=solid} - (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect frame = self.webView.frame; frame.origin.y = statusBarFrame.size.height; frame.size.height -= statusBarFrame.size.height; self.webView.frame = frame; [self.webView.superview addSubview:_statusBarBackgroundView]; } _statusBarOverlaysWebView = statusBarOverlaysWebView; } - (void) hide:(CDVInvokedUrlCommand*)command { UIApplication* app = [UIApplication sharedApplication]; if (!app.isStatusBarHidden) { self.viewController.wantsFullScreenLayout = YES; CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; [self hideStatusBar]; if (IsAtLeastiOSVersion(@"7.0")) { [_statusBarBackgroundView removeFromSuperview]; } if (!_statusBarOverlaysWebView) { CGRect frame = self.webView.frame; frame.origin.y = 0; if (!self.statusBarOverlaysWebView) { if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && !IsAtLeastiOSVersion(@"8.0")) { frame.size.height += statusBarFrame.size.width; } else { frame.size.height += statusBarFrame.size.height; } } self.webView.frame = frame; } _statusBarBackgroundView.hidden = YES; } } {code} was: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a *&& !IsAtLeastiOSVersion(@"8.0")*. In my m-file is it in line 204 and 373. {code:title=CDVStatusBar.m|borderStyle=solid} - (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation];
[jira] [Updated] (CB-9724) StatusBar in iOS: Size of the status bar is calculated incorrectly after a orientation change
[ https://issues.apache.org/jira/browse/CB-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronny Schleicher updated CB-9724: - Description: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line 204 and 373. {{monospaced}} (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect frame = self.webView.frame; frame.origin.y = statusBarFrame.size.height; frame.size.height -= statusBarFrame.size.height; self.webView.frame = frame; [self.webView.superview addSubview:_statusBarBackgroundView]; } _statusBarOverlaysWebView = statusBarOverlaysWebView; } {{monospaced}} {quote} - (void) hide:(CDVInvokedUrlCommand*)command { UIApplication* app = [UIApplication sharedApplication]; if (!app.isStatusBarHidden) { self.viewController.wantsFullScreenLayout = YES; CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; [self hideStatusBar]; if (IsAtLeastiOSVersion(@"7.0")) { [_statusBarBackgroundView removeFromSuperview]; } if (!_statusBarOverlaysWebView) { CGRect frame = self.webView.frame; frame.origin.y = 0; if (!self.statusBarOverlaysWebView) { if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { frame.size.height += statusBarFrame.size.width; } else { frame.size.height += statusBarFrame.size.height; } } self.webView.frame = frame; } _statusBarBackgroundView.hidden = YES; } } {quote} was: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line 204 and 373. {quote} (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self
[jira] [Updated] (CB-9724) StatusBar in iOS: Size of the status bar is calculated incorrectly after a orientation change
[ https://issues.apache.org/jira/browse/CB-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronny Schleicher updated CB-9724: - Description: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line 204 and 373. {quote} (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect frame = self.webView.frame; frame.origin.y = statusBarFrame.size.height; frame.size.height -= statusBarFrame.size.height; self.webView.frame = frame; [self.webView.superview addSubview:_statusBarBackgroundView]; } _statusBarOverlaysWebView = statusBarOverlaysWebView; } {quote} {quote} - (void) hide:(CDVInvokedUrlCommand*)command { UIApplication* app = [UIApplication sharedApplication]; if (!app.isStatusBarHidden) { self.viewController.wantsFullScreenLayout = YES; CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; [self hideStatusBar]; if (IsAtLeastiOSVersion(@"7.0")) { [_statusBarBackgroundView removeFromSuperview]; } if (!_statusBarOverlaysWebView) { CGRect frame = self.webView.frame; frame.origin.y = 0; if (!self.statusBarOverlaysWebView) { if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { frame.size.height += statusBarFrame.size.width; } else { frame.size.height += statusBarFrame.size.height; } } self.webView.frame = frame; } _statusBarBackgroundView.hidden = YES; } } {quote} was: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line 204 and 373. {quote} (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && !IsAtLeastiOSVersion(@"8.0")) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView];
[jira] [Updated] (CB-9724) StatusBar in iOS: Size of the status bar is calculated incorrectly after a orientation change
[ https://issues.apache.org/jira/browse/CB-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronny Schleicher updated CB-9724: - Description: h3. Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. h3. My Workaround / Bugfix Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a && !IsAtLeastiOSVersion(@"8.0"). In my m-file is it in line 204 and 373. {code:title=CDVStatusBar.m|borderStyle=solid} - (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect frame = self.webView.frame; frame.origin.y = statusBarFrame.size.height; frame.size.height -= statusBarFrame.size.height; self.webView.frame = frame; [self.webView.superview addSubview:_statusBarBackgroundView]; } _statusBarOverlaysWebView = statusBarOverlaysWebView; } - (void) hide:(CDVInvokedUrlCommand*)command { UIApplication* app = [UIApplication sharedApplication]; if (!app.isStatusBarHidden) { self.viewController.wantsFullScreenLayout = YES; CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; [self hideStatusBar]; if (IsAtLeastiOSVersion(@"7.0")) { [_statusBarBackgroundView removeFromSuperview]; } if (!_statusBarOverlaysWebView) { CGRect frame = self.webView.frame; frame.origin.y = 0; if (!self.statusBarOverlaysWebView) { if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && !IsAtLeastiOSVersion(@"8.0")) { frame.size.height += statusBarFrame.size.width; } else { frame.size.height += statusBarFrame.size.height; } } self.webView.frame = frame; } _statusBarBackgroundView.hidden = YES; } } {code} was: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a && !IsAtLeastiOSVersion(@"8.0"). In my m-file is it in line 204 and 373. {code:title=CDVStatusBar.m|borderStyle=solid} - (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self
[jira] [Updated] (CB-9724) StatusBar in iOS: Size of the status bar is calculated incorrectly after a orientation change
[ https://issues.apache.org/jira/browse/CB-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronny Schleicher updated CB-9724: - Description: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line 204 and 373. - (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && !IsAtLeastiOSVersion(@"8.0")) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect frame = self.webView.frame; frame.origin.y = statusBarFrame.size.height; frame.size.height -= statusBarFrame.size.height; self.webView.frame = frame; [self.webView.superview addSubview:_statusBarBackgroundView]; } _statusBarOverlaysWebView = statusBarOverlaysWebView; } - (void) hide:(CDVInvokedUrlCommand*)command { UIApplication* app = [UIApplication sharedApplication]; if (!app.isStatusBarHidden) { self.viewController.wantsFullScreenLayout = YES; CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; [self hideStatusBar]; if (IsAtLeastiOSVersion(@"7.0")) { [_statusBarBackgroundView removeFromSuperview]; } if (!_statusBarOverlaysWebView) { CGRect frame = self.webView.frame; frame.origin.y = 0; if (!self.statusBarOverlaysWebView) { if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && !IsAtLeastiOSVersion(@"8.0")) { frame.size.height += statusBarFrame.size.width; } else { frame.size.height += statusBarFrame.size.height; } } self.webView.frame = frame; } _statusBarBackgroundView.hidden = YES; } } was: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start yout App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line 204 and 373. - (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && !IsAtLeastiOSVersion(@"8.0")) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect frame = self.webView.frame;
[jira] [Updated] (CB-9724) StatusBar in iOS: Size of the status bar is calculated incorrectly after a orientation change
[ https://issues.apache.org/jira/browse/CB-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronny Schleicher updated CB-9724: - Description: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line 204 and 373. {quote} (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && !IsAtLeastiOSVersion(@"8.0")) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect frame = self.webView.frame; frame.origin.y = statusBarFrame.size.height; frame.size.height -= statusBarFrame.size.height; self.webView.frame = frame; [self.webView.superview addSubview:_statusBarBackgroundView]; } _statusBarOverlaysWebView = statusBarOverlaysWebView; } {quote} {quote} - (void) hide:(CDVInvokedUrlCommand*)command { UIApplication* app = [UIApplication sharedApplication]; if (!app.isStatusBarHidden) { self.viewController.wantsFullScreenLayout = YES; CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; [self hideStatusBar]; if (IsAtLeastiOSVersion(@"7.0")) { [_statusBarBackgroundView removeFromSuperview]; } if (!_statusBarOverlaysWebView) { CGRect frame = self.webView.frame; frame.origin.y = 0; if (!self.statusBarOverlaysWebView) { if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && !IsAtLeastiOSVersion(@"8.0")) { frame.size.height += statusBarFrame.size.width; } else { frame.size.height += statusBarFrame.size.height; } } self.webView.frame = frame; } _statusBarBackgroundView.hidden = YES; } } {quote} was: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line 204 and 373. - (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) && !IsAtLeastiOSVersion(@"8.0")) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect frame =
[jira] [Updated] (CB-9724) StatusBar in iOS: Size of the status bar is calculated incorrectly after a orientation change
[ https://issues.apache.org/jira/browse/CB-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronny Schleicher updated CB-9724: - Description: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a *&& !IsAtLeastiOSVersion(@"8.0")*. In my m-file is it in line 204 and 373. {quote} (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect frame = self.webView.frame; frame.origin.y = statusBarFrame.size.height; frame.size.height -= statusBarFrame.size.height; self.webView.frame = frame; [self.webView.superview addSubview:_statusBarBackgroundView]; } _statusBarOverlaysWebView = statusBarOverlaysWebView; } {quote} {quote} (void) hide:(CDVInvokedUrlCommand*)command { UIApplication* app = [UIApplication sharedApplication]; if (!app.isStatusBarHidden) { self.viewController.wantsFullScreenLayout = YES; CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; [self hideStatusBar]; if (IsAtLeastiOSVersion(@"7.0")) { [_statusBarBackgroundView removeFromSuperview]; } if (!_statusBarOverlaysWebView) { CGRect frame = self.webView.frame; frame.origin.y = 0; if (!self.statusBarOverlaysWebView) { if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { frame.size.height += statusBarFrame.size.width; } else { frame.size.height += statusBarFrame.size.height; } } self.webView.frame = frame; } _statusBarBackgroundView.hidden = YES; } } {quote} was: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line 204 and 373. {quote} (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView];
[jira] [Updated] (CB-9724) StatusBar in iOS: Size of the status bar is calculated incorrectly after a orientation change
[ https://issues.apache.org/jira/browse/CB-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronny Schleicher updated CB-9724: - Environment: iPhone with iOS version 8 and 9. (was: iPhone with iOS version 8 or 9.) > StatusBar in iOS: Size of the status bar is calculated incorrectly after a > orientation change > - > > Key: CB-9724 > URL: https://issues.apache.org/jira/browse/CB-9724 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: 3.5.0, 4.1.0 > Environment: iPhone with iOS version 8 and 9. >Reporter: Ronny Schleicher > > Steps to reproduce: > 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. > 2. Start your App in Portrait. > 4. Now remove the statusbar in the runtime of your app (with a button click > or somethink else) with 'StatusBar.hide();' > 5. Now turn the iPhone 90 degrees in landscape mode. > 6. After this enable the StatusBar in the runtime of your app (with a button > click or somethink else) with 'StatusBar.show();' > 7. Error -> the StatusBar size in incorrect. > My Workaround --- > Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow > two function a *&& !IsAtLeastiOSVersion(@"8.0")*. In my m-file is it in line > 204 and 373. > {quote} > (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView > { > // we only care about the latest iOS version or a change in setting > if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == > _statusBarOverlaysWebView) { > return; > } > CGRect bounds = [[UIScreen mainScreen] bounds]; > if (statusBarOverlaysWebView) { > [_statusBarBackgroundView removeFromSuperview]; > if > (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& > !IsAtLeastiOSVersion(@"8.0")*) { > self.webView.frame = CGRectMake(0, 0, bounds.size.height, > bounds.size.width); > } else { > self.webView.frame = bounds; > } > } else { > CGRect statusBarFrame = [UIApplication > sharedApplication].statusBarFrame; > statusBarFrame = [self invertFrameIfNeeded:statusBarFrame > orientation:self.viewController.interfaceOrientation]; > [self initializeStatusBarBackgroundView]; > CGRect frame = self.webView.frame; > frame.origin.y = statusBarFrame.size.height; > frame.size.height -= statusBarFrame.size.height; > self.webView.frame = frame; > [self.webView.superview addSubview:_statusBarBackgroundView]; > } > _statusBarOverlaysWebView = statusBarOverlaysWebView; > } > {quote} > {quote} > (void) hide:(CDVInvokedUrlCommand*)command > { > UIApplication* app = [UIApplication sharedApplication]; > if (!app.isStatusBarHidden) > { > self.viewController.wantsFullScreenLayout = YES; > CGRect statusBarFrame = [UIApplication > sharedApplication].statusBarFrame; > [self hideStatusBar]; > if (IsAtLeastiOSVersion(@"7.0")) { > [_statusBarBackgroundView removeFromSuperview]; > } > if (!_statusBarOverlaysWebView) { > CGRect frame = self.webView.frame; > frame.origin.y = 0; > if (!self.statusBarOverlaysWebView) { > if > (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& > !IsAtLeastiOSVersion(@"8.0")*) { > frame.size.height += statusBarFrame.size.width; > } else { > frame.size.height += statusBarFrame.size.height; > } > } > self.webView.frame = frame; > } > _statusBarBackgroundView.hidden = YES; > } > } > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-9724) StatusBar in iOS: Size of the status bar is calculated incorrectly after a orientation change
[ https://issues.apache.org/jira/browse/CB-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronny Schleicher updated CB-9724: - Description: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line 204 and 373. {quote} (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect frame = self.webView.frame; frame.origin.y = statusBarFrame.size.height; frame.size.height -= statusBarFrame.size.height; self.webView.frame = frame; [self.webView.superview addSubview:_statusBarBackgroundView]; } _statusBarOverlaysWebView = statusBarOverlaysWebView; } {quote} {quote} (void) hide:(CDVInvokedUrlCommand*)command { UIApplication* app = [UIApplication sharedApplication]; if (!app.isStatusBarHidden) { self.viewController.wantsFullScreenLayout = YES; CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; [self hideStatusBar]; if (IsAtLeastiOSVersion(@"7.0")) { [_statusBarBackgroundView removeFromSuperview]; } if (!_statusBarOverlaysWebView) { CGRect frame = self.webView.frame; frame.origin.y = 0; if (!self.statusBarOverlaysWebView) { if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { frame.size.height += statusBarFrame.size.width; } else { frame.size.height += statusBarFrame.size.height; } } self.webView.frame = frame; } _statusBarBackgroundView.hidden = YES; } } {quote} was: Steps to reproduce: 1. Create a PhoneGap App and use the Statusbar-Plugin to show the Statusbar. 2. Start your App in Portrait. 4. Now remove the statusbar in the runtime of your app (with a button click or somethink else) with 'StatusBar.hide();' 5. Now turn the iPhone 90 degrees in landscape mode. 6. After this enable the StatusBar in the runtime of your app (with a button click or somethink else) with 'StatusBar.show();' 7. Error -> the StatusBar size in incorrect. My Workaround --- Add in the file '.\Plugins\cordova-plugin-statusbar\CDVStatusBar.m' in follow two function a '&& !IsAtLeastiOSVersion(@"8.0")'. In my m-file is it in line 204 and 373. {{ (void) setStatusBarOverlaysWebView:(BOOL)statusBarOverlaysWebView { // we only care about the latest iOS version or a change in setting if (!IsAtLeastiOSVersion(@"7.0") || statusBarOverlaysWebView == _statusBarOverlaysWebView) { return; } CGRect bounds = [[UIScreen mainScreen] bounds]; if (statusBarOverlaysWebView) { [_statusBarBackgroundView removeFromSuperview]; if (UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation) *&& !IsAtLeastiOSVersion(@"8.0")*) { self.webView.frame = CGRectMake(0, 0, bounds.size.height, bounds.size.width); } else { self.webView.frame = bounds; } } else { CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame; statusBarFrame = [self invertFrameIfNeeded:statusBarFrame orientation:self.viewController.interfaceOrientation]; [self initializeStatusBarBackgroundView]; CGRect
[jira] [Assigned] (CB-9721) Set ENABLE_BITCODE to NO in build.xcconfig
[ https://issues.apache.org/jira/browse/CB-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon MacDonald reassigned CB-9721: --- Assignee: Simon MacDonald > Set ENABLE_BITCODE to NO in build.xcconfig > -- > > Key: CB-9721 > URL: https://issues.apache.org/jira/browse/CB-9721 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > Labels: cordova-ios-4.0.x > > By default in Xcode 7, it is set to YES. > This means that all libs/frameworks etc must have been built with > ENABLE_BITCODE = YES as well. > Setting this to NO will ensure backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9725) File Input from PhoneGap 5.2.0 on iOS9 - No longer works
Alex Soufi created CB-9725: -- Summary: File Input from PhoneGap 5.2.0 on iOS9 - No longer works Key: CB-9725 URL: https://issues.apache.org/jira/browse/CB-9725 Project: Apache Cordova Issue Type: Bug Components: iOS, Plugin Battery Status, Plugin Camera, Plugin Contacts, Plugin Device Orientation, Plugin Dialogs, Plugin File, Plugin Geolocation, Plugin Globalization, Plugin InAppBrowser, Plugin Media, Plugin Media Capture Affects Versions: 5.2.0 Environment: iPhone 5s, iOS9, PhoneGap CLI 5.2.1 Reporter: Alex Soufi File Input is no longer working after updating to iOS9. To isolate the problem, I used Build.PhoneGap.Com (cli 5.2.0) to created a simple PhoneGap app with index.html that has [input type="file" accept="image/*;capture=camera"] only. Until recent iOS9 update, file input on this page worked fine. If you clicked "Choose File", you get the "Take Photo or Video / Choose Existing / Cancel" dialog. After iOS9 update, the "Choose File" is no longer working properly. When clicked, you no longer get the "Take Photo or Video / Choose Existing" dialog, instead, you get the "Cancel" dialog that does not go away until you close the app. Two notes: 1- I viewed the same index.html page from Safari and Chrome on iPhone with iOS9 and everything worked fine. 2- The same PhoneGap app works fine on an iPhone with iOS8. What is causing above bug? Is there a fix? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9728) Memory leak due to open cursor objects
Sachin Gupta created CB-9728: Summary: Memory leak due to open cursor objects Key: CB-9728 URL: https://issues.apache.org/jira/browse/CB-9728 Project: Apache Cordova Issue Type: Bug Components: CordovaJS Affects Versions: 3.5.0 Environment: Android Reporter: Sachin Gupta Fix For: 3.6.0 There was memory leak due to some opened cursor objects while searching for contacts from address book. This is causing app crash on android platform. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9728) Memory leak due to open cursor objects
[ https://issues.apache.org/jira/browse/CB-9728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14938960#comment-14938960 ] ASF GitHub Bot commented on CB-9728: Github user guptasachin25 commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/80#issuecomment-144559114 Created this issue on JIRA. https://issues.apache.org/jira/browse/CB-9728 > Memory leak due to open cursor objects > --- > > Key: CB-9728 > URL: https://issues.apache.org/jira/browse/CB-9728 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS >Affects Versions: 3.5.0 > Environment: Android >Reporter: Sachin Gupta > Labels: newbie > Fix For: 3.6.0 > > Original Estimate: 24h > Remaining Estimate: 24h > > There was memory leak due to some opened cursor objects while searching for > contacts from address book. This is causing app crash on android platform. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9721) Set ENABLE_BITCODE to NO in build.xcconfig
[ https://issues.apache.org/jira/browse/CB-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937744#comment-14937744 ] ASF GitHub Bot commented on CB-9721: Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/169 > Set ENABLE_BITCODE to NO in build.xcconfig > -- > > Key: CB-9721 > URL: https://issues.apache.org/jira/browse/CB-9721 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > Labels: cordova-ios-4.0.x > > By default in Xcode 7, it is set to YES. > This means that all libs/frameworks etc must have been built with > ENABLE_BITCODE = YES as well. > Setting this to NO will ensure backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9729) Can't push app built with new XCode
Paul Tarjan created CB-9729: --- Summary: Can't push app built with new XCode Key: CB-9729 URL: https://issues.apache.org/jira/browse/CB-9729 Project: Apache Cordova Issue Type: Bug Components: iOS, iOS, Plugin Battery Status, Plugin Camera, Plugin Contacts, Plugin Device Orientation, Plugin Dialogs, Plugin File, Plugin Geolocation, Plugin Globalization, Plugin InAppBrowser, Plugin Media, Plugin Media Capture Affects Versions: 3.9.0 Reporter: Paul Tarjan When uploading a built IPA to Apple, I get the following errors: --- [22:27:00]: [Transporter Error Output]: ERROR ITMS-90474: "Invalid Bundle. iPad Multitasking support requires these orientations: 'UIInterfaceOrientationPortrait,UIInterfaceOrientationPortraitUpsideDown,UIInterfaceOrientationLandscapeLeft,UIInterfaceOrientationLandscapeRight'. Found 'UIInterfaceOrientationPortrait,UIInterfaceOrientationPortraitUpsideDown' in bundle 'com.trimian.directory'." [22:27:00]: [Transporter Error Output]: ERROR ITMS-90475: "Invalid Bundle. iPad Multitasking support requires launch story board in bundle 'com.trimian.directory'." [22:27:00]: [Transporter Error Output]: ERROR ITMS-90339: "This bundle is invalid. The Info.plist contains an invalid key 'CFBundleResourceSpecification' in bundle Directory [Directory.app]" --- I think it is two bugs in one. First, you need to mark the project as requiring full screen in the iPad section. Section, you ned to remove that key in the bundle. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9598) Factor out shared logic to cordova-common module and publish it separately.
[ https://issues.apache.org/jira/browse/CB-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936919#comment-14936919 ] ASF GitHub Bot commented on CB-9598: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/311 CB-9598 Switching to use `cordova-common` module See [CB-9598](https://issues.apache.org/jira/browse/CB-9598) for details. This PR just removes code which has been copied previously to `cordova-common` and updates requires to point to that code. The LIB includes `cordova-common` as a bundled dependency, so it doesn't need to be published. To npm links to new module could be set up using `coho npm-link` after pulling in the following PR to cordova-coho: https://github.com/apache/cordova-coho/pull/94 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-9598 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/311.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #311 commit 4c7bcc84a4ef96d84df968ac30c06b70945ef1b1 Author: Vladimir KotikovDate: 2015-09-30T13:24:06Z CB-9598 Cleans out code which has been moved to `cordova-common` commit a15f049f9882935f7426e23cfe409841ab9ae722 Author: Vladimir Kotikov Date: 2015-09-30T14:43:04Z CB-9598 Switches LIB to use `cordova-common` * Updates requires to point to `cordova-common` * Add 'cordova-common' as bundled dependency > Factor out shared logic to cordova-common module and publish it separately. > --- > > Key: CB-9598 > URL: https://issues.apache.org/jira/browse/CB-9598 > Project: Apache Cordova > Issue Type: Sub-task > Components: CordovaCommon, CordovaLib >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > > There also a potential problem of code duplication, since the PlatformApi > needs for several classes, which currently being stored and exposed by > cordova-lib: ConfigParser, PluginInfo, etc. The one of solutions of this > problem - is to factor out the common classes and routines to shared module > (proposed name - cordova-common), which then will be released separately. > This approach is discussed in cordova-lib/#235 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9721) Set ENABLE_BITCODE to NO in build.xcconfig
[ https://issues.apache.org/jira/browse/CB-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937493#comment-14937493 ] Simon MacDonald commented on CB-9721: - Sure thing, I'll look into that now. I'm just a babe in the woods with some of this iOS stuff learning from you master. > Set ENABLE_BITCODE to NO in build.xcconfig > -- > > Key: CB-9721 > URL: https://issues.apache.org/jira/browse/CB-9721 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > Labels: cordova-ios-4.0.x > > By default in Xcode 7, it is set to YES. > This means that all libs/frameworks etc must have been built with > ENABLE_BITCODE = YES as well. > Setting this to NO will ensure backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9721) Set ENABLE_BITCODE to NO in build.xcconfig
[ https://issues.apache.org/jira/browse/CB-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937698#comment-14937698 ] ASF subversion and git services commented on CB-9721: - Commit 947336b6aa998d4c22ea6e0d7814254fc01c8067 in cordova-ios's branch refs/heads/CB-9721 from [~macdonst] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=947336b ] CB-9721 Set ENABLE_BITCODE to NO in build.xcconfig > Set ENABLE_BITCODE to NO in build.xcconfig > -- > > Key: CB-9721 > URL: https://issues.apache.org/jira/browse/CB-9721 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > Labels: cordova-ios-4.0.x > > By default in Xcode 7, it is set to YES. > This means that all libs/frameworks etc must have been built with > ENABLE_BITCODE = YES as well. > Setting this to NO will ensure backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9721) Set ENABLE_BITCODE to NO in build.xcconfig
[ https://issues.apache.org/jira/browse/CB-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937021#comment-14937021 ] ASF subversion and git services commented on CB-9721: - Commit 7f2e135216930ac474b8a6fdf6fdd676823412d8 in cordova-ios's branch refs/heads/CB-9721 from [~macdonst] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=7f2e135 ] CB-9721 Set ENABLE_BITCODE to NO in build.xcconfig > Set ENABLE_BITCODE to NO in build.xcconfig > -- > > Key: CB-9721 > URL: https://issues.apache.org/jira/browse/CB-9721 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > Labels: cordova-ios-4.0.x > > By default in Xcode 7, it is set to YES. > This means that all libs/frameworks etc must have been built with > ENABLE_BITCODE = YES as well. > Setting this to NO will ensure backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9721) Set ENABLE_BITCODE to NO in build.xcconfig
[ https://issues.apache.org/jira/browse/CB-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937441#comment-14937441 ] Shazron Abdullah commented on CB-9721: -- I have no doubt that your change works. But we've decided long ago not to change Build Settings in the project file but change it in build.xcconfig. Could you change it there instead? This allows external tools to change it if need be, easily. > Set ENABLE_BITCODE to NO in build.xcconfig > -- > > Key: CB-9721 > URL: https://issues.apache.org/jira/browse/CB-9721 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > Labels: cordova-ios-4.0.x > > By default in Xcode 7, it is set to YES. > This means that all libs/frameworks etc must have been built with > ENABLE_BITCODE = YES as well. > Setting this to NO will ensure backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9721) Set ENABLE_BITCODE to NO in build.xcconfig
[ https://issues.apache.org/jira/browse/CB-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937025#comment-14937025 ] ASF GitHub Bot commented on CB-9721: GitHub user macdonst opened a pull request: https://github.com/apache/cordova-ios/pull/169 CB-9721 Set ENABLE_BITCODE to NO in build.xcconfig You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cordova-ios CB-9721 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #169 commit 7f2e135216930ac474b8a6fdf6fdd676823412d8 Author: Simon MacDonaldDate: 2015-09-30T15:42:43Z CB-9721 Set ENABLE_BITCODE to NO in build.xcconfig > Set ENABLE_BITCODE to NO in build.xcconfig > -- > > Key: CB-9721 > URL: https://issues.apache.org/jira/browse/CB-9721 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > Labels: cordova-ios-4.0.x > > By default in Xcode 7, it is set to YES. > This means that all libs/frameworks etc must have been built with > ENABLE_BITCODE = YES as well. > Setting this to NO will ensure backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9721) Set ENABLE_BITCODE to NO in build.xcconfig
[ https://issues.apache.org/jira/browse/CB-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937028#comment-14937028 ] Shazron Abdullah commented on CB-9721: -- I was actually thinking modifying the build.xcconfig file, not the project file. Does it not get picked up when you add it there? > Set ENABLE_BITCODE to NO in build.xcconfig > -- > > Key: CB-9721 > URL: https://issues.apache.org/jira/browse/CB-9721 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > Labels: cordova-ios-4.0.x > > By default in Xcode 7, it is set to YES. > This means that all libs/frameworks etc must have been built with > ENABLE_BITCODE = YES as well. > Setting this to NO will ensure backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9721) Set ENABLE_BITCODE to NO in build.xcconfig
[ https://issues.apache.org/jira/browse/CB-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937076#comment-14937076 ] Simon MacDonald commented on CB-9721: - I created a new app without this change and bitcode was enabled. Then I created a new app with the change in the PR and bitcode was disabled. When I load the project in Xcode the bitcode setting is bolded which IIRC means that it is over-ridden? Anyway, if there is a better way let me know and I'll make the changes. > Set ENABLE_BITCODE to NO in build.xcconfig > -- > > Key: CB-9721 > URL: https://issues.apache.org/jira/browse/CB-9721 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > Labels: cordova-ios-4.0.x > > By default in Xcode 7, it is set to YES. > This means that all libs/frameworks etc must have been built with > ENABLE_BITCODE = YES as well. > Setting this to NO will ensure backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9721) Set ENABLE_BITCODE to NO in build.xcconfig
[ https://issues.apache.org/jira/browse/CB-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937699#comment-14937699 ] Simon MacDonald commented on CB-9721: - [~shazron] This seems to work. Is it along the lines of what you were thinking? Lemme know and I'll merge it. > Set ENABLE_BITCODE to NO in build.xcconfig > -- > > Key: CB-9721 > URL: https://issues.apache.org/jira/browse/CB-9721 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > Labels: cordova-ios-4.0.x > > By default in Xcode 7, it is set to YES. > This means that all libs/frameworks etc must have been built with > ENABLE_BITCODE = YES as well. > Setting this to NO will ensure backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9721) Set ENABLE_BITCODE to NO in build.xcconfig
[ https://issues.apache.org/jira/browse/CB-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937702#comment-14937702 ] Shazron Abdullah commented on CB-9721: -- thanks Simon! -- sorry for not being clear in the first place (was mobile). > Set ENABLE_BITCODE to NO in build.xcconfig > -- > > Key: CB-9721 > URL: https://issues.apache.org/jira/browse/CB-9721 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > Labels: cordova-ios-4.0.x > > By default in Xcode 7, it is set to YES. > This means that all libs/frameworks etc must have been built with > ENABLE_BITCODE = YES as well. > Setting this to NO will ensure backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9598) Factor out shared logic to cordova-common module and publish it separately.
[ https://issues.apache.org/jira/browse/CB-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937716#comment-14937716 ] ASF GitHub Bot commented on CB-9598: Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/311#issuecomment-144477642 Looks like there is a Travis CI failure and appveyor does not even run the tests. > Factor out shared logic to cordova-common module and publish it separately. > --- > > Key: CB-9598 > URL: https://issues.apache.org/jira/browse/CB-9598 > Project: Apache Cordova > Issue Type: Sub-task > Components: CordovaCommon, CordovaLib >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > > There also a potential problem of code duplication, since the PlatformApi > needs for several classes, which currently being stored and exposed by > cordova-lib: ConfigParser, PluginInfo, etc. The one of solutions of this > problem - is to factor out the common classes and routines to shared module > (proposed name - cordova-common), which then will be released separately. > This approach is discussed in cordova-lib/#235 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org