[
https://issues.apache.org/jira/browse/CB-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936919#comment-14936919
]
ASF GitHub Bot commented on CB-9598:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/311
CB-9598 Switching to use `cordova-common` module
See [CB-9598](https://issues.apache.org/jira/browse/CB-9598) for details.
This PR just removes code which has been copied previously to
`cordova-common` and updates requires to point to that code. The LIB includes
`cordova-common` as a bundled dependency, so it doesn't need to be published.
To npm links to new module could be set up using `coho npm-link` after
pulling in the following PR to cordova-coho:
https://github.com/apache/cordova-coho/pull/94
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9598
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/311.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #311
----
commit 4c7bcc84a4ef96d84df968ac30c06b70945ef1b1
Author: Vladimir Kotikov <[email protected]>
Date: 2015-09-30T13:24:06Z
CB-9598 Cleans out code which has been moved to `cordova-common`
commit a15f049f9882935f7426e23cfe409841ab9ae722
Author: Vladimir Kotikov <[email protected]>
Date: 2015-09-30T14:43:04Z
CB-9598 Switches LIB to use `cordova-common`
* Updates requires to point to `cordova-common`
* Add 'cordova-common' as bundled dependency
----
> Factor out shared logic to cordova-common module and publish it separately.
> ---------------------------------------------------------------------------
>
> Key: CB-9598
> URL: https://issues.apache.org/jira/browse/CB-9598
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: CordovaCommon, CordovaLib
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> There also a potential problem of code duplication, since the PlatformApi
> needs for several classes, which currently being stored and exposed by
> cordova-lib: ConfigParser, PluginInfo, etc. The one of solutions of this
> problem - is to factor out the common classes and routines to shared module
> (proposed name - cordova-common), which then will be released separately.
> This approach is discussed in cordova-lib/#235
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
