[jira] [Comment Edited] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233657#comment-16233657
]
Kenichi Naito edited comment on CB-13496 at 11/1/17 4:52 AM:
-
Thanks, Audrey.
For example if you add the plugin where plugin.xml has
```
$(AppIdentifierPrefix)$PACKAGE_NAME
$(AppIdentifierPrefix)com.example.mylib
```
the Entitlements-Debug.plist becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
$(AppIdentifierPrefix)com.example.mylib
```
However after cordova prepare command, the Entitlements-Debug.plist becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
```
because nodeEqual function treats the above two string as `(.*?)`. Therefore
one of two is removed.
was (Author: knaito):
Thanks, Audrey.
For example if you add the plugin where plugin.xml has
```
$(AppIdentifierPrefix)$PACKAGE_NAME
$(AppIdentifierPrefix)com.example.mylib
```
the Entitlements-Debug.plist becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
$(AppIdentifierPrefix)com.example.mylib
```
However after cordova prepare command, the Entitlements-Debug.plist becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
```
because nodeEqual function treat the above two string as `(.*?)`. Therefore
one of two is removed.
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Kenichi Naito
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233657#comment-16233657
]
Kenichi Naito edited comment on CB-13496 at 11/1/17 4:52 AM:
-
Thanks, Audrey.
For example if you add the plugin where plugin.xml has
```
$(AppIdentifierPrefix)$PACKAGE_NAME
$(AppIdentifierPrefix)com.example.mylib
```
the Entitlements-Debug.plist becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
$(AppIdentifierPrefix)com.example.mylib
```
However after cordova prepare command, the Entitlements-Debug.plist becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
```
because nodeEqual function treat the above two string as `(.*?)`. Therefore
one of two is removed.
was (Author: knaito):
Thanks, Audrey.
For example if you add the plugin where plugin.xml has
```
$(AppIdentifierPrefix)$PACKAGE_NAME
$(AppIdentifierPrefix)com.example.mylib
```
the Entitlements-Debug.plist becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
$(AppIdentifierPrefix)com.example.mylib
```
However after cordova prepare command, this becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
```
because nodeEqual function treat the above two string as `(.*?)`. Therefore
one of two is removed.
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Kenichi Naito
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233657#comment-16233657
]
Kenichi Naito edited comment on CB-13496 at 11/1/17 4:51 AM:
-
Thanks, Audrey.
For example if you add the plugin where plugin.xml has
```
$(AppIdentifierPrefix)$PACKAGE_NAME
$(AppIdentifierPrefix)com.example.mylib
```
the Entitlements-Debug.plist becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
$(AppIdentifierPrefix)com.example.mylib
```
However after cordova prepare command, this becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
```
because nodeEqual function treat the above two string as `(.*?)`. Therefore
one of two is removed.
was (Author: knaito):
Thanks, Audrey.
For example if you add the plugin with plugin.xml as
```
$(AppIdentifierPrefix)$PACKAGE_NAME
$(AppIdentifierPrefix)com.example.mylib
```
the Entitlements-Debug.plist becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
$(AppIdentifierPrefix)com.example.mylib
```
However after cordova prepare command, this becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
```
because nodeEqual function treat the above two string as `(.*?)`. Therefore
one of two is removed.
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Kenichi Naito
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233657#comment-16233657
]
Kenichi Naito commented on CB-13496:
Thanks, Audrey.
For example if you add the plugin with plugin.xml as
```
$(AppIdentifierPrefix)$PACKAGE_NAME
$(AppIdentifierPrefix)com.example.mylib
```
the Entitlements-Debug.plist becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
$(AppIdentifierPrefix)com.example.mylib
```
However after cordova prepare command, this becomes
```
keychain-access-groups
$(AppIdentifierPrefix)io.cordova.hellocordova
```
because nodeEqual function treat the above two string as `(.*?)`. Therefore
one of two is removed.
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Kenichi Naito
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12808) 'Error: AppPackages doesn't exists` when building for windows@5.0.0
[
https://issues.apache.org/jira/browse/CB-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233586#comment-16233586
]
Christoph Brosdau commented on CB-12808:
Did anyone found a Solution for this?
I have the same Issue on Cordova 7.1.0, Node 6.11.3 and Visual Studio 2017.
I also added the Preference windows-target-version to 10.0 and have exactly the
same Output.
> 'Error: AppPackages doesn't exists` when building for windows@5.0.0
> ---
>
> Key: CB-12808
> URL: https://issues.apache.org/jira/browse/CB-12808
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Environment: See VisualStudioCommunity-Specs attachment.
> Windows 10 Home (see Windows10Home-About attachment)
> Microsoft Visual Studio Community 2017 Version 15.2 (26430.4) Release
> Windows 10 SDK 10.0.15063.137
> cordova@6.5.0 and cordova@7.0.0
>Reporter: Shazron Abdullah
>Priority: Major
> Attachments: VisualStudioCommunity-Specs.txt, Windows10Home-About.PNG
>
>
> See Environment field.
> 1. Install Windows 10 Home with latest updates as of May 12 2017
> 2. Install Visual Studio Community Edition with latest updates as of May 12
> 2017
> 3. Install Windows 10 SDK 10.0.15063.137
> 4. Add to your environment variables 'VSINSTALLDIR` value: {{C:\Program Files
> (x86)\Microsoft Visual Studio\2017\Community\}}
> Repro:
> {code}
> $ cordova create foo
> $ cd foo
> # edit config.xml to add these two tags below (without the hashes):
> #
> #
> $ cordova platform add windows
> Adding windows project...
> Creating Cordova Windows Project:
> Path: platforms\windows
> Namespace: io.cordova.hellocordova
> Name: HelloCordova
> Windows project created with cordova-windows@5.0.0
> Installing "cordova-plugin-whitelist" for windows
> $ cordova build windows
> Building project:
> C:\Users\shazron\Desktop\foo\platforms\windows\CordovaApp.Windows10.jsproj
> Configuration : debug
> Platform : anycpu
> Patching 10 in prebuild event...
> Injected base.js reference to the /www/index.html
> Removing /(
> *)(
> \s*<\/script>)(\s*)/ from /www/index.html
> Removing /(
> *)(\s*<\/script>)(\s*)/ from /www/index.html
> Error: AppPackages doesn't exists
> {code}
> The error originates in the platform code, here:
> https://github.com/apache/cordova-windows/blob/7fe4c21229815d216a985b114a4db5f01b5e5169/template/cordova/lib/package.js#L32-L36
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13524) Requirements check failed for JDK 1.8 or greater
Cyril Walle created CB-13524: Summary: Requirements check failed for JDK 1.8 or greater Key: CB-13524 URL: https://issues.apache.org/jira/browse/CB-13524 Project: Apache Cordova Issue Type: Bug Components: cordova-android, cordova-cli Environment: cordova --version 7.1.0 (npm says 5.5.1), cordova platform android 6.3.0 win8, java sdk 9.0.1 Reporter: Cyril Walle Assignee: Joe Bowser Priority: Normal After using cordova build android I get error JAVA_HOME=C:\Program Files\Java\jdk-9.0.1 Error: Requirements check failed for JDK 1.8 or greater is the 9.01 not good ? Should I install Java SE Development Kit 8u151 or Java SE Development Kit 8u152 ? PS also on page http://cordova.apache.org/contribute/issues.html Finding out versions You can quickly find out versions of platforms/plugins you're using by running: cordova platform ls should be replaced with cordova platform -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16230561#comment-16230561 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == + Coverage 63.43% 63.45% +0.02% == Files 14 14 Lines1690 1691 +1 Branches 283 284 +1 == + Hits 1072 1073 +1 Misses618 618 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.61% <66.66%> (+0.29%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...333c879](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16230465#comment-16230465 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == + Coverage 63.43% 63.45% +0.02% == Files 14 14 Lines1690 1691 +1 Branches 283 284 +1 == + Hits 1072 1073 +1 Misses618 618 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.61% <66.66%> (+0.29%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...333c879](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16230588#comment-16230588 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == + Coverage 63.43% 63.45% +0.02% == Files 14 14 Lines1690 1691 +1 Branches 283 284 +1 == + Hits 1072 1073 +1 Misses618 618 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.61% <66.66%> (+0.29%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...333c879](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227791#comment-16227791 ] ASF GitHub Bot commented on CB-13523: - dpogue opened a new pull request #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347 ### Platforms affected iOS with Xcode 9 ### What does this PR do? This adds a `automaticProvisioning` option to the build config which passes flags to xcodebuild during the exporting step that allow it to automatically create and update provisioning profiles for automatic code signing. I don't love that we're adding even more random stuff to the build config, but I suspect most people don't want this to be enabled by default. ### What testing has been done on this change? Added a case to existing spec tests. Will be testing this branch on my work's CI system with our ongoing projects, and will update the PR title when I've verified it's working as intended. ### Checklist - [x] Reported [CB-13523](https://issues.apache.org/jira/browse/CB-13523) - [x] Commit message follows the format - [x] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13523) Add build config option to enable Xcode automatic provisioning
Darryl Pogue created CB-13523: - Summary: Add build config option to enable Xcode automatic provisioning Key: CB-13523 URL: https://issues.apache.org/jira/browse/CB-13523 Project: Apache Cordova Issue Type: Improvement Components: cordova-ios Environment: Xcode 9 Cordova-iOS 4.5.3 Reporter: Darryl Pogue Assignee: Darryl Pogue Xcode 9 made more changes to how provisioning works for apps, particularly around manual vs automatic signing. The changes required to support manual signing of release builds was implemented as part of CB-13315. In order for automatic signing to work, we need to pass an additional flag to xcodebuild to allow Xcode to manage automatically updating provisioning profiles as needed. I want to keep this being a build config option because many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12653) Adding jasmine tests in coho for util files
[
https://issues.apache.org/jira/browse/CB-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227780#comment-16227780
]
ASF GitHub Bot commented on CB-12653:
-
stevengill closed pull request #146: CB-12653 : added jasmine tests for coho
util files
URL: https://github.com/apache/cordova-coho/pull/146
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 5eb3d60..1b02074 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -8,4 +8,4 @@ node_js:
install:
- "npm install"
script:
-- "npm test"
+- "npm test"
\ No newline at end of file
diff --git a/package.json b/package.json
index 2bd3377..5d5608f 100644
--- a/package.json
+++ b/package.json
@@ -60,4 +60,4 @@
"Brian LeRoux"
],
"license": "Apache-2.0"
-}
+}
\ No newline at end of file
diff --git a/spec/apputil.spec.js b/spec/apputil.spec.js
new file mode 100644
index 000..fa1351d
--- /dev/null
+++ b/spec/apputil.spec.js
@@ -0,0 +1,49 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var path = require('path');
+var chalk = require('chalk');
+var shell = require('shelljs');
+var apputil = require('../src/apputil');
+
+describe("apputil unit tests", function () {
+
+ it("Test#001 : print", function() {
+ spyOn(path, "relative").and.returnValue(true);
+ spyOn(console.log,"apply").and.returnValue(true);
+ apputil.print();
+ expect(path.relative.calls.count()).toEqual(0);
+ expect(console.log.apply.calls.count()).toEqual(1);
+ });
+
+ it("Test#002 : fatal", function() {
+ spyOn(console.error,"apply").and.returnValue(false);
+ spyOn(process,"exit").and.returnValue(false);
+ apputil.fatal();
+ expect(console.error.apply.calls.count()).toEqual(1);
+ expect(process.exit.calls.count()).toEqual(1);
+ });
+
+ it("Test#003 : initWorkingDir", function() {
+ spyOn(console,"log").and.returnValue(false);
+ apputil.initWorkingDir(true);
+ expect(console.log.calls.count()).toEqual(1);
+ expect(console.log.calls.allArgs()).toMatch("Running from");
+ });
+});
\ No newline at end of file
diff --git a/spec/executil.spec.js b/spec/executil.spec.js
new file mode 100644
index 000..6701761
--- /dev/null
+++ b/spec/executil.spec.js
@@ -0,0 +1,84 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var jasmine_co = require('jasmine-co').install();
+var executil = require('../src/executil');
+var superspawn = require('../src/superspawn');
+var apputil = require('../src/apputil');
+var Q = require("q");
+var deferred = Q.defer();
+var TIMEOUT = 6;
+var androidRepo = { title: 'Android',
+ id: 'android',
+ repoName: 'cordova-android',
+ jiraComponentName: 'Android',
+ cordovaJsPaths: [ 'bin/templates/project/assets/www/cordova.js' ],
+ remoteName: 'origin' };
+
+describe("executil unit tests", function () {
+ beforeEach(function () {
+ spyOn(apputil, "print").and.returnValue(true);
+ spyOn(superspawn, "spawn").and.returnValue(deferred.promise);
+ });
+
+ afterEach(function () {
+
[jira] [Commented] (CB-12653) Adding jasmine tests in coho for util files
[ https://issues.apache.org/jira/browse/CB-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227781#comment-16227781 ] ASF subversion and git services commented on CB-12653: -- Commit 453b914e423db162732d3137ae5ddffe24ca4cdb in cordova-coho's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-coho.git;h=453b914 ] CB-12653 : added jasmine_co and included jasmine tests for versionutil, apputil, flagutil, executil, and repoutil > Adding jasmine tests in coho for util files > --- > > Key: CB-12653 > URL: https://issues.apache.org/jira/browse/CB-12653 > Project: Apache Cordova > Issue Type: Test > Components: cordova-coho >Affects Versions: cordova@7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: coho, cordova@7 > Fix For: cordova@7 > > > Adding jasmine tests in coho to test util files -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13522) Remove ios usage description from cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile reassigned CB-13522: - Assignee: jcesarmobile > Remove ios usage description from cordova-plugin-contacts > - > > Key: CB-13522 > URL: https://issues.apache.org/jira/browse/CB-13522 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13522) Remove ios usage description from cordova-plugin-contacts
jcesarmobile created CB-13522: - Summary: Remove ios usage description from cordova-plugin-contacts Key: CB-13522 URL: https://issues.apache.org/jira/browse/CB-13522 Project: Apache Cordova Issue Type: Sub-task Reporter: jcesarmobile -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13521) Add 'protective' entry to cordovaDependencies for cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile reassigned CB-13521: - Assignee: jcesarmobile > Add 'protective' entry to cordovaDependencies for cordova-plugin-contacts > - > > Key: CB-13521 > URL: https://issues.apache.org/jira/browse/CB-13521 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13521) Add 'protective' entry to cordovaDependencies for cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227766#comment-16227766 ] ASF GitHub Bot commented on CB-13521: - jcesarmobile opened a new pull request #157: CB-13521 (iOS): Add 'protective' entry to cordovaDependencies URL: https://github.com/apache/cordova-plugin-contacts/pull/157 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add 'protective' entry to cordovaDependencies for cordova-plugin-contacts > - > > Key: CB-13521 > URL: https://issues.apache.org/jira/browse/CB-13521 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13521) Add 'protective' entry to cordovaDependencies for cordova-plugin-contacts
jcesarmobile created CB-13521: - Summary: Add 'protective' entry to cordovaDependencies for cordova-plugin-contacts Key: CB-13521 URL: https://issues.apache.org/jira/browse/CB-13521 Project: Apache Cordova Issue Type: Sub-task Reporter: jcesarmobile -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13519) Add 'protective' entry to cordovaDependencies for cordova-plugin-wkwebview-engine
jcesarmobile created CB-13519: - Summary: Add 'protective' entry to cordovaDependencies for cordova-plugin-wkwebview-engine Key: CB-13519 URL: https://issues.apache.org/jira/browse/CB-13519 Project: Apache Cordova Issue Type: Sub-task Reporter: jcesarmobile -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13520) Add 'protective' entry to cordovaDependencies for cordova-plugin-media-capture
jcesarmobile created CB-13520: - Summary: Add 'protective' entry to cordovaDependencies for cordova-plugin-media-capture Key: CB-13520 URL: https://issues.apache.org/jira/browse/CB-13520 Project: Apache Cordova Issue Type: Sub-task Reporter: jcesarmobile -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13517) Add 'protective' entry to cordovaDependencies for cordova-plugin-media
jcesarmobile created CB-13517: - Summary: Add 'protective' entry to cordovaDependencies for cordova-plugin-media Key: CB-13517 URL: https://issues.apache.org/jira/browse/CB-13517 Project: Apache Cordova Issue Type: Sub-task Reporter: jcesarmobile -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13516) Add 'protective' entry to cordovaDependencies for cordova-plugin-geolocation
jcesarmobile created CB-13516: - Summary: Add 'protective' entry to cordovaDependencies for cordova-plugin-geolocation Key: CB-13516 URL: https://issues.apache.org/jira/browse/CB-13516 Project: Apache Cordova Issue Type: Sub-task Reporter: jcesarmobile -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13518) Add 'protective' entry to cordovaDependencies for cordova-plugin-file
jcesarmobile created CB-13518: - Summary: Add 'protective' entry to cordovaDependencies for cordova-plugin-file Key: CB-13518 URL: https://issues.apache.org/jira/browse/CB-13518 Project: Apache Cordova Issue Type: Sub-task Reporter: jcesarmobile -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13515) Add 'protective' entry to cordovaDependencies for cordova-plugin-camera
jcesarmobile created CB-13515: - Summary: Add 'protective' entry to cordovaDependencies for cordova-plugin-camera Key: CB-13515 URL: https://issues.apache.org/jira/browse/CB-13515 Project: Apache Cordova Issue Type: Sub-task Reporter: jcesarmobile -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13076) Sunset cordova-plugin-device-orientation
[ https://issues.apache.org/jira/browse/CB-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227752#comment-16227752 ] ASF GitHub Bot commented on CB-13076: - maverickmishra commented on issue #155: CB-13076 , CB-13068 : Removed references of cordova device motion and cordova device orientation plugins URL: https://github.com/apache/cordova-coho/pull/155#issuecomment-340931605 Ok. Will do that soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Sunset cordova-plugin-device-orientation > > > Key: CB-13076 > URL: https://issues.apache.org/jira/browse/CB-13076 > Project: Apache Cordova > Issue Type: Task > Components: cordova-plugin-device-orientation (DEPRECATED) >Reporter: Filip Maj >Assignee: Vishal Mishra > Labels: plugins-next > > Todo (see subtasks): > 1. Deprecate JIRA components. > 2. Close out all github PRs and JIRA issues. > 3. What do we need to inform Apache Infra of? > 4. Update plugin README to reflect status of plugin and point to transition > blog post. > 5. Update coho to remove any references to the plugin. > 6. Update cordova-docs to remove plugin references / remove code generation > around cordova-plugin-device-orientation. > 7. Do one final release of the plugin. > 8. Ensure we deprecate the plugin in npm. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227745#comment-16227745 ] ASF subversion and git services commented on CB-12762: -- Commit 52be89f106f0f726394392f582c48b1874c3f34f in cordova-coho's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-coho.git;h=52be89f ] CB-12762 : point package.json repo items to github mirrors instead of apache repo site > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen >Assignee: Audrey So > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[
https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227744#comment-16227744
]
ASF GitHub Bot commented on CB-12762:
-
stevengill closed pull request #151: CB-12762 : point package.json repo items
to github mirrors instead of…
URL: https://github.com/apache/cordova-coho/pull/151
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/package.json b/package.json
index 4a3fb52..4df89ed 100644
--- a/package.json
+++ b/package.json
@@ -41,7 +41,7 @@
},
"repository": {
"type": "git",
-"url": "https://git-wip-us.apache.org/repos/asf/cordova-coho.git;
+"url": "https://github.com/apache/cordova-coho;
},
"bugs": {
"url": "https://issues.apache.org/jira/browse/CB;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Point package.json repo items to github mirrors
> ---
>
> Key: CB-12762
> URL: https://issues.apache.org/jira/browse/CB-12762
> Project: Apache Cordova
> Issue Type: Bug
> Components: AllComponents
>Reporter: Jesse MacFadyen
>Assignee: Audrey So
>
> Proposal is here:
> https://github.com/cordova/cordova-discuss/issues/67
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227747#comment-16227747 ] ASF subversion and git services commented on CB-12762: -- Commit 049a1f762d2cd45d337fa20a27417b9530d743f9 in cordova-coho's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-coho.git;h=049a1f7 ] Merge pull request #151 from audreyso/CB-12762 CB-12762 : point package.json repo items to github mirrors instead of… > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen >Assignee: Audrey So > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227746#comment-16227746 ] ASF subversion and git services commented on CB-12762: -- Commit 049a1f762d2cd45d337fa20a27417b9530d743f9 in cordova-coho's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-coho.git;h=049a1f7 ] Merge pull request #151 from audreyso/CB-12762 CB-12762 : point package.json repo items to github mirrors instead of… > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen >Assignee: Audrey So > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13076) Sunset cordova-plugin-device-orientation
[ https://issues.apache.org/jira/browse/CB-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227743#comment-16227743 ] ASF GitHub Bot commented on CB-13076: - stevengill commented on issue #155: CB-13076 , CB-13068 : Removed references of cordova device motion and cordova device orientation plugins URL: https://github.com/apache/cordova-coho/pull/155#issuecomment-340931034 Instead of removing these from repoutil, lets mark them inactive like https://github.com/apache/cordova-coho/blob/master/src/repoutil.js#L274 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Sunset cordova-plugin-device-orientation > > > Key: CB-13076 > URL: https://issues.apache.org/jira/browse/CB-13076 > Project: Apache Cordova > Issue Type: Task > Components: cordova-plugin-device-orientation (DEPRECATED) >Reporter: Filip Maj >Assignee: Vishal Mishra > Labels: plugins-next > > Todo (see subtasks): > 1. Deprecate JIRA components. > 2. Close out all github PRs and JIRA issues. > 3. What do we need to inform Apache Infra of? > 4. Update plugin README to reflect status of plugin and point to transition > blog post. > 5. Update coho to remove any references to the plugin. > 6. Update cordova-docs to remove plugin references / remove code generation > around cordova-plugin-device-orientation. > 7. Do one final release of the plugin. > 8. Ensure we deprecate the plugin in npm. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13511) update coho to work with apache repos that moved over to github
[
https://issues.apache.org/jira/browse/CB-13511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227731#comment-16227731
]
ASF GitHub Bot commented on CB-13511:
-
stevengill closed pull request #163: CB-13511: added github boolean to repos
that have moved over to github
URL: https://github.com/apache/cordova-coho/pull/163
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index a112c14..5eb3d60 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,6 +1,11 @@
language: node_js
sudo: false
node_js:
-- "0.10"
+- "4"
+- "6"
+- "8"
+
install:
-- npm install
+- "npm install"
+script:
+- "npm test"
diff --git a/appveyor.yml b/appveyor.yml
index c9b8cf9..e3ddd70 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -1,7 +1,14 @@
# appveyor file
# http://www.appveyor.com/docs/appveyor-yml
+environment:
+ matrix:
+ - nodejs_version: "4"
+ - nodejs_version: "6"
+ - nodejs_version: "8"
+
install:
+ - ps: Install-Product node $env:nodejs_version
- npm install
build: off
diff --git a/package.json b/package.json
index b9a6932..c3ea748 100644
--- a/package.json
+++ b/package.json
@@ -42,7 +42,7 @@
},
"scripts": {
"oldtest": "node test/test.js | tap-spec",
-"test": "npm run jasmine",
+"test": "npm run eslint",
"cover": "istanbul cover --root src --print detail jasmine",
"jasmine": "jasmine --captureExceptions --color",
"eslint": "eslint test && eslint src"
diff --git a/src/main.js b/src/main.js
index 958bca4..11b9a1b 100644
--- a/src/main.js
+++ b/src/main.js
@@ -64,6 +64,10 @@ module.exports = function () {
name: 'list-repos',
desc: 'Shows a list of valid values for the --repo flag.',
entryPoint: lazyRequire('./list-repos')
+}, {
+name: 'remote-update',
+desc: 'Update specified git remote to point to corresponding
apache github repo',
+entryPoint: lazyRequire('./remote-update')
}];
var releaseCommands = [{
name: 'prepare-platform-release-branch',
diff --git a/src/remote-update.js b/src/remote-update.js
new file mode 100644
index 000..46f7bb9
--- /dev/null
+++ b/src/remote-update.js
@@ -0,0 +1,72 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var optimist = require('optimist');
+var executil = require('./executil');
+var flagutil = require('./flagutil');
+var repoutil = require('./repoutil');
+
+module.exports = function * (argv) {
+console.log('here');
+var opt = flagutil.registerRepoFlag(optimist);
+opt = flagutil.registerDepthFlag(opt);
+
+var opt = opt // eslint-disable-line no-redeclare
+.options('remote', {
+desc: 'The name of the remote you want to update. Example: origin',
+default: ['origin']
+});
+
+opt = flagutil.registerHelpFlag(opt);
+var argv = opt // eslint-disable-line no-redeclare
+.usage('Updates specified git remotes to apache github repos by
performing the following command:\n' +
+ 'for each specified repo:\n' +
+ 'git remote set-url $REMOTE APACHE_GITHUB_URL' +
+ 'By default, it will set $REMOTE to origin and
APACHE_GITHUB_URL to the corresponding apache github repo' +
+ '\n' +
+ 'Usage: $0 remote-update [--remote remoteName] [-r repos]')
+.argv;
+
+if (argv.h) {
+optimist.showHelp();
+process.exit(1);
+}
+
+var remote = argv.remote;
+var repos = flagutil.computeReposFromFlag(argv.r, true);
+
+// ensure that any missing repos are cloned
+// yield require('./repo-clone').cloneRepos(repos, true, depth);
+yield updateRemote(repos, remote);
+};
+
+function * updateRemote (repos, remote) {
+
+yield repoutil.forEachRepo(repos, function * (repo) {
+
+// don't update svn repos
+if (repo.svn) {
+return;
+}
+
+yield
[jira] [Commented] (CB-13511) update coho to work with apache repos that moved over to github
[ https://issues.apache.org/jira/browse/CB-13511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227734#comment-16227734 ] ASF subversion and git services commented on CB-13511: -- Commit 042cd55e865aebedfc74ded1664e2ba08b28f18a in cordova-coho's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-coho.git;h=042cd55 ] CB-13511: removed reference to apache git repos > update coho to work with apache repos that moved over to github > --- > > Key: CB-13511 > URL: https://issues.apache.org/jira/browse/CB-13511 > Project: Apache Cordova > Issue Type: Improvement >Reporter: Steve Gill > > We don't need the apache git repos anymore since our repos have been moved > over to github proper. Update coho to reflect that -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13511) update coho to work with apache repos that moved over to github
[ https://issues.apache.org/jira/browse/CB-13511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227733#comment-16227733 ] ASF subversion and git services commented on CB-13511: -- Commit 5cdf30c60c9a3abb80200fd893cea03aa9e6d907 in cordova-coho's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-coho.git;h=5cdf30c ] CB-13511: added new remote-update command to update remote to apache github repos > update coho to work with apache repos that moved over to github > --- > > Key: CB-13511 > URL: https://issues.apache.org/jira/browse/CB-13511 > Project: Apache Cordova > Issue Type: Improvement >Reporter: Steve Gill > > We don't need the apache git repos anymore since our repos have been moved > over to github proper. Update coho to reflect that -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13511) update coho to work with apache repos that moved over to github
[ https://issues.apache.org/jira/browse/CB-13511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227735#comment-16227735 ] ASF subversion and git services commented on CB-13511: -- Commit 3de6d3f6f8ad0a9ef32990d819b215d723967ae2 in cordova-coho's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-coho.git;h=3de6d3f ] Merge pull request #163 from stevengill/master CB-13511: added github boolean to repos that have moved over to github > update coho to work with apache repos that moved over to github > --- > > Key: CB-13511 > URL: https://issues.apache.org/jira/browse/CB-13511 > Project: Apache Cordova > Issue Type: Improvement >Reporter: Steve Gill > > We don't need the apache git repos anymore since our repos have been moved > over to github proper. Update coho to reflect that -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13511) update coho to work with apache repos that moved over to github
[ https://issues.apache.org/jira/browse/CB-13511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227732#comment-16227732 ] ASF subversion and git services commented on CB-13511: -- Commit cb3674342a9cadb02abe4f065badf8af51cf8d46 in cordova-coho's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-coho.git;h=cb36743 ] CB-13511: added github boolean to repos that have moved over to github > update coho to work with apache repos that moved over to github > --- > > Key: CB-13511 > URL: https://issues.apache.org/jira/browse/CB-13511 > Project: Apache Cordova > Issue Type: Improvement >Reporter: Steve Gill > > We don't need the apache git repos anymore since our repos have been moved > over to github proper. Update coho to reflect that -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13493) Cordova-iOS Platform Release October 25, 2017
[ https://issues.apache.org/jira/browse/CB-13493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227703#comment-16227703 ] ASF GitHub Bot commented on CB-13493: - surajpindoria closed pull request #754: CB-13493: Blog post for cordova-ios@4.5.3 URL: https://github.com/apache/cordova-docs/pull/754 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/www/_posts/2017-10-31-ios-release.md b/www/_posts/2017-10-31-ios-release.md new file mode 100644 index 0..270c8d20e --- /dev/null +++ b/www/_posts/2017-10-31-ios-release.md @@ -0,0 +1,40 @@ +--- +layout: post +author: +name: Suraj Pindoria +url: https://twitter.com/surajpindoria +title: "Cordova iOS 4.5.3" +categories: announcements +tags: news releases +--- + +We are happy to announce a minor version of `Cordova iOS 4.5.3` has been released! + +This version continues to add updates for the latest iOS 11 and Xcode 9. + +Things to note: + +* Updated splash screen mapping for new and missing devices +* Re-added an icon mapping that was accidentally removed + +**Note:** When updating **iOS**, make sure to save your plugins as current unsaved plugins may not be reinstalled otherwise. Run the following command in your project to save your currently installed plugins into `config.xml`: + +cordova plugin save + +To upgrade: + +npm install -g cordova +cd my_project +cordova platform rm ios +cordova platform add ios@4.5.3 + +To add it explicitly: + +cordova platform add ios@4.5.3 + + +## What's new in iOS + +* [CB-13493](https://issues.apache.org/jira/browse/CB-13493) Updated checked-in node_modules +* [CB-13290](https://issues.apache.org/jira/browse/CB-13290) (ios) Update splash screen mapping for missing devices +* [CB-13454](https://issues.apache.org/jira/browse/CB-13454) (ios) re-add icon...@2x.png that was accidentally removed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova-iOS Platform Release October 25, 2017 > - > > Key: CB-13493 > URL: https://issues.apache.org/jira/browse/CB-13493 > Project: Apache Cordova > Issue Type: Task >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13493) Cordova-iOS Platform Release October 25, 2017
[ https://issues.apache.org/jira/browse/CB-13493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227705#comment-16227705 ] ASF subversion and git services commented on CB-13493: -- Commit 846a0e23459e1f1612fc3c3673bd00780075469a in cordova-docs's branch refs/heads/master from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=846a0e2 ] CB-13493: Blog post for cordova-ios@4.5.3 > Cordova-iOS Platform Release October 25, 2017 > - > > Key: CB-13493 > URL: https://issues.apache.org/jira/browse/CB-13493 > Project: Apache Cordova > Issue Type: Task >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13511) update coho to work with apache repos that moved over to github
[ https://issues.apache.org/jira/browse/CB-13511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227687#comment-16227687 ] ASF GitHub Bot commented on CB-13511: - audreyso commented on issue #163: CB-13511: added github boolean to repos that have moved over to github URL: https://github.com/apache/cordova-coho/pull/163#issuecomment-340922272 LGTM, also ran npm test & it passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > update coho to work with apache repos that moved over to github > --- > > Key: CB-13511 > URL: https://issues.apache.org/jira/browse/CB-13511 > Project: Apache Cordova > Issue Type: Improvement >Reporter: Steve Gill > > We don't need the apache git repos anymore since our repos have been moved > over to github proper. Update coho to reflect that -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13293) already fetched platforms shouldn't call fetch code
[ https://issues.apache.org/jira/browse/CB-13293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227666#comment-16227666 ] ASF GitHub Bot commented on CB-13293: - audreyso opened a new pull request #605: CB-13293 : if fetch has been called already, no need to fetch again URL: https://github.com/apache/cordova-lib/pull/605 ### Platforms affected ### What does this PR do? Prevent fetch from being called, if it has already been called. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > already fetched platforms shouldn't call fetch code > --- > > Key: CB-13293 > URL: https://issues.apache.org/jira/browse/CB-13293 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: tools-next > Fix For: cordova@7.1.0 > > > adding a platform that has already been added/fetched will still call > cordova-fetch before realizing the platform is already installed. Need to > check if platform is added first. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227640#comment-16227640 ] Suraj Pindoria commented on CB-12886: - There are a few other issues that are tracking some of these iPhone X related issues. I am wrapping up the last iOS release and then will work on getting these new fixes in. CB-13411 and CB-13505 could possibly help you out with some of your issues. > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png, > screenshot-3.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[
https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227454#comment-16227454
]
ASF GitHub Bot commented on CB-13501:
-
audreyso closed pull request #604: CB-13501 : added support for node 8 and
cleaned up eslint
URL: https://github.com/apache/cordova-lib/pull/604
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index aec9bd618..4bd6e4e42 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,16 +5,8 @@ git:
node_js:
- "4"
- "6"
+ - "8"
install:
- - git clone https://github.com/apache/cordova-js --depth 10
- - git clone https://github.com/apache/cordova-fetch --depth 10
- - git clone https://github.com/apache/cordova-serve --depth 10
- - git clone https://github.com/apache/cordova-common --depth 10
- - (cd cordova-js && npm install && npm link .)
- - (cd cordova-common && npm install && npm link .)
- - (cd cordova-serve && npm install && npm link .)
- - (cd cordova-fetch && npm link cordova-common && npm install && npm link .)
- - (npm link cordova-serve && npm link cordova-fetch && npm link
cordova-common && npm link cordova-js)
- npm install
# Workaround for npm/npm#10343 when dependency of linked module is moved to
dependent
# module's 'node_modules' In our case 'cordova-common' -> jshint' -> 'cli'
dependency
diff --git a/appveyor.yml b/appveyor.yml
index 535f54682..4c3d2982b 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -5,31 +5,10 @@ environment:
matrix:
- nodejs_version: "4"
- nodejs_version: "6"
+ - nodejs_version: "8"
install:
- ps: Install-Product node $env:nodejs_version
- - git clone https://github.com/apache/cordova-js --depth 10
- - git clone https://github.com/apache/cordova-common --depth 10
- - git clone https://github.com/apache/cordova-fetch --depth 10
- - git clone https://github.com/apache/cordova-serve --depth 10
- - cd cordova-js
- - npm install
- - npm link .
- - cd ../cordova-common
- - npm install
- - npm link .
- - cd ../cordova-serve
- - npm install
- - npm link .
- - cd ../cordova-fetch
- - npm link cordova-common
- - npm install
- - npm link .
- - cd ../
- - npm link cordova-js
- - npm link cordova-fetch
- - npm link cordova-common
- - npm link cordova-serve
- npm install
# Workaround for npm/npm#10343 when dependency of linked module is moved to
dependent
# module's 'node_modules' In our case 'cordova-common' -> jshint' -> 'cli'
dependency
diff --git a/package.json b/package.json
index 6539a6838..07879c3d1 100644
--- a/package.json
+++ b/package.json
@@ -20,7 +20,7 @@
"aliasify": "^2.1.0",
"cordova-common": "2.1.1",
"cordova-create": "~1.1.0",
-"cordova-fetch": "1.2.0",
+"cordova-fetch": "1.2.1",
"cordova-js": "4.2.2",
"cordova-serve": "^2.0.0",
"dep-graph": "1.1.0",
diff --git a/spec/cordova/util.spec.js b/spec/cordova/util.spec.js
index 08b0a16b1..40fcf5df5 100644
--- a/spec/cordova/util.spec.js
+++ b/spec/cordova/util.spec.js
@@ -312,8 +312,9 @@ describe('util module', function () {
describe('getPlatformApiFunction', function () {
it('Test 027 : should throw error informing user to update
platform', function () {
-expect(function () { util.getPlatformApiFunction('some/path',
'android'); }).toThrow(new Error // eslint-disable-line func-call-spacing
-('Uncaught, unspecified "error" event. ( Using this version of
Cordova with older version of cordova-android is deprecated. Upgrade to
cordova-android@5.0.0 or newer.)'));
+expect(function () { util.getPlatformApiFunction('some/path',
'android'); }).toThrowError(
+/(Uncaught, unspecified|Unhandled) "error" event. \( Using
this version of Cordova with older version of cordova-android is deprecated\.
Upgrade to cordova-android@5\.0\.0 or newer.\)/
+);
});
it('Test 028 : should throw error if platform is not supported',
function () {
diff --git a/src/cordova/plugin/add.js b/src/cordova/plugin/add.js
index 0bf5fb163..3b9b78627 100644
--- a/src/cordova/plugin/add.js
+++ b/src/cordova/plugin/add.js
@@ -240,9 +240,8 @@ function determinePluginTarget (projectRoot, cfg, target,
fetchOptions) {
// If parsedSpec.version satisfies pkgJson version, no writing to
pkg.json. Only write when
// it does not satisfy.
/* if (parsedSpec.version) {
-
if (pkgJson && pkgJson.dependencies &&
pkgJson.dependencies[parsedSpec.package]) {
-//it can only go in here if
+//it can only go in here if
var noSymbolVersion = parsedSpec.version;
if
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227455#comment-16227455 ] ASF subversion and git services commented on CB-13501: -- Commit c336af876f9d9f3edeb872b75a3171c2363c7eeb in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=c336af8 ] CB-13501 : added support for node 8 and cleaned up eslint > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227456#comment-16227456 ] ASF subversion and git services commented on CB-13501: -- Commit 30414ced993ece3cba263823b8012f40a5b99f65 in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=30414ce ] Merge pull request #604 from audreyso/CB-13501 CB-13501 : added support for node 8 and cleaned up eslint > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227457#comment-16227457 ] ASF subversion and git services commented on CB-13501: -- Commit 30414ced993ece3cba263823b8012f40a5b99f65 in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=30414ce ] Merge pull request #604 from audreyso/CB-13501 CB-13501 : added support for node 8 and cleaned up eslint > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227417#comment-16227417 ] Shashwat Tripathi edited comment on CB-12886 at 10/31/17 7:58 PM: -- I am also getting the same issue. This is happening only in iPhone-X. !screenshot-3.png! Some discussion going here also: https://github.com/ionic-team/ionic-v1/issues/317#issuecomment-340850973 was (Author: stripathix): I am also getting the same issue. This is happening only in iPhone-X. !screenshot-3.png! > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png, > screenshot-3.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashwat Tripathi updated CB-12886: --- Attachment: screenshot-3.png > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png, > screenshot-3.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227417#comment-16227417 ] Shashwat Tripathi commented on CB-12886: I am also getting the same issue. This is happening only in iPhone-X. !screenshot-3.png! > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png, > screenshot-3.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227294#comment-16227294 ] ASF GitHub Bot commented on CB-13501: - audreyso opened a new pull request #604: CB-13501 : added support for node 8 and cleaned up eslint URL: https://github.com/apache/cordova-lib/pull/604 ### Platforms affected ### What does this PR do? Added support for node 8 and fixed eslint error ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13493) Cordova-iOS Platform Release October 25, 2017
[ https://issues.apache.org/jira/browse/CB-13493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227250#comment-16227250 ] ASF GitHub Bot commented on CB-13493: - surajpindoria opened a new pull request #754: CB-13493: Blog post for cordova-ios@4.5.3 URL: https://github.com/apache/cordova-docs/pull/754 ### Platforms affected ### What does this PR do? Adds a blog post for cordova-ios@4.5.3 release ### What testing has been done on this change? Ran `npm run serve` and reviewed the blog post locally ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova-iOS Platform Release October 25, 2017 > - > > Key: CB-13493 > URL: https://issues.apache.org/jira/browse/CB-13493 > Project: Apache Cordova > Issue Type: Task >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13289) Gradle/Android Plugin DSL change breaks including CordovaLib
[ https://issues.apache.org/jira/browse/CB-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227228#comment-16227228 ] ASF GitHub Bot commented on CB-13289: - codecov-io commented on issue #413: CB-13289: This fixes the Cordova-Android build on cordova-android 6.x URL: https://github.com/apache/cordova-android/pull/413#issuecomment-339514900 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=h1) Report > Merging [#413](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/04fa5d3febe69d7adc91d1e603118f3d33af2606?src=pr=desc) will **increase** coverage by `0.23%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=tree) ```diff @@Coverage Diff @@ ## master #413 +/- ## == + Coverage 43.77% 44.01% +0.23% == Files 17 17 Lines1688 1679 -9 Branches 307 304 -3 == Hits 739 739 + Misses949 940 -9 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `48.13% <0%> (+1.52%)` | :arrow_up: | | [...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz) | `20.71% <0%> (+0.29%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=footer). Last update [04fa5d3...47e20da](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Gradle/Android Plugin DSL change breaks including CordovaLib > > > Key: CB-13289 > URL: https://issues.apache.org/jira/browse/CB-13289 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 6.2.1 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Labels: android-next > Fix For: 7.0.0 > > > Android Studio 3.0.0 uses a new DSL, and this breaks the dependency list. > This directly affects Cordova plugins that work as a Library Module, as well > as adding and removing the Android platform. Basically, once Android Studio > 3.0 updates, Cordova projects will not work properly with the new version of > Android Studio once they're updated. > This depends on CB-11244 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13493) Cordova-iOS Platform Release October 25, 2017
[ https://issues.apache.org/jira/browse/CB-13493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Pindoria closed CB-13493. --- Resolution: Fixed > Cordova-iOS Platform Release October 25, 2017 > - > > Key: CB-13493 > URL: https://issues.apache.org/jira/browse/CB-13493 > Project: Apache Cordova > Issue Type: Task >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13504) Cordova-Fetch Release 1.2.1 October 27, 2017
[ https://issues.apache.org/jira/browse/CB-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-13504. -- Resolution: Fixed > Cordova-Fetch Release 1.2.1 October 27, 2017 > > > Key: CB-13504 > URL: https://issues.apache.org/jira/browse/CB-13504 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Audrey So > Fix For: 1.2.1 > > > Following steps at: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13514) in config.xml removes some XML elements added by plugins
[
https://issues.apache.org/jira/browse/CB-13514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So updated CB-13514:
---
Labels: reproduced triaged (was: )
> in config.xml removes some XML elements added by plugins
> --
>
> Key: CB-13514
> URL: https://issues.apache.org/jira/browse/CB-13514
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: cordova-android 6.3.0
>Reporter: Ibrahim M. Ghazal
> Labels: reproduced, triaged
>
> Adding {{}} to config.xml is removing some XML elements added by
> plugins. For example, {{cordova-plugin-file-opener2}} adds a {{}}
> element to AndroidManifest.xml. If I add an {{}} to config.xml
> that modifies AndroidManifest.xml, the {{}} element is removed on
> {{cordova (prepare|build|run) android}}
> To reproduce, create a cordova project with the following two files:
> package.json
> {code}
> {
> "name": "com.example.test",
> "displayName": "Test",
> "version": "1.0.0",
> "dependencies": {
> "cordova-android": "6.3.0",
> "cordova-plugin-file-opener2": "2.0.19"
> },
> "cordova": {
> "platforms": [
> "android"
> ],
> "plugins": {
> "cordova-plugin-file-opener2": {}
> }
> }
> }
> {code}
> config.xml
> {code}
>
> xmlns="http://www.w3.org/ns/widgets;
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> Test
>
>
> target="/manifest/application"
> xmlns:android="http://schemas.android.com/apk/res/android;>
>
>
>
>
>
>
> {code}
> Then run:
> $ npm install && cordova platform add android@6.3.0 --nosave
> [output omitted]
> $ cat ./platforms/android/AndroidManifest.xml
> {code}
>
> android:versionName="1.0.0" package="com.example.test"
> xmlns:android="http://schemas.android.com/apk/res/android;>
> android:normalScreens="true" android:resizeable="true"
> android:smallScreens="true" android:xlargeScreens="true" />
>
> android:hardwareAccelerated="true" android:icon="@mipmap/icon"
> android:label="@string/app_name" android:supportsRtl="true">
> android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale"
> android:label="@string/activity_name" android:launchMode="singleTop"
> android:name="MainActivity"
> android:theme="@android:style/Theme.DeviceDefault.NoActionBar"
> android:windowSoftInputMode="adjustResize">
>
>
>
>
>
> android:exported="false" android:grantUriPermissions="true"
> android:name="io.github.pwlin.cordova.plugins.fileopener2.FileProvider">
> android:resource="@xml/opener_paths" />
>
>
>
> />
>
> {code}
> $ cordova run android
> Conflict found, edit-config changes from config.xml will overwrite plugin.xml
> changes
> [rest of output omitted]
> $ cat ./platforms/android/AndroidManifest.xml
> {code}
>
> android:versionName="1.0.0" package="com.example.test"
> xmlns:android="http://schemas.android.com/apk/res/android;>
> android:normalScreens="true" android:resizeable="true"
> android:smallScreens="true" android:xlargeScreens="true" />
>
> android:hardwareAccelerated="true" android:icon="@mipmap/icon"
> android:label="@string/app_name" android:supportsRtl="true">
> android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale"
> android:label="@string/activity_name" android:launchMode="singleTop"
> android:name="MainActivity"
> android:theme="@android:style/Theme.DeviceDefault.NoActionBar"
> android:windowSoftInputMode="adjustResize">
>
>
>
>
>
>
>
> />
>
> {code}
> Note the missing {{}} element after running {{cordova run android}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227070#comment-16227070
]
Audrey So commented on CB-13496:
Hi! Can you please provide steps so I can reproduce your issue? Also what
version of npm /node are you using? Thanks! (npm -v, node -v)
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Kenichi Naito
>Priority: Trivial
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13484) Allow removing a whole XML element using
[
https://issues.apache.org/jira/browse/CB-13484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So updated CB-13484:
---
Labels: new-feature (was: )
> Allow removing a whole XML element using
> --
>
> Key: CB-13484
> URL: https://issues.apache.org/jira/browse/CB-13484
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-common
>Affects Versions: 2.1.1
>Reporter: Ibrahim M. Ghazal
> Labels: new-feature
>
> Currently, {{}} can only *add* an XML element to a config file,
> but not *remove* an element. {{}} can remove attributes from an
> element, but not whole elements.
> I'd like the ability to remove elements by adding something to {{config.xml}}
> instead of writing a hook.
> This is useful because some plugins include extra permissions which are not
> always needed (For example, {{cordova-plugin-file}} adds the
> {{WRITE_EXTERNAL_STORAGE}} permission, but not all apps that include
> {{cordova-plugin-file}} will actually write outside their data directory).
> Example syntax:
> {code}
> xmlns:android="http://schemas.android.com/apk/res/android;>
> />
>
> {code}
> (Note the {{mode="remove"}}, the default if absent should be "add")
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[ https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So resolved CB-13483. Resolution: Not A Problem > cordova add platform ios adds cordova-ios@4.4.0 not latest > -- > > Key: CB-13483 > URL: https://issues.apache.org/jira/browse/CB-13483 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Affects Versions: 7.0.1 >Reporter: Austin France > > $ cordova platform add ios --save > Using cordova-fetch for ios@~4.4.0 > It does this even when the engine setting for ios in config.xml is set to > 4.5.1. > To get version 4.5.1 (which contains important fixes) I have to remember to > $ cordova platform add ios@4.5.1 --save -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13311) Statusbar does not overlay correctly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226868#comment-16226868 ] ASF GitHub Bot commented on CB-13311: - rlemm1991 commented on issue #87: CB-13311: (iOS) Statusbar does not overlay correctly on iPhone X URL: https://github.com/apache/cordova-plugin-statusbar/pull/87#issuecomment-340776861 Apologies for commenting, maybe in the wrong place to do this but following link though looking for answers with the status bar on Cordova & iPhone X leaving a white gap and came across this, I've tried using `corodva-plugin-ionic-webview` along side the `viewport-fit=cover`suggestion and still find this to be an issue with a white gap appearing between the status bar and content. if I'm in the wrong place I apologies. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Statusbar does not overlay correctly on iPhone X > > > Key: CB-13311 > URL: https://issues.apache.org/jira/browse/CB-13311 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-statusbar >Reporter: jcesarmobile >Assignee: jcesarmobile > > As statusbar plugin has the statusbar height hardcoded to 20 points, it > doesn't overlay correctly on the iPhone X simulator as it's statusbar height > is 44 points. > This happens when the viewport has viewport-fit=cover -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226808#comment-16226808 ] jerome edited comment on CB-12886 at 10/31/17 1:49 PM: --- Hi all, I am following this thread since several weeks but I still can't make it work on my side. +My config : + - Cordova 7.0.1 - Cordova iOS 4.5.2 - last version of Xcode When I use the "cordova-plugin-ios11-inset-statusbar", all seems OK on "older" iPhone form factors up to the iPhone 8 and 8 Plus (status bar ok, no white bars, no space in forms pages) but I can't have a full screen app on iPhone X, even if I use Launch Storyboard Images or viewport-fit. This is a screen on an iPhone 8, all is ok : !https://c1.staticflickr.com/5/4487/26287471709_0dd9e596de_c.jpg! On the iPhone X I have many issues. When I use Launch storyboard images, I have a strange bug on the splash screen, there is a white bar on the bottom for some seconds then the image is stretched to full screen. Is it normal ? iPhone X splash screen with white bar for a few seconds : !https://c1.staticflickr.com/5/4494/38032828592_1f2e4924b6_c.jpg! iPhone X stretched splash screen. !https://c1.staticflickr.com/5/4479/24211179268_6c64a21360_b.jpg! And after, the app Is not in full screen even if I set "viewport-fit= cover » in my meta. I try some changes in the CSS with the safe area but same issue. !https://c1.staticflickr.com/5/4490/38010757616_1089985a8e_c.jpg! I can't find a solution :'( Can anyone help me please ? I really need your help because I think Apple will reject my app if it's not compliant to the iPhone X ;) Here is the zip of my app. http://www.votreappli1.fr/jay/Sdis34/SDIS34_copie_2.zip Thx in advance ;) was (Author: jay34fr): Hi all, I am following this thread since several weeks but I still can't make it work on my side. +My config : + - Cordova 7.0.1 - Cordova iOS 4.5.2 - last version of Xcode When I use the "cordova-plugin-ios11-inset-statusbar", all seems OK on "older" iPhone form factors up to the iPhone 8 and 8 Plus (status bar ok, no white bars, no space in forms pages) but I can't have a full screen app on iPhone X, even if I use Launch Storyboard Images or viewport-fit. This is a screen on an iPhone 8, all is ok : !https://c1.staticflickr.com/5/4487/26287471709_0dd9e596de_c.jpg! On the iPhone X I have many issues. When I use Launch storyboard images, I have a strange bug on the splash screen, there is a white bar on the bottom for some seconds then the image is stretched to full screen. Is it normal ? iPhone X splash screen with white bar for a few seconds : !https://c1.staticflickr.com/5/4494/38032828592_1f2e4924b6_c.jpg! iPhone X stretched splash screen. !https://c1.staticflickr.com/5/4479/24211179268_6c64a21360_b.jpg! And after, the app Is not in full screen even if I set "viewport-fit= cover » in my meta. I try some changes in the CSS with the safe area but same issue. !https://c1.staticflickr.com/5/4490/38010757616_1089985a8e_c.jpg! I can't find a solution :'( Can anyone help me please ? I really need your help because I think Apple will reject my app if it not compliant to the iPhone X ;) Here is the zip of my app. http://www.votreappli1.fr/jay/Sdis34/SDIS34_copie_2.zip Thx in advance ;) > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226808#comment-16226808 ] jerome commented on CB-12886: - Hi all, I am following this thread since several weeks but I still can't make it work on my side. +My config : + - Cordova 7.0.1 - Cordova iOS 4.5.2 - last version of Xcode When I use the "cordova-plugin-ios11-inset-statusbar", all seems OK on "older" iPhone form factors up to the iPhone 8 and 8 Plus (status bar ok, no white bars, no space in forms pages) but I can't have a full screen app on iPhone X, even if I use Launch Storyboard Images or viewport-fit. This is a screen on an iPhone 8, all is ok : !https://c1.staticflickr.com/5/4487/26287471709_0dd9e596de_c.jpg! On the iPhone X I have many issues. When I use Launch storyboard images, I have a strange bug on the splash screen, there is a white bar on the bottom for some seconds then the image is stretched to full screen. Is it normal ? iPhone X splash screen with white bar for a few seconds : !https://c1.staticflickr.com/5/4494/38032828592_1f2e4924b6_c.jpg! iPhone X stretched splash screen. !https://c1.staticflickr.com/5/4479/24211179268_6c64a21360_b.jpg! And after, the app Is not in full screen even if I set "viewport-fit= cover » in my meta. I try some changes in the CSS with the safe area but same issue. !https://c1.staticflickr.com/5/4490/38010757616_1089985a8e_c.jpg! I can't find a solution :'( Can anyone help me please ? I really need your help because I think Apple will reject my app if it not compliant to the iPhone X ;) Here is the zip of my app. http://www.votreappli1.fr/jay/Sdis34/SDIS34_copie_2.zip Thx in advance ;) > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13514) in config.xml removes some XML elements added by plugins
[
https://issues.apache.org/jira/browse/CB-13514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ibrahim M. Ghazal updated CB-13514:
---
Description:
Adding {{}} to config.xml is removing some XML elements added by
plugins. For example, {{cordova-plugin-file-opener2}} adds a {{}}
element to AndroidManifest.xml. If I add an {{}} to config.xml
that modifies AndroidManifest.xml, the {{}} element is removed on
{{cordova (prepare|build|run) android}}
To reproduce, create a cordova project with the following two files:
package.json
{code}
{
"name": "com.example.test",
"displayName": "Test",
"version": "1.0.0",
"dependencies": {
"cordova-android": "6.3.0",
"cordova-plugin-file-opener2": "2.0.19"
},
"cordova": {
"platforms": [
"android"
],
"plugins": {
"cordova-plugin-file-opener2": {}
}
}
}
{code}
config.xml
{code}
http://www.w3.org/ns/widgets;
xmlns:cdv="http://cordova.apache.org/ns/1.0;>
Test
http://schemas.android.com/apk/res/android;>
{code}
Then run:
$ npm install && cordova platform add android@6.3.0 --nosave
[output omitted]
$ cat ./platforms/android/AndroidManifest.xml
{code}
http://schemas.android.com/apk/res/android;>
{code}
$ cordova run android
Conflict found, edit-config changes from config.xml will overwrite plugin.xml
changes
[rest of output omitted]
$ cat ./platforms/android/AndroidManifest.xml
{code}
http://schemas.android.com/apk/res/android;>
{code}
Note the missing {{}} element after running {{cordova run android}}
was:
Adding {{}} to config.xml is removing some XML elements added by
plugins. For example, {{cordova-plugin-file-opener2}} adds a {{}}
element to AndroidManifest.xml. If I add an {{}} to config.xml
that modifies AndroidManifest.xml, the {{}} element is removed on
{{cordova (prepare|build|run) android}}
To reproduce, create a cordova project with the following two files:
package.json
{code}
{
"name": "com.example.test",
"displayName": "Test",
"version": "1.0.0",
"dependencies": {
"cordova-android": "6.3.0",
"cordova-plugin-file-opener2": "2.0.19"
},
"cordova": {
"platforms": [
"android"
],
"plugins": {
"cordova-plugin-file-opener2": {}
}
}
}
{code}
config.xml
{code}
http://www.w3.org/ns/widgets;
xmlns:cdv="http://cordova.apache.org/ns/1.0;>
Test
http://schemas.android.com/apk/res/android;>
{code}
Then run:
$ npm install && cordova platform add android@6.3.0 --nosave
[output omitted]
$ cat .\platforms\android\AndroidManifest.xml
{code}
http://schemas.android.com/apk/res/android;>
{code}
$ cordova run android
Conflict found, edit-config changes from config.xml will overwrite plugin.xml
changes
[rest of output omitted]
$ cat .\platforms\android\AndroidManifest.xml
{code}
http://schemas.android.com/apk/res/android;>
{code}
Note the missing {{}} element after running {{cordova run android}}
> in config.xml removes some XML elements added by plugins
> --
>
> Key: CB-13514
> URL: https://issues.apache.org/jira/browse/CB-13514
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: cordova-android 6.3.0
>Reporter: Ibrahim M. Ghazal
>
> Adding {{}} to config.xml is removing some XML elements added by
> plugins. For example, {{cordova-plugin-file-opener2}} adds a {{}}
> element to AndroidManifest.xml. If I add an {{}} to config.xml
> that modifies AndroidManifest.xml, the {{}} element is removed on
> {{cordova (prepare|build|run) android}}
> To reproduce, create a cordova project with the following two files:
> package.json
> {code}
> {
> "name": "com.example.test",
> "displayName": "Test",
> "version": "1.0.0",
> "dependencies": {
> "cordova-android": "6.3.0",
> "cordova-plugin-file-opener2": "2.0.19"
> },
> "cordova": {
> "platforms": [
> "android"
> ],
> "plugins": {
> "cordova-plugin-file-opener2": {}
> }
> }
> }
> {code}
> config.xml
> {code}
>
> xmlns="http://www.w3.org/ns/widgets;
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> Test
>
>
> target="/manifest/application"
>
[jira] [Created] (CB-13513) Fastlane unable to disable automatic signing
Paul Robinson created CB-13513: -- Summary: Fastlane unable to disable automatic signing Key: CB-13513 URL: https://issues.apache.org/jira/browse/CB-13513 Project: Apache Cordova Issue Type: Bug Components: cordova-ios Affects Versions: cordova-ios 4.5.0 Reporter: Paul Robinson Assignee: Suraj Pindoria Priority: Blocker Running `disable_automatic_code_signing` command in fastlane fails and throw an error that the ios project is too old. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13514) in config.xml removes some XML elements added by plugins
Ibrahim M. Ghazal created CB-13514:
--
Summary: in config.xml removes some XML elements
added by plugins
Key: CB-13514
URL: https://issues.apache.org/jira/browse/CB-13514
Project: Apache Cordova
Issue Type: Bug
Components: cordova-common
Affects Versions: 2.1.0
Environment: cordova-android 6.3.0
Reporter: Ibrahim M. Ghazal
Adding {{}} to config.xml is removing some XML elements added by
plugins. For example, {{cordova-plugin-file-opener2}} adds a {{}}
element to AndroidManifest.xml. If I add an {{}} to config.xml
that modifies AndroidManifest.xml, the {{}} element is removed on
{{cordova (prepare|build|run) android}}
To reproduce, create a cordova project with the following two files:
package.json
{code}
{
"name": "com.example.test",
"displayName": "Test",
"version": "1.0.0",
"dependencies": {
"cordova-android": "6.3.0",
"cordova-plugin-file-opener2": "2.0.19"
},
"cordova": {
"platforms": [
"android"
],
"plugins": {
"cordova-plugin-file-opener2": {}
}
}
}
{code}
config.xml
{code}
http://www.w3.org/ns/widgets;
xmlns:cdv="http://cordova.apache.org/ns/1.0;>
Test
http://schemas.android.com/apk/res/android;>
{code}
Then run:
$ npm install && cordova platform add android@6.3.0 --nosave
[output omitted]
$ cat .\platforms\android\AndroidManifest.xml
{code}
http://schemas.android.com/apk/res/android;>
{code}
$ cordova run android
Conflict found, edit-config changes from config.xml will overwrite plugin.xml
changes
[rest of output omitted]
$ cat .\platforms\android\AndroidManifest.xml
{code}
http://schemas.android.com/apk/res/android;>
{code}
Note the missing {{}} element after running {{cordova run android}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13481) file:///android_asset/ shouldn't require READ_EXTERNAL_STORAGE permission
[
https://issues.apache.org/jira/browse/CB-13481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226565#comment-16226565
]
ASF GitHub Bot commented on CB-13481:
-
imgx64 opened a new pull request #221: CB-13481: (android) Don't ask for
permission to read file:///android_asset/
URL: https://github.com/apache/cordova-plugin-file/pull/221
### Platforms affected
Android 6+
### What does this PR do?
Allow reading from `cordova.file.applicationDirectory`
(`file:///android_asset/`) without asking the user for permission.
### What testing has been done on this change?
Modified the code and ran it on an Android 6.0 device (See sample code in
the JIRA bug).
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> file:///android_asset/ shouldn't require READ_EXTERNAL_STORAGE permission
> -
>
> Key: CB-13481
> URL: https://issues.apache.org/jira/browse/CB-13481
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
>Affects Versions: Master
> Environment: cordova-android 6.3.0.
> Running on Android 6.0.
>Reporter: Ibrahim M. Ghazal
>
> On Android 6+, trying to read a file from
> {{cordova.file.applicationDirectory}} ({{file:///android_asset/}}) opens the
> runtime permissions window and asks the user "Allow AppName to access photos,
> media, and files on your device?". This is obviously incorrect as the app
> always has the permission to read its own assets.
> Sample code that shows the issue:
> {code}
> function log(a) {console.log(a);};
> resolveLocalFileSystemURL(cordova.file.applicationDirectory,
> function(applicationDirectory) {
> applicationDirectory.getFile('www/index.js', {}, log, log);
> }, log);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13481) file:///android_asset/ shouldn't require READ_EXTERNAL_STORAGE permission
[
https://issues.apache.org/jira/browse/CB-13481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226564#comment-16226564
]
ASF GitHub Bot commented on CB-13481:
-
imgx64 closed pull request #221: CB-13481: (android) Don't ask for permission
to read file:///android_asset/
URL: https://github.com/apache/cordova-plugin-file/pull/221
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/android/FileUtils.java b/src/android/FileUtils.java
index 2b88d52..1d6e61f 100644
--- a/src/android/FileUtils.java
+++ b/src/android/FileUtils.java
@@ -570,6 +570,7 @@ private boolean hasWritePermission() {
private boolean needPermission(String nativeURL, int permissionType)
throws JSONException {
JSONObject j = requestAllPaths();
ArrayList allowedStorageDirectories = new ArrayList();
+allowedStorageDirectories.add(j.getString("applicationDirectory"));
allowedStorageDirectories.add(j.getString("applicationStorageDirectory"));
if(j.has("externalApplicationStorageDirectory")) {
allowedStorageDirectories.add(j.getString("externalApplicationStorageDirectory"));
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> file:///android_asset/ shouldn't require READ_EXTERNAL_STORAGE permission
> -
>
> Key: CB-13481
> URL: https://issues.apache.org/jira/browse/CB-13481
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
>Affects Versions: Master
> Environment: cordova-android 6.3.0.
> Running on Android 6.0.
>Reporter: Ibrahim M. Ghazal
>
> On Android 6+, trying to read a file from
> {{cordova.file.applicationDirectory}} ({{file:///android_asset/}}) opens the
> runtime permissions window and asks the user "Allow AppName to access photos,
> media, and files on your device?". This is obviously incorrect as the app
> always has the permission to read its own assets.
> Sample code that shows the issue:
> {code}
> function log(a) {console.log(a);};
> resolveLocalFileSystemURL(cordova.file.applicationDirectory,
> function(applicationDirectory) {
> applicationDirectory.getFile('www/index.js', {}, log, log);
> }, log);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13512) hide method with inappbrowser didn't work in ios phonegap application
Hamza Belheni created CB-13512: -- Summary: hide method with inappbrowser didn't work in ios phonegap application Key: CB-13512 URL: https://issues.apache.org/jira/browse/CB-13512 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-inappbrowser Affects Versions: cordova@7.0.0 Reporter: Hamza Belheni Fix For: Master, cordova@7.0.0 I'am developing a phonegap application which is based on webview concept and i want to show and hide the window according to some uses of the client.. hide() method didn't work on ios device despite the documentation of inappbrowser plugin is very clear and simple. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
