[jira] [Commented] (CB-13503) Problems with using plugins from local file system
[
https://issues.apache.org/jira/browse/CB-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245319#comment-16245319
]
Michael commented on CB-13503:
--
I'm also seeing this issue in 7.1.0.
Thanks for the suggestion regarding the script. I sure hope they can fix this
one soon!
> Problems with using plugins from local file system
> --
>
> Key: CB-13503
> URL: https://issues.apache.org/jira/browse/CB-13503
> Project: Apache Cordova
> Issue Type: Bug
> Components: AllPlatforms, cordova-fetch
>Affects Versions: cordova@7.1.0
>Reporter: Mark Veenstra
>Priority: Blocker
>
> I am struggling to get up and running with {{cordova@7.1.0}} sometime now.
> Maybe I am doing something wrong here but I can't figure it out. It seems to
> me something is going wrong with locally defined plugins that needs to be
> installed and the way it is saved into {{package.json}}.
> So to get upgraded I first installed the latest version {{npm install -g
> cordova@7.1.0}}. Then I did a {{cordova prepare}}.
> This {{prepare}} failed, after [some digging and
> trying|https://github.com/dpa99c/cordova-diagnostic-plugin/issues/245] it
> seemed that some locally plugins that needs to be installed into the project
> are interrupting other plugins. So I needed to disable the {{cordova-fetch}}.
> I set this globally with {{cordova config set fetch false}}.
> After this config change the {{codova prepare}} command went all fine. So I
> thought this is it.
> But when I tried to let my project be build by my CI server it failed on
> installating NPM packages.
> Because a {{npm install}} command will install the dependencies defined in
> {{package.json}} it will install the cordova plugins also. But in the
> beginning my plugins are in there like this:
> {code}
> {
> "name": "myApp",
> "version": "1.0.0",
> "description": "myApp description",
> "dependencies": {
> "cordova-android": "6.3.0",
> "cordova-browser": "5.0.1",
> "cordova-ios": "4.5.2",
> "cordova-plugin-myplugin": "resources/cordova-plugin-myplugin",
> "cordova-plugin-myplugin-locker":
> "resources/cordova-plugin-myplugin-locker"
> },
> "devDependencies": {
> },
> "scripts": {
> },
> "cordova": {
> "platforms": [
> "browser",
> "android",
> "ios"
> ],
> "plugins": {
> "cordova-plugin-myplugin": {},
> "cordova-plugin-myplugin-locker": {}
> }
> }
> }
> {code}
> With above {{npm install}} fails and tries to get the dependecies from git,
> which is incorrect. So I search the {{package.json}} definition and they say
> I should put {{file:}} in front of it, like this:
> {code}
> {
> "name": "myApp",
> "version": "1.0.0",
> "description": "myApp description",
> "dependencies": {
> "cordova-android": "6.3.0",
> "cordova-browser": "5.0.1",
> "cordova-ios": "4.5.2",
> "cordova-plugin-myplugin": "file:resources/cordova-plugin-myplugin",
> "cordova-plugin-myplugin-locker":
> "file:resources/cordova-plugin-myplugin-locker"
> },
> "devDependencies": {
> },
> "scripts": {
> },
> "cordova": {
> "platforms": [
> "browser",
> "android",
> "ios"
> ],
> "plugins": {
> "cordova-plugin-myplugin": {},
> "cordova-plugin-myplugin-locker": {}
> }
> }
> }
> {code}
> Now NPM finds the dependecies OK, but now when I do a {{cordova prepare}}
> again it throws an error that the plugin can't be installed from
> {{file:resources/cordova-plugin-myplugin}}.
> So I get stuck into different needs for different tools. Any ideas?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13507) git+https or git+ssh fails when trying to install
[ https://issues.apache.org/jira/browse/CB-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245314#comment-16245314 ] Michael commented on CB-13507: -- I'm still seeing this issue in 7.1.0. Any suggestions or workarounds? > git+https or git+ssh fails when trying to install > - > > Key: CB-13507 > URL: https://issues.apache.org/jira/browse/CB-13507 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlatforms >Affects Versions: 7.0.2 > Environment: I am selecting 7.0.2 since it's the closest but I am > running cordova 7.1.0 > OS: Mac OS X Sierra. > Although I don't think it has anything to do with cordova-ios and > cordova-android, my platform versions are: > - android 6.3.0 > - ios 4.5.2 >Reporter: Pablo Caselas > Fix For: 7.0.2 > > > I start with adding plugin dependencies with https://.. on package.json > (no plugin references on config.xml) and no platforms or plugins installed > then I run "cordova platform ios". > It installs the plugins without any problem, but changes config.xml and > package.json plugin references from https to git+https, and ssh to git+ssh. > Failed to restore plugin "cordova-plugin-document-viewer" from config.xml. > You might need to try adding it again. Error: Failed to fetch plugin > git+https://github.com/kas84/cordova-plugin-document-viewer.git via registry -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13051) Add default encoding type for getPicture
[ https://issues.apache.org/jira/browse/CB-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245253#comment-16245253 ] Darren Croft commented on CB-13051: --- Apparently if I don't make any changes to the image I will get the original image type, but I am fixing orientation and down scaling and it is converting png to jpg and losing transparency. > Add default encoding type for getPicture > > > Key: CB-13051 > URL: https://issues.apache.org/jira/browse/CB-13051 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-camera >Affects Versions: cordova@7.0.0 >Reporter: Darren Croft > > getPicture with a source of PHOTOLIBRARY can now access download and other > directories that may have pictures with various formats. > Currently the encoding option only has two options. I would like another > option of NOCHANGE or DEFAULT added so that the format won't be changed. > My problem right now is that PNG files converted to JPEG lose transparency. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13535) Add app events for connecting and disconnecting calls
[ https://issues.apache.org/jira/browse/CB-13535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245182#comment-16245182 ] ASF GitHub Bot commented on CB-13535: - shazron commented on issue #348: CB-13535: (ios) Add CallStart/CallEnd events to fire with Resign/Active events URL: https://github.com/apache/cordova-ios/pull/348#issuecomment-343043491 This shouldn't be in the platform but in a plugin, since adding new platform features should either be: 1. cross-platform (all relevant platforms support it, and this has to be decided by consensus on the dev list) 2. part of a standard spec, i.e w3c (but still decided by point 1 above). Not all apps need this functionality thus it should be optional in a plugin, and this can be achieved in a plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add app events for connecting and disconnecting calls > - > > Key: CB-13535 > URL: https://issues.apache.org/jira/browse/CB-13535 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Spencer Jameson >Assignee: Suraj Pindoria > > The app resign/active events that Cordova fires trigger for multiple phone > events. Example: connecting a call and locking the screen app both trigger > the *resign* event, while disconnecting a call and unlocking the screen > trigger the *active* event. It would be convenient to have distinct events > that fire for calls connecting and ending to tie into, aside from the generic > *active* and *resign* events. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244925#comment-16244925 ] ASF GitHub Bot commented on CB-13396: - Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342994247 They fixed it: https://github.com/apache/cordova-ios/pull/345 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13505) Update LaunchScreen story board constrains
[ https://issues.apache.org/jira/browse/CB-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244924#comment-16244924 ] ASF GitHub Bot commented on CB-13505: - Lazza commented on issue #345: CB-13505: (ios) adjust constraint for launchscreen storyboard URL: https://github.com/apache/cordova-ios/pull/345#issuecomment-342994082 Coincidentally, an issue with a similar content was already opened here: https://issues.apache.org/jira/browse/CB-13411 Thanks for contributing the patch! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update LaunchScreen story board constrains > -- > > Key: CB-13505 > URL: https://issues.apache.org/jira/browse/CB-13505 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Mike Hartington >Assignee: Suraj Pindoria > Attachments: jump.gif > > > LaunchScreen storyboard constraints were never updated for ios11/iphoneX. > This can cause the splashscreen to jump during startup. Sending a patch for > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13411) The launch screen storyboard (splash screen) has a white safe area on the bottom ONLY on iPhone X, iOS 11
[
https://issues.apache.org/jira/browse/CB-13411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suraj Pindoria closed CB-13411.
---
Resolution: Fixed
This was fixed with CB-13505
> The launch screen storyboard (splash screen) has a white safe area on the
> bottom ONLY on iPhone X, iOS 11
> -
>
> Key: CB-13411
> URL: https://issues.apache.org/jira/browse/CB-13411
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: {{cordova-ios}} 4.5.0 or 4.5.1 and
> {{cordova-plugin-splashscreen}}
>Reporter: Andrea Lazzarotto
>Assignee: Suraj Pindoria
>Priority: Minor
> Labels: easyfix
> Attachments: screenshot-1.png
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The splash screen used by {{cordova-plugin-splashscreen}} uses the
> {{CDVLaunchScreen.storyboard}} file from {{cordova-ios}}. On the iPhone X
> emulator with iOS11, this shows a white "safe area inset" *only on the bottom
> margin* (not on the top).
> The splash screen should be immersive both on top and on the bottom,
> therefore the storyboard should be fixed. I use this simple replacement in a
> hook to patch {{cordova-ios}} after {{cordova prepare}}:
> {code}
> NAME="$(find platforms/ios/ -name 'CDVLaunchScreen.storyboard')"
> sed -i '' 's_secondItem="xb3-aO-Qok"
> secondAttribute="top"_secondItem="Ze5-6b-2t3" secondAttribute="bottom"_g'
> "$NAME"
> {code}
> Basically one constraint on the storyboard needs to be updated. It should be
> trivial to fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13505) Update LaunchScreen story board constrains
[ https://issues.apache.org/jira/browse/CB-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Pindoria closed CB-13505. --- Resolution: Fixed Merged this in, thanks! > Update LaunchScreen story board constrains > -- > > Key: CB-13505 > URL: https://issues.apache.org/jira/browse/CB-13505 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Mike Hartington >Assignee: Suraj Pindoria > Attachments: jump.gif > > > LaunchScreen storyboard constraints were never updated for ios11/iphoneX. > This can cause the splashscreen to jump during startup. Sending a patch for > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13505) Update LaunchScreen story board constrains
[ https://issues.apache.org/jira/browse/CB-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244917#comment-16244917 ] ASF GitHub Bot commented on CB-13505: - surajpindoria closed pull request #345: CB-13505: (ios) adjust constraint for launchscreen storyboard URL: https://github.com/apache/cordova-ios/pull/345 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/bin/templates/project/__PROJECT_NAME__/CDVLaunchScreen.storyboard b/bin/templates/project/__PROJECT_NAME__/CDVLaunchScreen.storyboard index 51cdcf6d2..ffc1d1d65 100644 --- a/bin/templates/project/__PROJECT_NAME__/CDVLaunchScreen.storyboard +++ b/bin/templates/project/__PROJECT_NAME__/CDVLaunchScreen.storyboard @@ -43,7 +43,7 @@ - + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update LaunchScreen story board constrains > -- > > Key: CB-13505 > URL: https://issues.apache.org/jira/browse/CB-13505 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Mike Hartington >Assignee: Suraj Pindoria > Attachments: jump.gif > > > LaunchScreen storyboard constraints were never updated for ios11/iphoneX. > This can cause the splashscreen to jump during startup. Sending a patch for > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13505) Update LaunchScreen story board constrains
[ https://issues.apache.org/jira/browse/CB-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244918#comment-16244918 ] ASF subversion and git services commented on CB-13505: -- Commit 93867bb13b6c41f1e4f1ea5130794749c46f8d22 in cordova-ios's branch refs/heads/master from [~mhartington] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=93867bb ] CB-13505: adjust storyboard constraints > Update LaunchScreen story board constrains > -- > > Key: CB-13505 > URL: https://issues.apache.org/jira/browse/CB-13505 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Mike Hartington >Assignee: Suraj Pindoria > Attachments: jump.gif > > > LaunchScreen storyboard constraints were never updated for ios11/iphoneX. > This can cause the splashscreen to jump during startup. Sending a patch for > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13505) Update LaunchScreen story board constrains
[ https://issues.apache.org/jira/browse/CB-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244919#comment-16244919 ] ASF subversion and git services commented on CB-13505: -- Commit 37b91c2a2ae0b196510ecd2a67c44b1b2e99c6ca in cordova-ios's branch refs/heads/master from [~mhartington] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=37b91c2 ] CB-13505: (ios) adjust storyboard constraints > Update LaunchScreen story board constrains > -- > > Key: CB-13505 > URL: https://issues.apache.org/jira/browse/CB-13505 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Mike Hartington >Assignee: Suraj Pindoria > Attachments: jump.gif > > > LaunchScreen storyboard constraints were never updated for ios11/iphoneX. > This can cause the splashscreen to jump during startup. Sending a patch for > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13254) node 4 with cordova-cli causes platform add issues
[
https://issues.apache.org/jira/browse/CB-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244878#comment-16244878
]
jcesarmobile commented on CB-13254:
---
I think we should either fix it or deprecate the support for node 4. We
announced that we will drop support the 1st of April. I think node releases are
being very fast, we should start dropping support faster too.
> node 4 with cordova-cli causes platform add issues
> --
>
> Key: CB-13254
> URL: https://issues.apache.org/jira/browse/CB-13254
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Reporter: Shazron Abdullah
> Labels: tools-next
>
> From [~jcesarmobile] in dev@:
> {code}
> I'm trying to do cordova platform add
> https://github.com/apache/cordova-ios#4.5.0 and getting this error
> Using CLI 7.0.1:
> cordova platform add https://github.com/apache/cordova-ios#4.5.0
> Using cordova-fetch for https://github.com/apache/cordova-ios#4.5.0
> Adding ios project...
> Using this version of Cordova with older version of cordova-ios is
> deprecated. Upgrade to cordova-ios@4.0.0 or newer.
> Error: Your ios platform does not have Api.js
> Using nightly CLI:
> cordova platform add https://github.com/apache/cordova-ios#4.5.0
> Warning: using prerelease version 7.0.2-nightly.2017.9.7.596da5df
> (cordova-lib@7.0.2-nightly.2017.9.7.6f5be6a7)
> Using cordova-fetch for https://github.com/apache/cordova-ios#4.5.0
> Adding ios project...
> Unable to load PlatformApi from platform. Error: Cannot find module 'unorm'
> Error: Uncaught, unspecified "error" event. (The platform "ios" does not
> appear to be a valid cordova platform. It is missing API.js. ios not
> supported.)
> node -v
> v4.4.7
> npm -v
> 2.15.8
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13552) iOS Cordova Build overwriting Bundle Display Name
[ https://issues.apache.org/jira/browse/CB-13552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244793#comment-16244793 ] Suraj Pindoria commented on CB-13552: - To me this sounds like it is behaving correctly, it may have been a bug previously. But you should be making any changes to your project from config.xml and the www directory. Is there a particular reason for updating the display name inside Xcode? > iOS Cordova Build overwriting Bundle Display Name > - > > Key: CB-13552 > URL: https://issues.apache.org/jira/browse/CB-13552 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 > Environment: OSX 10.12.6; Cordova 7.1.0 >Reporter: Adam De Lay >Assignee: Suraj Pindoria > > I change my Bundle Display Name in my plist file (or in Xcode) and then I go > to use cordova to build my application and when I do, the Bundle Display Name > is being changed to the name tag from the config.xml. This is something new > that I noticed in 4.5.1. I've built hundreds of apps before and never had > this problem. I tried upgrading to 4.5.3 to see if it would fix the issue > and it doesn't. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244755#comment-16244755 ] ASF GitHub Bot commented on CB-13396: - gdvsbp commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342958327 @myrsk Deployments to actual devices will be affected too. Until CB-13411 or CB-13396 get resolved it looks like that hook is the only option we've got for fixing things. Hopefully some action happens with those soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244721#comment-16244721 ] ASF GitHub Bot commented on CB-13396: - gdvsbp commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342958327 @myrsk Deployments to actual devices will be affected too. Until CB-13411 or CB-13396 get resolved it looks like that hook is the only option we've got for fixing things. Hopefully some action happens with those soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13532) Cordova fails to find platform/plugin versions in package.json devDependencies
[
https://issues.apache.org/jira/browse/CB-13532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244644#comment-16244644
]
ASF GitHub Bot commented on CB-13532:
-
dpogue commented on issue #607: :CB-13532 : updated to include a check for
pkgJson devDependencies
URL: https://github.com/apache/cordova-lib/pull/607#issuecomment-342942707
:+1:
Just to confirm the intention: Cordova will prefer versions listed in
`dependencies` over `devDependencies`? That makes sense to me.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova fails to find platform/plugin versions in package.json devDependencies
> --
>
> Key: CB-13532
> URL: https://issues.apache.org/jira/browse/CB-13532
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Reporter: Darryl Pogue
> Labels: tools-next
>
> Cordova only looks at the {{dependencies}} section of package.json, and
> ignores anything specified in {{devDependencies}}. This results in the
> default pinned versions for platforms/plugins being used.
> Code in question:
> https://github.com/apache/cordova-lib/blob/da8ebf6cb81dd84c22e24fdf0baff9837a544b2d/src/cordova/platform/addHelper.js#L109-L113
> This is wrong because Cordova (and its related bits) is not a dependency of
> my application code, it is a build tool that belongs in devDependencies.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13555) (ios) Present notification view controller by inappbrowser view controller
[
https://issues.apache.org/jira/browse/CB-13555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244606#comment-16244606
]
ASF GitHub Bot commented on CB-13555:
-
jonathanli2 opened a new pull request #98: CB-13555 (ios) Present notification
view controller by inappbrowser view controller
URL: https://github.com/apache/cordova-plugin-dialogs/pull/98
…resented
### Platforms affected
iOS
### What does this PR do?
Fix the issue of not showing the dialog screen if inappbrowser screen is
presented
[https://issues.apache.org/jira/browse/CB-13555](https://issues.apache.org/jira/browse/CB-13555)
### What testing has been done on this change?
Create a cordova ios project with UIWebView or WKWebView, and call the below
method. The dialog view does not show to user.
function confirm(){
var win = window.open( "https://www.google.com;, "_blank" );
win.addEventListener( "loadstop", function() {
setTimeout(function() {
function onConfirm(buttonIndex) {
console.log('You selected button ' + buttonIndex);
}
navigator.notification.confirm(
'You are the winner!', // message
onConfirm,// callback to invoke with index of button
pressed
'Game Over', // title
['Restart','Exit'] // buttonLabels
);
}, 1000 );
});
}
### Checklist
- [Y] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [Y] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [N] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> (ios) Present notification view controller by inappbrowser view controller
> --
>
> Key: CB-13555
> URL: https://issues.apache.org/jira/browse/CB-13555
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-dialogs
>Affects Versions: cordova-ios 4.5.0
> Environment: IOS 10 and 11
>Reporter: Jonathan Li
> Labels: dialog, inappbrowser
> Fix For: Master
>
>
> When inappbrowser window is shown, if main uiwebview or wkwebview calls
> cordova Dialog plugin method to show the dialog view, the dialog should show
> to user on top of the inappbrowser view controller.
> However, currently the dialog view is shown behind the inappbrowser view, so
> user cannot see it or click button on the dialog
> An similar issue was reported for barcode scanner plugin at
> https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/570
> The issue can be repeated with the below method
> function confirm(){
> var win = window.open( "https://www.google.com;, "_blank" );
> win.addEventListener( "loadstop", function() {
> setTimeout(function() {
> function onConfirm(buttonIndex) {
> console.log('You selected button ' + buttonIndex);
> }
>
> navigator.notification.confirm(
> 'You are the winner!', // message
> onConfirm,// callback to invoke with index of button
> pressed
> 'Game Over', // title
> ['Restart','Exit'] // buttonLabels
> );
> }, 1000 );
> });
> }
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13555) (ios) Present notification view controller by inappbrowser view controller
Jonathan Li created CB-13555:
Summary: (ios) Present notification view controller by
inappbrowser view controller
Key: CB-13555
URL: https://issues.apache.org/jira/browse/CB-13555
Project: Apache Cordova
Issue Type: Bug
Components: cordova-plugin-dialogs
Affects Versions: cordova-ios 4.5.0
Environment: IOS 10 and 11
Reporter: Jonathan Li
Fix For: Master
When inappbrowser window is shown, if main uiwebview or wkwebview calls cordova
Dialog plugin method to show the dialog view, the dialog should show to user on
top of the inappbrowser view controller.
However, currently the dialog view is shown behind the inappbrowser view, so
user cannot see it or click button on the dialog
An similar issue was reported for barcode scanner plugin at
https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/570
The issue can be repeated with the below method
function confirm(){
var win = window.open( "https://www.google.com;, "_blank" );
win.addEventListener( "loadstop", function() {
setTimeout(function() {
function onConfirm(buttonIndex) {
console.log('You selected button ' + buttonIndex);
}
navigator.notification.confirm(
'You are the winner!', // message
onConfirm,// callback to invoke with index of button
pressed
'Game Over', // title
['Restart','Exit'] // buttonLabels
);
}, 1000 );
});
}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13532) Cordova fails to find platform/plugin versions in package.json devDependencies
[
https://issues.apache.org/jira/browse/CB-13532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244575#comment-16244575
]
ASF GitHub Bot commented on CB-13532:
-
audreyso opened a new pull request #607: :CB-13532 : updated to include a check
for pkgJson devDependencies
URL: https://github.com/apache/cordova-lib/pull/607
### Platforms affected
### What does this PR do?
include a check for pkgJson devDependencies
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova fails to find platform/plugin versions in package.json devDependencies
> --
>
> Key: CB-13532
> URL: https://issues.apache.org/jira/browse/CB-13532
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Reporter: Darryl Pogue
> Labels: tools-next
>
> Cordova only looks at the {{dependencies}} section of package.json, and
> ignores anything specified in {{devDependencies}}. This results in the
> default pinned versions for platforms/plugins being used.
> Code in question:
> https://github.com/apache/cordova-lib/blob/da8ebf6cb81dd84c22e24fdf0baff9837a544b2d/src/cordova/platform/addHelper.js#L109-L113
> This is wrong because Cordova (and its related bits) is not a dependency of
> my application code, it is a build tool that belongs in devDependencies.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244544#comment-16244544 ] ASF GitHub Bot commented on CB-13396: - myrsk commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342922918 Tried it on a real iphonex device too, still jumps, and shows that little white area to begin with, and then goes to the real splash page ... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13554) Unable to launch basic auth popup on the inappbrowser
[
https://issues.apache.org/jira/browse/CB-13554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
vikram pottam updated CB-13554:
---
Description:
Unable to launch basic auth popup on the inappbrowser
I am trying to launch a url from using cordova inapp browser , every enterprise
url of my company launches a popup (looks like a basic auth one) I cant see
that popup ,
also tried with auth plugin but it did not work as well
this is the error i am getting:
017-11-08 11:33:44.024401-0600 mytimeapp[2514:8278454] AuthDialog:
willSendRequestForAuthenticationChallenge : Host:"", Server:https,
Auth-Scheme:NSURLAuthenticationMethodNTLM, Realm:sts.cerner.com, Port:443,
Proxy:NO, Proxy-Type:(null)
2017-11-08 11:33:44.042277-0600 mytimeapp[2514:8278454] AuthDialog:
willSendRequestForAuthenticationChallenge : Host:"", Server:https,
Auth-Scheme:NSURLAuthenticationMethodServerTrust, Realm:(null), Port:443,
Proxy:NO, Proxy-Type:(null)
2017-11-08 11:33:44.093841-0600 mytimeapp[2514:8281203] CredStore -
performQuery - Error copying matching creds. Error=-25300, query={
class = inet;
"m_Limit" = "m_LimitAll";
ptcl = htps;
"r_Attributes" = 1;
sdmn = "";
srvr = "";
sync = syna;
}
2017-11-08 11:33:44.095529-0600 mytimeapp[2514:8281203] CredStore -
updateOrAddCredential - Error update cred. Error=-25300, query={
acct = ;
atyp = dflt;
class = inet;
port = 443;
ptcl = htps;
sdmn = "";
srvr = "";
}, attrs={
acct = ;
icmt = default;
labl = ")";
"v_Data" = <4d61726b 69764031 393838>;
}
2017-11-08 11:33:44.096822-0600 mytimeapp[2514:8281203] CredStore -
updateOrAddCredential - Error add cred. Error=-50, attrs={
acct = ;
atyp = dflt;
class = inet;
icmt = default;
labl = ")";;
path = "";
port = 443;
ptcl = htps;
sdmn = "";
srvr = "";
"v_Data" = <4d61726b 69764031 393838>;
}
was:Unable to launch basic auth popup on the inappbrowser
> Unable to launch basic auth popup on the inappbrowser
> -
>
> Key: CB-13554
> URL: https://issues.apache.org/jira/browse/CB-13554
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser
>Affects Versions: cordova@7.0.0
>Reporter: vikram pottam
>Assignee: Jesse MacFadyen
> Fix For: Master
>
>
> Unable to launch basic auth popup on the inappbrowser
> I am trying to launch a url from using cordova inapp browser , every
> enterprise url of my company launches a popup (looks like a basic auth one)
> I cant see that popup ,
> also tried with auth plugin but it did not work as well
> this is the error i am getting:
> 017-11-08 11:33:44.024401-0600 mytimeapp[2514:8278454] AuthDialog:
> willSendRequestForAuthenticationChallenge 0x60811b80>: Host:"", Server:https,
> Auth-Scheme:NSURLAuthenticationMethodNTLM, Realm:sts.cerner.com, Port:443,
> Proxy:NO, Proxy-Type:(null)
> 2017-11-08 11:33:44.042277-0600 mytimeapp[2514:8278454] AuthDialog:
> willSendRequestForAuthenticationChallenge 0x60411310>: Host:"", Server:https,
> Auth-Scheme:NSURLAuthenticationMethodServerTrust, Realm:(null), Port:443,
> Proxy:NO, Proxy-Type:(null)
> 2017-11-08 11:33:44.093841-0600 mytimeapp[2514:8281203] CredStore -
> performQuery - Error copying matching creds. Error=-25300, query={
> class = inet;
> "m_Limit" = "m_LimitAll";
> ptcl = htps;
> "r_Attributes" = 1;
> sdmn = "";
> srvr = "";
> sync = syna;
> }
> 2017-11-08 11:33:44.095529-0600 mytimeapp[2514:8281203] CredStore -
> updateOrAddCredential - Error update cred. Error=-25300, query={
> acct = ;
> atyp = dflt;
> class = inet;
> port = 443;
> ptcl = htps;
> sdmn = "";
> srvr = "";
> }, attrs={
> acct = ;
> icmt = default;
> labl = ")";
> "v_Data" = <4d61726b 69764031 393838>;
> }
> 2017-11-08 11:33:44.096822-0600 mytimeapp[2514:8281203] CredStore -
> updateOrAddCredential - Error add cred. Error=-50, attrs={
> acct = ;
> atyp = dflt;
> class = inet;
> icmt = default;
> labl = ")";;
> path = "";
> port = 443;
> ptcl = htps;
> sdmn = "";
> srvr = "";
> "v_Data" = <4d61726b 69764031 393838>;
> }
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13554) Unable to launch basic auth popup on the inappbrowser
vikram pottam created CB-13554: -- Summary: Unable to launch basic auth popup on the inappbrowser Key: CB-13554 URL: https://issues.apache.org/jira/browse/CB-13554 Project: Apache Cordova Issue Type: Bug Components: cordova-browser Affects Versions: cordova@7.0.0 Reporter: vikram pottam Assignee: Jesse MacFadyen Fix For: Master Unable to launch basic auth popup on the inappbrowser -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13553) option to provide custom 'user-data-dir' to preserve browser settings across subsequent runs
Szymon Stasik created CB-13553:
--
Summary: option to provide custom 'user-data-dir' to preserve
browser settings across subsequent runs
Key: CB-13553
URL: https://issues.apache.org/jira/browse/CB-13553
Project: Apache Cordova
Issue Type: Bug
Components: cordova-serve
Reporter: Szymon Stasik
To develop using browser and the app uses cordova plugins I use {{cordova run
browser # with appropriate flags}}. Now for development/debugging I'd like to
keep my browser config persistent (breakpoints, redux dev tools chrome
extension etc). To achieve this I'd like to keep the {{user-data-dir}}
somewhere else than in {{/tmp}} and now the {{/tmp}} prefix is hardcoded in
[{{cordova-serve}}|https://github.com/apache/cordova-serve/blob/master/src/browser.js#L107].
Would be great to have this as an option.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13332) iOS 11 Error When Taking Picture Missing NSPhotoLibraryAddUsageDescription
[ https://issues.apache.org/jira/browse/CB-13332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244256#comment-16244256 ] ASF GitHub Bot commented on CB-13332: - jcesarmobile commented on issue #289: CB-13332: (iOS) Error When Taking Picture Missing NSPhotoLibraryAddU… URL: https://github.com/apache/cordova-plugin-camera/pull/289#issuecomment-342871147 Yeah, it's only required if you have `saveToPhotoAlbum` option set to `true`, for reading then you need `NSPhotoLibraryUsageDescription` Either way, you have to use edit-config tag to set them, the plugin is removing the variables as they caused a lot of problems when other plugins wanted to set the same values This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS 11 Error When Taking Picture Missing NSPhotoLibraryAddUsageDescription > -- > > Key: CB-13332 > URL: https://issues.apache.org/jira/browse/CB-13332 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: iOS 11 >Reporter: Sam Mino >Assignee: jcesarmobile >Priority: Trivial > Labels: docs, easy-fix > > I am using this plugin to take a picture, but in iOS11 I receive the > following error: > * > _This app has crashed because it attempted to access privacy-sensitive data > without a usage description. The app's Info.plist must contain an > NSPhotoLibraryAddUsageDescription key with a string value explaining to the > user how the app uses this data._* > _Note: I have descriptions for CAMERA_USAGE_DESCRIPTION and > PHOTOLIBRARY_USAGE_DESCRIPTION. I was able to take a picture in iOS 10._ -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13332) iOS 11 Error When Taking Picture Missing NSPhotoLibraryAddUsageDescription
[ https://issues.apache.org/jira/browse/CB-13332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244244#comment-16244244 ] ASF GitHub Bot commented on CB-13332: - marcovtwout commented on issue #289: CB-13332: (iOS) Error When Taking Picture Missing NSPhotoLibraryAddU… URL: https://github.com/apache/cordova-plugin-camera/pull/289#issuecomment-342868860 FYI, `NSPhotoLibraryAddUsageDescription` is required when your plugin needs write access (shouldn't be required for read access) https://developer.apple.com/library/content/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS 11 Error When Taking Picture Missing NSPhotoLibraryAddUsageDescription > -- > > Key: CB-13332 > URL: https://issues.apache.org/jira/browse/CB-13332 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: iOS 11 >Reporter: Sam Mino >Assignee: jcesarmobile >Priority: Trivial > Labels: docs, easy-fix > > I am using this plugin to take a picture, but in iOS11 I receive the > following error: > * > _This app has crashed because it attempted to access privacy-sensitive data > without a usage description. The app's Info.plist must contain an > NSPhotoLibraryAddUsageDescription key with a string value explaining to the > user how the app uses this data._* > _Note: I have descriptions for CAMERA_USAGE_DESCRIPTION and > PHOTOLIBRARY_USAGE_DESCRIPTION. I was able to take a picture in iOS 10._ -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13552) iOS Cordova Build overwriting Bundle Display Name
Adam De Lay created CB-13552: Summary: iOS Cordova Build overwriting Bundle Display Name Key: CB-13552 URL: https://issues.apache.org/jira/browse/CB-13552 Project: Apache Cordova Issue Type: Bug Components: cordova-ios Affects Versions: cordova-ios 4.5.0 Environment: OSX 10.12.6; Cordova 7.1.0 Reporter: Adam De Lay Assignee: Suraj Pindoria I change my Bundle Display Name in my plist file (or in Xcode) and then I go to use cordova to build my application and when I do, the Bundle Display Name is being changed to the name tag from the config.xml. This is something new that I noticed in 4.5.1. I've built hundreds of apps before and never had this problem. I tried upgrading to 4.5.3 to see if it would fix the issue and it doesn't. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13551) cordova-android app restarts when "Don't keep activities" developer option is enabled on the Android device.
Srutha Keerthi created CB-13551: --- Summary: cordova-android app restarts when "Don't keep activities" developer option is enabled on the Android device. Key: CB-13551 URL: https://issues.apache.org/jira/browse/CB-13551 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-camera Affects Versions: 7.0.0 Environment: Android Reporter: Srutha Keerthi Priority: Minor Fix For: 7.0.0 Cordova - android application that uses the camera plugin restarts after taking a picture and trying to return to the calling Activity. This happens when there are a lot of other heavy resource usage apps (like downloading videos and running multiple games). Repro steps for developers are : 1. In the Developer Options settings of the Android device, enable the option "Don't keep Activities". This is to recreate a heavy resource usage on the OS (that is in reality caused by heavy resource usage by multiple apps) 2. Create a cordova app and add cordova-plugin-camera 3. Add a button and code to getPicture on button click. 4. Build and deploy the app onto the device. 5. Open camera by clicking on the button. 6. Take picture and click on the tick mark to accept the taken picture. 7. App restarts and does not execute the callback of the camera activity. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243537#comment-16243537 ] ASF GitHub Bot commented on CB-13396: - myrsk commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342749416 Hmm, will this be effected if i ionic build, and it does Building for iPhone SE Simulator. Then in xcode I run it as iphonex? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243525#comment-16243525 ] ASF GitHub Bot commented on CB-13396: - Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342745457 Did you make the shell script executable? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243528#comment-16243528 ] ASF GitHub Bot commented on CB-13396: - myrsk commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342746252 Yes, it was executable. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243383#comment-16243383 ] ASF GitHub Bot commented on CB-13396: - myrsk commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342712131 I have tried the fix, unforunately, the splash jumps from a smaller image on iphonex simulator (with small white space below), and then goes to the normal size splashscreen. Your help is appreciated. Similar issue to this: https://forum.ionicframework.com/t/ionic-3-splashscreen-bottom-gap-on-iphone-x-and-load-twice/111254 Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
