[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246841#comment-16246841 ] ASF subversion and git services commented on CB-13543: -- Commit 2ea959eeb4a28fcc41091035306d2c773f03d586 in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=2ea959e ] CB-13543 : adding travis file to build and deploy docs > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Update README.md > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13532) Cordova fails to find platform/plugin versions in package.json devDependencies
[
https://issues.apache.org/jira/browse/CB-13532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So reassigned CB-13532:
--
Assignee: Audrey So
> Cordova fails to find platform/plugin versions in package.json devDependencies
> --
>
> Key: CB-13532
> URL: https://issues.apache.org/jira/browse/CB-13532
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Reporter: Darryl Pogue
>Assignee: Audrey So
> Labels: tools-next
>
> Cordova only looks at the {{dependencies}} section of package.json, and
> ignores anything specified in {{devDependencies}}. This results in the
> default pinned versions for platforms/plugins being used.
> Code in question:
> https://github.com/apache/cordova-lib/blob/da8ebf6cb81dd84c22e24fdf0baff9837a544b2d/src/cordova/platform/addHelper.js#L109-L113
> This is wrong because Cordova (and its related bits) is not a dependency of
> my application code, it is a build tool that belongs in devDependencies.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-12810) keep existing formatting in package.json
[ https://issues.apache.org/jira/browse/CB-12810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So reassigned CB-12810: -- Assignee: Audrey So > keep existing formatting in package.json > > > Key: CB-12810 > URL: https://issues.apache.org/jira/browse/CB-12810 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: 7.0.0 >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: backlog, cordova-8.0.0, cordova-next, tools-next > > We will write our own indentation in package.json. For commands that shell > out to cordova-fetch and therefore npm, we have no control over it (cordova > platform/plugin add/rm). > We could theoretically keep indentaiton for commands where we write to > package.json (also platform/plugin add/rm to cordova key & during restore > when we sync config.xml & package.json). > This issue is probably not worth implementing. > npm@5 seems like it will respect existing formatting. > Previous issue with npm formatting: https://github.com/npm/npm/issues/5694 > npm5 respecting indentation: https://github.com/npm/npm/issues/16244 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13293) already fetched platforms shouldn't call fetch code
[ https://issues.apache.org/jira/browse/CB-13293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So reassigned CB-13293: -- Assignee: Audrey So > already fetched platforms shouldn't call fetch code > --- > > Key: CB-13293 > URL: https://issues.apache.org/jira/browse/CB-13293 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill >Assignee: Audrey So > Labels: tools-next > Fix For: cordova@7.1.0 > > > adding a platform that has already been added/fetched will still call > cordova-fetch before realizing the platform is already installed. Need to > check if platform is added first. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13559) Poor performance and crashes marshalling large ArrayBuffers from JS to Native side on iOS
[
https://issues.apache.org/jira/browse/CB-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246686#comment-16246686
]
Tim Hambourger commented on CB-13559:
-
FYI, the alternate implementation I've tested so far:
var CHUNK_SIZE = 0x;
function uint8ToBase64 (rawData) {
var strArray = [];
for (var i = 0; i * CHUNK_SIZE < rawData.length; i++) {
strArray.push(String.fromCharCode.apply(null, rawData.subarray(i *
CHUNK_SIZE, (i + 1) * CHUNK_SIZE)));
}
return window.btoa(strArray.join(''));
}
> Poor performance and crashes marshalling large ArrayBuffers from JS to Native
> side on iOS
> -
>
> Key: CB-13559
> URL: https://issues.apache.org/jira/browse/CB-13559
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios@4.4.0, cordova-ios@4.3.0, cordova-ios 4.5.0
> Environment: iOS 10.3 Simulator
> Using cordova-plugin-wkwebview-engine
>Reporter: Tim Hambourger
>Assignee: Suraj Pindoria
>Priority: Critical
> Attachments: iOS Exec timeline.png
>
>
> I'm doing performance analysis on an application that's attempting to write
> an approx. 10 MB Blob to disk using the File plugin. The uint8ToBase64
> function called by iOSExec looks like a particular bottleneck. I'm seeing
> large memory increases followed by GCs taking approx 1.5 secs. The attached
> screenshot has a typical Safari timeline.
> After some initial testing, it looks like re-implementing uint8ToBase64 using
> String.fromCharCode and window.btoa, rather than string appending, might
> yield some improvements. Some alternate implementations at
> [https://github.com/github-tools/github/issues/137] and
> [https://stackoverflow.com/questions/9267899/arraybuffer-to-base64-encoded-string].
> Is this something you would consider taking a look at? We're also weighing
> strategies to reduce our file size and the frequency of our writes, but a
> platform-level fix would be a huge help.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13559) Poor performance and crashes marshalling large ArrayBuffers from JS to Native side on iOS
Tim Hambourger created CB-13559: --- Summary: Poor performance and crashes marshalling large ArrayBuffers from JS to Native side on iOS Key: CB-13559 URL: https://issues.apache.org/jira/browse/CB-13559 Project: Apache Cordova Issue Type: Bug Components: cordova-ios Affects Versions: cordova-ios 4.5.0, cordova-ios@4.3.0, cordova-ios@4.4.0 Environment: iOS 10.3 Simulator Using cordova-plugin-wkwebview-engine Reporter: Tim Hambourger Assignee: Suraj Pindoria Priority: Critical Attachments: iOS Exec timeline.png I'm doing performance analysis on an application that's attempting to write an approx. 10 MB Blob to disk using the File plugin. The uint8ToBase64 function called by iOSExec looks like a particular bottleneck. I'm seeing large memory increases followed by GCs taking approx 1.5 secs. The attached screenshot has a typical Safari timeline. After some initial testing, it looks like re-implementing uint8ToBase64 using String.fromCharCode and window.btoa, rather than string appending, might yield some improvements. Some alternate implementations at [https://github.com/github-tools/github/issues/137] and [https://stackoverflow.com/questions/9267899/arraybuffer-to-base64-encoded-string]. Is this something you would consider taking a look at? We're also weighing strategies to reduce our file size and the frequency of our writes, but a platform-level fix would be a huge help. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13559) Poor performance and crashes marshalling large ArrayBuffers from JS to Native side on iOS
[ https://issues.apache.org/jira/browse/CB-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Hambourger updated CB-13559: Attachment: iOS Exec timeline.png > Poor performance and crashes marshalling large ArrayBuffers from JS to Native > side on iOS > - > > Key: CB-13559 > URL: https://issues.apache.org/jira/browse/CB-13559 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.4.0, cordova-ios@4.3.0, cordova-ios 4.5.0 > Environment: iOS 10.3 Simulator > Using cordova-plugin-wkwebview-engine >Reporter: Tim Hambourger >Assignee: Suraj Pindoria >Priority: Critical > Attachments: iOS Exec timeline.png > > > I'm doing performance analysis on an application that's attempting to write > an approx. 10 MB Blob to disk using the File plugin. The uint8ToBase64 > function called by iOSExec looks like a particular bottleneck. I'm seeing > large memory increases followed by GCs taking approx 1.5 secs. The attached > screenshot has a typical Safari timeline. > After some initial testing, it looks like re-implementing uint8ToBase64 using > String.fromCharCode and window.btoa, rather than string appending, might > yield some improvements. Some alternate implementations at > [https://github.com/github-tools/github/issues/137] and > [https://stackoverflow.com/questions/9267899/arraybuffer-to-base64-encoded-string]. > Is this something you would consider taking a look at? We're also weighing > strategies to reduce our file size and the frequency of our writes, but a > platform-level fix would be a huge help. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13528) Cordova-Android Platform Release November 2, 2017
[ https://issues.apache.org/jira/browse/CB-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246368#comment-16246368 ] ASF GitHub Bot commented on CB-13528: - infil00p opened a new pull request #757: CB-13528 Cordova Android 6.4.0 release announcement URL: https://github.com/apache/cordova-docs/pull/757 ### Platforms affected Android ### What does this PR do? This PR announces the updated Android version ### What testing has been done on this change? ### Checklist - [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova-Android Platform Release November 2, 2017 > - > > Key: CB-13528 > URL: https://issues.apache.org/jira/browse/CB-13528 > Project: Apache Cordova > Issue Type: Task > Components: cordova-android >Affects Versions: 6.3.0 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Fix For: 6.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13558) Unable to upload AAR to bintray
[ https://issues.apache.org/jira/browse/CB-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-13558: Description: I was unable to upload to bintray with the old version of Gradle that was saved on the framework project. When I updated it, I now get a 401 Unauthorized Error. This was found when releasing Cordova-Android 6.4.0 (CB-13528) (was: I was unable to upload to bintray with the old version of Gradle that was saved on the framework project. When I updated it, I now get a 401 Unauthorized Error.) > Unable to upload AAR to bintray > --- > > Key: CB-13558 > URL: https://issues.apache.org/jira/browse/CB-13558 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Joe Bowser >Assignee: Joe Bowser > > I was unable to upload to bintray with the old version of Gradle that was > saved on the framework project. When I updated it, I now get a 401 > Unauthorized Error. This was found when releasing Cordova-Android 6.4.0 > (CB-13528) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13558) Unable to upload AAR to bintray
[ https://issues.apache.org/jira/browse/CB-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-13558: Component/s: cordova-android > Unable to upload AAR to bintray > --- > > Key: CB-13558 > URL: https://issues.apache.org/jira/browse/CB-13558 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Joe Bowser >Assignee: Joe Bowser > > I was unable to upload to bintray with the old version of Gradle that was > saved on the framework project. When I updated it, I now get a 401 > Unauthorized Error. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13558) Unable to upload AAR to bintray
[ https://issues.apache.org/jira/browse/CB-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-13558: Summary: Unable to upload AAR to bintray (was: Unable to upload APK to bintray) > Unable to upload AAR to bintray > --- > > Key: CB-13558 > URL: https://issues.apache.org/jira/browse/CB-13558 > Project: Apache Cordova > Issue Type: Bug >Reporter: Joe Bowser >Assignee: Joe Bowser > > I was unable to upload to bintray with the old version of Gradle that was > saved on the framework project. When I updated it, I now get a 401 > Unauthorized Error. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13558) Unable to upload APK to bintray
Joe Bowser created CB-13558: --- Summary: Unable to upload APK to bintray Key: CB-13558 URL: https://issues.apache.org/jira/browse/CB-13558 Project: Apache Cordova Issue Type: Bug Reporter: Joe Bowser Assignee: Joe Bowser I was unable to upload to bintray with the old version of Gradle that was saved on the framework project. When I updated it, I now get a 401 Unauthorized Error. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13543: --- Labels: enhancement feature in-progress optimization (was: enhancement feature optimization) > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Update README.md > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246107#comment-16246107 ] ASF GitHub Bot commented on CB-13396: - Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-343228882 @myrsk apologies, the hook I posted had a typo. I wrote `-f` instead of `-d`. This is why it didn't work for you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246105#comment-16246105 ] ASF GitHub Bot commented on CB-13396: - Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-334784983 Actually, the code of this plugin needs not be changed. However, the `cordova-ios` template needs a fix. I am using `cordova-ios@4.5.1` and I've added this into `hooks/after_prepare/fix_splash_ios11.sh`: ``` #!/bin/bash if [ ! -d platforms/ios ]; then exit 0 fi NAME="$(find platforms/ios/ -name 'CDVLaunchScreen.storyboard')" sed -i '' 's_secondItem="xb3-aO-Qok" secondAttribute="top"_secondItem="Ze5-6b-2t3" secondAttribute="bottom"_g' "$NAME" ``` Basically, there is a wrong constraint in `CDVLaunchScreen.storyboard`. If this is fixed, nothing else needs to be changed. I have created a relevant issue on JIRA: https://issues.apache.org/jira/browse/CB-13411 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13540) cordova-fetch npm install --production clobbers node_modules, causes workflow issues
[
https://issues.apache.org/jira/browse/CB-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246030#comment-16246030
]
Alex Matchneer commented on CB-13540:
-
OK, getting closer: we use `yarn` (npm alternative that is generally faster and
more reliable) to install dependencies. I guess we can use npm if we must, but
the rest of our tooling is yarn-based and we figured we'd use it for cordova
too.
I still haven't pinpointed the exact issue, but I can reproduce it now:
1. rm -rf node_modules
2. yarn install
3. cordova add platform android --verbose
{code}
cordova :: cordova platform add android --verbose
No scripts found for hook "before_platform_add".
No version supplied. Retrieving version from config.xml...
Grabbing pinned version.
Using cordova-fetch for cordova-android@~6.3.0
saving
Running command: npm install cordova-android@~6.3.0 --production --save
Command finished with error code 0: npm
install,cordova-android@~6.3.0,--production,--save
Error: Failed to fetch platform cordova-android@~6.3.0
Probably this is either a connection problem, or platform spec is incorrect.
Check your connection and platform name/version/URL.
Failed to get absolute path to installed module
{code}
The npm install that internally happens is restructuring the contents of node
modules from what yarn installed; in particular, yarn tries to install modules
at the top level, including devDependency modules, and I believe the
--production flag passed to npm install is causing a bunch of those modules to
be deleted in the middle of script execution. Here is a diff on my node_modules
directory before and after the first `cordova platform add android`:
https://gist.github.com/machty/ae683968198a68359423f06a1339aacd
So, I guess the easiest answer is "just use npm and don't try and be clever
with yarn", but it seems non-ideal for Cordova to restructure `node_modules`
mid-execution, and it makes the integration with other workflows a bit more
brittle.
I'm gonna continue poking around but wanted to share my findings thus far.
> cordova-fetch npm install --production clobbers node_modules, causes workflow
> issues
>
>
> Key: CB-13540
> URL: https://issues.apache.org/jira/browse/CB-13540
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
>Reporter: Alex Matchneer
>Priority: Minor
> Labels: fetch, node_modules, npm
>
> I have tried and failed to provide a reproduction of this issue and have
> hence written/deleted/rewritten this issue many times without submitting, but
> now I'm going to just submit it, hope for feedback, and continue to try and
> reproduce:
> Basically, since this issue (https://issues.apache.org/jira/browse/CB-13303),
> cordova-fetch uses the `--production` flag with `npm install`, which tells
> npm not to install any "devDependencies".
> This seems like a sound approach, but for reasons that I can't reliably
> reproduced/put my finger on, it seems like this flag is also aggressively
> removing packages from `node_modules`, causing the following workflow issues:
> In my cordova project, I've added `cordova` as a dependency to package.json
> and encourage my teammates to use `./node_modules/.bin/cordova` rather than
> some globally installed `cordova` executable so that all dependencies are
> locked down and we don't have to fight the dependency hell of global CLI
> dependencies + local package.json dependencies.
> Now, when I freshly clone a repo, do an npm install, and then run
> `./node_modules/.bin/cordova prepare`, it will non-deterministically fail
> with the following output:
> {code}
> Discovered platform "ios@^4.5.3" in config.xml or package.json. Adding it to
> the project
> Using cordova-fetch for cordova-ios@^4.5.3
> Error: Failed to fetch platform cordova-ios@^4.5.3
> Probably this is either a connection problem, or platform spec is incorrect.
> Check your connection and platform name/version/URL.
> Failed to get absolute path to installed module
> Error: No platforms added to this project. Please use `cordova platform add
> `.
> {code}
> And when I look at node_modules, most of my dependencies have been deleted,
> and in particular, there's no more `node_modules/.bin/cordova` executable.
> My best guess is that the `npm install --production --no-save` that
> cordova-fetch internally does is nuking a bunch of dependencies considering
> "non-production", including the cli folder itself. The remedy is to use a
> globally installed cordova CLI executable, which somehow avoids these issues.
> Both my local and global cordova executables are 7.7.4.
> I will continue to try and provide a consistent reproduction of this issue;
> I've tried and failed many times and I'm starting to pull my hair out.
[jira] [Commented] (CB-13540) cordova-fetch npm install --production clobbers node_modules, causes workflow issues
[
https://issues.apache.org/jira/browse/CB-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245935#comment-16245935
]
Alex Matchneer commented on CB-13540:
-
npm -v
5.5.1
node -v
v7.7.4
cordova -v
7.1.0
I just ran into a similar issue, this time when using `cordova platform add
android`, and got the following output:
{code}
cordova platform add android
Using cordova-fetch for cordova-android@~6.3.0
Error: Failed to fetch platform cordova-android@~6.3.0
Probably this is either a connection problem, or platform spec is incorrect.
Check your connection and platform name/version/URL.
Failed to get absolute path to installed module
{code}
And then when I ran it again, it ran to completion. Continuing to poke around
and hopefully find a scenario that will reproduce.
> cordova-fetch npm install --production clobbers node_modules, causes workflow
> issues
>
>
> Key: CB-13540
> URL: https://issues.apache.org/jira/browse/CB-13540
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
>Reporter: Alex Matchneer
>Priority: Minor
> Labels: fetch, node_modules, npm
>
> I have tried and failed to provide a reproduction of this issue and have
> hence written/deleted/rewritten this issue many times without submitting, but
> now I'm going to just submit it, hope for feedback, and continue to try and
> reproduce:
> Basically, since this issue (https://issues.apache.org/jira/browse/CB-13303),
> cordova-fetch uses the `--production` flag with `npm install`, which tells
> npm not to install any "devDependencies".
> This seems like a sound approach, but for reasons that I can't reliably
> reproduced/put my finger on, it seems like this flag is also aggressively
> removing packages from `node_modules`, causing the following workflow issues:
> In my cordova project, I've added `cordova` as a dependency to package.json
> and encourage my teammates to use `./node_modules/.bin/cordova` rather than
> some globally installed `cordova` executable so that all dependencies are
> locked down and we don't have to fight the dependency hell of global CLI
> dependencies + local package.json dependencies.
> Now, when I freshly clone a repo, do an npm install, and then run
> `./node_modules/.bin/cordova prepare`, it will non-deterministically fail
> with the following output:
> {code}
> Discovered platform "ios@^4.5.3" in config.xml or package.json. Adding it to
> the project
> Using cordova-fetch for cordova-ios@^4.5.3
> Error: Failed to fetch platform cordova-ios@^4.5.3
> Probably this is either a connection problem, or platform spec is incorrect.
> Check your connection and platform name/version/URL.
> Failed to get absolute path to installed module
> Error: No platforms added to this project. Please use `cordova platform add
> `.
> {code}
> And when I look at node_modules, most of my dependencies have been deleted,
> and in particular, there's no more `node_modules/.bin/cordova` executable.
> My best guess is that the `npm install --production --no-save` that
> cordova-fetch internally does is nuking a bunch of dependencies considering
> "non-production", including the cli folder itself. The remedy is to use a
> globally installed cordova CLI executable, which somehow avoids these issues.
> Both my local and global cordova executables are 7.7.4.
> I will continue to try and provide a consistent reproduction of this issue;
> I've tried and failed many times and I'm starting to pull my hair out. I just
> wanted to officially post this issue in case other people have seen it, have
> advice, or have had better luck reproducing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13535) Add app events for connecting and disconnecting calls
[
https://issues.apache.org/jira/browse/CB-13535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245659#comment-16245659
]
ASF GitHub Bot commented on CB-13535:
-
SpencerEJameson closed pull request #348: CB-13535: (ios) Add CallStart/CallEnd
events to fire with Resign/Active events
URL: https://github.com/apache/cordova-ios/pull/348
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/CordovaLib/Classes/Public/CDVViewController.m
b/CordovaLib/Classes/Public/CDVViewController.m
index d0c05865a..b06fa1767 100644
--- a/CordovaLib/Classes/Public/CDVViewController.m
+++ b/CordovaLib/Classes/Public/CDVViewController.m
@@ -28,6 +28,10 @@ Licensed to the Apache Software Foundation (ASF) under one
#import "CDVLocalStorage.h"
#import "CDVCommandDelegateImpl.h"
#import
+#import
+#import
+#import
+#import
@interface CDVViewController () {
NSInteger _userAgentLockToken;
@@ -39,6 +43,7 @@ @interface CDVViewController () {
@property (nonatomic, readwrite, strong) NSMutableArray* startupPluginNames;
@property (nonatomic, readwrite, strong) NSDictionary* pluginsMap;
@property (nonatomic, readwrite, strong) id
webViewEngine;
+@property (nonatomic, readwrite, strong) CXCallObserver* callObserver;
@property (readwrite, assign) BOOL initialized;
@@ -74,6 +79,11 @@ - (void)__init
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(onAppDidEnterBackground:)
name:UIApplicationDidEnterBackgroundNotification object:nil];
+ if (IsAtLeastiOSVersion(@"10.0")) {
+ CXCallObserver *callObserver = [[CXCallObserver alloc] init];
+ [callObserver setDelegate:self queue:nil];
+ self.callObserver = callObserver;
+ }
// read from UISupportedInterfaceOrientations (or
UISupportedInterfaceOrientations~iPad, if its iPad) from -Info.plist
self.supportedOrientations = [self parseInterfaceOrientations:
[[[NSBundle mainBundle] infoDictionary]
objectForKey:@"UISupportedInterfaceOrientations"]];
@@ -343,9 +353,9 @@ - (void)viewDidLoad
}
}
}];
-
+
// /
-
+
NSString* bgColorString = [self.settings
cordovaSettingForKey:@"BackgroundColor"];
UIColor* bgColor = [self colorFromColorString:bgColorString];
[self.webView setBackgroundColor:bgColor];
@@ -405,16 +415,16 @@ - (UIColor*)colorFromColorString:(NSString*)colorString
if (!colorString) {
return nil;
}
-
+
// Validate format
NSError* error = NULL;
NSRegularExpression* regex = [NSRegularExpression
regularExpressionWithPattern:@"^(#[0-9A-F]{3}|(0x|#)([0-9A-F]{2})?[0-9A-F]{6})$"
options:NSRegularExpressionCaseInsensitive error:];
NSUInteger countMatches = [regex numberOfMatchesInString:colorString
options:0 range:NSMakeRange(0, [colorString length])];
-
+
if (!countMatches) {
return nil;
}
-
+
// #FAB to #FFAABB
if ([colorString hasPrefix:@"#"] && [colorString length] == 4) {
NSString* r = [colorString substringWithRange:NSMakeRange(1, 1)];
@@ -422,22 +432,22 @@ - (UIColor*)colorFromColorString:(NSString*)colorString
NSString* b = [colorString substringWithRange:NSMakeRange(3, 1)];
colorString = [NSString stringWithFormat:@"#%@%@%@%@%@%@", r, r, g, g,
b, b];
}
-
+
// #RRGGBB to 0xRRGGBB
colorString = [colorString stringByReplacingOccurrencesOfString:@"#"
withString:@"0x"];
-
+
// 0xRRGGBB to 0xAARRGGBB
if ([colorString hasPrefix:@"0x"] && [colorString length] == 8) {
colorString = [@"0xFF" stringByAppendingString:[colorString
substringFromIndex:2]];
}
-
+
// 0xAARRGGBB to int
unsigned colorValue = 0;
NSScanner *scanner = [NSScanner scannerWithString:colorString];
if (![scanner scanHexInt:]) {
return nil;
}
-
+
// int to UIColor
return [UIColor colorWithRed:((float)((colorValue & 0x00FF) >>
16))/255.0
green:((float)((colorValue & 0xFF00) >>
8))/255.0
@@ -480,9 +490,9 @@ - (BOOL)shouldAutorotate
}
// CB-12098
-#if __IPHONE_OS_VERSION_MAX_ALLOWED < 9
-- (NSUInteger)supportedInterfaceOrientations
-#else
+#if __IPHONE_OS_VERSION_MAX_ALLOWED < 9
+- (NSUInteger)supportedInterfaceOrientations
+#else
- (UIInterfaceOrientationMask)supportedInterfaceOrientations
#endif
{
@@ -728,6 +738,16 @@ - (void)onAppWillResignActive:(NSNotification*)notification
{
// NSLog(@"%@",@"applicationWillResignActive");
[self.commandDelegate evalJs:@"cordova.fireDocumentEvent('resign');"
[jira] [Commented] (CB-13535) Add app events for connecting and disconnecting calls
[ https://issues.apache.org/jira/browse/CB-13535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245658#comment-16245658 ] ASF GitHub Bot commented on CB-13535: - SpencerEJameson commented on issue #348: CB-13535: (ios) Add CallStart/CallEnd events to fire with Resign/Active events URL: https://github.com/apache/cordova-ios/pull/348#issuecomment-343157832 @shazron Totally, that makes sense. Thanks for providing the feedback! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add app events for connecting and disconnecting calls > - > > Key: CB-13535 > URL: https://issues.apache.org/jira/browse/CB-13535 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Spencer Jameson >Assignee: Suraj Pindoria > > The app resign/active events that Cordova fires trigger for multiple phone > events. Example: connecting a call and locking the screen app both trigger > the *resign* event, while disconnecting a call and unlocking the screen > trigger the *active* event. It would be convenient to have distinct events > that fire for calls connecting and ending to tie into, aside from the generic > *active* and *resign* events. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13557) Not able to set splashscreen image
Krishna Mohan created CB-13557:
--
Summary: Not able to set splashscreen image
Key: CB-13557
URL: https://issues.apache.org/jira/browse/CB-13557
Project: Apache Cordova
Issue Type: Bug
Components: cordova-plugin-splashscreen
Affects Versions: 4.0.0
Environment: ios ; cordova-plugin-splashscreen-4.0.3; CDVSplashScreen.m
Reporter: Krishna Mohan
Priority: Blocker
Fix For: 4.0.0
Please refer:
Defect: CB-9762 Launch Storyboard
Issue-1
getImageName function is checking for : isUsingCDVLaunchScreen.
issue: it is checking for a string called 'CDVLaunchScreen'. What if i have a
different storyboard name?
Fix: read "UILaunchStoryboardName" from plist. Don't* try to validate if the
value is "CDVLaunchScreen".
{I can create any text file with name: CDVLaunchScreen & set it in
UILaunchStoryboardName }
Issue-2
in getImageName fucntion, if "isUsingCDVLaunchScreen" is true, you are looking
for a hardcoded "imageName"
fix: read it from another flag in plist
Ex:
imageName = [[NSBundle mainBundle]
objectForInfoDictionaryKey:@"UILaunchStoryboardImage"];
if(!imageName) //if not set in plist
imageName = @"LaunchStoryboard"; //set the default
issue-3:
As a fix for: CB-9762 Launch Storyboard, all that is being done is: reading the
name from xcassetts.
-->instead of fixing issue-1 & issue-2, set a flag "StoryboardImage" in plist,
which is a image name.
-->read the value, get the imagename from plist vriable. if mistakenly set as
path in plist, handle it
-->here u can read/check for default name in case as fallback
Suggestion:
If you want to make the system more robust,
refer the below links.
//i am android developer, no knowledge about ios coding.
Basically, read the Storyboardname from plist, create an object from the
string, then cast it to Storyboard Calss & then, try to get the id of
resource(s) from storyboard.
https://stackoverflow.com/questions/1174093/create-objective-c-class-instance-by-name
id object = [[NSClassFromString(@"NameofClass") alloc] init];
https://stackoverflow.com/questions/2055940/how-do-i-test-which-class-an-object-is-in-objective-c
[yourObject isKindOfClass:[a class]]
Ex:
[myObject isKindOfClass:[NSString class]]
[myObject isKindOfClass:[UIImageView class]]
https://stackoverflow.com/questions/13708660/programmatically-get-a-storyboard-id
NSString *restorationId = self.restorationIdentifier;
https://stackoverflow.com/questions/13867565/what-is-a-storyboard-id-and-how-can-i-use-this
MyCustomViewController *vc = [self.storyboard
instantiateViewControllerWithIdentifier:@"MyViewController"];
EX:
https://stackoverflow.com/questions/24035984/instantiate-and-present-a-viewcontroller-in-swift
UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"myStoryboardName"
bundle:nil];
UIViewController *vc = [storyboard
instantiateViewControllerWithIdentifier:@"myVCID"];
[self presentViewController:vc animated:YES completion:nil];
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13556) I'd like to use Cordova Plugins in _blank Inappbrowser
[ https://issues.apache.org/jira/browse/CB-13556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JianningMu updated CB-13556: Labels: _blank cordova cordova-plugin inappbrowser plugin (was: _blank cordova inappbrowser plugin) > I'd like to use Cordova Plugins in _blank Inappbrowser > -- > > Key: CB-13556 > URL: https://issues.apache.org/jira/browse/CB-13556 > Project: Apache Cordova > Issue Type: Wish > Components: cordova-plugin-inappbrowser >Reporter: JianningMu >Priority: Minor > Labels: _blank, cordova, cordova-plugin, inappbrowser, plugin > > I built two Cordova projects which named P and S. > Then, I put S's www into P's www. By this way, I'd like to make S as a > sub-project of P. > Next, one of P's pages uses Inappbrowser to _self open S's index.html. > As a result, S can work well with Cordova Plugins which added by P. > But, when S was _blank opened, it can't use Cordova Plugins. > In short, I'd like to use Cordova Plugins in _blank Inappbrowser. > Could you give me a hand? > Thank you! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13556) I'd like to use Cordova Plugins in _blank Inappbrowser
[ https://issues.apache.org/jira/browse/CB-13556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JianningMu updated CB-13556: Labels: _blank cordova inappbrowser plugin (was: ) > I'd like to use Cordova Plugins in _blank Inappbrowser > -- > > Key: CB-13556 > URL: https://issues.apache.org/jira/browse/CB-13556 > Project: Apache Cordova > Issue Type: Wish > Components: cordova-plugin-inappbrowser >Reporter: JianningMu >Priority: Minor > Labels: _blank, cordova, inappbrowser, plugin > > I built two Cordova projects which named P and S. > Then, I put S's www into P's www. By this way, I'd like to make S as a > sub-project of P. > Next, one of P's pages uses Inappbrowser to _self open S's index.html. > As a result, S can work well with Cordova Plugins which added by P. > But, when S was _blank opened, it can't use Cordova Plugins. > In short, I'd like to use Cordova Plugins in _blank Inappbrowser. > Could you give me a hand? > Thank you! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13556) I'd like to use Cordova Plugins in _blank Inappbrowser
JianningMu created CB-13556: --- Summary: I'd like to use Cordova Plugins in _blank Inappbrowser Key: CB-13556 URL: https://issues.apache.org/jira/browse/CB-13556 Project: Apache Cordova Issue Type: Wish Components: cordova-plugin-inappbrowser Reporter: JianningMu Priority: Minor I built two Cordova projects which named P and S. Then, I put S's www into P's www. By this way, I'd like to make S as a sub-project of P. Next, one of P's pages uses Inappbrowser to _self open S's index.html. As a result, S can work well with Cordova Plugins which added by P. But, when S was _blank opened, it can't use Cordova Plugins. In short, I'd like to use Cordova Plugins in _blank Inappbrowser. Could you give me a hand? Thank you! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
