[jira] [Commented] (CB-3750) InAppBrowser: Can We Haz Loading Spinner?
[ https://issues.apache.org/jira/browse/CB-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290468#comment-16290468 ] ASF GitHub Bot commented on CB-3750: NiklasMerz commented on issue #89: CB-3750: Add loading spinner for ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/89#issuecomment-351631038 For hide spinner see #254 and [CB-13659](https://issues.apache.org/jira/browse/CB-13659) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser: Can We Haz Loading Spinner? > - > > Key: CB-3750 > URL: https://issues.apache.org/jira/browse/CB-3750 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0 > Environment: iOS >Reporter: Lindsey Simon >Priority: Trivial > Labels: Triaged > > I'm using the InAppBrowser to open a Google/Facebook OAuth login screen. In > order for that to work it first opens an URL on my server and then redirects > to the proper provider endpoint. > When the internet is slow this results in a pretty lousy user experience as > the InAppBrowser doesn't seem to have any loading indicator - which made me > think it wasn't working, and then I clicked Done prematurely. I suspect my > users will do the same and not try a second time and my app is DOA. > Am I missing anything here by chance? > Any advice on how to get a loading indicator in the least-intrusive way? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13673) Remove deprecated platforms from screen orientation plugin
[ https://issues.apache.org/jira/browse/CB-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Mishra closed CB-13673. -- Resolution: Fixed > Remove deprecated platforms from screen orientation plugin > -- > > Key: CB-13673 > URL: https://issues.apache.org/jira/browse/CB-13673 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13672) Remove multiple exclusion of js-module in vibration plugin
[ https://issues.apache.org/jira/browse/CB-13672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Mishra closed CB-13672. -- Resolution: Fixed > Remove multiple exclusion of js-module in vibration plugin > -- > > Key: CB-13672 > URL: https://issues.apache.org/jira/browse/CB-13672 > Project: Apache Cordova > Issue Type: Bug >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13665) Update globalization plugin with notice about Deprecation
[ https://issues.apache.org/jira/browse/CB-13665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Mishra closed CB-13665. -- Resolution: Fixed > Update globalization plugin with notice about Deprecation > - > > Key: CB-13665 > URL: https://issues.apache.org/jira/browse/CB-13665 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13677) Remove deprecated platforms for splash screen plugin
[ https://issues.apache.org/jira/browse/CB-13677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Mishra closed CB-13677. -- Resolution: Fixed > Remove deprecated platforms for splash screen plugin > > > Key: CB-13677 > URL: https://issues.apache.org/jira/browse/CB-13677 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13669) Remove deprecated platforms from the Media Capture plugin
[ https://issues.apache.org/jira/browse/CB-13669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Mishra closed CB-13669. -- Resolution: Fixed > Remove deprecated platforms from the Media Capture plugin > - > > Key: CB-13669 > URL: https://issues.apache.org/jira/browse/CB-13669 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13667) Remove deprecated platforms for the Battery status plugin
[ https://issues.apache.org/jira/browse/CB-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Mishra closed CB-13667. -- Resolution: Fixed > Remove deprecated platforms for the Battery status plugin > - > > Key: CB-13667 > URL: https://issues.apache.org/jira/browse/CB-13667 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13666) Remove deprecated platforms for vibration plugin
[ https://issues.apache.org/jira/browse/CB-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Mishra closed CB-13666. -- Resolution: Fixed > Remove deprecated platforms for vibration plugin > > > Key: CB-13666 > URL: https://issues.apache.org/jira/browse/CB-13666 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13663) Remove support for deprecated platforms for cordova-plugin-network-information
[ https://issues.apache.org/jira/browse/CB-13663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Mishra closed CB-13663. -- Resolution: Fixed > Remove support for deprecated platforms for cordova-plugin-network-information > -- > > Key: CB-13663 > URL: https://issues.apache.org/jira/browse/CB-13663 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13665) Update globalization plugin with notice about Deprecation
[ https://issues.apache.org/jira/browse/CB-13665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290461#comment-16290461 ] ASF subversion and git services commented on CB-13665: -- Commit e0a5c7a224bdb628ffd1650797b04cfa528da0be in cordova-plugin-globalization's branch refs/heads/master from [~vishalmishra] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-globalization.git;h=e0a5c7a ] Merge pull request #62 from maverickmishra/master CB-13665 : Update README with deprecation notice > Update globalization plugin with notice about Deprecation > - > > Key: CB-13665 > URL: https://issues.apache.org/jira/browse/CB-13665 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13665) Update globalization plugin with notice about Deprecation
[ https://issues.apache.org/jira/browse/CB-13665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290460#comment-16290460 ] ASF GitHub Bot commented on CB-13665: - maverickmishra closed pull request #62: CB-13665 : Update README with deprecation notice URL: https://github.com/apache/cordova-plugin-globalization/pull/62 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 1f3a5a0..ba868b6 100644 --- a/README.md +++ b/README.md @@ -50,6 +50,10 @@ Although in the global scope, it is not available until after the `deviceready` Report issues with this plugin on the [Apache Cordova issue tracker](https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%29%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Plugin%20Globalization%22%20ORDER%20BY%20priority%20DESC%2C%20summary%20ASC%2C%20updatedDate%20DESC) +### Deprecation Notice + +With the [ECMA Internationalization API](https://www.ecma-international.org/ecma-402/1.0/) now supported on iOS, Android and Windows devices, this plugin is not required any more. Migrating from this plugin to the [ECMA Internationalization API](https://www.ecma-international.org/ecma-402/1.0/) is explained in this [Cordova blog post](https://cordova.apache.org/news/2017/11/20/migrate-from-cordova-globalization-plugin.html). + ## Installation cordova plugin add cordova-plugin-globalization This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update globalization plugin with notice about Deprecation > - > > Key: CB-13665 > URL: https://issues.apache.org/jira/browse/CB-13665 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13667) Remove deprecated platforms for the Battery status plugin
[ https://issues.apache.org/jira/browse/CB-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290458#comment-16290458 ] ASF subversion and git services commented on CB-13667: -- Commit 3e36391c15246d5a34d4e4428ce030edd5b15e7a in cordova-plugin-battery-status's branch refs/heads/master from [~vishalmishra] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=3e36391 ] Merge pull request #61 from maverickmishra/master CB-13667 : Remove deprecated platforms > Remove deprecated platforms for the Battery status plugin > - > > Key: CB-13667 > URL: https://issues.apache.org/jira/browse/CB-13667 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13667) Remove deprecated platforms for the Battery status plugin
[ https://issues.apache.org/jira/browse/CB-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290456#comment-16290456 ] ASF GitHub Bot commented on CB-13667: - maverickmishra closed pull request #61: CB-13667 : Remove deprecated platforms URL: https://github.com/apache/cordova-plugin-battery-status/pull/61 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 6c76309..f8f9eda 100644 --- a/README.md +++ b/README.md @@ -60,26 +60,14 @@ Fires when the battery charge percentage changes by at least 1 percent, or when ### Supported Platforms -- Amazon Fire OS - iOS - Android -- BlackBerry 10 -- Windows Phone 7 and 8 -- Windows (Windows Phone 8.1 and Windows 10) -- Firefox OS +- Windows - Browser (Chrome, Firefox, Opera) -### Quirks: Android Amazon Fire OS +### Quirks: Android -**Warning**: the Android and Fire OS implementations are greedy and prolonged use will drain the device's battery. - -### Quirks: Windows Phone 7 Windows Phone 8 - -The `level` property is _not_ supported on Windows Phone 7 because the OS does not provide native APIs to determine battery level. The `isPlugged` parameter _is_ supported. - -### Quirks: Windows Phone 8.1 - -The `isPlugged` parameter is _not_ supported on Windows Phone 8.1. The `level` parameter _is_ supported. +**Warning**: the Android implementation is greedy and prolonged use will drain the device's battery. ## batterylow event @@ -95,18 +83,11 @@ Fires when the battery charge percentage reaches the low charge threshold. This ### Supported Platforms -- Amazon Fire OS - iOS - Android -- BlackBerry 10 -- Firefox OS -- Windows (Windows Phone 8.1 and Windows 10) +- Windows - Browser (Chrome, Firefox, Opera) -### Quirks: Windows Phone 8.1 - -The `batterylow` event fires on Windows Phone 8.1 irrespective of whether the device is plugged in or not. This happens because the OS does not provide an API to detect whether the device is plugged in. - ## batterycritical event Fires when the battery charge percentage reaches the critical charge threshold. This threshold value is device-specific. Returns an [object][status_object] containing battery status. @@ -121,17 +102,11 @@ Fires when the battery charge percentage reaches the critical charge threshold. ### Supported Platforms -- Amazon Fire OS - iOS - Android -- BlackBerry 10 -- Firefox OS -- Windows (Windows Phone 8.1 and Windows 10) +- Windows - Browser (Chrome, Firefox, Opera) -### Quirks: Windows Phone 8.1 - -The `batterycritical` event fires on Windows Phone 8.1 irrespective of whether the device is plugged in or not. This happens because the OS does not provide an API to detect whether the device is plugged in. [w3c_spec]: http://www.w3.org/TR/2011/WD-battery-status-20110915/ [status_object]: #status-object diff --git a/package.json b/package.json index 24d80e0..73447f3 100644 --- a/package.json +++ b/package.json @@ -1,20 +1,15 @@ { "name": "cordova-plugin-battery-status", - "version": "1.2.6-dev", + "version": "2.0.0-dev", "description": "Cordova Battery Plugin", "types": "./types/index.d.ts", "cordova": { "id": "cordova-plugin-battery-status", "platforms": [ "android", - "amazon-fireos", - "ubuntu", "ios", - "blackberry10", - "wp7", - "wp8", - "tizen", - "firefoxos" + "browser", + "windows" ] }, "repository": { @@ -29,14 +24,7 @@ "battery", "ecosystem:cordova", "cordova-android", -"cordova-amazon-fireos", -"cordova-ubuntu", -"cordova-ios", -"cordova-blackberry10", -"cordova-wp7", -"cordova-wp8", -"cordova-tizen", -"cordova-firefoxos" +"cordova-ios" ], "scripts": { "test": "npm run eslint", diff --git a/plugin.xml b/plugin.xml index 39d1596..3c15e77 100644 --- a/plugin.xml +++ b/plugin.xml @@ -20,7 +20,7 @@ http://apache.org/cordova/ns/plugins/1.0; id="cordova-plugin-battery-status" - version="1.2.6-dev"> + version="2.0.0-dev"> Battery Cordova Battery Plugin Apache 2.0 @@ -43,23 +43,6 @@ - - - - - - - - - - - - - - - - - @@ -71,36 +54,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -110,20 +63,6 @@ - - - -
[jira] [Commented] (CB-13667) Remove deprecated platforms for the Battery status plugin
[ https://issues.apache.org/jira/browse/CB-13667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290457#comment-16290457 ] ASF subversion and git services commented on CB-13667: -- Commit 85dca46d2fad281ed9a5da4fce14af331b27 in cordova-plugin-battery-status's branch refs/heads/master from [~vishalmishra] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=85d ] CB-13667 : Remove deprecated platforms > Remove deprecated platforms for the Battery status plugin > - > > Key: CB-13667 > URL: https://issues.apache.org/jira/browse/CB-13667 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13669) Remove deprecated platforms from the Media Capture plugin
[ https://issues.apache.org/jira/browse/CB-13669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290453#comment-16290453 ] ASF GitHub Bot commented on CB-13669: - maverickmishra closed pull request #87: CB-13669 : Remove deprecated plugins URL: https://github.com/apache/cordova-plugin-media-capture/pull/87 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 78ba926..830eb38 100644 --- a/README.md +++ b/README.md @@ -61,13 +61,9 @@ Report issues with this plugin on the [Apache Cordova issue tracker](https://iss ## Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 - Browser - iOS -- Windows Phone 7 and 8 -- Windows 8 - Windows ## Objects @@ -126,12 +122,8 @@ code. ### Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 - iOS -- Windows Phone 7 and 8 -- Windows 8 - Windows ### Example @@ -189,13 +181,9 @@ object featuring a `CaptureError.CAPTURE_NO_MEDIA_FILES` error code. ### Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 - Browser - iOS -- Windows Phone 7 and 8 -- Windows 8 - Windows ### iOS Quirks @@ -229,11 +217,6 @@ To add these entries into the `info.plist`, you can use the `edit-config` tag in ``` -### Windows Phone 7 Quirks - -Invoking the native camera application while your device is connected -via Zune does not work, and the error callback executes. - ### Browser Quirks Works in Chrome, Firefox and Opera only (since IE and Safari doesn't supports @@ -291,12 +274,8 @@ capturing a video clip, the `CaptureErrorCB` callback executes with a ### Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 - iOS -- Windows Phone 7 and 8 -- Windows 8 - Windows ### Example @@ -319,10 +298,6 @@ capturing a video clip, the `CaptureErrorCB` callback executes with a navigator.device.capture.captureVideo(captureSuccess, captureError, {limit:2}); -### BlackBerry 10 Quirks - -- Cordova for BlackBerry 10 attempts to launch the __Video Recorder__ application, provided by RIM, to capture video recordings. The app receives a `CaptureError.CAPTURE_NOT_SUPPORTED` error code if the application is not installed on the device. - ## CaptureAudioOptions @@ -341,18 +316,10 @@ capturing a video clip, the `CaptureErrorCB` callback executes with a navigator.device.capture.captureAudio(captureSuccess, captureError, options); -### Amazon Fire OS Quirks - -- The `duration` parameter is not supported. Recording lengths cannot be limited programmatically. - ### Android Quirks - The `duration` parameter is not supported. Recording lengths can't be limited programmatically. -### BlackBerry 10 Quirks - -- The `duration` parameter is not supported. Recording lengths can't be limited programmatically. -- The `limit` parameter is not supported, so only one recording can be created for each invocation. ### iOS Quirks @@ -396,10 +363,6 @@ capturing a video clip, the `CaptureErrorCB` callback executes with a navigator.device.capture.captureVideo(captureSuccess, captureError, options); -### BlackBerry 10 Quirks - -- The __duration__ property is ignored, so the length of recordings can't be limited programmatically. - ### iOS Quirks - The __limit__ property is ignored. Only one video is recorded per invocation. @@ -549,23 +512,10 @@ callback. ### Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 - iOS -- Windows Phone 7 and 8 -- Windows 8 - Windows -### Amazon Fire OS Quirks - -The API to access media file format information is limited, so not all -`MediaFileData` properties are supported. - -### BlackBerry 10 Quirks - -Does not provide an API for information about media files, so all -`MediaFileData` objects return with default values. ### Android Quirks @@ -613,36 +563,6 @@ The API to access media file format information is limited, so not all - __duration__: The length of the video or sound clip in seconds. The value is zero for images. (Number) -### BlackBerry 10 Quirks - -No API provides format information for media files, so the -`MediaFileData` object returned by `MediaFile.getFormatData` features -the following default values: - -- __codecs__: Not supported, and returns `null`. - -- __bitrate__: Not supported, and returns zero. - -- __height__: Not supported, and returns zero. - -- __width__: Not supported, and returns zero. - -- __duration__: Not supported, and returns zero. - -### Amazon Fire OS Quirks - -Supports the following `MediaFileData` properties: - -- __codecs__: Not supported, and returns `null`. - -- __bitrate__: Not supported, and returns zero. - -- __height__: Supported: image and
[jira] [Commented] (CB-13669) Remove deprecated platforms from the Media Capture plugin
[ https://issues.apache.org/jira/browse/CB-13669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290454#comment-16290454 ] ASF subversion and git services commented on CB-13669: -- Commit 191643651b3211553d40d212df897af7330bcf7a in cordova-plugin-media-capture's branch refs/heads/master from [~vishalmishra] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=1916436 ] CB-13669 : Remove deprecated plugins > Remove deprecated platforms from the Media Capture plugin > - > > Key: CB-13669 > URL: https://issues.apache.org/jira/browse/CB-13669 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13677) Remove deprecated platforms for splash screen plugin
[ https://issues.apache.org/jira/browse/CB-13677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290452#comment-16290452 ] ASF subversion and git services commented on CB-13677: -- Commit a606af98cacf3e66fd9e9bb4b53f09619a606587 in cordova-plugin-splashscreen's branch refs/heads/master from [~vishalmishra] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=a606af9 ] Merge pull request #143 from maverickmishra/master CB-13677: Remove deprecated platforms > Remove deprecated platforms for splash screen plugin > > > Key: CB-13677 > URL: https://issues.apache.org/jira/browse/CB-13677 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13677) Remove deprecated platforms for splash screen plugin
[ https://issues.apache.org/jira/browse/CB-13677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290451#comment-16290451 ] ASF subversion and git services commented on CB-13677: -- Commit 2ae821c4a853b6544464bce2d57e26efd7b8d888 in cordova-plugin-splashscreen's branch refs/heads/master from [~vishalmishra] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=2ae821c ] CB-13677: Remove deprecated platforms > Remove deprecated platforms for splash screen plugin > > > Key: CB-13677 > URL: https://issues.apache.org/jira/browse/CB-13677 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13677) Remove deprecated platforms for splash screen plugin
[ https://issues.apache.org/jira/browse/CB-13677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290450#comment-16290450 ] ASF GitHub Bot commented on CB-13677: - maverickmishra closed pull request #143: CB-13677: Remove deprecated platforms URL: https://github.com/apache/cordova-plugin-splashscreen/pull/143 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 86df3193..49ff0ef4 100644 --- a/README.md +++ b/README.md @@ -41,11 +41,8 @@ Report issues with this plugin on the [Apache Cordova issue tracker][Apache Cord ## Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 - iOS -- Windows Phone 7 and 8 - Windows (`cordova-windows` version >= 4.4.0 is required) - Browser @@ -353,12 +350,6 @@ projectRoot --> - - - - - - ``` @@ -499,7 +490,7 @@ navigator.splashscreen.hide(); ``` -### BlackBerry 10, WP8, iOS Quirk +### iOS Quirk The `config.xml` file's `AutoHideSplashScreen` setting must be `false`. To delay hiding the splash screen for two seconds, add a diff --git a/package.json b/package.json index 015aec5a..9309f86a 100644 --- a/package.json +++ b/package.json @@ -1,20 +1,16 @@ { "name": "cordova-plugin-splashscreen", - "version": "4.1.1-dev", + "version": "5.0.0-dev", "description": "Cordova Splashscreen Plugin", "types": "./types/index.d.ts", "cordova": { "id": "cordova-plugin-splashscreen", "platforms": [ "android", - "amazon-fireos", "ubuntu", "ios", - "blackberry10", - "wp8", - "windows8", "windows", - "tizen" + "browser" ] }, "repository": { @@ -29,14 +25,8 @@ "splashscreen", "ecosystem:cordova", "cordova-android", -"cordova-amazon-fireos", -"cordova-ubuntu", "cordova-ios", -"cordova-blackberry10", -"cordova-wp8", -"cordova-windows8", -"cordova-windows", -"cordova-tizen" +"cordova-windows" ], "scripts": { "test": "npm run jshint", diff --git a/plugin.xml b/plugin.xml index dc1f3ab5..fb0fc0a6 100644 --- a/plugin.xml +++ b/plugin.xml @@ -20,7 +20,7 @@ http://apache.org/cordova/ns/plugins/1.0; id="cordova-plugin-splashscreen" - version="4.1.1-dev"> + version="5.0.0-dev"> Splashscreen Cordova Splashscreen Plugin Apache 2.0 @@ -49,23 +49,6 @@ - - - - - - - - - - - - - - - - - @@ -83,35 +66,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -119,13 +73,6 @@ - - - - - - - diff --git a/src/blackberry10/index.js b/src/blackberry10/index.js deleted file mode 100644 index c6825064.. --- a/src/blackberry10/index.js +++ /dev/null @@ -1,30 +0,0 @@ -/* - * Copyright 2013 Research In Motion Limited. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -/* global PluginResult */ - -module.exports = { -show: function (success, fail, args, env) { -var result = new PluginResult(args, env); -result.error("Not supported on platform", false); -}, - -hide: function (success, fail, args, env) { -var result = new PluginResult(args, env); -window.qnx.webplatform.getApplication().windowVisible = true; -result.ok(undefined, false); -} -}; diff --git a/src/tizen/SplashScreenProxy.js b/src/tizen/SplashScreenProxy.js deleted file mode 100644 index 06c06972.. --- a/src/tizen/SplashScreenProxy.js +++ /dev/null @@ -1,43 +0,0 @@ -/* - * - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License,
[jira] [Commented] (CB-13666) Remove deprecated platforms for vibration plugin
[ https://issues.apache.org/jira/browse/CB-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290449#comment-16290449 ] ASF subversion and git services commented on CB-13666: -- Commit c255a2f73176e83aa6bf28a75bd33f04fb54060d in cordova-plugin-vibration's branch refs/heads/master from [~vishalmishra] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=c255a2f ] Merge pull request #62 from maverickmishra/master CB-13666 : Removed deprecated platforms > Remove deprecated platforms for vibration plugin > > > Key: CB-13666 > URL: https://issues.apache.org/jira/browse/CB-13666 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13666) Remove deprecated platforms for vibration plugin
[ https://issues.apache.org/jira/browse/CB-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290448#comment-16290448 ] ASF subversion and git services commented on CB-13666: -- Commit 2a309f9b08635148bcea903359459d622cddeab9 in cordova-plugin-vibration's branch refs/heads/master from [~vishalmishra] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=2a309f9 ] CB-13666 : Removed deprecated platforms > Remove deprecated platforms for vibration plugin > > > Key: CB-13666 > URL: https://issues.apache.org/jira/browse/CB-13666 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13666) Remove deprecated platforms for vibration plugin
[ https://issues.apache.org/jira/browse/CB-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290447#comment-16290447 ] ASF GitHub Bot commented on CB-13666: - maverickmishra closed pull request #62: CB-13666 : Removed deprecated platforms URL: https://github.com/apache/cordova-plugin-vibration/pull/62 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index d989247..e5ae6ee 100644 --- a/README.md +++ b/README.md @@ -49,15 +49,11 @@ Although in the global scope, they are not available until after the `deviceread ## Supported Platforms -navigator.vibrate, -navigator.notification.vibrate -- Amazon Fire OS +navigator.vibrate + - Android -- BlackBerry 10 -- Firefox OS - iOS -- Windows Phone 7 and 8 -- Windows (Windows Phone 8.1 devices only) +- Windows The Android webview (API level 19 and up) supports the [W3C Vibration API](https://www.w3.org/TR/vibration/) natively and therefore, the Android specific implementation of this plugin has been dropped. @@ -93,7 +89,7 @@ or navigator.vibrate(3000); // 3000 is ignored - Windows and Blackberry Quirks + Windows Quirks - __time__: Max time is 5000ms (5s) and min time is 1ms @@ -115,9 +111,6 @@ Vibrates the device with a given pattern // Vibrate for 5 seconds navigator.vibrate([1000, 1000, 3000, 1000, 5000]); - Windows Phone 8 Quirks - -- vibrate(pattern) falls back on vibrate with default duration ### Cancel vibration (not supported in iOS) @@ -135,6 +128,3 @@ or Passing in a parameter of 0, an empty array, or an array with one element of value 0 will cancel any vibrations. - - - diff --git a/package.json b/package.json index 02792a4..80f80c7 100644 --- a/package.json +++ b/package.json @@ -6,15 +6,9 @@ "cordova": { "id": "cordova-plugin-vibration", "platforms": [ - "firefoxos", - "wp7", - "wp8", "android", - "amazon-fireos", - "ubuntu", "ios", - "blackberry10", - "tizen" + "windows" ] }, "repository": { @@ -28,15 +22,9 @@ "cordova", "vibration", "ecosystem:cordova", -"cordova-firefoxos", -"cordova-wp7", -"cordova-wp8", "cordova-android", -"cordova-amazon-fireos", -"cordova-ubuntu", "cordova-ios", -"cordova-blackberry10", -"cordova-tizen" +"cordova-windows" ], "scripts": { "test": "npm run eslint", diff --git a/plugin.xml b/plugin.xml index d45531e..5a92d3a 100644 --- a/plugin.xml +++ b/plugin.xml @@ -30,66 +30,6 @@ https://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration.git https://issues.apache.org/jira/browse/CB/component/12320639 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -97,35 +37,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -143,18 +54,18 @@ - - - - - - - - + + + + + + + @@ -169,14 +80,4 @@ - - - - - - - - - - diff --git a/src/blackberry10/index.js b/src/blackberry10/index.js deleted file mode 100644 index 491f9bf..000 --- a/src/blackberry10/index.js +++ /dev/null @@ -1,82 +0,0 @@ -/* - * - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law
[jira] [Commented] (CB-13663) Remove support for deprecated platforms for cordova-plugin-network-information
[ https://issues.apache.org/jira/browse/CB-13663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290446#comment-16290446 ] ASF subversion and git services commented on CB-13663: -- Commit f294a194c91f9c6984024e33fab3bba8df1944ad in cordova-plugin-network-information's branch refs/heads/master from [~vishalmishra] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-network-information.git;h=f294a19 ] Merge pull request #59 from maverickmishra/master CB-13663 : Removed deprecated platforms > Remove support for deprecated platforms for cordova-plugin-network-information > -- > > Key: CB-13663 > URL: https://issues.apache.org/jira/browse/CB-13663 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13663) Remove support for deprecated platforms for cordova-plugin-network-information
[ https://issues.apache.org/jira/browse/CB-13663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290444#comment-16290444 ] ASF GitHub Bot commented on CB-13663: - maverickmishra closed pull request #59: CB-13663 : Removed deprecated platforms URL: https://github.com/apache/cordova-plugin-network-information/pull/59 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 4ee2bb0..1bcb8f3 100644 --- a/README.md +++ b/README.md @@ -45,15 +45,10 @@ Report issues with this plugin on the [Apache Cordova issue tracker][Apache Cord ## Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 - Browser - iOS -- Windows Phone 7 and 8 -- Tizen - Windows -- Firefox OS # Connection @@ -114,27 +109,10 @@ eventually be removed. - The code examples in this section show examples of changing app behavior using the online and offline events and your network connection status. diff --git a/package.json b/package.json index 73b253d..74998a1 100644 --- a/package.json +++ b/package.json @@ -1,22 +1,14 @@ { "name": "cordova-plugin-network-information", - "version": "1.3.5-dev", + "version": "2.0.0-dev", "description": "Cordova Network Information Plugin", "types": "./types/index.d.ts", "cordova": { "id": "cordova-plugin-network-information", "platforms": [ - "firefoxos", "android", - "amazon-fireos", - "ubuntu", "ios", - "blackberry10", - "wp7", - "wp8", - "windows8", "windows", - "tizen", "browser" ] }, @@ -32,17 +24,9 @@ "network", "information", "ecosystem:cordova", -"cordova-firefoxos", "cordova-android", -"cordova-amazon-fireos", -"cordova-ubuntu", "cordova-ios", -"cordova-blackberry10", -"cordova-wp7", -"cordova-wp8", -"cordova-windows8", "cordova-windows", -"cordova-tizen", "cordova-browser" ], "scripts": { diff --git a/plugin.xml b/plugin.xml index 95f3f31..ce2cea0 100644 --- a/plugin.xml +++ b/plugin.xml @@ -21,7 +21,7 @@ http://apache.org/cordova/ns/plugins/1.0; xmlns:android="http://schemas.android.com/apk/res/android; id="cordova-plugin-network-information" - version="1.3.5-dev"> + version="2.0.0-dev"> Network Information Cordova Network Information Plugin @@ -39,12 +39,6 @@ xmlns:android="http://schemas.android.com/apk/res/android; - - - - - - @@ -62,34 +56,6 @@ xmlns:android="http://schemas.android.com/apk/res/android; - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -106,51 +72,6 @@ xmlns:android="http://schemas.android.com/apk/res/android; - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -158,13 +79,6 @@ xmlns:android="http://schemas.android.com/apk/res/android; - - - - - - - diff --git a/src/blackberry10/index.js b/src/blackberry10/index.js deleted file mode 100644 index 1c8588b..000 --- a/src/blackberry10/index.js +++ /dev/null @@ -1,65 +0,0 @@ -/* - * - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - * -*/ - -/* global PluginResult */ - -// map from BB10 to cordova connection types: -//
[jira] [Commented] (CB-13663) Remove support for deprecated platforms for cordova-plugin-network-information
[ https://issues.apache.org/jira/browse/CB-13663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290445#comment-16290445 ] ASF subversion and git services commented on CB-13663: -- Commit a15fc1cae50c7f16f9437a1d7e8a8022d25c1e95 in cordova-plugin-network-information's branch refs/heads/master from [~vishalmishra] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-network-information.git;h=a15fc1c ] CB-13663 : Removed deprecated platforms > Remove support for deprecated platforms for cordova-plugin-network-information > -- > > Key: CB-13663 > URL: https://issues.apache.org/jira/browse/CB-13663 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13057) Remove cordova platform save command
[ https://issues.apache.org/jira/browse/CB-13057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290441#comment-16290441 ] ASF subversion and git services commented on CB-13057: -- Commit 33d84dd734a47d1d2d9bd85b6e6017b3c59bfbe5 in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=33d84dd ] CB-13057 : removed save function and updated unit-tests after these changes > Remove cordova platform save command > > > Key: CB-13057 > URL: https://issues.apache.org/jira/browse/CB-13057 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: cordova@8 >Reporter: Steve Gill >Assignee: Audrey So > Labels: backlog, tools-next > Fix For: cordova@8 > > > With autosaving now in place, we don't need `cordova platform save` anymore. > By removing this command, we can also remove > cordovaProject/platforms/platforms.json & > cordova-lib/src/cordova/platform_metadata.js > Deprecation notice will be added to cordova platform save until save command > is removed in cordova@8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13057) Remove cordova platform save command
[ https://issues.apache.org/jira/browse/CB-13057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290442#comment-16290442 ] ASF subversion and git services commented on CB-13057: -- Commit 7108ad25d885f62df6a9b745beeb09de49d7074b in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=7108ad2 ] CB-13057: updated based on feedback This closes #586 > Remove cordova platform save command > > > Key: CB-13057 > URL: https://issues.apache.org/jira/browse/CB-13057 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: cordova@8 >Reporter: Steve Gill >Assignee: Audrey So > Labels: backlog, tools-next > Fix For: cordova@8 > > > With autosaving now in place, we don't need `cordova platform save` anymore. > By removing this command, we can also remove > cordovaProject/platforms/platforms.json & > cordova-lib/src/cordova/platform_metadata.js > Deprecation notice will be added to cordova platform save until save command > is removed in cordova@8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13057) Remove cordova platform save command
[ https://issues.apache.org/jira/browse/CB-13057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290440#comment-16290440 ] ASF GitHub Bot commented on CB-13057: - stevengill closed pull request #586: CB-13057 : Remove cordova platform save command URL: https://github.com/apache/cordova-lib/pull/586 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/integration-tests/pkgJson-restore.spec.js b/integration-tests/pkgJson-restore.spec.js index 04253e035..4e3e19048 100644 --- a/integration-tests/pkgJson-restore.spec.js +++ b/integration-tests/pkgJson-restore.spec.js @@ -140,8 +140,6 @@ describe('tests platform/spec restore with --save', function () { var cwd = process.cwd(); var pkgJsonPath = path.join(cwd, 'package.json'); var pkgJson; -var platformsFolderPath = path.join(cwd, 'platforms/platforms.json'); -var platformsJson; var configXmlPath = path.join(cwd, 'config.xml'); var bPlatform = 'browser'; var engines; @@ -167,9 +165,6 @@ describe('tests platform/spec restore with --save', function () { pkgJson = cordova_util.requireNoCache(pkgJsonPath); expect(pkgJson.cordova.platforms.indexOf('browser')).toBeDefined(); expect(pkgJson.dependencies['cordova-browser']).toEqual('git+https://github.com/apache/cordova-browser.git'); -// Check that platform was added to platforms list successfully. -platformsJson = cordova_util.requireNoCache(platformsFolderPath); -expect(platformsJson[bPlatform]).toBeDefined(); }).then(function () { // Remove platform without --save. return cordovaPlatform('rm', bPlatform, {'fetch': true}); @@ -178,9 +173,6 @@ describe('tests platform/spec restore with --save', function () { pkgJson = cordova_util.requireNoCache(pkgJsonPath); expect(pkgJson.cordova.platforms.indexOf('browser')).toBeDefined(); expect(pkgJson.dependencies['cordova-browser']).toEqual('git+https://github.com/apache/cordova-browser.git'); -// Platform in platforms.json should not be there. -platformsJson = cordova_util.requireNoCache(platformsFolderPath); -expect(platformsJson[bPlatform]).toBeUndefined(); }).then(function () { // Run cordova prepare return prepare({'fetch': true}); @@ -200,9 +192,6 @@ describe('tests platform/spec restore with --save', function () { pkgJson = cordova_util.requireNoCache(pkgJsonPath); expect(pkgJson.cordova.platforms.indexOf('browser')).toBeDefined(); expect(pkgJson.dependencies['cordova-browser']).toEqual('git+https://github.com/apache/cordova-browser.git'); -// Check that platform was restored to platform.json list successfully. -platformsJson = cordova_util.requireNoCache(platformsFolderPath); -expect(platformsJson[bPlatform]).toBeDefined(); }).fail(function (err) { expect(err).toBeUndefined(); }).fin(done); @@ -327,9 +316,7 @@ describe('tests platform/spec restore with --save', function () { var cwd = process.cwd(); var pkgJsonPath = path.join(cwd, 'package.json'); var pkgJson; -var platformsFolderPath = path.join(cwd, 'platforms/platforms.json'); var secondPlatformAdded = 'ios'; -var platformsJson; emptyPlatformList().then(function () { // Add 'browser' platform to project without --save @@ -340,14 +327,10 @@ describe('tests platform/spec restore with --save', function () { }).then(function () { // Delete any previous caches of require(package.json) and (platformsJson) pkgJson = cordova_util.requireNoCache(pkgJsonPath); -platformsJson = cordova_util.requireNoCache(platformsFolderPath); // Check the platform add of only helpers.testPlatform was successful in package.json. expect(pkgJson.cordova.platforms).toBeDefined(); expect(pkgJson.cordova.platforms.indexOf('browser')).toBeGreaterThan(-1); expect(pkgJson.cordova.platforms.indexOf(secondPlatformAdded)).toEqual(-1); -// Expect both platforms to be installed platform list in platforms.json -expect(platformsJson['browser']).toBeDefined(); -expect(platformsJson[secondPlatformAdded]).toBeDefined(); }).then(fullPlatformList) // Platforms should still be in platform ls. .then(function () { // Remove helpers.testPlatform without --save. @@ -357,23 +340,12 @@ describe('tests platform/spec
[jira] [Commented] (CB-13673) Remove deprecated platforms from screen orientation plugin
[ https://issues.apache.org/jira/browse/CB-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290431#comment-16290431 ] ASF subversion and git services commented on CB-13673: -- Commit 7ada73dc2a4f66c23bf49725b753f78d0583deb4 in cordova-plugin-screen-orientation's branch refs/heads/master from [~purplecabbage] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-screen-orientation.git;h=7ada73d ] Merge pull request #27 from purplecabbage/CB-13673 CB-13673 : Remove deprecated platforms > Remove deprecated platforms from screen orientation plugin > -- > > Key: CB-13673 > URL: https://issues.apache.org/jira/browse/CB-13673 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13673) Remove deprecated platforms from screen orientation plugin
[ https://issues.apache.org/jira/browse/CB-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290430#comment-16290430 ] ASF subversion and git services commented on CB-13673: -- Commit 374c59a094cd4d231007281b62dd0457285b3624 in cordova-plugin-screen-orientation's branch refs/heads/master from [~purplecabbage] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-screen-orientation.git;h=374c59a ] CB-13673 : Remove deprecated platforms > Remove deprecated platforms from screen orientation plugin > -- > > Key: CB-13673 > URL: https://issues.apache.org/jira/browse/CB-13673 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13673) Remove deprecated platforms from screen orientation plugin
[ https://issues.apache.org/jira/browse/CB-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290432#comment-16290432 ] ASF subversion and git services commented on CB-13673: -- Commit 7ada73dc2a4f66c23bf49725b753f78d0583deb4 in cordova-plugin-screen-orientation's branch refs/heads/master from [~purplecabbage] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-screen-orientation.git;h=7ada73d ] Merge pull request #27 from purplecabbage/CB-13673 CB-13673 : Remove deprecated platforms > Remove deprecated platforms from screen orientation plugin > -- > > Key: CB-13673 > URL: https://issues.apache.org/jira/browse/CB-13673 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13673) Remove deprecated platforms from screen orientation plugin
[ https://issues.apache.org/jira/browse/CB-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290429#comment-16290429 ] ASF GitHub Bot commented on CB-13673: - purplecabbage closed pull request #27: CB-13673 : Remove deprecated platforms URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/27 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index e295d91..3c61cb7 100644 --- a/README.md +++ b/README.md @@ -23,7 +23,7 @@ # Cordova Screen Orientation Plugin -Cordova plugin to set/lock the screen orientation in a common way for iOS, Android, WP8 and Blackberry 10. This plugin is based on [Screen Orientation API](http://www.w3.org/TR/screen-orientation/) so the api matches the current spec. +Cordova plugin to set/lock the screen orientation in a common way for iOS, Android, and windows-uwp. This plugin is based on [Screen Orientation API](http://www.w3.org/TR/screen-orientation/) so the api matches the current spec. The plugin adds the following to the screen object (`window.screen`): @@ -113,17 +113,9 @@ screen.orientation.onchange = function(){console.log(screen.orientation.type); The __screen.orientation__ property will not update when the phone is [rotated 180 degrees](http://www.quirksmode.org/dom/events/orientationchange.html). -## BB10 Notes +## Windows UWP Notes -Wraps the com.blackberry.app plugin functions, auto installed as a dependancy. - -## WP8 Notes - -Windows phone does not support specification or primary and secondary orientations. If called with a specific orientation the plugin will just apply the landscape or portait orientation. - -## W8.1 Notes - -Windows 8.1 Applicaitons (runtime/metro applications) will only display orientation changes if the device has some sort of accelerometer. The internal state of the "orientation" will still be kept, but the actual screen won't rotate unless the device supports it. +Windows store apps (windows-uwp) will only display orientation changes if the device has some sort of accelerometer. The internal state of the "orientation" will still be kept, but the actual screen won't rotate unless the device supports it. # Legacy Changelog diff --git a/package.json b/package.json index 8d7fcf4..6526b9e 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "platforms": [ "android", "ios", - "wp8" + "windows" ] }, "keywords": [ diff --git a/plugin.xml b/plugin.xml index 1da2cb5..de2c0dd 100644 --- a/plugin.xml +++ b/plugin.xml @@ -20,7 +20,7 @@ id="cordova-plugin-screen-orientation" version="2.0.3-dev"> Screen Orientation -Adds Screen Orientation API lock and unlock functions to the global screen object in android, iOS, WP8, W8.1, and BB10. +Adds Screen Orientation API lock and unlock functions to the global screen object in android, iOS and windows-uwp. Apache 2.0 @@ -56,23 +56,10 @@ - - - - - - - - - - - - - diff --git a/www/screenorientation.bb10.js b/www/screenorientation.bb10.js deleted file mode 100644 index eef4bca..000 --- a/www/screenorientation.bb10.js +++ /dev/null @@ -1,34 +0,0 @@ -/* - * - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - * -*/ - -var screenOrientation = {}; - -screenOrientation.setOrientation = function(orientation) { -if (blackberry.app) { -if (orientation === 'unlocked') { -blackberry.app.unlockOrientation(); -} else { -blackberry.app.lockOrientation(orientation); -} -} -}; - -module.exports = screenOrientation; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to
[jira] [Commented] (CB-13056) Remove non platform-API platforms
[ https://issues.apache.org/jira/browse/CB-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290400#comment-16290400 ] ASF subversion and git services commented on CB-13056: -- Commit 349a1e600368148316b5706b5736fd490ccbe621 in cordova-lib's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=349a1e6 ] CB-13056: fixed tests > Remove non platform-API platforms > - > > Key: CB-13056 > URL: https://issues.apache.org/jira/browse/CB-13056 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Audrey So > Labels: tools-next > Fix For: cordova-8 > > > In the next major version of cordova, we should drop all platforms that > haven't updated to platformAPI > This includes older browser platforms, webos, blackberry and ubuntu > We can remove the parsers for these files + the platformAPI polyfill and any > other files that these platforms use -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13056) Remove non platform-API platforms
[ https://issues.apache.org/jira/browse/CB-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290398#comment-16290398 ] ASF subversion and git services commented on CB-13056: -- Commit 82c29778f32e7a2f1aa495e98d2f8d93e693d1a5 in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=82c2977 ] CB-13056 : removed PlatformApiPoly and tests > Remove non platform-API platforms > - > > Key: CB-13056 > URL: https://issues.apache.org/jira/browse/CB-13056 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Audrey So > Labels: tools-next > Fix For: cordova-8 > > > In the next major version of cordova, we should drop all platforms that > haven't updated to platformAPI > This includes older browser platforms, webos, blackberry and ubuntu > We can remove the parsers for these files + the platformAPI polyfill and any > other files that these platforms use -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13056) Remove non platform-API platforms
[ https://issues.apache.org/jira/browse/CB-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290399#comment-16290399 ] ASF subversion and git services commented on CB-13056: -- Commit 7ddf693d8cf9df6cd39a14e9c4b5e6a6f298ff67 in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=7ddf693 ] CB-13056 : added error message back in > Remove non platform-API platforms > - > > Key: CB-13056 > URL: https://issues.apache.org/jira/browse/CB-13056 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Audrey So > Labels: tools-next > Fix For: cordova-8 > > > In the next major version of cordova, we should drop all platforms that > haven't updated to platformAPI > This includes older browser platforms, webos, blackberry and ubuntu > We can remove the parsers for these files + the platformAPI polyfill and any > other files that these platforms use -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13056) Remove non platform-API platforms
[ https://issues.apache.org/jira/browse/CB-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290397#comment-16290397 ] ASF subversion and git services commented on CB-13056: -- Commit f86b408e2495a68d4c13122d4fe7a426f22ee1e2 in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=f86b408 ] CB-13056 : removed parsers and platformApi polyfill for webos, blackberry10, and ubuntu > Remove non platform-API platforms > - > > Key: CB-13056 > URL: https://issues.apache.org/jira/browse/CB-13056 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Audrey So > Labels: tools-next > Fix For: cordova-8 > > > In the next major version of cordova, we should drop all platforms that > haven't updated to platformAPI > This includes older browser platforms, webos, blackberry and ubuntu > We can remove the parsers for these files + the platformAPI polyfill and any > other files that these platforms use -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10123) -webkit-scrollbar css does not work in WKWebViewEngine
[ https://issues.apache.org/jira/browse/CB-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290311#comment-16290311 ] Chin Lun commented on CB-10123: --- Hi, I am also experience this issue. Is there any ETA for the fix? > -webkit-scrollbar css does not work in WKWebViewEngine > -- > > Key: CB-10123 > URL: https://issues.apache.org/jira/browse/CB-10123 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-wkwebview-engine > Environment: Using iOS 9, with IOS-Cordova 4.0 (beta) and official > cordova WKWebView engine. >Reporter: Cole Turner > Labels: wkwebview-known-issues > > To hide the appearance of scrollbars in Safari, Webkit, and UIWebView, we use > the following CSS: > ::-webkit-scrollbar {display:none;} > The WKWebView engine does not honor this property. The only way to control > the appearance of a scrollbar is invoking it via a plugin as so: > self.wkWebView.scrollView.showsVerticalScrollIndicator = NO; > self.wkWebView.scrollView.showsHorizontalScrollIndicator = NO; > It would be nice to abstract this as a plugin preference since the WKWebView > engine is now a separate plugin: (via Shazron) > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13671) Remove deprecated platforms for dialogs plugin
[ https://issues.apache.org/jira/browse/CB-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290219#comment-16290219 ] ASF subversion and git services commented on CB-13671: -- Commit 87c1665f102b17c84372f01fd7f766ea27e4b21e in cordova-plugin-dialogs's branch refs/heads/master from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-dialogs.git;h=87c1665 ] CB-13671: Remove deprecated platforms > Remove deprecated platforms for dialogs plugin > -- > > Key: CB-13671 > URL: https://issues.apache.org/jira/browse/CB-13671 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-dialogs >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13671) Remove deprecated platforms for dialogs plugin
[ https://issues.apache.org/jira/browse/CB-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290218#comment-16290218 ] ASF GitHub Bot commented on CB-13671: - stevengill closed pull request #99: CB-13671: Remove deprecated platforms URL: https://github.com/apache/cordova-plugin-dialogs/pull/99 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 675c3c4..aaca95a 100644 --- a/README.md +++ b/README.md @@ -82,32 +82,11 @@ function, which is typically less customizable. ### Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 - Browser -- Firefox OS - iOS -- Tizen -- Windows Phone 7 and 8 -- Windows 8 - Windows -### Windows Phone 7 and 8 Quirks - -- There is no built-in browser alert, but you can bind one as follows to call `alert()` in the global scope: - -window.alert = navigator.notification.alert; - -- Both `alert` and `confirm` are non-blocking calls, results of which are only available asynchronously. - -### Firefox OS Quirks: - -Both native-blocking `window.alert()` and non-blocking `navigator.notification.alert()` are available. - -### BlackBerry 10 Quirks -`navigator.notification.alert('text', callback, 'title', 'text')` callback parameter is passed the number 1. - ## navigator.notification.confirm Displays a customizable confirmation dialog box. @@ -147,39 +126,21 @@ indexing, so the value is `1`, `2`, `3`, etc. ### Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 - Browser -- Firefox OS - iOS -- Tizen -- Windows Phone 7 and 8 -- Windows 8 - Windows ### Android Quirks - Android supports a maximum of three buttons, and ignores any more than that. -### Windows Phone 7 and 8 Quirks - -- There is no built-in browser function for `window.confirm`, but you can bind it by assigning: - -window.confirm = navigator.notification.confirm; - -- Calls to `alert` and `confirm` are non-blocking, so the result is only available asynchronously. - ### Windows Quirks - On Windows8/8.1 it is not possible to add more than three buttons to MessageDialog instance. - On Windows Phone 8.1 it's not possible to show dialog with more than two buttons. -### Firefox OS Quirks: - -Both native-blocking `window.confirm()` and non-blocking `navigator.notification.confirm()` are available. - ## navigator.notification.prompt Displays a native dialog box that is more customizable than the browser's `prompt` function. @@ -224,13 +185,9 @@ contains the following properties: ### Supported Platforms -- Amazon Fire OS - Android - Browser -- Firefox OS - iOS -- Windows Phone 7 and 8 -- Windows 8 - Windows ### Android Quirks @@ -243,10 +200,6 @@ contains the following properties: - On Windows prompt dialog is html-based due to lack of such native api. -### Firefox OS Quirks: - -Both native-blocking `window.prompt()` and non-blocking `navigator.notification.prompt()` are available. - ## navigator.notification.beep The device plays a beep sound. @@ -262,29 +215,11 @@ The device plays a beep sound. ### Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 - Browser - iOS -- Tizen -- Windows Phone 7 and 8 - Windows 8 -### Amazon Fire OS Quirks - -- Amazon Fire OS plays the default __Notification Sound__ specified under the __Settings/Display & Sound__ panel. - ### Android Quirks - Android plays the default __Notification ringtone__ specified under the __Settings/Sound & Display__ panel. - -### Windows Phone 7 and 8 Quirks - -- Relies on a generic beep file from the Cordova distribution. - -### Tizen Quirks - -- Tizen implements beeps by playing an audio file via the media API. - -- The beep file must be short, must be located in a `sounds` subdirectory of the application's root directory, and must be named `beep.wav`. diff --git a/package.json b/package.json index efaca98..36ea9ba 100644 --- a/package.json +++ b/package.json @@ -1,21 +1,14 @@ { "name": "cordova-plugin-dialogs", - "version": "1.3.5-dev", + "version": "2.0.0-dev", "description": "Cordova Notification Plugin", "types": "./types/index.d.ts", "cordova": { "id": "cordova-plugin-dialogs", "platforms": [ - "firefoxos", "android", "browser", - "amazon-fireos", - "ubuntu", "ios", - "blackberry10", - "wp7", - "wp8", - "windows8", "windows" ] }, @@ -30,16 +23,9 @@ "cordova", "notification", "ecosystem:cordova", -"cordova-firefoxos", "cordova-android", "cordova-browser", -"cordova-amazon-fireos", -"cordova-ubuntu", "cordova-ios", -"cordova-blackberry10", -"cordova-wp7",
[jira] [Commented] (CB-13670) Remove deprecated platforms for device plugin
[ https://issues.apache.org/jira/browse/CB-13670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290213#comment-16290213 ] ASF GitHub Bot commented on CB-13670: - stevengill closed pull request #73: CB-13670: Remove deprecated platforms URL: https://github.com/apache/cordova-plugin-device/pull/73 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 2cdb708..048f028 100644 --- a/README.md +++ b/README.md @@ -61,14 +61,9 @@ Get the version of Cordova running on the device. ### Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 - Browser -- Firefox OS - iOS -- Tizen -- Windows Phone 7 and 8 - Windows - OSX @@ -81,11 +76,8 @@ different across versions of the same product. ### Supported Platforms - Android -- BlackBerry 10 - Browser - iOS -- Tizen -- Windows Phone 7 and 8 - Windows - OSX @@ -107,14 +99,6 @@ var model = device.model; - Gets the [product name](http://developer.android.com/reference/android/os/Build.html#PRODUCT) instead of the [model name](http://developer.android.com/reference/android/os/Build.html#MODEL), which is often the production code name. For example, the Nexus One returns `Passion`, and Motorola Droid returns `voles`. -### Tizen Quirks - -- Returns the device model assigned by the vendor, for example, `TIZEN` - -### Windows Phone 7 and 8 Quirks - -- Returns the device model specified by the manufacturer. For example, the Samsung Focus returns `SGH-i917`. - ## device.platform Get the device's operating system name. @@ -125,12 +109,8 @@ var string = device.platform; ### Supported Platforms - Android -- BlackBerry 10 - Browser -- Firefox OS - iOS -- Tizen -- Windows Phone 7 and 8 - Windows - OSX @@ -148,14 +128,6 @@ var string = device.platform; var devicePlatform = device.platform; ``` -### Windows Phone 7 Quirks - -Windows Phone 7 devices report the platform as `WinCE`. - -### Windows Phone 8 Quirks - -Windows Phone 8 devices report the platform as `Win32NT`. - ## device.uuid Get the device's Universally Unique Identifier ([UUID](http://en.wikipedia.org/wiki/Universally_Unique_Identifier)). @@ -171,10 +143,7 @@ The details of how a UUID is generated are determined by the device manufacturer ### Supported Platforms - Android -- BlackBerry 10 - iOS -- Tizen -- Windows Phone 7 and 8 - Windows - OSX @@ -206,14 +175,6 @@ The UUID will be the same if app is restored from a backup or iCloud as it is sa The `uuid` on OSX is generated automatically if it does not exist yet and is stored in the `standardUserDefaults` in the `CDVUUID` property. -### Windows Phone 7 and 8 Quirks - -The `uuid` for Windows Phone 7 requires the permission -`ID_CAP_IDENTITY_DEVICE`. Microsoft will likely deprecate this -property soon. If the capability is not available, the application -generates a persistent guid that is maintained for the duration of the -application's installation on the device. - ## device.version Get the operating system version. @@ -223,11 +184,8 @@ Get the operating system version. ### Supported Platforms - Android 2.1+ -- BlackBerry 10 - Browser - iOS -- Tizen -- Windows Phone 7 and 8 - Windows - OSX @@ -261,9 +219,7 @@ Get the device's manufacturer. ### Supported Platforms - Android -- BlackBerry 10 - iOS -- Windows Phone 7 and 8 - Windows ### Quick Example @@ -289,7 +245,6 @@ var isSim = device.isVirtual; - Android 2.1+ - Browser - iOS -- Windows Phone 8 - Windows - OSX diff --git a/package.json b/package.json index 65e0826..a968cd1 100644 --- a/package.json +++ b/package.json @@ -1,21 +1,13 @@ { "name": "cordova-plugin-device", - "version": "1.1.8-dev", + "version": "2.0.0-dev", "description": "Cordova Device Plugin", "types": "./types/index.d.ts", "cordova": { "id": "cordova-plugin-device", "platforms": [ - "firefoxos", - "tizen", "android", - "amazon-fireos", - "ubuntu", "ios", - "blackberry10", - "wp7", - "wp8", - "windows8", "windows", "browser", "osx" @@ -32,16 +24,8 @@ "cordova", "device", "ecosystem:cordova", -"cordova-firefoxos", -"cordova-tizen", "cordova-android", -"cordova-amazon-fireos", -"cordova-ubuntu", "cordova-ios", -"cordova-blackberry10", -"cordova-wp7", -"cordova-wp8", -"cordova-windows8", "cordova-windows", "cordova-browser", "cordova-osx" diff --git a/plugin.xml b/plugin.xml index 0be5e7f..81cf61c 100644 --- a/plugin.xml +++ b/plugin.xml @@ -22,7 +22,7 @@ xmlns:rim="http://www.blackberry.com/ns/widgets;
[jira] [Commented] (CB-13670) Remove deprecated platforms for device plugin
[ https://issues.apache.org/jira/browse/CB-13670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290215#comment-16290215 ] ASF subversion and git services commented on CB-13670: -- Commit 6ef6287e6601a05e815da758d6cd393af8de3b84 in cordova-plugin-device's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-device.git;h=6ef6287 ] Merge pull request #73 from surajpindoria/removePlatforms CB-13670: Remove deprecated platforms > Remove deprecated platforms for device plugin > - > > Key: CB-13670 > URL: https://issues.apache.org/jira/browse/CB-13670 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-device >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13670) Remove deprecated platforms for device plugin
[ https://issues.apache.org/jira/browse/CB-13670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290214#comment-16290214 ] ASF subversion and git services commented on CB-13670: -- Commit ac14d1c7de258d5c5a5c89517e35bc696495d9e9 in cordova-plugin-device's branch refs/heads/master from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-device.git;h=ac14d1c ] CB-13670: Remove deprecated platforms > Remove deprecated platforms for device plugin > - > > Key: CB-13670 > URL: https://issues.apache.org/jira/browse/CB-13670 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-device >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13668) Remove deprecated platforms for file plugin
[ https://issues.apache.org/jira/browse/CB-13668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290212#comment-16290212 ] ASF subversion and git services commented on CB-13668: -- Commit 4f9c0f25c2ea5ad38207c7552cceab45b4c025ac in cordova-plugin-file's branch refs/heads/master from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-file.git;h=4f9c0f2 ] CB-13668: Remove deprecated platforms > Remove deprecated platforms for file plugin > --- > > Key: CB-13668 > URL: https://issues.apache.org/jira/browse/CB-13668 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13664) Remove deprecated platforms for geolocation plugin
[ https://issues.apache.org/jira/browse/CB-13664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290210#comment-16290210 ] ASF subversion and git services commented on CB-13664: -- Commit 76579eb007764570da28da330d366460d56bf5f0 in cordova-plugin-geolocation's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=76579eb ] Merge pull request #99 from surajpindoria/removePlatforms CB-13664: remove deprecated platforms > Remove deprecated platforms for geolocation plugin > -- > > Key: CB-13664 > URL: https://issues.apache.org/jira/browse/CB-13664 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-geolocation >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13664) Remove deprecated platforms for geolocation plugin
[ https://issues.apache.org/jira/browse/CB-13664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290209#comment-16290209 ] ASF subversion and git services commented on CB-13664: -- Commit 92f595cefb83716189d6176ae01b044f8d016233 in cordova-plugin-geolocation's branch refs/heads/master from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=92f595c ] CB-13664: remove deprecated platforms > Remove deprecated platforms for geolocation plugin > -- > > Key: CB-13664 > URL: https://issues.apache.org/jira/browse/CB-13664 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-geolocation >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13664) Remove deprecated platforms for geolocation plugin
[ https://issues.apache.org/jira/browse/CB-13664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290208#comment-16290208 ] ASF GitHub Bot commented on CB-13664: - stevengill closed pull request #99: CB-13664: remove deprecated platforms URL: https://github.com/apache/cordova-plugin-geolocation/pull/99 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 7535d94..a212a76 100644 --- a/README.md +++ b/README.md @@ -88,13 +88,8 @@ It is also possible to install via repo url directly ( unstable ) ## Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 -- Firefox OS - iOS -- Tizen -- Windows Phone 7 and 8 - Windows ## Methods @@ -310,10 +305,6 @@ It contains a set of properties that describe the geographic coordinates of a po * __speed__: Current ground speed of the device, specified in meters per second. _(Number)_ -### Amazon Fire OS Quirks - -__altitudeAccuracy__: Not supported by Android devices, returning `null`. - ### Android Quirks __altitudeAccuracy__: Not supported by Android devices, returning `null`. diff --git a/package.json b/package.json index 79c4364..2ef9f65 100644 --- a/package.json +++ b/package.json @@ -1,20 +1,13 @@ { "name": "cordova-plugin-geolocation", - "version": "3.0.1-dev", + "version": "4.0.0-dev", "description": "Cordova Geolocation Plugin", "cordova": { "id": "cordova-plugin-geolocation", "platforms": [ "android", - "amazon-fireos", "ios", - "blackberry10", - "ubuntu", - "wp7", - "wp8", - "windows8", - "windows", - "firefoxos" + "windows" ] }, "repository": { @@ -29,15 +22,8 @@ "geolocation", "ecosystem:cordova", "cordova-android", -"cordova-amazon-fireos", "cordova-ios", -"cordova-blackberry10", -"cordova-ubuntu", -"cordova-wp7", -"cordova-wp8", -"cordova-windows8", -"cordova-windows", -"cordova-firefoxos" +"cordova-windows" ], "scripts": { "test": "npm run eslint", diff --git a/plugin.xml b/plugin.xml index 457b96a..74da986 100644 --- a/plugin.xml +++ b/plugin.xml @@ -22,7 +22,7 @@ xmlns:rim="http://www.blackberry.com/ns/widgets; xmlns:android="http://schemas.android.com/apk/res/android; id="cordova-plugin-geolocation" - version="3.0.1-dev"> + version="4.0.0-dev"> Geolocation Cordova Geolocation Plugin @@ -61,16 +61,6 @@ xmlns:android="http://schemas.android.com/apk/res/android; - - - - - - - - - - @@ -103,113 +93,6 @@ xmlns:android="http://schemas.android.com/apk/res/android; - - - - - - - - - - - - - - - - - - - - - - - - - - - - - read_geolocation - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -236,31 +119,4 @@ xmlns:android="http://schemas.android.com/apk/res/android; - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/src/firefoxos/GeolocationProxy.js b/src/firefoxos/GeolocationProxy.js deleted file mode 100644 index 598f705..000 --- a/src/firefoxos/GeolocationProxy.js +++ /dev/null @@ -1,67 +0,0 @@ -/* - * - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless
[jira] [Commented] (CB-13661) Remove deprecated platforms from camera plugin
[ https://issues.apache.org/jira/browse/CB-13661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290206#comment-16290206 ] ASF GitHub Bot commented on CB-13661: - stevengill closed pull request #301: CB-13661: Remove deprecated platforms URL: https://github.com/apache/cordova-plugin-camera/pull/301 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 27bf6f5f..c3948f09 100644 --- a/README.md +++ b/README.md @@ -179,14 +179,10 @@ than `DATA_URL`. __Supported Platforms__ - Android -- BlackBerry - Browser -- Firefox -- FireOS - iOS - Windows -- WP8 -- Ubuntu +- OSX More examples [here](#camera-getPicture-examples). Quirks [here](#camera-getPicture-quirks). @@ -469,12 +465,6 @@ Take a photo and retrieve it as a Base64-encoded image: - Amazon Fire OS Quirks - -Amazon Fire OS uses intents to launch the camera activity on the device to capture -images, and on phones with low memory, the Cordova activity may be killed. In this -scenario, the image may not appear when the Cordova activity is restored. - Android Quirks Android uses intents to launch the camera activity on the device to capture @@ -490,10 +480,6 @@ successful. Can only return photos as Base64-encoded image. - Firefox OS Quirks - -Camera plugin is currently implemented using [Web Activities][web_activities]. - iOS Quirks Including a JavaScript `alert()` in either of the callback functions @@ -505,11 +491,6 @@ displays: // do your thing here! }, 0); - Windows Phone 7 Quirks - -Invoking the native camera application while the device is connected -via Zune does not work, and triggers an error callback. - Windows quirks On Windows Phone 8.1 using `SAVEDPHOTOALBUM` or `PHOTOLIBRARY` as a source type causes application to suspend until file picker returns the selected image and @@ -520,22 +501,6 @@ To avoid this we suggest using SPA pattern or call `camera.getPicture` only from More information about Windows Phone 8.1 picker APIs is here: [How to continue your Windows Phone app after calling a file picker](https://msdn.microsoft.com/en-us/library/windows/apps/dn720490.aspx) - Tizen Quirks - -Tizen only supports a `destinationType` of -`Camera.DestinationType.FILE_URI` and a `sourceType` of -`Camera.PictureSourceType.PHOTOLIBRARY`. - - -## `CameraOptions` Errata - - Amazon Fire OS Quirks - -- Any `cameraDirection` value results in a back-facing photo. - -- Ignores the `allowEdit` parameter. - -- `Camera.PictureSourceType.PHOTOLIBRARY` and `Camera.PictureSourceType.SAVEDPHOTOALBUM` both display the same photo album. Android Quirks @@ -547,38 +512,6 @@ Tizen only supports a `destinationType` of - Ignores the `encodingType` parameter if the image is unedited (i.e. `quality` is 100, `correctOrientation` is false, and no `targetHeight` or `targetWidth` are specified). The `CAMERA` source will always return the JPEG file given by the native camera and the `PHOTOLIBRARY` and `SAVEDPHOTOALBUM` sources will return the selected file in its existing encoding. - BlackBerry 10 Quirks - -- Ignores the `quality` parameter. - -- Ignores the `allowEdit` parameter. - -- `Camera.MediaType` is not supported. - -- Ignores the `correctOrientation` parameter. - -- Ignores the `cameraDirection` parameter. - - Firefox OS Quirks - -- Ignores the `quality` parameter. - -- `Camera.DestinationType` is ignored and equals `1` (image file URI) - -- Ignores the `allowEdit` parameter. - -- Ignores the `PictureSourceType` parameter (user chooses it in a dialog window) - -- Ignores the `encodingType` - -- Ignores the `targetWidth` and `targetHeight` - -- `Camera.MediaType` is not supported. - -- Ignores the `correctOrientation` parameter. - -- Ignores the `cameraDirection` parameter. - iOS Quirks - When using `destinationType.FILE_URI`, photos are saved in the application's temporary directory. The contents of the application's temporary directory is deleted when the application ends. @@ -587,29 +520,6 @@ Tizen only supports a `destinationType` of - When using `destinationType.NATIVE_URI` and `sourceType.PHOTOLIBRARY` or `sourceType.SAVEDPHOTOALBUM`, all editing options are ignored and link is returned to original picture. - Tizen Quirks - -- options not supported - -- always returns a FILE URI - - Windows Phone 7 and 8 Quirks - -- Ignores the `allowEdit` parameter. - -- Ignores the `correctOrientation` parameter. - -- Ignores the `cameraDirection` parameter. - -- Ignores the `saveToPhotoAlbum` parameter. IMPORTANT: All images taken with the WP8/8 Cordova camera API are always copied to the phone's
[jira] [Commented] (CB-13661) Remove deprecated platforms from camera plugin
[ https://issues.apache.org/jira/browse/CB-13661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290207#comment-16290207 ] ASF subversion and git services commented on CB-13661: -- Commit 7fad5d5786822c3b5d2781a47599b51adf1e040b in cordova-plugin-camera's branch refs/heads/master from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=7fad5d5 ] CB-13661: Remove deprecated platforms > Remove deprecated platforms from camera plugin > -- > > Key: CB-13661 > URL: https://issues.apache.org/jira/browse/CB-13661 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13662) Remove deprecated platforms from inappbrowser plugin
[ https://issues.apache.org/jira/browse/CB-13662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290198#comment-16290198 ] ASF GitHub Bot commented on CB-13662: - stevengill closed pull request #253: CB-13662: remove deprecated platforms URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/253 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index a4b7cd92..2653394a 100644 --- a/README.md +++ b/README.md @@ -144,66 +144,23 @@ instance, or the system browser. ### Supported Platforms -- Amazon Fire OS - Android -- BlackBerry 10 - Browser -- Firefox OS - iOS - OSX -- Windows 8 and 8.1 -- Windows Phone 7 and 8 +- Windows ### Example var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes'); var ref2 = cordova.InAppBrowser.open(encodeURI('http://ja.m.wikipedia.org/wiki/ハングル'), '_blank', 'location=yes'); -### Firefox OS Quirks - -As plugin doesn't enforce any design there is a need to add some CSS rules if -opened with `target='_blank'`. The rules might look like these - -``` css -.inAppBrowserWrap { - background-color: rgba(0,0,0,0.75); - color: rgba(235,235,235,1.0); -} -.inAppBrowserWrap menu { - overflow: auto; - list-style-type: none; - padding-left: 0; -} -.inAppBrowserWrap menu li { - font-size: 25px; - height: 25px; - float: left; - margin: 0 10px; - padding: 3px 10px; - text-decoration: none; - color: #ccc; - display: block; - background: rgba(30,30,30,0.50); -} -.inAppBrowserWrap menu li.disabled { - color: #777; -} -``` - ### OSX Quirks At the moment the only supported target in OSX is `_system`. `_blank` and `_self` targets are not yet implemented and are ignored silently. Pull requests and patches to get these to work are greatly appreciated. -### Windows Quirks - -Windows 8.0, 8.1 and Windows Phone 8.1 don't support remote urls to be opened in the Cordova WebView so remote urls are always showed in the system's web browser if opened with `target='_self'`. - -On Windows 10 if the URL is NOT in the white list and is opened with `target='_self'` it will be showed in the system's web browser instead of InAppBrowser popup. - -Similar to Firefox OS IAB window visual behaviour can be overridden via `inAppBrowserWrap`/`inAppBrowserWrapFullscreen` CSS classes - ### Browser Quirks - Plugin is implemented via iframe, @@ -324,12 +281,11 @@ function executeScriptCallBack(params) { ### Supported Platforms -- Amazon Fire OS - Android - Browser - iOS -- Windows 8 and 8.1 -- Windows Phone 7 and 8 +- Windows +- OSX ### Browser Quirks @@ -360,12 +316,10 @@ The function is passed an `InAppBrowserEvent` object. ### Supported Platforms -- Amazon Fire OS - Android - Browser - iOS -- Windows 8 and 8.1 -- Windows Phone 7 and 8 +- Windows ### Quick Example @@ -384,13 +338,10 @@ The function is passed an `InAppBrowserEvent` object. ### Supported Platforms -- Amazon Fire OS - Android - Browser -- Firefox OS - iOS -- Windows 8 and 8.1 -- Windows Phone 7 and 8 +- Windows ### Quick Example @@ -407,11 +358,10 @@ The function is passed an `InAppBrowserEvent` object. ### Supported Platforms -- Amazon Fire OS - Android - Browser - iOS -- Windows 8 and 8.1 +- Windows ### Quick Example @@ -429,10 +379,9 @@ The function is passed an `InAppBrowserEvent` object. ### Supported Platforms -- Amazon Fire OS - Android - iOS -- Windows 8 and 8.1 +- Windows ### Quick Example @@ -461,11 +410,10 @@ The function is passed an `InAppBrowserEvent` object. ### Supported Platforms -- Amazon Fire OS - Android - Browser - iOS -- Windows 8 and 8.1 +- Windows ### Quick Example @@ -498,7 +446,6 @@ Due to [MSDN docs](https://msdn.microsoft.com/en-us/library/windows.ui.xaml.cont ### Supported Platforms -- Amazon Fire OS - Android - iOS - Windows diff --git a/package.json b/package.json index 06562054..e9f8a857 100644 --- a/package.json +++ b/package.json @@ -1,21 +1,16 @@ { "name": "cordova-plugin-inappbrowser", - "version": "1.7.3-dev", + "version": "2.0.0-dev", "description": "Cordova InAppBrowser Plugin", "types": "./types/index.d.ts", "cordova": { "id": "cordova-plugin-inappbrowser", "platforms": [ "android", - "amazon-fireos", - "ubuntu", + "browser", "ios", "osx", - "wp7", - "wp8", - "windows8", - "windows", - "firefoxos" + "windows" ] }, "repository": { @@ -33,15 +28,10 @@ "inappbrowser", "ecosystem:cordova", "cordova-android", -"cordova-amazon-fireos", -"cordova-ubuntu", +"cordova-browser", "cordova-ios",
[jira] [Commented] (CB-13662) Remove deprecated platforms from inappbrowser plugin
[ https://issues.apache.org/jira/browse/CB-13662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290199#comment-16290199 ] ASF subversion and git services commented on CB-13662: -- Commit 2c547a1a1ef934b36fe2a910f79313967de49209 in cordova-plugin-inappbrowser's branch refs/heads/master from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=2c547a1 ] CB-13662: remove deprecated platforms > Remove deprecated platforms from inappbrowser plugin > > > Key: CB-13662 > URL: https://issues.apache.org/jira/browse/CB-13662 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13678) Remove deprecated platforms from media plugin
[ https://issues.apache.org/jira/browse/CB-13678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290196#comment-16290196 ] ASF subversion and git services commented on CB-13678: -- Commit 33c7e3db1dcc84c19e40ee246f2539ae135933be in cordova-plugin-media's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-media.git;h=33c7e3d ] Merge pull request #157 from surajpindoria/removePlatforms CB-13678: Remove deprecated platforms > Remove deprecated platforms from media plugin > - > > Key: CB-13678 > URL: https://issues.apache.org/jira/browse/CB-13678 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13678) Remove deprecated platforms from media plugin
[ https://issues.apache.org/jira/browse/CB-13678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290194#comment-16290194 ] ASF GitHub Bot commented on CB-13678: - stevengill closed pull request #157: CB-13678: Remove deprecated platforms URL: https://github.com/apache/cordova-plugin-media/pull/157 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 991732e9..b5330c38 100644 --- a/README.md +++ b/README.md @@ -58,18 +58,10 @@ cordova plugin add cordova-plugin-media ## Supported Platforms - Android -- BlackBerry 10 - iOS -- Windows Phone 7 and 8 -- Tizen -- Windows 8 - Windows - Browser -## Windows Phone Quirks - -- Only one media file can be played back at a time. - ## Media ```js @@ -464,10 +456,6 @@ setTimeout(function() { }, 5000); ``` -### BlackBerry 10 Quirks - -- Not supported on BlackBerry OS 5 devices. - ## media.setVolume Set the volume for an audio file. @@ -525,7 +513,6 @@ Starts recording an audio file. - Android - iOS -- Windows Phone 7 and 8 - Windows ### Quick Example @@ -588,10 +575,6 @@ To add this entry into the `info.plist`, you can use the `edit-config` tag in th - Any subdirectory specified at record time must already exist. -### Tizen Quirks - -- Not supported on Tizen devices. - ## media.stop Stops playing an audio file. @@ -636,7 +619,6 @@ Stops recording an audio file. - Android - iOS -- Windows Phone 7 and 8 - Windows ### Quick Example @@ -668,10 +650,6 @@ function recordAudio() { } ``` -### Tizen Quirks - -- Not supported on Tizen devices. - ## MediaError A `MediaError` object is returned to the `mediaError` callback diff --git a/package.json b/package.json index 7cfae7f6..682fc8d1 100644 --- a/package.json +++ b/package.json @@ -1,21 +1,15 @@ { "name": "cordova-plugin-media", - "version": "4.0.1-dev", + "version": "5.0.0-dev", "description": "Cordova Media Plugin", "types": "./types/index.d.ts", "cordova": { "id": "cordova-plugin-media", "platforms": [ "android", - "amazon-fireos", - "ubuntu", + "browser", "ios", - "blackberry10", - "wp7", - "wp8", - "windows8", - "windows", - "tizen" + "windows" ] }, "repository": { @@ -30,15 +24,9 @@ "media", "ecosystem:cordova", "cordova-android", -"cordova-amazon-fireos", -"cordova-ubuntu", +"cordova-browser", "cordova-ios", -"cordova-blackberry10", -"cordova-wp7", -"cordova-wp8", -"cordova-windows8", -"cordova-windows", -"cordova-tizen" +"cordova-windows" ], "scripts": { "test": "npm run jshint", diff --git a/plugin.xml b/plugin.xml index ada69136..61ae3be0 100644 --- a/plugin.xml +++ b/plugin.xml @@ -21,7 +21,7 @@ http://apache.org/cordova/ns/plugins/1.0; xmlns:android="http://schemas.android.com/apk/res/android; id="cordova-plugin-media" -version="4.0.1-dev"> +version="5.0.0-dev"> Media Cordova Media Plugin @@ -64,39 +64,6 @@ id="cordova-plugin-media" - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -108,60 +75,6 @@ id="cordova-plugin-media" - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -173,13 +86,6 @@ id="cordova-plugin-media" - - - - - - - diff --git a/src/blackberry10/index.js b/src/blackberry10/index.js deleted file mode 100644 index e48fafa3.. --- a/src/blackberry10/index.js +++ /dev/null @@ -1,239 +0,0 @@ -/* - * - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the
[jira] [Commented] (CB-13678) Remove deprecated platforms from media plugin
[ https://issues.apache.org/jira/browse/CB-13678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290195#comment-16290195 ] ASF subversion and git services commented on CB-13678: -- Commit f299d0aa33b9e4848cc9cb9ad4f38de291386902 in cordova-plugin-media's branch refs/heads/master from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-media.git;h=f299d0a ] CB-13678: Remove deprecated platforms > Remove deprecated platforms from media plugin > - > > Key: CB-13678 > URL: https://issues.apache.org/jira/browse/CB-13678 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13673) Remove deprecated platforms from screen orientation plugin
[ https://issues.apache.org/jira/browse/CB-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290185#comment-16290185 ] ASF GitHub Bot commented on CB-13673: - stevengill commented on issue #27: CB-13673 : Remove deprecated platforms URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/27#issuecomment-351579097 Can you give the version a major bump like all the other prs This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated platforms from screen orientation plugin > -- > > Key: CB-13673 > URL: https://issues.apache.org/jira/browse/CB-13673 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13674) Tools Release Dec 12, 2017
[ https://issues.apache.org/jira/browse/CB-13674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290172#comment-16290172 ] ASF subversion and git services commented on CB-13674: -- Commit 8ad0a8b96736e9aaa5e63f66f353044f6aed5746 in cordova-lib's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=8ad0a8b ] CB-13674: updated pinned platforms > Tools Release Dec 12, 2017 > -- > > Key: CB-13674 > URL: https://issues.apache.org/jira/browse/CB-13674 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-12807) Improve error message for bad templates when using cordova create --template
[ https://issues.apache.org/jira/browse/CB-12807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-12807. -- Resolution: Fixed > Improve error message for bad templates when using cordova create --template > > > Key: CB-12807 > URL: https://issues.apache.org/jira/browse/CB-12807 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-create >Affects Versions: 1.1.1 >Reporter: Steve Gill >Assignee: Audrey So > Labels: cordova-8.0.0, triaged > > right now, we don't handle the error very well when you are using a invalid > template during cordova create --template sometemplate. We just spew out the > npm stack. It would be better if we could catch the error and provide a nicer > message to our users. Something along the lines of the template is invalid. > Make sure you follow the template guide when creating a template. (link to > template guide). Templates now require a package.json. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12807) Improve error message for bad templates when using cordova create --template
[ https://issues.apache.org/jira/browse/CB-12807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290149#comment-16290149 ] ASF subversion and git services commented on CB-12807: -- Commit cf633c2ee7ef46ee28d5baa4a53e71f84d9c894b in cordova-create's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-create.git;h=cf633c2 ] CB-12807 : updated error message to follow the template guide > Improve error message for bad templates when using cordova create --template > > > Key: CB-12807 > URL: https://issues.apache.org/jira/browse/CB-12807 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-create >Affects Versions: 1.1.1 >Reporter: Steve Gill >Assignee: Audrey So > Labels: cordova-8.0.0, triaged > > right now, we don't handle the error very well when you are using a invalid > template during cordova create --template sometemplate. We just spew out the > npm stack. It would be better if we could catch the error and provide a nicer > message to our users. Something along the lines of the template is invalid. > Make sure you follow the template guide when creating a template. (link to > template guide). Templates now require a package.json. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12807) Improve error message for bad templates when using cordova create --template
[ https://issues.apache.org/jira/browse/CB-12807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290152#comment-16290152 ] ASF GitHub Bot commented on CB-12807: - stevengill closed pull request #9: CB-12807 : updated error message to follow the template guide URL: https://github.com/apache/cordova-create/pull/9 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/index.js b/index.js index 827f158..cd1c2a6 100644 --- a/index.js +++ b/index.js @@ -210,7 +210,10 @@ module.exports = function(dir, optionalId, optionalName, cfg, extEvents) { events.emit('verbose', 'Using cordova-fetch for '+ target); return fetch(target, tempDest, {}) .fail(function(err){ -events.emit('error', '\033[1m \033[31m Error from Cordova Fetch: ' + err.message); +events.emit('verbose', '\033[1m \033[31m Error from Cordova Fetch: ' + err.message); +events.emit('error', 'The template you are trying to use is invalid.' + +' Make sure you follow the template guide found here https://cordova.apache.org/docs/en/latest/guide/cli/template.html.' + +' Templates now require a package.json.'); if (options.verbose) { console.trace(); } This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve error message for bad templates when using cordova create --template > > > Key: CB-12807 > URL: https://issues.apache.org/jira/browse/CB-12807 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-create >Affects Versions: 1.1.1 >Reporter: Steve Gill >Assignee: Audrey So > Labels: cordova-8.0.0, triaged > > right now, we don't handle the error very well when you are using a invalid > template during cordova create --template sometemplate. We just spew out the > npm stack. It would be better if we could catch the error and provide a nicer > message to our users. Something along the lines of the template is invalid. > Make sure you follow the template guide when creating a template. (link to > template guide). Templates now require a package.json. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12807) Improve error message for bad templates when using cordova create --template
[ https://issues.apache.org/jira/browse/CB-12807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290151#comment-16290151 ] ASF GitHub Bot commented on CB-12807: - stevengill commented on issue #9: CB-12807 : updated error message to follow the template guide URL: https://github.com/apache/cordova-create/pull/9#issuecomment-351570287 Merged This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve error message for bad templates when using cordova create --template > > > Key: CB-12807 > URL: https://issues.apache.org/jira/browse/CB-12807 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-create >Affects Versions: 1.1.1 >Reporter: Steve Gill >Assignee: Audrey So > Labels: cordova-8.0.0, triaged > > right now, we don't handle the error very well when you are using a invalid > template during cordova create --template sometemplate. We just spew out the > npm stack. It would be better if we could catch the error and provide a nicer > message to our users. Something along the lines of the template is invalid. > Make sure you follow the template guide when creating a template. (link to > template guide). Templates now require a package.json. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290137#comment-16290137 ] ASF GitHub Bot commented on CB-13055: - stevengill closed pull request #11: CB-13055: fixed failing tests in cordova-lib URL: https://github.com/apache/cordova-fetch/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.gitignore b/.gitignore index 3c3629e..d5f19d8 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1,2 @@ node_modules +package-lock.json diff --git a/index.js b/index.js index 9d77f04..c2510c9 100644 --- a/index.js +++ b/index.js @@ -84,7 +84,6 @@ module.exports = function (target, dest, opts) { }) .then(function (depTree) { tree1 = depTree; - // install new module return superspawn.spawn('npm', fetchArgs, opts); }) @@ -99,7 +98,6 @@ module.exports = function (target, dest, opts) { // Need to use trimID in that case. // This could happen on a platform update. var id = getJsonDiff(tree1, tree2) || trimID(target); - return module.exports.getPath(id, nodeModulesDir, target); }) .fail(function (err) { @@ -119,20 +117,25 @@ module.exports = function (target, dest, opts) { * */ function getJsonDiff (obj1, obj2) { -var result = ''; - +var result = []; // regex to filter out peer dependency warnings from result var re = /UNMET PEER DEPENDENCY/; for (var key in obj2) { // if it isn't a unmet peer dependency, continue if (key.search(re) === -1) { -if (obj2[key] !== obj1[key]) result = key; +if (obj2[key] !== obj1[key]) { +result.push(key); +} } } -return result; +if (result.length > 1) { +// something went wrong if we have more than one module installed at a time +return false; +} +// only return the first element +return result[0]; } - /* * Takes the specified target and returns the moduleID * If the git repoName is different than moduleID, then the This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290138#comment-16290138 ] ASF subversion and git services commented on CB-13055: -- Commit 1fd25de9caeaea29126b25fcc7745a3843f8da12 in cordova-fetch's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-fetch.git;h=1fd25de ] CB-13055: fixed failing tests in cordova-lib > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290139#comment-16290139 ] ASF subversion and git services commented on CB-13055: -- Commit a4bf668c5596056f9d030ff2bed0baa5122d4f70 in cordova-fetch's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-fetch.git;h=a4bf668 ] Merge pull request #11 from stevengill/master CB-13055: fixed failing tests in cordova-lib > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290128#comment-16290128 ] ASF subversion and git services commented on CB-13055: -- Commit 8f823f7e9136395403dd350d973f82814b4ebb1f in cordova-lib's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=8f823f7 ] CB-13055: fixed failing tests > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290126#comment-16290126 ] ASF subversion and git services commented on CB-13055: -- Commit 474a33bebdf30b73ad5067bcf94fec55027c4155 in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=474a33b ] CB-13055 : updated integration tests, removed lazy_load.js, removed gitclone and nofetch, and npm dependency > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290130#comment-16290130 ] ASF subversion and git services commented on CB-13055: -- Commit 99285c2580c1d583663eaad16c51f783180410bd in cordova-lib's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=99285c2 ] CB-13055: fixed failing tests > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290125#comment-16290125 ] ASF subversion and git services commented on CB-13055: -- Commit 6e22fb4c217d77d28b58ebe580fa4f998ee6d5e6 in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=6e22fb4 ] CB-13055 : updated after PR feedback This closes #608 > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13674) Tools Release Dec 12, 2017
[ https://issues.apache.org/jira/browse/CB-13674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290129#comment-16290129 ] ASF subversion and git services commented on CB-13674: -- Commit c374b7e4795da5df2277c51292c7616e67fd25e4 in cordova-lib's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=c374b7e ] CB-13674: updated cordova dependencies > Tools Release Dec 12, 2017 > -- > > Key: CB-13674 > URL: https://issues.apache.org/jira/browse/CB-13674 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290127#comment-16290127 ] ASF subversion and git services commented on CB-13055: -- Commit 99400b563bf7c0f39d993ea0ad868abc84be3990 in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=99400b5 ] CB-13055 : updated after PR feedback > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290124#comment-16290124 ] ASF subversion and git services commented on CB-13055: -- Commit ebcc3ff56f09e90e750407ea4393bafb9443bdb3 in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=ebcc3ff ] CB-13055 : updated integration tests, removed lazy_load.js, removed gitclone and nofetch, and npm dependency > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13673) Remove deprecated platforms from screen orientation plugin
[ https://issues.apache.org/jira/browse/CB-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290116#comment-16290116 ] ASF GitHub Bot commented on CB-13673: - purplecabbage commented on issue #26: CB-13673 : Removed deprecated platforms URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/26#issuecomment-351564470 Version bumps are part of the release process. That seems like a better place for this to happen. The release tooling already takes care of versioning afaik. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated platforms from screen orientation plugin > -- > > Key: CB-13673 > URL: https://issues.apache.org/jira/browse/CB-13673 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290082#comment-16290082 ] ASF GitHub Bot commented on CB-13055: - stevengill opened a new pull request #11: CB-13055: fixed failing tests in cordova-lib URL: https://github.com/apache/cordova-fetch/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13659) InAppBrowser: Add option to disable spinner on iOS
[ https://issues.apache.org/jira/browse/CB-13659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Merz updated CB-13659: - Flags: Patch Labels: newbie starter (was: ) > InAppBrowser: Add option to disable spinner on iOS > -- > > Key: CB-13659 > URL: https://issues.apache.org/jira/browse/CB-13659 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser >Reporter: Niklas Merz >Priority: Minor > Labels: newbie, starter > > Like mentioned in this pull request > [https://github.com/apache/cordova-plugin-inappbrowser/pull/89], the > inappbrowser needs flags to disable the loading spinner -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13659) InAppBrowser: Add option to disable spinner on iOS
[ https://issues.apache.org/jira/browse/CB-13659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290008#comment-16290008 ] Niklas Merz commented on CB-13659: -- I have submitted a PR which adds the option to disabe the spinner. I think adding the loading indicator to android should be done as a seperate issue and PR. > InAppBrowser: Add option to disable spinner on iOS > -- > > Key: CB-13659 > URL: https://issues.apache.org/jira/browse/CB-13659 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser >Reporter: Niklas Merz >Priority: Minor > > Like mentioned in this pull request > [https://github.com/apache/cordova-plugin-inappbrowser/pull/89], the > inappbrowser needs flags to disable the loading spinner -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13659) InAppBrowser: Add option to disable spinner on iOS
[ https://issues.apache.org/jira/browse/CB-13659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289963#comment-16289963 ] ASF GitHub Bot commented on CB-13659: - NiklasMerz opened a new pull request #254: CB-13659 (iOS) Add hidespinner option URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/254 Signed-off-by: Niklas Merz### Platforms affected iOS ### What does this PR do? It adds a new option to disabled the spinner which is displayed while loading. ### What testing has been done on this change? Run the test framework and manually testing the new option ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser: Add option to disable spinner on iOS > -- > > Key: CB-13659 > URL: https://issues.apache.org/jira/browse/CB-13659 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser >Reporter: Niklas Merz >Priority: Minor > > Like mentioned in this pull request > [https://github.com/apache/cordova-plugin-inappbrowser/pull/89], the > inappbrowser needs flags to disable the loading spinner -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13679) Plugins' privacy usage variables are not being transferred to plist
Josh Kapp created CB-13679: -- Summary: Plugins' privacy usage variables are not being transferred to plist Key: CB-13679 URL: https://issues.apache.org/jira/browse/CB-13679 Project: Apache Cordova Issue Type: Bug Components: cordova-cli Affects Versions: cordova-ios 4.5.0 Environment: Mac OS X 10.13.1, XCode 9.2, corodva-ios 4.5.4 Ionic 3.19.0 Reporter: Josh Kapp When building an ionic project with {{ionic cordova build ios --device --release}} the usage description values for the following plugins are not generated in the resulting plist. This was verified to work correctly in the same environment in previous versions of cordova (6.x). {{ ... }} As a workaround, these can be set explicitly via: {{ Rallyest would like to access your camera to capture photos and videos Rallyest would like to access photos and videos in your photo library }} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13677) Remove deprecated platforms for splash screen plugin
[ https://issues.apache.org/jira/browse/CB-13677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289769#comment-16289769 ] ASF GitHub Bot commented on CB-13677: - maverickmishra opened a new pull request #143: CB-13677: Remove deprecated platforms URL: https://github.com/apache/cordova-plugin-splashscreen/pull/143 ### Platforms affected Blackberry 10, Amazon Fire OS, Windows Phone 7 and 8, Ubuntu and Tizen ### What does this PR do? Removes deprecated platforms ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated platforms for splash screen plugin > > > Key: CB-13677 > URL: https://issues.apache.org/jira/browse/CB-13677 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13678) Remove deprecated platforms from media plugin
[ https://issues.apache.org/jira/browse/CB-13678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289765#comment-16289765 ] ASF GitHub Bot commented on CB-13678: - surajpindoria opened a new pull request #157: CB-13678: Remove deprecated platforms URL: https://github.com/apache/cordova-plugin-media/pull/157 ### Platforms affected Deprecated platforms ### What does this PR do? Remove deprecated platforms ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated platforms from media plugin > - > > Key: CB-13678 > URL: https://issues.apache.org/jira/browse/CB-13678 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13678) Remove deprecated platforms from media plugin
Suraj Pindoria created CB-13678: --- Summary: Remove deprecated platforms from media plugin Key: CB-13678 URL: https://issues.apache.org/jira/browse/CB-13678 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-media Reporter: Suraj Pindoria Assignee: Suraj Pindoria -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13677) Remove deprecated platforms for splash screen plugin
Vishal Mishra created CB-13677: -- Summary: Remove deprecated platforms for splash screen plugin Key: CB-13677 URL: https://issues.apache.org/jira/browse/CB-13677 Project: Apache Cordova Issue Type: Task Reporter: Vishal Mishra -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13677) Remove deprecated platforms for splash screen plugin
[ https://issues.apache.org/jira/browse/CB-13677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Mishra reassigned CB-13677: -- Assignee: Vishal Mishra > Remove deprecated platforms for splash screen plugin > > > Key: CB-13677 > URL: https://issues.apache.org/jira/browse/CB-13677 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13676) InAppBrowser event.url is always lowercase
[ https://issues.apache.org/jira/browse/CB-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) closed CB-13676. --- Resolution: Invalid Sure, let me know if you figure it out. Glad I could lead you into the (hopefully) right direction. > InAppBrowser event.url is always lowercase > -- > > Key: CB-13676 > URL: https://issues.apache.org/jira/browse/CB-13676 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser > Environment: osx 10.13, xcode 9.2, ios 11.2, cordova-ios@4.5.1, > cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, > cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1 >Reporter: Martin Birkby > > Hi, > Trying to implement OAuth for a custom OAuth provider. The token that is > returned contains Base64 encoded information which is lost as the event.url > from the InAppBrowser amends the redirect url to lowercase. In this case the > redirect url has ;token= appended to it. The below code replicates... > {code} > public secureDataLogin(): Promise { > return new Promise(function(resolve, reject) { > let csrf: string = uuid.v4(); > var url = 'http://111.111.11.111:8080/auth/oauth/2' + > '?response_type=token=' + csrf + '_uri=' + > 'http://www.google.com' + > '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; > var browserRef = window.cordova.InAppBrowser.open(url, "_blank", > "location=no"); > browserRef.addEventListener("loadstart", (event) => { > if ((event.url).indexOf('http://www.google.com') === 0) { > browserRef.removeEventListener("exit", (event) => {}); > browserRef.close(); > > // would decode and process the token data here > console.log(event.url); > } > }); > browserRef.addEventListener("loaderror", (event) => { > console.log('*ERROR*' + event.type + ' - ' + event.message); > }); > browserRef.addEventListener("exit", function(event) { > console.log("Browser exit called"); > }); > }); > } > {code} > Cheers > Martin -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13676) InAppBrowser event.url is always lowercase
[ https://issues.apache.org/jira/browse/CB-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289419#comment-16289419 ] Martin Birkby commented on CB-13676: I've just made a mock up of this scenario using a mock oath server and the problem doesn't seem to occur in that. Not sure where this issue is coming from but it doesn't appear to be from the InAppBrowser itself. Using the original OAuth server case is maintained when returning the redirect to normal browser but not when it is returning it to InAppBrowser via the event url. I think this needs more investigation on my part. I'm sure it's not event.url causing the issue for me at least. Apologies for taking up your time. Please close this issue, will report back once I've tracked down what is changing the case! Sorry! > InAppBrowser event.url is always lowercase > -- > > Key: CB-13676 > URL: https://issues.apache.org/jira/browse/CB-13676 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser > Environment: osx 10.13, xcode 9.2, ios 11.2, cordova-ios@4.5.1, > cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, > cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1 >Reporter: Martin Birkby > > Hi, > Trying to implement OAuth for a custom OAuth provider. The token that is > returned contains Base64 encoded information which is lost as the event.url > from the InAppBrowser amends the redirect url to lowercase. In this case the > redirect url has ;token= appended to it. The below code replicates... > {code} > public secureDataLogin(): Promise { > return new Promise(function(resolve, reject) { > let csrf: string = uuid.v4(); > var url = 'http://111.111.11.111:8080/auth/oauth/2' + > '?response_type=token=' + csrf + '_uri=' + > 'http://www.google.com' + > '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; > var browserRef = window.cordova.InAppBrowser.open(url, "_blank", > "location=no"); > browserRef.addEventListener("loadstart", (event) => { > if ((event.url).indexOf('http://www.google.com') === 0) { > browserRef.removeEventListener("exit", (event) => {}); > browserRef.close(); > > // would decode and process the token data here > console.log(event.url); > } > }); > browserRef.addEventListener("loaderror", (event) => { > console.log('*ERROR*' + event.type + ' - ' + event.message); > }); > browserRef.addEventListener("exit", function(event) { > console.log("Browser exit called"); > }); > }); > } > {code} > Cheers > Martin -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13676) InAppBrowser event.url is always lowercase
[ https://issues.apache.org/jira/browse/CB-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289393#comment-16289393 ] Jan Piotrowski (Sujan) commented on CB-13676: - Hm, any idea how to make a repro of this a bit simpler? I don't really want to build a OAuth backend just to replicate this ;) One could probably use something like bit.ly to "simulate" the login and redirect to such a URL. Could you please create a new, minimal reproduction app with `cordova create` that only includes the relevant code and put it on Github? Please also confirm this happens with the most recent `cordova-ios` version (4.5.4 I think) and without `cordova-plugin-ionic-webview`, to exclude both as a contributing factor. Thanks. > InAppBrowser event.url is always lowercase > -- > > Key: CB-13676 > URL: https://issues.apache.org/jira/browse/CB-13676 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser > Environment: osx 10.13, xcode 9.2, ios 11.2, cordova-ios@4.5.1, > cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, > cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1 >Reporter: Martin Birkby > > Hi, > Trying to implement OAuth for a custom OAuth provider. The token that is > returned contains Base64 encoded information which is lost as the event.url > from the InAppBrowser amends the redirect url to lowercase. In this case the > redirect url has ;token= appended to it. The below code replicates... > {code} > public secureDataLogin(): Promise { > return new Promise(function(resolve, reject) { > let csrf: string = uuid.v4(); > var url = 'http://111.111.11.111:8080/auth/oauth/2' + > '?response_type=token=' + csrf + '_uri=' + > 'http://www.google.com' + > '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; > var browserRef = window.cordova.InAppBrowser.open(url, "_blank", > "location=no"); > browserRef.addEventListener("loadstart", (event) => { > if ((event.url).indexOf('http://www.google.com') === 0) { > browserRef.removeEventListener("exit", (event) => {}); > browserRef.close(); > > // would decode and process the token data here > console.log(event.url); > } > }); > browserRef.addEventListener("loaderror", (event) => { > console.log('*ERROR*' + event.type + ' - ' + event.message); > }); > browserRef.addEventListener("exit", function(event) { > console.log("Browser exit called"); > }); > }); > } > {code} > Cheers > Martin -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13673) Remove deprecated platforms from screen orientation plugin
[ https://issues.apache.org/jira/browse/CB-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289382#comment-16289382 ] ASF GitHub Bot commented on CB-13673: - macdonst commented on issue #26: CB-13673 : Removed deprecated platforms URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/26#issuecomment-351423986 @purplecabbage we decided that all plugins that are removing platforms should be major releases. @maverickmishra and @surajpindoria are bumping all plugins that are being changed to the next major dev version. The version bump doesn't become official until we do a plugins release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated platforms from screen orientation plugin > -- > > Key: CB-13673 > URL: https://issues.apache.org/jira/browse/CB-13673 > Project: Apache Cordova > Issue Type: Task >Reporter: Vishal Mishra >Assignee: Vishal Mishra > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13676) InAppBrowser event.url is always lowercase
[ https://issues.apache.org/jira/browse/CB-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289376#comment-16289376 ] Martin Birkby commented on CB-13676: Correct, a callback from the OAuth service for a browser based app is http://localhost:4200/auth/oauth;token=eyJhbGciOiJSU0EyNTYiLCJraWQiOiJmYOTI0ZDNlMjE2YjQifQ.eyJhdWQizlkLTQ5OGOTI0ZDNlMjE2YjMiOiJmYTE0ZjZhNS0zMzlkLTQ5OGItYMjE2YjRAaWRlbnRpdHkuc2VjZG0iLCJzdWIiOiJmYTE00zMzlk In the event.url response the token is all lowercase > InAppBrowser event.url is always lowercase > -- > > Key: CB-13676 > URL: https://issues.apache.org/jira/browse/CB-13676 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser > Environment: osx 10.13, xcode 9.2, ios 11.2, cordova-ios@4.5.1, > cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, > cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1 >Reporter: Martin Birkby > > Hi, > Trying to implement OAuth for a custom OAuth provider. The token that is > returned contains Base64 encoded information which is lost as the event.url > from the InAppBrowser amends the redirect url to lowercase. In this case the > redirect url has ;token= appended to it. The below code replicates... > {code} > public secureDataLogin(): Promise { > return new Promise(function(resolve, reject) { > let csrf: string = uuid.v4(); > var url = 'http://111.111.11.111:8080/auth/oauth/2' + > '?response_type=token=' + csrf + '_uri=' + > 'http://www.google.com' + > '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; > var browserRef = window.cordova.InAppBrowser.open(url, "_blank", > "location=no"); > browserRef.addEventListener("loadstart", (event) => { > if ((event.url).indexOf('http://www.google.com') === 0) { > browserRef.removeEventListener("exit", (event) => {}); > browserRef.close(); > > // would decode and process the token data here > console.log(event.url); > } > }); > browserRef.addEventListener("loaderror", (event) => { > console.log('*ERROR*' + event.type + ' - ' + event.message); > }); > browserRef.addEventListener("exit", function(event) { > console.log("Browser exit called"); > }); > }); > } > {code} > Cheers > Martin -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13676) InAppBrowser event.url is always lowercase
[ https://issues.apache.org/jira/browse/CB-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289376#comment-16289376 ] Martin Birkby edited comment on CB-13676 at 12/13/17 3:17 PM: -- Correct, a callback from the OAuth service for a browser based app is http://localhost:4200/auth/oauth;token=eyJhbGciOiJSU0EyNTYiLCJraWQiOiJmYOTI0ZDNlMjE2YjQifQ0ZDNlMjE2YjMiOiJmYTE0ZjZhNS0zMzlkLTQ5OGItYMjE2YjRAaWRlbnRpdHkuc2VjZG0iLCJzdWIiOiJmYTE00zMzlk In the event.url response the token is all lowercase was (Author: scoobymib3): Correct, a callback from the OAuth service for a browser based app is http://localhost:4200/auth/oauth;token=eyJhbGciOiJSU0EyNTYiLCJraWQiOiJmYOTI0ZDNlMjE2YjQifQ.eyJhdWQizlkLTQ5OGOTI0ZDNlMjE2YjMiOiJmYTE0ZjZhNS0zMzlkLTQ5OGItYMjE2YjRAaWRlbnRpdHkuc2VjZG0iLCJzdWIiOiJmYTE00zMzlk In the event.url response the token is all lowercase > InAppBrowser event.url is always lowercase > -- > > Key: CB-13676 > URL: https://issues.apache.org/jira/browse/CB-13676 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser > Environment: osx 10.13, xcode 9.2, ios 11.2, cordova-ios@4.5.1, > cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, > cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1 >Reporter: Martin Birkby > > Hi, > Trying to implement OAuth for a custom OAuth provider. The token that is > returned contains Base64 encoded information which is lost as the event.url > from the InAppBrowser amends the redirect url to lowercase. In this case the > redirect url has ;token= appended to it. The below code replicates... > {code} > public secureDataLogin(): Promise { > return new Promise(function(resolve, reject) { > let csrf: string = uuid.v4(); > var url = 'http://111.111.11.111:8080/auth/oauth/2' + > '?response_type=token=' + csrf + '_uri=' + > 'http://www.google.com' + > '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; > var browserRef = window.cordova.InAppBrowser.open(url, "_blank", > "location=no"); > browserRef.addEventListener("loadstart", (event) => { > if ((event.url).indexOf('http://www.google.com') === 0) { > browserRef.removeEventListener("exit", (event) => {}); > browserRef.close(); > > // would decode and process the token data here > console.log(event.url); > } > }); > browserRef.addEventListener("loaderror", (event) => { > console.log('*ERROR*' + event.type + ' - ' + event.message); > }); > browserRef.addEventListener("exit", function(event) { > console.log("Browser exit called"); > }); > }); > } > {code} > Cheers > Martin -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13676) InAppBrowser event.url is always lowercase
[ https://issues.apache.org/jira/browse/CB-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289362#comment-16289362 ] Jan Piotrowski (Sujan) commented on CB-13676: - So `event.url` is lowercased although the server definitely did redirect to a URL with a token param containing also uppercase letters? > InAppBrowser event.url is always lowercase > -- > > Key: CB-13676 > URL: https://issues.apache.org/jira/browse/CB-13676 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser > Environment: osx 10.13, xcode 9.2, ios 11.2, cordova-ios@4.5.1, > cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, > cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1 >Reporter: Martin Birkby > > Hi, > Trying to implement OAuth for a custom OAuth provider. The token that is > returned contains Base64 encoded information which is lost as the event.url > from the InAppBrowser amends the redirect url to lowercase. In this case the > redirect url has ;token= appended to it. The below code replicates... > {code} > public secureDataLogin(): Promise { > return new Promise(function(resolve, reject) { > let csrf: string = uuid.v4(); > var url = 'http://111.111.11.111:8080/auth/oauth/2' + > '?response_type=token=' + csrf + '_uri=' + > 'http://www.google.com' + > '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; > var browserRef = window.cordova.InAppBrowser.open(url, "_blank", > "location=no"); > browserRef.addEventListener("loadstart", (event) => { > if ((event.url).indexOf('http://www.google.com') === 0) { > browserRef.removeEventListener("exit", (event) => {}); > browserRef.close(); > > // would decode and process the token data here > console.log(event.url); > } > }); > browserRef.addEventListener("loaderror", (event) => { > console.log('*ERROR*' + event.type + ' - ' + event.message); > }); > browserRef.addEventListener("exit", function(event) { > console.log("Browser exit called"); > }); > }); > } > {code} > Cheers > Martin -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13676) InAppBrowser event.url is always lowercase
[ https://issues.apache.org/jira/browse/CB-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13676: Description: Hi, Trying to implement OAuth for a custom OAuth provider. The token that is returned contains Base64 encoded information which is lost as the event.url from the InAppBrowser amends the redirect url to lowercase. In this case the redirect url has ;token= appended to it. The below code replicates... {code} public secureDataLogin(): Promise { return new Promise(function(resolve, reject) { let csrf: string = uuid.v4(); var url = 'http://111.111.11.111:8080/auth/oauth/2' + '?response_type=token=' + csrf + '_uri=' + 'http://www.google.com' + '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; var browserRef = window.cordova.InAppBrowser.open(url, "_blank", "location=no"); browserRef.addEventListener("loadstart", (event) => { if ((event.url).indexOf('http://www.google.com') === 0) { browserRef.removeEventListener("exit", (event) => {}); browserRef.close(); // would decode and process the token data here console.log(event.url); } }); browserRef.addEventListener("loaderror", (event) => { console.log('*ERROR*' + event.type + ' - ' + event.message); }); browserRef.addEventListener("exit", function(event) { console.log("Browser exit called"); }); }); } {code} Cheers Martin was: Hi, Trying to implement OAuth for a custom OAuth provider. The token that is returned contains Base64 encoded information which is lost as the event.url from the InAppBrowser amends the redirect url to lowercase. In this case the redirect url has ;token= appended to it. The below code replicates... public secureDataLogin(): Promise { return new Promise(function(resolve, reject) { let csrf: string = uuid.v4(); var url = 'http://111.111.11.111:8080/auth/oauth/2' + '?response_type=token=' + csrf + '_uri=' + 'http://www.google.com' + '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; var browserRef = window.cordova.InAppBrowser.open(url, "_blank", "location=no"); browserRef.addEventListener("loadstart", (event) => { if ((event.url).indexOf('http://www.google.com') === 0) { browserRef.removeEventListener("exit", (event) => {}); browserRef.close(); // would decode and process the token data here console.log(event.url); } }); browserRef.addEventListener("loaderror", (event) => { console.log('*ERROR*' + event.type + ' - ' + event.message); }); browserRef.addEventListener("exit", function(event) { console.log("Browser exit called"); }); }); } Cheers Martin > InAppBrowser event.url is always lowercase > -- > > Key: CB-13676 > URL: https://issues.apache.org/jira/browse/CB-13676 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser > Environment: osx 10.13, xcode 9.2, ios 11.2, cordova-ios@4.5.1, > cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, > cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1 >Reporter: Martin Birkby > > Hi, > Trying to implement OAuth for a custom OAuth provider. The token that is > returned contains Base64 encoded information which is lost as the event.url > from the InAppBrowser amends the redirect url to lowercase. In this case the > redirect url has ;token= appended to it. The below code replicates... > {code} > public secureDataLogin(): Promise { > return new Promise(function(resolve, reject) { > let csrf: string = uuid.v4(); > var url = 'http://111.111.11.111:8080/auth/oauth/2' + > '?response_type=token=' + csrf + '_uri=' + > 'http://www.google.com' + > '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; > var browserRef = window.cordova.InAppBrowser.open(url, "_blank", > "location=no"); > browserRef.addEventListener("loadstart", (event) => { > if ((event.url).indexOf('http://www.google.com') === 0) { > browserRef.removeEventListener("exit", (event) => {}); > browserRef.close(); > > // would decode and process the token data here > console.log(event.url); > } > }); > browserRef.addEventListener("loaderror", (event) => { > console.log('*ERROR*' + event.type + ' - ' + event.message); >
[jira] [Updated] (CB-13676) InAppBrowser event.url is always lowercase
[ https://issues.apache.org/jira/browse/CB-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Birkby updated CB-13676: --- Environment: osx 10.13, xcode 9.2, ios 11.2, cordova-ios@4.5.1, cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1 (was: osx 10.13, xcode 9.2, cordova-ios@4.5.1, cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1) > InAppBrowser event.url is always lowercase > -- > > Key: CB-13676 > URL: https://issues.apache.org/jira/browse/CB-13676 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser > Environment: osx 10.13, xcode 9.2, ios 11.2, cordova-ios@4.5.1, > cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, > cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1 >Reporter: Martin Birkby > > Hi, > Trying to implement OAuth for a custom OAuth provider. The token that is > returned contains Base64 encoded information which is lost as the event.url > from the InAppBrowser amends the redirect url to lowercase. In this case the > redirect url has ;token= appended to it. The below code replicates... > public secureDataLogin(): Promise { > return new Promise(function(resolve, reject) { > let csrf: string = uuid.v4(); > var url = 'http://111.111.11.111:8080/auth/oauth/2' + > '?response_type=token=' + csrf + '_uri=' + > 'http://www.google.com' + > '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; > var browserRef = window.cordova.InAppBrowser.open(url, "_blank", > "location=no"); > browserRef.addEventListener("loadstart", (event) => { > if ((event.url).indexOf('http://www.google.com') === 0) { > browserRef.removeEventListener("exit", (event) => {}); > browserRef.close(); > > // would decode and process the token data here > console.log(event.url); > } > }); > browserRef.addEventListener("loaderror", (event) => { > console.log('*ERROR*' + event.type + ' - ' + event.message); > }); > browserRef.addEventListener("exit", function(event) { > console.log("Browser exit called"); > }); > }); > } > Cheers > Martin -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13676) InAppBrowser event.url is always lowercase
[ https://issues.apache.org/jira/browse/CB-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Birkby updated CB-13676: --- Description: Hi, Trying to implement OAuth for a custom OAuth provider. The token that is returned contains Base64 encoded information which is lost as the event.url from the InAppBrowser amends the redirect url to lowercase. In this case the redirect url has ;token= appended to it. The below code replicates... public secureDataLogin(): Promise { return new Promise(function(resolve, reject) { let csrf: string = uuid.v4(); var url = 'http://111.111.11.111:8080/auth/oauth/2' + '?response_type=token=' + csrf + '_uri=' + 'http://www.google.com' + '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; var browserRef = window.cordova.InAppBrowser.open(url, "_blank", "location=no"); browserRef.addEventListener("loadstart", (event) => { if ((event.url).indexOf('http://www.google.com') === 0) { browserRef.removeEventListener("exit", (event) => {}); browserRef.close(); // would decode and process the token data here console.log(event.url); } }); browserRef.addEventListener("loaderror", (event) => { console.log('*ERROR*' + event.type + ' - ' + event.message); }); browserRef.addEventListener("exit", function(event) { console.log("Browser exit called"); }); }); } Cheers Martin was: Hi, Trying to implement OAuth for a custom OAuth provider. The token that is returned contains Base64 encoded information which is lost as the event.url from the InAppBrowser amends the redirect url to lowercase. In this case the redirect url has ;token= appended to it. The below code replicates... public secureDataLogin(): Promise { return new Promise(function(resolve, reject) { let csrf: string = uuid.v4(); sessionStorage.setItem('csrf', csrf); var url = 'http://111.111.11.111:8080/auth/oauth/2' + '?response_type=token=' + csrf + '_uri=' + 'http://www.google.com' + '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; var browserRef = window.cordova.InAppBrowser.open(url, "_blank", "location=no"); browserRef.addEventListener("loadstart", (event) => { if ((event.url).indexOf('http://www.google.com') === 0) { browserRef.removeEventListener("exit", (event) => {}); browserRef.close(); // would decode and process the token data here console.log(event.url); } }); browserRef.addEventListener("loaderror", (event) => { console.log('*ERROR*' + event.type + ' - ' + event.message); }); browserRef.addEventListener("exit", function(event) { console.log("Browser exit called"); }); }); } Cheers Martin > InAppBrowser event.url is always lowercase > -- > > Key: CB-13676 > URL: https://issues.apache.org/jira/browse/CB-13676 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser > Environment: osx 10.13, xcode 9.2, cordova-ios@4.5.1, > cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, > cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1 >Reporter: Martin Birkby > > Hi, > Trying to implement OAuth for a custom OAuth provider. The token that is > returned contains Base64 encoded information which is lost as the event.url > from the InAppBrowser amends the redirect url to lowercase. In this case the > redirect url has ;token= appended to it. The below code replicates... > public secureDataLogin(): Promise { > return new Promise(function(resolve, reject) { > let csrf: string = uuid.v4(); > var url = 'http://111.111.11.111:8080/auth/oauth/2' + > '?response_type=token=' + csrf + '_uri=' + > 'http://www.google.com' + > '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; > var browserRef = window.cordova.InAppBrowser.open(url, "_blank", > "location=no"); > browserRef.addEventListener("loadstart", (event) => { > if ((event.url).indexOf('http://www.google.com') === 0) { > browserRef.removeEventListener("exit", (event) => {}); > browserRef.close(); > > // would decode and process the token data here > console.log(event.url); > } > }); > browserRef.addEventListener("loaderror", (event) => { > console.log('*ERROR*' + event.type + ' - ' + event.message); > }); >
[jira] [Created] (CB-13676) InAppBrowser event.url is always lowercase
Martin Birkby created CB-13676: -- Summary: InAppBrowser event.url is always lowercase Key: CB-13676 URL: https://issues.apache.org/jira/browse/CB-13676 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-inappbrowser Environment: osx 10.13, xcode 9.2, cordova-ios@4.5.1, cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1 Reporter: Martin Birkby Hi, Trying to implement OAuth for a custom OAuth provider. The token that is returned contains Base64 encoded information which is lost as the event.url from the InAppBrowser amends the redirect url to lowercase. In this case the redirect url has ;token= appended to it. The below code replicates... public secureDataLogin(): Promise { return new Promise(function(resolve, reject) { let csrf: string = uuid.v4(); sessionStorage.setItem('csrf', csrf); var url = 'http://111.111.11.111:8080/auth/oauth/2' + '?response_type=token=' + csrf + '_uri=' + 'http://www.google.com' + '=profile_id=a1aa-123a-132a-1a11-ab12345678ab'; var browserRef = window.cordova.InAppBrowser.open(url, "_blank", "location=no"); browserRef.addEventListener("loadstart", (event) => { if ((event.url).indexOf('http://www.google.com') === 0) { browserRef.removeEventListener("exit", (event) => {}); browserRef.close(); // would decode and process the token data here console.log(event.url); } }); browserRef.addEventListener("loaderror", (event) => { console.log('*ERROR*' + event.type + ' - ' + event.message); }); browserRef.addEventListener("exit", function(event) { console.log("Browser exit called"); }); }); } Cheers Martin -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13580) cordova-android 6.4.0 broke build if cdvBuildMultipleApks is set to true
[ https://issues.apache.org/jira/browse/CB-13580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289135#comment-16289135 ] ASF GitHub Bot commented on CB-13580: - Robula commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors) URL: https://github.com/apache/cordova-android/pull/417#issuecomment-351364568 Did this affect the output path to APKs? I'm seeing that the the output is now: `build/outputs/apk/release/android-release.apk` Where previously it was: `build/outputs/apk/android-release.apk` I've created an issue in the relevant place where I am experiencing problems. https://github.com/Microsoft/vsts-cordova-tasks/issues/81 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-android 6.4.0 broke build if cdvBuildMultipleApks is set to true > > > Key: CB-13580 > URL: https://issues.apache.org/jira/browse/CB-13580 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 6.4.0 >Reporter: David Strauß >Assignee: Joe Bowser > Labels: build > > With the latest cordova-android (6.4.0) builds for different product flavors > (arm, x86) do not work anymore (error e.g.: "No flavor is associated with > flavor dimension ...") because of the changes introduced with gradle 3.0.0. > With the new gradle plugin a flavorDimenson must be specified to build > different product flavors (mentioned > [here|https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html?utm_source=android-studio#flavor_dimensions] > in the upgrade guide. This can be fixed by adding `flavorDimensions > "default"` to build.gradle if cdvBuildMultipleApks is set to true. > Another change that was introduced with the new gradle version is that builds > for different architectures are put into their own directory > (build/outputs/apk//) which results in APK files not > being found (mentioned in the upgrade guide under the point "Modifying > variant outputs at build time may not work"). > This can be fixed by adapting the findOutputApksHelper method in > GenericBuilder.js. > An unfortunate side effect of these issues is that projects leveraging > crosswalk do not work anymore. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13675) cordova-plugin-network-information reports type === NONE when connected through 3G/4G on iOS 11
[ https://issues.apache.org/jira/browse/CB-13675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques L. CHEREAU updated CB-13675: Description: When an iPhone (SE) with iOS 11.2 is disconnected from WIFI *+but connected to a CELL network+* (Vodafone UK) either; * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE instead of Connection.CELLxxx # Upon launching such cordova/phonegap app an offline event is triggered This issue has also been reported by someone else in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. was: When an iPhone SE with iOS 11.2 is disconnected from WIFI *+but connected to a CELL network+* (Vodafone UK) either; * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE instead of Connection.CELLxxx # Upon launching such cordova/phonegap app an offline event is triggered This issue has also been reported by someone else in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. > cordova-plugin-network-information reports type === NONE when connected > through 3G/4G on iOS 11 > --- > > Key: CB-13675 > URL: https://issues.apache.org/jira/browse/CB-13675 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlugins >Affects Versions: cordova-ios@4.4.0, cordova-ios@4.3.1 > Environment: iPhone SE > iOS 11.2 > Vodafone UK + WiFi > Phonegap Cli 6.5.0 and 7.0.1 > cordova-ios 4.3.1 and 4.4.0 > cordova-plugin-network-information 1.3.4 >Reporter: Jacques L. CHEREAU > > When an iPhone (SE) with iOS 11.2 is disconnected from WIFI *+but connected > to a CELL network+* (Vodafone UK) either; > * by being out of reach of a WIFI network, or > * by forgetting the WIFI network in iOS settings or > * by disabling WIFI in the iOS control panel: > then > # A cordova/phonegap app reports navigator.connection.type === > Connection.NONE instead of Connection.CELLxxx > # Upon launching such cordova/phonegap app an offline event is triggered > > This issue has also been reported by someone else in the ionic forums > [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13675) cordova-plugin-network-information reports type === NONE when connected through 3G/4G on iOS 11
[ https://issues.apache.org/jira/browse/CB-13675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques L. CHEREAU updated CB-13675: Description: When an iPhone SE with iOS 11.2 is disconnected from WIFI *+but connected to a CELL network+* (Vodafone UK) either; * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE instead of Connection.CELLxxx # Upon launching such cordova/phonegap app an offline event is triggered This issue has also been reported by someone else in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. was: When an iPhone SE with iOS 11.2 is disconnected from WIFI *+but connected to a CELL network+* (Vodafone UK) either; * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE instead of Connection.CELLxxx # Upon launching such cordova/phonegap app an offline event is triggered This issue has also been reported in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. > cordova-plugin-network-information reports type === NONE when connected > through 3G/4G on iOS 11 > --- > > Key: CB-13675 > URL: https://issues.apache.org/jira/browse/CB-13675 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlugins >Affects Versions: cordova-ios@4.4.0, cordova-ios@4.3.1 > Environment: iPhone SE > iOS 11.2 > Vodafone UK + WiFi > Phonegap Cli 6.5.0 and 7.0.1 > cordova-ios 4.3.1 and 4.4.0 > cordova-plugin-network-information 1.3.4 >Reporter: Jacques L. CHEREAU > > When an iPhone SE with iOS 11.2 is disconnected from WIFI *+but connected to > a CELL network+* (Vodafone UK) either; > * by being out of reach of a WIFI network, or > * by forgetting the WIFI network in iOS settings or > * by disabling WIFI in the iOS control panel: > then > # A cordova/phonegap app reports navigator.connection.type === > Connection.NONE instead of Connection.CELLxxx > # Upon launching such cordova/phonegap app an offline event is triggered > > This issue has also been reported by someone else in the ionic forums > [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13675) cordova-plugin-network-information reports type === NONE when connected through 3G/4G on iOS 11
[ https://issues.apache.org/jira/browse/CB-13675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques L. CHEREAU updated CB-13675: Description: When an iPhone SE with iOS 11.2 is disconnected from WIFI *+but connected to a CELL network+* (Vodafone UK) either; * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE instead of Connection.CELLxxx # Upon launching such cordova/phonegap app an offline event is triggered This issue has also been reported in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. was: When an iPhone SE with iOS 11.2 is disconnected from WIFI *+but connected to a CELL network+* (Vodafone UK) either; * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE # Upon launching such cordova/phonegap app an offline event is triggered This issue has also been reported in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. > cordova-plugin-network-information reports type === NONE when connected > through 3G/4G on iOS 11 > --- > > Key: CB-13675 > URL: https://issues.apache.org/jira/browse/CB-13675 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlugins >Affects Versions: cordova-ios@4.4.0, cordova-ios@4.3.1 > Environment: iPhone SE > iOS 11.2 > Vodafone UK + WiFi > Phonegap Cli 6.5.0 and 7.0.1 > cordova-ios 4.3.1 and 4.4.0 > cordova-plugin-network-information 1.3.4 >Reporter: Jacques L. CHEREAU > > When an iPhone SE with iOS 11.2 is disconnected from WIFI *+but connected to > a CELL network+* (Vodafone UK) either; > * by being out of reach of a WIFI network, or > * by forgetting the WIFI network in iOS settings or > * by disabling WIFI in the iOS control panel: > then > # A cordova/phonegap app reports navigator.connection.type === > Connection.NONE instead of Connection.CELLxxx > # Upon launching such cordova/phonegap app an offline event is triggered > > This issue has also been reported in the ionic forums > [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13675) cordova-plugin-network-information reports type === NONE when connected through 3G/4G on iOS 11
[ https://issues.apache.org/jira/browse/CB-13675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques L. CHEREAU updated CB-13675: Description: When an iPhone SE with iOS 11.2 is disconnected from WIFI *+but connected to a CELL network+* (Vodafone UK) either; * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE # Upon launching such cordova/phonegap app an offline event is triggered This issue has also been reported in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. was: When an iPhone SE with iOS 11.2 is disconnected from WIFI but connected to a CELL network (Vodafone UK) either; * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE # Upon launching such cordova/phonegap app an offline event is triggered This issue has also been reported in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. > cordova-plugin-network-information reports type === NONE when connected > through 3G/4G on iOS 11 > --- > > Key: CB-13675 > URL: https://issues.apache.org/jira/browse/CB-13675 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlugins >Affects Versions: cordova-ios@4.4.0, cordova-ios@4.3.1 > Environment: iPhone SE > iOS 11.2 > Vodafone UK + WiFi > Phonegap Cli 6.5.0 and 7.0.1 > cordova-ios 4.3.1 and 4.4.0 > cordova-plugin-network-information 1.3.4 >Reporter: Jacques L. CHEREAU > > When an iPhone SE with iOS 11.2 is disconnected from WIFI *+but connected to > a CELL network+* (Vodafone UK) either; > * by being out of reach of a WIFI network, or > * by forgetting the WIFI network in iOS settings or > * by disabling WIFI in the iOS control panel: > then > # A cordova/phonegap app reports navigator.connection.type === Connection.NONE > # Upon launching such cordova/phonegap app an offline event is triggered > > This issue has also been reported in the ionic forums > [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13675) cordova-plugin-network-information reports type === NONE when connected through 3G/4G on iOS 11
[ https://issues.apache.org/jira/browse/CB-13675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques L. CHEREAU updated CB-13675: Description: When an iPhone SE with iOS 11.2 is disconnected from WIFI but connected to a CELL network (Vodafone UK) either; * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE # Upon launching such cordova/phonegap app an offline event is triggered This issue has also been reported in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. was: When an iPhone SE with iOS 11.2 is disconnected from WIFI but connected to a CELL network (Vodafone UK) either; * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE # Upon launching such cordova/phonegap app an offline event is triggered # navigator.onLine is false (which might suggest a UIWebWiew/iOS issue rather than a Cordova issue) This issue has also been reported in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. > cordova-plugin-network-information reports type === NONE when connected > through 3G/4G on iOS 11 > --- > > Key: CB-13675 > URL: https://issues.apache.org/jira/browse/CB-13675 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlugins >Affects Versions: cordova-ios@4.4.0, cordova-ios@4.3.1 > Environment: iPhone SE > iOS 11.2 > Vodafone UK + WiFi > Phonegap Cli 6.5.0 and 7.0.1 > cordova-ios 4.3.1 and 4.4.0 > cordova-plugin-network-information 1.3.4 >Reporter: Jacques L. CHEREAU > > When an iPhone SE with iOS 11.2 is disconnected from WIFI but connected to a > CELL network (Vodafone UK) either; > * by being out of reach of a WIFI network, or > * by forgetting the WIFI network in iOS settings or > * by disabling WIFI in the iOS control panel: > then > # A cordova/phonegap app reports navigator.connection.type === Connection.NONE > # Upon launching such cordova/phonegap app an offline event is triggered > > This issue has also been reported in the ionic forums > [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13659) InAppBrowser: Add option to disable spinner on iOS
[ https://issues.apache.org/jira/browse/CB-13659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289007#comment-16289007 ] Jan Piotrowski (Sujan) commented on CB-13659: - As this PR indicates what work is left to do (solve conflicts) to get this merged, feel free to redo that PR and directly include the suggested functionality from above. > InAppBrowser: Add option to disable spinner on iOS > -- > > Key: CB-13659 > URL: https://issues.apache.org/jira/browse/CB-13659 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser >Reporter: Niklas Merz >Priority: Minor > > Like mentioned in this pull request > [https://github.com/apache/cordova-plugin-inappbrowser/pull/89], the > inappbrowser needs flags to disable the loading spinner -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13675) cordova-plugin-network-information reports type === NONE when connected through 3G/4G on iOS 11
[ https://issues.apache.org/jira/browse/CB-13675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques L. CHEREAU updated CB-13675: Description: When an iPhone SE with iOS 11.2 is disconnected from WIFI but connected to a CELL network (Vodafone UK) either; * * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE # Upon launching such cordova/phonegap app an offline event is triggered # navigator.onLine is false (which might suggest a UIWebWiew/iOS issue rather than a Cordova issue) This issue has also been reported in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. was: When an iPhone SE with iOS 11.2 is disconnected from WIFI but connected to a CELL network (Vodafone UK) either by being out of reach of a WIFI network, or by forgetting the WIFI network in iOS settings or by disabling WIFI in the iOS control panel: 1) A cordova/phonegap app reports navigator.connection.type as NONE 2) Upon launching the cordova app an offline event is triggered 3) navigator.onLine is false (which might suggest a UIWebWiew/iOS issue rather than a Cordova issue) This issue has also been reported on the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. > cordova-plugin-network-information reports type === NONE when connected > through 3G/4G on iOS 11 > --- > > Key: CB-13675 > URL: https://issues.apache.org/jira/browse/CB-13675 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlugins >Affects Versions: cordova-ios@4.4.0, cordova-ios@4.3.1 > Environment: iPhone SE > iOS 11.2 > Vodafone UK + WiFi > Phonegap Cli 6.5.0 and 7.0.1 > cordova-ios 4.3.1 and 4.4.0 > cordova-plugin-network-information 1.3.4 >Reporter: Jacques L. CHEREAU > > When an iPhone SE with iOS 11.2 is disconnected from WIFI but connected to a > CELL network (Vodafone UK) either; > * * by being out of reach of a WIFI network, or > * by forgetting the WIFI network in iOS settings or > * by disabling WIFI in the iOS control panel: > then > # A cordova/phonegap app reports navigator.connection.type === Connection.NONE > # Upon launching such cordova/phonegap app an offline event is triggered > # navigator.onLine is false (which might suggest a UIWebWiew/iOS issue rather > than a Cordova issue) > > This issue has also been reported in the ionic forums > [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13675) cordova-plugin-network-information reports type === NONE when connected through 3G/4G on iOS 11
[ https://issues.apache.org/jira/browse/CB-13675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques L. CHEREAU updated CB-13675: Description: When an iPhone SE with iOS 11.2 is disconnected from WIFI but connected to a CELL network (Vodafone UK) either; * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE # Upon launching such cordova/phonegap app an offline event is triggered # navigator.onLine is false (which might suggest a UIWebWiew/iOS issue rather than a Cordova issue) This issue has also been reported in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. was: When an iPhone SE with iOS 11.2 is disconnected from WIFI but connected to a CELL network (Vodafone UK) either; * * by being out of reach of a WIFI network, or * by forgetting the WIFI network in iOS settings or * by disabling WIFI in the iOS control panel: then # A cordova/phonegap app reports navigator.connection.type === Connection.NONE # Upon launching such cordova/phonegap app an offline event is triggered # navigator.onLine is false (which might suggest a UIWebWiew/iOS issue rather than a Cordova issue) This issue has also been reported in the ionic forums [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. > cordova-plugin-network-information reports type === NONE when connected > through 3G/4G on iOS 11 > --- > > Key: CB-13675 > URL: https://issues.apache.org/jira/browse/CB-13675 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlugins >Affects Versions: cordova-ios@4.4.0, cordova-ios@4.3.1 > Environment: iPhone SE > iOS 11.2 > Vodafone UK + WiFi > Phonegap Cli 6.5.0 and 7.0.1 > cordova-ios 4.3.1 and 4.4.0 > cordova-plugin-network-information 1.3.4 >Reporter: Jacques L. CHEREAU > > When an iPhone SE with iOS 11.2 is disconnected from WIFI but connected to a > CELL network (Vodafone UK) either; > * by being out of reach of a WIFI network, or > * by forgetting the WIFI network in iOS settings or > * by disabling WIFI in the iOS control panel: > then > # A cordova/phonegap app reports navigator.connection.type === Connection.NONE > # Upon launching such cordova/phonegap app an offline event is triggered > # navigator.onLine is false (which might suggest a UIWebWiew/iOS issue rather > than a Cordova issue) > > This issue has also been reported in the ionic forums > [https://forum.ionicframework.com/t/cordova-network-plugin-is-not-working-in-ios-version-11-but-was-working-in-version-10/111326]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org