[jira] [Commented] (CB-13787) Cordova plugin screen orientation iOS not locking view correctly

2018-01-30 Thread Adrian Jarc (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346380#comment-16346380
 ] 

Adrian Jarc commented on CB-13787:
--

So no work is going to be done on that?

> Cordova plugin screen orientation iOS not locking view correctly
> 
>
> Key: CB-13787
> URL: https://issues.apache.org/jira/browse/CB-13787
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: iPhone 6S iOS 11.2.1
> cordova-plugin-screen-orientation@3.0.1 and lower
> Ionic v1.7.16
>  Cordova v6.5.0
>  
>  
>  
>Reporter: Adrian Jarc
>Priority: Major
> Attachments: ScreenOrientation Bug.mp4
>
>
> Bug happens if you have an app that is locked to portrait mode and have a 
> component that temporarily turns the app into landscape. While iPhone is 
> turned to portrait mode it works normally but once you turn it to landscape 
> (from view that is locked to portrait) and fire the component that is 
> supposed to turn the app to landscape the app doesn't turn. Similar bug 
> happens when turning the app back to portrait.
> See the video for full bug replication demonstration.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-12007) Build does fail / Could not resolve com.android.tools.build:gradle:2.1.0

2018-01-30 Thread jcesarmobile (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-12007.
-
Resolution: Cannot Reproduce

Can't reproduce with latest version, it's probably fixed.
Please, if you still find problems with latest Cordova create a new issue.

> Build does fail / Could not resolve com.android.tools.build:gradle:2.1.0
> 
>
> Key: CB-12007
> URL: https://issues.apache.org/jira/browse/CB-12007
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Reporter: Sven Siwek
>Priority: Major
>
> I try to build simple kitchensink demo/template.
> C:\Users\siw\workspace_neon\examples\kitchensink-cordova>cordova build 
> android -
> -release --verbose
> No scripts found for hook "before_build".
> No scripts found for hook "before_prepare".
> Checking config.xml for saved platforms that haven't been added to the project
> Checking for any plugins added to the project that have not been installed in 
> an
> droid platform
> No differences found between plugins added to project and installed in 
> android p
> latform. Continuing...
> Generating platform-specific config.xml from defaults for android at 
> C:\Users\si
> w\workspace_neon\examples\kitchensink-cordova\platforms\android\res\xml\config.x
> ml
> Merging project's config.xml into platform-specific android config.xml
> Merging and updating files from [www, platforms\android\platform_www] to 
> platfor
> ms\android\assets\www
> Wrote out android application name "kitchensink-cordova" to 
> C:\Users\siw\workspa
> ce_neon\examples\kitchensink-cordova\platforms\android\res\values\strings.xml
> android-versionCode not found in config.xml. Generating a code based on 
> version
> in config.xml (2.0.0): 2
> Wrote out Android package name "org.jboss.quickstarts.wfk.kitchensinkcordova" 
> to
>  
> C:\Users\siw\workspace_neon\examples\kitchensink-cordova\platforms\android\src\
> org\jboss\quickstarts\wfk\kitchensinkcordova\MainActivity.java
> This app does not have launcher icons defined
> This app does not have splash screens defined
> Prepared android project successfully
> No scripts found for hook "after_prepare".
> Checking config.xml for saved plugins that haven't been added to the project
> No scripts found for hook "before_compile".
> ANDROID_HOME=C:\Users\siw\android-sdks
> JAVA_HOME=C:\Program Files\java\jdk1.7.0_51
> Running command: cmd "/s /c 
> "C:\Users\siw\workspace_neon\examples\kitchensink-co
> rdova\platforms\android\gradlew.bat cdvBuildRelease -b 
> C:\Users\siw\workspace_ne
> on\examples\kitchensink-cordova\platforms\android\build.gradle 
> -Dorg.gradle.daem
> on=true -Pandroid.useDeprecatedNdk=true""
> FAILURE: Build failed with an exception.
> * What went wrong:
> A problem occurred configuring root project 'android'.
> > Could not resolve all dependencies for configuration ':classpath'.
>> Could not resolve com.android.tools.build:gradle:2.1.0.
>  Required by:
>  :android:unspecified
>   > Could not resolve com.android.tools.build:gradle:2.1.0.
>  > Could not get resource 
> 'https://repo1.maven.org/maven2/com/android/to
> ols/build/gradle/2.1.0/gradle-2.1.0.pom'.
> > Could not GET 
> 'https://repo1.maven.org/maven2/com/android/tools/bu
> ild/gradle/2.1.0/gradle-2.1.0.pom'.
>> repo1.maven.org
>   > Could not resolve com.android.tools.build:gradle:2.1.0.
>  > Could not get resource 
> 'https://jcenter.bintray.com/com/android/tools
> /build/gradle/2.1.0/gradle-2.1.0.pom'.
> > Could not GET 
> 'https://jcenter.bintray.com/com/android/tools/build
> /gradle/2.1.0/gradle-2.1.0.pom'.
>> jcenter.bintray.com
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug
> option to get more log output.
> BUILD FAILED
> Total time: 4.412 secs
> Command finished with error code 1: cmd /s /c 
> "C:\Users\siw\workspace_neon\examp
> les\kitchensink-cordova\platforms\android\gradlew.bat cdvBuildRelease -b 
> C:\User
> s\siw\workspace_neon\examples\kitchensink-cordova\platforms\android\build.gradle
>  -Dorg.gradle.daemon=true -Pandroid.useDeprecatedNdk=true"
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> A problem occurred configuring root project 'android'.
> > Could not resolve all dependencies for configuration ':classpath'.
>> Could not resolve com.android.tools.build:gradle:2.1.0.
>  Required by:
>  :android:unspecified
>   > Could not resolve com.android.tools.build:gradle:2.1.0.
>  > Could not get resource 
> 'https://repo1.maven.org/maven2/com/android/to
> ols/build/gradle/2.1.0/gradle-2.1.0.pom'.
> > Could not GET 
> 

[jira] [Closed] (CB-13845) connection.type returns none even if mobile has internet Access

2018-01-30 Thread jcesarmobile (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-13845.
-
Resolution: Duplicate

> connection.type returns none even if mobile has internet Access
> ---
>
> Key: CB-13845
> URL: https://issues.apache.org/jira/browse/CB-13845
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-network-information
> Environment: Honor 9
> Android 7.0
>Reporter: Raymond
>Priority: Major
>
> I use Cordova network information plugin for my app. After some time running 
> in the background, I resume my app and the plugin returns connection.type 
> none even tough my mobile has internet Access. This issue occurs on Android 
> v7.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-13730) cordova-plugin-network-information return wrong connection status on Android

2018-01-30 Thread jcesarmobile (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-13730.
-
Resolution: Duplicate

> cordova-plugin-network-information return wrong connection status on Android
> 
>
> Key: CB-13730
> URL: https://issues.apache.org/jira/browse/CB-13730
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-network-information
>Affects Versions: cordova@7.1.0
> Environment: Windows 10, cordova-cli@7.1.0, cordova-android@6.4.0
>Reporter: Cristian Iossi
>Priority: Major
>  Labels: test
>
> There is a problem with cordova-plugin-network-information on Android. Even 
> if there is internet connection, after the app is opened for a while, when I 
> resume the app from the background and I check connection with 
> navigator.connection.type, it returns connection.type = NONE: I tried to do 
> an ajax request to verify the connection, and it works, so there is 
> connection. If I close and re-open the app it returns connection.type = 4G. I 
> use cordova@7.1.0 and cordova-android@6.4.0.
> My code to check the connection status is: 
> {code:java}
> function isOnline() {
> var networkState = navigator.connection.type;
> if (networkState !== Connection.NONE) {
> return true
> } else {
> return false
> }
> }
> {code}
> Thanks
> Cristian



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12973) inAppBrowser (_blank) returns to unresponsive app after "done" on iOS 10.

2018-01-30 Thread Jacob Weber (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345745#comment-16345745
 ] 

Jacob Weber commented on CB-12973:
--

Thanks Pavel. I can try that temporarily. [~Sujan12], were you able to 
reproduce it using my example?

> inAppBrowser (_blank) returns to unresponsive app after "done" on iOS 10.
> -
>
> Key: CB-12973
> URL: https://issues.apache.org/jira/browse/CB-12973
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: cordova -v
> 7.0.1
> Installed platforms:
>   android 6.2.3
>   ios 4.1.1
> ╰─➤  cordova plugins
> cordova-plugin-badge 0.8.0 "Badges"
> cordova-plugin-console 1.0.5 "Console"
> cordova-plugin-device 1.1.4 "Device"
> cordova-plugin-inappbrowser 1.7.1 "InAppBrowser"
> cordova-plugin-splashscreen 4.0.3 "Splashscreen"
> cordova-plugin-statusbar 2.2.1 "StatusBar"
> cordova-plugin-whitelist 1.3.1 "Whitelist"
> ionic-plugin-keyboard 2.2.1 "Keyboard"
>Reporter: Charles Palmer
>Priority: Critical
> Attachments: MyApp.zip
>
>
> Same app works on iOS 9 and Android. Also works on _system with Safari 
> browser.
> Use case. I create a simplified test case with a touch button to invoke code 
> (I have tried many workarounds without change of behavior)  The fundamental 
> code is:
> 
> var options = {
>   location: 'yes',
>   clearcache: 'yes',
>   toolbar: 'yes'
> };
>   IABRef = 
> cordova.InAppBrowser.open(encodeURI('https://conconn-staging.herokuapp.com'), 
> '_blank', options);
>  
>   IABRef.addEventListener('exit', iabClose);
> 
> I can enter the browser. If I hit "done" immediately, I return successfully 
> and can use the button to reinvoke the browser. However if I interact with 
> the browser content, there is about a 90%+ that upon exit ("done") to the 
> app, the app will not be responsive.. It should be noted that the exit 
> listener does activate, but I have not found a way to reactivate the 
> application's response.
> I suspect that there is an interaction at the interface between InAppBrowser 
> and the Apple Library for iOS 10, but this is speculation. As I said this 
> work with iOS 9 and fails in iOS 10. This can be simulated . (Xcode 8.3.3)  
> and observed on hardware.
> I believe there are multiple people facing this issue. Happy to provide more 
> information or collaborate if appropriate.
> I would be happy with a reliable work around or patch. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-13832) IOS app gets logged out when using "_system" as target

2018-01-30 Thread Agnosco (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Agnosco closed CB-13832.

Resolution: Invalid

> IOS app gets logged out when using "_system" as target
> --
>
> Key: CB-13832
> URL: https://issues.apache.org/jira/browse/CB-13832
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
>Reporter: Agnosco
>Priority: Major
>
> I have cordova 7.1.0 and IOS 10+
> I'm logged in my ios app and have an external link in the app. So, to open 
> the link in safari I have -"cordova.InAppBrowser.open(url, '_system', 
> 'location=no');". It opens the url link in safari but I got logged out from 
> app when I tried to go back to app.
> It works fine with target '_blank'. Is it a desired behavior? It used to work 
> in previous version of  cordova-plugin-inappbrowser 1.3.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-13826) Plugins Release Jan 24, 2018

2018-01-30 Thread Suraj Pindoria (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Pindoria closed CB-13826.
---
Resolution: Fixed

> Plugins Release Jan 24, 2018
> 
>
> Key: CB-13826
> URL: https://issues.apache.org/jira/browse/CB-13826
> Project: Apache Cordova
>  Issue Type: Task
>Reporter: Suraj Pindoria
>Assignee: Suraj Pindoria
>Priority: Major
>
> Following steps at 
> [https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13826) Plugins Release Jan 24, 2018

2018-01-30 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345531#comment-16345531
 ] 

ASF subversion and git services commented on CB-13826:
--

Commit 21a9863dea9464f5bf5ca0f5b557bb0b4a3d485a in cordova-docs's branch 
refs/heads/master from [~surajpindoria]
[ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=21a9863 ]

CB-13826: Plugins release blog post (#786)



> Plugins Release Jan 24, 2018
> 
>
> Key: CB-13826
> URL: https://issues.apache.org/jira/browse/CB-13826
> Project: Apache Cordova
>  Issue Type: Task
>Reporter: Suraj Pindoria
>Assignee: Suraj Pindoria
>Priority: Major
>
> Following steps at 
> [https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13826) Plugins Release Jan 24, 2018

2018-01-30 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345530#comment-16345530
 ] 

ASF GitHub Bot commented on CB-13826:
-

surajpindoria closed pull request #786: CB-13826: Plugins release blog post
URL: https://github.com/apache/cordova-docs/pull/786
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/www/_posts/2018-01-29-plugins-release.md 
b/www/_posts/2018-01-29-plugins-release.md
new file mode 100644
index 0..ec9206773
--- /dev/null
+++ b/www/_posts/2018-01-29-plugins-release.md
@@ -0,0 +1,48 @@
+---
+layout: post
+author:
+name: Suraj Pindoria
+url: https://twitter.com/surajpindoria
+title:  "Plugins Release"
+categories: news
+tags: release plugins
+---
+
+The following plugins were updated today:
+
+* cordova-plugin-camera@4.0.2
+* cordova-plugin-file-transfer@1.7.1
+* cordova-plugin-inappbrowser@2.0.2
+* cordova-plugin-media@5.0.2
+* cordova-plugin-splashscreen@5.0.2
+
+
+You can update any plugin by removing it, and then re-adding it.
+
+ E.g. To update your camera plugin:
+
+cordova plugin rm cordova-plugin-camera
+cordova plugin add cordova-plugin-camera@latest
+
+Changes include:
+
+cordova-plugin-camera@4.0.2
+* [CB-13781](https://issues.apache.org/jira/browse/CB-13781) (android) Fixed 
permissions request on **Android** 8 to save a photo into the photo album
+* [CB-13747](https://issues.apache.org/jira/browse/CB-13747) Add 
build-tools-26.0.2 to travis
+
+cordova-plugin-file-transfer@1.7.1
+* [CB-13749](https://issues.apache.org/jira/browse/CB-13749) Add 
build-tools-26.0.2 to travis
+
+cordova-plugin-inappbrowser@2.0.2
+* [CB-13791](https://issues.apache.org/jira/browse/CB-13791) Add **Android** 
support for a footer close button
+* [CB-13409](https://issues.apache.org/jira/browse/CB-13409) Lets user adjust 
color of toolbar, hide navigation buttons and set custom text on close button
+* [CB-13746](https://issues.apache.org/jira/browse/CB-13746) Add 
build-tools-26.0.2 to travis
+
+cordova-plugin-media@5.0.2
+* [CB-13751](https://issues.apache.org/jira/browse/CB-13751) Add 
build-tools-26.0.2 to travis (#163)
+* Fix for [CB-11513](https://issues.apache.org/jira/browse/CB-11513)
+* [CB-7684](https://issues.apache.org/jira/browse/CB-7684) (#143)
+
+cordova-plugin-splashscreen@5.0.2
+* [CB-13750](https://issues.apache.org/jira/browse/CB-13750) Add 
build-tools-26.0.2 to travis
+* [CB-13737](https://issues.apache.org/jira/browse/CB-13737) (iOS): fix Splash 
screen images for iPhone X


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Plugins Release Jan 24, 2018
> 
>
> Key: CB-13826
> URL: https://issues.apache.org/jira/browse/CB-13826
> Project: Apache Cordova
>  Issue Type: Task
>Reporter: Suraj Pindoria
>Assignee: Suraj Pindoria
>Priority: Major
>
> Following steps at 
> [https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13826) Plugins Release Jan 24, 2018

2018-01-30 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345475#comment-16345475
 ] 

ASF GitHub Bot commented on CB-13826:
-

surajpindoria commented on a change in pull request #786: CB-13826: Plugins 
release blog post
URL: https://github.com/apache/cordova-docs/pull/786#discussion_r164818563
 
 

 ##
 File path: www/_posts/2018-01-29-plugins-release.md
 ##
 @@ -0,0 +1,50 @@
+---
+layout: post
+author:
+name: Suraj Pindoria
+url: https://twitter.com/surajpindoria
+title:  "Plugins Release"
+categories: news
+tags: release plugins
+---
+
+The following plugins were updated today:
+
+* cordova-plugin-camera@4.0.2
+* cordova-plugin-file-transfer@1.7.1
+* cordova-plugin-inappbrowser@2.0.2
+* cordova-plugin-media@5.0.2
+* cordova-plugin-splashscreen@5.0.2
+
+Our last plugin release had an issue which made it impossible to install from 
npm. These point releases of the plugins fix the bug allowing you to install 
from npm as well as git url.
 
 Review comment:
   Oops, I definitely did not copy/paste from the last blog post  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Plugins Release Jan 24, 2018
> 
>
> Key: CB-13826
> URL: https://issues.apache.org/jira/browse/CB-13826
> Project: Apache Cordova
>  Issue Type: Task
>Reporter: Suraj Pindoria
>Assignee: Suraj Pindoria
>Priority: Major
>
> Following steps at 
> [https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13846) cordova forced use of gradle daemon is problematic

2018-01-30 Thread Austin France (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Austin France updated CB-13846:
---
Description: 
[GradleBuilder.js line 
57|https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/GradleBuilder.js#L57]
 forcably turns the gradle daemon on, overriding any gradle.properties or 
GRADLE_OPTS environment variable settings.

This is problematic because when performing concurrent builds (for example, in 
jenkins with more than one executer) the gradle daemon often crashes, causing 
the build to fail.

There needs to be an option (in config.xml) to disable use of the gradle daemon 
or better still, an option to not force the use of the gradle daemon and leave 
it up the the proper mechanisms (gradle.properties or GRADLE_OPTS) to disable 
or enable it.

  was:
[GradleBuilder.js line 
57|https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/GradleBuilder.js#L57]
 forcably turns the gradle daemon on, overriding any 
~/.gradle/gradle.properties or GRADLE_OPTS environment variable settings.

This is problematic because when performing concurrent builds (for example, in 
jenkins with more than one executer) the gradle daemon often crashes, causing 
the build to fail.

There needs to be an option (in config.xml) to disable use of the gradle daemon 
or better still, an option to not force the use of the gradle daemon and leave 
it up the the proper mechanisms (gradle.properties or GRADLE_OPTS) to disable 
or enable it.


> cordova forced use of gradle daemon is problematic
> --
>
> Key: CB-13846
> URL: https://issues.apache.org/jira/browse/CB-13846
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
> Environment: Jenkins on Linux
>Reporter: Austin France
>Assignee: Joe Bowser
>Priority: Major
>
> [GradleBuilder.js line 
> 57|https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/GradleBuilder.js#L57]
>  forcably turns the gradle daemon on, overriding any gradle.properties or 
> GRADLE_OPTS environment variable settings.
> This is problematic because when performing concurrent builds (for example, 
> in jenkins with more than one executer) the gradle daemon often crashes, 
> causing the build to fail.
> There needs to be an option (in config.xml) to disable use of the gradle 
> daemon or better still, an option to not force the use of the gradle daemon 
> and leave it up the the proper mechanisms (gradle.properties or GRADLE_OPTS) 
> to disable or enable it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13846) cordova forced use of gradle daemon is problematic

2018-01-30 Thread Austin France (JIRA)
Austin France created CB-13846:
--

 Summary: cordova forced use of gradle daemon is problematic
 Key: CB-13846
 URL: https://issues.apache.org/jira/browse/CB-13846
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-android
 Environment: Jenkins on Linux
Reporter: Austin France
Assignee: Joe Bowser


[GradleBuilder.js line 
57|https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/GradleBuilder.js#L57]
 forcably turns the gradle daemon on, overriding any 
~/.gradle/gradle.properties or GRADLE_OPTS environment variable settings.

This is problematic because when performing concurrent builds (for example, in 
jenkins with more than one executer) the gradle daemon often crashes, causing 
the build to fail.

There needs to be an option (in config.xml) to disable use of the gradle daemon 
or better still, not force the use of the gradle daemon and leave it up the the 
proper mechanisms (gradle.properties or GRADLE_OPTS) to disable or enable it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13846) cordova forced use of gradle daemon is problematic

2018-01-30 Thread Austin France (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Austin France updated CB-13846:
---
Description: 
[GradleBuilder.js line 
57|https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/GradleBuilder.js#L57]
 forcably turns the gradle daemon on, overriding any 
~/.gradle/gradle.properties or GRADLE_OPTS environment variable settings.

This is problematic because when performing concurrent builds (for example, in 
jenkins with more than one executer) the gradle daemon often crashes, causing 
the build to fail.

There needs to be an option (in config.xml) to disable use of the gradle daemon 
or better still, an option to not force the use of the gradle daemon and leave 
it up the the proper mechanisms (gradle.properties or GRADLE_OPTS) to disable 
or enable it.

  was:
[GradleBuilder.js line 
57|https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/GradleBuilder.js#L57]
 forcably turns the gradle daemon on, overriding any 
~/.gradle/gradle.properties or GRADLE_OPTS environment variable settings.

This is problematic because when performing concurrent builds (for example, in 
jenkins with more than one executer) the gradle daemon often crashes, causing 
the build to fail.

There needs to be an option (in config.xml) to disable use of the gradle daemon 
or better still, not force the use of the gradle daemon and leave it up the the 
proper mechanisms (gradle.properties or GRADLE_OPTS) to disable or enable it.


> cordova forced use of gradle daemon is problematic
> --
>
> Key: CB-13846
> URL: https://issues.apache.org/jira/browse/CB-13846
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
> Environment: Jenkins on Linux
>Reporter: Austin France
>Assignee: Joe Bowser
>Priority: Major
>
> [GradleBuilder.js line 
> 57|https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/GradleBuilder.js#L57]
>  forcably turns the gradle daemon on, overriding any 
> ~/.gradle/gradle.properties or GRADLE_OPTS environment variable settings.
> This is problematic because when performing concurrent builds (for example, 
> in jenkins with more than one executer) the gradle daemon often crashes, 
> causing the build to fail.
> There needs to be an option (in config.xml) to disable use of the gradle 
> daemon or better still, an option to not force the use of the gradle daemon 
> and leave it up the the proper mechanisms (gradle.properties or GRADLE_OPTS) 
> to disable or enable it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Resolved] (CB-13825) Outdated node_modules

2018-01-30 Thread Tobias Bocanegra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Bocanegra resolved CB-13825.
---
   Resolution: Fixed
Fix Version/s: 4.1.0

> Outdated node_modules
> -
>
> Key: CB-13825
> URL: https://issues.apache.org/jira/browse/CB-13825
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Affects Versions: 4.1.0
>Reporter: Alberto Lalama
>Assignee: Tobias Bocanegra
>Priority: Major
> Fix For: 4.1.0
>
>
> Commit  [f7db769af|https://github.com/apache/cordova-osx/pull/43] updated 
> cordova-common to v2.1.0 without updating node_modules. This means that 
> pinning cordova-osx to the github repo in config.xml fails to install plugins 
> with the following error:
> Installing "cordova-plugin-whitelist" for osx
>  Failed to install 'cordova-plugin-whitelist':TypeError: Cannot read property 
> 'get' of undefined
>  at Api.addPlugin (platforms/osx/cordova/Api.js:187:25)
>  at handleInstall (cordova-lib/src/plugman/install.js:611:6)
>  at node_modules/cordova-lib/src/plugman/install.js:407:28
>  at _fulfilled (node_modules/cordova-lib/node_modules/q/q.js:787:54)
>  at self.promiseDispatch.done 
> (node_modules/cordova-lib/node_modules/q/q.js:816:30)
>  at Promise.promise.promiseDispatch 
> (node_modules/cordova-lib/node_modules/q/q.js:749:13)
>  at node_modules/cordova-lib/node_modules/q/q.js:509:49
>  at flush (node_modules/cordova-lib/node_modules/q/q.js:108:17)
>  at _combinedTickCallback (internal/process/next_tick.js:131:7)
>  at process._tickCallback (internal/process/next_tick.js:180:9)
>  Failed to restore plugin "cordova-plugin-whitelist" from config.xml. You 
> might need to try adding it again. Error: TypeError: Cannot read property 
> 'get' of undefined
>  
> A straightforward solution would be to update node_modules (cordova-ios seems 
> to do this regularly). Could we use a dependency manager (e.g. yarn)? Any 
> other suggestions?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Resolved] (CB-13824) (Swift 4) Plugin class not found

2018-01-30 Thread Tobias Bocanegra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Bocanegra resolved CB-13824.
---
   Resolution: Fixed
Fix Version/s: 4.1.0

>  (Swift 4) Plugin class not found
> -
>
> Key: CB-13824
> URL: https://issues.apache.org/jira/browse/CB-13824
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios, cordova-osx
>Reporter: Alberto Lalama
>Assignee: Tobias Bocanegra
>Priority: Minor
> Fix For: 4.1.0
>
>
> After upgrading to Xcode 9.2 (Swift 4), some plugins were not found. Plugin 
> method execution fails with the following message: "CDVPlugin class X 
> (pluginName: Y) does not exist".
> Closer inspection reveals that NSClassFromString returns nil for plugins 
> implemented in Swift. Prefixing the class with the module name fixes the 
> issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Resolved] (CB-11483) Add support for native calls into javascript

2018-01-30 Thread Tobias Bocanegra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Bocanegra resolved CB-11483.
---
Resolution: Won't Fix

no longer needed, I guess.

> Add support for native calls into javascript
> 
>
> Key: CB-11483
> URL: https://issues.apache.org/jira/browse/CB-11483
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Affects Versions: 4.0.0
>Reporter: Tobias Bocanegra
>Assignee: Tobias Bocanegra
>Priority: Major
> Fix For: Master
>
>
> The current cordova exec for osx is missing the {{nativeEvalAndFetch}} 
> methods that allow direct calls into cordova.
> see: https://github.com/apache/cordova-osx/pull/35



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-3021) Can no longer import CDVPlugin.h from plugin Objective-C++ code

2018-01-30 Thread Tobias Bocanegra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Bocanegra updated CB-3021:
-
Fix Version/s: 4.1.0

> Can no longer import CDVPlugin.h from plugin Objective-C++ code
> ---
>
> Key: CB-3021
> URL: https://issues.apache.org/jira/browse/CB-3021
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Affects Versions: 2.6.0
> Environment: XCode 4.6.1
> OSX 10.8.3
>Reporter: Ryan Willoughby
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: C++, OSX, Plugins, iOS
> Fix For: 4.1.0
>
>
> As of 2.6.0, importing CDVPlugin.h from C++ source code results in compile 
> errors:
> /CordovaLib/Classes/CDVPlugin.h:26:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:27:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:28:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:29:17: Default initialization of an object of 
> const type 'NSString *const'
> Install this plugin in a Cordova 2.6.0 project to reproduce:
> https://github.com/wildabeast/BarcodeScanner



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Resolved] (CB-3021) Can no longer import CDVPlugin.h from plugin Objective-C++ code

2018-01-30 Thread Tobias Bocanegra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Bocanegra resolved CB-3021.
--
Resolution: Fixed

> Can no longer import CDVPlugin.h from plugin Objective-C++ code
> ---
>
> Key: CB-3021
> URL: https://issues.apache.org/jira/browse/CB-3021
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Affects Versions: 2.6.0
> Environment: XCode 4.6.1
> OSX 10.8.3
>Reporter: Ryan Willoughby
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: C++, OSX, Plugins, iOS
> Fix For: 4.1.0
>
>
> As of 2.6.0, importing CDVPlugin.h from C++ source code results in compile 
> errors:
> /CordovaLib/Classes/CDVPlugin.h:26:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:27:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:28:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:29:17: Default initialization of an object of 
> const type 'NSString *const'
> Install this plugin in a Cordova 2.6.0 project to reproduce:
> https://github.com/wildabeast/BarcodeScanner



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-3021) Can no longer import CDVPlugin.h from plugin Objective-C++ code

2018-01-30 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344679#comment-16344679
 ] 

ASF subversion and git services commented on CB-3021:
-

Commit 3efc345de20a444fcc17af6e2b4438db7d8d7397 in cordova-osx's branch 
refs/heads/master from [~tripod]
[ https://gitbox.apache.org/repos/asf?p=cordova-osx.git;h=3efc345 ]

CB-3021 Can no longer import CDVPlugin.h from plugin Objective-C++ code


> Can no longer import CDVPlugin.h from plugin Objective-C++ code
> ---
>
> Key: CB-3021
> URL: https://issues.apache.org/jira/browse/CB-3021
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Affects Versions: 2.6.0
> Environment: XCode 4.6.1
> OSX 10.8.3
>Reporter: Ryan Willoughby
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: C++, OSX, Plugins, iOS
> Fix For: 4.1.0
>
>
> As of 2.6.0, importing CDVPlugin.h from C++ source code results in compile 
> errors:
> /CordovaLib/Classes/CDVPlugin.h:26:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:27:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:28:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:29:17: Default initialization of an object of 
> const type 'NSString *const'
> Install this plugin in a Cordova 2.6.0 project to reproduce:
> https://github.com/wildabeast/BarcodeScanner



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13824) (Swift 4) Plugin class not found

2018-01-30 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344673#comment-16344673
 ] 

ASF subversion and git services commented on CB-13824:
--

Commit ce5513ffa1ff77f39bd5f0fa6019e73e473636bd in cordova-osx's branch 
refs/heads/master from alberto lalama
[ https://gitbox.apache.org/repos/asf?p=cordova-osx.git;h=ce5513f ]

CB-13824 Swift 4 support

 This closes #45


>  (Swift 4) Plugin class not found
> -
>
> Key: CB-13824
> URL: https://issues.apache.org/jira/browse/CB-13824
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios, cordova-osx
>Reporter: Alberto Lalama
>Assignee: Tobias Bocanegra
>Priority: Minor
>
> After upgrading to Xcode 9.2 (Swift 4), some plugins were not found. Plugin 
> method execution fails with the following message: "CDVPlugin class X 
> (pluginName: Y) does not exist".
> Closer inspection reveals that NSClassFromString returns nil for plugins 
> implemented in Swift. Prefixing the class with the module name fixes the 
> issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13824) (Swift 4) Plugin class not found

2018-01-30 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344672#comment-16344672
 ] 

ASF GitHub Bot commented on CB-13824:
-

tripodsan closed pull request #45: CB-13824: (osx) Swift 4 support
URL: https://github.com/apache/cordova-osx/pull/45
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/CordovaLib/CordovaLib/Classes/CDVViewController.m 
b/CordovaLib/CordovaLib/Classes/CDVViewController.m
index c310403..d43c0f3 100644
--- a/CordovaLib/CordovaLib/Classes/CDVViewController.m
+++ b/CordovaLib/CordovaLib/Classes/CDVViewController.m
@@ -304,6 +304,12 @@ - (id) getCommandInstance:(NSString*) pluginName {
 id obj = self.pluginObjects[className];
 if (!obj) {
 obj = [(CDVPlugin*) [NSClassFromString(className) alloc] 
initWithWebView:webView];
+if (!obj) {
+NSString* fullClassName = [NSString stringWithFormat:@"%@.%@",
+   
NSBundle.mainBundle.infoDictionary[@"CFBundleExecutable"],
+   className];
+obj = [(CDVPlugin*) [NSClassFromString(fullClassName) alloc] 
initWithWebView:webView];
+}
 
 if (obj != nil) {
 [self registerPlugin:obj withClassName:className];


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


>  (Swift 4) Plugin class not found
> -
>
> Key: CB-13824
> URL: https://issues.apache.org/jira/browse/CB-13824
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios, cordova-osx
>Reporter: Alberto Lalama
>Assignee: Tobias Bocanegra
>Priority: Minor
>
> After upgrading to Xcode 9.2 (Swift 4), some plugins were not found. Plugin 
> method execution fails with the following message: "CDVPlugin class X 
> (pluginName: Y) does not exist".
> Closer inspection reveals that NSClassFromString returns nil for plugins 
> implemented in Swift. Prefixing the class with the module name fixes the 
> issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-3021) Can no longer import CDVPlugin.h from plugin Objective-C++ code

2018-01-30 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344676#comment-16344676
 ] 

ASF GitHub Bot commented on CB-3021:


tripodsan commented on issue #36: CB-3021 OSX : Added "extern" to CDVPlugin.h
URL: https://github.com/apache/cordova-osx/pull/36#issuecomment-361511804
 
 
   source repository no longer exists. closing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can no longer import CDVPlugin.h from plugin Objective-C++ code
> ---
>
> Key: CB-3021
> URL: https://issues.apache.org/jira/browse/CB-3021
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Affects Versions: 2.6.0
> Environment: XCode 4.6.1
> OSX 10.8.3
>Reporter: Ryan Willoughby
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: C++, OSX, Plugins, iOS
>
> As of 2.6.0, importing CDVPlugin.h from C++ source code results in compile 
> errors:
> /CordovaLib/Classes/CDVPlugin.h:26:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:27:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:28:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:29:17: Default initialization of an object of 
> const type 'NSString *const'
> Install this plugin in a Cordova 2.6.0 project to reproduce:
> https://github.com/wildabeast/BarcodeScanner



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-3021) Can no longer import CDVPlugin.h from plugin Objective-C++ code

2018-01-30 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344675#comment-16344675
 ] 

ASF GitHub Bot commented on CB-3021:


tripodsan closed pull request #36: CB-3021 OSX : Added "extern" to CDVPlugin.h
URL: https://github.com/apache/cordova-osx/pull/36
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can no longer import CDVPlugin.h from plugin Objective-C++ code
> ---
>
> Key: CB-3021
> URL: https://issues.apache.org/jira/browse/CB-3021
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Affects Versions: 2.6.0
> Environment: XCode 4.6.1
> OSX 10.8.3
>Reporter: Ryan Willoughby
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: C++, OSX, Plugins, iOS
>
> As of 2.6.0, importing CDVPlugin.h from C++ source code results in compile 
> errors:
> /CordovaLib/Classes/CDVPlugin.h:26:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:27:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:28:17: Default initialization of an object of 
> const type 'NSString *const'
> /CordovaLib/Classes/CDVPlugin.h:29:17: Default initialization of an object of 
> const type 'NSString *const'
> Install this plugin in a Cordova 2.6.0 project to reproduce:
> https://github.com/wildabeast/BarcodeScanner



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13824) (Swift 4) Plugin class not found

2018-01-30 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344671#comment-16344671
 ] 

ASF GitHub Bot commented on CB-13824:
-

tripodsan commented on issue #45: CB-13824: (osx) Swift 4 support
URL: https://github.com/apache/cordova-osx/pull/45#issuecomment-361510862
 
 
   LGTM, @albertolalama would be cool if you could add a swift plugin to the 
tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


>  (Swift 4) Plugin class not found
> -
>
> Key: CB-13824
> URL: https://issues.apache.org/jira/browse/CB-13824
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios, cordova-osx
>Reporter: Alberto Lalama
>Assignee: Tobias Bocanegra
>Priority: Minor
>
> After upgrading to Xcode 9.2 (Swift 4), some plugins were not found. Plugin 
> method execution fails with the following message: "CDVPlugin class X 
> (pluginName: Y) does not exist".
> Closer inspection reveals that NSClassFromString returns nil for plugins 
> implemented in Swift. Prefixing the class with the module name fixes the 
> issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13825) Outdated node_modules

2018-01-30 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344649#comment-16344649
 ] 

ASF GitHub Bot commented on CB-13825:
-

tripodsan commented on issue #46: CB-13825: (osx) Update node dependencies
URL: https://github.com/apache/cordova-osx/pull/46#issuecomment-361505208
 
 
   sorry, but this is the wrong solution. adding the node_modules directly to 
the repository is wrong. they need to come in via package.json.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Outdated node_modules
> -
>
> Key: CB-13825
> URL: https://issues.apache.org/jira/browse/CB-13825
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Affects Versions: 4.1.0
>Reporter: Alberto Lalama
>Assignee: Tobias Bocanegra
>Priority: Major
>
> Commit  [f7db769af|https://github.com/apache/cordova-osx/pull/43] updated 
> cordova-common to v2.1.0 without updating node_modules. This means that 
> pinning cordova-osx to the github repo in config.xml fails to install plugins 
> with the following error:
> Installing "cordova-plugin-whitelist" for osx
>  Failed to install 'cordova-plugin-whitelist':TypeError: Cannot read property 
> 'get' of undefined
>  at Api.addPlugin (platforms/osx/cordova/Api.js:187:25)
>  at handleInstall (cordova-lib/src/plugman/install.js:611:6)
>  at node_modules/cordova-lib/src/plugman/install.js:407:28
>  at _fulfilled (node_modules/cordova-lib/node_modules/q/q.js:787:54)
>  at self.promiseDispatch.done 
> (node_modules/cordova-lib/node_modules/q/q.js:816:30)
>  at Promise.promise.promiseDispatch 
> (node_modules/cordova-lib/node_modules/q/q.js:749:13)
>  at node_modules/cordova-lib/node_modules/q/q.js:509:49
>  at flush (node_modules/cordova-lib/node_modules/q/q.js:108:17)
>  at _combinedTickCallback (internal/process/next_tick.js:131:7)
>  at process._tickCallback (internal/process/next_tick.js:180:9)
>  Failed to restore plugin "cordova-plugin-whitelist" from config.xml. You 
> might need to try adding it again. Error: TypeError: Cannot read property 
> 'get' of undefined
>  
> A straightforward solution would be to update node_modules (cordova-ios seems 
> to do this regularly). Could we use a dependency manager (e.g. yarn)? Any 
> other suggestions?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org