[jira] [Commented] (CB-14102) "cordova plugin add" removes other plugins installed from Github
[ https://issues.apache.org/jira/browse/CB-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482210#comment-16482210 ] ASF GitHub Bot commented on CB-14102: - knight opened a new pull request #614: CB-14102: Fix tests use specified npm version URL: https://github.com/apache/cordova-lib/pull/614 ### Platforms affected This is only test codes in order to pass the travis ci. ### What does this PR do? 1. Test ios platform version is changed to ios@4.5.4 instead of ios@4.3.0. ios@4.3.0 is too old for the latest cordova-cli and brings installing error. 2. Use npm 5.7.1 instead of 5.6.x. Because npm@5.6.x has an issue. The issue is on npm’s Github: https://github.com/npm/npm/issues/17379 As a result, `cordova plugin add` with github url brings error in test. ### What testing has been done on this change? Using ios@4.54 instead of ios@4.3.0 Using npm@5.7.1 instead of default npm. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > "cordova plugin add" removes other plugins installed from Github > - > > Key: CB-14102 > URL: https://issues.apache.org/jira/browse/CB-14102 > Project: Apache Cordova > Issue Type: Wish > Components: cordova-fetch >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Minor > Fix For: 8.0.0 > > > The cordova platform/plugin add commands use cordova-fetch to get the > relevant files. It does this by using npm. > However, npm@5.6.x has an issue when installing modules from Github. > npm modules installed from a Github URL will be removed after installing > other npm modules. > The issue is on npm’s Github: https://github.com/npm/npm/issues/17379 > For example, using node v9.5.0, npm v5.6.0 and cordova 8.0, run > $ cordova plugin add https://github.com/knight/HelloWorldPlugin.git > This adds helloworldplugin into the node_modules directory, as shown below: > $ ls node_modules/ > fs-extrahelloworldpluginjsonfileuniversalify > graceful-fsinstallnpm > If we add further plugins like so: > $ cordova plugin add cordova-plugin-camera > The previous modules in node_modules directory disappear. > $ ls node_modules/ > cordova-plugin-camera > This is fixed in npm@5.7.1, as mentioned in the issue link above. > It is possible that the user cannot update their global npm version due to > some other dependencies. I suggest that we add a way for the user to override > the npm executable which is used by Cordova. For example, we could add an > environment variable as below, which would be used instead of the global npm: > CORDOVA_NPM=/home/user/bin/npm -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14102) "cordova plugin add" removes other plugins installed from Github
Ken Naito created CB-14102: -- Summary: "cordova plugin add" removes other plugins installed from Github Key: CB-14102 URL: https://issues.apache.org/jira/browse/CB-14102 Project: Apache Cordova Issue Type: Wish Components: cordova-fetch Affects Versions: 8.0.0 Reporter: Ken Naito Fix For: 8.0.0 The cordova platform/plugin add commands use cordova-fetch to get the relevant files. It does this by using npm. However, npm@5.6.x has an issue when installing modules from Github. npm modules installed from a Github URL will be removed after installing other npm modules. The issue is on npm’s Github: https://github.com/npm/npm/issues/17379 For example, using node v9.5.0, npm v5.6.0 and cordova 8.0, run $ cordova plugin add https://github.com/knight/HelloWorldPlugin.git This adds helloworldplugin into the node_modules directory, as shown below: $ ls node_modules/ fs-extrahelloworldpluginjsonfileuniversalify graceful-fsinstallnpm If we add further plugins like so: $ cordova plugin add cordova-plugin-camera The previous modules in node_modules directory disappear. $ ls node_modules/ cordova-plugin-camera This is fixed in npm@5.7.1, as mentioned in the issue link above. It is possible that the user cannot update their global npm version due to some other dependencies. I suggest that we add a way for the user to override the npm executable which is used by Cordova. For example, we could add an environment variable as below, which would be used instead of the global npm: CORDOVA_NPM=/home/user/bin/npm -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14098) Remove unused res folder from app template
[ https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482091#comment-16482091 ] ASF GitHub Bot commented on CB-14098: - raphinesse commented on issue #21: CB-14098: Remove unused res folder URL: https://github.com/apache/cordova-app-hello-world/pull/21#issuecomment-390522900 @Menardi The former README in this folder says: > Although there are default image resources in a newly-created project, those come from the platform-specific project template, which can generally be found in the platform's `template` directory. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unused res folder from app template > -- > > Key: CB-14098 > URL: https://issues.apache.org/jira/browse/CB-14098 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world >Affects Versions: 3.11.0 >Reporter: Raphael >Priority: Major > > The res folder weighs around 10MiB and contains resources for a whole lot of > platforms, most of which are actually deprecated. Furthermore, as I > understand the included `README.md` (which I'm not sure I do), the contents > of this folder seem to not even being used for anything. > So my proposal is to remove this directory from the template. That would > decrease the installation size of `cordova` by about two thirds and remove > unnecessary clutter from any newly created apps. > If I did get anything wrong and this is actually used, we should probably > clarify the README, remove all content related to deprecated platforms (like > suggested in CB-13726) and run them through some compressors (pngquant and > zopflipng). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14098) Remove unused res folder from app template
[ https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482092#comment-16482092 ] ASF GitHub Bot commented on CB-14098: - raphinesse commented on issue #21: CB-14098: Remove unused res folder URL: https://github.com/apache/cordova-app-hello-world/pull/21#issuecomment-390522900 @Menardi Thanks for testing. The former README in this folder says: > Although there are default image resources in a newly-created project, those come from the platform-specific project template, which can generally be found in the platform's `template` directory. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unused res folder from app template > -- > > Key: CB-14098 > URL: https://issues.apache.org/jira/browse/CB-14098 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world >Affects Versions: 3.11.0 >Reporter: Raphael >Priority: Major > > The res folder weighs around 10MiB and contains resources for a whole lot of > platforms, most of which are actually deprecated. Furthermore, as I > understand the included `README.md` (which I'm not sure I do), the contents > of this folder seem to not even being used for anything. > So my proposal is to remove this directory from the template. That would > decrease the installation size of `cordova` by about two thirds and remove > unnecessary clutter from any newly created apps. > If I did get anything wrong and this is actually used, we should probably > clarify the README, remove all content related to deprecated platforms (like > suggested in CB-13726) and run them through some compressors (pngquant and > zopflipng). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14098) Remove unused res folder from app template
[ https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482089#comment-16482089 ] ASF GitHub Bot commented on CB-14098: - Menardi commented on issue #21: CB-14098: Remove unused res folder URL: https://github.com/apache/cordova-app-hello-world/pull/21#issuecomment-390522704 I agree, it looks like the `res` folder is redundant. An iOS app built on this template is just fine, and has all the default Cordova icons. I'm not sure where they're being taken from, but it's not this `res` folder. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unused res folder from app template > -- > > Key: CB-14098 > URL: https://issues.apache.org/jira/browse/CB-14098 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world >Affects Versions: 3.11.0 >Reporter: Raphael >Priority: Major > > The res folder weighs around 10MiB and contains resources for a whole lot of > platforms, most of which are actually deprecated. Furthermore, as I > understand the included `README.md` (which I'm not sure I do), the contents > of this folder seem to not even being used for anything. > So my proposal is to remove this directory from the template. That would > decrease the installation size of `cordova` by about two thirds and remove > unnecessary clutter from any newly created apps. > If I did get anything wrong and this is actually used, we should probably > clarify the README, remove all content related to deprecated platforms (like > suggested in CB-13726) and run them through some compressors (pngquant and > zopflipng). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14096) Landing page still shows deprecated platforms
[ https://issues.apache.org/jira/browse/CB-14096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482075#comment-16482075 ] ASF GitHub Bot commented on CB-14096: - Menardi commented on issue #818: CB-14096: Remove deprecated platforms from landing page URL: https://github.com/apache/cordova-docs/pull/818#issuecomment-390520980 No problem. There are two parts that needed to be changed. The before and after screenshots are below.     This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Landing page still shows deprecated platforms > - > > Key: CB-14096 > URL: https://issues.apache.org/jira/browse/CB-14096 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gearóid M >Priority: Minor > > The [landing page|http://cordova.apache.org/] still shows icons for > deprecated platforms such as Blackberry and Firefox OS. These should be > removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-8134) Image missing in Windows Phone 8 vmware instructions
[ https://issues.apache.org/jira/browse/CB-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-8134. Resolution: Won't Fix Closing as wp8 is deprecated > Image missing in Windows Phone 8 vmware instructions > > > Key: CB-8134 > URL: https://issues.apache.org/jira/browse/CB-8134 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-wp8 (DEPRECATED) > Environment: Windows Phone 8 >Reporter: Shazron Abdullah >Priority: Major > > Under "3. Choose the Advanced settings. Enable the Preferred virtualization > engine: Intel VT-x with EPT option:" > Link: > http://cordova.apache.org/docs/en/edge/guide_platforms_wp8_vmware.md.html -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14101) check_reqs.js does not recognize java version
[
https://issues.apache.org/jira/browse/CB-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arne Simon updated CB-14101:
Affects Version/s: 8.0.0
> check_reqs.js does not recognize java version
> -
>
> Key: CB-14101
> URL: https://issues.apache.org/jira/browse/CB-14101
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: 8.0.0
> Environment: OS = Arch Linux
> JAVA = javac 9.0.4
> CORDOVA = 8.0.0
>Reporter: Arne Simon
>Priority: Major
>
> The java version i am using produces following output.
> {code}
> > javac -version
> javac 9.0.4
> {code}
>
> The error happens in two points:
> {code:java}
> // We use tryCommand with catchStderr = true, because
> // javac writes version info to stderr instead of stdout
> return tryCommand('javac -version', msg, true).then(function (output) {
> // Let's check for at least Java 8, and keep it future proof so we can
> support Java 10
> var match = /javac
> ((?:1\.)(?:[8-9]\.)(?:\d+))|((?:1\.)(?:[1-9]\d+\.)(?:\d+))/i.exec(output);
> return match && match[1];
> });{code}
> 1. _platforms/android/cordova/lib/check_reqs.js:218_
> The comment states that javac prints to stderr, this is not true on my system
> it prints to stdout!
> 2. _platforms/android/cordova/lib/check_reqs.js:220_
> The regex only looks after version numbers like 1.8 or 1.9 or 10, but the
> version number my java version prints is _9.0.4_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14101) check_reqs.js does not recognize java version
Arne Simon created CB-14101:
---
Summary: check_reqs.js does not recognize java version
Key: CB-14101
URL: https://issues.apache.org/jira/browse/CB-14101
Project: Apache Cordova
Issue Type: Bug
Environment: OS = Arch Linux
JAVA = javac 9.0.4
CORDOVA = 8.0.0
Reporter: Arne Simon
The java version i am using produces following output.
{code}
> javac -version
javac 9.0.4
{code}
The error happens in two points:
{code:java}
// We use tryCommand with catchStderr = true, because
// javac writes version info to stderr instead of stdout
return tryCommand('javac -version', msg, true).then(function (output) {
// Let's check for at least Java 8, and keep it future proof so we can
support Java 10
var match = /javac
((?:1\.)(?:[8-9]\.)(?:\d+))|((?:1\.)(?:[1-9]\d+\.)(?:\d+))/i.exec(output);
return match && match[1];
});{code}
1. _platforms/android/cordova/lib/check_reqs.js:218_
The comment states that javac prints to stderr, this is not true on my system
it prints to stdout!
2. _platforms/android/cordova/lib/check_reqs.js:220_
The regex only looks after version numbers like 1.8 or 1.9 or 10, but the
version number my java version prints is _9.0.4_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14100) InAppBrowser on iOS content is under statusbar and add option to hide url
Adrian Axinte created CB-14100: -- Summary: InAppBrowser on iOS content is under statusbar and add option to hide url Key: CB-14100 URL: https://issues.apache.org/jira/browse/CB-14100 Project: Apache Cordova Issue Type: Bug Components: cordova-ios Reporter: Adrian Axinte Assignee: Suraj Pindoria On iOs with inappbrowser, the content is hidden under statusbar. If I set toolbarposition to top, than same, content is hidden under both statusbar and toolbar. -- on iOS there is no way to hide url bar? -- It would be nice to style the prev/next buttons, now looks strage. Android ones are prefect screenshot > http://take.ms/F8WNs -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
