[jira] [Commented] (CB-12020) add a method to hide an InAppBrowser after it was shown

2016-10-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585680#comment-15585680
 ] 

ASF GitHub Bot commented on CB-12020:
-

Github user sfrank87 closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/192


> add a method to hide an InAppBrowser after it was shown
> ---
>
> Key: CB-12020
> URL: https://issues.apache.org/jira/browse/CB-12020
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin InAppBrowser
> Environment: Android, iOS
>Reporter: Frank Stingl
>Assignee: jcesarmobile
>  Labels: android, ios
>
> The InAppBrowser plugin, unfortunately, offers no ability to hide an 
> InAppBrowser after it was shown. Because I had a need for such a 
> functionality, I implemented it. :)
> Now, you can call the hide() method to make the InAppBrowser disappear. Then, 
> call show() to have it reappearing.
> However, after I finished my work, I recognized that there was a similar Jira 
> issue #cb-8467, but, I don’t know why, it was not merged upstream until today.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12020) add a method to hide an InAppBrowser after it was shown

2016-10-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576033#comment-15576033
 ] 

ASF GitHub Bot commented on CB-12020:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/192
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/192/commits/157116caebec508ac8e9dce5e8bfa94a4d0fcc2a)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/84//PLATFORM=android/artifact/)
 |
 



> add a method to hide an InAppBrowser after it was shown
> ---
>
> Key: CB-12020
> URL: https://issues.apache.org/jira/browse/CB-12020
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin InAppBrowser
> Environment: Android, iOS
>Reporter: Frank Stingl
>  Labels: android, ios
>
> The InAppBrowser plugin, unfortunately, offers no ability to hide an 
> InAppBrowser after it was shown. Because I had a need for such a 
> functionality, I implemented it. :)
> Now, you can call the hide() method to make the InAppBrowser disappear. Then, 
> call show() to have it reappearing.
> However, after I finished my work, I recognized that there was a similar Jira 
> issue #cb-8467, but, I don’t know why, it was not merged upstream until today.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12020) add a method to hide an InAppBrowser after it was shown

2016-10-14 Thread Frank Stingl (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575259#comment-15575259
 ] 

Frank Stingl commented on CB-12020:
---

Pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/192


> add a method to hide an InAppBrowser after it was shown
> ---
>
> Key: CB-12020
> URL: https://issues.apache.org/jira/browse/CB-12020
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin InAppBrowser
> Environment: Android, iOS
>Reporter: Frank Stingl
>  Labels: android, ios
>
> The InAppBrowser plugin, unfortunately, offers no ability to hide an 
> InAppBrowser after it was shown. Because I had a need for such a 
> functionality, I implemented it. :)
> Now, you can call the hide() method to make the InAppBrowser disappear. Then, 
> call show() to have it reappearing.
> However, after I finished my work, I recognized that there was a similar Jira 
> issue #cb-8467, but, I don’t know why, it was not merged upstream until today.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12020) add a method to hide an InAppBrowser after it was shown

2016-10-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575255#comment-15575255
 ] 

ASF GitHub Bot commented on CB-12020:
-

GitHub user sfrank87 opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/192

CB-12020 Android and iOS: add a method to hide an InAppBrowser after it was 
shown

### Platforms affected
Android, iOS

### What does this PR do?
add a hide() method to hide the InAppBrowser. You can make it reappear my 
calling the show() method (again).

### What testing has been done on this change?
- automated test: check for the existence of the hide() method
- manual test: open InAppBrowser visible, than hide it (after 2 seconds)

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sfrank87/cordova-plugin-inappbrowser 
CB-12020_add_a_method_to_hide_an_InAppBrowser_after_it_was_shown

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #192


commit 157116caebec508ac8e9dce5e8bfa94a4d0fcc2a
Author: Frank Stingl 
Date:   2016-10-14T12:48:31Z

CB-12020 Android and iOS: add a method to hide an InAppBrowser after it was 
shown




> add a method to hide an InAppBrowser after it was shown
> ---
>
> Key: CB-12020
> URL: https://issues.apache.org/jira/browse/CB-12020
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin InAppBrowser
> Environment: Android, iOS
>Reporter: Frank Stingl
>  Labels: android, ios
>
> The InAppBrowser plugin, unfortunately, offers no ability to hide an 
> InAppBrowser after it was shown. Because I had a need for such a 
> functionality, I implemented it. :)
> Now, you can call the hide() method to make the InAppBrowser disappear. Then, 
> call show() to have it reappearing.
> However, after I finished my work, I recognized that there was a similar Jira 
> issue #cb-8467, but, I don’t know why, it was not merged upstream until today.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org