[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2018-01-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329359#comment-16329359
 ] 

ASF GitHub Bot commented on CB-12969:
-

infil00p commented on issue #227: CB-12969 android: Added support for data URIs
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/227#issuecomment-358426574
 
 
   It looks like the PR got borked, and we can't accept it as is due to the 
conflict.,  Closing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2018-01-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329360#comment-16329360
 ] 

ASF GitHub Bot commented on CB-12969:
-

infil00p closed pull request #227: CB-12969 android: Added support for data URIs
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/227
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 735b7364..df373722 100644
--- a/README.md
+++ b/README.md
@@ -707,3 +707,18 @@ iab.open('http://url-that-fails-whitelist.com', 
'random_string'); // loads in th
 iab.open('http://url-that-fails-whitelist.com', 'random_string', 
'location=no'); // loads in the InAppBrowser, no location bar
 
 ```
+
+### Data Urls (format: data:[][;base64],)
+
+Supported by android, windows and browser platforms 
+```
+var iab = cordova.InAppbrowser;
+iab.open('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E');   
   // loads in the Cordova WebView (android, browser) 
+iab.open('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E', '_self');  
   // loads in the Cordova WebView (android, browser) 
+iab.open('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E', '_system');
   // loads in the system browser
+iab.open('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E', '_blank'); 
   // loads in the InAppBrowser (android, browser)
+iab.open('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E', 
'random_string'); // loads in the InAppBrowser (android, browser)
+iab.open('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E', 
'random_string', 'location=no'); // loads in the InAppBrowser, no location bar 
(android, browser)
+
+```  
+
diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index fefbcece..abcc74b2 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -393,22 +393,27 @@ public void run() {
  */
 public String openExternal(String url) {
 try {
-Intent intent = null;
-intent = new Intent(Intent.ACTION_VIEW);
 // Omitting the MIME type for file: URLs causes "No Activity found 
to handle Intent".
 // Adding the MIME type to http: URLs causes them to not be 
handled by the downloader.
 Uri uri = Uri.parse(url);
-if ("file".equals(uri.getScheme())) {
+String scheme = uri.getScheme();
+
+Intent intent = "data".equals(scheme)
+? Intent.makeMainSelectorActivity(Intent.ACTION_MAIN, 
Intent.CATEGORY_APP_BROWSER)
+: new Intent(Intent.ACTION_VIEW);
+
+if ("file".equals(scheme)) {
 intent.setDataAndType(uri, 
webView.getResourceApi().getMimeType(uri));
 } else {
 intent.setData(uri);
 }
+
 intent.putExtra(Browser.EXTRA_APPLICATION_ID, 
cordova.getActivity().getPackageName());
 this.cordova.getActivity().startActivity(intent);
 return "";
-// not catching FileUriExposedException explicitly because 
buildtools<24 doesn't know about it
+// not catching FileUriExposedException explicitly because 
buildtools<24 doesn't know about it
 } catch (java.lang.RuntimeException e) {
-LOG.d(LOG_TAG, "InAppBrowser: Error loading url "+url+":"+ 
e.toString());
+LOG.d(LOG_TAG, "InAppBrowser: Error loading url " + url + ":" + 
e.toString());
 return e.toString();
 }
 }
diff --git a/src/windows/InAppBrowserProxy.js b/src/windows/InAppBrowserProxy.js
index dec91dba..b03e8206 100644
--- a/src/windows/InAppBrowserProxy.js
+++ b/src/windows/InAppBrowserProxy.js
@@ -135,7 +135,12 @@ var IAB = {
 
 if (target === "_system") {
 url = new Windows.Foundation.Uri(strUrl);
-Windows.System.Launcher.launchUriAsync(url);
+var options = new Windows.System.LauncherOptions();
+if (url.schemeName === 'data') {
+options.contentType = "text/html";
+}
+
+Windows.System.Launcher.launchUriAsync(url, options);
 } else if (target === "_self" || !target) {
 window.location = strUrl;
 } else {


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> InAppBrowser - Cannot open data URLs in system browser
>

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2017-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175074#comment-16175074
 ] 

ASF GitHub Bot commented on CB-12969:
-

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227
  
Why is there a conflict in windows/InAppBrowserProxy.js? That needs to be 
fixed before getting merged in. 


> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2017-08-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127035#comment-16127035
 ] 

ASF GitHub Bot commented on CB-12969:
-

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227
  
@filmaj, sure, my congratulations :)
@stevengill, could you please take a look?


> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2017-08-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127027#comment-16127027
 ] 

ASF GitHub Bot commented on CB-12969:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227
  
Hey, i'm on vacation for the next couple of weeks (getting married!). CAN
you get someone else to review? Perhaps @stevesgill

On Aug 15, 2017 11:50 AM, "Nikita Matrosov" 
wrote:

@filmaj , I've added a section in docs for Data
URIs, could you please take a look?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub

,
or mute the thread


.



> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2017-08-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127016#comment-16127016
 ] 

ASF GitHub Bot commented on CB-12969:
-

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227
  
@filmaj, I've added a section in docs for Data URIs, could you please take 
a look?


> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2017-07-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103264#comment-16103264
 ] 

ASF GitHub Bot commented on CB-12969:
-

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227
  
@filmaj, I would expand this section 
(https://github.com/apache/cordova-plugin-inappbrowser#more-usage-info) by 
adding samples with Data URIs.

But, for now, I found that this patch doesn't work on windows with data URI 
in case of using `_blank` target. Not sure, whether it supposed to work.


> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2017-07-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098639#comment-16098639
 ] 

ASF GitHub Bot commented on CB-12969:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227
  
The reason I ask is I am wondering if / how the documentation or the API 
reference for this plugin would change as a result.

And I wouldn't test against all those platforms, I personally test against 
Android, iOS, Windows and Browser.


> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2017-07-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098218#comment-16098218
 ] 

ASF GitHub Bot commented on CB-12969:
-

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227
  
Seems that it's supported on browser platform only (for now I've verified 
for android, windows, ios, browser platforms). I've updated PR to add support 
for windows platform.
@filmaj, should I check all platforms from this list: 
https://github.com/apache/cordova-plugin-inappbrowser#supported-platforms?


> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2017-07-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093331#comment-16093331
 ] 

ASF GitHub Bot commented on CB-12969:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227
  
Is this supported on any platforms other than iOS?


> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2017-07-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092924#comment-16092924
 ] 

ASF GitHub Bot commented on CB-12969:
-

GitHub user matrosov-nikita opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227

CB-12969 android: Added support for data URIs



### Platforms affected
Android

### What does this PR do?
Adds support for data Uri (e.g. `'data:text/html, 
Hello'`)

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matrosov-nikita/cordova-plugin-inappbrowser 
CB-12969

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #227


commit d2a30038852165fcc4233dd13f03d3cc1eedc77c
Author: Nikita Matrosov 
Date:   2017-07-19T10:51:34Z

CB-12969 android: Added support for data URIs




> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2017-07-19 Thread Nikita Matrosov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092853#comment-16092853
 ] 

Nikita Matrosov commented on CB-12969:
--

[~Sachitra], seems there are some limitations to launch Safari with data Uri 
and we have no control over it:
https://stackoverflow.com/questions/641461/iphone-open-data-url-in-safari
https://issues.apache.org/jira/browse/CB-3302

> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2017-07-17 Thread Sachitra Malwatte (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089432#comment-16089432
 ] 

Sachitra Malwatte commented on CB-12969:


Thanks [~Nikita Matrosov],
I 'll use the fix given for Android and let you know.
A fix for iOS is greatly appreciated as well. ehehehe :)

> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

2017-07-14 Thread Nikita Matrosov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087106#comment-16087106
 ] 

Nikita Matrosov commented on CB-12969:
--

[~Sachitra], I've been working on this bug. Here's fix for Android: 
https://github.com/matrosov-nikita/cordova-plugin-inappbrowser/commit/01af013f25c71a5208e7b642344717376a046f2f

> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org