subject:"\[jira\] \[Commented\] \(CB\-13396\) Splash screen images are resized incorrectly on iPhone X"

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636107#comment-16636107
 ] 

ASF GitHub Bot commented on CB-13396:
-

kenmickles commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-426427107
 
 
   @janpio I don't even remember what this did at this point. Gonna close the 
PR...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>Priority: Major
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636108#comment-16636108
 ] 

ASF GitHub Bot commented on CB-13396:
-

kenmickles closed pull request #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/ios/CDVSplashScreen.m b/src/ios/CDVSplashScreen.m
index ab97055a..fdab6ee3 100644
--- a/src/ios/CDVSplashScreen.m
+++ b/src/ios/CDVSplashScreen.m
@@ -352,7 +352,15 @@ - (void)updateBounds
 if ([self isUsingCDVLaunchScreen]) {
 // CB-9762's launch screen expects the image to fill the screen and be 
scaled using AspectFill.
 CGSize viewportSize = [UIApplication 
sharedApplication].delegate.window.bounds.size;
-_imageView.frame = CGRectMake(0, 0, viewportSize.width, 
viewportSize.height);
+CGFloat imageHeight = viewportSize.height;
+
+// make LaunchStoryboard bottom space constraint work with iOS 11 safe 
areas
+if (@available(iOS 11.0, *)) {
+UIEdgeInsets safeAreaInsets = [UIApplication 
sharedApplication].delegate.window.safeAreaInsets;
+imageHeight -= safeAreaInsets.bottom;
+}
+
+_imageView.frame = CGRectMake(0, 0, viewportSize.width, imageHeight);
 _imageView.contentMode = UIViewContentModeScaleAspectFill;
 return; 
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>Priority: Major
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636053#comment-16636053
 ] 

ASF GitHub Bot commented on CB-13396:
-

janpio commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-426412447
 
 
   @kenmickles Tests are failing on iOS, app cannot be built. Can you have a 
look please? Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>Priority: Major
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-04-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446898#comment-16446898
 ] 

ASF GitHub Bot commented on CB-13396:
-

dodomui commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-383314578
 
 
   @Lazza, thanks. I see... it's nothing with Ionic..
   
   Erm... I am using cordova IOS 4.3.1 with cordova-plugin-splashscreen 5.0.2.
   Splashscreen for iphoneX will always having flashing effect as the 
splashscreen move down a bit.
   
   Can solve the problem by using lastest cordova IOS but it doesn't support 
IOS 8, so I need keep to Cordova IOS 4.3.1.
   
   I can solve the iphoneX splashscreen flashing issue by applying @kenmickles 
solution.
   But it cause another issue that the bottom of the iphoneX splashscreen 
starting with transparent bottom at the safe area, and showing the background 
page in the bottom safe area...
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>Priority: Major
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-04-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446889#comment-16446889
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-383313157
 
 
   @dodomui first of all, you should not need the hook with the latest version 
so try that before all.   Secondly, I do not know why you are referring to 
Ionic, this is nothing Ionic specific.
   
   Finally, hooks are script and they must be made executable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>Priority: Major
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-04-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445840#comment-16445840
 ] 

ASF GitHub Bot commented on CB-13396:
-

dodomui commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-383119469
 
 
   Hi @Lazza, I'm new to ionic.
   Wonder if you could kindly advise to fix the splashcreen resizing 
automatically while startup.
   
   I'm using Ionic 1 + cordova 4.3.1 due to need to support IOS 8 for my app.
   There's only one files under hooks/after_prepare/ which is 
010_add_platform_class.js
   Tried add a new file hooks/after_prepare/fix_splash_ios11.sh
   But received below error.
   Error: spawn EACCES
   
   [ERROR] An error occurred while running cordova build ios (exit code 1).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>Priority: Major
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315395#comment-16315395
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355837859
 
 
   > That's why I created the other issue
   
   In fact this is great.
   
   > My intention is not to pollute this issue with unrelated comments
   
   My remarks were obviously addressed to the people leaving comments unrelated 
to the **white bottom margin problem** that this GitHub comment thread is 
about. Not to you.
   
   > anybody can use whatever they want
   
   Fair enough, but generally developers tend to prefer solutions that are:
   
   - new and recommended by the core developers
   - less prone to bugs
   - more maintainable
   - easier to use
   
   This is why they *"should"* use it, not *"must"* use it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315388#comment-16315388
 ] 

ASF GitHub Bot commented on CB-13396:
-

jcesarmobile commented on issue #135: CB-13396: (ios) Fix image sizing on 
iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355837438
 
 
   > this is a different issue
   Yes, it's a different issue, but there are a few people in this issue 
complaining about the other issue that wasn't reported because it's not clear 
that this PR is for when using storyboard and they are not using storyboard. 
   That's why I created the other issue, fixed it and pointed the people to the 
other issue instead of complaining here. My intention is not to pollute this 
issue with unrelated comments, it's the opposite, to point them to the right 
issue.
   
   > the previous method is old anyways and people should just use the 
storyboard one
   
   The old method is still supported and anybody can use whatever they want
   
   > Hence this discussion should not be polluted with unrelated topics.
   
   The other topic is related, the title says "Fix image sizing on iPhone X", 
and people enter hopping that it fixes their issues with iPhone X image sizing, 
but it doesn't, the other issue fixes it.
   
   Anyway, no discussion should be polluted in PRs, Apache Cordova uses JIRA 
for the issues, so all the discussions should be in the related JIRA and not 
here.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315390#comment-16315390
 ] 

ASF GitHub Bot commented on CB-13396:
-

jcesarmobile commented on issue #135: CB-13396: (ios) Fix image sizing on 
iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355837438
 
 
   > this is a different issue
   
   Yes, it's a different issue, but there are a few people in this issue 
complaining about the other issue that wasn't reported because it's not clear 
that this PR is for when using storyboard and they are not using storyboard. 
   That's why I created the other issue, fixed it and pointed the people to the 
other issue instead of complaining here. My intention is not to pollute this 
issue with unrelated comments, it's the opposite, to point them to the right 
issue.
   
   > the previous method is old anyways and people should just use the 
storyboard one
   
   The old method is still supported and anybody can use whatever they want
   
   > Hence this discussion should not be polluted with unrelated topics.
   
   The other topic is related, the title says "Fix image sizing on iPhone X", 
and people enter hopping that it fixes their issues with iPhone X image sizing, 
but it doesn't, the other issue fixes it.
   
   Anyway, no discussion should be polluted in PRs, Apache Cordova uses JIRA 
for the issues, so all the discussions should be in the related JIRA and not 
here.
   
 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315381#comment-16315381
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355836250
 
 
   > The other problem is not reported (or I couldn't find it), but splash 
screen doesn't work fine on iPhone X when NOT using storyboard
   
   OK, but:
   
   1. this is a different issue
   2. the previous method is old anyways and people should just use the 
storyboard one
   
   Hence this discussion should not be polluted with unrelated topics.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315369#comment-16315369
 ] 

ASF GitHub Bot commented on CB-13396:
-

jcesarmobile commented on issue #135: CB-13396: (ios) Fix image sizing on 
iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355835035
 
 
   @Drewster727 @iisdan and any other using the legacy splash screen files 
instead of the launch storyboard, can you test this PR? it should fix your 
problems https://github.com/apache/cordova-plugin-splashscreen/pull/146
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-07 Thread jcesarmobile (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315242#comment-16315242
 ] 

jcesarmobile commented on CB-13396:
---

[~kenmickles] can you provide your config.xml or something helpful to reproduce 
and see if this is already fixed or not? (as some comments claim in the PR)

> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315239#comment-16315239
 ] 

ASF GitHub Bot commented on CB-13396:
-

jcesarmobile commented on issue #135: CB-13396: (ios) Fix image sizing on 
iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355820652
 
 
   People here is talking about 2 different issues, this one is about incorrect 
sizing when transitioning from the storyboard to the plugin screen and seems to 
be fixed, so this PR might not be necessary. The other problem is not reported 
(or I couldn't find it), but splash screen doesn't work fine on iPhone X when 
NOT using storyboard, I'm about to report it and fix it. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311918#comment-16311918
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355377691
 
 
   @iisdan there is **absolutely no** white bottom margin in the screenshot you 
provided.
   
   If the image is displaced it might be due to incorrectly sized PNG files. 
Check that you are generating all the correct PNG sizes for every size, or just 
use `cordova-splash` instead (it's more convenient).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311762#comment-16311762
 ] 

ASF GitHub Bot commented on CB-13396:
-

iisdan commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355354819
 
 
   @Lazza something is still going on, ios 4.5.4 still having the issue 
   
![img_0274](https://user-images.githubusercontent.com/2072523/34577644-dfded384-f14f-11e7-9a91-d8ebe3e79b2b.jpg)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311764#comment-16311764
 ] 

ASF GitHub Bot commented on CB-13396:
-

iisdan commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355354819
 
 
   @Lazza something is still going on, ios 4.5.4 still having the issue. Starts 
off fine and then moves to the side. 
   
![img_0274](https://user-images.githubusercontent.com/2072523/34577644-dfded384-f14f-11e7-9a91-d8ebe3e79b2b.jpg)
   
 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311736#comment-16311736
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355349973
 
 
   As mentioned here:
   
   
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342994247
   
   It has been fixed in CB-13505: https://github.com/apache/cordova-ios/pull/345


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311737#comment-16311737
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355349973
 
 
   As mentioned here: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342994247
   
   It has been fixed in CB-13505: https://github.com/apache/cordova-ios/pull/345
 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311688#comment-16311688
 ] 

ASF GitHub Bot commented on CB-13396:
-

iisdan commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355341540
 
 
   @Lazza I'm on 4.5.4 and I'm still having this issue 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311642#comment-16311642
 ] 

ASF GitHub Bot commented on CB-13396:
-

scottwio commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355335583
 
 
   @Lazza what version of cordova-ios contains this fix?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311176#comment-16311176
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355255090
 
 
   @iisdan This was already fixed upstream by `cordova-ios` and these changes 
were not necessary.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310559#comment-16310559
 ] 

ASF GitHub Bot commented on CB-13396:
-

iisdan commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355174454
 
 
   This is important, eta on merge? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268206#comment-16268206
 ] 

ASF GitHub Bot commented on CB-13396:
-

EternallLight commented on issue #135: CB-13396: (ios) Fix image sizing on 
iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347427236
 
 
   @Drewster727 
   I had an issue with uploading to iTunes Connect though - “Your binary is not 
optimized for iPhone 5” (ITMS-90096) when submitting. 
   It started working only when I brought back legacy launch screen and 
specified both Launch Image Source and Launch Image File in the Xcode project 
settings.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267725#comment-16267725
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347353420
 
 
   @EternallLight  thanks for the instructions. I confirmed this fixed my 
issue. Looks like any issues we were having are related to the legacy-splash 
screen method.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266957#comment-16266957
 ] 

ASF GitHub Bot commented on CB-13396:
-

EternallLight commented on issue #135: CB-13396: (ios) Fix image sizing on 
iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347222370
 
 
   @Drewster727 
   
   I started with standard sizes as listen in the documentation: 
   
   2x* | universal | any | any | 2732x2732 | Default@2x~universal~anyany.png
   2x | universal | com | any | 1278x2732 | Default@2x~universal~comany.png
   2x | universal | com | com | 1334x750 | Default@2x~universal~comcom.png
   3x* | universal | any | any | 2208x2208 | Default@3x~universal~anyany.png
   3x | universal | any | com | 2208x1242 | Default@3x~universal~anycom.png
   3x | universal | com | any | 1242x2208 | Default@3x~universal~comany.png
   
   The reason why I didn't do this initially, is that for some reason it didn't 
work with another file path than specified in documentation (I had it available 
in resources/ios/splash, but they must be in res/screen/ios.
   
   I created all these images, put them in res/screen/ios, run `cordova 
prepare`, and they all appeared in Images.xassets/LaunchStoryboard as they're 
supposed to be, and the issue with iPhone X was gone.
   
   Note that you often need to re-install the app, on your phone or simulator 
in order to see the changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266935#comment-16266935
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347214473
 
 
   I personally use 
[`cordova-splash`](https://github.com/AlexDisler/cordova-splash) to generate 
those automatically. Never had any issue after using the hook (or the fixed 
`cordova-ios` version).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266931#comment-16266931
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347214473
 
 
   I personally use https://github.com/AlexDisler/cordova-splash to generate 
those automatically. Never had any issue after using the hook (or the fixed 
`cordova-ios` version).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266925#comment-16266925
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347213069
 
 
   @EternallLight can you list the sizes? Kind of a pain, but I may try it...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266810#comment-16266810
 ] 

ASF GitHub Bot commented on CB-13396:
-

EternallLight commented on issue #135: CB-13396: (ios) Fix image sizing on 
iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347098127
 
 
   @Drewster727 I'm having the same issue. Updated to 4.5.4, the constraints 
fix seem to be already applied. Any ideas?
   
   *UPD*.
   I fixed this. In my case it was happening because I messed up with splash 
screens and used a launch images set (had an image for each screen size) 
instead of the LaunchStoryboard approach. Once I figured the difference and 
made universal images like any-any, com-any and any-com, it started working on 
each iPhone and iPad, including iPhone X.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266448#comment-16266448
 ] 

ASF GitHub Bot commented on CB-13396:
-

EternallLight commented on issue #135: CB-13396: (ios) Fix image sizing on 
iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347098127
 
 
   @Drewster727 I'm having the same issue. Updated to 4.5.4, the constraints 
fix seem to be already applied. Any ideas?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266087#comment-16266087
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347018801
 
 
   @myrsk thanks! Unfortunately that didn't fix my issue. Might be easier if I 
attach screenshots. My issue may be slightly different... I start out on the X 
with a correctly sized image, and then it changes to an incorrect sized image 
(no bars on top or bottom like other folks). 
   
   Right when the app starts up:
   
   https://user-images.githubusercontent.com/4528753/33241855-a7e5bc1a-d299-11e7-9edd-825f9408594a.png;>
   
   A couple seconds after the above image, it switches to this: 
   (notice this is not fitting the screen anymore)
   
   https://user-images.githubusercontent.com/4528753/33241857-ac4b51b6-d299-11e7-805f-d38d9de52112.png;>
   
   I have debugged the CDVSplashScreen.m file and can't quite figure out what's 
causing this. I did add some code to detect the iPhoneX and force loading the 
-2643h splash file. When I did that I notice that instead of an incorrectly 
sized image, I get a white screen after my correctly sized image.
   
   I've also tried the cordova-ios nightly builds. Did not resolve my issue. 
   
   cordova-cli 7.1.0
   cordova-ios 4.5.4
   cordova-plugin-splashscreen 4.1.0
   
   plugins:
   com.lampa.startapp 0.1.4 "startApp"
   cordova-plugin-app-preferences 0.99.3 "AppPreferences"
   cordova-plugin-appavailability 0.4.2 "AppAvailability"
   cordova-plugin-apprate 1.3.0 "AppRate"
   cordova-plugin-crosswalk-webview 2.3.0 "Crosswalk WebView Engine"
   cordova-plugin-device 1.1.7 "Device"
   cordova-plugin-dialogs 1.3.4 "Notification"
   cordova-plugin-directions 0.4.4 "Directions"
   cordova-plugin-geolocation 3.0.0 "Geolocation"
   cordova-plugin-globalization 1.0.8 "Globalization"
   cordova-plugin-inappbrowser 1.7.2 "InAppBrowser"
   cordova-plugin-statusbar 2.3.0 "StatusBar"
   cordova-plugin-whitelist 1.3.3 "Whitelist"
   ionic-plugin-keyboard 2.2.1 "Keyboard"
   
   Anyone have any ideas? I only see this symptom on the iPhone X


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266085#comment-16266085
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347018801
 
 
   @myrsk thanks! Unfortunately that didn't fix my issue. Might be easier if I 
attach screenshots. My issue may be slightly different... I start out on the X 
with a correctly sized image, and then it changes to an incorrect sized image 
(no bars on top or bottom like other folks). 
   
   Right when the app starts up:
   
   https://user-images.githubusercontent.com/4528753/33241855-a7e5bc1a-d299-11e7-9edd-825f9408594a.png;>
   
   A couple seconds after the above image, it switches to this: 
   (notice this is not fitting the screen anymore)
   
   https://user-images.githubusercontent.com/4528753/33241857-ac4b51b6-d299-11e7-805f-d38d9de52112.png;>
   
   I have debugged the CDVSplashScreen.m file and can't quite figure out what's 
causing this. I did add some code to detect the iPhoneX and force loading the 
-2643h splash file. When I did that I notice that instead of an incorrectly 
sized image, I get a white screen after my correctly sized image.
   
   I've also tried the cordova-ios nightly builds. Did not resolve my issue. 
   
   cordova-cli 7.1.0
   cordova-ios 4.5.4
   cordova-plugin-splashscreen 4.1.0
   
   Anyone have any ideas? I only see this symptom on the iPhone X


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266084#comment-16266084
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347018801
 
 
   @myrsk thanks! Unfortunately that didn't fix my issue. Might be easier if I 
attach screenshots. My issue may be slightly different... I start out on the X 
with a correctly sized image, and then it changes to an incorrect sized image 
(no bars on top or bottom like other folks). 
   
   Right when the app starts up:
   https://user-images.githubusercontent.com/4528753/33241855-a7e5bc1a-d299-11e7-9edd-825f9408594a.png;>
   
   A couple seconds after the above image, it switches to this:
   https://user-images.githubusercontent.com/4528753/33241857-ac4b51b6-d299-11e7-805f-d38d9de52112.png;>
   
   I have debugged the CDVSplashScreen.m file and can't quite figure out what's 
causing this. I did add some code to detect the iPhoneX and force loading the 
-2643h splash file. When I did that I notice that instead of an incorrectly 
sized image, I get a white screen after my correctly sized image.
   
   I've also tried the cordova-ios nightly builds. Did not resolve my issue. 
   
   cordova-cli 7.1.0
   cordova-ios 4.5.4
   cordova-plugin-splashscreen 4.1.0
   
   Anyone have any ideas? I only see this symptom on the iPhone X


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266066#comment-16266066
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347018801
 
 
   @myrsk thanks! Unfortunately that didn't fix my issue. Might be easier if I 
attach screenshots. My issue may be slightly different... I start out on the X 
with a correctly sized image, and then it changes to an incorrect sized image 
(no bars on top or bottom like other folks). 
   
   Right when the app starts up:
   https://user-images.githubusercontent.com/4528753/33241855-a7e5bc1a-d299-11e7-9edd-825f9408594a.png;>
   
   A couple seconds after the above image, it switches to this:
   https://user-images.githubusercontent.com/4528753/33241857-ac4b51b6-d299-11e7-805f-d38d9de52112.png;>
   
   I have debugged the CDVSplashScreen.m file and can't quite figure out what's 
causing this. I did add some code to detect the iPhoneX and force loading the 
-2643h splash file. When I did that I notice that instead of an incorrectly 
sized image, I get a white screen after my correctly sized image.
   
   cordova-cli 7.1.0
   cordova-ios 4.5.4
   cordova-plugin-splashscreen 4.1.0
   
   Anyone have any ideas?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266068#comment-16266068
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347018801
 
 
   @myrsk thanks! Unfortunately that didn't fix my issue. Might be easier if I 
attach screenshots. My issue may be slightly different... I start out on the X 
with a correctly sized image, and then it changes to an incorrect sized image 
(no bars on top or bottom like other folks). 
   
   Right when the app starts up:
   https://user-images.githubusercontent.com/4528753/33241855-a7e5bc1a-d299-11e7-9edd-825f9408594a.png;>
   
   A couple seconds after the above image, it switches to this:
   https://user-images.githubusercontent.com/4528753/33241857-ac4b51b6-d299-11e7-805f-d38d9de52112.png;>
   
   I have debugged the CDVSplashScreen.m file and can't quite figure out what's 
causing this. I did add some code to detect the iPhoneX and force loading the 
-2643h splash file. When I did that I notice that instead of an incorrectly 
sized image, I get a white screen after my correctly sized image.
   
   cordova-cli 7.1.0
   cordova-ios 4.5.4
   cordova-plugin-splashscreen 4.1.0
   
   Anyone have any ideas? I only see this symptom on the iPhone X


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266063#comment-16266063
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347018801
 
 
   @myrsk thanks! Unfortunately that didn't fix my issue. Might be easier if I 
attach screenshots. My issue may be slightly different... I start out on the X 
with a correctly sized image, and then it changes to an incorrect sized image 
(no bars on top or bottom like other folks). 
   
   Right when the app starts up:
   https://user-images.githubusercontent.com/4528753/33241855-a7e5bc1a-d299-11e7-9edd-825f9408594a.png;>
   
   A couple seconds after the above image, it switches to this:
   https://user-images.githubusercontent.com/4528753/33241857-ac4b51b6-d299-11e7-805f-d38d9de52112.png;>
   
   I have debugged the CDVSplashScreen.m file and can't quite figure out what's 
causing this. I did add some code to detect the iPhoneX and force loading the 
-2643h splash file. When I did that I notice that instead of an incorrectly 
sized image, I get a white screen after my correctly sized image.
   
   Anyone have any ideas?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266060#comment-16266060
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347018801
 
 
   @myrsk thanks! Unfortunately that didn't fix my issue. Might be easier if I 
attach screenshots. My issue may be slightly different... I start out on the X 
with a correctly sized image, and then it changes to an incorrect sized image 
(no bars on top or bottom like other folks). 
   
   Right when the app starts up:
   https://user-images.githubusercontent.com/4528753/33241801-f93d88b4-d298-11e7-9893-78c7c3da3b33.png;>
   
   A couple seconds after the above image, it switches to this:
   https://user-images.githubusercontent.com/4528753/33241805-0d0dcafc-d299-11e7-855e-7651624cf319.png;>
   
   I have debugged the CDVSplashScreen.m file and can't quite figure out what's 
causing this. I did add some code to detect the iPhoneX and force loading the 
-2643h splash file. When I did that I notice that instead of an incorrectly 
sized image, I get a white screen after my correctly sized image.
   
   Anyone have any ideas?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265900#comment-16265900
 ] 

ASF GitHub Bot commented on CB-13396:
-

myrsk commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-346981260
 
 
   @Drewster727 
   
   Open up the file in /platforms/ios/[Your App 
Name]/CDVLaunchScreen.storyboard (in any editor).
   
   Go down to the constraints section.
   
   Replace the following line
   
   ``
   
   with
   
   ``
   
   Save and rebuild the app.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265889#comment-16265889
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-346976779
 
 
   @myrak what exactly did you modify? I'd like to do the same so I can publish 
my app. Did you just do the same thing that Lazza's script did?
   
   I can confirm the hook did not fix my issue either. @Lazza 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265888#comment-16265888
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-346976779
 
 
   @myrak what exactly did you modify? I'd like to do the same so I can publish 
my app. Did you just do the same thing that Lazza's script did?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265703#comment-16265703
 ] 

ASF GitHub Bot commented on CB-13396:
-

myrsk commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-346938514
 
 
   Even after adding a hook, i was still facing issues. However, I edited the 
file manually and removed the hook. Worked fine on everything. No more jumps  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265379#comment-16265379
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-346744923
 
 
   I appear to be having this issue. I did see where you said they resolved it, 
but it happens only in the iphone x simulator. Splash shows up correctly, then 
bam, switches to a different incorrect size.
   
   cordova-cli 7.1.0
   cordova-ios 4.5.4
   cordova-plugin-splashscreen 4.1.0
   
   Any ideas?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265377#comment-16265377
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-346744923
 
 
   I appear to be having this issue. I did see where you said they resolved it, 
but it happens only in the iphone x simulator. Splash shows up correctly, then 
bam, switches to a different incorrect size.
   
   cordova-cli 7.1.0
   cordova-ios 4.5.4 (master)
   cordova-plugin-splashscreen 4.1.0
   
   Any ideas?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265370#comment-16265370
 ] 

ASF GitHub Bot commented on CB-13396:
-

saurabhgupta050890 commented on issue #135: CB-13396: (ios) Fix image sizing on 
iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-346854939
 
 
   @gdvsbp Could you share your Cordova environment details 
   
   I have this setup
   cordova-cli 7.0.1
   cordova-ios 4.5.4
   cordova-plugin-splashscreen (4.1.0)
   
   And having this issue 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265357#comment-16265357
 ] 

ASF GitHub Bot commented on CB-13396:
-

gdvsbp commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-346849258
 
 
   This issue has been resolved for my team with the latest official release of 
this plugin, no hooks necessary or installing from master necessary. Both the 
simulator and an actual iPhone X device are now working as expected. I didn’t 
wind up trying @Lazza’s solution so I can’t comment on that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265325#comment-16265325
 ] 

ASF GitHub Bot commented on CB-13396:
-

saurabhgupta050890 commented on issue #135: CB-13396: (ios) Fix image sizing on 
iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-346839283
 
 
   Having same trouble in iPhoneX simulator. 
   
   @Lazza tried your solution also. Not working


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264927#comment-16264927
 ] 

ASF GitHub Bot commented on CB-13396:
-

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-346744923
 
 
   I appear to be having this issue. I did see where you said they resolved it, 
but it happens only in the iphone x simulator. Splash shows up correctly, then 
bam, switches to a different incorrect size.
   
   cordova-ios 4.5.4 (master)
   cordova-plugin-splashscreen (4.1.0)
   
   Any ideas?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246107#comment-16246107
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-343228882
 
 
   @myrsk apologies, the hook I posted had a typo. I wrote `-f` instead of 
`-d`. This is why it didn't work for you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246105#comment-16246105
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-334784983
 
 
   Actually, the code of this plugin needs not be changed. However, the 
`cordova-ios` template needs a fix. I am using `cordova-ios@4.5.1` and I've 
added this into `hooks/after_prepare/fix_splash_ios11.sh`:
   
   ```
   #!/bin/bash
   
   if [ ! -d platforms/ios ]; then
   exit 0
   fi
   
   
   NAME="$(find platforms/ios/ -name 'CDVLaunchScreen.storyboard')"
   sed -i '' 's_secondItem="xb3-aO-Qok" 
secondAttribute="top"_secondItem="Ze5-6b-2t3" secondAttribute="bottom"_g' 
"$NAME"
   ```
   
   Basically, there is a wrong constraint in `CDVLaunchScreen.storyboard`. If 
this is fixed, nothing else needs to be changed.
   
   I have created a relevant issue on JIRA: 
https://issues.apache.org/jira/browse/CB-13411


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244925#comment-16244925
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342994247
 
 
   They fixed it: https://github.com/apache/cordova-ios/pull/345


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244755#comment-16244755
 ] 

ASF GitHub Bot commented on CB-13396:
-

gdvsbp commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342958327
 
 
   @myrsk Deployments to actual devices will be affected too. Until CB-13411 or 
CB-13396 get resolved it looks like that hook is the only option we've got for 
fixing things. Hopefully some action happens with those soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244721#comment-16244721
 ] 

ASF GitHub Bot commented on CB-13396:
-

gdvsbp commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342958327
 
 
   @myrsk Deployments to actual devices will be affected too. Until CB-13411 or 
CB-13396 get resolved it looks like that hook is the only option we've got for 
fixing things. Hopefully some action happens with those soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244544#comment-16244544
 ] 

ASF GitHub Bot commented on CB-13396:
-

myrsk commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342922918
 
 
   Tried it on a real iphonex device too, still jumps, and shows that little 
white area to begin with, and then goes to the real splash page ...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243537#comment-16243537
 ] 

ASF GitHub Bot commented on CB-13396:
-

myrsk commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342749416
 
 
   Hmm, will this be effected if i ionic build, and it does Building for iPhone 
SE Simulator.
   
   Then in xcode I run it as iphonex?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243525#comment-16243525
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342745457
 
 
   Did you make the shell script executable? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243528#comment-16243528
 ] 

ASF GitHub Bot commented on CB-13396:
-

myrsk commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342746252
 
 
   Yes, it was executable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243383#comment-16243383
 ] 

ASF GitHub Bot commented on CB-13396:
-

myrsk commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342712131
 
 
   I have tried the fix, unforunately, the splash jumps from a smaller image on 
iphonex simulator (with small white space below), and then goes to the normal 
size splashscreen.
   
   Your help is appreciated.
   
   Similar issue to this: 
https://forum.ionicframework.com/t/ionic-3-splashscreen-bottom-gap-on-iphone-x-and-load-twice/111254
   
   Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242790#comment-16242790
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342606034
 
 
   @remisture sorry for the late reply. Great!
   
   I have now edited my previous comment so that it is a bit more clear.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242787#comment-16242787
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-334784983
 
 
   Actually, the code of this plugin needs not be changed. However, the 
`cordova-ios` template needs a fix. I am using `cordova-ios@4.5.1` and I've 
added this into `hooks/after_prepare/fix_splash_ios11.sh`:
   
   ```
   #!/bin/bash
   
   if [ ! -f platforms/ios ]; then
   exit 0
   fi
   
   
   NAME="$(find platforms/ios/ -name 'CDVLaunchScreen.storyboard')"
   sed -i '' 's_secondItem="xb3-aO-Qok" 
secondAttribute="top"_secondItem="Ze5-6b-2t3" secondAttribute="bottom"_g' 
"$NAME"
   ```
   
   Basically, there is a wrong constraint in `CDVLaunchScreen.storyboard`. If 
this is fixed, nothing else needs to be changed.
   
   I have created a relevant issue on JIRA: 
https://issues.apache.org/jira/browse/CB-13411


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242778#comment-16242778
 ] 

ASF GitHub Bot commented on CB-13396:
-

remisture commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342604327
 
 
   It worked, @Lazza! Thanks :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241950#comment-16241950
 ] 

ASF GitHub Bot commented on CB-13396:
-

remisture commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342474325
 
 
   @Lazza Yes, I can try. What's the name of the file i'm adding? I have never 
added a hook before.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241948#comment-16241948
 ] 

ASF GitHub Bot commented on CB-13396:
-

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342473668
 
 
   @remisture could you test the hook I suggested in the comments above? IMHO 
it's the easiest fix and it would help if other users confirm that it works.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241946#comment-16241946
 ] 

ASF GitHub Bot commented on CB-13396:
-

remisture commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-342473190
 
 
   Any updates on this issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-10-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199428#comment-16199428
 ] 

ASF GitHub Bot commented on CB-13396:
-

Github user Lazza commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/135
  
I would suggest not changing the code because the issue is going to vanish 
as soon as CB-13411 is fixed.


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-10-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199421#comment-16199421
 ] 

ASF GitHub Bot commented on CB-13396:
-

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/135
  
The `@available(iOS 11.0, *)` won't compile on Xcode 8, you should wrap 
your code in 
```
#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 11
// your code
#endif
```

@kerrishotts can you take a look into the code?


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-10-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194729#comment-16194729
 ] 

ASF GitHub Bot commented on CB-13396:
-

Github user Lazza commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/135
  
Actually, the code of this plugin need not be changed. However, the 
`cordova-ios` template needs a fix. I am using `cordova-ios@4.5.1` and I've 
added this to my `hooks/after_prepare/` directory:

```
NAME="$(find platforms/ios/ -name 'CDVLaunchScreen.storyboard')"
sed -i '' 's_secondItem="xb3-aO-Qok" 
secondAttribute="top"_secondItem="Ze5-6b-2t3" secondAttribute="bottom"_g' 
"$NAME"
```

Basically, there is a wrong constraint in `CDVLaunchScreen.storyboard`. If 
this is fixed, nothing else needs to be changed.


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2017-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192036#comment-16192036
 ] 

ASF GitHub Bot commented on CB-13396:
-

GitHub user kenmickles opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/135

CB-13396: (ios) Fix image sizing on iOS 11



### Platforms affected

iOS11 / iPhone X

### What does this PR do?

Prevent splash image from jumping around when CDVLaunchScreen.storyboard 
transitions to CDVSplashScreen.

### What testing has been done on this change?

Tested in these simulators:
- iPhone 6s / iOS 9.3
- iPhone 7 Plus / iOS 10.3
- iPhone 8 / iOS 11.0
- iPhone X / iOS 11.0

And on one device:
- iPhone 7 / iOS 11.0.1

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kenmickles/cordova-plugin-splashscreen master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #135


commit 2223bd9eeedd512ad51c5981c19ba57395031e37
Author: Ken Mickles 
Date:   2017-10-04T17:23:42Z

CB-13396: (ios) Fix image sizing on iOS 11




> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

67 matches

Mail list logo