[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[
https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378040#comment-16378040
]
ASF GitHub Bot commented on CB-13523:
-
shazron closed pull request #358: CB-13523: Pass automaticProvisioning to build
step
URL: https://github.com/apache/cordova-ios/pull/358
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/bin/templates/scripts/cordova/lib/build.js
b/bin/templates/scripts/cordova/lib/build.js
index b68262e9d..b102152b2 100644
--- a/bin/templates/scripts/cordova/lib/build.js
+++ b/bin/templates/scripts/cordova/lib/build.js
@@ -171,7 +171,7 @@ module.exports.run = function (buildOpts) {
// remove the build/device folder before building
return spawn('rm', [ '-rf', buildOutputDir ], projectPath)
.then(function () {
-var xcodebuildArgs = getXcodeBuildArgs(projectName,
projectPath, configuration, buildOpts.device, buildOpts.buildFlag,
emulatorTarget);
+var xcodebuildArgs = getXcodeBuildArgs(projectName,
projectPath, configuration, buildOpts.device, buildOpts.buildFlag,
emulatorTarget, buildOpts.automaticProvisioning);
return spawn('xcodebuild', xcodebuildArgs, projectPath);
});
@@ -268,9 +268,10 @@ module.exports.findXCodeProjectIn = findXCodeProjectIn;
* @param {Boolean} isDevice Flag that specify target for package
(device/emulator)
* @param {Array} buildFlags
* @param {String} emulatorTarget Target for emulator (rather than default)
+ * @param {Boolean} autoProvisioning Whether to allow Xcode to
automatically update provisioning
* @return {Array} Array of arguments that could be passed
directly to spawn method
*/
-function getXcodeBuildArgs (projectName, projectPath, configuration, isDevice,
buildFlags, emulatorTarget) {
+function getXcodeBuildArgs (projectName, projectPath, configuration, isDevice,
buildFlags, emulatorTarget, autoProvisioning) {
var xcodebuildArgs;
var options;
var buildActions;
@@ -307,6 +308,10 @@ function getXcodeBuildArgs (projectName, projectPath,
configuration, isDevice, b
if (customArgs.sdk) {
customArgs.otherFlags = customArgs.otherFlags.concat(['-sdk',
customArgs.sdk]);
}
+
+if (autoProvisioning) {
+options = options.concat(['-allowProvisioningUpdates']);
+}
} else { // emulator
options = [
'-xcconfig', customArgs.xcconfig || path.join(__dirname, '..',
'build-' + configuration.toLowerCase() + '.xcconfig'),
diff --git a/tests/spec/unit/build.spec.js b/tests/spec/unit/build.spec.js
index 4b123361f..df5304284 100644
--- a/tests/spec/unit/build.spec.js
+++ b/tests/spec/unit/build.spec.js
@@ -181,6 +181,29 @@ describe('build', function () {
expect(args.length).toEqual(17);
done();
});
+
+it('should generate appropriate args for automatic provisioning',
function (done) {
+var isDevice = true;
+var args = getXcodeBuildArgs('TestProjectName', testProjectPath,
'TestConfiguration', isDevice, null, null, true);
+expect(args[0]).toEqual('-xcconfig');
+expect(args[1]).toEqual(path.join('/test',
'build-testconfiguration.xcconfig'));
+expect(args[2]).toEqual('-workspace');
+expect(args[3]).toEqual('TestProjectName.xcworkspace');
+expect(args[4]).toEqual('-scheme');
+expect(args[5]).toEqual('TestProjectName');
+expect(args[6]).toEqual('-configuration');
+expect(args[7]).toEqual('TestConfiguration');
+expect(args[8]).toEqual('-destination');
+expect(args[9]).toEqual('generic/platform=iOS');
+expect(args[10]).toEqual('-archivePath');
+expect(args[11]).toEqual('TestProjectName.xcarchive');
+expect(args[12]).toEqual('-allowProvisioningUpdates');
+expect(args[13]).toEqual('archive');
+expect(args[14]).toEqual('CONFIGURATION_BUILD_DIR=' +
path.join(testProjectPath, 'build', 'device'));
+expect(args[15]).toEqual('SHARED_PRECOMPS_DIR=' +
path.join(testProjectPath, 'build', 'sharedpch'));
+expect(args.length).toEqual(16);
+done();
+});
});
describe('getXcodeArchiveArgs method', function () {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378041#comment-16378041 ] ASF subversion and git services commented on CB-13523: -- Commit 28e7ac1474163c8a43e6adf5474da6298a4e0afa in cordova-ios's branch refs/heads/master from [~dpogue] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=28e7ac1 ] CB-13523: Pass automaticProvisioning to build step (#358) > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > Fix For: cordova-ios@4.5.4 > > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377878#comment-16377878 ] ASF GitHub Bot commented on CB-13523: - dpogue commented on issue #358: CB-13523: Pass automaticProvisioning to build step URL: https://github.com/apache/cordova-ios/pull/358#issuecomment-368712730 Note this isn't enabled by default, it requires specifying `"automaticProvisioning": true` in build.json config, or as a `--automaticProvisioning` flag to the command This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > Fix For: cordova-ios@4.5.4 > > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377876#comment-16377876 ] ASF GitHub Bot commented on CB-13523: - shazron commented on issue #358: CB-13523: Pass automaticProvisioning to build step URL: https://github.com/apache/cordova-ios/pull/358#issuecomment-368712330 This flag is an Xcode 9 feature, so we need to bump this as well: https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/check_reqs.js#L29 I'm surprised that we still have that at 7... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > Fix For: cordova-ios@4.5.4 > > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377581#comment-16377581 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #358: CB-13523: Pass automaticProvisioning to build step URL: https://github.com/apache/cordova-ios/pull/358#issuecomment-368652042 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=h1) Report > Merging [#358](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/f8a817bc8e7c1925c0c4ec7b474ec2ce48f1643d?src=pr=desc) will **increase** coverage by `0.04%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=tree) ```diff @@Coverage Diff @@ ## master #358 +/- ## == + Coverage 63.95% 63.99% +0.04% == Files 14 14 Lines1695 1697 +2 Branches 285 286 +1 == + Hits 1084 1086 +2 Misses611 611 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/358/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `37.2% <75%> (+0.58%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=footer). Last update [f8a817b...44c02e3](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > Fix For: cordova-ios@4.5.4 > > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377582#comment-16377582 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #358: CB-13523: Pass automaticProvisioning to build step URL: https://github.com/apache/cordova-ios/pull/358#issuecomment-368652042 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=h1) Report > Merging [#358](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/f8a817bc8e7c1925c0c4ec7b474ec2ce48f1643d?src=pr=desc) will **increase** coverage by `0.04%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=tree) ```diff @@Coverage Diff @@ ## master #358 +/- ## == + Coverage 63.95% 63.99% +0.04% == Files 14 14 Lines1695 1697 +2 Branches 285 286 +1 == + Hits 1084 1086 +2 Misses611 611 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/358/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `37.2% <75%> (+0.58%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=footer). Last update [f8a817b...44c02e3](https://codecov.io/gh/apache/cordova-ios/pull/358?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > Fix For: cordova-ios@4.5.4 > > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377570#comment-16377570 ] ASF GitHub Bot commented on CB-13523: - dpogue opened a new pull request #358: CB-13523: Pass automaticProvisioning to build step URL: https://github.com/apache/cordova-ios/pull/358 ### Platforms affected iOS ### What does this PR do? Passes `-allowProvisioningUpdates` to the build/archive step. We are already passing it to the export step (https://github.com/apache/cordova-ios/pull/347) but it's also worth having it here. ### What testing has been done on this change? Testing on Ayogo's Jenkins instance and was able to successfully make an iOS build without any manual steps to set up certificates or provisioning profiles. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > Fix For: cordova-ios@4.5.4 > > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[
https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277313#comment-16277313
]
ASF GitHub Bot commented on CB-13523:
-
surajpindoria closed pull request #762: CB-13523: Add automaticProvisioning to
iOS signing docs
URL: https://github.com/apache/cordova-docs/pull/762
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/www/docs/en/dev/guide/platforms/ios/index.md
b/www/docs/en/dev/guide/platforms/ios/index.md
index de400e6fe..2c6300a77 100644
--- a/www/docs/en/dev/guide/platforms/ios/index.md
+++ b/www/docs/en/dev/guide/platforms/ios/index.md
@@ -160,10 +160,11 @@ To sign an app, you need the following parameters:
| Parameter| Flag | Description
|--|--|---
| Code Sign Identity | `--codeSignIdentity` | Code signing identity
to use for signing. It can be created with Xcode and added to your keychain.
Starting with Xcode 8 you should use `--codeSignIdentity="iPhone Developer"`
both for `debug` and `release`.
-| Provisioning Profile | `--provisioningProfile` | GUID of the
provisioning profile to be used for signing. It is copied here on your Mac:
```~/Library/MobileDevice/Provisioning\ Profiles/```. Opening it in a text
editor, you can find the GUID which needs to be specified here.
-| Code Sign Resource Rules | `--codesignResourceRules`| (Optional) Used to
control which files in a bundle should be sealed by a code signature. For more
details, read [The OS X Code Signing In Depth
article](https://developer.apple.com/library/mac/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG206)
-| Development Team | `--developmentTeam` | This is new for Xcode
8. The development team ([Team
ID](https://developer.apple.com/account/#/membership/)) to use for code
signing. You would use this setting and a simplified Code Sign Identity (i.e.
just 'iPhone Developer') to sign your apps, you do not need to provide a
Provisioning Profile.
+| Development Team | `--developmentTeam` | The development team
([Team ID](https://developer.apple.com/account/#/membership/)) to use for code
signing. You would use this setting and a simplified Code Sign Identity (i.e.
just 'iPhone Developer') to sign your apps, you do not need to provide a
Provisioning Profile.
| Packaging Type | `--packageType` | This will determine
what type of build is generated by Xcode. Valid options are `development` (the
default), `enterprise`, `ad-hoc`, and `app-store`.
+| Provisioning Profile | `--provisioningProfile` | (Optional) GUID of the
provisioning profile to be used for manual signing. It is copied here on your
Mac: ```~/Library/MobileDevice/Provisioning\ Profiles/```. Opening it in a text
editor, you can find the GUID which needs to be specified here if using manual
signing.
+| Code Sign Resource Rules | `--codesignResourceRules`| (Optional) Used to
control which files in a bundle should be sealed by a code signature. For more
details, read [The OS X Code Signing In Depth
article](https://developer.apple.com/library/mac/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG206)
+| Automatic Provisioning | `--automaticProvisioning`| (Optional) Enable to
allow Xcode to automatically manage provisioning profiles. Valid options are
`false` (the default) and `true`.
### Using build.json
@@ -171,7 +172,7 @@ Alternatively, you could specify them in a build
configuration file (`build.json
using the `--buildConfig` argument to the same commands. Here's a sample of a
build configuration file:
-Xcode 8 and iOS 10:
+For automatic signing, where provisioning profiles are managed automatically
by Xcode (recommended):
```json
{
@@ -180,6 +181,7 @@ Xcode 8 and iOS 10:
"codeSignIdentity": "iPhone Developer",
"developmentTeam": "FG35JLLMXX4A",
"packageType": "development",
+"automaticProvisioning": true,
"buildFlag": [
"EMBEDDED_CONTENT_CONTAINS_SWIFT = YES",
"ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES=NO",
@@ -190,6 +192,7 @@ Xcode 8 and iOS 10:
"codeSignIdentity": "iPhone Developer",
"developmentTeam": "FG35JLLMXX4A",
"packageType": "app-store",
+"automaticProvisioning": true,
"buildFlag": [
"EMBEDDED_CONTENT_CONTAINS_SWIFT = YES",
"ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES=NO",
@@ -200,7 +203,7 @@ Xcode 8 and iOS 10:
}
```
-Earlier versions:
+For manual signing, specifying the
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277311#comment-16277311 ] ASF GitHub Bot commented on CB-13523: - surajpindoria commented on issue #762: CB-13523: Add automaticProvisioning to iOS signing docs URL: https://github.com/apache/cordova-docs/pull/762#issuecomment-349075699 Cool! Forgot about this PR, merging in! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue > Fix For: cordova-ios@4.5.4 > > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277269#comment-16277269 ] ASF GitHub Bot commented on CB-13523: - dpogue commented on issue #762: CB-13523: Add automaticProvisioning to iOS signing docs URL: https://github.com/apache/cordova-docs/pull/762#issuecomment-349068903 This has now been released in Cordova-iOS 4.5.4 and can be merged This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue > Fix For: cordova-ios@4.5.4 > > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254329#comment-16254329 ] ASF subversion and git services commented on CB-13523: -- Commit 0e5e38c6bf144d99c85d5ad0cfb9180ff7ffca5b in cordova-ios's branch refs/heads/4.5.x from [~dpogue] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=0e5e38c ] CB-13523: Add flag for Xcode-managed provisioning This adds a `automaticProvisioning` option to the build config which passes flags to xcodebuild during the exporting step that allow it to automatically create and update provisioning profiles for automatic code signing. > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253944#comment-16253944 ] ASF GitHub Bot commented on CB-13523: - dpogue commented on issue #762: CB-13523: Add automaticProvisioning to iOS signing docs URL: https://github.com/apache/cordova-docs/pull/762#issuecomment-344690609 The `--automaticProvisioning` flag won't be available until the next iOS release This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253941#comment-16253941 ] ASF GitHub Bot commented on CB-13523: - stevengill commented on issue #762: CB-13523: Add automaticProvisioning to iOS signing docs URL: https://github.com/apache/cordova-docs/pull/762#issuecomment-344690096 LGTM. @dpogue ready to merge or wait until after next iOS release? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252954#comment-16252954 ] ASF GitHub Bot commented on CB-13523: - dpogue opened a new pull request #762: CB-13523: Add automaticProvisioning to iOS signing docs URL: https://github.com/apache/cordova-docs/pull/762 Docs side of https://github.com/apache/cordova-ios/commit/5cb8bd199fe8df85272678d6d4c6343dd080f2a3 Also tried to clean up the manual flags to indicate that automatic signing is generally recommended, and you should only need to specify a provisioningProfile UUID if you're using manual signing. ### Platforms affected iOS ### What does this PR do? Adds docs for the `--automaticProvisioning` option This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252737#comment-16252737 ] ASF subversion and git services commented on CB-13523: -- Commit 5cb8bd199fe8df85272678d6d4c6343dd080f2a3 in cordova-ios's branch refs/heads/master from [~dpogue] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=5cb8bd1 ] CB-13523: Add flag for Xcode-managed provisioning This adds a `automaticProvisioning` option to the build config which passes flags to xcodebuild during the exporting step that allow it to automatically create and update provisioning profiles for automatic code signing. > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[
https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252736#comment-16252736
]
ASF GitHub Bot commented on CB-13523:
-
surajpindoria closed pull request #347: CB-13523: Add flag for Xcode-managed
provisioning
URL: https://github.com/apache/cordova-ios/pull/347
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/bin/templates/scripts/cordova/build
b/bin/templates/scripts/cordova/build
index 61d26cca3..bd5a61947 100755
--- a/bin/templates/scripts/cordova/build
+++ b/bin/templates/scripts/cordova/build
@@ -42,6 +42,7 @@ var buildOpts = nopt({
'codeSignIdentity': String,
'codeSignResourceRules': String,
'provisioningProfile': String,
+'automaticProvisioning': Boolean,
'developmentTeam': String,
'packageType': String,
'buildConfig' : String,
diff --git a/bin/templates/scripts/cordova/lib/build.js
b/bin/templates/scripts/cordova/lib/build.js
index f51b084c1..b68262e9d 100644
--- a/bin/templates/scripts/cordova/lib/build.js
+++ b/bin/templates/scripts/cordova/lib/build.js
@@ -97,7 +97,7 @@ module.exports.run = function (buildOpts) {
var buildType = buildOpts.release ? 'release' : 'debug';
var config = buildConfig.ios[buildType];
if (config) {
-['codeSignIdentity', 'codeSignResourceRules',
'provisioningProfile', 'developmentTeam', 'packageType', 'buildFlag',
'iCloudContainerEnvironment'].forEach(
+['codeSignIdentity', 'codeSignResourceRules',
'provisioningProfile', 'developmentTeam', 'packageType', 'buildFlag',
'iCloudContainerEnvironment', 'automaticProvisioning'].forEach(
function (key) {
buildOpts[key] = buildOpts[key] || config[key];
});
@@ -225,7 +225,7 @@ module.exports.run = function (buildOpts) {
}
function packageArchive () {
-var xcodearchiveArgs = getXcodeArchiveArgs(projectName,
projectPath, buildOutputDir, exportOptionsPath);
+var xcodearchiveArgs = getXcodeArchiveArgs(projectName,
projectPath, buildOutputDir, exportOptionsPath,
buildOpts.automaticProvisioning);
return spawn('xcodebuild', xcodearchiveArgs, projectPath);
}
@@ -337,15 +337,16 @@ function getXcodeBuildArgs (projectName, projectPath,
configuration, isDevice, b
* @param {String} projectPathPath to project file. Will be used to
set CWD for xcodebuild
* @param {String} outputPath Output directory to contain the IPA
* @param {String} exportOptionsPath Path to the exportOptions.plist file
+ * @param {Boolean} autoProvisioning Whether to allow Xcode to
automatically update provisioning
* @return {Array} Array of arguments that could be
passed directly to spawn method
*/
-function getXcodeArchiveArgs (projectName, projectPath, outputPath,
exportOptionsPath) {
+function getXcodeArchiveArgs (projectName, projectPath, outputPath,
exportOptionsPath, autoProvisioning) {
return [
'-exportArchive',
'-archivePath', projectName + '.xcarchive',
'-exportOptionsPlist', exportOptionsPath,
'-exportPath', outputPath
-];
+].concat(autoProvisioning ? ['-allowProvisioningUpdates'] : []);
}
function parseBuildFlag (buildFlag, args) {
diff --git a/bin/templates/scripts/cordova/run
b/bin/templates/scripts/cordova/run
index 470384b52..c4cfca30a 100755
--- a/bin/templates/scripts/cordova/run
+++ b/bin/templates/scripts/cordova/run
@@ -45,6 +45,7 @@ var opts = nopt({
'codeSignIdentity': String,
'codeSignResourceRules': String,
'provisioningProfile': String,
+'automaticProvisioning': Boolean,
'buildConfig' : String,
'noSign' : Boolean
}, { 'd' : '--verbose' }, args);
diff --git a/tests/spec/unit/build.spec.js b/tests/spec/unit/build.spec.js
index 6cf005c80..4b123361f 100644
--- a/tests/spec/unit/build.spec.js
+++ b/tests/spec/unit/build.spec.js
@@ -199,6 +199,20 @@ describe('build', function () {
expect(archiveArgs.length).toEqual(7);
done();
});
+
+it('should generate the appropriate arguments for automatic
provisioning', function (done) {
+var archiveArgs = getXcodeArchiveArgs('TestProjectName',
testProjectPath, '/test/output/path', '/test/export/options/path', true);
+expect(archiveArgs[0]).toEqual('-exportArchive');
+expect(archiveArgs[1]).toEqual('-archivePath');
+expect(archiveArgs[2]).toEqual('TestProjectName.xcarchive');
+expect(archiveArgs[3]).toEqual('-exportOptionsPlist');
+
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247690#comment-16247690 ] ASF GitHub Bot commented on CB-13523: - janpio commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-343510505 Nice. (Side note: Please make sure that the new option also gets documented - these definitely need documentation) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238231#comment-16238231 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `40%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == - Coverage 63.43% 63.41% -0.02% == Files 14 14 Lines1690 1692 +2 Branches 283 284 +1 == + Hits 1072 1073 +1 - Misses618 619 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.44% <40%> (+0.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...110b084](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238232#comment-16238232 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `40%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == - Coverage 63.43% 63.41% -0.02% == Files 14 14 Lines1690 1692 +2 Branches 283 284 +1 == + Hits 1072 1073 +1 - Misses618 619 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.44% <40%> (+0.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...110b084](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237185#comment-16237185 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `40%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == - Coverage 63.43% 63.41% -0.02% == Files 14 14 Lines1690 1692 +2 Branches 283 284 +1 == + Hits 1072 1073 +1 - Misses618 619 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.44% <40%> (+0.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...301f6d5](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237039#comment-16237039 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `50%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == - Coverage 63.43% 63.41% -0.02% == Files 14 14 Lines1690 1692 +2 Branches 283 284 +1 == + Hits 1072 1073 +1 - Misses618 619 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.44% <50%> (+0.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...9bd5306](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237050#comment-16237050 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `50%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == - Coverage 63.43% 63.41% -0.02% == Files 14 14 Lines1690 1692 +2 Branches 283 284 +1 == + Hits 1072 1073 +1 - Misses618 619 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.44% <50%> (+0.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...9bd5306](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237047#comment-16237047 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `50%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == - Coverage 63.43% 63.41% -0.02% == Files 14 14 Lines1690 1692 +2 Branches 283 284 +1 == + Hits 1072 1073 +1 - Misses618 619 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.44% <50%> (+0.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...9bd5306](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237048#comment-16237048 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `50%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == - Coverage 63.43% 63.41% -0.02% == Files 14 14 Lines1690 1692 +2 Branches 283 284 +1 == + Hits 1072 1073 +1 - Misses618 619 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.44% <50%> (+0.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...9bd5306](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236596#comment-16236596 ] ASF subversion and git services commented on CB-13523: -- Commit 333c8790401bc7555c29026e27f288e289f64d89 in cordova-ios's branch refs/heads/automatic-provisioning from [~dpogue] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=333c879 ] CB-13523: Add flag for Xcode-managed provisioning This adds a `automaticProvisioning` option to the build config which passes flags to xcodebuild during the exporting step that allow it to automatically create and update provisioning profiles for automatic code signing. > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235778#comment-16235778 ] Darryl Pogue commented on CB-13523: --- The buildFlags are only passed to xcodebuild during the building/archiving step, not during the export step that generates the final .ipa file (and I suspect it might be invalid to specify most of the buildFlags during an export) > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235558#comment-16235558 ] Michael Schmidt commented on CB-13523: -- Using the existing tooling with the option buildFlags I should be able to pass on '-allowProvisioningUpdates' to xcodebuild - which currently doesn't work (yet), see CB-13525. Just to understand better: what requires introducing a specific flag for this? I could just pass it with the regular buildFlags option. > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16230561#comment-16230561 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == + Coverage 63.43% 63.45% +0.02% == Files 14 14 Lines1690 1691 +1 Branches 283 284 +1 == + Hits 1072 1073 +1 Misses618 618 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.61% <66.66%> (+0.29%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...333c879](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16230465#comment-16230465 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == + Coverage 63.43% 63.45% +0.02% == Files 14 14 Lines1690 1691 +1 Branches 283 284 +1 == + Hits 1072 1073 +1 Misses618 618 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.61% <66.66%> (+0.29%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...333c879](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16230588#comment-16230588 ] ASF GitHub Bot commented on CB-13523: - codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == + Coverage 63.43% 63.45% +0.02% == Files 14 14 Lines1690 1691 +1 Branches 283 284 +1 == + Hits 1072 1073 +1 Misses618 618 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `36.61% <66.66%> (+0.29%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=footer). Last update [aaf229b...333c879](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Major > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227791#comment-16227791 ] ASF GitHub Bot commented on CB-13523: - dpogue opened a new pull request #347: CB-13523: Add flag for Xcode-managed provisioning (DON'T MERGE) URL: https://github.com/apache/cordova-ios/pull/347 ### Platforms affected iOS with Xcode 9 ### What does this PR do? This adds a `automaticProvisioning` option to the build config which passes flags to xcodebuild during the exporting step that allow it to automatically create and update provisioning profiles for automatic code signing. I don't love that we're adding even more random stuff to the build config, but I suspect most people don't want this to be enabled by default. ### What testing has been done on this change? Added a case to existing spec tests. Will be testing this branch on my work's CI system with our ongoing projects, and will update the PR title when I've verified it's working as intended. ### Checklist - [x] Reported [CB-13523](https://issues.apache.org/jira/browse/CB-13523) - [x] Commit message follows the format - [x] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
