[jira] [Commented] (CB-6160) adding plugin fails for Firefoxos.
[ https://issues.apache.org/jira/browse/CB-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175103#comment-14175103 ] Maxime LUCE commented on CB-6160: - Is this issue still valid ? It seems fixed in : https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/firefoxos.js#L29. Can we resolve this issue ? adding plugin fails for Firefoxos. --- Key: CB-6160 URL: https://issues.apache.org/jira/browse/CB-6160 Project: Apache Cordova Issue Type: Bug Components: Plugman Reporter: Gert-Jan Braas Priority: Blocker reason: No xml_helpers defined ( in src/platforms/firefoxos.js) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6160) adding plugin fails for Firefoxos.
[ https://issues.apache.org/jira/browse/CB-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175133#comment-14175133 ] Gert-Jan Braas commented on CB-6160: Yes. I think that's OK. It was a blocker, and it seems to be fixed adding plugin fails for Firefoxos. --- Key: CB-6160 URL: https://issues.apache.org/jira/browse/CB-6160 Project: Apache Cordova Issue Type: Bug Components: Plugman Reporter: Gert-Jan Braas Priority: Blocker reason: No xml_helpers defined ( in src/platforms/firefoxos.js) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6160) adding plugin fails for Firefoxos.
[ https://issues.apache.org/jira/browse/CB-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944000#comment-13944000 ] Bart van Velden commented on CB-6160: - issues seem similar adding plugin fails for Firefoxos. --- Key: CB-6160 URL: https://issues.apache.org/jira/browse/CB-6160 Project: Apache Cordova Issue Type: Bug Components: Plugman Reporter: Gert-Jan Braas Priority: Blocker reason: No xml_helpers defined ( in src/platforms/firefoxos.js) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6160) adding plugin fails for Firefoxos.
[ https://issues.apache.org/jira/browse/CB-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940010#comment-13940010 ] Piotr Zalewa commented on CB-6160: -- Ping. What test should be run to test plugman? We need this shipped. I believe bug was introduced in 0.20.1 or 0.20.2 I will try tomorrow, but I haven't been working on plugman yet adding plugin fails for Firefoxos. --- Key: CB-6160 URL: https://issues.apache.org/jira/browse/CB-6160 Project: Apache Cordova Issue Type: Bug Components: Plugman Reporter: Gert-Jan Braas Priority: Blocker reason: No xml_helpers defined ( in src/platforms/firefoxos.js) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6160) adding plugin fails for Firefoxos.
[ https://issues.apache.org/jira/browse/CB-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940024#comment-13940024 ] Piotr Zalewa commented on CB-6160: -- As far as I can get this merge is actually in master here: https://github.com/apache/cordova-plugman/blob/master/src/platforms/firefoxos.js#L4 Can we please ship it? adding plugin fails for Firefoxos. --- Key: CB-6160 URL: https://issues.apache.org/jira/browse/CB-6160 Project: Apache Cordova Issue Type: Bug Components: Plugman Reporter: Gert-Jan Braas Priority: Blocker reason: No xml_helpers defined ( in src/platforms/firefoxos.js) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6160) adding plugin fails for Firefoxos.
[ https://issues.apache.org/jira/browse/CB-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13936120#comment-13936120 ] Gert-Jan Braas commented on CB-6160: It's tested on my CB-6160 branch on github with 'npm test'. I'm afraid I'm not aware of any other tests. how does a 2-line change in src/platforms/firefoxos.js affect anything in android, ios or blackberry10? if I look at [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=78e3650 ] it seems to me there is a lot more changed than just the alteration I made. adding plugin fails for Firefoxos. --- Key: CB-6160 URL: https://issues.apache.org/jira/browse/CB-6160 Project: Apache Cordova Issue Type: Bug Components: Plugman Reporter: Gert-Jan Braas Priority: Blocker reason: No xml_helpers defined ( in src/platforms/firefoxos.js) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6160) adding plugin fails for Firefoxos.
[
https://issues.apache.org/jira/browse/CB-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935756#comment-13935756
]
Josh Soref commented on CB-6160:
[~stevegill]: That merge is unfortunate.
cordova create yip; cd yip; cordova platform add android ios blackberry10; node
--debug-brk cordova plugin add org.cordova.mobile-spec-dependencies
--searchpath ~/Cordova/cordova-mobile-spec; cordova plugin remove
org.cordova.mobile-spec-dependencies; cordova plugin
Failed to install 'org.cordova.mobile-spec-dependencies':TypeError: Arguments
to path.join must be strings
at path.js:360:15
at Array.filter (native)
at Object.exports.join (path.js:358:36)
at cordova-plugman/src/install.js:338:39
commit ae2ce7ac6325d1c6558365b4be82e5a8ff0983b9
Author: [~jbondc]
+dep.subdir = path.join(dep.subdir.split('/'));
...
-dep_subdir = path.join.apply(null,
dep_subdir.split('/'));
Broke this. I'm not sure what sort of testing people are doing. But I'm not a
fan. At the very least the test which I'm showing above should pass for each
and every change to plugman.
adding plugin fails for Firefoxos.
---
Key: CB-6160
URL: https://issues.apache.org/jira/browse/CB-6160
Project: Apache Cordova
Issue Type: Bug
Components: Plugman
Reporter: Gert-Jan Braas
Priority: Blocker
reason:
No xml_helpers defined ( in src/platforms/firefoxos.js)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6160) adding plugin fails for Firefoxos.
[ https://issues.apache.org/jira/browse/CB-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935788#comment-13935788 ] Josh Soref commented on CB-6160: Even with that, I get: Error: ENOENT, no such file or directory '.../Cordova/cordova-mobile-spec/plugin.xml' at Object.fs.openSync (fs.js:427:18) at Object.fs.readFileSync (fs.js:284:15) at Object.module.exports.parseElementtreeSync (cordova-plugman/src/util/xml-helpers.js:119:27) It should be looking for: .../Cordova/cordova-mobile-spec/dependencies-plugin/plugin.xml adding plugin fails for Firefoxos. --- Key: CB-6160 URL: https://issues.apache.org/jira/browse/CB-6160 Project: Apache Cordova Issue Type: Bug Components: Plugman Reporter: Gert-Jan Braas Priority: Blocker reason: No xml_helpers defined ( in src/platforms/firefoxos.js) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6160) adding plugin fails for Firefoxos.
[ https://issues.apache.org/jira/browse/CB-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930642#comment-13930642 ] ASF subversion and git services commented on CB-6160: - Commit 78e3650e9b483fa1e98bfe01458a00b76d422446 in cordova-plugman's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=78e3650 ] Merge branch 'CB-6160' of github.com:Steckelfisch/cordova-plugman adding plugin fails for Firefoxos. --- Key: CB-6160 URL: https://issues.apache.org/jira/browse/CB-6160 Project: Apache Cordova Issue Type: Bug Components: Plugman Reporter: Gert-Jan Braas Priority: Blocker reason: No xml_helpers defined ( in src/platforms/firefoxos.js) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6160) adding plugin fails for Firefoxos.
[ https://issues.apache.org/jira/browse/CB-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919231#comment-13919231 ] Gert-Jan Braas commented on CB-6160: the lo: braas@chickenrun:~/projects/ligplekkenonderweg/LPOWC$ cordova plugin add org.apache.cordova.dialogs Fetching plugin org.apache.cordova.dialogs via plugin registry Installing org.apache.cordova.dialogs (android) Installing org.apache.cordova.dialogs (firefoxos) ReferenceError: xml_helpers is not defined at Object.module.exports.package_name (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/platforms/firefoxos.js:27:26) at PlatformMunger.generate_plugin_config_munge (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:285:54) at PlatformMunger.add_plugin_changes (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:211:29) at /var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:368:14 at Array.forEach (native) at PlatformMunger_process [as process] (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:367:45) at Object.exports.process (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:77:12) at Object.handlePrepare (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/prepare.js:72:20) at /var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/install.js:413:33 at _fulfilled (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/node_modules/q/q.js:798:54) adding plugin fails for Firefoxos. --- Key: CB-6160 URL: https://issues.apache.org/jira/browse/CB-6160 Project: Apache Cordova Issue Type: Bug Components: Plugman Reporter: Gert-Jan Braas Priority: Blocker reason: No xml_helpers defined ( in src/platforms/firefoxos.js) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6160) adding plugin fails for Firefoxos.
[ https://issues.apache.org/jira/browse/CB-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919302#comment-13919302 ] Gert-Jan Braas commented on CB-6160: fix at: https://github.com/apache/cordova-plugman/pull/61 adding plugin fails for Firefoxos. --- Key: CB-6160 URL: https://issues.apache.org/jira/browse/CB-6160 Project: Apache Cordova Issue Type: Bug Components: Plugman Reporter: Gert-Jan Braas Priority: Blocker reason: No xml_helpers defined ( in src/platforms/firefoxos.js) -- This message was sent by Atlassian JIRA (v6.2#6252)
