[jira] [Commented] (CB-7091) Remove check_requirements from cordova-lib
[ https://issues.apache.org/jira/browse/CB-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079968#comment-14079968 ] ASF subversion and git services commented on CB-7091: - Commit 3fe8c0f47e3598ddcd842ec7c4eb77b07172ee21 in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=3fe8c0f ] CB-7091: Remove check_requirements() funcs from platform parsers No longer used, removing. They were either: 1) Empty 2) Duplicating the chqck_reqs call that is also done by platform create scripts 3) In Ubuntu duplicated the code from check_reqs > Remove check_requirements from cordova-lib > -- > > Key: CB-7091 > URL: https://issues.apache.org/jira/browse/CB-7091 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > > As per this discussion [1] check_requirements() functions in platform parsers > are redundant. The same check is executed twice, once via cordova create > call_into_create() -> platform_parser ... > and then again from the platform create script. > Removing > 1) The call to check_requriements() from create.js:call_into_create(). > 2) The check_requirements() functions from platform parsers in metadata. > Adding: > A simple check that the host OS is listed in platforms[platform].hostos > [1] https://www.mail-archive.com/dev%40cordova.apache.org/msg19084.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7091) Remove check_requirements from cordova-lib
[ https://issues.apache.org/jira/browse/CB-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079963#comment-14079963 ] ASF GitHub Bot commented on CB-7091: Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/67 > Remove check_requirements from cordova-lib > -- > > Key: CB-7091 > URL: https://issues.apache.org/jira/browse/CB-7091 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > > As per this discussion [1] check_requirements() functions in platform parsers > are redundant. The same check is executed twice, once via cordova create > call_into_create() -> platform_parser ... > and then again from the platform create script. > Removing > 1) The call to check_requriements() from create.js:call_into_create(). > 2) The check_requirements() functions from platform parsers in metadata. > Adding: > A simple check that the host OS is listed in platforms[platform].hostos > [1] https://www.mail-archive.com/dev%40cordova.apache.org/msg19084.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7091) Remove check_requirements from cordova-lib
[ https://issues.apache.org/jira/browse/CB-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079943#comment-14079943 ] ASF subversion and git services commented on CB-7091: - Commit 05fa0fe93bccc4b016e471a1b8bd40e5743f8767 in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=05fa0fe ] CB-7091: Remove check_requirements() funcs from platform parsers No longer used, removing. They were either: 1) Empty 2) Duplicating the chqck_reqs call that is also done by platform create scripts 3) In Ubuntu duplicated the code from check_reqs > Remove check_requirements from cordova-lib > -- > > Key: CB-7091 > URL: https://issues.apache.org/jira/browse/CB-7091 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > > As per this discussion [1] check_requirements() functions in platform parsers > are redundant. The same check is executed twice, once via cordova create > call_into_create() -> platform_parser ... > and then again from the platform create script. > Removing > 1) The call to check_requriements() from create.js:call_into_create(). > 2) The check_requirements() functions from platform parsers in metadata. > Adding: > A simple check that the host OS is listed in platforms[platform].hostos > [1] https://www.mail-archive.com/dev%40cordova.apache.org/msg19084.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7091) Remove check_requirements from cordova-lib
[ https://issues.apache.org/jira/browse/CB-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079928#comment-14079928 ] ASF GitHub Bot commented on CB-7091: GitHub user jsoref opened a pull request: https://github.com/apache/cordova-lib/pull/67 CB-7091: Remove check_requirements() funcs from platform parsers No longer used, removing. They were either: 1) Empty 2) Duplicating the chqck_reqs call that is also done by platform create scripts 3) In Ubuntu duplicated the code from check_reqs You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-lib cb_7091 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/67.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #67 commit 05fa0fe93bccc4b016e471a1b8bd40e5743f8767 Author: Josh Soref Date: 2014-07-30T20:32:34Z CB-7091: Remove check_requirements() funcs from platform parsers No longer used, removing. They were either: 1) Empty 2) Duplicating the chqck_reqs call that is also done by platform create scripts 3) In Ubuntu duplicated the code from check_reqs > Remove check_requirements from cordova-lib > -- > > Key: CB-7091 > URL: https://issues.apache.org/jira/browse/CB-7091 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > > As per this discussion [1] check_requirements() functions in platform parsers > are redundant. The same check is executed twice, once via cordova create > call_into_create() -> platform_parser ... > and then again from the platform create script. > Removing > 1) The call to check_requriements() from create.js:call_into_create(). > 2) The check_requirements() functions from platform parsers in metadata. > Adding: > A simple check that the host OS is listed in platforms[platform].hostos > [1] https://www.mail-archive.com/dev%40cordova.apache.org/msg19084.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7091) Remove check_requirements from cordova-lib
[ https://issues.apache.org/jira/browse/CB-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055038#comment-14055038 ] ASF subversion and git services commented on CB-7091: - Commit 153092f2c235185c7f141979a550779800954a92 in cordova-lib's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=153092f ] CB-7091: Remove check_requirements() funcs from platform parsers No longer used, removing. They were either: 1) Empty 2) Duplicating the chqck_reqs call that is also done by platform create scripts 3) In Ubuntu duplicated the code from check_reqs > Remove check_requirements from cordova-lib > -- > > Key: CB-7091 > URL: https://issues.apache.org/jira/browse/CB-7091 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > > As per this discussion [1] check_requirements() functions in platform parsers > are redundant. The same check is executed twice, once via cordova create > call_into_create() -> platform_parser ... > and then again from the platform create script. > Removing > 1) The call to check_requriements() from create.js:call_into_create(). > 2) The check_requirements() functions from platform parsers in metadata. > Adding: > A simple check that the host OS is listed in platforms[platform].hostos > [1] https://www.mail-archive.com/dev%40cordova.apache.org/msg19084.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7091) Remove check_requirements from cordova-lib
[ https://issues.apache.org/jira/browse/CB-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054348#comment-14054348 ] ASF subversion and git services commented on CB-7091: - Commit ab49973560ccb7a1ea37d9f5db4e497ef0ce92d1 in cordova-lib's branch refs/heads/master from [~kamrik] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=ab49973 ] CB-7091: Don't call check_requirements during platform add check_reqs is called from the platform build script, there is no use in calling it twice. Instead, added a simple check that if a platform has a list of compatible host OSs (defined in platforms.js), the host OS is checked against this list. > Remove check_requirements from cordova-lib > -- > > Key: CB-7091 > URL: https://issues.apache.org/jira/browse/CB-7091 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Reporter: Mark Koudritsky >Assignee: Mark Koudritsky > > As per this discussion [1] check_requirements() functions in platform parsers > are redundant. The same check is executed twice, once via cordova create > call_into_create() -> platform_parser ... > and then again from the platform create script. > Removing > 1) The call to check_requriements() from create.js:call_into_create(). > 2) The check_requirements() functions from platform parsers in metadata. > Adding: > A simple check that the host OS is listed in platforms[platform].hostos > [1] https://www.mail-archive.com/dev%40cordova.apache.org/msg19084.html -- This message was sent by Atlassian JIRA (v6.2#6252)
