[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14169876#comment-14169876
]
Mike Billau commented on CB-7499:
-
Thanks Andrew for checking this out.
Agree about the engine tag.
To answer your question, yes plugins should check the API level.
I see you've already pulled in a fix to do this check:
https://github.com/apache/cordova-plugin-dialogs/commit/4cfe290b2a3e8f0aafb71a1ff4fbee4b710c8749
Tested on 2.3.3, looks great. Thanks.
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Fix For: 3.7.0
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170384#comment-14170384
]
Andrew Grieve commented on CB-7499:
---
Hey Mike!
I think that fix is unrelated. The (suspected) problem would be with the call
to
http://developer.android.com/reference/android/view/View.html#setTextDirection(int))
here:
https://github.com/apache/cordova-plugin-dialogs/blob/4cfe290b2a3e8f0aafb71a1ff4fbee4b710c8749/src/android/Notification.java#L184
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Fix For: 3.7.0
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163587#comment-14163587
]
ASF GitHub Bot commented on CB-7499:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/120
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Fix For: 3.7.0
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162382#comment-14162382
]
Andrew Grieve commented on CB-7499:
---
Pretty sure adding the attribute to the manifest is fine.
http://android-developers.blogspot.ca/2013/03/native-rtl-support-in-android-42.html
Users use the play store to enable the app per-language, so I don't see how
this could hurt.
As for the engine tag, I don't think we should add it. This is more like
progressive enhancement since it's 4.2+
Bigger question is whether the plugins should check the android version before
calling setTextDirection() since it was added in level 17 (almost certainly it
should) Mike, can you add this?
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Fix For: 3.7.0
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14135355#comment-14135355
]
Mike Billau commented on CB-7499:
-
Hmmm, this plugin now depends on a specific version of Android (at least for
this feature to work) so maybe I need add in the engine tag to plugin.xml?
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Fix For: 3.7.0
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14135727#comment-14135727
]
ASF subversion and git services commented on CB-7499:
-
Commit d9900a725d84c5629cdb0f783b7ef99ac9d8bb72 in cordova-android's branch
refs/heads/4.0.x from [~mrbillau]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=d9900a7 ]
Second part of CB-7499, support RTL text direction
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Fix For: 3.7.0
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134397#comment-14134397
]
ASF subversion and git services commented on CB-7499:
-
Commit d9900a725d84c5629cdb0f783b7ef99ac9d8bb72 in cordova-android's branch
refs/heads/master from [~mrbillau]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=d9900a7 ]
Second part of CB-7499, support RTL text direction
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134405#comment-14134405
]
ASF GitHub Bot commented on CB-7499:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/32
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126974#comment-14126974
]
ASF GitHub Bot commented on CB-7499:
GitHub user mbillau opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/32
Set dialog text dir to locale
First part of the patch for CB-7499; sets the text direction on dialog
messages to follow the locale.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbillau/cordova-plugin-dialogs CB-7499
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
commit c88acd6ae9b4533d76605ee4876bf914ccd252e0
Author: mbillau mike.bil...@gmail.com
Date: 2014-09-09T13:20:33Z
Set dialog text dir to locale
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127122#comment-14127122
]
ASF GitHub Bot commented on CB-7499:
GitHub user mbillau opened a pull request:
https://github.com/apache/cordova-android/pull/120
Second part of CB-7499, support RTL text direction
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbillau/cordova-android CB-7499
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
commit 88fa4eec948d769b3d0924a40f6e6832fdde29a9
Author: mbillau mike.bil...@gmail.com
Date: 2014-09-09T13:38:15Z
Second part of CB-7499, support RTL text direction
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127130#comment-14127130
]
ASF GitHub Bot commented on CB-7499:
Github user mbillau closed the pull request at:
https://github.com/apache/cordova-android/pull/120
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127131#comment-14127131
]
ASF GitHub Bot commented on CB-7499:
GitHub user mbillau reopened a pull request:
https://github.com/apache/cordova-android/pull/120
Second part of CB-7499, support RTL text direction
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbillau/cordova-android CB-7499
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
commit 88fa4eec948d769b3d0924a40f6e6832fdde29a9
Author: mbillau mike.bil...@gmail.com
Date: 2014-09-09T13:38:15Z
Second part of CB-7499, support RTL text direction
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127129#comment-14127129
]
ASF GitHub Bot commented on CB-7499:
Github user mbillau commented on the pull request:
https://github.com/apache/cordova-android/pull/120#issuecomment-54990566
@infil00p Do you think there will be any issues adding this new attribute
to AndroidManifest.xml?
Cordova dialogs should support BIDI text
Key: CB-7499
URL: https://issues.apache.org/jira/browse/CB-7499
Project: Apache Cordova
Issue Type: Bug
Components: Android, Plugin Dialogs
Affects Versions: Master
Reporter: Mike Billau
Assignee: Mike Billau
Priority: Minor
Labels: bidirectional, globalization
Since API 19, Andorid has had the facilities to deal with bidirectional text,
however, current Cordova notification implementation does not correctly
handle bidirectional text in dialogs.
We can see this is the case by first setting the language to Hebrew and then
launching the following dialogs:
navigator.notification.confirm(Pure English !!!, function(){}, 7);
navigator.notification.confirm(עברית היא שפה מדוברת בIsrael !,
function(){}, 8);
Since we are in Hebrew, the base text direction will be RTL. This means that
when we see the second notification with the Hebrew text, it will be
right-justified. When we click and see the Pure English !!! notication,
because locale is RTL, we should expect to see: !!! Pure English and it
should be right-justified, however, we still see Pure English !!!, left
justified.
http://w3-03.ibm.com/globalization/page/publish/4353
Ideally you should be able to just add android:supportsRtl=true to the
manifest, however, this is doesn't seem to ne enough without setting the text
direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
