[jira] [Commented] (CB-7674) Preference activation no longer occurs in CordovaActivity.onCreate()
[ https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165679#comment-14165679 ] ASF subversion and git services commented on CB-7674: - Commit 0585fd5f32cb010391904c3c0d1eeb52d00dd584 in cordova-amazon-fireos's branch refs/heads/master from [~cmarcelk] [ https://git-wip-us.apache.org/repos/asf?p=cordova-amazon-fireos.git;h=0585fd5 ] CB-7674 move preference activation back into onCreate() The preference creation actually needs to be before super.onCreate(savedInstance) in order to avoid the exception requestFeature() must be called before adding content. Also ran into an issue in the native tests Whitelist and User WebView/Client/Chrome where it would throw an exception that the CordovaWebView appView already had a parent and needed to be removed from that parent before the invocation to root.addView(appView). So I conditionally remove the wrong parent. Also made a change to the native tests so the menus test would work. I also put super.init() back into the template, though invoking it is optional as loadUrl will call it automatically if needed. Conflicts: bin/templates/project/Activity.java Preference activation no longer occurs in CordovaActivity.onCreate() Key: CB-7674 URL: https://issues.apache.org/jira/browse/CB-7674 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.6.0 Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Blocker During the 3.6.0 development timeframe, a modification was made to CordovaActivity.onCreate() to move the activation of preferences to CordovaActivity.init(). For applications that were relying on the activation of preferences in onCreate(), those preferences are no longer active when onCreate() completes, and may break those applications. Although it is described as a subtle change to the API surface in the commit message, this is a breaking change to a public API. https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8 https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803 http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7674) Preference activation no longer occurs in CordovaActivity.onCreate()
[ https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165680#comment-14165680 ] ASF subversion and git services commented on CB-7674: - Commit 5c273343d8bdbe9c843251a56e014207c77e6ac4 in cordova-amazon-fireos's branch refs/heads/master from [~bowserj] [ https://git-wip-us.apache.org/repos/asf?p=cordova-amazon-fireos.git;h=5c27334 ] CB-7674: Added sleep to avoid null error after most recent change to not break API Preference activation no longer occurs in CordovaActivity.onCreate() Key: CB-7674 URL: https://issues.apache.org/jira/browse/CB-7674 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.6.0 Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Blocker During the 3.6.0 development timeframe, a modification was made to CordovaActivity.onCreate() to move the activation of preferences to CordovaActivity.init(). For applications that were relying on the activation of preferences in onCreate(), those preferences are no longer active when onCreate() completes, and may break those applications. Although it is described as a subtle change to the API surface in the commit message, this is a breaking change to a public API. https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8 https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803 http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7674) Preference activation no longer occurs in CordovaActivity.onCreate()
[ https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14155223#comment-14155223 ] Joe Bowser commented on CB-7674: I think this has been resolved, should we close this blocker? Preference activation no longer occurs in CordovaActivity.onCreate() Key: CB-7674 URL: https://issues.apache.org/jira/browse/CB-7674 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.6.0 Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Blocker During the 3.6.0 development timeframe, a modification was made to CordovaActivity.onCreate() to move the activation of preferences to CordovaActivity.init(). For applications that were relying on the activation of preferences in onCreate(), those preferences are no longer active when onCreate() completes, and may break those applications. Although it is described as a subtle change to the API surface in the commit message, this is a breaking change to a public API. https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8 https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803 http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7674) Preference activation no longer occurs in CordovaActivity.onCreate()
[ https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153993#comment-14153993 ] Marcel Kinard commented on CB-7674: --- You've got buy-in from me, as I'm broken. If I can get in a fix tonight that folks are happy with, I'd suggest a re-tag of 3.6.4. Preference activation no longer occurs in CordovaActivity.onCreate() Key: CB-7674 URL: https://issues.apache.org/jira/browse/CB-7674 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.6.0 Reporter: Marcel Kinard Assignee: Marcel Kinard During the 3.6.0 development timeframe, a modification was made to CordovaActivity.onCreate() to move the activation of preferences to CordovaActivity.init(). For applications that were relying on the activation of preferences in onCreate(), those preferences are no longer active when onCreate() completes, and may break those applications. Although it is described as a subtle change to the API surface in the commit message, this is a breaking change to a public API. https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8 https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803 http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7674) Preference activation no longer occurs in CordovaActivity.onCreate()
[ https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154023#comment-14154023 ] Marcel Kinard commented on CB-7674: --- The commit above solves the problem for me. It also cleans up failing native tests. I think it looks good. Comments welcome. Preference activation no longer occurs in CordovaActivity.onCreate() Key: CB-7674 URL: https://issues.apache.org/jira/browse/CB-7674 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.6.0 Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Blocker During the 3.6.0 development timeframe, a modification was made to CordovaActivity.onCreate() to move the activation of preferences to CordovaActivity.init(). For applications that were relying on the activation of preferences in onCreate(), those preferences are no longer active when onCreate() completes, and may break those applications. Although it is described as a subtle change to the API surface in the commit message, this is a breaking change to a public API. https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8 https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803 http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7674) Preference activation no longer occurs in CordovaActivity.onCreate()
[ https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154045#comment-14154045 ] Martin Gonzalez commented on CB-7674: - Changes look good. I've tested the changes using mobilespec, and also android native tests, everything looks good(Android 4.4.2). This changes solves the problem that we've been facing and also this major change on the API. Preference activation no longer occurs in CordovaActivity.onCreate() Key: CB-7674 URL: https://issues.apache.org/jira/browse/CB-7674 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.6.0 Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Blocker During the 3.6.0 development timeframe, a modification was made to CordovaActivity.onCreate() to move the activation of preferences to CordovaActivity.init(). For applications that were relying on the activation of preferences in onCreate(), those preferences are no longer active when onCreate() completes, and may break those applications. Although it is described as a subtle change to the API surface in the commit message, this is a breaking change to a public API. https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8 https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803 http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7674) Preference activation no longer occurs in CordovaActivity.onCreate()
[ https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154142#comment-14154142 ] ASF subversion and git services commented on CB-7674: - Commit 90766ae0faa6594a6f4d6b9d61d66af8e3600b8e in cordova-android's branch refs/heads/3.6.x from [~cmarcelk] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=90766ae ] CB-7674 move preference activation back into onCreate() The preference creation actually needs to be before super.onCreate(savedInstance) in order to avoid the exception requestFeature() must be called before adding content. Also ran into an issue in the native tests Whitelist and User WebView/Client/Chrome where it would throw an exception that the CordovaWebView appView already had a parent and needed to be removed from that parent before the invocation to root.addView(appView). So I conditionally remove the wrong parent. Also made a change to the native tests so the menus test would work. I also put super.init() back into the template, though invoking it is optional as loadUrl will call it automatically if needed. Preference activation no longer occurs in CordovaActivity.onCreate() Key: CB-7674 URL: https://issues.apache.org/jira/browse/CB-7674 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.6.0 Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Blocker During the 3.6.0 development timeframe, a modification was made to CordovaActivity.onCreate() to move the activation of preferences to CordovaActivity.init(). For applications that were relying on the activation of preferences in onCreate(), those preferences are no longer active when onCreate() completes, and may break those applications. Although it is described as a subtle change to the API surface in the commit message, this is a breaking change to a public API. https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8 https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803 http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7674) Preference activation no longer occurs in CordovaActivity.onCreate()
[ https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154141#comment-14154141 ] ASF subversion and git services commented on CB-7674: - Commit 6cbf6b78751f78c62752e8d65df14d448d9eb6c9 in cordova-android's branch refs/heads/master from [~bowserj] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=6cbf6b7 ] CB-7674: Added sleep to avoid null error after most recent change to not break API Preference activation no longer occurs in CordovaActivity.onCreate() Key: CB-7674 URL: https://issues.apache.org/jira/browse/CB-7674 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.6.0 Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Blocker During the 3.6.0 development timeframe, a modification was made to CordovaActivity.onCreate() to move the activation of preferences to CordovaActivity.init(). For applications that were relying on the activation of preferences in onCreate(), those preferences are no longer active when onCreate() completes, and may break those applications. Although it is described as a subtle change to the API surface in the commit message, this is a breaking change to a public API. https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8 https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803 http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7674) Preference activation no longer occurs in CordovaActivity.onCreate()
[ https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154143#comment-14154143 ] ASF subversion and git services commented on CB-7674: - Commit a272fd15319e59a3bd030451ba84c3560bc8eb2b in cordova-android's branch refs/heads/3.6.x from [~bowserj] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=a272fd1 ] CB-7674: Added sleep to avoid null error after most recent change to not break API Preference activation no longer occurs in CordovaActivity.onCreate() Key: CB-7674 URL: https://issues.apache.org/jira/browse/CB-7674 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.6.0 Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Blocker During the 3.6.0 development timeframe, a modification was made to CordovaActivity.onCreate() to move the activation of preferences to CordovaActivity.init(). For applications that were relying on the activation of preferences in onCreate(), those preferences are no longer active when onCreate() completes, and may break those applications. Although it is described as a subtle change to the API surface in the commit message, this is a breaking change to a public API. https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8 https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803 http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7674) Preference activation no longer occurs in CordovaActivity.onCreate()
[ https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154148#comment-14154148 ] Joe Bowser commented on CB-7674: The recent tests for 3.5.1 broke since this slows down the launch of one of the tests. I added sleep to get the test to work, so it's pretty minor. I think keeping the API the same is more important than a second here or there on the 3.x branch. I'm cool with keeping the change on 4.0.x though. Preference activation no longer occurs in CordovaActivity.onCreate() Key: CB-7674 URL: https://issues.apache.org/jira/browse/CB-7674 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.6.0 Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Blocker During the 3.6.0 development timeframe, a modification was made to CordovaActivity.onCreate() to move the activation of preferences to CordovaActivity.init(). For applications that were relying on the activation of preferences in onCreate(), those preferences are no longer active when onCreate() completes, and may break those applications. Although it is described as a subtle change to the API surface in the commit message, this is a breaking change to a public API. https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8 https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803 http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s -- This message was sent by Atlassian JIRA (v6.3.4#6332)
