[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[ https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987809#comment-16987809 ] ASF GitHub Bot commented on DRILL-5844: --- asfgit commented on pull request #1904: DRILL-5844: Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API URL: https://github.com/apache/drill/pull/1904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incorrect values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API > -- > > Key: DRILL-5844 > URL: https://issues.apache.org/jira/browse/DRILL-5844 > Project: Apache Drill > Issue Type: Bug > Components: Client - JDBC, Metadata >Affects Versions: 1.10.0 >Reporter: second88 >Assignee: Arjun Gupta >Priority: Minor > Labels: ready-to-commit > Fix For: 1.17.0 > > > As far as I can see, the values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API of a Drill Connection include: > TABLE > VIEW > SYSTEM_TABLE > According to [JDBC > API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])], > the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", > "LOCAL TEMPORARY", "ALIAS", "SYNONYM". > Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE". > Besides, I wonder if this bug is related to another bug > [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me. > It should be noted that the values of TABLE_TYPE returned from methods > DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be > one-to-one matched with but may not be the same as those in > INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[ https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985365#comment-16985365 ] ASF GitHub Bot commented on DRILL-5844: --- arina-ielchiieva commented on issue #1904: DRILL-5844: Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API URL: https://github.com/apache/drill/pull/1904#issuecomment-559970207 @arjuntheprogrammer all Drill tests won't run on Windows machine, please use unix-based system. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incorrect values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API > -- > > Key: DRILL-5844 > URL: https://issues.apache.org/jira/browse/DRILL-5844 > Project: Apache Drill > Issue Type: Bug > Components: Client - JDBC, Metadata >Affects Versions: 1.10.0 >Reporter: second88 >Assignee: Arjun Gupta >Priority: Minor > Labels: ready-to-commit > Fix For: 1.17.0 > > > As far as I can see, the values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API of a Drill Connection include: > TABLE > VIEW > SYSTEM_TABLE > According to [JDBC > API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])], > the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", > "LOCAL TEMPORARY", "ALIAS", "SYNONYM". > Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE". > Besides, I wonder if this bug is related to another bug > [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me. > It should be noted that the values of TABLE_TYPE returned from methods > DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be > one-to-one matched with but may not be the same as those in > INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[ https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985353#comment-16985353 ] ASF GitHub Bot commented on DRILL-5844: --- arjuntheprogrammer commented on issue #1904: DRILL-5844: Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API URL: https://github.com/apache/drill/pull/1904#issuecomment-559965358 > did you have a chance to fix test failures? Hi @arina-ielchiieva, I made the changes to the file which @vvysotskyi helped me pointing out, but because of some reasons, I am not able to run all the unit tests on Windows machine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incorrect values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API > -- > > Key: DRILL-5844 > URL: https://issues.apache.org/jira/browse/DRILL-5844 > Project: Apache Drill > Issue Type: Bug > Components: Client - JDBC, Metadata >Affects Versions: 1.10.0 >Reporter: second88 >Assignee: Arjun Gupta >Priority: Minor > Labels: ready-to-commit > Fix For: 1.17.0 > > > As far as I can see, the values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API of a Drill Connection include: > TABLE > VIEW > SYSTEM_TABLE > According to [JDBC > API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])], > the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", > "LOCAL TEMPORARY", "ALIAS", "SYNONYM". > Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE". > Besides, I wonder if this bug is related to another bug > [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me. > It should be noted that the values of TABLE_TYPE returned from methods > DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be > one-to-one matched with but may not be the same as those in > INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[ https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985352#comment-16985352 ] ASF GitHub Bot commented on DRILL-5844: --- arjuntheprogrammer commented on issue #1904: DRILL-5844: Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API URL: https://github.com/apache/drill/pull/1904#issuecomment-559965358 > ave a chance to fix test failures? Hi @arina-ielchiieva, I made the changes to the file which @vvysotskyi helped me pointing out, but because of some reasons, I am not able to run all the unit tests on Windows machine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incorrect values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API > -- > > Key: DRILL-5844 > URL: https://issues.apache.org/jira/browse/DRILL-5844 > Project: Apache Drill > Issue Type: Bug > Components: Client - JDBC, Metadata >Affects Versions: 1.10.0 >Reporter: second88 >Assignee: Arjun Gupta >Priority: Minor > Labels: ready-to-commit > Fix For: 1.17.0 > > > As far as I can see, the values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API of a Drill Connection include: > TABLE > VIEW > SYSTEM_TABLE > According to [JDBC > API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])], > the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", > "LOCAL TEMPORARY", "ALIAS", "SYNONYM". > Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE". > Besides, I wonder if this bug is related to another bug > [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me. > It should be noted that the values of TABLE_TYPE returned from methods > DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be > one-to-one matched with but may not be the same as those in > INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[ https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985065#comment-16985065 ] ASF GitHub Bot commented on DRILL-5844: --- arina-ielchiieva commented on issue #1904: DRILL-5844: Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API URL: https://github.com/apache/drill/pull/1904#issuecomment-559819512 @arjuntheprogrammer did you have a chance to fix test failures? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incorrect values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API > -- > > Key: DRILL-5844 > URL: https://issues.apache.org/jira/browse/DRILL-5844 > Project: Apache Drill > Issue Type: Bug > Components: Client - JDBC, Metadata >Affects Versions: 1.10.0 >Reporter: second88 >Assignee: Arjun Gupta >Priority: Minor > Labels: ready-to-commit > Fix For: 1.17.0 > > > As far as I can see, the values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API of a Drill Connection include: > TABLE > VIEW > SYSTEM_TABLE > According to [JDBC > API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])], > the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", > "LOCAL TEMPORARY", "ALIAS", "SYNONYM". > Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE". > Besides, I wonder if this bug is related to another bug > [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me. > It should be noted that the values of TABLE_TYPE returned from methods > DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be > one-to-one matched with but may not be the same as those in > INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[ https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982386#comment-16982386 ] ASF GitHub Bot commented on DRILL-5844: --- vvysotskyi commented on issue #1904: DRILL-5844: Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API URL: https://github.com/apache/drill/pull/1904#issuecomment-558588917 @arjuntheprogrammer, please run **ALL** unit tests before submitting the PR or informing the reviewer that it is ready for review. Your changes cause failures for `TestJdbcMetadata.tablesWithConditions` unit test (not sure about other tests). Please fix it and check that tests run is clean. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incorrect values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API > -- > > Key: DRILL-5844 > URL: https://issues.apache.org/jira/browse/DRILL-5844 > Project: Apache Drill > Issue Type: Bug > Components: Client - JDBC, Metadata >Affects Versions: 1.10.0 >Reporter: second88 >Assignee: Arjun Gupta >Priority: Minor > Labels: ready-to-commit > Fix For: 1.17.0 > > > As far as I can see, the values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API of a Drill Connection include: > TABLE > VIEW > SYSTEM_TABLE > According to [JDBC > API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])], > the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", > "LOCAL TEMPORARY", "ALIAS", "SYNONYM". > Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE". > Besides, I wonder if this bug is related to another bug > [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me. > It should be noted that the values of TABLE_TYPE returned from methods > DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be > one-to-one matched with but may not be the same as those in > INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[ https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981555#comment-16981555 ] ASF GitHub Bot commented on DRILL-5844: --- arjuntheprogrammer commented on issue #1904: DRILL-5844: Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API URL: https://github.com/apache/drill/pull/1904#issuecomment-558159864 @ihuzenko - I have squashed the changes into one commit, please let me know if there is any other thing required. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incorrect values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API > -- > > Key: DRILL-5844 > URL: https://issues.apache.org/jira/browse/DRILL-5844 > Project: Apache Drill > Issue Type: Bug > Components: Client - JDBC, Metadata >Affects Versions: 1.10.0 >Reporter: second88 >Assignee: Arjun Gupta >Priority: Minor > Labels: ready-to-commit > Fix For: 1.17.0 > > > As far as I can see, the values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API of a Drill Connection include: > TABLE > VIEW > SYSTEM_TABLE > According to [JDBC > API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])], > the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", > "LOCAL TEMPORARY", "ALIAS", "SYNONYM". > Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE". > Besides, I wonder if this bug is related to another bug > [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me. > It should be noted that the values of TABLE_TYPE returned from methods > DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be > one-to-one matched with but may not be the same as those in > INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[ https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981375#comment-16981375 ] ASF GitHub Bot commented on DRILL-5844: --- arjuntheprogrammer commented on issue #1904: DRILL-5844: Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API URL: https://github.com/apache/drill/pull/1904#issuecomment-558044517 @ihuzenko - sorry for the delay, there were some problems with my local setup earlier. Now everything is working fine, I ran TestJdbcPluginWithMySQLIT with new changes locally - and it ran successfully. Thanks for pointing out the error. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incorrect values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API > -- > > Key: DRILL-5844 > URL: https://issues.apache.org/jira/browse/DRILL-5844 > Project: Apache Drill > Issue Type: Bug > Components: Client - JDBC, Metadata >Affects Versions: 1.10.0 >Reporter: second88 >Assignee: Arjun Gupta >Priority: Minor > Fix For: 1.17.0 > > > As far as I can see, the values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API of a Drill Connection include: > TABLE > VIEW > SYSTEM_TABLE > According to [JDBC > API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])], > the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", > "LOCAL TEMPORARY", "ALIAS", "SYNONYM". > Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE". > Besides, I wonder if this bug is related to another bug > [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me. > It should be noted that the values of TABLE_TYPE returned from methods > DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be > one-to-one matched with but may not be the same as those in > INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[ https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978548#comment-16978548 ] ASF GitHub Bot commented on DRILL-5844: --- ihuzenko commented on issue #1904: DRILL-5844: Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API URL: https://github.com/apache/drill/pull/1904#issuecomment-556075425 @arjuntheprogrammer, please execute locally both updated tests, I suspect that **TestJdbcPluginWithMySQLIT** won't pass because you didn't update expected results to "VIEW", "SYSTEM VIEW", "TABLE". Since Travis CI limits allowed build time, a lot of slow tests are excluded from the build. Best practice is to build Drill locally using ```mvn clean install``` to ensure that everything is fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incorrect values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API > -- > > Key: DRILL-5844 > URL: https://issues.apache.org/jira/browse/DRILL-5844 > Project: Apache Drill > Issue Type: Bug > Components: Client - JDBC, Metadata >Affects Versions: 1.10.0 >Reporter: second88 >Assignee: Arjun Gupta >Priority: Minor > Fix For: 1.17.0 > > > As far as I can see, the values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API of a Drill Connection include: > TABLE > VIEW > SYSTEM_TABLE > According to [JDBC > API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])], > the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", > "LOCAL TEMPORARY", "ALIAS", "SYNONYM". > Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE". > Besides, I wonder if this bug is related to another bug > [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me. > It should be noted that the values of TABLE_TYPE returned from methods > DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be > one-to-one matched with but may not be the same as those in > INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[
https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978516#comment-16978516
]
ASF GitHub Bot commented on DRILL-5844:
---
arjuntheprogrammer commented on issue #1904: DRILL-5844: Incorrect values of
TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
URL: https://github.com/apache/drill/pull/1904#issuecomment-556054184
> Hi @arjuntheprogrammer , there are a lot of possible options how to check
your fix. One simplest example for **TestJdbcPluginWithH2IT.java** is :
>
> ```java
> @Test
> public void testJdbcTableTypes() throws Exception {
> String query = "select distinct table_type from
information_schema.`tables` " +
> "where table_schema like 'h2%'";
> testBuilder()
> .sqlQuery(query)
> .unOrdered()
> .baselineColumns("table_type")
> .baselineValuesForSingleColumn("SYSTEM TABLE", "TABLE")
> .go();
> }
> ```
>
> similar test could be added to **TestJdbcPluginWithMySQLIT.java**, you'll
only need to change where condition to `mysql%` and update expected results.
@ihuzenko - I have written the test function in both of the files, and build
and test on Travis CI also passed.
Please let me know if this issue requires any other changes.
Thanks for your help.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Incorrect values of TABLE_TYPE returned from method
> DatabaseMetaData.getTables of JDBC API
> --
>
> Key: DRILL-5844
> URL: https://issues.apache.org/jira/browse/DRILL-5844
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC, Metadata
>Affects Versions: 1.10.0
>Reporter: second88
>Assignee: Arjun Gupta
>Priority: Minor
> Fix For: 1.17.0
>
>
> As far as I can see, the values of TABLE_TYPE returned from method
> DatabaseMetaData.getTables of JDBC API of a Drill Connection include:
> TABLE
> VIEW
> SYSTEM_TABLE
> According to [JDBC
> API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])],
> the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY",
> "LOCAL TEMPORARY", "ALIAS", "SYNONYM".
> Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE".
> Besides, I wonder if this bug is related to another bug
> [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me.
> It should be noted that the values of TABLE_TYPE returned from methods
> DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be
> one-to-one matched with but may not be the same as those in
> INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[
https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978469#comment-16978469
]
ASF GitHub Bot commented on DRILL-5844:
---
ihuzenko commented on issue #1904: DRILL-5844: Incorrect values of TABLE_TYPE
returned from method DatabaseMetaData.getTables of JDBC API
URL: https://github.com/apache/drill/pull/1904#issuecomment-556025542
Hi @arjuntheprogrammer , there are a lot of possible options how to check
your fix. One simplest example for **TestJdbcPluginWithH2IT.java** is :
```java
@Test
public void testJdbcTableTypes() throws Exception {
String query = "select distinct table_type from
information_schema.`tables` " +
"where table_schema like 'h2%'";
testBuilder()
.sqlQuery(query)
.unOrdered()
.baselineColumns("table_type")
.baselineValuesForSingleColumn("SYSTEM TABLE", "TABLE")
.go();
}
```
similar test could be added to **TestJdbcPluginWithMySQLIT.java**, you'll
only need to change where condition to ```mysql%``` and update expected
results.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Incorrect values of TABLE_TYPE returned from method
> DatabaseMetaData.getTables of JDBC API
> --
>
> Key: DRILL-5844
> URL: https://issues.apache.org/jira/browse/DRILL-5844
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC, Metadata
>Affects Versions: 1.10.0
>Reporter: second88
>Assignee: Arjun Gupta
>Priority: Minor
> Fix For: 1.17.0
>
>
> As far as I can see, the values of TABLE_TYPE returned from method
> DatabaseMetaData.getTables of JDBC API of a Drill Connection include:
> TABLE
> VIEW
> SYSTEM_TABLE
> According to [JDBC
> API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])],
> the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY",
> "LOCAL TEMPORARY", "ALIAS", "SYNONYM".
> Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE".
> Besides, I wonder if this bug is related to another bug
> [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me.
> It should be noted that the values of TABLE_TYPE returned from methods
> DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be
> one-to-one matched with but may not be the same as those in
> INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[ https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978438#comment-16978438 ] ASF GitHub Bot commented on DRILL-5844: --- arjuntheprogrammer commented on issue #1904: DRILL-5844: Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API URL: https://github.com/apache/drill/pull/1904#issuecomment-556010994 > Hello @arjuntheprogrammer , overall the changes looks good. Please fix failing unit test. > > > TestMetadataProvider.tablesWithSystemTableFilter > > And add two another test methods to cover your fix in IT tests: > > > TestJdbcPluginWithH2IT.java > > TestJdbcPluginWithMySQLIT.java Hi @ihuzenko , thanks for reviewing the pull request. Can you please guide me what type of tests are supposed to be written in these files: TestJdbcPluginWithH2IT.java TestJdbcPluginWithMySQLIT.java Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incorrect values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API > -- > > Key: DRILL-5844 > URL: https://issues.apache.org/jira/browse/DRILL-5844 > Project: Apache Drill > Issue Type: Bug > Components: Client - JDBC, Metadata >Affects Versions: 1.10.0 >Reporter: second88 >Assignee: Arjun Gupta >Priority: Minor > Fix For: 1.17.0 > > > As far as I can see, the values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API of a Drill Connection include: > TABLE > VIEW > SYSTEM_TABLE > According to [JDBC > API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])], > the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", > "LOCAL TEMPORARY", "ALIAS", "SYNONYM". > Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE". > Besides, I wonder if this bug is related to another bug > [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me. > It should be noted that the values of TABLE_TYPE returned from methods > DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be > one-to-one matched with but may not be the same as those in > INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DRILL-5844) Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
[ https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978283#comment-16978283 ] ASF GitHub Bot commented on DRILL-5844: --- arjuntheprogrammer commented on pull request #1904: DRILL-5844 URL: https://github.com/apache/drill/pull/1904 Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API. According to JDBC API, the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", "LOCAL TEMPORARY", "ALIAS", "SYNONYM". Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incorrect values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API > -- > > Key: DRILL-5844 > URL: https://issues.apache.org/jira/browse/DRILL-5844 > Project: Apache Drill > Issue Type: Bug > Components: Client - JDBC, Metadata >Affects Versions: 1.10.0 >Reporter: second88 >Priority: Minor > > As far as I can see, the values of TABLE_TYPE returned from method > DatabaseMetaData.getTables of JDBC API of a Drill Connection include: > TABLE > VIEW > SYSTEM_TABLE > According to [JDBC > API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])], > the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", > "LOCAL TEMPORARY", "ALIAS", "SYNONYM". > Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE". > Besides, I wonder if this bug is related to another bug > [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me. > It should be noted that the values of TABLE_TYPE returned from methods > DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be > one-to-one matched with but may not be the same as those in > INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE". -- This message was sent by Atlassian Jira (v8.3.4#803005)
