[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415777#comment-16415777
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1190
  
+1


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Assignee: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415431#comment-16415431
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

Github user pushpendra-jaiswal-90 commented on the issue:

https://github.com/apache/drill/pull/1190
  
@arina-ielchiieva I have removed comment.


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Assignee: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415415#comment-16415415
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/1190#discussion_r177385544
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -557,8 +557,7 @@ private ExecConstants() {
   public static final LongValidator CODE_GEN_EXP_IN_METHOD_SIZE_VALIDATOR 
= new LongValidator(CODE_GEN_EXP_IN_METHOD_SIZE);
 
   /**
-   * Timeout for create prepare statement request. If the request exceeds 
this timeout, then request is timed out.
-   * Default value is 10mins.
+   * Default value is 30 seconds.
--- End diff --

Maybe we should remove comment about the default as well? Actual default 
value can be found in drill-module.conf and if it changes, we won't need to 
modify it here.


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Assignee: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415176#comment-16415176
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

Github user pushpendra-jaiswal-90 commented on the issue:

https://github.com/apache/drill/pull/1190
  
@arina-ielchiieva I have done the changes. Could you please review?


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Assignee: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414975#comment-16414975
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1190#discussion_r177300882
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -558,7 +558,7 @@ private ExecConstants() {
 
   /**
* Timeout for create prepare statement request. If the request exceeds 
this timeout, then request is timed out.
-   * Default value is 10mins.
+   * Default value is 30 seconds.
--- End diff --

I refer to the entire comment. "If the request exceeds this timeout, then 
request is timed out" does not add any value, it is simply a definition for a 
timeout. The same for `CREATE_PREPARE_STATEMENT_TIMEOUT_MILLIS` and "Timeout 
for create prepare statement request".


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Assignee: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414084#comment-16414084
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1190
  
@pushpendra-jaiswal-90 try searching for the occurrence of 
`prepare.statement.create_timeout_ms` in the project using your IDE :)


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414082#comment-16414082
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/1190#discussion_r177152303
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -558,7 +558,7 @@ private ExecConstants() {
 
   /**
* Timeout for create prepare statement request. If the request exceeds 
this timeout, then request is timed out.
-   * Default value is 10mins.
+   * Default value is 30 seconds.
--- End diff --

Agree, with Vlad, it better to remove this sentence at all: `Default value 
is 30 seconds.`


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414075#comment-16414075
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

Github user pushpendra-jaiswal-90 commented on the issue:

https://github.com/apache/drill/pull/1190
  
@arina-ielchiieva Can you please tell me which drill-module.conf has it ?


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413907#comment-16413907
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1190#discussion_r177103076
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -558,7 +558,7 @@ private ExecConstants() {
 
   /**
* Timeout for create prepare statement request. If the request exceeds 
this timeout, then request is timed out.
-   * Default value is 10mins.
+   * Default value is 30 seconds.
--- End diff --

Is it 30 seconds or 10 seconds? In any case, I don't think that the entire 
comment provides any additional info that cannot be inferred from the code 
itself.


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413899#comment-16413899
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1190
  
@pushpendra-jaiswal-90 two more points:
1. In drill-module.conf default for prepare.statement.create_timeout_ms is 
set 1 ms, which does not correspond to the value you have indicated. Please 
make sure both values are in sync.
2. Please do not do merge, it's not convenient when we are cherry-picking 
range of commits. But for your case I suggest you do squash the commits into 
one.


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413826#comment-16413826
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

Github user pushpendra-jaiswal-90 commented on the issue:

https://github.com/apache/drill/pull/1190
  
@arina-ielchiieva I've done the required changes. 
 


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413657#comment-16413657
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

Github user pushpendra-jaiswal-90 commented on the issue:

https://github.com/apache/drill/pull/1190
  
@vrozov @vdiravka Could you please review this?


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413573#comment-16413573
 ] 

ASF GitHub Bot commented on DRILL-5937:
---

GitHub user pushpendra-jaiswal-90 opened a pull request:

https://github.com/apache/drill/pull/1190

[DRILL-5937] ExecConstants: changed comment, timeout default is 30 sec.

**Changed comment** to reflect default prepared statement timeout as 30 
sec. (same as hive) .
10 seconds timeout is also failing in some cases in our mapr environment.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pushpendra-jaiswal-90/drill 
bug/DRILL-5937-prepared-timeout-default

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1190


commit 5556e25ed689a9029de27d9a3ad91f02e46b95f2
Author: Pushpendra Jaiswal 
Date:   2018-03-26T07:05:51Z

[DRILL-5937] ExecConstants: changed comment, timeout default is 30 sec.




>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[Pushpendra Jaiswal (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413483#comment-16413483
 ] 

Pushpendra Jaiswal commented on DRILL-5937:
---

Thanks  for prompt reply. 

I am looking timeouts in other dbs.

I am facing some problems with pushing code with my current credentials. Do I 
need any special permission ?  

Could you please help me a little bit 

>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[Kunal Khatua (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413469#comment-16413469
 ] 

Kunal Khatua commented on DRILL-5937:
-

Certainly not 10mins! 

So, it's between choosing 10 or 30 sec. Probably worthwhile to find out what 
values other databases have for this.

>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[Pushpendra Jaiswal (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413468#comment-16413468
 ] 

Pushpendra Jaiswal commented on DRILL-5937:
---

[~kkhatua] what should be the default value for timeout 30 sec or 10 mins or 10 
sec ?

>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[Kunal Khatua (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411703#comment-16411703
 ] 

Kunal Khatua commented on DRILL-5937:
-

Yes. Feel free to create a pull request for this. 

Also, you don't need permission to work on something trivial like this. If 
there is a more complex feature, you can use the Dev mailing list to get 
feedback on your idea before you submit your pull request. 

>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins

[Pushpendra Jaiswal (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411319#comment-16411319
 ] 

Pushpendra Jaiswal commented on DRILL-5937:
---

Hi [~kkhatua] 

Can I take this up ?

>  prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> --
>
> Key: DRILL-5937
> URL: https://issues.apache.org/jira/browse/DRILL-5937
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization
>Affects Versions: 1.8.0
>Reporter: Pushpendra Jaiswal
>Priority: Major
> Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment 
> says default should be 10 mins
> The value is by default set to 1 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526
>  
> /**
>* Timeout for create prepare statement request. If the request exceeds 
> this timeout, then request is timed out.
>* Default value is 10mins.
>*/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)