[jira] [Commented] (DRILL-6225) Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support
[ https://issues.apache.org/jira/browse/DRILL-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885955#comment-16885955 ] ASF GitHub Bot commented on DRILL-6225: --- debraj92 commented on issue #1817: DRILL-6225: Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support URL: https://github.com/apache/drill/pull/1817#issuecomment-511731164 Hi , I am closing this PR now because it looks like upgrading boost at this point is not feasible. I will leave the JIRA open and keep the patch locally so that we can apply it in the future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support > --- > > Key: DRILL-6225 > URL: https://issues.apache.org/jira/browse/DRILL-6225 > Project: Apache Drill > Issue Type: Task > Components: Client - C++ >Reporter: Rob Wu >Assignee: Debraj Ray >Priority: Minor > > Boost 1.57 is not able to compile with openSSL 1.1 > ([https://svn.boost.org/trac10/ticket/12238)] and adding > add_definitions(-DOPENSSL_API_COMPAT=0x1000L) does not work. > > In order to add support for openSSL 1.1, we would need to upgrade boost to > 1.62+. However, it looks like boost 1.62 bcp will segfault on asio component > when you attempt to shade the boost libraries > ([https://svn.boost.org/trac10/ticket/12357)]. So in that case, we should > upgrade to 1.64 > +. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (DRILL-6225) Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support
[ https://issues.apache.org/jira/browse/DRILL-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885956#comment-16885956 ] ASF GitHub Bot commented on DRILL-6225: --- debraj92 commented on pull request #1817: DRILL-6225: Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support URL: https://github.com/apache/drill/pull/1817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support > --- > > Key: DRILL-6225 > URL: https://issues.apache.org/jira/browse/DRILL-6225 > Project: Apache Drill > Issue Type: Task > Components: Client - C++ >Reporter: Rob Wu >Assignee: Debraj Ray >Priority: Minor > > Boost 1.57 is not able to compile with openSSL 1.1 > ([https://svn.boost.org/trac10/ticket/12238)] and adding > add_definitions(-DOPENSSL_API_COMPAT=0x1000L) does not work. > > In order to add support for openSSL 1.1, we would need to upgrade boost to > 1.62+. However, it looks like boost 1.62 bcp will segfault on asio component > when you attempt to shade the boost libraries > ([https://svn.boost.org/trac10/ticket/12357)]. So in that case, we should > upgrade to 1.64 > +. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (DRILL-6225) Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support
[ https://issues.apache.org/jira/browse/DRILL-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883623#comment-16883623 ] ASF GitHub Bot commented on DRILL-6225: --- dgrinchenko commented on issue #1817: DRILL-6225: Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support URL: https://github.com/apache/drill/pull/1817#issuecomment-510800641 @debraj92 please read carefully point 2 of my comment, it describes why travis failing for you. [Here ](https://packages.ubuntu.com/xenial/libboost-all-dev)is the max version of libboost available for the travis. The another problem - if you decide to build own version of libboost, then it would need to be linked statically to the client, to not interference with already installed system version of libboost, otherwise your patch would change the minimal system version requirements for building and using drill client This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support > --- > > Key: DRILL-6225 > URL: https://issues.apache.org/jira/browse/DRILL-6225 > Project: Apache Drill > Issue Type: Task > Components: Client - C++ >Reporter: Rob Wu >Assignee: Debraj Ray >Priority: Minor > > Boost 1.57 is not able to compile with openSSL 1.1 > ([https://svn.boost.org/trac10/ticket/12238)] and adding > add_definitions(-DOPENSSL_API_COMPAT=0x1000L) does not work. > > In order to add support for openSSL 1.1, we would need to upgrade boost to > 1.62+. However, it looks like boost 1.62 bcp will segfault on asio component > when you attempt to shade the boost libraries > ([https://svn.boost.org/trac10/ticket/12357)]. So in that case, we should > upgrade to 1.64 > +. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (DRILL-6225) Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support
[ https://issues.apache.org/jira/browse/DRILL-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881189#comment-16881189 ] ASF GitHub Bot commented on DRILL-6225: --- debraj92 commented on issue #1817: DRILL-6225: Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support URL: https://github.com/apache/drill/pull/1817#issuecomment-509622674 Hi @dgrinchenko , Actually the change is incomplete because I ran into a problem with the travis building. Before explaining the problem, let me answer your questions and make the idea clear: 1. The purpose of this change is to enable support for openssl 1.1.0/1.1.1. This requires updating boost (to at least 1.64). So, I updated boost to the latest - 1.68. But, then I ran into problems with building using travis (as explained later) and I started experimenting with other versions of boost to see if the issue can be resolved. Thats why you see 1.65 there in the change. Ideally it should be 1.68. 2. Agreed, the changes in travis.yml are only experiments to get the build pass. Will explain the problem shortly. 3. Boost API has changed. The argument now needs to be passed by reference. This is the main purpose of the change. Without the change drill client code would not compile with boost 1.68. Now, the problem. To get travis to build drill client code I would have to specify the location for downloading the boost 1.68 static libs. I could not find a repo from where I can do this and hence the change in the travis.yml file is not accurate. One option is to build boost from source but that would unnecessarily slow down the build. I also tried other boost versions (1.65, 1.67) but travis build did not succeed. Not sure how to proceed from here now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support > --- > > Key: DRILL-6225 > URL: https://issues.apache.org/jira/browse/DRILL-6225 > Project: Apache Drill > Issue Type: Task > Components: Client - C++ >Reporter: Rob Wu >Assignee: Debraj Ray >Priority: Minor > > Boost 1.57 is not able to compile with openSSL 1.1 > ([https://svn.boost.org/trac10/ticket/12238)] and adding > add_definitions(-DOPENSSL_API_COMPAT=0x1000L) does not work. > > In order to add support for openSSL 1.1, we would need to upgrade boost to > 1.62+. However, it looks like boost 1.62 bcp will segfault on asio component > when you attempt to shade the boost libraries > ([https://svn.boost.org/trac10/ticket/12357)]. So in that case, we should > upgrade to 1.64 > +. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6225) Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support
[ https://issues.apache.org/jira/browse/DRILL-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881105#comment-16881105 ] ASF GitHub Bot commented on DRILL-6225: --- dgrinchenko commented on issue #1817: DRILL-6225: Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support URL: https://github.com/apache/drill/pull/1817#issuecomment-509576938 @debraj92 for me the change is unclear: - the summary states about update to the libboost version 1.68, while PR updating it to 1.65 - travis-ci currently using Ubuntu Xenial as an LTS distribution, and libboost 1.65 strictly require Ubuntu Bionic (https://packages.ubuntu.com/search?keywords=libboost1.65-all-dev). Also, Ubuntu Xenial EOL is roughly in 2022 and i don't see, why we should remove support of this version of the Linux. Requirements for CentOS version and RedHat linux need to be verified too. - why we changed expected function argument to be passed by reference? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support > --- > > Key: DRILL-6225 > URL: https://issues.apache.org/jira/browse/DRILL-6225 > Project: Apache Drill > Issue Type: Task > Components: Client - C++ >Reporter: Rob Wu >Assignee: Debraj Ray >Priority: Minor > > Boost 1.57 is not able to compile with openSSL 1.1 > ([https://svn.boost.org/trac10/ticket/12238)] and adding > add_definitions(-DOPENSSL_API_COMPAT=0x1000L) does not work. > > In order to add support for openSSL 1.1, we would need to upgrade boost to > 1.62+. However, it looks like boost 1.62 bcp will segfault on asio component > when you attempt to shade the boost libraries > ([https://svn.boost.org/trac10/ticket/12357)]. So in that case, we should > upgrade to 1.64 > +. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6225) Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support
[ https://issues.apache.org/jira/browse/DRILL-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881070#comment-16881070 ] ASF GitHub Bot commented on DRILL-6225: --- arina-ielchiieva commented on issue #1817: DRILL-6225: Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support URL: https://github.com/apache/drill/pull/1817#issuecomment-509558121 @debraj92 there are some failures on protobuf job. Could you please check? https://travis-ci.org/apache/drill/jobs/552669860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support > --- > > Key: DRILL-6225 > URL: https://issues.apache.org/jira/browse/DRILL-6225 > Project: Apache Drill > Issue Type: Task > Components: Client - C++ >Reporter: Rob Wu >Assignee: Debraj Ray >Priority: Minor > > Boost 1.57 is not able to compile with openSSL 1.1 > ([https://svn.boost.org/trac10/ticket/12238)] and adding > add_definitions(-DOPENSSL_API_COMPAT=0x1000L) does not work. > > In order to add support for openSSL 1.1, we would need to upgrade boost to > 1.62+. However, it looks like boost 1.62 bcp will segfault on asio component > when you attempt to shade the boost libraries > ([https://svn.boost.org/trac10/ticket/12357)]. So in that case, we should > upgrade to 1.64 > +. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6225) Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support
[ https://issues.apache.org/jira/browse/DRILL-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875509#comment-16875509 ] ASF GitHub Bot commented on DRILL-6225: --- arina-ielchiieva commented on issue #1817: DRILL-6225: Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support URL: https://github.com/apache/drill/pull/1817#issuecomment-506957237 @debraj92 please squash the commits and address protobuf job failures - https://travis-ci.org/apache/drill/jobs/552040788. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support > --- > > Key: DRILL-6225 > URL: https://issues.apache.org/jira/browse/DRILL-6225 > Project: Apache Drill > Issue Type: Task > Components: Client - C++ >Reporter: Rob Wu >Assignee: Debraj Ray >Priority: Minor > > Boost 1.57 is not able to compile with openSSL 1.1 > ([https://svn.boost.org/trac10/ticket/12238)] and adding > add_definitions(-DOPENSSL_API_COMPAT=0x1000L) does not work. > > In order to add support for openSSL 1.1, we would need to upgrade boost to > 1.62+. However, it looks like boost 1.62 bcp will segfault on asio component > when you attempt to shade the boost libraries > ([https://svn.boost.org/trac10/ticket/12357)]. So in that case, we should > upgrade to 1.64 > +. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6225) Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support
[ https://issues.apache.org/jira/browse/DRILL-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875366#comment-16875366 ] Debraj Ray commented on DRILL-6225: --- Hi, As part of this change, we are only upgrading boost to 1.68 so that openssl 1.1.1 (LTS) can be supported. There is no specific changes related to openssl version upgrade. [~robertw] , kindly update the Jira title to make it more clear. PR opened here: [https://github.com/apache/drill/pull/1817] Best Regards, Debraj > Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support > --- > > Key: DRILL-6225 > URL: https://issues.apache.org/jira/browse/DRILL-6225 > Project: Apache Drill > Issue Type: Task > Components: Client - C++ >Reporter: Rob Wu >Assignee: Debraj Ray >Priority: Minor > > Boost 1.57 is not able to compile with openSSL 1.1 > ([https://svn.boost.org/trac10/ticket/12238)] and adding > add_definitions(-DOPENSSL_API_COMPAT=0x1000L) does not work. > > In order to add support for openSSL 1.1, we would need to upgrade boost to > 1.62+. However, it looks like boost 1.62 bcp will segfault on asio component > when you attempt to shade the boost libraries > ([https://svn.boost.org/trac10/ticket/12357)]. So in that case, we should > upgrade to 1.64 > +. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
