[jira] [Commented] (DRILL-6386) Disallow Unused Imports In Checkstyle
[ https://issues.apache.org/jira/browse/DRILL-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469232#comment-16469232 ] ASF GitHub Bot commented on DRILL-6386: --- ilooner commented on a change in pull request #1252: DRILL-6386: Disallowed unused imports and removed them. URL: https://github.com/apache/drill/pull/1252#discussion_r187129341 ## File path: src/main/resources/checkstyle-config.xml ## @@ -27,7 +27,11 @@ - + + + Review comment: Thanks for catching. Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Disallow Unused Imports In Checkstyle > - > > Key: DRILL-6386 > URL: https://issues.apache.org/jira/browse/DRILL-6386 > Project: Apache Drill > Issue Type: Improvement >Reporter: Timothy Farkas >Assignee: Timothy Farkas >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6386) Disallow Unused Imports In Checkstyle
[ https://issues.apache.org/jira/browse/DRILL-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468141#comment-16468141 ] ASF GitHub Bot commented on DRILL-6386: --- vrozov commented on a change in pull request #1252: DRILL-6386: Disallowed unused imports and removed them. URL: https://github.com/apache/drill/pull/1252#discussion_r186901891 ## File path: src/main/resources/checkstyle-config.xml ## @@ -27,7 +27,11 @@ - + + + Review comment: There is already 'AvoidStarImport' rule. Please change it to use defaults. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Disallow Unused Imports In Checkstyle > - > > Key: DRILL-6386 > URL: https://issues.apache.org/jira/browse/DRILL-6386 > Project: Apache Drill > Issue Type: Improvement >Reporter: Timothy Farkas >Assignee: Timothy Farkas >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6386) Disallow Unused Imports In Checkstyle
[ https://issues.apache.org/jira/browse/DRILL-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468108#comment-16468108 ] ASF GitHub Bot commented on DRILL-6386: --- ilooner commented on issue #1252: DRILL-6386: Disallowed unused imports and removed them. URL: https://github.com/apache/drill/pull/1252#issuecomment-387574479 @vrozov Disallowed start imports @arina-ielchiieva Address comments questions Please let me know if you have anymore comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Disallow Unused Imports In Checkstyle > - > > Key: DRILL-6386 > URL: https://issues.apache.org/jira/browse/DRILL-6386 > Project: Apache Drill > Issue Type: Improvement >Reporter: Timothy Farkas >Assignee: Timothy Farkas >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6386) Disallow Unused Imports In Checkstyle
[ https://issues.apache.org/jira/browse/DRILL-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468109#comment-16468109 ] ASF GitHub Bot commented on DRILL-6386: --- ilooner commented on issue #1252: DRILL-6386: Disallowed unused imports and removed them. URL: https://github.com/apache/drill/pull/1252#issuecomment-387574479 @vrozov Disallowed start imports @arina-ielchiieva Addressed comments and questions Please let me know if you have anymore comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Disallow Unused Imports In Checkstyle > - > > Key: DRILL-6386 > URL: https://issues.apache.org/jira/browse/DRILL-6386 > Project: Apache Drill > Issue Type: Improvement >Reporter: Timothy Farkas >Assignee: Timothy Farkas >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6386) Disallow Unused Imports In Checkstyle
[ https://issues.apache.org/jira/browse/DRILL-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467781#comment-16467781 ] ASF GitHub Bot commented on DRILL-6386: --- ilooner commented on issue #1252: DRILL-6386: Disallowed unused imports and removed them. URL: https://github.com/apache/drill/pull/1252#issuecomment-387492658 @arina-ielchiieva Addressing your questions: 1. This doesn't cover import order. From what I vaguely remember with Apache Apex, import order was a highly controversial topic. I want to avoid that discussion for now and get everybody comfortable with adding more checkstyle checks bit by bit. Once people are more comfortable with stricter checkstyle checks I am hoping a discussion about adding import order checks can reach a consensus quicker. 2. I will refactor into two commits as you suggested. 3. I wasn't planning on adding any documentation about this now since the checkstyle errors are pretty descriptive. However, I was planning on writing a Checkstyle.md which will explain how to import a checkstyle.xml into your IDE so that you can see checkstyle warnings within your IDE as well as autoformat your code according to Drill's checkstyle config. Chandni figured out all these things for Apache Apex, but I don't think it's documented anywhere. So I'll sync up with her and get it written down as part of a separate Jira. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Disallow Unused Imports In Checkstyle > - > > Key: DRILL-6386 > URL: https://issues.apache.org/jira/browse/DRILL-6386 > Project: Apache Drill > Issue Type: Improvement >Reporter: Timothy Farkas >Assignee: Timothy Farkas >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6386) Disallow Unused Imports In Checkstyle
[ https://issues.apache.org/jira/browse/DRILL-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467697#comment-16467697 ] ASF GitHub Bot commented on DRILL-6386: --- vrozov commented on issue #1252: DRILL-6386: Disallowed unused imports and removed them. URL: https://github.com/apache/drill/pull/1252#issuecomment-387473728 In addition to disabling unused imports, it will be good to disable wildcard imports as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Disallow Unused Imports In Checkstyle > - > > Key: DRILL-6386 > URL: https://issues.apache.org/jira/browse/DRILL-6386 > Project: Apache Drill > Issue Type: Improvement >Reporter: Timothy Farkas >Assignee: Timothy Farkas >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6386) Disallow Unused Imports In Checkstyle
[ https://issues.apache.org/jira/browse/DRILL-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467473#comment-16467473 ] ASF GitHub Bot commented on DRILL-6386: --- arina-ielchiieva commented on issue #1252: DRILL-6386: Disallowed unused imports and removed them. URL: https://github.com/apache/drill/pull/1252#issuecomment-387421645 1. Will this cover imports order? 2. Should we have two commits: one by drill dev that fixes unused imports, another by Tim that adds unused commits check? 3. Will this information be added in PR-1251 or here to specific .md document? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Disallow Unused Imports In Checkstyle > - > > Key: DRILL-6386 > URL: https://issues.apache.org/jira/browse/DRILL-6386 > Project: Apache Drill > Issue Type: Improvement >Reporter: Timothy Farkas >Assignee: Timothy Farkas >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6386) Disallow Unused Imports In Checkstyle
[ https://issues.apache.org/jira/browse/DRILL-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466543#comment-16466543 ] ASF GitHub Bot commented on DRILL-6386: --- ilooner commented on issue #1252: DRILL-6386: Disallowed unused imports and removed them. URL: https://github.com/apache/drill/pull/1252#issuecomment-387224347 @vrozov @kkhatua Please review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Disallow Unused Imports In Checkstyle > - > > Key: DRILL-6386 > URL: https://issues.apache.org/jira/browse/DRILL-6386 > Project: Apache Drill > Issue Type: Improvement >Reporter: Timothy Farkas >Assignee: Timothy Farkas >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6386) Disallow Unused Imports In Checkstyle
[ https://issues.apache.org/jira/browse/DRILL-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466542#comment-16466542 ] ASF GitHub Bot commented on DRILL-6386: --- ilooner opened a new pull request #1252: DRILL-6386: Disallowed unused imports and removed them. URL: https://github.com/apache/drill/pull/1252 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Disallow Unused Imports In Checkstyle > - > > Key: DRILL-6386 > URL: https://issues.apache.org/jira/browse/DRILL-6386 > Project: Apache Drill > Issue Type: Improvement >Reporter: Timothy Farkas >Assignee: Timothy Farkas >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
