[GitHub] flink pull request: [FLINK-1501] Add metrics library for monitorin...
Github user bhatsachin commented on the pull request: https://github.com/apache/flink/pull/421#issuecomment-84282886 Hey, I am one of the IIT Mandi students contributing to Flink. I would like to pick up a task pertaining to the monitoring enhancements. Robert, what is the status on the per job monitoring task? Are there any further changes to this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-1501) Integrate metrics library and report basic metrics to JobManager web interface
[ https://issues.apache.org/jira/browse/FLINK-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372599#comment-14372599 ] ASF GitHub Bot commented on FLINK-1501: --- Github user bhatsachin commented on the pull request: https://github.com/apache/flink/pull/421#issuecomment-84282886 Hey, I am one of the IIT Mandi students contributing to Flink. I would like to pick up a task pertaining to the monitoring enhancements. Robert, what is the status on the per job monitoring task? Are there any further changes to this PR? Integrate metrics library and report basic metrics to JobManager web interface -- Key: FLINK-1501 URL: https://issues.apache.org/jira/browse/FLINK-1501 Project: Flink Issue Type: Sub-task Components: JobManager, TaskManager Affects Versions: 0.9 Reporter: Robert Metzger Assignee: Robert Metzger Fix For: pre-apache As per mailing list, the library: https://github.com/dropwizard/metrics The goal of this task is to get the basic infrastructure in place. Subsequent issues will integrate more features into the system. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: Make Expression API available to Java, Rename ...
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-84384122 Gah, I just did that in the discuss thread =P --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Make Expression API available to Java, Rename ...
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-84382628 Exactly, thanks @hsaputra It would also be good to add some actual arguments to the discussion that go beyond I like xxx more than yyy ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Adds akka interal docs and configuration descr...
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/512 Adds akka interal docs and configuration description Adds Akka documentation and configuration description to docs. The Akka internal documentation is the same as the one published in the wiki at the moment of opening this PR. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink akkaDocumentation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/512.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #512 commit 2e83f69c24efcf42ac52758cd446237baa3263ad Author: Till Rohrmann trohrm...@apache.org Date: 2015-02-19T17:01:42Z [docs] Adds akka interal docs and configuration description --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1766]Fix the bug of equals function of ...
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/511 [FLINK-1766]Fix the bug of equals function of FSKey The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first confirm whether obj == this, if obj is the same object.It should return true You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink Bug_Flink_1776 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #511 commit ab0ae5ece5e641455fa819b372a742ed607c183d Author: hongsibao hongsi...@huawei.com Date: 2015-03-21T15:12:58Z [FLINK-1766]Fix the bug of equals function of FSKey --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1766]Fix the bug of equals function of ...
Github user matadorhong closed the pull request at: https://github.com/apache/flink/pull/509 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372838#comment-14372838 ] ASF GitHub Bot commented on FLINK-1766: --- GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/511 [FLINK-1766]Fix the bug of equals function of FSKey The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first confirm whether obj == this, if obj is the same object.It should return true You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink Bug_Flink_1776 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #511 commit ab0ae5ece5e641455fa819b372a742ed607c183d Author: hongsibao hongsi...@huawei.com Date: 2015-03-21T15:12:58Z [FLINK-1766]Fix the bug of equals function of FSKey Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372839#comment-14372839 ] ASF GitHub Bot commented on FLINK-1766: --- Github user matadorhong closed the pull request at: https://github.com/apache/flink/pull/509 Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: Make Expression API available to Java, Rename ...
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-84381205 I think @fhueske just suggetsing it would be less work to have the new name settle before PR being submmitted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Add the class member variables with 'this'
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/510 Add the class member variables with 'this' Just add the class member variables with 'this' like other class member variables in other class member function byunified format for good reading. You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink fix_this_3.21 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/510.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #510 commit 99a8f4e02f735e5076b591c9ca21501cd7fcde23 Author: hongsibao hongsi...@huawei.com Date: 2015-03-21T15:08:22Z Add the class member variables with 'this' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Comment Edited] (FLINK-1763) Remove cancel from streaming SinkFunction
[
https://issues.apache.org/jira/browse/FLINK-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372024#comment-14372024
]
Gyula Fora edited comment on FLINK-1763 at 3/21/15 11:40 AM:
-
I still think that it makes sense to have a cancel method here as that gives a
way of always closing outside connections. Otherwise the cancel method in the
StreamVertex should call the close() method of the operator.
was (Author: gyfora):
I still think that it makes sense to have a cancel method here as that gives a
way of always closing outside connections. Otherwise the cancel method in the
StreamVertex should call the close() method of the operator (which I dont think
it should).
Remove cancel from streaming SinkFunction
---
Key: FLINK-1763
URL: https://issues.apache.org/jira/browse/FLINK-1763
Project: Flink
Issue Type: Improvement
Components: Streaming
Affects Versions: 0.9
Reporter: Stephan Ewen
Fix For: 0.9
Since the streaming sink function is called individually for each record, it
does not require a {{cancel()}} function. The system can cancel between calls
to that function (which it cannot do for the source function).
Removing this method removes the need to always implement the unnecessary,
and usually empty, method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] flink pull request: [FLINK-1655] Renamed StreamInvokable to Stream...
GitHub user akshaydixi opened a pull request: https://github.com/apache/flink/pull/508 [FLINK-1655] Renamed StreamInvokable to StreamOperator and all its subclasses and tests in a similar fashion. Changes made are: * StreamInvokable - StreamOperator * ChainableInvokable - ChainableStreamOperator * SinkInvokable - SinkStreamOperator * SourceInvokable - SourceStreamOperator * CoFlatMapInvokable - CoFlatMapStreamOperator * CoGroupedReduceInvokable - CoGroupedReduceStreamOperator * CoInvokable - CoStreamOperator * CoMapInvokable - CoMapStreamOperator * CoReduceInvokable - CoReduceStreamOperator * CoWindowInvokable - CoWindowStreamOperator * GroupedWindowBufferInvokable - GroupedWindowBufferStreamOperator * WindowBufferInvokable - WindowBufferStreamOperator * CounterInvokable - CounterStreamOperator * FilterInvokable - FilterStreamOperator * FlatMapInvokable - FlatMapStreamOperator * GroupedFoldInvokable - GroupedFoldStreamOperator * GroupedReduceInvokable - GroupedReduceStreamOperator * MapInvokable - MapStreamOperator * ProjectInvokable - ProjectStreamOperator * StreamFoldInvokable - FoldStreamOperator * StreamReduceInvokable - ReduceStreamOperator You can merge this pull request into a Git repository by running: $ git pull https://github.com/akshaydixi/flink FLINK-1655 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/508.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #508 commit 18ba6e31b7cd0eb0eac857595ba8ad304d81202a Author: Akshay Dixit akshayd...@gmail.com Date: 2015-03-21T11:28:53Z [FLINK-1655] Renamed StreamInvokable to StreamOperator and all its subclasses and tests in a similar fashion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372721#comment-14372721 ] ASF GitHub Bot commented on FLINK-1766: --- GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/509 [FLINK-1766]Fix the bug of equals function of FSKey The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first confirm whether obj == this, if obj is the same object.It should return True. You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink bug_equals_3.21 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/509.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #509 commit 68de654200b796c45e2f250c0d359c56a3d474bc Author: Sibao Hong hongsi...@huawei.com Date: 2015-03-13T07:03:51Z Merge pull request #1 from apache/master update commit 07c20a40ccbfc886344bde5c26ed3605a799220a Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-18T09:45:49Z Merge branch 'master' of https://github.com/apache/flink commit 914f06e856e7680500a2c4c10390b701872c49fc Author: hongsibao hongsi...@huawei.com Date: 2015-03-18T15:44:12Z Merge remote-tracking branch 'upstream/master' commit 17fd72dc87ff652362bbda159f09e14130ea3e93 Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-19T07:28:43Z Merge branch 'master' of https://github.com/apache/flink commit 16e3a6c1c2d0ba4f73ed7854ce60e405791bb976 Author: hongsibao hongsi...@huawei.com Date: 2015-03-19T15:53:24Z Merge branch 'master' of https://github.com/matadorhong/flink commit 86253a304427620b570d52abee16d6ef561f6de4 Author: hongsibao hongsi...@huawei.com Date: 2015-03-19T15:55:17Z Merge remote-tracking branch 'upstream/master' commit 2495512d32554668efd2972866833b9f7033d7f6 Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-20T01:23:49Z Merge branch 'master' of https://github.com/apache/flink commit 80bbc423d22f437c4b3a20f28e0f4ec6866fc14d Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-20T01:24:04Z Merge branch 'master' of https://github.com/matadorhong/flink commit cd969f20eca52442bd84212757fa3842e54c6099 Author: hongsibao hongsi...@huawei.com Date: 2015-03-20T16:42:25Z Merge remote-tracking branch 'upstream/master' commit 89d2bb56ec5c92579b073c9d963d03622f34d4bb Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-21T02:25:02Z Merge branch 'master' of https://github.com/matadorhong/flink commit 8a412681b281889a45bae96b8e129efc15625ae3 Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-21T03:52:19Z Merge remote-tracking branch 'upstream/master' commit eeb3469a2c0350e3c4251dccf5947f7458e29657 Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-21T12:49:05Z Fix the bug of equals function of FSKey. Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1655) Rename StreamInvokable to StreamOperator
[ https://issues.apache.org/jira/browse/FLINK-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372694#comment-14372694 ] ASF GitHub Bot commented on FLINK-1655: --- GitHub user akshaydixi opened a pull request: https://github.com/apache/flink/pull/508 [FLINK-1655] Renamed StreamInvokable to StreamOperator and all its subclasses and tests in a similar fashion. Changes made are: * StreamInvokable - StreamOperator * ChainableInvokable - ChainableStreamOperator * SinkInvokable - SinkStreamOperator * SourceInvokable - SourceStreamOperator * CoFlatMapInvokable - CoFlatMapStreamOperator * CoGroupedReduceInvokable - CoGroupedReduceStreamOperator * CoInvokable - CoStreamOperator * CoMapInvokable - CoMapStreamOperator * CoReduceInvokable - CoReduceStreamOperator * CoWindowInvokable - CoWindowStreamOperator * GroupedWindowBufferInvokable - GroupedWindowBufferStreamOperator * WindowBufferInvokable - WindowBufferStreamOperator * CounterInvokable - CounterStreamOperator * FilterInvokable - FilterStreamOperator * FlatMapInvokable - FlatMapStreamOperator * GroupedFoldInvokable - GroupedFoldStreamOperator * GroupedReduceInvokable - GroupedReduceStreamOperator * MapInvokable - MapStreamOperator * ProjectInvokable - ProjectStreamOperator * StreamFoldInvokable - FoldStreamOperator * StreamReduceInvokable - ReduceStreamOperator You can merge this pull request into a Git repository by running: $ git pull https://github.com/akshaydixi/flink FLINK-1655 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/508.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #508 commit 18ba6e31b7cd0eb0eac857595ba8ad304d81202a Author: Akshay Dixit akshayd...@gmail.com Date: 2015-03-21T11:28:53Z [FLINK-1655] Renamed StreamInvokable to StreamOperator and all its subclasses and tests in a similar fashion. Rename StreamInvokable to StreamOperator Key: FLINK-1655 URL: https://issues.apache.org/jira/browse/FLINK-1655 Project: Flink Issue Type: Improvement Components: Streaming Reporter: Gyula Fora Assignee: Akshay Dixit Priority: Minor The names of the StreamInvokable and ChainableInvokable are misleading and is easy to confuse with the AbstractInvokable These classes ( and the variable names that refer to objects) should be renamed to: StreamInvokable - StreamOperator ChainableInvokable - ChainableStreamOperator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [FLINK-1766]Fix the bug of equals function of ...
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/509 [FLINK-1766]Fix the bug of equals function of FSKey The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first confirm whether obj == this, if obj is the same object.It should return True. You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink bug_equals_3.21 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/509.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #509 commit 68de654200b796c45e2f250c0d359c56a3d474bc Author: Sibao Hong hongsi...@huawei.com Date: 2015-03-13T07:03:51Z Merge pull request #1 from apache/master update commit 07c20a40ccbfc886344bde5c26ed3605a799220a Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-18T09:45:49Z Merge branch 'master' of https://github.com/apache/flink commit 914f06e856e7680500a2c4c10390b701872c49fc Author: hongsibao hongsi...@huawei.com Date: 2015-03-18T15:44:12Z Merge remote-tracking branch 'upstream/master' commit 17fd72dc87ff652362bbda159f09e14130ea3e93 Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-19T07:28:43Z Merge branch 'master' of https://github.com/apache/flink commit 16e3a6c1c2d0ba4f73ed7854ce60e405791bb976 Author: hongsibao hongsi...@huawei.com Date: 2015-03-19T15:53:24Z Merge branch 'master' of https://github.com/matadorhong/flink commit 86253a304427620b570d52abee16d6ef561f6de4 Author: hongsibao hongsi...@huawei.com Date: 2015-03-19T15:55:17Z Merge remote-tracking branch 'upstream/master' commit 2495512d32554668efd2972866833b9f7033d7f6 Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-20T01:23:49Z Merge branch 'master' of https://github.com/apache/flink commit 80bbc423d22f437c4b3a20f28e0f4ec6866fc14d Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-20T01:24:04Z Merge branch 'master' of https://github.com/matadorhong/flink commit cd969f20eca52442bd84212757fa3842e54c6099 Author: hongsibao hongsi...@huawei.com Date: 2015-03-20T16:42:25Z Merge remote-tracking branch 'upstream/master' commit 89d2bb56ec5c92579b073c9d963d03622f34d4bb Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-21T02:25:02Z Merge branch 'master' of https://github.com/matadorhong/flink commit 8a412681b281889a45bae96b8e129efc15625ae3 Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-21T03:52:19Z Merge remote-tracking branch 'upstream/master' commit eeb3469a2c0350e3c4251dccf5947f7458e29657 Author: Hong Sibao hongsi...@huawei.com Date: 2015-03-21T12:49:05Z Fix the bug of equals function of FSKey. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (FLINK-1766) Fix the bug of equals function of FSKey
Sibao Hong created FLINK-1766: - Summary: Fix the bug of equals function of FSKey Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: Add the class member variables with 'this'
Github user matadorhong closed the pull request at: https://github.com/apache/flink/pull/507 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Assigned] (FLINK-1655) Rename StreamInvokable to StreamOperator
[ https://issues.apache.org/jira/browse/FLINK-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akshay Dixit reassigned FLINK-1655: --- Assignee: Akshay Dixit Rename StreamInvokable to StreamOperator Key: FLINK-1655 URL: https://issues.apache.org/jira/browse/FLINK-1655 Project: Flink Issue Type: Improvement Components: Streaming Reporter: Gyula Fora Assignee: Akshay Dixit Priority: Minor The names of the StreamInvokable and ChainableInvokable are misleading and is easy to confuse with the AbstractInvokable These classes ( and the variable names that refer to objects) should be renamed to: StreamInvokable - StreamOperator ChainableInvokable - ChainableStreamOperator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: Adds akka interal docs and configuration descr...
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/512#issuecomment-84447837 +1 to keep it in Wiki for now. There is already a stub in the Doc so we could just set it to point to the wiki --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1766]Fix the bug of equals function of ...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84423950 If you are interested: Here are some simple guidelines on how to format code and create easy to merge commits for pull requests: http://flink.apache.org/coding_guidelines.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372970#comment-14372970 ] ASF GitHub Bot commented on FLINK-1766: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84423950 If you are interested: Here are some simple guidelines on how to format code and create easy to merge commits for pull requests: http://flink.apache.org/coding_guidelines.html Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372966#comment-14372966 ] ASF GitHub Bot commented on FLINK-1766: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84423820 Looks good. This seems more like an optimization, than a bug, Before we can merge the change, it needs to be brought in sync with the code style. Currently, the checkstyle rules reject the code for using spaces rather than tabs. Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [FLINK-1761] Fix IndexOutOfBoundsException whe...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-1761) IndexOutOfBoundsException when receiving empty buffer at remote channel
[
https://issues.apache.org/jira/browse/FLINK-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14373102#comment-14373102
]
ASF GitHub Bot commented on FLINK-1761:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/504
IndexOutOfBoundsException when receiving empty buffer at remote channel
---
Key: FLINK-1761
URL: https://issues.apache.org/jira/browse/FLINK-1761
Project: Flink
Issue Type: Bug
Components: Distributed Runtime
Affects Versions: master
Reporter: Ufuk Celebi
Assignee: Ufuk Celebi
Receiving buffers from remote input channels with size 0 results in an
{{IndexOutOfBoundsException}}.
{code}
Caused by: java.lang.IndexOutOfBoundsException: index: 30 (expected: range(0,
30))
at io.netty.buffer.AbstractByteBuf.checkIndex(AbstractByteBuf.java:1123)
at
io.netty.buffer.PooledUnsafeDirectByteBuf.getBytes(PooledUnsafeDirectByteBuf.java:156)
at
io.netty.buffer.PooledUnsafeDirectByteBuf.getBytes(PooledUnsafeDirectByteBuf.java:151)
at io.netty.buffer.SlicedByteBuf.getBytes(SlicedByteBuf.java:179)
at io.netty.buffer.AbstractByteBuf.readBytes(AbstractByteBuf.java:717)
at
org.apache.flink.runtime.io.network.netty.PartitionRequestClientHandler.decodeBufferOrEvent(PartitionRequestClientHandler.java:205)
at
org.apache.flink.runtime.io.network.netty.PartitionRequestClientHandler.decodeMsg(PartitionRequestClientHandler.java:164)
at
org.apache.flink.runtime.io.network.netty.PartitionRequestClientHandler.channelRead(PartitionRequestClientHandler.java:118)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374744#comment-14374744 ] ASF GitHub Bot commented on FLINK-1766: --- Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84489355 Great thanks to Ewen. I will first have a study of how to format code. Then pull a request. Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [FLINK-1766]Fix the bug of equals function of ...
Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84489355 Great thanks to Ewen. I will first have a study of how to format code. Then pull a request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374752#comment-14374752 ] ASF GitHub Bot commented on FLINK-1766: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84494016 No problem. We are happy that you are interested to contribute :-) Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: Make Expression API available to Java, Rename ...
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-84488745 Touché --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1766]Fix the bug of equals function of ...
Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84491491 Thanks for Ewen. That help me a lot to understand how to contribute to Flink. I will follow the guide in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-1766) Fix the bug of equals function of FSKey
[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374751#comment-14374751 ] ASF GitHub Bot commented on FLINK-1766: --- Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84491491 Thanks for Ewen. That help me a lot to understand how to contribute to Flink. I will follow the guide in the future. Fix the bug of equals function of FSKey --- Key: FLINK-1766 URL: https://issues.apache.org/jira/browse/FLINK-1766 Project: Flink Issue Type: Bug Reporter: Sibao Hong Priority: Minor The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first have a confirm whether obj == this, if obj is the same object.It should return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (FLINK-1611) Rename classes and packages that contains Nephele
[ https://issues.apache.org/jira/browse/FLINK-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Saputra resolved FLINK-1611. -- Resolution: Duplicate Rename classes and packages that contains Nephele - Key: FLINK-1611 URL: https://issues.apache.org/jira/browse/FLINK-1611 Project: Flink Issue Type: Improvement Components: other Reporter: Henry Saputra Assignee: Henry Saputra Priority: Minor We have several classes and packages names that have Nephele names: ./flink-compiler/src/main/java/org/apache/flink/compiler/plantranslate/NepheleJobGraphGenerator.java ./flink-tests/src/test/java/org/apache/flink/test/broadcastvars/BroadcastVarsNepheleITCase.java ./flink-tests/src/test/java/org/apache/flink/test/broadcastvars/KMeansIterativeNepheleITCase.java ./flink-tests/src/test/java/org/apache/flink/test/iterative/nephele/ConnectedComponentsNepheleITCase.java ./flink-tests/src/test/java/org/apache/flink/test/iterative/nephele/DanglingPageRankNepheleITCase.java ./flink-tests/src/test/java/org/apache/flink/test/iterative/nephele/DanglingPageRankWithCombinerNepheleITCase.java ./flink-tests/src/test/java/org/apache/flink/test/iterative/nephele/IterationWithChainingNepheleITCase.java Nephele was the older name used by Flink in early years to describe the Flink processing engine. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
