[jira] [Commented] (FLINK-1800) Add a Beta badge in the documentation to components in flink-staging
[ https://issues.apache.org/jira/browse/FLINK-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487343#comment-14487343 ] ASF GitHub Bot commented on FLINK-1800: --- Github user uce commented on the pull request: https://github.com/apache/flink/pull/555#issuecomment-91231122 Actually, you are right. I'll remove Beta from Spargel. Add a Beta badge in the documentation to components in flink-staging -- Key: FLINK-1800 URL: https://issues.apache.org/jira/browse/FLINK-1800 Project: Flink Issue Type: Task Components: Documentation Reporter: Robert Metzger Assignee: Robert Metzger Priority: Minor As per mailing list discussion: http://apache-flink-incubator-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Add-a-quot-Beta-quot-badge-in-the-documentation-to-components-in-flink-staging-td4801.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (FLINK-1845) NonReusingSortMergeCoGroupIterator uses ReusingKeyGroupedIterator
[ https://issues.apache.org/jira/browse/FLINK-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-1845. --- NonReusingSortMergeCoGroupIterator uses ReusingKeyGroupedIterator - Key: FLINK-1845 URL: https://issues.apache.org/jira/browse/FLINK-1845 Project: Flink Issue Type: Bug Components: Local Runtime Affects Versions: 0.9 Reporter: Stephan Ewen Assignee: Alexander Alexandrov Fix For: 0.9 This is an unexpected mutability bug. [~aalexandrov] already has created a pull request that fixes this... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [FLINK-1823] Remove linq from Table API docume...
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (FLINK-1853) TopSpeedWindowing example cannot be run from the ComandLine or Webclient
Gyula Fora created FLINK-1853: - Summary: TopSpeedWindowing example cannot be run from the ComandLine or Webclient Key: FLINK-1853 URL: https://issues.apache.org/jira/browse/FLINK-1853 Project: Flink Issue Type: Bug Components: Examples, Streaming Reporter: Gyula Fora When trying to run the TopSpeedWindowing.jar example from either the commandline or webclient the user gets the following excpetion: java.lang.ClassNotFoundException: org.apache.flink.streaming.examples.windowing.TopSpeedWindowing at java.net.URLClassLoader$1.run(URLClassLoader.java:372) at java.net.URLClassLoader$1.run(URLClassLoader.java:361) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:360) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:344) at org.apache.flink.client.program.PackagedProgram.loadMainClass(PackagedProgram.java:516) at org.apache.flink.client.program.PackagedProgram.init(PackagedProgram.java:142) at org.apache.flink.client.program.PackagedProgram.init(PackagedProgram.java:102) at org.apache.flink.client.web.JobSubmissionServlet.doGet(JobSubmissionServlet.java:176) at javax.servlet.http.HttpServlet.service(HttpServlet.java:668) at javax.servlet.http.HttpServlet.service(HttpServlet.java:770) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:532) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:453) at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:227) at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:965) at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:388) at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:187) at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:901) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117) at org.eclipse.jetty.server.handler.HandlerList.handle(HandlerList.java:47) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:113) at org.eclipse.jetty.server.Server.handle(Server.java:352) at org.eclipse.jetty.server.HttpConnection.handleRequest(HttpConnection.java:596) at org.eclipse.jetty.server.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:1048) at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:549) at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:211) at org.eclipse.jetty.server.HttpConnection.handle(HttpConnection.java:425) at org.eclipse.jetty.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:489) at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:436) at java.lang.Thread.run(Thread.java:745) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [FLINK-1847] Changes collect to return a Seq[T...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/583#issuecomment-91326117 +1 looks good and pretty important, since this would be API breaking to change after 0.9. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1800][docs] Add beta badge to component...
Github user uce commented on the pull request: https://github.com/apache/flink/pull/555#issuecomment-91226516 I'm merging this with my change. I will leave Spargel with the beta tag (as it is in staging) and start a discussion on dev@ about what to do with it in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (FLINK-1854) Planvisualizer cannot visualize the streaming iteration example
Gyula Fora created FLINK-1854: - Summary: Planvisualizer cannot visualize the streaming iteration example Key: FLINK-1854 URL: https://issues.apache.org/jira/browse/FLINK-1854 Project: Flink Issue Type: Bug Components: Examples, Streaming Reporter: Gyula Fora Planvisualizer cannot visualize the streaming iteration example. The generated json for the plan is: {nodes:[{id:1,type:Custom Source,pact:Data Source,contents:Custom Source at RandomFibonacciSource,parallelism:1},{id:2,type:Map,pact:Data Stream,contents:Map at InputMap,parallelism:8,predecessors:[{id:1,ship_strategy:FORWARD,side:second}]},{id:3,type:Map,pact:Data Stream,contents:Map at Step,parallelism:8,predecessors:[{id:2,ship_strategy:FORWARD,side:second},{id:4,ship_strategy:FORWARD,side:second}]},{id:4,type:Map,pact:Data Source,contents:Map,parallelism:8},{id:5,type:Map,pact:Data Stream,contents:Map,parallelism:8,predecessors:[{id:3,ship_strategy:FORWARD,side:second}]},{id:6,type:Map,pact:Data Stream,contents:Map at OutputMap,parallelism:8,predecessors:[{id:3,ship_strategy:FORWARD,side:second}]},{id:7,type:Stream Sink,pact:Data Stream,contents:Stream Sink at PrintSinkFunction,parallelism:8,predecessors:[{id:6,ship_strategy:FORWARD,side:second}]}]} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487956#comment-14487956 ] ASF GitHub Bot commented on FLINK-1847: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/583#issuecomment-91326117 +1 looks good and pretty important, since this would be API breaking to change after 0.9. Change Scala collect() method to return a Seq - Key: FLINK-1847 URL: https://issues.apache.org/jira/browse/FLINK-1847 Project: Flink Issue Type: Bug Components: Scala API Affects Versions: 0.9 Reporter: Stephan Ewen Assignee: Till Rohrmann Right now, the method is very specific in returning {{mutable.Buffer}}. Changing it to {{Seq}} allows us to alter the underlying representation without breaking the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (FLINK-1847) Change Scala collect() method to return a Seq
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-1847. - Resolution: Fixed Fix Version/s: 0.9 Fixed via e45f13f5351c1550fc4413c534effe213ddeb059 Change Scala collect() method to return a Seq - Key: FLINK-1847 URL: https://issues.apache.org/jira/browse/FLINK-1847 Project: Flink Issue Type: Bug Components: Scala API Affects Versions: 0.9 Reporter: Stephan Ewen Assignee: Till Rohrmann Fix For: 0.9 Right now, the method is very specific in returning {{mutable.Buffer}}. Changing it to {{Seq}} allows us to alter the underlying representation without breaking the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [FLINK-1800][docs] Add beta badge to component...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/555 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (FLINK-1855) SocketTextStreamWordCount example cannot be run from the webclient
Gyula Fora created FLINK-1855: - Summary: SocketTextStreamWordCount example cannot be run from the webclient Key: FLINK-1855 URL: https://issues.apache.org/jira/browse/FLINK-1855 Project: Flink Issue Type: Bug Components: Examples, Streaming, Webfrontend Reporter: Gyula Fora When trying to parameterize(with for instance localhost ) the SocketTextStreamWordCount streaming example from the webclient, I get the following error: HTTP ERROR: 500 Problem accessing /runJob. Reason: org/apache/flink/streaming/examples/wordcount/WordCount -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487267#comment-14487267 ] ASF GitHub Bot commented on FLINK-1847: --- GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/583 [FLINK-1847] Changes collect to return a Seq[T] and adds parentheses Changes the return type of Scala API's collect method to Seq[T] and adds parentheses to collect and count methods. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink fixScalaCollect Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/583.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #583 commit cf1b2e3da4e9a9ded929a73d2ecce2fb4046b778 Author: Till Rohrmann trohrm...@apache.org Date: 2015-04-09T10:26:53Z [FLINK-1847] [Scala API] Changes the return type of Scala API's collect method to Seq[T] and adds parentheses to collect and count methods. [FLINK-1847] [Scala API] Updates existing test cases using Scala API's collect/count method. Change Scala collect() method to return a Seq - Key: FLINK-1847 URL: https://issues.apache.org/jira/browse/FLINK-1847 Project: Flink Issue Type: Bug Components: Scala API Affects Versions: 0.9 Reporter: Stephan Ewen Assignee: Till Rohrmann Right now, the method is very specific in returning {{mutable.Buffer}}. Changing it to {{Seq}} allows us to alter the underlying representation without breaking the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [docs] Add clickable stack figure on overview ...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/585#issuecomment-91324826 I think it is great as it is. +1 to add! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488176#comment-14488176 ] ASF GitHub Bot commented on FLINK-1847: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/583 Change Scala collect() method to return a Seq - Key: FLINK-1847 URL: https://issues.apache.org/jira/browse/FLINK-1847 Project: Flink Issue Type: Bug Components: Scala API Affects Versions: 0.9 Reporter: Stephan Ewen Assignee: Till Rohrmann Right now, the method is very specific in returning {{mutable.Buffer}}. Changing it to {{Seq}} allows us to alter the underlying representation without breaking the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [FLINK-1847] Changes collect to return a Seq[T...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/583 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (FLINK-1852) Scala API's count and collect methods are declared without parenthesis
Till Rohrmann created FLINK-1852: Summary: Scala API's count and collect methods are declared without parenthesis Key: FLINK-1852 URL: https://issues.apache.org/jira/browse/FLINK-1852 Project: Flink Issue Type: Bug Components: Scala API Reporter: Till Rohrmann Priority: Minor The Scala API's {{count}} and {{collect}} methods are declared without parentheses indicating that these methods don't have any side effects. Since they trigger the execution of the {{ExecutionGraph}} and in the future will buffer the intermediate results somewhere, they definitely have side effects. Therefore, I'd propose to add parentheses to these methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (FLINK-1845) NonReusingSortMergeCoGroupIterator uses ReusingKeyGroupedIterator
[ https://issues.apache.org/jira/browse/FLINK-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-1845. - Resolution: Fixed Fixed in 8740d1e77b82365c009c0fff37fd24c24a67f8bc Thanks for the patch! NonReusingSortMergeCoGroupIterator uses ReusingKeyGroupedIterator - Key: FLINK-1845 URL: https://issues.apache.org/jira/browse/FLINK-1845 Project: Flink Issue Type: Bug Components: Local Runtime Affects Versions: 0.9 Reporter: Stephan Ewen Assignee: Alexander Alexandrov Fix For: 0.9 This is an unexpected mutability bug. [~aalexandrov] already has created a pull request that fixes this... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-1850) Snapshot docs overview page refers to wrong version
Ufuk Celebi created FLINK-1850: -- Summary: Snapshot docs overview page refers to wrong version Key: FLINK-1850 URL: https://issues.apache.org/jira/browse/FLINK-1850 Project: Flink Issue Type: Bug Components: docs Affects Versions: master Reporter: Ufuk Celebi Priority: Minor The overview page of the docs (index.html) refers to release-0.8. While editing, let's add a paragraph about the snapshot version (links to how to build it, that users can [most of the time] expect it to be stable etc.). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1799) Scala API does not support generic arrays
[ https://issues.apache.org/jira/browse/FLINK-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487977#comment-14487977 ] ASF GitHub Bot commented on FLINK-1799: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/582#issuecomment-91327192 Instead of the switch/case statement, can't you use `PrimitiveArrayTypeInfo.getInfoFor(ClassX type)`? Seems simpler. Also, this is a good change to be backed by a Unit test case, rather than an Integration test case. I really think that such changes should be guarded by more fine grained tests (Unit Tests(, rather than the big hammer kind of test (have a distributed program that uses this). Out testing time goes through the roof otherwise. I fund that unit tests are a cycle or two more work to write, but typically also get you thinking better about what cases the tests should cover. Scala API does not support generic arrays - Key: FLINK-1799 URL: https://issues.apache.org/jira/browse/FLINK-1799 Project: Flink Issue Type: Bug Reporter: Till Rohrmann Assignee: Aljoscha Krettek The Scala API does not support generic arrays at the moment. It throws a rather unhelpful error message ```InvalidTypesException: The given type is not a valid object array```. Code to reproduce the problem is given below: {code} def main(args: Array[String]) { foobar[Double] } def foobar[T: ClassTag: TypeInformation]: DataSet[Block[T]] = { val tpe = createTypeInformation[Array[T]] null } {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (FLINK-1852) Scala API's count and collect methods are declared without parenthesis
[ https://issues.apache.org/jira/browse/FLINK-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-1852. Resolution: Duplicate See FLINK-1847 Scala API's count and collect methods are declared without parenthesis -- Key: FLINK-1852 URL: https://issues.apache.org/jira/browse/FLINK-1852 Project: Flink Issue Type: Bug Components: Scala API Reporter: Till Rohrmann Priority: Minor The Scala API's {{count}} and {{collect}} methods are declared without parentheses indicating that these methods don't have any side effects. Since they trigger the execution of the {{ExecutionGraph}} and in the future will buffer the intermediate results somewhere, they definitely have side effects. Therefore, I'd propose to add parentheses to these methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-1856) Add required imports to Scala API examples
Robert Metzger created FLINK-1856: - Summary: Add required imports to Scala API examples Key: FLINK-1856 URL: https://issues.apache.org/jira/browse/FLINK-1856 Project: Flink Issue Type: Bug Components: Documentation Affects Versions: 0.9 Reporter: Robert Metzger We should add all required code (if it is not obvious) to the examples in the documentation. There are too may users affected by this: http://stackoverflow.com/questions/29540121/flink-scala-api-not-enough-arguments/29541055 http://apache-flink-incubator-user-mailing-list-archive.2336050.n4.nabble.com/Flink-cannot-compile-my-join-code-td709.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [FLINK-1799][scala] Fix handling of generic ar...
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/582 [FLINK-1799][scala] Fix handling of generic arrays You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink fix-scala-generic-arrays Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/582.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #582 commit ac1b4111704933169f46515caffbe2607d263677 Author: Aljoscha Krettek aljoscha.kret...@gmail.com Date: 2015-04-09T12:05:08Z [FLINK-1799][scala] Fix handling of generic arrays --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-1821) simplify coding
[ https://issues.apache.org/jira/browse/FLINK-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487349#comment-14487349 ] Liu Jiongzhou commented on FLINK-1821: -- thanks guys, it acturally depends on personal preference. keep the explicit else branch might be ok. simplify coding Key: FLINK-1821 URL: https://issues.apache.org/jira/browse/FLINK-1821 Project: Flink Issue Type: Improvement Components: Local Runtime Reporter: Liu Jiongzhou Assignee: Liu Jiongzhou There is no need to maintain an else syntax in line 157 of org.apache.flink.util.AbstractID. Remove it for coding simplification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (FLINK-1821) simplify coding
[ https://issues.apache.org/jira/browse/FLINK-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiongzhou closed FLINK-1821. Resolution: Fixed simplify coding Key: FLINK-1821 URL: https://issues.apache.org/jira/browse/FLINK-1821 Project: Flink Issue Type: Improvement Components: Local Runtime Reporter: Liu Jiongzhou Assignee: Liu Jiongzhou There is no need to maintain an else syntax in line 157 of org.apache.flink.util.AbstractID. Remove it for coding simplification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [docs] Add custom search (backport)
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/564#issuecomment-91267478 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [docs] Add custom search
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/563#issuecomment-91267445 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1800][docs] Add beta badge to component...
Github user uce commented on the pull request: https://github.com/apache/flink/pull/555#issuecomment-91231122 Actually, you are right. I'll remove Beta from Spargel. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1710] [table] Switch compile backend to...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/584#issuecomment-91325622 Looks good! Any concrete numbers in how the compile time changes? I assume this is now shipping java code strings which get compiled in each function / serializer / comparator? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (FLINK-1856) Add required imports to Scala API examples
[ https://issues.apache.org/jira/browse/FLINK-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-1856: -- Labels: starter (was: ) Add required imports to Scala API examples -- Key: FLINK-1856 URL: https://issues.apache.org/jira/browse/FLINK-1856 Project: Flink Issue Type: Bug Components: Documentation, Scala API Affects Versions: 0.9 Reporter: Robert Metzger Labels: starter We should add all required code (if it is not obvious) to the examples in the documentation. There are too may users affected by this: http://stackoverflow.com/questions/29540121/flink-scala-api-not-enough-arguments/29541055 http://apache-flink-incubator-user-mailing-list-archive.2336050.n4.nabble.com/Flink-cannot-compile-my-join-code-td709.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FLINK-1856) Add required imports to Scala API examples
[ https://issues.apache.org/jira/browse/FLINK-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-1856: -- Component/s: Scala API Add required imports to Scala API examples -- Key: FLINK-1856 URL: https://issues.apache.org/jira/browse/FLINK-1856 Project: Flink Issue Type: Bug Components: Documentation, Scala API Affects Versions: 0.9 Reporter: Robert Metzger Labels: starter We should add all required code (if it is not obvious) to the examples in the documentation. There are too may users affected by this: http://stackoverflow.com/questions/29540121/flink-scala-api-not-enough-arguments/29541055 http://apache-flink-incubator-user-mailing-list-archive.2336050.n4.nabble.com/Flink-cannot-compile-my-join-code-td709.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1809) Add standard scaler to ML library
[ https://issues.apache.org/jira/browse/FLINK-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487638#comment-14487638 ] ASF GitHub Bot commented on FLINK-1809: --- Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/579#issuecomment-91286399 Maybe we could name the package ```org.apache.flink.ml.preprocessing``` instead of ```org.apache.flink.ml.preprocess```. What do you think? If you include in the title of the PR the JIRA issue, like [FLINK-1809] Adds standard scaler to ml library, then all our comments here will be automatically added to the corresponding JIRA issue. Add standard scaler to ML library - Key: FLINK-1809 URL: https://issues.apache.org/jira/browse/FLINK-1809 Project: Flink Issue Type: Improvement Components: Machine Learning Library Reporter: Till Rohrmann Assignee: Faye Beligianni Priority: Minor Labels: ML Many ML algorithms require the input data to have mean 0 and a variance 1 for each individual feature [1]. Therefore, a {{Transformer}} which achieves exactly that would be a valuable addition to the machine learning library. Resources: [1] [http://scikit-learn.org/stable/modules/generated/sklearn.preprocessing.StandardScaler.html] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [FLINK-1799][scala] Fix handling of generic ar...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/582#issuecomment-91327192 Instead of the switch/case statement, can't you use `PrimitiveArrayTypeInfo.getInfoFor(ClassX type)`? Seems simpler. Also, this is a good change to be backed by a Unit test case, rather than an Integration test case. I really think that such changes should be guarded by more fine grained tests (Unit Tests(, rather than the big hammer kind of test (have a distributed program that uses this). Out testing time goes through the roof otherwise. I fund that unit tests are a cycle or two more work to write, but typically also get you thinking better about what cases the tests should cover. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Closed] (FLINK-1847) Change Scala collect() method to return a Seq
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-1847. --- Change Scala collect() method to return a Seq - Key: FLINK-1847 URL: https://issues.apache.org/jira/browse/FLINK-1847 Project: Flink Issue Type: Bug Components: Scala API Affects Versions: 0.9 Reporter: Stephan Ewen Assignee: Till Rohrmann Fix For: 0.9 Right now, the method is very specific in returning {{mutable.Buffer}}. Changing it to {{Seq}} allows us to alter the underlying representation without breaking the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [docs] Add clickable stack figure on overview ...
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/585 [docs] Add clickable stack figure on overview page This commit adds a figure giving an overview of Flink's stack. Users can click on components to go to the respective component docs. ![screen shot 2015-04-09 at 15 02 39](https://cloud.githubusercontent.com/assets/1756620/7067175/8706309a-dec9-11e4-889f-a93c76444733.png) I'm sure there will be people who vote for other colors etc. Please only provide comments with concrete suggestions on what to change. ;) This is only for 0.9-SNAPSHOT. Do we want another version for 0.8 w/o Gelly, ML, Table, and, Tez? You can merge this pull request into a Git repository by running: $ git pull https://github.com/uce/incubator-flink stack_overview Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/585.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #585 commit 11d727d7e6d9ee5aa2fc227d846d777dd559f055 Author: Ufuk Celebi u...@apache.org Date: 2015-04-09T13:04:45Z [docs] Add clickable stack figure on overview page This commit adds a figure giving an overview of Flink's stack. Users can click on components to go to the respective component docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-1710) Expression API Tests take very long
[ https://issues.apache.org/jira/browse/FLINK-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487952#comment-14487952 ] ASF GitHub Bot commented on FLINK-1710: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/584#issuecomment-91325622 Looks good! Any concrete numbers in how the compile time changes? I assume this is now shipping java code strings which get compiled in each function / serializer / comparator? Expression API Tests take very long --- Key: FLINK-1710 URL: https://issues.apache.org/jira/browse/FLINK-1710 Project: Flink Issue Type: Bug Components: Expression API Affects Versions: 0.9 Reporter: Stephan Ewen Assignee: Aljoscha Krettek Fix For: 0.9 The tests of the Expression API take an immense amount of time, compared to the other API tests. Is that because they execute on large (generated) data sets, because the program compilation overhead is high, or because there is an inefficiency in the execution still? Running org.apache.flink.api.scala.expressions.AggregationsITCase Running org.apache.flink.api.scala.expressions.SelectITCase Running org.apache.flink.api.scala.expressions.AsITCase Running org.apache.flink.api.scala.expressions.StringExpressionsITCase Running org.apache.flink.api.scala.expressions.CastingITCase Running org.apache.flink.api.scala.expressions.JoinITCase Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.652 sec - in org.apache.flink.api.scala.expressions.AsITCase Running org.apache.flink.api.scala.expressions.GroupedAggreagationsITCase Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.797 sec - in org.apache.flink.api.scala.expressions.StringExpressionsITCase Running org.apache.flink.api.scala.expressions.PageRankExpressionITCase Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.072 sec - in org.apache.flink.api.scala.expressions.SelectITCase Running org.apache.flink.api.scala.expressions.ExpressionsITCase Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 65.628 sec - in org.apache.flink.api.scala.expressions.CastingITCase Running org.apache.flink.api.scala.expressions.FilterITCase Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 74.174 sec - in org.apache.flink.api.scala.expressions.AggregationsITCase Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 93.878 sec - in org.apache.flink.api.scala.expressions.JoinITCase Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.4 sec - in org.apache.flink.api.scala.expressions.GroupedAggreagationsITCase Tests run: 12, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 44.179 sec - in org.apache.flink.api.scala.expressions.FilterITCase Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 53.801 sec - in org.apache.flink.api.scala.expressions.ExpressionsITCase Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 124.365 sec - in org.apache.flink.api.scala.expressions.PageRankExpressionITCase -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: Ml branch
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/579#issuecomment-91286399 Maybe we could name the package ```org.apache.flink.ml.preprocessing``` instead of ```org.apache.flink.ml.preprocess```. What do you think? If you include in the title of the PR the JIRA issue, like [FLINK-1809] Adds standard scaler to ml library, then all our comments here will be automatically added to the corresponding JIRA issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1710] [table] Switch compile backend to...
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/584 [FLINK-1710] [table] Switch compile backend to Janino This greatly reduces compile time while still supporting the same feature set. I added Janino in flink-bin/LICENSE and flink-bin/NOTICE. I hope this is correct. Can someone comment on this? You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink table-janino Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/584.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #584 commit 21d85679b4b8fb47c8b0200cc06d7a39b188be69 Author: Aljoscha Krettek aljoscha.kret...@gmail.com Date: 2015-04-07T16:11:16Z [FLINK-1710] [table] Switch compile backend to Janino This greatly reduces compile time while still supporting the same feature set. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (FLINK-1823) Rename linq.md to something like table.md to avoid potential trademark issue
[ https://issues.apache.org/jira/browse/FLINK-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek resolved FLINK-1823. - Resolution: Fixed Fixed in : https://github.com/apache/flink/commit/80b570be541c6b1a55df3d5ec8bbac4935aaff38 Rename linq.md to something like table.md to avoid potential trademark issue Key: FLINK-1823 URL: https://issues.apache.org/jira/browse/FLINK-1823 Project: Flink Issue Type: Bug Components: Documentation Reporter: Henry Saputra Assignee: Aljoscha Krettek Priority: Minor Since LINQ is trademarked to Microsoft in related to language integrated query, I suggest we rename docs/linq.md to something else like table.md or integratedquery.md to just avoid potential issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488020#comment-14488020 ] ASF GitHub Bot commented on FLINK-1847: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/583#issuecomment-91330315 Merging this... Change Scala collect() method to return a Seq - Key: FLINK-1847 URL: https://issues.apache.org/jira/browse/FLINK-1847 Project: Flink Issue Type: Bug Components: Scala API Affects Versions: 0.9 Reporter: Stephan Ewen Assignee: Till Rohrmann Right now, the method is very specific in returning {{mutable.Buffer}}. Changing it to {{Seq}} allows us to alter the underlying representation without breaking the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1799) Scala API does not support generic arrays
[ https://issues.apache.org/jira/browse/FLINK-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487263#comment-14487263 ] ASF GitHub Bot commented on FLINK-1799: --- GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/582 [FLINK-1799][scala] Fix handling of generic arrays You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink fix-scala-generic-arrays Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/582.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #582 commit ac1b4111704933169f46515caffbe2607d263677 Author: Aljoscha Krettek aljoscha.kret...@gmail.com Date: 2015-04-09T12:05:08Z [FLINK-1799][scala] Fix handling of generic arrays Scala API does not support generic arrays - Key: FLINK-1799 URL: https://issues.apache.org/jira/browse/FLINK-1799 Project: Flink Issue Type: Bug Reporter: Till Rohrmann Assignee: Aljoscha Krettek The Scala API does not support generic arrays at the moment. It throws a rather unhelpful error message ```InvalidTypesException: The given type is not a valid object array```. Code to reproduce the problem is given below: {code} def main(args: Array[String]) { foobar[Double] } def foobar[T: ClassTag: TypeInformation]: DataSet[Block[T]] = { val tpe = createTypeInformation[Array[T]] null } {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1710) Expression API Tests take very long
[ https://issues.apache.org/jira/browse/FLINK-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487285#comment-14487285 ] ASF GitHub Bot commented on FLINK-1710: --- GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/584 [FLINK-1710] [table] Switch compile backend to Janino This greatly reduces compile time while still supporting the same feature set. I added Janino in flink-bin/LICENSE and flink-bin/NOTICE. I hope this is correct. Can someone comment on this? You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink table-janino Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/584.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #584 commit 21d85679b4b8fb47c8b0200cc06d7a39b188be69 Author: Aljoscha Krettek aljoscha.kret...@gmail.com Date: 2015-04-07T16:11:16Z [FLINK-1710] [table] Switch compile backend to Janino This greatly reduces compile time while still supporting the same feature set. Expression API Tests take very long --- Key: FLINK-1710 URL: https://issues.apache.org/jira/browse/FLINK-1710 Project: Flink Issue Type: Bug Components: Expression API Affects Versions: 0.9 Reporter: Stephan Ewen Assignee: Aljoscha Krettek Fix For: 0.9 The tests of the Expression API take an immense amount of time, compared to the other API tests. Is that because they execute on large (generated) data sets, because the program compilation overhead is high, or because there is an inefficiency in the execution still? Running org.apache.flink.api.scala.expressions.AggregationsITCase Running org.apache.flink.api.scala.expressions.SelectITCase Running org.apache.flink.api.scala.expressions.AsITCase Running org.apache.flink.api.scala.expressions.StringExpressionsITCase Running org.apache.flink.api.scala.expressions.CastingITCase Running org.apache.flink.api.scala.expressions.JoinITCase Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.652 sec - in org.apache.flink.api.scala.expressions.AsITCase Running org.apache.flink.api.scala.expressions.GroupedAggreagationsITCase Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.797 sec - in org.apache.flink.api.scala.expressions.StringExpressionsITCase Running org.apache.flink.api.scala.expressions.PageRankExpressionITCase Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.072 sec - in org.apache.flink.api.scala.expressions.SelectITCase Running org.apache.flink.api.scala.expressions.ExpressionsITCase Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 65.628 sec - in org.apache.flink.api.scala.expressions.CastingITCase Running org.apache.flink.api.scala.expressions.FilterITCase Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 74.174 sec - in org.apache.flink.api.scala.expressions.AggregationsITCase Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 93.878 sec - in org.apache.flink.api.scala.expressions.JoinITCase Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.4 sec - in org.apache.flink.api.scala.expressions.GroupedAggreagationsITCase Tests run: 12, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 44.179 sec - in org.apache.flink.api.scala.expressions.FilterITCase Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 53.801 sec - in org.apache.flink.api.scala.expressions.ExpressionsITCase Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 124.365 sec - in org.apache.flink.api.scala.expressions.PageRankExpressionITCase -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [docs] Add clickable stack figure on overview ...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/585#issuecomment-91235819 Nice work, thank you. I think its fine to add this only to 0.9. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-1800) Add a Beta badge in the documentation to components in flink-staging
[ https://issues.apache.org/jira/browse/FLINK-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487326#comment-14487326 ] ASF GitHub Bot commented on FLINK-1800: --- Github user uce commented on the pull request: https://github.com/apache/flink/pull/555#issuecomment-91226516 I'm merging this with my change. I will leave Spargel with the beta tag (as it is in staging) and start a discussion on dev@ about what to do with it in the future. Add a Beta badge in the documentation to components in flink-staging -- Key: FLINK-1800 URL: https://issues.apache.org/jira/browse/FLINK-1800 Project: Flink Issue Type: Task Components: Documentation Reporter: Robert Metzger Assignee: Robert Metzger Priority: Minor As per mailing list discussion: http://apache-flink-incubator-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Add-a-quot-Beta-quot-badge-in-the-documentation-to-components-in-flink-staging-td4801.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [FLINK-1847] Changes collect to return a Seq[T...
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/583 [FLINK-1847] Changes collect to return a Seq[T] and adds parentheses Changes the return type of Scala API's collect method to Seq[T] and adds parentheses to collect and count methods. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink fixScalaCollect Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/583.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #583 commit cf1b2e3da4e9a9ded929a73d2ecce2fb4046b778 Author: Till Rohrmann trohrm...@apache.org Date: 2015-04-09T10:26:53Z [FLINK-1847] [Scala API] Changes the return type of Scala API's collect method to Seq[T] and adds parentheses to collect and count methods. [FLINK-1847] [Scala API] Updates existing test cases using Scala API's collect/count method. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1847] Changes collect to return a Seq[T...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/583#issuecomment-91330315 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487089#comment-14487089 ] Till Rohrmann commented on FLINK-1847: -- I strongly agree with this policy. Change Scala collect() method to return a Seq - Key: FLINK-1847 URL: https://issues.apache.org/jira/browse/FLINK-1847 Project: Flink Issue Type: Bug Components: Scala API Affects Versions: 0.9 Reporter: Stephan Ewen Right now, the method is very specific in returning {{mutable.Buffer}}. Changing it to {{Seq}} allows us to alter the underlying representation without breaking the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (FLINK-1847) Change Scala collect() method to return a Seq
[ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-1847: Assignee: Till Rohrmann Change Scala collect() method to return a Seq - Key: FLINK-1847 URL: https://issues.apache.org/jira/browse/FLINK-1847 Project: Flink Issue Type: Bug Components: Scala API Affects Versions: 0.9 Reporter: Stephan Ewen Assignee: Till Rohrmann Right now, the method is very specific in returning {{mutable.Buffer}}. Changing it to {{Seq}} allows us to alter the underlying representation without breaking the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)