[jira] [Commented] (FLINK-7201) ConcurrentModificationException in JobLeaderIdService

2017-07-15 Thread Aljoscha Krettek (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088717#comment-16088717
 ] 

Aljoscha Krettek commented on FLINK-7201:
-

[~StephanEwen] do you have the expertise for looking at this or do we need to 
wait for [~till.rohrmann] to get back?

I marked this as "flip-6", there's no comments on {{MiniCluster}} but this 
seems to part of the FLIP-6 overhaul of the distributed runtime.

> ConcurrentModificationException in JobLeaderIdService
> -
>
> Key: FLINK-7201
> URL: https://issues.apache.org/jira/browse/FLINK-7201
> Project: Flink
>  Issue Type: Bug
>  Components: JobManager
>Reporter: Xu Pingyong
>Assignee: Xu Pingyong
>  Labels: flip-6
>
> {code:java}
>  java.util.ConcurrentModificationException: null
>   at java.util.HashMap$HashIterator.nextEntry(HashMap.java:922)
>   at java.util.HashMap$ValueIterator.next(HashMap.java:950)
>   at 
> org.apache.flink.runtime.resourcemanager.JobLeaderIdService.clear(JobLeaderIdService.java:114)
>   at 
> org.apache.flink.runtime.resourcemanager.JobLeaderIdService.stop(JobLeaderIdService.java:92)
>   at 
> org.apache.flink.runtime.resourcemanager.ResourceManager.shutDown(ResourceManager.java:200)
>   at 
> org.apache.flink.runtime.resourcemanager.ResourceManagerRunner.shutDownInternally(ResourceManagerRunner.java:102)
>   at 
> org.apache.flink.runtime.resourcemanager.ResourceManagerRunner.shutDown(ResourceManagerRunner.java:97)
>   at 
> org.apache.flink.runtime.minicluster.MiniCluster.shutdownInternally(MiniCluster.java:329)
>   at 
> org.apache.flink.runtime.minicluster.MiniCluster.shutdown(MiniCluster.java:297)
>   at 
> org.apache.flink.runtime.minicluster.MiniClusterITCase.runJobWithMultipleJobManagers(MiniClusterITCase.java:85)
> {code}
> Because the jobLeaderIdService stops before the rpcService when shutdown the 
> resourceManager, jobLeaderIdService has a risk of thread-unsafe.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (FLINK-7201) ConcurrentModificationException in JobLeaderIdService

2017-07-15 Thread Aljoscha Krettek (JIRA) 

 [ 
https://issues.apache.org/jira/browse/FLINK-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aljoscha Krettek updated FLINK-7201:

Labels: flip-6  (was: )

> ConcurrentModificationException in JobLeaderIdService
> -
>
> Key: FLINK-7201
> URL: https://issues.apache.org/jira/browse/FLINK-7201
> Project: Flink
>  Issue Type: Bug
>  Components: JobManager
>Reporter: Xu Pingyong
>Assignee: Xu Pingyong
>  Labels: flip-6
>
> {code:java}
>  java.util.ConcurrentModificationException: null
>   at java.util.HashMap$HashIterator.nextEntry(HashMap.java:922)
>   at java.util.HashMap$ValueIterator.next(HashMap.java:950)
>   at 
> org.apache.flink.runtime.resourcemanager.JobLeaderIdService.clear(JobLeaderIdService.java:114)
>   at 
> org.apache.flink.runtime.resourcemanager.JobLeaderIdService.stop(JobLeaderIdService.java:92)
>   at 
> org.apache.flink.runtime.resourcemanager.ResourceManager.shutDown(ResourceManager.java:200)
>   at 
> org.apache.flink.runtime.resourcemanager.ResourceManagerRunner.shutDownInternally(ResourceManagerRunner.java:102)
>   at 
> org.apache.flink.runtime.resourcemanager.ResourceManagerRunner.shutDown(ResourceManagerRunner.java:97)
>   at 
> org.apache.flink.runtime.minicluster.MiniCluster.shutdownInternally(MiniCluster.java:329)
>   at 
> org.apache.flink.runtime.minicluster.MiniCluster.shutdown(MiniCluster.java:297)
>   at 
> org.apache.flink.runtime.minicluster.MiniClusterITCase.runJobWithMultipleJobManagers(MiniClusterITCase.java:85)
> {code}
> Because the jobLeaderIdService stops before the rpcService when shutdown the 
> resourceManager, jobLeaderIdService has a risk of thread-unsafe.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7180) CoGroupStream perform checkpoint failed

2017-07-15 Thread Aljoscha Krettek (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088716#comment-16088716
 ] 

Aljoscha Krettek commented on FLINK-7180:
-

Cool, thanks for letting us know! :-)

> CoGroupStream perform checkpoint failed
> ---
>
> Key: FLINK-7180
> URL: https://issues.apache.org/jira/browse/FLINK-7180
> Project: Flink
>  Issue Type: Bug
>  Components: DataStream API
>Affects Versions: 1.3.1
>Reporter: Sihua Zhou
>Assignee: Sihua Zhou
>Priority: Blocker
> Fix For: 1.3.2
>
>
> When using the CoGroup api and enable the checkpoint, Job will failed when 
> performing checkpoint, e.g:
> {code:java}
> input1.coGroup(input2)
> .where(new KeySelector() {
> @Override
> public String getKey(String value) throws Exception {
> return value;
> }
> })
> .equalTo(new KeySelector() {
> @Override
> public String getKey(String value) throws Exception {
> return value;
> }
> })
> .window(SlothJoinWindow.create())
> .trigger(new SlothWindowTrigger(0))
> .apply(new CoGroupFunction() {
> @Override
> public void coGroup(Iterable first, 
> Iterable second, Collector out) throws Exception {
> String outputStr = "first:" + first + " , second:" + 
> second;
> System.out.println(outputStr);
> out.collect(outputStr);
> }
> })
> .keyBy(new KeySelector() {
> @Override
> public String getKey(String value) throws Exception {
> return value;
> }
> })
> .print();
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7127) Remove unnecessary null check or add null check

2017-07-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088649#comment-16088649
 ] 

ASF GitHub Bot commented on FLINK-7127:
---

GitHub user mylog00 opened a pull request:

https://github.com/apache/flink/pull/4349

[FLINK-7127] [runtime] Remove unnecessary null check or add null check;

To avoid NPE I decided add null check instead remove it one.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mylog00/flink FLINK-7127

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4349


commit 9370470b4674d414e9fd0d1f6146a4a9de92cc70
Author: Dmitrii Kniazev 
Date:   2017-07-10T18:41:32Z

[FLINK-7127] [runtime] Remove unnecessary null check or add null check;




> Remove unnecessary null check or add null check
> ---
>
> Key: FLINK-7127
> URL: https://issues.apache.org/jira/browse/FLINK-7127
> Project: Flink
>  Issue Type: Improvement
>  Components: State Backends, Checkpointing
>Reporter: Ufuk Celebi
>Priority: Trivial
>  Labels: starter
>
> In {{HeapKeyedStateBackend#snapshot}} we have:
> {code}
> for (Map.Entry> kvState : stateTables.entrySet()) 
> {
>   // 1) Here we don't check for null
>   metaInfoSnapshots.add(kvState.getValue().getMetaInfo().snapshot());
>   kVStateToId.put(kvState.getKey(), kVStateToId.size());
>   // 2) Here we check for null
>   StateTable stateTable = kvState.getValue();
>   if (null != stateTable) {
>   cowStateStableSnapshots.put(stateTable, 
> stateTable.createSnapshot());
>   }
> }
> {code}
> Either this can lead to a NPE and we should check it in 1) or we remove the 
> null check in 2). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] flink pull request #4349: [FLINK-7127] [runtime] Remove unnecessary null che...

2017-07-15 Thread mylog00 
GitHub user mylog00 opened a pull request:

https://github.com/apache/flink/pull/4349

[FLINK-7127] [runtime] Remove unnecessary null check or add null check;

To avoid NPE I decided add null check instead remove it one.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mylog00/flink FLINK-7127

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4349


commit 9370470b4674d414e9fd0d1f6146a4a9de92cc70
Author: Dmitrii Kniazev 
Date:   2017-07-10T18:41:32Z

[FLINK-7127] [runtime] Remove unnecessary null check or add null check;




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (FLINK-7200) Make metrics more Datadog friendly

2017-07-15 Thread Chesnay Schepler (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088602#comment-16088602
 ] 

Chesnay Schepler commented on FLINK-7200:
-

You can configure the the components contained in the metric name using scope 
formats, as described in the metrics documentation: 
https://ci.apache.org/projects/flink/flink-docs-release-1.4/monitoring/metrics.html#scope

All your suggestions can be accomplished with this feature.

> Make metrics more Datadog friendly
> --
>
> Key: FLINK-7200
> URL: https://issues.apache.org/jira/browse/FLINK-7200
> Project: Flink
>  Issue Type: Improvement
>  Components: Metrics
>Affects Versions: 1.3.1
>Reporter: Robert Batts
>Priority: Minor
>
> The current output of the Datadog Reporter is a little unfriendly to the 
> platform they are going to from a metrics name perspective. Take for example 
> the metric used reporting with the Datadog Kafka integration.
> kafka.consumer_lag= [topic:, consumer_group: , partition: ]
> Through the use of tags (in this case topic, consumer_group, and partition) 
> you can create graphs in Datadog filtered to a specific topic and 
> consumer_group and then averaged on each partition. This allows you to 
> visualize something like a heatmap for lag on each partition for a consumer.
> So what am I suggesting for Flink? Currently, I think the tags for Datadog 
> are in a great place. Tags like job_id and subtask_id would be great for 
> filtering and grouping. But, the metric name is currently too specific to a 
> taskmanager and subtask. Currently, the metrics look something like this:
> flink_w04.taskmanager.4f378aff5730.TwitterExample.ExtractHashtags.7.numRecordsOut
> {host}.taskmanager.{tm_id}.{job_name}.{operator_name}.{subtask_index}.{metric_name}
> What I am suggesting is something more like this:
> taskmanager.TwitterExample.ExtractHashtags.numRecordsOut
> taskmanager.{job_name}.{operator_name}.{metric_name}
> (or even taskmanager.{metric_name}, but that would be a lot of tags on a 
> single metric)
> By doing this someone could create a graph on the numRecordsOut for an entire 
> task's metric with a single metric in Datadog rather than combining the 
> metric for every subtask_index using the tm_id metric (that could change if a 
> tm_id dropped out of the cluster.) Additionally, given the current set of 
> tags being output to Datadog there is a ton of grouping and filtering that 
> will be available if everything was on a simplified metric.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7101) Fix Non-windowed group-aggregate error when using `minIdleStateRetentionTime` config and retract agg

2017-07-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088576#comment-16088576
 ] 

ASF GitHub Bot commented on FLINK-7101:
---

GitHub user sunjincheng121 opened a pull request:

https://github.com/apache/flink/pull/4348

[FLINK-7101][table] add condition of !stateCleaningEnabled is avoided…

- [x] General
  - The pull request references the related JIRA issue ("
[FLINK-7101][table] add condition of !stateCleaningEnabled is avoided 
non-grouped window state to be cleaned up too early")
  - The pull request addresses only one issue
  - Each commit in the PR has a meaningful commit message (including the 
JIRA id)

- [ ] Documentation
  - Documentation has been added for new functionality
  - Old documentation affected by the pull request has been updated
  - JavaDoc for public methods has been added

- [ ] Tests & Build
  - Functionality added by the pull request is covered by tests
  - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sunjincheng121/flink FLINK-7101-PR

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4348


commit 1c006299c8b8a169e346ef776cf9c5f5d7af20e0
Author: sunjincheng121 
Date:   2017-07-15T11:43:30Z

[FLINK-7101][table] add condition of !stateCleaningEnabled is avoided 
non-grouped window state to be cleaned up too early




> Fix Non-windowed group-aggregate error when using `minIdleStateRetentionTime` 
> config and retract agg
> 
>
> Key: FLINK-7101
> URL: https://issues.apache.org/jira/browse/FLINK-7101
> Project: Flink
>  Issue Type: Bug
>  Components: Table API & SQL
>Affects Versions: 1.3.0, 1.3.1
>Reporter: sunjincheng
>Assignee: sunjincheng
> Fix For: 1.4.0
>
> Attachments: screenshot-1.png
>
>
> When Non-windowed group-aggregate using {{minIdleStateRetentionTime}} config 
> and retract AGG, Will emit "NULL" agg value which we do not expect. 
> For example: ({{IntSumWithRetractAggFunction}})
> 1. Receive: CRow(Row.of(6L: JLong, 5: JInt, "aaa"), true) 
> 2. Cleanup state
> 3. Receive: CRow(Row.of(6L: JLong, 5: JInt, "aaa"), false)  // acc.f1 = -1, 
> getValue= null 
> So, we must change the logic of {{GroupAggProcessFunction}} as follows:
> {code}
> if (inputCnt != 0) {
>  ...
> } else {
>  ...
> }
> {code}
> TO
> {code}
> if (inputCnt > 0) {
>  ...
> } else {
> if( null != prevRow.row){
>  ...
>  }
> }
> {code}
> In this case, the result will bigger than expected, but i think it's make 
> sense, because user want cleanup state.(they should know the impact)
> What do you think? [~fhueske] [~hequn8128]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] flink pull request #4348: [FLINK-7101][table] add condition of !stateCleanin...

2017-07-15 Thread sunjincheng121 
GitHub user sunjincheng121 opened a pull request:

https://github.com/apache/flink/pull/4348

[FLINK-7101][table] add condition of !stateCleaningEnabled is avoided…

- [x] General
  - The pull request references the related JIRA issue ("
[FLINK-7101][table] add condition of !stateCleaningEnabled is avoided 
non-grouped window state to be cleaned up too early")
  - The pull request addresses only one issue
  - Each commit in the PR has a meaningful commit message (including the 
JIRA id)

- [ ] Documentation
  - Documentation has been added for new functionality
  - Old documentation affected by the pull request has been updated
  - JavaDoc for public methods has been added

- [ ] Tests & Build
  - Functionality added by the pull request is covered by tests
  - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sunjincheng121/flink FLINK-7101-PR

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4348


commit 1c006299c8b8a169e346ef776cf9c5f5d7af20e0
Author: sunjincheng121 
Date:   2017-07-15T11:43:30Z

[FLINK-7101][table] add condition of !stateCleaningEnabled is avoided 
non-grouped window state to be cleaned up too early




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (FLINK-5005) Publish Scala 2.12 artifacts

2017-07-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088559#comment-16088559
 ] 

ASF GitHub Bot commented on FLINK-5005:
---

Github user ariskk commented on the issue:

https://github.com/apache/flink/pull/3703
  
We are really looking forward to this  


> Publish Scala 2.12 artifacts
> 
>
> Key: FLINK-5005
> URL: https://issues.apache.org/jira/browse/FLINK-5005
> Project: Flink
>  Issue Type: Improvement
>  Components: Scala API
>Reporter: Andrew Roberts
>
> Scala 2.12 was [released|http://www.scala-lang.org/news/2.12.0] today, and 
> offers many compile-time and runtime speed improvements. It would be great to 
> get artifacts up on maven central to allow Flink users to migrate to Scala 
> 2.12.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] flink issue #3703: [FLINK-5005] WIP: publish scala 2.12 artifacts

2017-07-15 Thread ariskk 
Github user ariskk commented on the issue:

https://github.com/apache/flink/pull/3703
  
We are really looking forward to this 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (FLINK-7202) Split supressions for flink-core, flink-java, flink-optimizer per package

2017-07-15 Thread Dawid Wysakowicz (JIRA) 
Dawid Wysakowicz created FLINK-7202:
---

 Summary: Split supressions for flink-core, flink-java, 
flink-optimizer per package
 Key: FLINK-7202
 URL: https://issues.apache.org/jira/browse/FLINK-7202
 Project: Flink
  Issue Type: Sub-task
Reporter: Dawid Wysakowicz
Assignee: Dawid Wysakowicz






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7185) Activate checkstyle flink-java/io

2017-07-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088527#comment-16088527
 ] 

ASF GitHub Bot commented on FLINK-7185:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4340#discussion_r127580379
  
--- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java ---
@@ -23,9 +23,32 @@
 import org.apache.flink.api.java.ExecutionEnvironment;
 import org.apache.flink.api.java.Utils;
 import org.apache.flink.api.java.operators.DataSource;
-//CHECKSTYLE.OFF: AvoidStarImport - Needed for TupleGenerator
-import org.apache.flink.api.java.tuple.*;
-//CHECKSTYLE.ON: AvoidStarImport
+import org.apache.flink.api.java.tuple.Tuple;
+import org.apache.flink.api.java.tuple.Tuple1;
+import org.apache.flink.api.java.tuple.Tuple10;
+import org.apache.flink.api.java.tuple.Tuple11;
+import org.apache.flink.api.java.tuple.Tuple12;
+import org.apache.flink.api.java.tuple.Tuple13;
+import org.apache.flink.api.java.tuple.Tuple14;
+import org.apache.flink.api.java.tuple.Tuple15;
+import org.apache.flink.api.java.tuple.Tuple16;
+import org.apache.flink.api.java.tuple.Tuple17;
+import org.apache.flink.api.java.tuple.Tuple18;
+import org.apache.flink.api.java.tuple.Tuple19;
--- End diff --

Oh, ok. I didn't notice, it was because of code generation previously. How 
do we want to proceed with it then? Do we want to add suppression for it? Just 
adding the `//CHECKSTYLE: OFF` won't work as it violates the `ImportOrder` rule.


> Activate checkstyle flink-java/io
> -
>
> Key: FLINK-7185
> URL: https://issues.apache.org/jira/browse/FLINK-7185
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Dawid Wysakowicz
>Assignee: Dawid Wysakowicz
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io

2017-07-15 Thread dawidwys 
Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4340#discussion_r127580379
  
--- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java ---
@@ -23,9 +23,32 @@
 import org.apache.flink.api.java.ExecutionEnvironment;
 import org.apache.flink.api.java.Utils;
 import org.apache.flink.api.java.operators.DataSource;
-//CHECKSTYLE.OFF: AvoidStarImport - Needed for TupleGenerator
-import org.apache.flink.api.java.tuple.*;
-//CHECKSTYLE.ON: AvoidStarImport
+import org.apache.flink.api.java.tuple.Tuple;
+import org.apache.flink.api.java.tuple.Tuple1;
+import org.apache.flink.api.java.tuple.Tuple10;
+import org.apache.flink.api.java.tuple.Tuple11;
+import org.apache.flink.api.java.tuple.Tuple12;
+import org.apache.flink.api.java.tuple.Tuple13;
+import org.apache.flink.api.java.tuple.Tuple14;
+import org.apache.flink.api.java.tuple.Tuple15;
+import org.apache.flink.api.java.tuple.Tuple16;
+import org.apache.flink.api.java.tuple.Tuple17;
+import org.apache.flink.api.java.tuple.Tuple18;
+import org.apache.flink.api.java.tuple.Tuple19;
--- End diff --

Oh, ok. I didn't notice, it was because of code generation previously. How 
do we want to proceed with it then? Do we want to add suppression for it? Just 
adding the `//CHECKSTYLE: OFF` won't work as it violates the `ImportOrder` rule.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (FLINK-7190) Activate checkstyle flink-java/*

2017-07-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088517#comment-16088517
 ] 

ASF GitHub Bot commented on FLINK-7190:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4343#discussion_r127579802
  
--- Diff: tools/maven/suppressions-java.xml ---
@@ -24,6 +24,9 @@ under the License.
 
 

+   files="ExecutionEnvironment\.java"
+   checks="JavadocParagraph"/>
+Activate checkstyle flink-java/*
> 
>
> Key: FLINK-7190
> URL: https://issues.apache.org/jira/browse/FLINK-7190
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Dawid Wysakowicz
>Assignee: Dawid Wysakowicz
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] flink pull request #4343: [FLINK-7190] Activate checkstyle flink-java/*

2017-07-15 Thread dawidwys 
Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/4343#discussion_r127579802
  
--- Diff: tools/maven/suppressions-java.xml ---
@@ -24,6 +24,9 @@ under the License.
 
 

+   files="ExecutionEnvironment\.java"
+   checks="JavadocParagraph"/>
+

[GitHub] flink pull request #4294: [FLINK-7127] [runtime] Remove unnecessary null che...

2017-07-15 Thread mylog00 
Github user mylog00 closed the pull request at:

https://github.com/apache/flink/pull/4294


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (FLINK-7127) Remove unnecessary null check or add null check

2017-07-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088499#comment-16088499
 ] 

ASF GitHub Bot commented on FLINK-7127:
---

Github user mylog00 closed the pull request at:

https://github.com/apache/flink/pull/4294


> Remove unnecessary null check or add null check
> ---
>
> Key: FLINK-7127
> URL: https://issues.apache.org/jira/browse/FLINK-7127
> Project: Flink
>  Issue Type: Improvement
>  Components: State Backends, Checkpointing
>Reporter: Ufuk Celebi
>Priority: Trivial
>  Labels: starter
>
> In {{HeapKeyedStateBackend#snapshot}} we have:
> {code}
> for (Map.Entry> kvState : stateTables.entrySet()) 
> {
>   // 1) Here we don't check for null
>   metaInfoSnapshots.add(kvState.getValue().getMetaInfo().snapshot());
>   kVStateToId.put(kvState.getKey(), kVStateToId.size());
>   // 2) Here we check for null
>   StateTable stateTable = kvState.getValue();
>   if (null != stateTable) {
>   cowStateStableSnapshots.put(stateTable, 
> stateTable.createSnapshot());
>   }
> }
> {code}
> Either this can lead to a NPE and we should check it in 1) or we remove the 
> null check in 2). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)