[jira] [Commented] (FLINK-11654) Multiple transactional KafkaProducers writing to same cluster have clashing transaction IDs

2019-07-12 Thread Jiangjie Qin (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-11654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884267#comment-16884267
 ] 

Jiangjie Qin commented on FLINK-11654:
--

[~knaufk] That makes sense. In fact the {{transactional.id}} config is already 
supported by Kafka producers, we can simply use add that to the current prefix. 
This config can be set via {{producerProperties}} config. There are still 1 or 
2 constructors of the {{FlinkKafkaProducer}} that do not take 
{{producerProperties}}. We can keep the behavior as is in that case.

If we do that, the behavior would be:
 # When user did not provide \{{producerProperties}} or did not specify 
\{{transactional.id}} in the \{{producerProperties}}, the behavior will be the 
same as current behavior.
 # When user provided a {{transactional.id}} in the {{producerProperties}}, 
that \{{transactional.id}} will be part of the prefix. If the user provided 
{{transactional.id}} config is unique, the eventually used transactional.id 
will also be unique.

I think this is a good approach. It is fully backwards compatible and do not 
introduce any new API.

> Multiple transactional KafkaProducers writing to same cluster have clashing 
> transaction IDs
> ---
>
> Key: FLINK-11654
> URL: https://issues.apache.org/jira/browse/FLINK-11654
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.7.1
>Reporter: Jürgen Kreileder
>Priority: Major
> Fix For: 1.9.0
>
>
> We run multiple jobs on a cluster which write a lot to the same Kafka topic 
> from identically named sinks. When EXACTLY_ONCE semantic is enabled for the 
> KafkaProducers we run into a lot of ProducerFencedExceptions and all jobs go 
> into a restart cycle.
> Example exception from the Kafka log:
>  
> {code:java}
> [2019-02-18 18:05:28,485] ERROR [ReplicaManager broker=1] Error processing 
> append operation on partition finding-commands-dev-1-0 
> (kafka.server.ReplicaManager)
> org.apache.kafka.common.errors.ProducerFencedException: Producer's epoch is 
> no longer valid. There is probably another producer with a newer epoch. 483 
> (request epoch), 484 (server epoch)
> {code}
> The reason for this is the way FlinkKafkaProducer initializes the 
> TransactionalIdsGenerator:
> The IDs are only guaranteed to be unique for a single Job. But they can clash 
> between different Jobs (and Clusters).
>  
>  
> {code:java}
> --- 
> a/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
> +++ 
> b/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
> @@ -819,6 +819,7 @@ public class FlinkKafkaProducer
>                 nextTransactionalIdHintState = 
> context.getOperatorStateStore().getUnionListState(
>                         NEXT_TRANSACTIONAL_ID_HINT_DESCRIPTOR);
>                 transactionalIdsGenerator = new TransactionalIdsGenerator(
> + // the prefix probably should include job id and maybe cluster id
>                         getRuntimeContext().getTaskName() + "-" + 
> ((StreamingRuntimeContext) getRuntimeContext()).getOperatorUniqueID(),
>                         getRuntimeContext().getIndexOfThisSubtask(),
>                         
> getRuntimeContext().getNumberOfParallelSubtasks(),{code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Comment Edited] (FLINK-11654) Multiple transactional KafkaProducers writing to same cluster have clashing transaction IDs

2019-07-12 Thread Jiangjie Qin (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-11654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884267#comment-16884267
 ] 

Jiangjie Qin edited comment on FLINK-11654 at 7/13/19 2:04 AM:
---

[~knaufk] That makes sense. In fact the {{transactional.id}} config is already 
supported by Kafka producers, we can simply use add that to the current prefix. 
This config can be set via {{producerProperties}} config. There are still 1 or 
2 constructors of the {{FlinkKafkaProducer}} that do not take 
{{producerProperties}}. We can keep the behavior as is in that case.

If we do that, the behavior would be:
 # When user did not provide {{producerProperties}} or did not specify 
{{transactional.id}} in the {{producerProperties}}, the behavior will be the 
same as current behavior.
 # When user provided a {{transactional.id}} in the {{producerProperties}}, 
that {{transactional.id}} will be part of the prefix. If the user provided 
{{transactional.id}} config is unique, the eventually used transactional.id 
will also be unique.

I think this is a good approach. It is fully backwards compatible and does not 
introduce any new API.


was (Author: becket_qin):
[~knaufk] That makes sense. In fact the {{transactional.id}} config is already 
supported by Kafka producers, we can simply use add that to the current prefix. 
This config can be set via {{producerProperties}} config. There are still 1 or 
2 constructors of the {{FlinkKafkaProducer}} that do not take 
{{producerProperties}}. We can keep the behavior as is in that case.

If we do that, the behavior would be:
 # When user did not provide \{{producerProperties}} or did not specify 
\{{transactional.id}} in the \{{producerProperties}}, the behavior will be the 
same as current behavior.
 # When user provided a {{transactional.id}} in the {{producerProperties}}, 
that \{{transactional.id}} will be part of the prefix. If the user provided 
{{transactional.id}} config is unique, the eventually used transactional.id 
will also be unique.

I think this is a good approach. It is fully backwards compatible and do not 
introduce any new API.

> Multiple transactional KafkaProducers writing to same cluster have clashing 
> transaction IDs
> ---
>
> Key: FLINK-11654
> URL: https://issues.apache.org/jira/browse/FLINK-11654
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.7.1
>Reporter: Jürgen Kreileder
>Priority: Major
> Fix For: 1.9.0
>
>
> We run multiple jobs on a cluster which write a lot to the same Kafka topic 
> from identically named sinks. When EXACTLY_ONCE semantic is enabled for the 
> KafkaProducers we run into a lot of ProducerFencedExceptions and all jobs go 
> into a restart cycle.
> Example exception from the Kafka log:
>  
> {code:java}
> [2019-02-18 18:05:28,485] ERROR [ReplicaManager broker=1] Error processing 
> append operation on partition finding-commands-dev-1-0 
> (kafka.server.ReplicaManager)
> org.apache.kafka.common.errors.ProducerFencedException: Producer's epoch is 
> no longer valid. There is probably another producer with a newer epoch. 483 
> (request epoch), 484 (server epoch)
> {code}
> The reason for this is the way FlinkKafkaProducer initializes the 
> TransactionalIdsGenerator:
> The IDs are only guaranteed to be unique for a single Job. But they can clash 
> between different Jobs (and Clusters).
>  
>  
> {code:java}
> --- 
> a/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
> +++ 
> b/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
> @@ -819,6 +819,7 @@ public class FlinkKafkaProducer
>                 nextTransactionalIdHintState = 
> context.getOperatorStateStore().getUnionListState(
>                         NEXT_TRANSACTIONAL_ID_HINT_DESCRIPTOR);
>                 transactionalIdsGenerator = new TransactionalIdsGenerator(
> + // the prefix probably should include job id and maybe cluster id
>                         getRuntimeContext().getTaskName() + "-" + 
> ((StreamingRuntimeContext) getRuntimeContext()).getOperatorUniqueID(),
>                         getRuntimeContext().getIndexOfThisSubtask(),
>                         
> getRuntimeContext().getNumberOfParallelSubtasks(),{code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FLINK-13241) YarnResourceManager does not handle slot allocations in certain cases

2019-07-12 Thread Xintong Song (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884257#comment-16884257
 ] 

Xintong Song commented on FLINK-13241:
--

Turns out it's not a bytes/megabytes converting issue.

We explicitly set the exact managed memory size into configuration on RM side, 
to avoid TM calculating managed memory from fraction and uncertain JVM free 
memory. However, we were setting the wrong configuration instance. In 
YarnResourceManager constructor, we copied the configuration instance because 
we are going to alter it. But we altered the original configuration instead of 
the copied one which is used by TM.

I've opened a PR to fix it, and same problem for Mesos.

> YarnResourceManager does not handle slot allocations in certain cases
> -
>
> Key: FLINK-13241
> URL: https://issues.apache.org/jira/browse/FLINK-13241
> Project: Flink
>  Issue Type: Bug
>  Components: Deployment / YARN
>Affects Versions: 1.9.0
>Reporter: Zhu Zhu
>Assignee: Xintong Song
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 1.9.0
>
> Attachments: 17_37_05__07_12_2019.jpg
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the case that a job allocates a few slots first and after a period 
> allocates some other slots. The YarnResourceManager seems to receive and 
> ignore the latter slot requests.
> To produce this issue, we can create a job with 2 vertices in different 
> shared groups, as shown below:
> !17_37_05__07_12_2019.jpg|width=433,height=127!
> Slot allocation for map2 vertex happens after the source vertex acquires 
> slots to decide its location, thus to meet the input constraints.
> YarnResourceManager can receive slot requests for map2, but seems not to 
> handle it and the job will hang there waiting for resources.
> In my observation, this issue does not happen on Flink(Version: 1.9-SNAPSHOT, 
> Rev:3bc322a, Date:26.06.2019 @ 17:28:51 CST). It should be a new issue after 
> that.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [flink] xintongsong commented on issue #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.

2019-07-12 Thread GitBox
xintongsong commented on issue #9105: [FLINK-13241][Yarn/Mesos] Fix 
Yarn/MesosResourceManager setting managed memory size into wrong configuration 
instance.
URL: https://github.com/apache/flink/pull/9105#issuecomment-511072921
 
 
   Hi @tillrohrmann, this is a bug fix for Flink-13241. Please take a look at 
your convenience.
   
   I think this fix needs to go into both master and release-1.9. Typically 
what should I do in such cases? Should I open 2 separate PRs based on 
master/release-1.9 respectively, or just one PR and mention that in 
description/comment?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot commented on issue #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.

2019-07-12 Thread GitBox
flinkbot commented on issue #9105: [FLINK-13241][Yarn/Mesos] Fix 
Yarn/MesosResourceManager setting managed memory size into wrong configuration 
instance.
URL: https://github.com/apache/flink/pull/9105#issuecomment-511072529
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (FLINK-13241) YarnResourceManager does not handle slot allocations in certain cases

2019-07-12 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-13241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-13241:
---
Labels: pull-request-available  (was: )

> YarnResourceManager does not handle slot allocations in certain cases
> -
>
> Key: FLINK-13241
> URL: https://issues.apache.org/jira/browse/FLINK-13241
> Project: Flink
>  Issue Type: Bug
>  Components: Deployment / YARN
>Affects Versions: 1.9.0
>Reporter: Zhu Zhu
>Assignee: Xintong Song
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 1.9.0
>
> Attachments: 17_37_05__07_12_2019.jpg
>
>
> In the case that a job allocates a few slots first and after a period 
> allocates some other slots. The YarnResourceManager seems to receive and 
> ignore the latter slot requests.
> To produce this issue, we can create a job with 2 vertices in different 
> shared groups, as shown below:
> !17_37_05__07_12_2019.jpg|width=433,height=127!
> Slot allocation for map2 vertex happens after the source vertex acquires 
> slots to decide its location, thus to meet the input constraints.
> YarnResourceManager can receive slot requests for map2, but seems not to 
> handle it and the job will hang there waiting for resources.
> In my observation, this issue does not happen on Flink(Version: 1.9-SNAPSHOT, 
> Rev:3bc322a, Date:26.06.2019 @ 17:28:51 CST). It should be a new issue after 
> that.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [flink] xintongsong opened a new pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.

2019-07-12 Thread GitBox
xintongsong opened a new pull request #9105: [FLINK-13241][Yarn/Mesos] Fix 
Yarn/MesosResourceManager setting managed memory size into wrong configuration 
instance.
URL: https://github.com/apache/flink/pull/9105
 
 
   ## What is the purpose of the change
   
   This PR fix the bug that Yarn/MesosResourceManager set managed memory size 
into wrong configuration instance. As a result, such setting does not overwrite 
the config on TM side, causing RM/TM slot resource profile inconsistency. As a 
result, pending task manager slots on RM side cannot be completed once created, 
prevent RM from starting new TMs for subsequence slot requests.
   
   ## Brief change log
   
   - Yarn/MesosResourceManager set managed memory into the proper configuration 
instance.
   
   ## Verifying this change
   
 - Manually verified the change by running a streaming job with two 
vertices using lazy from source strategy on Yarn. The job requests slots in 2 
rounds and we verified that RM does start new TM for the second round slot 
requests, which it doesn't without this change.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
 - The serializers: (no)
 - The runtime per-record code paths (performance sensitive): (no)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
 - The S3 file system connector: (no)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (no)
 - If yes, how is the feature documented? (not applicable)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Assigned] (FLINK-13241) YarnResourceManager does not handle slot allocations in certain cases

2019-07-12 Thread Xintong Song (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-13241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xintong Song reassigned FLINK-13241:


Assignee: Xintong Song

> YarnResourceManager does not handle slot allocations in certain cases
> -
>
> Key: FLINK-13241
> URL: https://issues.apache.org/jira/browse/FLINK-13241
> Project: Flink
>  Issue Type: Bug
>  Components: Deployment / YARN
>Affects Versions: 1.9.0
>Reporter: Zhu Zhu
>Assignee: Xintong Song
>Priority: Blocker
> Fix For: 1.9.0
>
> Attachments: 17_37_05__07_12_2019.jpg
>
>
> In the case that a job allocates a few slots first and after a period 
> allocates some other slots. The YarnResourceManager seems to receive and 
> ignore the latter slot requests.
> To produce this issue, we can create a job with 2 vertices in different 
> shared groups, as shown below:
> !17_37_05__07_12_2019.jpg|width=433,height=127!
> Slot allocation for map2 vertex happens after the source vertex acquires 
> slots to decide its location, thus to meet the input constraints.
> YarnResourceManager can receive slot requests for map2, but seems not to 
> handle it and the job will hang there waiting for resources.
> In my observation, this issue does not happen on Flink(Version: 1.9-SNAPSHOT, 
> Rev:3bc322a, Date:26.06.2019 @ 17:28:51 CST). It should be a new issue after 
> that.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [flink] flinkbot commented on issue #8976: [FLINK-12277][table/hive/doc] Add documentation for catalogs

2019-07-12 Thread GitBox
flinkbot commented on issue #8976: [FLINK-12277][table/hive/doc] Add 
documentation for catalogs
URL: https://github.com/apache/flink/pull/8976#issuecomment-511060754
 
 
   ## CI report:
   
   * a6494267595de4d1c63430ec20083b909e50cf9c : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119004902)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9067: [FLINK-13069][hive] HiveTableSink should implement OverwritableTableSink

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9067: [FLINK-13069][hive] HiveTableSink 
should implement OverwritableTableSink
URL: https://github.com/apache/flink/pull/9067#issuecomment-510405753
 
 
   ## CI report:
   
   * 0034a70157b871b401cb1f8cd5a223427cf6223a : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118885081)
   * 1f192d01c764dbff8ab884512814cc1a4fd80dba : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001084)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #7487: [FLINK-11321] Clarify NPE on fetching nonexistent topic

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #7487: [FLINK-11321] Clarify NPE on fetching 
nonexistent topic
URL: https://github.com/apache/flink/pull/7487#issuecomment-510739413
 
 
   ## CI report:
   
   * c746405bfc3264fec2e9a5a6551360e37aa5688f : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118879011)
   * be567080699e278af084886da36fb8369fa3fc13 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001185)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9088: [FLINK-13012][hive] Handle default partition name of Hive table

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9088: [FLINK-13012][hive] Handle default 
partition name of Hive table
URL: https://github.com/apache/flink/pull/9088#issuecomment-510484364
 
 
   ## CI report:
   
   * eac5f74690ddb0b08cb41b029f5b8ac675e63565 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118891245)
   * b22f836f5e8f95a9f376f54c68798eeb14cb1644 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001057)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8742: [FLINK-11879] Add validators for the uses of InputSelectable, BoundedOneInput and BoundedMultiInput

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8742: [FLINK-11879] Add validators for the 
uses of InputSelectable, BoundedOneInput and BoundedMultiInput
URL: https://github.com/apache/flink/pull/8742#issuecomment-510731561
 
 
   ## CI report:
   
   * 3f0c15862fc70f35cd58883ca9635bde1a5fb7ee : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118876288)
   * e9adf752da210ededdcebbd1ba3753c3b689cf3e : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001175)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9094: [FLINK-13094][state-processor-api] Provide an easy way to read timers using the State Processor API

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9094: [FLINK-13094][state-processor-api] 
Provide an easy way to read timers using the State Processor API
URL: https://github.com/apache/flink/pull/9094#issuecomment-510560219
 
 
   ## CI report:
   
   * 68c63247fc6c3b60b0cf7afb483cc04ee8f558d0 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118811503)
   * 90313e480878fce12d292065691baee026795e70 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001032)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - 
Table API Example Walkthrough
URL: https://github.com/apache/flink/pull/8903#issuecomment-510464651
 
 
   ## CI report:
   
   * b2821a6ae97fd943f3a66b672e85fbd2374126c4 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118909729)
   * 0699f7e5f2240a4a1bc44c15f08e6a1df47d3b01 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001161)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9089: [FLINK-13225][table-planner-blink] Introduce type inference for hive functions in blink

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9089: [FLINK-13225][table-planner-blink] 
Introduce type inference for hive functions in blink
URL: https://github.com/apache/flink/pull/9089#issuecomment-510488226
 
 
   ## CI report:
   
   * fb34a0f4245ddac5872ea77aad07887a6ff12d11 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118890132)
   * ba44069acdbd82261839605b5d363548dae81522 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001049)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9103: [FLINK-13243][tests] Simplify exception matching

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9103: [FLINK-13243][tests] Simplify 
exception matching
URL: https://github.com/apache/flink/pull/9103#issuecomment-510833512
 
 
   ## CI report:
   
   * f0e07043aa8531a5b88be21bda5bff075aedd4a7 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118911167)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9023: [FLINK-13154][docs] Fix broken links of web docs

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9023: [FLINK-13154][docs] Fix broken links 
of web docs
URL: https://github.com/apache/flink/pull/9023#issuecomment-510760232
 
 
   ## CI report:
   
   * e46e8fe47051e393cb99fd5e08a821ab72d334bf : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118884406)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] bowenli86 commented on a change in pull request #8976: [FLINK-12277][table/hive/doc] Add documentation for catalogs

2019-07-12 Thread GitBox
bowenli86 commented on a change in pull request #8976: 
[FLINK-12277][table/hive/doc] Add documentation for catalogs
URL: https://github.com/apache/flink/pull/8976#discussion_r303169470
 
 

 ##
 File path: docs/dev/table/catalog.md
 ##
 @@ -0,0 +1,367 @@
+---
+title: "Catalog"
+is_beta: true
+nav-parent_id: tableapi
+nav-pos: 100
+---
+
+
+Catalogs provide metadata, such as names, schemas, statistics of tables, and 
information about how to access data stored in a database or other external 
systems. Once a catalog is registered within a `TableEnvironment`, all its 
meta-objects are accessible from the Table API and SQL queries.
+
+
+* This will be replaced by the TOC
+{:toc}
+
+
+Catalog Interface
+-
+
+APIs are defined in `Catalog` interface. The interface defines a set of APIs 
to read and write catalog meta-objects such as database, tables, partitions, 
views, and functions.
+
+
+Catalog Meta-Objects Naming Structure
+-
+
+Flink's catalogs use a strict two-level structure, that is, catalogs contain 
databases, and databases contain meta-objects. Thus, the full name of a 
meta-object is always structured as `catalogName`.`databaseName`.`objectName`.
+
+Each `TableEnvironment` has a `CatalogManager` to manager all registered 
catalogs. To ease access to meta-objects, `CatalogManager` has a concept of 
current catalog and current database. By setting current catalog and current 
database, users can use just the meta-object's name in their queries. This 
greatly simplifies user experience.
+
+For example, a previous query as
+
+```sql
+select * from mycatalog.mydb.myTable;
+```
+
+can be shortened to
+
+```sql
+select * from myTable;
+```
+
+To querying tables in a different database under the current catalog, users 
don't need to specify the catalog name. In our example, it would be
+
+```
+select * from mydb2.myTable2
+```
+
+`CatalogManager` always has a built-in `GenericInMemoryCatalog` named 
`default_catalog`, which has a built-in default database named 
`default_database`. If no other catalog and database are explicitly set, they 
will be the current catalog and current database by default. All temp 
meta-objects, such as those defined by `TableEnvironment#registerTable`  are 
registered to this catalog. 
+
+Users can set current catalog and database via 
`TableEnvironment.useCatalog(...)` and `TableEnvironment.useDatabase(...)` in 
Table API, or `USE CATALOG ...` and `USE DATABASE ...` in Flink SQL.
+
+
+Catalog Types
+-
+
+## GenericInMemoryCatalog
+
+The default catalog; all meta-objects in this catalog are stored in memory, 
and be will be lost once the session shuts down.
+
+Its config entry value in SQL CLI yaml file is "generic_in_memory".
+
+## HiveCatalog
+
+Flink's `HiveCatalog` can read and write both Flink and Hive meta-objects 
using Hive Metastore as persistent storage.
+
+Its config entry value in SQL CLI yaml file is "hive".
+
+### Persist Flink meta-objects
+
+Historically, Flink meta-objects are only stored in memory and are per session 
based. That means users have to recreate all the meta-objects every time they 
start a new session.
+
+To maintain meta-objects across sessions, users can choose to use 
`HiveCatalog` to persist all of users' Flink streaming (unbounded-stream) and 
batch (bounded-stream) meta-objects. Because Hive Metastore is only used for 
storage, Hive itself may not understand Flink's meta-objects stored in the 
metastore.
+
+### Integrate Flink with Hive metadata
+
+The ultimate goal for integrating Flink with Hive metadata is that:
+
+1. Existing meta-objects, like tables, views, and functions, created by Hive 
or other Hive-compatible applications can be used by Flink
+
+2. Meta-objects created by `HiveCatalog` can be written back to Hive metastore 
such that Hive and other Hive-compatible applications can consume.
+
+## User-configured Catalog
+
+Catalogs are pluggable. Users can develop custom catalogs by implementing the 
`Catalog` interface, which defines a set of APIs for reading and writing 
catalog meta-objects such as database, tables, partitions, views, and functions.
+
+
+HiveCatalog
+---
+
+## Supported Hive Versions
+
+Flink's `HiveCatalog` officially supports Hive 2.3.4 and 1.2.1.
+
+The Hive version is explicitly specified as a String, either by passing it to 
the constructor when creating `HiveCatalog` instances directly in Table API or 
specifying it in yaml config file in SQL CLI. The Hive version string are 
`2.3.4` and `1.2.1`.
+
+## Case Insensitive to Meta-Object Names
+
+Note that Hive Metastore stores meta-object names in lower cases. Thus, unlike 
`GenericInMemoryCatalog`, `HiveCatalog` is case-insensitive to meta-object 
names, and users need to be cautious on that.
+
+## Dependencies
+
+To use `HiveCatalog`, users need to include the following dependency jars.
+
+For Hive 2.3.4, users need:
+
+```
+// Hive dependencies
+
+- hive-exec-2.3.4.jar 

[GitHub] [flink] flinkbot edited a comment on issue #9084: [FLINK-13213][table-api] Keep MinIdleStateRetentionTime/MaxIdleStateRetentionTime in TableConfig after call toAppendStream/toRetractStream wi

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9084: [FLINK-13213][table-api] Keep 
MinIdleStateRetentionTime/MaxIdleStateRetentionTime in TableConfig after call 
toAppendStream/toRetractStream without QueryConfig parameters
URL: https://github.com/apache/flink/pull/9084#issuecomment-510437882
 
 
   ## CI report:
   
   * 779dc96005e2bf894f50df9989ee0c43dad0c511 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118847196)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9021: [FLINK-13205][runtime] Make checkpoints injection ordered with stop-with-savepoint

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9021: [FLINK-13205][runtime] Make 
checkpoints injection ordered with stop-with-savepoint
URL: https://github.com/apache/flink/pull/9021#issuecomment-510405873
 
 
   ## CI report:
   
   * abed4b5678a2f09b3bb729bd62b5264e56b55b9f : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118731856)
   * 505ec154b21e0340e112f16fcfcfb1eeb52fa345 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118883736)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9082: [FLINK-13207][ml] Add the algorithm of Fast Fourier Transformation(FFT)

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9082: [FLINK-13207][ml] Add the algorithm 
of Fast Fourier Transformation(FFT)
URL: https://github.com/apache/flink/pull/9082#issuecomment-510415691
 
 
   ## CI report:
   
   * 2b6f431f4f281936034418c8ce64e2e1ba10bd5f : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118885069)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] bowenli86 commented on a change in pull request #8976: [FLINK-12277][table/hive/doc] Add documentation for catalogs

2019-07-12 Thread GitBox
bowenli86 commented on a change in pull request #8976: 
[FLINK-12277][table/hive/doc] Add documentation for catalogs
URL: https://github.com/apache/flink/pull/8976#discussion_r303169470
 
 

 ##
 File path: docs/dev/table/catalog.md
 ##
 @@ -0,0 +1,367 @@
+---
+title: "Catalog"
+is_beta: true
+nav-parent_id: tableapi
+nav-pos: 100
+---
+
+
+Catalogs provide metadata, such as names, schemas, statistics of tables, and 
information about how to access data stored in a database or other external 
systems. Once a catalog is registered within a `TableEnvironment`, all its 
meta-objects are accessible from the Table API and SQL queries.
+
+
+* This will be replaced by the TOC
+{:toc}
+
+
+Catalog Interface
+-
+
+APIs are defined in `Catalog` interface. The interface defines a set of APIs 
to read and write catalog meta-objects such as database, tables, partitions, 
views, and functions.
+
+
+Catalog Meta-Objects Naming Structure
+-
+
+Flink's catalogs use a strict two-level structure, that is, catalogs contain 
databases, and databases contain meta-objects. Thus, the full name of a 
meta-object is always structured as `catalogName`.`databaseName`.`objectName`.
+
+Each `TableEnvironment` has a `CatalogManager` to manager all registered 
catalogs. To ease access to meta-objects, `CatalogManager` has a concept of 
current catalog and current database. By setting current catalog and current 
database, users can use just the meta-object's name in their queries. This 
greatly simplifies user experience.
+
+For example, a previous query as
+
+```sql
+select * from mycatalog.mydb.myTable;
+```
+
+can be shortened to
+
+```sql
+select * from myTable;
+```
+
+To querying tables in a different database under the current catalog, users 
don't need to specify the catalog name. In our example, it would be
+
+```
+select * from mydb2.myTable2
+```
+
+`CatalogManager` always has a built-in `GenericInMemoryCatalog` named 
`default_catalog`, which has a built-in default database named 
`default_database`. If no other catalog and database are explicitly set, they 
will be the current catalog and current database by default. All temp 
meta-objects, such as those defined by `TableEnvironment#registerTable`  are 
registered to this catalog. 
+
+Users can set current catalog and database via 
`TableEnvironment.useCatalog(...)` and `TableEnvironment.useDatabase(...)` in 
Table API, or `USE CATALOG ...` and `USE DATABASE ...` in Flink SQL.
+
+
+Catalog Types
+-
+
+## GenericInMemoryCatalog
+
+The default catalog; all meta-objects in this catalog are stored in memory, 
and be will be lost once the session shuts down.
+
+Its config entry value in SQL CLI yaml file is "generic_in_memory".
+
+## HiveCatalog
+
+Flink's `HiveCatalog` can read and write both Flink and Hive meta-objects 
using Hive Metastore as persistent storage.
+
+Its config entry value in SQL CLI yaml file is "hive".
+
+### Persist Flink meta-objects
+
+Historically, Flink meta-objects are only stored in memory and are per session 
based. That means users have to recreate all the meta-objects every time they 
start a new session.
+
+To maintain meta-objects across sessions, users can choose to use 
`HiveCatalog` to persist all of users' Flink streaming (unbounded-stream) and 
batch (bounded-stream) meta-objects. Because Hive Metastore is only used for 
storage, Hive itself may not understand Flink's meta-objects stored in the 
metastore.
+
+### Integrate Flink with Hive metadata
+
+The ultimate goal for integrating Flink with Hive metadata is that:
+
+1. Existing meta-objects, like tables, views, and functions, created by Hive 
or other Hive-compatible applications can be used by Flink
+
+2. Meta-objects created by `HiveCatalog` can be written back to Hive metastore 
such that Hive and other Hive-compatible applications can consume.
+
+## User-configured Catalog
+
+Catalogs are pluggable. Users can develop custom catalogs by implementing the 
`Catalog` interface, which defines a set of APIs for reading and writing 
catalog meta-objects such as database, tables, partitions, views, and functions.
+
+
+HiveCatalog
+---
+
+## Supported Hive Versions
+
+Flink's `HiveCatalog` officially supports Hive 2.3.4 and 1.2.1.
+
+The Hive version is explicitly specified as a String, either by passing it to 
the constructor when creating `HiveCatalog` instances directly in Table API or 
specifying it in yaml config file in SQL CLI. The Hive version string are 
`2.3.4` and `1.2.1`.
+
+## Case Insensitive to Meta-Object Names
+
+Note that Hive Metastore stores meta-object names in lower cases. Thus, unlike 
`GenericInMemoryCatalog`, `HiveCatalog` is case-insensitive to meta-object 
names, and users need to be cautious on that.
+
+## Dependencies
+
+To use `HiveCatalog`, users need to include the following dependency jars.
+
+For Hive 2.3.4, users need:
+
+```
+// Hive dependencies
+
+- hive-exec-2.3.4.jar 

[GitHub] [flink] flinkbot edited a comment on issue #9077: [FLINK-13196][table] Fix Ambiguous column name exception bug for Table API

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9077: [FLINK-13196][table] Fix Ambiguous 
column name exception bug for Table API
URL: https://github.com/apache/flink/pull/9077#issuecomment-510405822
 
 
   ## CI report:
   
   * 11d60ab9683d4ba90a801af3996a7ab62644dba8 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118889199)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9078: [FLINK-13186] Remove dispatcherRetrievalService and dispatcherLeaderRetriever from RestClusterClient

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9078: [FLINK-13186] Remove 
dispatcherRetrievalService and dispatcherLeaderRetriever from RestClusterClient
URL: https://github.com/apache/flink/pull/9078#issuecomment-510405833
 
 
   ## CI report:
   
   * b73e7985607cee8e9a8abc5b8031e4ee149db514 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118877390)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] bowenli86 commented on a change in pull request #8976: [FLINK-12277][table/hive/doc] Add documentation for catalogs

2019-07-12 Thread GitBox
bowenli86 commented on a change in pull request #8976: 
[FLINK-12277][table/hive/doc] Add documentation for catalogs
URL: https://github.com/apache/flink/pull/8976#discussion_r303169116
 
 

 ##
 File path: docs/dev/table/catalog.md
 ##
 @@ -0,0 +1,367 @@
+---
+title: "Catalog"
+is_beta: true
+nav-parent_id: tableapi
+nav-pos: 100
+---
+
+
+Catalogs provide metadata, such as names, schemas, statistics of tables, and 
information about how to access data stored in a database or other external 
systems. Once a catalog is registered within a `TableEnvironment`, all its 
meta-objects are accessible from the Table API and SQL queries.
+
+
+* This will be replaced by the TOC
+{:toc}
+
+
+Catalog Interface
+-
+
+APIs are defined in `Catalog` interface. The interface defines a set of APIs 
to read and write catalog meta-objects such as database, tables, partitions, 
views, and functions.
+
+
+Catalog Meta-Objects Naming Structure
+-
+
+Flink's catalogs use a strict two-level structure, that is, catalogs contain 
databases, and databases contain meta-objects. Thus, the full name of a 
meta-object is always structured as `catalogName`.`databaseName`.`objectName`.
+
+Each `TableEnvironment` has a `CatalogManager` to manager all registered 
catalogs. To ease access to meta-objects, `CatalogManager` has a concept of 
current catalog and current database. By setting current catalog and current 
database, users can use just the meta-object's name in their queries. This 
greatly simplifies user experience.
+
+For example, a previous query as
+
+```sql
+select * from mycatalog.mydb.myTable;
+```
+
+can be shortened to
+
+```sql
+select * from myTable;
+```
+
+To querying tables in a different database under the current catalog, users 
don't need to specify the catalog name. In our example, it would be
+
+```
+select * from mydb2.myTable2
+```
+
+`CatalogManager` always has a built-in `GenericInMemoryCatalog` named 
`default_catalog`, which has a built-in default database named 
`default_database`. If no other catalog and database are explicitly set, they 
will be the current catalog and current database by default. All temp 
meta-objects, such as those defined by `TableEnvironment#registerTable`  are 
registered to this catalog. 
+
+Users can set current catalog and database via 
`TableEnvironment.useCatalog(...)` and `TableEnvironment.useDatabase(...)` in 
Table API, or `USE CATALOG ...` and `USE DATABASE ...` in Flink SQL.
+
+
+Catalog Types
+-
+
+## GenericInMemoryCatalog
+
+The default catalog; all meta-objects in this catalog are stored in memory, 
and be will be lost once the session shuts down.
+
+Its config entry value in SQL CLI yaml file is "generic_in_memory".
+
+## HiveCatalog
+
+Flink's `HiveCatalog` can read and write both Flink and Hive meta-objects 
using Hive Metastore as persistent storage.
+
+Its config entry value in SQL CLI yaml file is "hive".
+
+### Persist Flink meta-objects
+
+Historically, Flink meta-objects are only stored in memory and are per session 
based. That means users have to recreate all the meta-objects every time they 
start a new session.
+
+To maintain meta-objects across sessions, users can choose to use 
`HiveCatalog` to persist all of users' Flink streaming (unbounded-stream) and 
batch (bounded-stream) meta-objects. Because Hive Metastore is only used for 
storage, Hive itself may not understand Flink's meta-objects stored in the 
metastore.
+
+### Integrate Flink with Hive metadata
+
+The ultimate goal for integrating Flink with Hive metadata is that:
+
+1. Existing meta-objects, like tables, views, and functions, created by Hive 
or other Hive-compatible applications can be used by Flink
+
+2. Meta-objects created by `HiveCatalog` can be written back to Hive metastore 
such that Hive and other Hive-compatible applications can consume.
+
+## User-configured Catalog
+
+Catalogs are pluggable. Users can develop custom catalogs by implementing the 
`Catalog` interface, which defines a set of APIs for reading and writing 
catalog meta-objects such as database, tables, partitions, views, and functions.
+
+
+HiveCatalog
+---
+
+## Supported Hive Versions
+
+Flink's `HiveCatalog` officially supports Hive 2.3.4 and 1.2.1.
+
+The Hive version is explicitly specified as a String, either by passing it to 
the constructor when creating `HiveCatalog` instances directly in Table API or 
specifying it in yaml config file in SQL CLI. The Hive version string are 
`2.3.4` and `1.2.1`.
+
+## Case Insensitive to Meta-Object Names
+
+Note that Hive Metastore stores meta-object names in lower cases. Thus, unlike 
`GenericInMemoryCatalog`, `HiveCatalog` is case-insensitive to meta-object 
names, and users need to be cautious on that.
+
+## Dependencies
+
+To use `HiveCatalog`, users need to include the following dependency jars.
+
+For Hive 2.3.4, users need:
+
+```
+// Hive dependencies
+
+- hive-exec-2.3.4.jar 

[GitHub] [flink] bowenli86 commented on a change in pull request #8976: [FLINK-12277][table/hive/doc] Add documentation for catalogs

2019-07-12 Thread GitBox
bowenli86 commented on a change in pull request #8976: 
[FLINK-12277][table/hive/doc] Add documentation for catalogs
URL: https://github.com/apache/flink/pull/8976#discussion_r303169116
 
 

 ##
 File path: docs/dev/table/catalog.md
 ##
 @@ -0,0 +1,367 @@
+---
+title: "Catalog"
+is_beta: true
+nav-parent_id: tableapi
+nav-pos: 100
+---
+
+
+Catalogs provide metadata, such as names, schemas, statistics of tables, and 
information about how to access data stored in a database or other external 
systems. Once a catalog is registered within a `TableEnvironment`, all its 
meta-objects are accessible from the Table API and SQL queries.
+
+
+* This will be replaced by the TOC
+{:toc}
+
+
+Catalog Interface
+-
+
+APIs are defined in `Catalog` interface. The interface defines a set of APIs 
to read and write catalog meta-objects such as database, tables, partitions, 
views, and functions.
+
+
+Catalog Meta-Objects Naming Structure
+-
+
+Flink's catalogs use a strict two-level structure, that is, catalogs contain 
databases, and databases contain meta-objects. Thus, the full name of a 
meta-object is always structured as `catalogName`.`databaseName`.`objectName`.
+
+Each `TableEnvironment` has a `CatalogManager` to manager all registered 
catalogs. To ease access to meta-objects, `CatalogManager` has a concept of 
current catalog and current database. By setting current catalog and current 
database, users can use just the meta-object's name in their queries. This 
greatly simplifies user experience.
+
+For example, a previous query as
+
+```sql
+select * from mycatalog.mydb.myTable;
+```
+
+can be shortened to
+
+```sql
+select * from myTable;
+```
+
+To querying tables in a different database under the current catalog, users 
don't need to specify the catalog name. In our example, it would be
+
+```
+select * from mydb2.myTable2
+```
+
+`CatalogManager` always has a built-in `GenericInMemoryCatalog` named 
`default_catalog`, which has a built-in default database named 
`default_database`. If no other catalog and database are explicitly set, they 
will be the current catalog and current database by default. All temp 
meta-objects, such as those defined by `TableEnvironment#registerTable`  are 
registered to this catalog. 
+
+Users can set current catalog and database via 
`TableEnvironment.useCatalog(...)` and `TableEnvironment.useDatabase(...)` in 
Table API, or `USE CATALOG ...` and `USE DATABASE ...` in Flink SQL.
+
+
+Catalog Types
+-
+
+## GenericInMemoryCatalog
+
+The default catalog; all meta-objects in this catalog are stored in memory, 
and be will be lost once the session shuts down.
+
+Its config entry value in SQL CLI yaml file is "generic_in_memory".
+
+## HiveCatalog
+
+Flink's `HiveCatalog` can read and write both Flink and Hive meta-objects 
using Hive Metastore as persistent storage.
+
+Its config entry value in SQL CLI yaml file is "hive".
+
+### Persist Flink meta-objects
+
+Historically, Flink meta-objects are only stored in memory and are per session 
based. That means users have to recreate all the meta-objects every time they 
start a new session.
+
+To maintain meta-objects across sessions, users can choose to use 
`HiveCatalog` to persist all of users' Flink streaming (unbounded-stream) and 
batch (bounded-stream) meta-objects. Because Hive Metastore is only used for 
storage, Hive itself may not understand Flink's meta-objects stored in the 
metastore.
+
+### Integrate Flink with Hive metadata
+
+The ultimate goal for integrating Flink with Hive metadata is that:
+
+1. Existing meta-objects, like tables, views, and functions, created by Hive 
or other Hive-compatible applications can be used by Flink
+
+2. Meta-objects created by `HiveCatalog` can be written back to Hive metastore 
such that Hive and other Hive-compatible applications can consume.
+
+## User-configured Catalog
+
+Catalogs are pluggable. Users can develop custom catalogs by implementing the 
`Catalog` interface, which defines a set of APIs for reading and writing 
catalog meta-objects such as database, tables, partitions, views, and functions.
+
+
+HiveCatalog
+---
+
+## Supported Hive Versions
+
+Flink's `HiveCatalog` officially supports Hive 2.3.4 and 1.2.1.
+
+The Hive version is explicitly specified as a String, either by passing it to 
the constructor when creating `HiveCatalog` instances directly in Table API or 
specifying it in yaml config file in SQL CLI. The Hive version string are 
`2.3.4` and `1.2.1`.
+
+## Case Insensitive to Meta-Object Names
+
+Note that Hive Metastore stores meta-object names in lower cases. Thus, unlike 
`GenericInMemoryCatalog`, `HiveCatalog` is case-insensitive to meta-object 
names, and users need to be cautious on that.
+
+## Dependencies
+
+To use `HiveCatalog`, users need to include the following dependency jars.
+
+For Hive 2.3.4, users need:
+
+```
+// Hive dependencies
+
+- hive-exec-2.3.4.jar 

[GitHub] [flink] flinkbot edited a comment on issue #9067: [FLINK-13069][hive] HiveTableSink should implement OverwritableTableSink

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9067: [FLINK-13069][hive] HiveTableSink 
should implement OverwritableTableSink
URL: https://github.com/apache/flink/pull/9067#issuecomment-510405753
 
 
   ## CI report:
   
   * 0034a70157b871b401cb1f8cd5a223427cf6223a : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118885081)
   * 1f192d01c764dbff8ab884512814cc1a4fd80dba : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001084)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8742: [FLINK-11879] Add validators for the uses of InputSelectable, BoundedOneInput and BoundedMultiInput

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8742: [FLINK-11879] Add validators for the 
uses of InputSelectable, BoundedOneInput and BoundedMultiInput
URL: https://github.com/apache/flink/pull/8742#issuecomment-510731561
 
 
   ## CI report:
   
   * 3f0c15862fc70f35cd58883ca9635bde1a5fb7ee : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118876288)
   * e9adf752da210ededdcebbd1ba3753c3b689cf3e : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001175)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9064: [FLINK-13188][Runtime / State Backends][Test] Fix MockStateBackend#resolveCheckpointStorageLocation return null cause intellij assertion dete

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9064: [FLINK-13188][Runtime / State 
Backends][Test] Fix MockStateBackend#resolveCheckpointStorageLocation return 
null cause intellij assertion detect test failed
URL: https://github.com/apache/flink/pull/9064#issuecomment-510409332
 
 
   ## CI report:
   
   * 77d92ad5b8be29975fe61014ea1445955fc7841d : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118880623)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9039: [FLINK-13170][table-planner] Planner should get table factory from ca…

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9039: [FLINK-13170][table-planner] Planner 
should get table factory from ca…
URL: https://github.com/apache/flink/pull/9039#issuecomment-510445729
 
 
   ## CI report:
   
   * a14e955ab6082bbd08fcf9b28a654ab771a57fb2 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118899030)
   * 0e58a3aa301da884b3859a7d7e653b964903f32f : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001110)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9038: [FLINK-13169][tests][coordination] IT test for fine-grained recovery (task executor failures)

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9038: [FLINK-13169][tests][coordination] IT 
test for fine-grained recovery (task executor failures)
URL: https://github.com/apache/flink/pull/9038#issuecomment-510467775
 
 
   ## CI report:
   
   * b8a762441d69da24f9041b2159ae0bbda334 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118861397)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9102: [FLINK-13239][ml] Add unary loss functions

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9102: [FLINK-13239][ml] Add unary loss 
functions
URL: https://github.com/apache/flink/pull/9102#issuecomment-510780255
 
 
   ## CI report:
   
   * 1779173d5c43d2b02fa750df8f9101da401c7180 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118890103)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9101: [FLINK-13221][Table SQL / Planner] Blink planner should set ScheduleMode to LAZY_FROM_SOURCES_WITH_BATCH_SLOT_REQUEST for batch jobs

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9101: [FLINK-13221][Table SQL / Planner] 
Blink planner should set ScheduleMode to 
LAZY_FROM_SOURCES_WITH_BATCH_SLOT_REQUEST for batch jobs
URL: https://github.com/apache/flink/pull/9101#issuecomment-510770597
 
 
   ## CI report:
   
   * 6afb0645f386b618ddc1e9d86add2a22967676d6 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118887349)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9035: [FLINK-13168] [table] clarify isBatch/isStreaming/isBounded flag in flink planner and blink planner

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9035: [FLINK-13168] [table] clarify 
isBatch/isStreaming/isBounded flag in flink planner and blink planner
URL: https://github.com/apache/flink/pull/9035#issuecomment-510801620
 
 
   ## CI report:
   
   * dac226605ba8018c4c18c27624260c9e3d1f9eaf : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118897652)
   * a7be6ce6aae6d2229f81923846ac6dd08d3a271e : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001128)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9100: [hotfix] Update `findAndCreateTableSource` method's annotation in TableFactoryUtil class

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9100: [hotfix] Update 
`findAndCreateTableSource` method's annotation in TableFactoryUtil class
URL: https://github.com/apache/flink/pull/9100#issuecomment-510765209
 
 
   ## CI report:
   
   * c9047e3a73d40a615166316b4335fee5013afcce : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118885755)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9098: [FLINK-13236][table-runtime-blink] Fix bug and improve performance in TopNBuffer

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9098: [FLINK-13236][table-runtime-blink] 
Fix bug and improve performance in TopNBuffer
URL: https://github.com/apache/flink/pull/9098#issuecomment-510755324
 
 
   ## CI report:
   
   * 19d462121bdf06eb9982a9890dd5ce53cc9499b4 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118883116)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9099: [FLINK-13237][table-planner-blink] 
Add expression table api test to blink
URL: https://github.com/apache/flink/pull/9099#issuecomment-510762700
 
 
   ## CI report:
   
   * fb347fe30a5e894e388837ed2de4f9b60513d7b1 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118885023)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9097: [FLINK-11529][docs-zh] Translate the "DataStream API Tutorial" page into Chinese

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9097: [FLINK-11529][docs-zh] Translate the 
"DataStream API Tutorial" page into Chinese
URL: https://github.com/apache/flink/pull/9097#issuecomment-510731538
 
 
   ## CI report:
   
   * 9fb0b9288a0b45fe24445e6bd18b7e99c7bd88eb : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118876215)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - 
Table API Example Walkthrough
URL: https://github.com/apache/flink/pull/8903#issuecomment-510464651
 
 
   ## CI report:
   
   * b2821a6ae97fd943f3a66b672e85fbd2374126c4 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118909729)
   * 0699f7e5f2240a4a1bc44c15f08e6a1df47d3b01 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001161)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9094: [FLINK-13094][state-processor-api] Provide an easy way to read timers using the State Processor API

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9094: [FLINK-13094][state-processor-api] 
Provide an easy way to read timers using the State Processor API
URL: https://github.com/apache/flink/pull/9094#issuecomment-510560219
 
 
   ## CI report:
   
   * 68c63247fc6c3b60b0cf7afb483cc04ee8f558d0 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118811503)
   * 90313e480878fce12d292065691baee026795e70 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001032)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9089: [FLINK-13225][table-planner-blink] Introduce type inference for hive functions in blink

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9089: [FLINK-13225][table-planner-blink] 
Introduce type inference for hive functions in blink
URL: https://github.com/apache/flink/pull/9089#issuecomment-510488226
 
 
   ## CI report:
   
   * fb34a0f4245ddac5872ea77aad07887a6ff12d11 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118890132)
   * ba44069acdbd82261839605b5d363548dae81522 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001049)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #7487: [FLINK-11321] Clarify NPE on fetching nonexistent topic

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #7487: [FLINK-11321] Clarify NPE on fetching 
nonexistent topic
URL: https://github.com/apache/flink/pull/7487#issuecomment-510739413
 
 
   ## CI report:
   
   * c746405bfc3264fec2e9a5a6551360e37aa5688f : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118879011)
   * be567080699e278af084886da36fb8369fa3fc13 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001185)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9088: [FLINK-13012][hive] Handle default partition name of Hive table

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9088: [FLINK-13012][hive] Handle default 
partition name of Hive table
URL: https://github.com/apache/flink/pull/9088#issuecomment-510484364
 
 
   ## CI report:
   
   * eac5f74690ddb0b08cb41b029f5b8ac675e63565 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118891245)
   * b22f836f5e8f95a9f376f54c68798eeb14cb1644 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001057)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #7487: [FLINK-11321] Clarify NPE on fetching nonexistent topic

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #7487: [FLINK-11321] Clarify NPE on fetching 
nonexistent topic
URL: https://github.com/apache/flink/pull/7487#issuecomment-510739413
 
 
   ## CI report:
   
   * c746405bfc3264fec2e9a5a6551360e37aa5688f : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118965614)
   * be567080699e278af084886da36fb8369fa3fc13 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001185)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9039: [FLINK-13170][table-planner] Planner should get table factory from ca…

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9039: [FLINK-13170][table-planner] Planner 
should get table factory from ca…
URL: https://github.com/apache/flink/pull/9039#issuecomment-510445729
 
 
   ## CI report:
   
   * a14e955ab6082bbd08fcf9b28a654ab771a57fb2 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/11802)
   * 0e58a3aa301da884b3859a7d7e653b964903f32f : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001110)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8742: [FLINK-11879] Add validators for the uses of InputSelectable, BoundedOneInput and BoundedMultiInput

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8742: [FLINK-11879] Add validators for the 
uses of InputSelectable, BoundedOneInput and BoundedMultiInput
URL: https://github.com/apache/flink/pull/8742#issuecomment-510731561
 
 
   ## CI report:
   
   * 3f0c15862fc70f35cd58883ca9635bde1a5fb7ee : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118946002)
   * e9adf752da210ededdcebbd1ba3753c3b689cf3e : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001175)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8692: [FLINK-12804] Introduce mailbox-based ExecutorService

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8692: [FLINK-12804] Introduce mailbox-based 
ExecutorService
URL: https://github.com/apache/flink/pull/8692#issuecomment-510864550
 
 
   ## CI report:
   
   * 516347e407eb6df83b7abc719bce4805fdbea87d : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/118925470)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9083: [FLINK-13116] [table-planner-blink] Supports catalog statistics in blink planner

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9083: [FLINK-13116] [table-planner-blink] 
Supports catalog statistics in blink planner
URL: https://github.com/apache/flink/pull/9083#issuecomment-510435070
 
 
   ## CI report:
   
   * 402974d0ffb69d9244c108234c9837f2eacc8d37 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118878495)
   * c1768f65b4eeb9abef3d7797aa6e1c711012bd39 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001071)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9049: [FLINK-13176][SQL CLI] remember current catalog and database in SQL CLI SessionContext

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9049: [FLINK-13176][SQL CLI] remember 
current catalog and database in SQL CLI SessionContext
URL: https://github.com/apache/flink/pull/9049#issuecomment-510698190
 
 
   ## CI report:
   
   * 0cdf8186440e2446515c463d1a214ca1505f7a22 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118865431)
   * 25e8c5e8b7c481aa97976a9b8312e624392abd16 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001098)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9067: [FLINK-13069][hive] HiveTableSink should implement OverwritableTableSink

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9067: [FLINK-13069][hive] HiveTableSink 
should implement OverwritableTableSink
URL: https://github.com/apache/flink/pull/9067#issuecomment-510405753
 
 
   ## CI report:
   
   * 0034a70157b871b401cb1f8cd5a223427cf6223a : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118983443)
   * 1f192d01c764dbff8ab884512814cc1a4fd80dba : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001084)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9064: [FLINK-13188][Runtime / State Backends][Test] Fix MockStateBackend#resolveCheckpointStorageLocation return null cause intellij assertion dete

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9064: [FLINK-13188][Runtime / State 
Backends][Test] Fix MockStateBackend#resolveCheckpointStorageLocation return 
null cause intellij assertion detect test failed
URL: https://github.com/apache/flink/pull/9064#issuecomment-510409332
 
 
   ## CI report:
   
   * 77d92ad5b8be29975fe61014ea1445955fc7841d : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118969476)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8920: [FLINK-13024][table] integrate 
FunctionCatalog with CatalogManager
URL: https://github.com/apache/flink/pull/8920#issuecomment-510405859
 
 
   ## CI report:
   
   * 4afedee15460ac0f1f2945ca657581c538ddfc06 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118723073)
   * f639acfa778cc8e31581107f27e3cf0139e3a98d : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/118956583)
   * d1aa3f20fd038d7e0177599671bf31c830426982 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001147)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8911: [FLINK-12995][hive] Add Hive-1.2.1 build to Travis

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8911: [FLINK-12995][hive] Add Hive-1.2.1 
build to Travis
URL: https://github.com/apache/flink/pull/8911#issuecomment-510741229
 
 
   ## CI report:
   
   * e0f3d5b774c08e2154b31fdde4b2c193276723a3 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118966942)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9088: [FLINK-13012][hive] Handle default partition name of Hive table

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9088: [FLINK-13012][hive] Handle default 
partition name of Hive table
URL: https://github.com/apache/flink/pull/9088#issuecomment-510484364
 
 
   ## CI report:
   
   * eac5f74690ddb0b08cb41b029f5b8ac675e63565 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118985888)
   * b22f836f5e8f95a9f376f54c68798eeb14cb1644 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001057)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9064: [FLINK-13188][Runtime / State Backends][Test] Fix MockStateBackend#resolveCheckpointStorageLocation return null cause intellij assertion dete

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9064: [FLINK-13188][Runtime / State 
Backends][Test] Fix MockStateBackend#resolveCheckpointStorageLocation return 
null cause intellij assertion detect test failed
URL: https://github.com/apache/flink/pull/9064#issuecomment-510409332
 
 
   ## CI report:
   
   * 77d92ad5b8be29975fe61014ea1445955fc7841d : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118880623)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9089: [FLINK-13225][table-planner-blink] Introduce type inference for hive functions in blink

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9089: [FLINK-13225][table-planner-blink] 
Introduce type inference for hive functions in blink
URL: https://github.com/apache/flink/pull/9089#issuecomment-510488226
 
 
   ## CI report:
   
   * fb34a0f4245ddac5872ea77aad07887a6ff12d11 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118985870)
   * ba44069acdbd82261839605b5d363548dae81522 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001049)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9035: [FLINK-13168] [table] clarify isBatch/isStreaming/isBounded flag in flink planner and blink planner

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9035: [FLINK-13168] [table] clarify 
isBatch/isStreaming/isBounded flag in flink planner and blink planner
URL: https://github.com/apache/flink/pull/9035#issuecomment-510801620
 
 
   ## CI report:
   
   * dac226605ba8018c4c18c27624260c9e3d1f9eaf : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118987086)
   * a7be6ce6aae6d2229f81923846ac6dd08d3a271e : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001128)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - 
Table API Example Walkthrough
URL: https://github.com/apache/flink/pull/8903#issuecomment-510464651
 
 
   ## CI report:
   
   * b2821a6ae97fd943f3a66b672e85fbd2374126c4 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118909729)
   * 0699f7e5f2240a4a1bc44c15f08e6a1df47d3b01 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001161)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9094: [FLINK-13094][state-processor-api] Provide an easy way to read timers using the State Processor API

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9094: [FLINK-13094][state-processor-api] 
Provide an easy way to read timers using the State Processor API
URL: https://github.com/apache/flink/pull/9094#issuecomment-510560219
 
 
   ## CI report:
   
   * 68c63247fc6c3b60b0cf7afb483cc04ee8f558d0 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118956473)
   * 90313e480878fce12d292065691baee026795e70 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001032)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9096: [hotfix][table-planner-blink] Also set batch properties in BatchExecutor

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9096: [hotfix][table-planner-blink] Also 
set batch properties in BatchExecutor
URL: https://github.com/apache/flink/pull/9096#issuecomment-510724774
 
 
   ## CI report:
   
   * d75ca929b19b054d56332b13374bb3570ccdd179 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118873953)
   * 2210b1aa33ad28cd919b0ea2603e2059e7b7c859 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/119001005)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8911: [FLINK-12995][hive] Add Hive-1.2.1 build to Travis

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8911: [FLINK-12995][hive] Add Hive-1.2.1 
build to Travis
URL: https://github.com/apache/flink/pull/8911#issuecomment-510741229
 
 
   ## CI report:
   
   * e0f3d5b774c08e2154b31fdde4b2c193276723a3 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118879513)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8911: [FLINK-12995][hive] Add Hive-1.2.1 build to Travis

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8911: [FLINK-12995][hive] Add Hive-1.2.1 
build to Travis
URL: https://github.com/apache/flink/pull/8911#issuecomment-511005853
 
 
   ## CI report:
   
   * e0f3d5b774c08e2154b31fdde4b2c193276723a3 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118879513)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #7487: [FLINK-11321] Clarify NPE on fetching nonexistent topic

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #7487: [FLINK-11321] Clarify NPE on fetching 
nonexistent topic
URL: https://github.com/apache/flink/pull/7487#issuecomment-510739413
 
 
   ## CI report:
   
   * c746405bfc3264fec2e9a5a6551360e37aa5688f : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118879011)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8920: [FLINK-13024][table] integrate 
FunctionCatalog with CatalogManager
URL: https://github.com/apache/flink/pull/8920#issuecomment-510405859
 
 
   ## CI report:
   
   * 4afedee15460ac0f1f2945ca657581c538ddfc06 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118723073)
   * f639acfa778cc8e31581107f27e3cf0139e3a98d : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118880117)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] bowenli86 commented on issue #9067: [FLINK-13069][hive] HiveTableSink should implement OverwritableTableSink

2019-07-12 Thread GitBox
bowenli86 commented on issue #9067: [FLINK-13069][hive] HiveTableSink should 
implement OverwritableTableSink
URL: https://github.com/apache/flink/pull/9067#issuecomment-511050839
 
 
   @lirui-apache can you post the CI status? I don't see there's any yet


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9090: [FLINK-13124] Don't forward exceptions when finishing SourceStreamTask

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9090: [FLINK-13124] Don't forward 
exceptions when finishing SourceStreamTask
URL: https://github.com/apache/flink/pull/9090#issuecomment-510496617
 
 
   ## CI report:
   
   * 6c229740b17ae4e0df7c8ba9678ada086ae8bf47 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118880603)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8556: [FLINK-12171][Network] Do not limit the network buffer memory by heap size on the TM side

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8556: [FLINK-12171][Network] Do not limit 
the network buffer memory by heap size on the TM side
URL: https://github.com/apache/flink/pull/8556#issuecomment-510513877
 
 
   ## CI report:
   
   * 4e2a56f6a3a9e57b001ee013d31053222e05ab7a : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118876293)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9083: [FLINK-13116] [table-planner-blink] Supports catalog statistics in blink planner

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9083: [FLINK-13116] [table-planner-blink] 
Supports catalog statistics in blink planner
URL: https://github.com/apache/flink/pull/9083#issuecomment-510435070
 
 
   ## CI report:
   
   * 402974d0ffb69d9244c108234c9837f2eacc8d37 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118878495)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9096: [hotfix][table-planner-blink] Also set batch properties in BatchExecutor

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9096: [hotfix][table-planner-blink] Also 
set batch properties in BatchExecutor
URL: https://github.com/apache/flink/pull/9096#issuecomment-510724774
 
 
   ## CI report:
   
   * d75ca929b19b054d56332b13374bb3570ccdd179 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118873953)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9071: FLINK-13044 [BuildSystem / Shaded] Fix for wrong shading of AWS SDK in flink-s3-fs-hadoop

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9071: FLINK-13044 [BuildSystem / Shaded] 
Fix for wrong shading of AWS SDK in flink-s3-fs-hadoop
URL: https://github.com/apache/flink/pull/9071#issuecomment-510513895
 
 
   ## CI report:
   
   * 9b3db8abd8b43f98158021a430b00a20fae2b26d : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118873266)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9091: [FLINK-13229][table-planner-blink] ExpressionReducer with udf bug in blink

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9091: [FLINK-13229][table-planner-blink] 
ExpressionReducer with udf bug in blink
URL: https://github.com/apache/flink/pull/9091#issuecomment-510500743
 
 
   ## CI report:
   
   * 9e54082df582ddf39462b4080d7e0e14cf7c87cf : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118869558)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9047: [FLINK-13109][docs-zh]Translate "Restart Strategies" page into Chinese

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9047: [FLINK-13109][docs-zh]Translate 
"Restart Strategies" page into Chinese
URL: https://github.com/apache/flink/pull/9047#issuecomment-510488279
 
 
   ## CI report:
   
   * aeba9de6ddf74dbb92b21666cdd9c75fb825987b : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118866049)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9049: [FLINK-13176][SQL CLI] remember current catalog and database in SQL CLI SessionContext

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9049: [FLINK-13176][SQL CLI] remember 
current catalog and database in SQL CLI SessionContext
URL: https://github.com/apache/flink/pull/9049#issuecomment-510698190
 
 
   ## CI report:
   
   * 0cdf8186440e2446515c463d1a214ca1505f7a22 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118865431)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8841: [FLINK-12765][coordinator] 
Bookkeeping of available resources of allocated slots in SlotPool
URL: https://github.com/apache/flink/pull/8841#issuecomment-510405743
 
 
   ## CI report:
   
   * 4106cd9017d5a20ae427c74b627d6c574c02cc40 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118863640)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9094: [FLINK-13094][state-processor-api] Provide an easy way to read timers using the State Processor API

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9094: [FLINK-13094][state-processor-api] 
Provide an easy way to read timers using the State Processor API
URL: https://github.com/apache/flink/pull/9094#issuecomment-510560219
 
 
   ## CI report:
   
   * 68c63247fc6c3b60b0cf7afb483cc04ee8f558d0 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118956473)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8990: [FLINK-13104][metrics] Updated request callback to log warning on failure

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #8990: [FLINK-13104][metrics] Updated 
request callback to log warning on failure
URL: https://github.com/apache/flink/pull/8990#issuecomment-510684087
 
 
   ## CI report:
   
   * f29b2ae71ed7d7dcd823399dc3427f76534b38d1 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118907907)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9039: [FLINK-13170][table-planner] Planner should get table factory from ca…

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9039: [FLINK-13170][table-planner] Planner 
should get table factory from ca…
URL: https://github.com/apache/flink/pull/9039#issuecomment-510445729
 
 
   ## CI report:
   
   * a14e955ab6082bbd08fcf9b28a654ab771a57fb2 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/11802)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9094: [FLINK-13094][state-processor-api] Provide an easy way to read timers using the State Processor API

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9094: [FLINK-13094][state-processor-api] 
Provide an easy way to read timers using the State Processor API
URL: https://github.com/apache/flink/pull/9094#issuecomment-510560219
 
 
   ## CI report:
   
   * 68c63247fc6c3b60b0cf7afb483cc04ee8f558d0 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118877885)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9039: [FLINK-13170][table-planner] Planner should get table factory from ca…

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9039: [FLINK-13170][table-planner] Planner 
should get table factory from ca…
URL: https://github.com/apache/flink/pull/9039#issuecomment-510445729
 
 
   ## CI report:
   
   * a14e955ab6082bbd08fcf9b28a654ab771a57fb2 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118899030)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9084: [FLINK-13213][table-api] Keep MinIdleStateRetentionTime/MaxIdleStateRetentionTime in TableConfig after call toAppendStream/toRetractStream wi

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9084: [FLINK-13213][table-api] Keep 
MinIdleStateRetentionTime/MaxIdleStateRetentionTime in TableConfig after call 
toAppendStream/toRetractStream without QueryConfig parameters
URL: https://github.com/apache/flink/pull/9084#issuecomment-510437882
 
 
   ## CI report:
   
   * 779dc96005e2bf894f50df9989ee0c43dad0c511 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118997915)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9085: [FLINK-13215][hive] Mirate ParseUtil usages to URLEncoder

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9085: [FLINK-13215][hive] Mirate ParseUtil 
usages to URLEncoder
URL: https://github.com/apache/flink/pull/9085#issuecomment-510445809
 
 
   ## CI report:
   
   * 6d1bf89db6821cfc6d9759e5b59404f39a20812f : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118893599)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9084: [FLINK-13213][table-api] Keep MinIdleStateRetentionTime/MaxIdleStateRetentionTime in TableConfig after call toAppendStream/toRetractStream wi

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9084: [FLINK-13213][table-api] Keep 
MinIdleStateRetentionTime/MaxIdleStateRetentionTime in TableConfig after call 
toAppendStream/toRetractStream without QueryConfig parameters
URL: https://github.com/apache/flink/pull/9084#issuecomment-510437882
 
 
   ## CI report:
   
   * 779dc96005e2bf894f50df9989ee0c43dad0c511 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118892358)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9102: [FLINK-13239][ml] Add unary loss functions

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9102: [FLINK-13239][ml] Add unary loss 
functions
URL: https://github.com/apache/flink/pull/9102#issuecomment-510780255
 
 
   ## CI report:
   
   * 1779173d5c43d2b02fa750df8f9101da401c7180 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118995485)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] bowenli86 commented on a change in pull request #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager

2019-07-12 Thread GitBox
bowenli86 commented on a change in pull request #8920: [FLINK-13024][table] 
integrate FunctionCatalog with CatalogManager
URL: https://github.com/apache/flink/pull/8920#discussion_r303147915
 
 

 ##
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/connectors/hive/HiveTableFactory.java
 ##
 @@ -112,4 +141,75 @@ public HiveTableFactory(HiveConf hiveConf) {
return new HiveTableSink(new JobConf(hiveConf), tablePath, 
table);
}
 
+   @Override
+   public FunctionDefinition createFunctionDefinition(String name, 
CatalogFunction catalogFunction) {
 
 Review comment:
   AFAICT, `createFunctionDefinition()` is a bit different from 
`createTableSource/Sink()`. Its implementation is only about how to initialize 
a func definition from the CatalogFunction. The name is for building the func 
definition rather than accessing something from catalog APIs, thus we don't 
need the database name.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] bowenli86 commented on issue #9049: [FLINK-13176][SQL CLI] remember current catalog and database in SQL CLI SessionContext

2019-07-12 Thread GitBox
bowenli86 commented on issue #9049: [FLINK-13176][SQL CLI] remember current 
catalog and database in SQL CLI SessionContext
URL: https://github.com/apache/flink/pull/9049#issuecomment-511032460
 
 
   built successfully with latest master on my own branch 
https://travis-ci.org/bowenli86/flink/builds/557967675


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] bowenli86 commented on a change in pull request #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager

2019-07-12 Thread GitBox
bowenli86 commented on a change in pull request #8920: [FLINK-13024][table] 
integrate FunctionCatalog with CatalogManager
URL: https://github.com/apache/flink/pull/8920#discussion_r303147915
 
 

 ##
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/connectors/hive/HiveTableFactory.java
 ##
 @@ -112,4 +141,75 @@ public HiveTableFactory(HiveConf hiveConf) {
return new HiveTableSink(new JobConf(hiveConf), tablePath, 
table);
}
 
+   @Override
+   public FunctionDefinition createFunctionDefinition(String name, 
CatalogFunction catalogFunction) {
 
 Review comment:
   AFAICT, `createFunctionDefinition()` is a bit different from 
`createTableSource/Sink()`. Its implementation should be only about how to 
initialize a func definition from the CatalogFunction. The name is only for 
building the func definition rather than accessing something from catalog APIs, 
thus we don't need the database name.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9102: [FLINK-13239][ml] Add unary loss functions

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9102: [FLINK-13239][ml] Add unary loss 
functions
URL: https://github.com/apache/flink/pull/9102#issuecomment-510780255
 
 
   ## CI report:
   
   * 1779173d5c43d2b02fa750df8f9101da401c7180 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118890103)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] bowenli86 commented on issue #9049: [FLINK-13176][SQL CLI] remember current catalog and database in SQL CLI SessionContext

2019-07-12 Thread GitBox
bowenli86 commented on issue #9049: [FLINK-13176][SQL CLI] remember current 
catalog and database in SQL CLI SessionContext
URL: https://github.com/apache/flink/pull/9049#issuecomment-511030331
 
 
   I adopted Timo's suggestion. Please take a look @xuefuz @twalthr @docete 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9077: [FLINK-13196][table] Fix Ambiguous column name exception bug for Table API

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9077: [FLINK-13196][table] Fix Ambiguous 
column name exception bug for Table API
URL: https://github.com/apache/flink/pull/9077#issuecomment-510405822
 
 
   ## CI report:
   
   * 11d60ab9683d4ba90a801af3996a7ab62644dba8 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/118889199)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] sjwiesman edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-12 Thread GitBox
sjwiesman edited a comment on issue #8903: [FLINK-12747][docs] Getting Started 
- Table API Example Walkthrough
URL: https://github.com/apache/flink/pull/8903#issuecomment-510909640
 
 
   @morsapaes I believe I've addressed all of your comments
   
   @knaufk ~I'm working on adding testing to the archetypes, in particular the 
quickstarts have [archetype integration 
tests](https://maven.apache.org/archetype/maven-archetype-plugin/integration-test-mojo.html)
 but it doesn't seem like they actually run and that the quickstarts are 
covered by end to end tests. I am working to see if I can get the plugin to 
work since it is much lighter weight but worst case I will add the e2e tests.~ 
I've added e2e tests that check the walkthroughs compile and run. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] sjwiesman commented on a change in pull request #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-12 Thread GitBox
sjwiesman commented on a change in pull request #8903: [FLINK-12747][docs] 
Getting Started - Table API Example Walkthrough
URL: https://github.com/apache/flink/pull/8903#discussion_r303138794
 
 

 ##
 File path: docs/getting-started/tutorials/table_api.md
 ##
 @@ -0,0 +1,423 @@
+---
+title: "Table API"
+nav-id: tableapitutorials
+nav-title: 'Table API'
+nav-parent_id: apitutorials
+nav-pos: 1
+---
+
+
+Apache Flink offers a Table API as a unified, relational API for batch and 
stream processing, i.e., queries are executed with the same semantics on 
unbounded, real-time streams or bounded, recorded streams and produce the same 
results.
+The Table API in Flink is commonly used to ease the definition of data 
analytics, data pipelining, and ETL applications.
+
+* This will be replaced by the TOC
+{:toc}
+
+## What Are We Building? 
+
+In this tutorial, we'll show how to build a continuous ETL pipeline for 
tracking financial transactions by account over time.
+We will start by building our report as a nightly batch job, and then migrate 
to a streaming pipeline to see how batch is just a special case of streaming. 
+
+## Prerequisites
+
+We'll assume that you have some familiarity with Java or Scala, but you should 
be able to follow along even if you're coming from a different programming 
language.
+We'll also assume that you're familiar with basic relational concepts such as 
`SELECT` and `GROUP BY` clauses. 
+
+If you want to follow along, you will require a computer with: 
+
+* Java 8 
+* Maven 
+
+## Help, I’m Stuck! 
+
+If you get stuck, check out the [community support 
resources](https://flink.apache.org/community.html).
+In particular, Apache Flink's [user mailing 
list](https://flink.apache.org/community.html#mailing-lists) is consistently 
ranked as one of the most active of any Apache project and a great way to get 
help quickly. 
+
+## How To Follow Along
+
+If you would like to follow along this walkthrough provides a Flink Maven 
Archetype to create a skeleton project with all the necessary dependencies 
quickly.
+
+
+
+{% highlight bash %}
+$ mvn archetype:generate \
+-DarchetypeGroupId=org.apache.flink \
+-DarchetypeArtifactId=flink-walkthrough-table-java \{% unless 
site.is_stable %}
+
-DarchetypeCatalog=https://repository.apache.org/content/repositories/snapshots/
 \{% endunless %}
+-DarchetypeVersion={{ site.version }} \
+-DgroupId=spend-report \
+-DartifactId=spend-report \
+-Dversion=0.1 \
+-Dpackage=spendreport \
+-DinteractiveMode=false
+{% endhighlight %}
+
+
+{% highlight bash %}
+$ mvn archetype:generate \
+-DarchetypeGroupId=org.apache.flink \
+-DarchetypeArtifactId=flink-walkthrough-table-scala \{% unless 
site.is_stable %}
+
-DarchetypeCatalog=https://repository.apache.org/content/repositories/snapshots/
 \{% endunless %}
+-DarchetypeVersion={{ site.version }} \
+-DgroupId=spend-report \
+-DartifactId=spend-report \
+-Dversion=0.1 \
+-Dpackage=spendreport \
+-DinteractiveMode=false
+{% endhighlight %}
+
+
+
+{% unless site.is_stable %}
+
+Note: For Maven 3.0 or higher, it is no longer possible to specify 
the repository (-DarchetypeCatalog) via the commandline. If you wish to use the 
snapshot repository, you need to add a repository entry to your settings.xml. 
For details about this change, please refer to http://maven.apache.org/archetype/maven-archetype-plugin/archetype-repository.html;>Maven
 official document
+
+{% endunless %}
+
+You can edit the `groupId`, `artifactId` and `package` if you like. With the 
above parameters,
+Maven will create a project with all the dependencies to complete this 
tutorial.
+After importing the project into your editor, you will see a file following 
code. 
+
+
+
+{% highlight java %}
+ExecutionEnvironment env   = ExecutionEnvironment.getExecutionEnvironment();
+BatchTableEnvironment tEnv = BatchTableEnvironment.create(env);
+
+tEnv.registerTableSource("transactions", new TransactionTableSource());
+tEnv.registerTableSink("spend_report", new SpendReportTableSink());
+tEnv.registerFunction("truncateDateToHour", new TruncateDateToHour());
+
+tEnv
+   .scan("transactions")
+   .insertInto("spend_report");
+
+env.execute("Spend Report");
+{% endhighlight %}
+
+
+
+{% highlight scala %}
+val env  = ExecutionEnvironment.getExecutionEnvironment()
+val tEnv = BatchTableEnvironment.create(env)
+
+tEnv.registerTableSource("transactions", new TransactionTableSource())
+tEnv.registerTableSink("spend_report", new SpendReportTableSink())
+
+val truncateDateToHour = new TruncateDateToHour
+
+tEnv
+   .scan("transactions")
+   .insertInto("spend_report")
+
+env.execute("Spend Report")
+{% endhighlight %}
+
+
+
+Let's break down this code by component. 
+
+## Breaking Down The Code
+
+ The Execution Environment
+
+The first two lines set up our `ExecutionEnvironment`.
+The execution environment is how we set properties for our deployments, 

[GitHub] [flink] flinkbot edited a comment on issue #9101: [FLINK-13221][Table SQL / Planner] Blink planner should set ScheduleMode to LAZY_FROM_SOURCES_WITH_BATCH_SLOT_REQUEST for batch jobs

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9101: [FLINK-13221][Table SQL / Planner] 
Blink planner should set ScheduleMode to 
LAZY_FROM_SOURCES_WITH_BATCH_SLOT_REQUEST for batch jobs
URL: https://github.com/apache/flink/pull/9101#issuecomment-510770597
 
 
   ## CI report:
   
   * 6afb0645f386b618ddc1e9d86add2a22967676d6 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118988239)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9035: [FLINK-13168] [table] clarify isBatch/isStreaming/isBounded flag in flink planner and blink planner

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9035: [FLINK-13168] [table] clarify 
isBatch/isStreaming/isBounded flag in flink planner and blink planner
URL: https://github.com/apache/flink/pull/9035#issuecomment-510801620
 
 
   ## CI report:
   
   * dac226605ba8018c4c18c27624260c9e3d1f9eaf : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118987086)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9100: [hotfix] Update `findAndCreateTableSource` method's annotation in TableFactoryUtil class

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9100: [hotfix] Update 
`findAndCreateTableSource` method's annotation in TableFactoryUtil class
URL: https://github.com/apache/flink/pull/9100#issuecomment-510765209
 
 
   ## CI report:
   
   * c9047e3a73d40a615166316b4335fee5013afcce : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118985846)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9101: [FLINK-13221][Table SQL / Planner] Blink planner should set ScheduleMode to LAZY_FROM_SOURCES_WITH_BATCH_SLOT_REQUEST for batch jobs

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9101: [FLINK-13221][Table SQL / Planner] 
Blink planner should set ScheduleMode to 
LAZY_FROM_SOURCES_WITH_BATCH_SLOT_REQUEST for batch jobs
URL: https://github.com/apache/flink/pull/9101#issuecomment-510770597
 
 
   ## CI report:
   
   * 6afb0645f386b618ddc1e9d86add2a22967676d6 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118887349)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9035: [FLINK-13168] [table] clarify isBatch/isStreaming/isBounded flag in flink planner and blink planner

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9035: [FLINK-13168] [table] clarify 
isBatch/isStreaming/isBounded flag in flink planner and blink planner
URL: https://github.com/apache/flink/pull/9035#issuecomment-510801620
 
 
   ## CI report:
   
   * dac226605ba8018c4c18c27624260c9e3d1f9eaf : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118897652)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9088: [FLINK-13012][hive] Handle default partition name of Hive table

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9088: [FLINK-13012][hive] Handle default 
partition name of Hive table
URL: https://github.com/apache/flink/pull/9088#issuecomment-510484364
 
 
   ## CI report:
   
   * eac5f74690ddb0b08cb41b029f5b8ac675e63565 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118985888)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9089: [FLINK-13225][table-planner-blink] Introduce type inference for hive functions in blink

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9089: [FLINK-13225][table-planner-blink] 
Introduce type inference for hive functions in blink
URL: https://github.com/apache/flink/pull/9089#issuecomment-510488226
 
 
   ## CI report:
   
   * fb34a0f4245ddac5872ea77aad07887a6ff12d11 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/118985870)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9088: [FLINK-13012][hive] Handle default partition name of Hive table

2019-07-12 Thread GitBox
flinkbot edited a comment on issue #9088: [FLINK-13012][hive] Handle default 
partition name of Hive table
URL: https://github.com/apache/flink/pull/9088#issuecomment-510484364
 
 
   ## CI report:
   
   * eac5f74690ddb0b08cb41b029f5b8ac675e63565 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118891245)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   3   4   >