bowenli86 commented on a change in pull request #8920: [FLINK-13024][table]
integrate FunctionCatalog with CatalogManager
URL: https://github.com/apache/flink/pull/8920#discussion_r303147915
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/connectors/hive/HiveTableFactory.java
##########
@@ -112,4 +141,75 @@ public HiveTableFactory(HiveConf hiveConf) {
return new HiveTableSink(new JobConf(hiveConf), tablePath,
table);
}
+ @Override
+ public FunctionDefinition createFunctionDefinition(String name,
CatalogFunction catalogFunction) {
Review comment:
AFAICT, `createFunctionDefinition()` is a bit different from
`createTableSource/Sink()`. Its implementation is only about how to initialize
a func definition from the CatalogFunction. The name is for building the func
definition rather than accessing something from catalog APIs, thus we don't
need the database name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
