[GitHub] [flink] flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526703428 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit b8dc475b7766026ebda4f778209616357a42c98f (Sun Sep 01 03:34:31 UTC 2019) **Warnings:** * **1 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
xuefuz edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526882966 @bowenli86 Please take another look when you get a chance. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz commented on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
xuefuz commented on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526882966 @bowenli86 Please take another look when you get a chance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9548: [hotfix] [docs] Fix typo
flinkbot edited a comment on issue #9548: [hotfix] [docs] Fix typo URL: https://github.com/apache/flink/pull/9548#issuecomment-525621002 ## CI report: * 4db15eae32c52515a64a38d6e808cd40f5812c58 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124863301) * a4cfa5ccc0b07a8197ad3e46d4c82e5da3d0ff07 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125336568) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-13840) Let StandaloneJobClusterEntrypoint use user code class loader
[
https://issues.apache.org/jira/browse/FLINK-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920265#comment-16920265
]
Guowei Ma commented on FLINK-13840:
---
As Till said, it is an easy way to add a different directory than lib to
PackagedProgram.
I wrote a draft doc about how to deal with this.
Any comments are welcome!
[https://docs.google.com/document/d/1SUhFt1BmsGMLUYVa72SWLbNrrWzunvcjAlEm8iusvq0/edit#]
> Let StandaloneJobClusterEntrypoint use user code class loader
> -
>
> Key: FLINK-13840
> URL: https://issues.apache.org/jira/browse/FLINK-13840
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Coordination
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Fix For: 1.10.0
>
>
> In order to resolve class loading issues when using the
> {{StandaloneJobClusterEntryPoint}}, it would be better to run the user code
> in the user code class loader which supports child first class loading. At
> the moment, the user code jar is part of the system class path and, hence,
> part of the system class loader.
> An easy way to solve this problem would be to place the user code in a
> different directory than {{lib}} and then specify this path as an additional
> classpath when creating the {{PackagedProgram}}.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9548: [hotfix] [docs] Fix typo
flinkbot edited a comment on issue #9548: [hotfix] [docs] Fix typo URL: https://github.com/apache/flink/pull/9548#issuecomment-525620568 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 70fe6aa747ad021bbb8dd8cdc0beecc863f010be (Sun Sep 01 01:29:19 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] YngwieWang closed pull request #9548: [hotfix] [docs] Fix typo
YngwieWang closed pull request #9548: [hotfix] [docs] Fix typo URL: https://github.com/apache/flink/pull/9548 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9548: [hotfix] [docs] Fix typo
flinkbot edited a comment on issue #9548: [hotfix] [docs] Fix typo URL: https://github.com/apache/flink/pull/9548#issuecomment-525621002 ## CI report: * 4db15eae32c52515a64a38d6e808cd40f5812c58 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124863301) * a4cfa5ccc0b07a8197ad3e46d4c82e5da3d0ff07 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125336568) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9548: [hotfix] [docs] Fix typo
flinkbot edited a comment on issue #9548: [hotfix] [docs] Fix typo URL: https://github.com/apache/flink/pull/9548#issuecomment-525620568 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit a4cfa5ccc0b07a8197ad3e46d4c82e5da3d0ff07 (Sun Sep 01 01:20:10 UTC 2019) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] YngwieWang commented on issue #9548: [hotfix] [docs] Fix typo
YngwieWang commented on issue #9548: [hotfix] [docs] Fix typo URL: https://github.com/apache/flink/pull/9548#issuecomment-526877532 @1u0 , I am greatly appreciated for your help and patient, and I am very sorry that my git skill is poor. I followed your instruction and got some error. I think this time I'm still not doing the right thing. I'm very sorry to trouble you and the community. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9548: [hotfix] [docs] Fix typo
flinkbot edited a comment on issue #9548: [hotfix] [docs] Fix typo URL: https://github.com/apache/flink/pull/9548#issuecomment-525621002 ## CI report: * 4db15eae32c52515a64a38d6e808cd40f5812c58 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124863301) * a4cfa5ccc0b07a8197ad3e46d4c82e5da3d0ff07 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9548: [hotfix] [docs] Fix typo
flinkbot edited a comment on issue #9548: [hotfix] [docs] Fix typo URL: https://github.com/apache/flink/pull/9548#issuecomment-525620568 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit a4cfa5ccc0b07a8197ad3e46d4c82e5da3d0ff07 (Sun Sep 01 00:59:46 UTC 2019) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9586: [hotfix] fix typos
flinkbot edited a comment on issue #9586: [hotfix] fix typos URL: https://github.com/apache/flink/pull/9586#issuecomment-526869421 ## CI report: * 7e3ec397d6462766f56ffb42875beebe5db58528 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125333511) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9586: [hotfix] fix typos
flinkbot edited a comment on issue #9586: [hotfix] fix typos URL: https://github.com/apache/flink/pull/9586#issuecomment-526869421 ## CI report: * 7e3ec397d6462766f56ffb42875beebe5db58528 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125333511) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9586: [hotfix] fix typos
flinkbot commented on issue #9586: [hotfix] fix typos URL: https://github.com/apache/flink/pull/9586#issuecomment-526869421 ## CI report: * 7e3ec397d6462766f56ffb42875beebe5db58528 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9586: [hotfix] fix typos
flinkbot commented on issue #9586: [hotfix] fix typos URL: https://github.com/apache/flink/pull/9586#issuecomment-526868527 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 7e3ec397d6462766f56ffb42875beebe5db58528 (Sat Aug 31 22:05:06 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] KangZhiDong opened a new pull request #9586: [hotfix] fix typos
KangZhiDong opened a new pull request #9586: [hotfix] fix typos URL: https://github.com/apache/flink/pull/9586 fix typos This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (FLINK-13932) PyTest ExecutionConfigTests.test_equals_and_hash fail
[
https://issues.apache.org/jira/browse/FLINK-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-13932.
Resolution: Duplicate
> PyTest ExecutionConfigTests.test_equals_and_hash fail
> -
>
> Key: FLINK-13932
> URL: https://issues.apache.org/jira/browse/FLINK-13932
> Project: Flink
> Issue Type: Bug
> Components: API / Python
>Reporter: TisonKun
>Priority: Critical
>
> Not yet found at master, but independent pull requests even trivial fix fail
> on the same case
> {code:java}
> === FAILURES
> ===
> __ ExecutionConfigTests.test_equals_and_hash
> ___
> self = testMethod=test_equals_and_hash>
> def test_equals_and_hash(self):
>
> config1 =
> ExecutionEnvironment.get_execution_environment().get_config()
>
> config2 =
> ExecutionEnvironment.get_execution_environment().get_config()
>
> self.assertEqual(config1, config2)
>
> > self.assertEqual(hash(config1), hash(config2))
> E AssertionError: 897378335 != 1596606912
> pyflink/common/tests/test_execution_config.py:277: AssertionError
> === warnings summary
> ===
> .tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13
> .tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13
> .tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13
> .tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13
> .tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13
>
> /home/travis/build/flink-ci/flink/flink-python/.tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13:
> DeprecationWarning: Using or importing the ABCs from 'collections' instead
> of from 'collections.abc' is deprecated, and in 3.8 it will stop working
> from collections import (
> {code}
> https://api.travis-ci.com/v3/job/229672435/log.txt
> https://api.travis-ci.com/v3/job/229721832/log.txt
> cc [~sunjincheng121] [~dian.fu]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (FLINK-992) Create CollectionDataSets by reading (client) local files.
[
https://issues.apache.org/jira/browse/FLINK-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920206#comment-16920206
]
Niraj Kumar edited comment on FLINK-992 at 8/31/19 7:55 PM:
[~stefanobaghino], if this is still relevant then can I work on it?
was (Author: lazy_ninja):
[~stefanobaghino], is this is still relevant then can I work on it?
> Create CollectionDataSets by reading (client) local files.
> --
>
> Key: FLINK-992
> URL: https://issues.apache.org/jira/browse/FLINK-992
> Project: Flink
> Issue Type: New Feature
> Components: API / DataSet, API / Python
>Reporter: Fabian Hueske
>Priority: Minor
> Labels: starter
>
> {{CollectionDataSets}} are a nice way to feed data into programs.
> We could add support to read a client-local file at program construction time
> using a FileInputFormat, put its data into a CollectionDataSet, and ship its
> data together with the program.
> This would remove the need to upload small files into DFS which are used
> together with some large input (stored in DFS).
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (FLINK-992) Create CollectionDataSets by reading (client) local files.
[
https://issues.apache.org/jira/browse/FLINK-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920206#comment-16920206
]
Niraj Kumar commented on FLINK-992:
---
[~stefanobaghino], is this is still relevant then can I work on it?
> Create CollectionDataSets by reading (client) local files.
> --
>
> Key: FLINK-992
> URL: https://issues.apache.org/jira/browse/FLINK-992
> Project: Flink
> Issue Type: New Feature
> Components: API / DataSet, API / Python
>Reporter: Fabian Hueske
>Priority: Minor
> Labels: starter
>
> {{CollectionDataSets}} are a nice way to feed data into programs.
> We could add support to read a client-local file at program construction time
> using a FileInputFormat, put its data into a CollectionDataSet, and ship its
> data together with the program.
> This would remove the need to upload small files into DFS which are used
> together with some large input (stored in DFS).
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (FLINK-13395) Add source and sink connector for Aliyun Log Service
[ https://issues.apache.org/jira/browse/FLINK-13395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ke Li updated FLINK-13395: -- Description: Alibaba Log Service is a big data service which has been widely used in Alibaba Group and thousands of customers of Alibaba Cloud. The core storage engine of Log Service is named Loghub which is a large scale distributed storage system which provides producer and consumer to push and pull data like Kafka, AWS Kinesis and Azure Eventhub does. There are a lot of users are using Log Service to collect and analysis data from both on premise and cloud data sources, and consuming data stored in Log Service from Flink or Blink for streaming computing. was: Aliyun Log Service is a big data service which has been widely used in Alibaba Group and thousands of customers of Alibaba Cloud. The core storage engine of Log Service is named Loghub which is a large scale distributed storage system which provides producer and consumer to push and pull data like Kafka, AWS Kinesis and Azure Eventhub does. There are a lot of users are using Log Service to collect and analysis data from both on premise and cloud data sources, and consuming data stored in Log Service from Flink or Blink for streaming computing. > Add source and sink connector for Aliyun Log Service > > > Key: FLINK-13395 > URL: https://issues.apache.org/jira/browse/FLINK-13395 > Project: Flink > Issue Type: New Feature > Components: Connectors / Common >Reporter: Ke Li >Priority: Major > > Alibaba Log Service is a big data service which has been widely used in > Alibaba Group and thousands of customers of Alibaba Cloud. The core storage > engine of Log Service is named Loghub which is a large scale distributed > storage system which provides producer and consumer to push and pull data > like Kafka, AWS Kinesis and Azure Eventhub does. > There are a lot of users are using Log Service to collect and analysis data > from both on premise and cloud data sources, and consuming data stored in Log > Service from Flink or Blink for streaming computing. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] zentol commented on a change in pull request #9560: [FLINK-13897][oss] Move NOTICE file into META-INF directory
zentol commented on a change in pull request #9560: [FLINK-13897][oss] Move NOTICE file into META-INF directory URL: https://github.com/apache/flink/pull/9560#discussion_r319720852 ## File path: NOTICE-binary ## @@ -4732,11 +4851,6 @@ Copyright 2014-2019 The Apache Software Foundation flink-fs-hadoop-shaded Copyright 2014-2019 The Apache Software Foundation -This project includes software developed at -The Apache Software Foundation (http://www.apache.org/). - -This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) - Review comment: I didn't do any manual changes; I just built everything, ran the collect_licenses script and removed some unrelated changes. I'll double check whether an older jar sneaked in, and how the notice file in the oss jar looks like. AFAIK the shade-plugin isn't deduplicating entries, so this is indeed odd. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9560: [FLINK-13897][oss] Move NOTICE file into META-INF directory
flinkbot edited a comment on issue #9560: [FLINK-13897][oss] Move NOTICE file into META-INF directory URL: https://github.com/apache/flink/pull/9560#issuecomment-526167658 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 4ce38df3d88f26be49178016d7fdd136766ebb62 (Sat Aug 31 11:28:34 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (FLINK-13891) Increment flink-shaded version
[ https://issues.apache.org/jira/browse/FLINK-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-13891. Resolution: Fixed master: 3198c920711e5e2095ad23ef97dbf8ca4d365723 > Increment flink-shaded version > -- > > Key: FLINK-13891 > URL: https://issues.apache.org/jira/browse/FLINK-13891 > Project: Flink > Issue Type: Improvement > Components: Build System >Reporter: Chesnay Schepler >Assignee: Chesnay Schepler >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Closed] (FLINK-13467) Bump ASM to 7.1
[
https://issues.apache.org/jira/browse/FLINK-13467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-13467.
Resolution: Fixed
master: 68e423d05bc732e58afa1cfbb95dd9ae434cc35e
> Bump ASM to 7.1
> ---
>
> Key: FLINK-13467
> URL: https://issues.apache.org/jira/browse/FLINK-13467
> Project: Flink
> Issue Type: Sub-task
> Components: Build System, BuildSystem / Shaded
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0, shaded-8.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The ClosureCleaner doesn't work on Java 11; we have to jump to ASM 7.0+ which
> officially added support for it.
> {code}
> java.lang.UnsupportedOperationException
> at
> org.apache.flink.shaded.asm6.org.objectweb.asm.ClassVisitor.visitNestHostExperimental(ClassVisitor.java:158)
> at
> org.apache.flink.shaded.asm6.org.objectweb.asm.ClassReader.accept(ClassReader.java:541)
> at
> org.apache.flink.shaded.asm6.org.objectweb.asm.ClassReader.accept(ClassReader.java:391)
> at
> org.apache.flink.api.java.ClosureCleaner.cleanThis0(ClosureCleaner.java:187)
> at
> org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:100)
> at
> org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:71)
> at
> org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.clean(StreamExecutionEnvironment.java:1574)
> {code}
> https://github.com/eclipse/jetty.project/issues/2941
> https://gitlab.ow2.org/asm/asm/issues/317854
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Closed] (FLINK-13770) Bump Netty to 4.1.39.Final
[
https://issues.apache.org/jira/browse/FLINK-13770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-13770.
Resolution: Fixed
master: 4c6c11aa7d677a9f504505b0d985fe2c7a25e48e
> Bump Netty to 4.1.39.Final
> --
>
> Key: FLINK-13770
> URL: https://issues.apache.org/jira/browse/FLINK-13770
> Project: Flink
> Issue Type: Improvement
> Components: BuildSystem / Shaded, Runtime / Network
>Reporter: Nico Kruber
>Assignee: Nico Kruber
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0, shaded-8.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I quickly went through all the changelogs for Netty 4.1.32 (which we
> currently use) to the latest Netty 4.1.39.Final. Below, you will find a
> list of bug fixes and performance improvements that may affect us. Nice
> changes we could benefit from, also for the Java > 8 efforts. The most
> important ones fixing leaks etc are #8921, #9167, #9274, #9394, and the
> various {{CompositeByteBuf}} fixes. The rest are mostly performance
> improvements.
> Since we are still early in the dev cycle for Flink 1.10, it would be
> nice to update now and verify that the new version works correctly.
> {code}
> Netty 4.1.33.Final
> - Fix ClassCastException and native crash when using kqueue transport
> (#8665)
> - Provide a way to cache the internal nioBuffer of the PooledByteBuffer
> to reduce GC (#8603)
> Netty 4.1.34.Final
> - Do not use GetPrimitiveArrayCritical(...) due multiple not-fixed bugs
> related to GCLocker (#8921)
> - Correctly monkey-patch id also in whe os / arch is used within library
> name (#8913)
> - Further reduce ensureAccessible() overhead (#8895)
> - Support using an Executor to offload blocking / long-running tasks
> when processing TLS / SSL via the SslHandler (#8847)
> - Minimize memory footprint for AbstractChannelHandlerContext for
> handlers that execute in the EventExecutor (#8786)
> - Fix three bugs in CompositeByteBuf (#8773)
> Netty 4.1.35.Final
> - Fix possible ByteBuf leak when CompositeByteBuf is resized (#8946)
> - Correctly produce ssl alert when certificate validation fails on the
> client-side when using native SSL implementation (#8949)
> Netty 4.1.37.Final
> - Don't filter out TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (#9274)
> - Try to mark child channel writable again once the parent channel
> becomes writable (#9254)
> - Properly debounce wakeups (#9191)
> - Don't read from timerfd and eventfd on each EventLoop tick (#9192)
> - Correctly detect that KeyManagerFactory is not supported when using
> OpenSSL 1.1.0+ (#9170)
> - Fix possible unsafe sharing of internal NIO buffer in CompositeByteBuf
> (#9169)
> - KQueueEventLoop won't unregister active channels reusing a file
> descriptor (#9149)
> - Prefer direct io buffers if direct buffers pooled (#9167)
> Netty 4.1.38.Final
> - Prevent ByteToMessageDecoder from overreading when !isAutoRead (#9252)
> - Correctly take length of ByteBufInputStream into account for
> readLine() / readByte() (#9310)
> - availableSharedCapacity will be slowly exhausted (#9394)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Created] (FLINK-13933) Hive Generic UDTF can not be used in table API both stream and batch mode
fa zheng created FLINK-13933: Summary: Hive Generic UDTF can not be used in table API both stream and batch mode Key: FLINK-13933 URL: https://issues.apache.org/jira/browse/FLINK-13933 Project: Flink Issue Type: Bug Components: Table SQL / Planner Affects Versions: 1.9.0 Reporter: fa zheng Fix For: 1.9.1 When i use Hive Generic UDTF in table API, something wrong with CalciteContextException: No match found for function signature . As mentioned in tutorials, Hive’s GenericUDTF is automatically translated into Flink’s TableFunction. However, it didn't give a property of TABLE_FUNCTION. In convertToSqlFunction, when functionDefinition is instanceof TableFunctionDefinition, it will further call category.isTableFunction() and lead a wrong answer. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] zentol merged pull request #9557: [FLINK-13891][build] Increment flink-shaded version
zentol merged pull request #9557: [FLINK-13891][build] Increment flink-shaded version URL: https://github.com/apache/flink/pull/9557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9585: [FLINK-13926][window]`ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic
flinkbot edited a comment on issue #9585: [FLINK-13926][window]`ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic URL: https://github.com/apache/flink/pull/9585#issuecomment-526815944 ## CI report: * 44eb7774cfa7c00fb996b7b518a2814725438167 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125313002) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9556: [FLINK-13895] client does not exit when application has failed
flinkbot edited a comment on issue #9556: [FLINK-13895] client does not exit when application has failed URL: https://github.com/apache/flink/pull/9556#issuecomment-526132629 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 581e923972811ec53e5c3361dcd78f5c8c4ee4ae (Sat Aug 31 11:01:00 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-13895).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-13895) Client does not exit when bin/yarn-session.sh come fail
[ https://issues.apache.org/jira/browse/FLINK-13895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated FLINK-13895: Description: the hadoop cluster environment java version is 1.7, flink is compiled with jdk1.8，I used bin/yarn-session.sh submit it , then client comes error and does not exit . I found yarn application which is failed , so then we should not kill the yarn application, we can stop the yarn client . attachments is operation log (was: the hadoop cluster environment java version is 1.7, flink is compiled with jdk1.8，I used bin/yarn-session.sh submit it , then client comes error and does not exit . I found yarn application which is failed , so then we should not kill the yarn application . attachments is operation log) > Client does not exit when bin/yarn-session.sh come fail > --- > > Key: FLINK-13895 > URL: https://issues.apache.org/jira/browse/FLINK-13895 > Project: Flink > Issue Type: Improvement > Components: Deployment / YARN >Affects Versions: 1.9.0 >Reporter: Yu Wang >Priority: Minor > Labels: pull-request-available > Attachments: client_exit.txt > > Time Spent: 10m > Remaining Estimate: 0h > > the hadoop cluster environment java version is 1.7, flink is compiled with > jdk1.8，I used bin/yarn-session.sh submit it , then client comes error and > does not exit . I found yarn application which is failed , so then we should > not kill the yarn application, we can stop the yarn client . attachments is > operation log -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] gentlewangyu commented on issue #9556: [FLINK-13895] client does not exit when application has failed
gentlewangyu commented on issue #9556: [FLINK-13895] client does not exit when application has failed URL: https://github.com/apache/flink/pull/9556#issuecomment-526821382 @TisonKun thank you for your answer , I have updated the description This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-13895) Client does not exit when bin/yarn-session.sh come fail
[ https://issues.apache.org/jira/browse/FLINK-13895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated FLINK-13895: Description: the hadoop cluster environment java version is 1.7, flink is compiled with jdk1.8，I used bin/yarn-session.sh submit it , then client comes error and does not exit . I found yarn application which is failed , so then we should not kill the yarn application . attachments is operation log (was: the hadoop cluster environment java version is 1.7, flink is compiled with jdk1.8，I used bin/yarn-session.sh submit it , then client comes error and does not exit . I found yarn application which is failed , so then we should not kill the yarn application .) > Client does not exit when bin/yarn-session.sh come fail > --- > > Key: FLINK-13895 > URL: https://issues.apache.org/jira/browse/FLINK-13895 > Project: Flink > Issue Type: Improvement > Components: Deployment / YARN >Affects Versions: 1.9.0 >Reporter: Yu Wang >Priority: Minor > Labels: pull-request-available > Attachments: client_exit.txt > > Time Spent: 10m > Remaining Estimate: 0h > > the hadoop cluster environment java version is 1.7, flink is compiled with > jdk1.8，I used bin/yarn-session.sh submit it , then client comes error and > does not exit . I found yarn application which is failed , so then we should > not kill the yarn application . attachments is operation log -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (FLINK-13895) Client does not exit when bin/yarn-session.sh come fail
[ https://issues.apache.org/jira/browse/FLINK-13895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated FLINK-13895: Attachment: client_exit.txt > Client does not exit when bin/yarn-session.sh come fail > --- > > Key: FLINK-13895 > URL: https://issues.apache.org/jira/browse/FLINK-13895 > Project: Flink > Issue Type: Improvement > Components: Deployment / YARN >Affects Versions: 1.9.0 >Reporter: Yu Wang >Priority: Minor > Labels: pull-request-available > Attachments: client_exit.txt > > Time Spent: 10m > Remaining Estimate: 0h > > the hadoop cluster environment java version is 1.7, flink is compiled with > jdk1.8，I used bin/yarn-session.sh submit it , then client comes error and > does not exit . I found yarn application which is failed , so then we should > not kill the yarn application . -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (FLINK-13895) Client does not exit when bin/yarn-session.sh come fail
[ https://issues.apache.org/jira/browse/FLINK-13895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated FLINK-13895: Description: the hadoop cluster environment java version is 1.7, flink is compiled with jdk1.8，I used bin/yarn-session.sh submit it , then client comes error and does not exit . I found yarn application which is failed , so then we should not kill the yarn application . (was: 2019-08-29 09:42:00,589 INFO org.apache.flink.yarn.AbstractYarnClusterDescriptor - Deploying cluster, current state ACCEPTED 2019-08-29 09:42:04,718 ERROR org.apache.flink.yarn.cli.FlinkYarnSessionCli - Error while running the Flink Yarn session. org.apache.flink.client.deployment.ClusterDeploymentException: Couldn't deploy Yarn session cluster at org.apache.flink.yarn.AbstractYarnClusterDescriptor.deploySessionCluster(AbstractYarnClusterDescriptor.java:385) at org.apache.flink.yarn.cli.FlinkYarnSessionCli.run(FlinkYarnSessionCli.java:616) at org.apache.flink.yarn.cli.FlinkYarnSessionCli.lambda$main$3(FlinkYarnSessionCli.java:844) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1754) at org.apache.flink.runtime.security.HadoopSecurityContext.runSecured(HadoopSecurityContext.java:41) at org.apache.flink.yarn.cli.FlinkYarnSessionCli.main(FlinkYarnSessionCli.java:844) Caused by: org.apache.flink.yarn.AbstractYarnClusterDescriptor$YarnDeploymentException: The YARN application unexpectedly switched to state FAILED during deployment. Diagnostics from YARN: Application application_1565802461003_0608 failed 1 times due to AM Container for appattempt_1565802461003_0608_01 exited with exitCode: 1 For more detailed output, check application tracking page:https://hadoop-btnn9001.eniot.io:8090/cluster/app/application_1565802461003_0608Then, click on links to logs of each attempt. Diagnostics: Exception from container-launch. Container id: container_e35_1565802461003_0608_01_01 Exit code: 1 Stack trace: ExitCodeException exitCode=1: at org.apache.hadoop.util.Shell.runCommand(Shell.java:545) at org.apache.hadoop.util.Shell.run(Shell.java:456) at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:722) at org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor.launchContainer(LinuxContainerExecutor.java:387) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch.call(ContainerLaunch.java:302) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch.call(ContainerLaunch.java:82) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) Shell output: main : command provided 1 main : run as user is flinktest main : requested yarn user is flinktest Container exited with a non-zero exit code 1 Failing this attempt. Failing the application. If log aggregation is enabled on your cluster, use this command to further investigate the issue: yarn logs -applicationId application_1565802461003_0608 at org.apache.flink.yarn.AbstractYarnClusterDescriptor.startAppMaster(AbstractYarnClusterDescriptor.java:1024) at org.apache.flink.yarn.AbstractYarnClusterDescriptor.deployInternal(AbstractYarnClusterDescriptor.java:507) at org.apache.flink.yarn.AbstractYarnClusterDescriptor.deploySessionCluster(AbstractYarnClusterDescriptor.java:378) ... 7 more 2019-08-29 09:42:04,723 INFO org.apache.flink.yarn.AbstractYarnClusterDescriptor - Cancelling deployment from Deployment Failure Hook 2019-08-29 09:42:04,723 INFO org.apache.flink.yarn.AbstractYarnClusterDescriptor - Killing YARN application 2019-08-29 09:42:04,729 INFO org.apache.hadoop.io.retry.RetryInvocationHandler - Exception while invoking forceKillApplication of class ApplicationClientProtocolPBClientImpl over rm1. Trying to fail over immediately. java.io.IOException: The client is stopped at org.apache.hadoop.ipc.Client.getConnection(Client.java:1508) at org.apache.hadoop.ipc.Client.call(Client.java:1452) at org.apache.hadoop.ipc.Client.call(Client.java:1413) at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:229) at com.sun.proxy.$Proxy7.forceKillApplication(Unknown Source) at org.apache.hadoop.yarn.api.impl.pb.client.ApplicationClientProtocolPBClientImpl.forceKillApplication(ApplicationClientProtocolPBClientImpl.java:176)
[GitHub] [flink] flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink
flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink URL: https://github.com/apache/flink/pull/9485#issuecomment-522655319 ## CI report: * 64391df18f5c2e3c25268ad52c724abcaa4211b5 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123755053) * 042b4f58d39980820d1c9dc1d779536ece0834c9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125046886) * c4645a6663767d1dfcd242ea5ceb38ef838a5580 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125183439) * 4389f525990904cd3b2a0f366c1324033af0a6e2 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125312745) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9585: [FLINK-13926][window]`ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic
flinkbot edited a comment on issue #9585: [FLINK-13926][window]`ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic URL: https://github.com/apache/flink/pull/9585#issuecomment-526815944 ## CI report: * 44eb7774cfa7c00fb996b7b518a2814725438167 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125313002) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9585: [FLINK-13926][window]`ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic
flinkbot commented on issue #9585: [FLINK-13926][window]`ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic URL: https://github.com/apache/flink/pull/9585#issuecomment-526815944 ## CI report: * 44eb7774cfa7c00fb996b7b518a2814725438167 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink
flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink URL: https://github.com/apache/flink/pull/9485#issuecomment-522655319 ## CI report: * 64391df18f5c2e3c25268ad52c724abcaa4211b5 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123755053) * 042b4f58d39980820d1c9dc1d779536ece0834c9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125046886) * c4645a6663767d1dfcd242ea5ceb38ef838a5580 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125183439) * 4389f525990904cd3b2a0f366c1324033af0a6e2 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125312745) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9585: [FLINK-13926][window]`ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic
flinkbot commented on issue #9585: [FLINK-13926][window]`ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic URL: https://github.com/apache/flink/pull/9585#issuecomment-526814875 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 44eb7774cfa7c00fb996b7b518a2814725438167 (Sat Aug 31 09:12:21 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-13926).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-13926) `ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic
[
https://issues.apache.org/jira/browse/FLINK-13926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-13926:
---
Labels: pull-request-available windows (was: windows)
> `ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be
> generic
> ---
>
> Key: FLINK-13926
> URL: https://issues.apache.org/jira/browse/FLINK-13926
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream
>Affects Versions: 1.9.0
>Reporter: zhihao zhang
>Priority: Major
> Labels: pull-request-available, windows
> Fix For: 2.0.0
>
>
> `ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be
> generic just like `DynamicEventTimeSessionWindows` and
> `DynamicProcessingTimeSessionWindows`.
> now:
>
> {code:java}
> public class ProcessingTimeSessionWindows extends
> MergingWindowAssigner {}
> {code}
> proposal:
>
> {code:java}
> public class ProcessingTimeSessionWindows extends MergingWindowAssigner TimeWindow> {}
> {code}
> If this ticket is ok to go, I would like to take it.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] izhangzhihao opened a new pull request #9585: [FLINK-13926][window]`ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be generic
izhangzhihao opened a new pull request #9585:
[FLINK-13926][window]`ProcessingTimeSessionWindows` and
`EventTimeSessionWindows` should be generic
URL: https://github.com/apache/flink/pull/9585
## What is the purpose of the change
`ProcessingTimeSessionWindows` and `EventTimeSessionWindows` should be
generic just like `DynamicEventTimeSessionWindows` and
`DynamicProcessingTimeSessionWindows`.
now:
```java
public class ProcessingTimeSessionWindows extends
MergingWindowAssigner {}
```
proposal:
```java
public class ProcessingTimeSessionWindows extends
MergingWindowAssigner {}
```
## Brief change log
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ not documented)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink
flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink URL: https://github.com/apache/flink/pull/9485#issuecomment-522655319 ## CI report: * 64391df18f5c2e3c25268ad52c724abcaa4211b5 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123755053) * 042b4f58d39980820d1c9dc1d779536ece0834c9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125046886) * c4645a6663767d1dfcd242ea5ceb38ef838a5580 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125183439) * 4389f525990904cd3b2a0f366c1324033af0a6e2 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink
flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink URL: https://github.com/apache/flink/pull/9485#issuecomment-522652393 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 4389f525990904cd3b2a0f366c1324033af0a6e2 (Sat Aug 31 09:01:50 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink
JingsongLi commented on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink URL: https://github.com/apache/flink/pull/9485#issuecomment-526814192 @dawidwys Thanks for you review, comments addressed. @wuchong can you take a look to 7052fdc ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink
JingsongLi commented on a change in pull request #9485:
[FLINK-13775][table-planner-blink] Refactor
ExpressionConverter(RexNodeConverter) in blink
URL: https://github.com/apache/flink/pull/9485#discussion_r319717162
##
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/expressions/converter/CustomizedConvertRule.java
##
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.expressions.converter;
+
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.expressions.CallExpression;
+import org.apache.flink.table.expressions.Expression;
+import org.apache.flink.table.expressions.ExpressionUtils;
+import org.apache.flink.table.expressions.TableReferenceExpression;
+import org.apache.flink.table.expressions.TypeLiteralExpression;
+import org.apache.flink.table.expressions.ValueLiteralExpression;
+import org.apache.flink.table.expressions.utils.ApiExpressionUtils;
+import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
+import org.apache.flink.table.functions.FunctionDefinition;
+import org.apache.flink.table.operations.QueryOperation;
+import org.apache.flink.table.planner.calcite.FlinkRelBuilder;
+import org.apache.flink.table.planner.functions.InternalFunctionDefinitions;
+import org.apache.flink.table.planner.functions.sql.FlinkSqlOperatorTable;
+import org.apache.flink.table.planner.functions.sql.SqlThrowExceptionFunction;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.ArrayType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import com.google.common.collect.ImmutableList;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.rex.RexSubQuery;
+import org.apache.calcite.sql.fun.SqlTrimFunction;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+import static org.apache.calcite.sql.type.SqlTypeName.VARCHAR;
+import static
org.apache.flink.table.planner.calcite.FlinkTypeFactory.toLogicalType;
+import static
org.apache.flink.table.planner.expressions.converter.ExpressionConverter.extractValue;
+import static
org.apache.flink.table.planner.expressions.converter.ExpressionConverter.toRexNodes;
+import static
org.apache.flink.table.runtime.types.LogicalTypeDataTypeConverter.fromDataTypeToLogicalType;
+import static
org.apache.flink.table.runtime.typeutils.TypeCheckUtils.isCharacterString;
+import static
org.apache.flink.table.runtime.typeutils.TypeCheckUtils.isTemporal;
+import static
org.apache.flink.table.runtime.typeutils.TypeCheckUtils.isTimeInterval;
+
+/**
+ * Customized {@link CallExpressionConvertRule}, Functions conversion here all
require special logic,
+ * and there may be some special rules, such as needing get the literal values
of inputs, such as
+ * converting to combinations of functions, to convert to RexNode of calcite.
+ */
+public class CustomizedConvertRule implements CallExpressionConvertRule {
+
+ private static final Map
DEFINITION_RULE_MAP = new HashMap<>();
+ static {
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.CAST,
CustomizedConvertRule::convertCast);
+
DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.REINTERPRET_CAST,
CustomizedConvertRule::convertReinterpretCast);
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.IN,
CustomizedConvertRule::convertIn);
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.GET,
CustomizedConvertRule::convertGet);
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.TRIM,
CustomizedConvertRule::convertTrim);
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.AS,
CustomizedConvertRule::convertAs);
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.BETWEEN,
CustomizedConvertRule::convertBetween);
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.NOT_BETWEEN,
[GitHub] [flink] flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink
flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink URL: https://github.com/apache/flink/pull/9485#issuecomment-522652393 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 4389f525990904cd3b2a0f366c1324033af0a6e2 (Sat Aug 31 08:56:46 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink
flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink URL: https://github.com/apache/flink/pull/9485#issuecomment-522652393 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit c4645a6663767d1dfcd242ea5ceb38ef838a5580 (Sat Aug 31 08:52:41 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink
JingsongLi commented on a change in pull request #9485:
[FLINK-13775][table-planner-blink] Refactor
ExpressionConverter(RexNodeConverter) in blink
URL: https://github.com/apache/flink/pull/9485#discussion_r319716955
##
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/expressions/converter/OverConvertRule.java
##
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.expressions.converter;
+
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.expressions.CallExpression;
+import org.apache.flink.table.expressions.Expression;
+import org.apache.flink.table.expressions.ResolvedExpression;
+import org.apache.flink.table.expressions.ValueLiteralExpression;
+import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
+import org.apache.flink.table.functions.FunctionDefinition;
+import org.apache.flink.table.planner.calcite.FlinkPlannerImpl;
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
+import org.apache.flink.table.planner.expressions.SqlAggFunctionVisitor;
+import org.apache.flink.table.types.logical.DecimalType;
+import org.apache.flink.table.types.logical.LogicalTypeRoot;
+import org.apache.flink.table.types.logical.utils.LogicalTypeChecks;
+
+import com.google.common.collect.ImmutableList;
+import org.apache.calcite.rel.RelFieldCollation;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rex.RexCall;
+import org.apache.calcite.rex.RexFieldCollation;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.rex.RexWindowBound;
+import org.apache.calcite.sql.SqlAggFunction;
+import org.apache.calcite.sql.SqlBasicCall;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlLiteral;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperator;
+import org.apache.calcite.sql.SqlPostfixOperator;
+import org.apache.calcite.sql.SqlWindow;
+import org.apache.calcite.sql.parser.SqlParserPos;
+import org.apache.calcite.sql.type.OrdinalReturnTypeInference;
+
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import static
org.apache.flink.table.planner.expressions.converter.ExpressionConverter.extractValue;
+import static
org.apache.flink.table.runtime.types.LogicalTypeDataTypeConverter.fromDataTypeToLogicalType;
+
+/**
+ * A {@link CallExpressionConvertRule} that converts {@link
BuiltInFunctionDefinitions#OVER}.
+ */
+public class OverConvertRule implements CallExpressionConvertRule {
+
+ @Override
+ public Optional convert(
+ CallExpression call, ConvertContext context) {
+ List children = call.getChildren();
+ if (call.getFunctionDefinition() ==
BuiltInFunctionDefinitions.OVER) {
+ FlinkTypeFactory typeFactory = context.getTypeFactory();
+ Expression agg = children.get(0);
+ SqlAggFunction aggFunc = agg.accept(new
SqlAggFunctionVisitor(typeFactory));
+ RelDataType aggResultType =
typeFactory.createFieldTypeFromLogicalType(
+ fromDataTypeToLogicalType(((ResolvedExpression)
agg).getOutputDataType()));
+
+ // assemble exprs by agg children
+ List aggExprs =
agg.getChildren().stream().map(context::toRexNode)
+ .collect(Collectors.toList());
+
+ // assemble order by key
+ Expression orderKeyExpr = children.get(1);
+ Set kinds = new HashSet<>();
+ RexNode collationRexNode = createCollation(
+ context.toRexNode(orderKeyExpr),
RelFieldCollation.Direction.ASCENDING, null, kinds);
+ ImmutableList orderKey =
ImmutableList
+ .of(new RexFieldCollation(collationRexNode,
kinds));
+
+ // assemble partition by keys
+
[GitHub] [flink] flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink
flinkbot edited a comment on issue #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink URL: https://github.com/apache/flink/pull/9485#issuecomment-522652393 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit c4645a6663767d1dfcd242ea5ceb38ef838a5580 (Sat Aug 31 08:48:36 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #9485: [FLINK-13775][table-planner-blink] Refactor ExpressionConverter(RexNodeConverter) in blink
JingsongLi commented on a change in pull request #9485:
[FLINK-13775][table-planner-blink] Refactor
ExpressionConverter(RexNodeConverter) in blink
URL: https://github.com/apache/flink/pull/9485#discussion_r319716866
##
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/expressions/converter/CustomizedConvertRule.java
##
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.expressions.converter;
+
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.expressions.CallExpression;
+import org.apache.flink.table.expressions.Expression;
+import org.apache.flink.table.expressions.ExpressionUtils;
+import org.apache.flink.table.expressions.TableReferenceExpression;
+import org.apache.flink.table.expressions.TypeLiteralExpression;
+import org.apache.flink.table.expressions.ValueLiteralExpression;
+import org.apache.flink.table.expressions.utils.ApiExpressionUtils;
+import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
+import org.apache.flink.table.functions.FunctionDefinition;
+import org.apache.flink.table.operations.QueryOperation;
+import org.apache.flink.table.planner.calcite.FlinkRelBuilder;
+import org.apache.flink.table.planner.functions.InternalFunctionDefinitions;
+import org.apache.flink.table.planner.functions.sql.FlinkSqlOperatorTable;
+import org.apache.flink.table.planner.functions.sql.SqlThrowExceptionFunction;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.ArrayType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import com.google.common.collect.ImmutableList;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.rex.RexSubQuery;
+import org.apache.calcite.sql.fun.SqlTrimFunction;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+import static org.apache.calcite.sql.type.SqlTypeName.VARCHAR;
+import static
org.apache.flink.table.planner.calcite.FlinkTypeFactory.toLogicalType;
+import static
org.apache.flink.table.planner.expressions.converter.ExpressionConverter.extractValue;
+import static
org.apache.flink.table.planner.expressions.converter.ExpressionConverter.toRexNodes;
+import static
org.apache.flink.table.runtime.types.LogicalTypeDataTypeConverter.fromDataTypeToLogicalType;
+import static
org.apache.flink.table.runtime.typeutils.TypeCheckUtils.isCharacterString;
+import static
org.apache.flink.table.runtime.typeutils.TypeCheckUtils.isTemporal;
+import static
org.apache.flink.table.runtime.typeutils.TypeCheckUtils.isTimeInterval;
+
+/**
+ * Customized {@link CallExpressionConvertRule}, Functions conversion here all
require special logic,
+ * and there may be some special rules, such as needing get the literal values
of inputs, such as
+ * converting to combinations of functions, to convert to RexNode of calcite.
+ */
+public class CustomizedConvertRule implements CallExpressionConvertRule {
+
+ private static final Map
DEFINITION_RULE_MAP = new HashMap<>();
+ static {
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.CAST,
CustomizedConvertRule::convertCast);
+
DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.REINTERPRET_CAST,
CustomizedConvertRule::convertReinterpretCast);
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.IN,
CustomizedConvertRule::convertIn);
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.GET,
CustomizedConvertRule::convertGet);
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.TRIM,
CustomizedConvertRule::convertTrim);
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.AS,
CustomizedConvertRule::convertAs);
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.BETWEEN,
CustomizedConvertRule::convertBetween);
+ DEFINITION_RULE_MAP.put(BuiltInFunctionDefinitions.NOT_BETWEEN,
[GitHub] [flink] flinkbot edited a comment on issue #9158: [FLINK-10052][coordination] Tolerate temporarily suspended ZooKeeper connections
flinkbot edited a comment on issue #9158: [FLINK-10052][coordination] Tolerate temporarily suspended ZooKeeper connections URL: https://github.com/apache/flink/pull/9158#issuecomment-512691988 ## CI report: * 6c5df1ff80d0b5c7a5b39867733c8e1c9740d5cf : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/119585208) * 408ebea57b460c2ce6a40ae924eb8f7e89694c2a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119591295) * c1b73eb5d61aee00b79e961799b3a0fc928a565d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119766216) * af2379f40a051eff633245bb3bb02485bad35f26 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/119874091) * bd146ddcd1d9e0501f7e792875f5887edb8b7299 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125310114) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9158: [FLINK-10052][coordination] Tolerate temporarily suspended ZooKeeper connections
flinkbot edited a comment on issue #9158: [FLINK-10052][coordination] Tolerate temporarily suspended ZooKeeper connections URL: https://github.com/apache/flink/pull/9158#issuecomment-512691988 ## CI report: * 6c5df1ff80d0b5c7a5b39867733c8e1c9740d5cf : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/119585208) * 408ebea57b460c2ce6a40ae924eb8f7e89694c2a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119591295) * c1b73eb5d61aee00b79e961799b3a0fc928a565d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119766216) * af2379f40a051eff633245bb3bb02485bad35f26 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/119874091) * bd146ddcd1d9e0501f7e792875f5887edb8b7299 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125310114) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9158: [FLINK-10052][coordination] Tolerate temporarily suspended ZooKeeper connections
flinkbot edited a comment on issue #9158: [FLINK-10052][coordination] Tolerate temporarily suspended ZooKeeper connections URL: https://github.com/apache/flink/pull/9158#issuecomment-512691988 ## CI report: * 6c5df1ff80d0b5c7a5b39867733c8e1c9740d5cf : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/119585208) * 408ebea57b460c2ce6a40ae924eb8f7e89694c2a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119591295) * c1b73eb5d61aee00b79e961799b3a0fc928a565d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119766216) * af2379f40a051eff633245bb3bb02485bad35f26 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/119874091) * bd146ddcd1d9e0501f7e792875f5887edb8b7299 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9158: [FLINK-10052][coordination] Tolerate temporarily suspended ZooKeeper connections
flinkbot edited a comment on issue #9158: [FLINK-10052][coordination] Tolerate temporarily suspended ZooKeeper connections URL: https://github.com/apache/flink/pull/9158#issuecomment-512689977 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit bd146ddcd1d9e0501f7e792875f5887edb8b7299 (Sat Aug 31 06:56:32 UTC 2019) **Warnings:** * **9 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❗ 3. Needs [attention] from. - Needs attention by @tillrohrmann [PMC] * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-7151) Add a function SQL DDL
[
https://issues.apache.org/jira/browse/FLINK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920042#comment-16920042
]
Terry Wang commented on FLINK-7151:
---
Hi~ [~ZhenqiuHuang] How is it going on this issue?
Since I am drafting a doc about enhancement for Flink Sql DDL related
Database/Table/Function, I am willing to include this issue and implement it
before 1.10 release. What're your thoughts?
> Add a function SQL DDL
> --
>
> Key: FLINK-7151
> URL: https://issues.apache.org/jira/browse/FLINK-7151
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
>Reporter: yuemeng
>Assignee: Shuyi Chen
>Priority: Critical
> Fix For: 1.10.0
>
>
> Based on create function and table.we can register a udf,udaf,udtf use sql:
> {code}
> CREATE FUNCTION [IF NOT EXISTS] [catalog_name.db_name.]function_name AS
> class_name;
> DROP FUNCTION [IF EXISTS] [catalog_name.db_name.]function_name;
> ALTER FUNCTION [IF EXISTS] [catalog_name.db_name.]function_name RENAME TO
> new_name;
> {code}
> {code}
> CREATE function 'TOPK' AS
> 'com..aggregate.udaf.distinctUdaf.topk.ITopKUDAF';
> INSERT INTO db_sink SELECT id, TOPK(price, 5, 'DESC') FROM kafka_source GROUP
> BY id;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
