[GitHub] [flink] flinkbot commented on pull request #17148: [FLINK-24158][runtime] Remove useless collector in LimitOperator
flinkbot commented on pull request #17148: URL: https://github.com/apache/flink/pull/17148#issuecomment-912915087 ## CI report: * 95e9cb3361f5477bd111a1be0a61e8073ede6a07 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17143: [release-1.14][FLINK-24064][connector/common] HybridSource restore from savepoint
flinkbot edited a comment on pull request #17143: URL: https://github.com/apache/flink/pull/17143#issuecomment-912869331 ## CI report: * 3faf6ec7a4531b97d39ec47d6f0760dc01da9459 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23531) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (FLINK-23820) Test profiling for Python user-defined functions
[ https://issues.apache.org/jira/browse/FLINK-23820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409833#comment-17409833 ] JING ZHANG edited comment on FLINK-23820 at 9/4/21, 5:48 AM: - Results are expected. *Environment* Mac, python 3.8.11, master branch (last commit:2984d87ed7761a6ca345b8b79bcb6dd49db0442b) *Coding* !image-2021-09-04-13-38-53-247.png|width=1472,height=909! *Profile result* After setting "python.profile.enabled" to true, there are profile result like the following picture. *!image-2021-09-04-13-37-49-740.png|width=2638,height=1289!* was (Author: qingru zhang): Results are expected. *Environment* Mac, python 3.8.11, master branch (last commit:2984d87ed7761a6ca345b8b79bcb6dd49db0442b) *Coding* !image-2021-09-04-13-38-53-247.png|width=1472,height=909! *LOGGING* After setting "python.profile.enabled" to true, there are profile informations like the following picture in the log. *!image-2021-09-04-13-37-49-740.png|width=2638,height=1289!* > Test profiling for Python user-defined functions > > > Key: FLINK-23820 > URL: https://issues.apache.org/jira/browse/FLINK-23820 > Project: Flink > Issue Type: Improvement > Components: API / Python >Reporter: Huang Xingbo >Assignee: JING ZHANG >Priority: Blocker > Labels: release-testing > Fix For: 1.14.0 > > Attachments: image-2021-09-04-13-37-49-740.png, > image-2021-09-04-13-38-53-247.png > > > The newly introduced profiling feature allows users to profiling their python > user-defined functions. > In order to test this new feature I recommend to follow the documentation[1] > [1] > https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/python/debugging/#profiling-python-udfs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-23820) Test profiling for Python user-defined functions
[ https://issues.apache.org/jira/browse/FLINK-23820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409836#comment-17409836 ] JING ZHANG commented on FLINK-23820: [~hxbks2ks] Hi xingbo, please check whether above verify method is correct. If yes, please mark the Jira to CLOSED. I could not update the Jira status. > Test profiling for Python user-defined functions > > > Key: FLINK-23820 > URL: https://issues.apache.org/jira/browse/FLINK-23820 > Project: Flink > Issue Type: Improvement > Components: API / Python >Reporter: Huang Xingbo >Assignee: JING ZHANG >Priority: Blocker > Labels: release-testing > Fix For: 1.14.0 > > Attachments: image-2021-09-04-13-37-49-740.png, > image-2021-09-04-13-38-53-247.png > > > The newly introduced profiling feature allows users to profiling their python > user-defined functions. > In order to test this new feature I recommend to follow the documentation[1] > [1] > https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/python/debugging/#profiling-python-udfs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-23820) Test profiling for Python user-defined functions
[ https://issues.apache.org/jira/browse/FLINK-23820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409833#comment-17409833 ] JING ZHANG commented on FLINK-23820: Results are expected. *Environment* Mac, python 3.8.11, master branch (last commit:2984d87ed7761a6ca345b8b79bcb6dd49db0442b) *Coding* !image-2021-09-04-13-38-53-247.png|width=1472,height=909! *LOGGING* After setting "python.profile.enabled" to true, there are profile informations like the following picture in the log. *!image-2021-09-04-13-37-49-740.png|width=2638,height=1289!* > Test profiling for Python user-defined functions > > > Key: FLINK-23820 > URL: https://issues.apache.org/jira/browse/FLINK-23820 > Project: Flink > Issue Type: Improvement > Components: API / Python >Reporter: Huang Xingbo >Assignee: JING ZHANG >Priority: Blocker > Labels: release-testing > Fix For: 1.14.0 > > Attachments: image-2021-09-04-13-37-49-740.png, > image-2021-09-04-13-38-53-247.png > > > The newly introduced profiling feature allows users to profiling their python > user-defined functions. > In order to test this new feature I recommend to follow the documentation[1] > [1] > https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/python/debugging/#profiling-python-udfs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-23820) Test profiling for Python user-defined functions
[ https://issues.apache.org/jira/browse/FLINK-23820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JING ZHANG updated FLINK-23820: --- Attachment: image-2021-09-04-13-38-53-247.png > Test profiling for Python user-defined functions > > > Key: FLINK-23820 > URL: https://issues.apache.org/jira/browse/FLINK-23820 > Project: Flink > Issue Type: Improvement > Components: API / Python >Reporter: Huang Xingbo >Assignee: JING ZHANG >Priority: Blocker > Labels: release-testing > Fix For: 1.14.0 > > Attachments: image-2021-09-04-13-37-49-740.png, > image-2021-09-04-13-38-53-247.png > > > The newly introduced profiling feature allows users to profiling their python > user-defined functions. > In order to test this new feature I recommend to follow the documentation[1] > [1] > https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/python/debugging/#profiling-python-udfs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-23820) Test profiling for Python user-defined functions
[ https://issues.apache.org/jira/browse/FLINK-23820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JING ZHANG updated FLINK-23820: --- Attachment: image-2021-09-04-13-37-49-740.png > Test profiling for Python user-defined functions > > > Key: FLINK-23820 > URL: https://issues.apache.org/jira/browse/FLINK-23820 > Project: Flink > Issue Type: Improvement > Components: API / Python >Reporter: Huang Xingbo >Assignee: JING ZHANG >Priority: Blocker > Labels: release-testing > Fix For: 1.14.0 > > Attachments: image-2021-09-04-13-37-49-740.png > > > The newly introduced profiling feature allows users to profiling their python > user-defined functions. > In order to test this new feature I recommend to follow the documentation[1] > [1] > https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/python/debugging/#profiling-python-udfs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #17148: [FLINK-24158][runtime] Remove useless collector in LimitOperator
flinkbot commented on pull request #17148: URL: https://github.com/apache/flink/pull/17148#issuecomment-912912399 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 95e9cb3361f5477bd111a1be0a61e8073ede6a07 (Sat Sep 04 05:35:24 UTC 2021) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17146: [FLINK-24142]Fix Document DataStream Connectors File Sink ORC Format …
flinkbot edited a comment on pull request #17146: URL: https://github.com/apache/flink/pull/17146#issuecomment-912900037 ## CI report: * d3cb8742eef0401e30f30aa6e863a0f9254f6f9f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23534) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-24158) Remove useless collector in LimitOperator
[
https://issues.apache.org/jira/browse/FLINK-24158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-24158:
---
Labels: beginner easyfix pull-request-available (was: beginner easyfix)
> Remove useless collector in LimitOperator
> -
>
> Key: FLINK-24158
> URL: https://issues.apache.org/jira/browse/FLINK-24158
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Runtime
>Reporter: Zhuang Tianyi
>Assignee: Zhuang Tianyi
>Priority: Minor
> Labels: beginner, easyfix, pull-request-available
>
> [https://github.dev/apache/flink/blob/2984d87ed7761a6ca345b8b79bcb6dd49db0442b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sort/LimitOperator.java#L56|https://github.dev/apache/flink/blob/2984d87ed7761a6ca345b8b79bcb6dd49db0442b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sort/LimitOperator.java#L56-L56]
>
> The collector is unnecessary, we can call {color:#00}output.consume
> directly.
> {color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] TennyZhuang opened a new pull request #17148: [FLINK-24158][runtime] Remove useless collector in LimitOperator
TennyZhuang opened a new pull request #17148: URL: https://github.com/apache/flink/pull/17148 Signed-off-by: TennyZhuang ## What is the purpose of the change Clean code in `LimitOperator` ## Brief change log - Remove useless collector in LimitOperator ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-23847) [Kafka] Error msg are obscure when KafkaConsumer init, valueDeserializer is null
[ https://issues.apache.org/jira/browse/FLINK-23847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] camilesing updated FLINK-23847: --- Priority: Minor (was: Critical) > [Kafka] Error msg are obscure when KafkaConsumer init, valueDeserializer is > null > > > Key: FLINK-23847 > URL: https://issues.apache.org/jira/browse/FLINK-23847 > Project: Flink > Issue Type: Bug > Components: Connectors / Kafka >Reporter: camilesing >Priority: Minor > Labels: pull-request-available > > As the title, i think the msg can be clearer. > > _this.deserializer = checkNotNull(deserializer, "valueDeserializer");_ > _->_ > _this.deserializer = checkNotNull(deserializer, "valueDeserializer cannot be > null");_ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #17146: [FLINK-24142]Fix Document DataStream Connectors File Sink ORC Format …
flinkbot edited a comment on pull request #17146: URL: https://github.com/apache/flink/pull/17146#issuecomment-912900037 ## CI report: * d3cb8742eef0401e30f30aa6e863a0f9254f6f9f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23534) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-24158) Remove useless collector in LimitOperator
[
https://issues.apache.org/jira/browse/FLINK-24158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409782#comment-17409782
]
Zili Chen commented on FLINK-24158:
---
Sounds reasonable, go ahead!
> Remove useless collector in LimitOperator
> -
>
> Key: FLINK-24158
> URL: https://issues.apache.org/jira/browse/FLINK-24158
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Runtime
>Reporter: Zhuang Tianyi
>Assignee: Zhuang Tianyi
>Priority: Minor
> Labels: beginner, easyfix
>
> [https://github.dev/apache/flink/blob/2984d87ed7761a6ca345b8b79bcb6dd49db0442b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sort/LimitOperator.java#L56|https://github.dev/apache/flink/blob/2984d87ed7761a6ca345b8b79bcb6dd49db0442b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sort/LimitOperator.java#L56-L56]
>
> The collector is unnecessary, we can call {color:#00}output.consume
> directly.
> {color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FLINK-24158) Remove useless collector in LimitOperator
[
https://issues.apache.org/jira/browse/FLINK-24158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zili Chen reassigned FLINK-24158:
-
Assignee: Zhuang Tianyi
> Remove useless collector in LimitOperator
> -
>
> Key: FLINK-24158
> URL: https://issues.apache.org/jira/browse/FLINK-24158
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Runtime
>Reporter: Zhuang Tianyi
>Assignee: Zhuang Tianyi
>Priority: Minor
> Labels: beginner, easyfix
>
> [https://github.dev/apache/flink/blob/2984d87ed7761a6ca345b8b79bcb6dd49db0442b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sort/LimitOperator.java#L56|https://github.dev/apache/flink/blob/2984d87ed7761a6ca345b8b79bcb6dd49db0442b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sort/LimitOperator.java#L56-L56]
>
> The collector is unnecessary, we can call {color:#00}output.consume
> directly.
> {color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #17146: [FLINK-24142]Fix Document DataStream Connectors File Sink ORC Format …
flinkbot commented on pull request #17146: URL: https://github.com/apache/flink/pull/17146#issuecomment-912900037 ## CI report: * d3cb8742eef0401e30f30aa6e863a0f9254f6f9f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17145: [FLINK-23748][tests] Testing window TVF session window
flinkbot edited a comment on pull request #17145: URL: https://github.com/apache/flink/pull/17145#issuecomment-912894672 ## CI report: * cbd5815780842a5bac95d8d101a4c681c0cbb7fd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23533) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-23660) Hive Catalog support truncate table
[ https://issues.apache.org/jira/browse/FLINK-23660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lixu updated FLINK-23660: - Component/s: Connectors / Hive > Hive Catalog support truncate table > --- > > Key: FLINK-23660 > URL: https://issues.apache.org/jira/browse/FLINK-23660 > Project: Flink > Issue Type: Improvement > Components: Connectors / Hive, Table SQL / API >Affects Versions: 1.13.0 >Reporter: lixu >Priority: Major > Fix For: 1.14.0, 1.15.0 > > > I think it is necessary to support hive truncate table in actual business -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-23660) Hive Catalog support truncate table
[ https://issues.apache.org/jira/browse/FLINK-23660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lixu updated FLINK-23660: - Fix Version/s: 1.15.0 > Hive Catalog support truncate table > --- > > Key: FLINK-23660 > URL: https://issues.apache.org/jira/browse/FLINK-23660 > Project: Flink > Issue Type: Improvement > Components: Table SQL / API >Affects Versions: 1.13.0 >Reporter: lixu >Priority: Major > Fix For: 1.14.0, 1.15.0 > > > I think it is necessary to support hive truncate table in actual business -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-24158) Remove useless collector in LimitOperator
[
https://issues.apache.org/jira/browse/FLINK-24158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhuang Tianyi updated FLINK-24158:
--
Priority: Minor (was: Major)
> Remove useless collector in LimitOperator
> -
>
> Key: FLINK-24158
> URL: https://issues.apache.org/jira/browse/FLINK-24158
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Runtime
>Reporter: Zhuang Tianyi
>Priority: Minor
> Labels: beginner, easyfix
>
> [https://github.dev/apache/flink/blob/2984d87ed7761a6ca345b8b79bcb6dd49db0442b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sort/LimitOperator.java#L56|https://github.dev/apache/flink/blob/2984d87ed7761a6ca345b8b79bcb6dd49db0442b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sort/LimitOperator.java#L56-L56]
>
> The collector is unnecessary, we can call {color:#00}output.consume
> directly.
> {color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FLINK-24158) Remove useless collector in LimitOperator
Zhuang Tianyi created FLINK-24158:
-
Summary: Remove useless collector in LimitOperator
Key: FLINK-24158
URL: https://issues.apache.org/jira/browse/FLINK-24158
Project: Flink
Issue Type: Improvement
Components: Table SQL / Runtime
Reporter: Zhuang Tianyi
[https://github.dev/apache/flink/blob/2984d87ed7761a6ca345b8b79bcb6dd49db0442b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sort/LimitOperator.java#L56|https://github.dev/apache/flink/blob/2984d87ed7761a6ca345b8b79bcb6dd49db0442b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sort/LimitOperator.java#L56-L56]
The collector is unnecessary, we can call {color:#00}output.consume
directly.
{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #17147: fix flaky test
flinkbot commented on pull request #17147: URL: https://github.com/apache/flink/pull/17147#issuecomment-912896475 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 574ef8e5ded6a6515935c2b490c3c48a2b255359 (Sat Sep 04 03:00:20 UTC 2021) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **Invalid pull request title: No valid Jira ID provided** Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] slm960323 closed pull request #17147: fix flaky test
slm960323 closed pull request #17147: URL: https://github.com/apache/flink/pull/17147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] slm960323 opened a new pull request #17147: fix flaky test
slm960323 opened a new pull request #17147: URL: https://github.com/apache/flink/pull/17147 Fix the flaky test testCEPOperatorComparatorEventTime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17145: [FLINK-23748][tests] Testing window TVF session window
flinkbot commented on pull request #17145: URL: https://github.com/apache/flink/pull/17145#issuecomment-912894672 ## CI report: * cbd5815780842a5bac95d8d101a4c681c0cbb7fd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17146: [FLINK-24142]Fix Document DataStream Connectors File Sink ORC Format …
flinkbot commented on pull request #17146: URL: https://github.com/apache/flink/pull/17146#issuecomment-912893660 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit d3cb8742eef0401e30f30aa6e863a0f9254f6f9f (Sat Sep 04 02:35:11 UTC 2021) **Warnings:** * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24142).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] MasonMa-sy opened a new pull request #17146: [FLINK-24142]Fix Document DataStream Connectors File Sink ORC Format …
MasonMa-sy opened a new pull request #17146: URL: https://github.com/apache/flink/pull/17146 ## What is the purpose of the change Compared with the Java sample, batch.size in the implementation of vectorizer in scala cannot be increased. As a result, the generated Orc file has no data. ## Brief change log - *fix content and content.zh* ## Verifying this change Not needed. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - This is a document change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17145: [FLINK-23748][tests] Testing window TVF session window
flinkbot commented on pull request #17145: URL: https://github.com/apache/flink/pull/17145#issuecomment-912888695 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit cbd5815780842a5bac95d8d101a4c681c0cbb7fd (Sat Sep 04 01:56:44 UTC 2021) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] hililiwei opened a new pull request #17145: [FLINK-23748][tests] Testing window TVF session window
hililiwei opened a new pull request #17145: URL: https://github.com/apache/flink/pull/17145 ## What is the purpose of the change Add the SESSION Window TVF followed by Window Aggregate test class https://issues.apache.org/jira/browse/FLINK-23748 ## Brief change log Add Session Windows test methods in WindowAggregateITCase, including GroupingSets, Cube, Rollup, etc ## Verifying this change Dependencies (does it add or upgrade a dependency): no The public API, i.e., is any changed class annotated with @Public(Evolving): no The serializers: no The runtime per-record code paths (performance sensitive): no Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FLINK-24157) do you have a plan for support dotnet
Clement created FLINK-24157: --- Summary: do you have a plan for support dotnet Key: FLINK-24157 URL: https://issues.apache.org/jira/browse/FLINK-24157 Project: Flink Issue Type: Improvement Reporter: Clement l am neter developer,many net developers need use it ,so do you have a plan for support dotnet thanks -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] hililiwei closed pull request #17056: [FLINK-23748][tests] Testing window TVF session window
hililiwei closed pull request #17056: URL: https://github.com/apache/flink/pull/17056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17144: [release-1.13][FLINK-24064][connector/common] HybridSource restore from savepoint
flinkbot edited a comment on pull request #17144: URL: https://github.com/apache/flink/pull/17144#issuecomment-912869388 ## CI report: * 114fa3ed26bf0871efe70d096d6b6e1124e213e6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23532) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17143: [release-1.14][FLINK-24064][connector/common] HybridSource restore from savepoint
flinkbot edited a comment on pull request #17143: URL: https://github.com/apache/flink/pull/17143#issuecomment-912869331 ## CI report: * 3faf6ec7a4531b97d39ec47d6f0760dc01da9459 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23531) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (FLINK-23857) insert overwirite table select * from t where 1 != 1, Unable to clear table data
[
https://issues.apache.org/jira/browse/FLINK-23857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409759#comment-17409759
]
luoyuxia edited comment on FLINK-23857 at 9/4/21, 12:00 AM:
{code:java}
insert overwrite table t1 partition(f2=1) select * from t2 where 1 != 1{code}
Yeah, I have tried, the sql can clear partition data in Hive.
Currently, the fix only works for no partition table. I would like to try to
make it work even for partition table.
was (Author: luoyuxia):
{code:java}
insert overwrite table t1 partition(f2=1) select * from t2 where 1 != 1{code}
Yeah, I have tried, the sql can clear partition data in Hive.
Now, the fix only works for no partition table. I would like to try to make it
work even for partition table.
> insert overwirite table select * from t where 1 != 1, Unable to clear table
> data
>
>
> Key: FLINK-23857
> URL: https://issues.apache.org/jira/browse/FLINK-23857
> Project: Flink
> Issue Type: Bug
> Components: Connectors / FileSystem, Connectors / Hive
>Affects Versions: 1.13.1
>Reporter: lixu
>Assignee: Rui Li
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0, 1.15.0
>
>
> insert overwirite table select * from t where 1 != 1，Unable to clear table
> data，Unlike hive。
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-23857) insert overwirite table select * from t where 1 != 1, Unable to clear table data
[
https://issues.apache.org/jira/browse/FLINK-23857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409759#comment-17409759
]
luoyuxia commented on FLINK-23857:
--
{code:java}
insert overwrite table t1 partition(f2=1) select * from t2 where 1 != 1{code}
Yeah, I have tried, the sql can clear partition data in Hive.
Now, the fix only works for no partition table. I would like to try to make it
work even for partition table.
> insert overwirite table select * from t where 1 != 1, Unable to clear table
> data
>
>
> Key: FLINK-23857
> URL: https://issues.apache.org/jira/browse/FLINK-23857
> Project: Flink
> Issue Type: Bug
> Components: Connectors / FileSystem, Connectors / Hive
>Affects Versions: 1.13.1
>Reporter: lixu
>Assignee: Rui Li
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0, 1.15.0
>
>
> insert overwirite table select * from t where 1 != 1，Unable to clear table
> data，Unlike hive。
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #17144: [release-1.13][FLINK-24064][connector/common] HybridSource restore from savepoint
flinkbot commented on pull request #17144: URL: https://github.com/apache/flink/pull/17144#issuecomment-912869388 ## CI report: * 114fa3ed26bf0871efe70d096d6b6e1124e213e6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17143: [release-1.14][FLINK-24064][connector/common] HybridSource restore from savepoint
flinkbot commented on pull request #17143: URL: https://github.com/apache/flink/pull/17143#issuecomment-912869331 ## CI report: * 3faf6ec7a4531b97d39ec47d6f0760dc01da9459 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17144: [release-1.13][FLINK-24064][connector/common] HybridSource restore from savepoint
flinkbot commented on pull request #17144: URL: https://github.com/apache/flink/pull/17144#issuecomment-912864427 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 114fa3ed26bf0871efe70d096d6b6e1124e213e6 (Fri Sep 03 23:37:59 UTC 2021) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17143: [release-1.14][FLINK-24064][connector/common] HybridSource restore from savepoint
flinkbot commented on pull request #17143: URL: https://github.com/apache/flink/pull/17143#issuecomment-912863947 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 3faf6ec7a4531b97d39ec47d6f0760dc01da9459 (Fri Sep 03 23:35:47 UTC 2021) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tweise opened a new pull request #17144: [release-1.13][FLINK-24064][connector/common] HybridSource restore from savepoint
tweise opened a new pull request #17144: URL: https://github.com/apache/flink/pull/17144 Backport https://github.com/apache/flink/pull/17111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tweise opened a new pull request #17143: [release-1.14][FLINK-24064][connector/common] HybridSource restore from savepoint
tweise opened a new pull request #17143: URL: https://github.com/apache/flink/pull/17143 Backport https://github.com/apache/flink/pull/17111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tweise commented on pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
tweise commented on pull request #17111: URL: https://github.com/apache/flink/pull/17111#issuecomment-912861293 @stevenzwu @AHeise @SteNicholas thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tweise merged pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
tweise merged pull request #17111: URL: https://github.com/apache/flink/pull/17111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
flinkbot edited a comment on pull request #17111: URL: https://github.com/apache/flink/pull/17111#issuecomment-911126675 ## CI report: * 5690d85244d8151cfe4e10dcccbf020331d5fe30 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23525) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-23846) [DOCS]PushGatewayReporter config description obscure
[ https://issues.apache.org/jira/browse/FLINK-23846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-23846: --- Labels: pull-request-available stale-critical (was: pull-request-available) I am the [Flink Jira Bot|https://github.com/apache/flink-jira-bot/] and I help the community manage its development. I see this issues has been marked as Critical but is unassigned and neither itself nor its Sub-Tasks have been updated for 14 days. I have gone ahead and marked it "stale-critical". If this ticket is critical, please either assign yourself or give an update. Afterwards, please remove the label or in 7 days the issue will be deprioritized. > [DOCS]PushGatewayReporter config description obscure > > > Key: FLINK-23846 > URL: https://issues.apache.org/jira/browse/FLINK-23846 > Project: Flink > Issue Type: Bug > Components: Documentation >Reporter: camilesing >Priority: Critical > Labels: pull-request-available, stale-critical > > the randomJobNameSuffix config description: _Specifies whether a random > suffix should be appended to the job name_ > > when i first to see it, i dont down know what this means. so i search a lot > of information and practice, until i understand that. > > i think the config description can be clearer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-21234) testKafkaSourceSinkWithKeyAndPartialValue[legacy = false, format = csv] hang
[ https://issues.apache.org/jira/browse/FLINK-21234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-21234: --- Labels: auto-deprioritized-major pull-request-available stale-major test-stability (was: auto-deprioritized-major pull-request-available test-stability) I am the [Flink Jira Bot|https://github.com/apache/flink-jira-bot/] and I help the community manage its development. I see this issues has been marked as Major but is unassigned and neither itself nor its Sub-Tasks have been updated for 60 days. I have gone ahead and added a "stale-major" to the issue". If this ticket is a Major, please either assign yourself or give an update. Afterwards, please remove the label or in 7 days the issue will be deprioritized. > testKafkaSourceSinkWithKeyAndPartialValue[legacy = false, format = csv] hang > > > Key: FLINK-21234 > URL: https://issues.apache.org/jira/browse/FLINK-21234 > Project: Flink > Issue Type: Bug > Components: Connectors / Kafka >Affects Versions: 1.12.2, 1.13.0 >Reporter: Guowei Ma >Priority: Major > Labels: auto-deprioritized-major, pull-request-available, > stale-major, test-stability > > https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=12758=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-22869) SQLClientSchemaRegistryITCase timeouts on azure
[
https://issues.apache.org/jira/browse/FLINK-22869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-22869:
---
Labels: stale-critical test-stability (was: test-stability)
I am the [Flink Jira Bot|https://github.com/apache/flink-jira-bot/] and I help
the community manage its development. I see this issues has been marked as
Critical but is unassigned and neither itself nor its Sub-Tasks have been
updated for 14 days. I have gone ahead and marked it "stale-critical". If this
ticket is critical, please either assign yourself or give an update.
Afterwards, please remove the label or in 7 days the issue will be
deprioritized.
> SQLClientSchemaRegistryITCase timeouts on azure
> ---
>
> Key: FLINK-22869
> URL: https://issues.apache.org/jira/browse/FLINK-22869
> Project: Flink
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.12.4, 1.13.2
>Reporter: Xintong Song
>Priority: Critical
> Labels: stale-critical, test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=18652=logs=68a897ab-3047-5660-245a-cce8f83859f6=16ca2cca-2f63-5cce-12d2-d519b930a729=27324
> {code}
> Jun 03 23:51:30 [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0,
> Time elapsed: 227.425 s <<< FAILURE! - in
> org.apache.flink.tests.util.kafka.SQLClientSchemaRegistryITCase
> Jun 03 23:51:30 [ERROR]
> testReading(org.apache.flink.tests.util.kafka.SQLClientSchemaRegistryITCase)
> Time elapsed: 194.931 s <<< ERROR!
> Jun 03 23:51:30 org.junit.runners.model.TestTimedOutException: test timed out
> after 12 milliseconds
> Jun 03 23:51:30 at java.lang.Object.wait(Native Method)
> Jun 03 23:51:30 at java.lang.Thread.join(Thread.java:1252)
> Jun 03 23:51:30 at java.lang.Thread.join(Thread.java:1326)
> Jun 03 23:51:30 at
> org.apache.kafka.clients.admin.KafkaAdminClient.close(KafkaAdminClient.java:541)
> Jun 03 23:51:30 at
> org.apache.kafka.clients.admin.Admin.close(Admin.java:96)
> Jun 03 23:51:30 at
> org.apache.kafka.clients.admin.Admin.close(Admin.java:79)
> Jun 03 23:51:30 at
> org.apache.flink.tests.util.kafka.KafkaContainerClient.createTopic(KafkaContainerClient.java:71)
> Jun 03 23:51:30 at
> org.apache.flink.tests.util.kafka.SQLClientSchemaRegistryITCase.testReading(SQLClientSchemaRegistryITCase.java:102)
> Jun 03 23:51:30 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> Jun 03 23:51:30 at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> Jun 03 23:51:30 at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Jun 03 23:51:30 at java.lang.reflect.Method.invoke(Method.java:498)
> Jun 03 23:51:30 at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> Jun 03 23:51:30 at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> Jun 03 23:51:30 at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> Jun 03 23:51:30 at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> Jun 03 23:51:30 at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
> Jun 03 23:51:30 at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
> Jun 03 23:51:30 at
> java.util.concurrent.FutureTask.run(FutureTask.java:266)
> Jun 03 23:51:30 at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-22531) Improve the support for finite streaming jobs with async operations.
[ https://issues.apache.org/jira/browse/FLINK-22531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-22531: --- Labels: developer-experience stale-major (was: developer-experience) I am the [Flink Jira Bot|https://github.com/apache/flink-jira-bot/] and I help the community manage its development. I see this issues has been marked as Major but is unassigned and neither itself nor its Sub-Tasks have been updated for 60 days. I have gone ahead and added a "stale-major" to the issue". If this ticket is a Major, please either assign yourself or give an update. Afterwards, please remove the label or in 7 days the issue will be deprioritized. > Improve the support for finite streaming jobs with async operations. > > > Key: FLINK-22531 > URL: https://issues.apache.org/jira/browse/FLINK-22531 > Project: Flink > Issue Type: Improvement > Components: Stateful Functions >Affects Versions: statefun-3.0.0 >Reporter: Igal Shilman >Priority: Major > Labels: developer-experience, stale-major > > Finite streaming jobs will terminate even in the presence of asynchronous in > flight operations. > Looking at the AsyncWait operator, it seems that it can be mitigated by using > the following interface: > [https://github.com/apache/flink/blob/master/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/BoundedOneInput.java#L27] > > Mailing list thread: > http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Stateful-Functions-Help-for-calling-remote-stateful-function-written-in-Python-td43283.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #17102: [FLINK-23960][streaming] checkScheduledTimestamps changed according to semantic of the calculation processing time delay
flinkbot edited a comment on pull request #17102: URL: https://github.com/apache/flink/pull/17102#issuecomment-910365614 ## CI report: * 7a88172bfdf610fe669d46a10fa62fe5db22f2b8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23522) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17103: [FLINK-24069][tests] Fail IgnoreInFlightData test when there is not enough data for it for all checkpoints not only the first one
flinkbot edited a comment on pull request #17103: URL: https://github.com/apache/flink/pull/17103#issuecomment-910422814 ## CI report: * 8e9b56137ccaf9a804e3e317db26096db3ef3f7c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23523) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17126: [FLINK-24090][docs] Added Troubleshooting section with ignoring in-fl…
flinkbot edited a comment on pull request #17126: URL: https://github.com/apache/flink/pull/17126#issuecomment-911781874 ## CI report: * 002396c2b89a35277bb192e9ec9ae00daeb0459f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23524) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17142: [FLINK-24148] Add bloom filter option in RocksDBConfiguredOptions
flinkbot edited a comment on pull request #17142: URL: https://github.com/apache/flink/pull/17142#issuecomment-912651118 ## CI report: * 27b71d7c937e087f515908b5575852a14c0bcdd0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23520) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
flinkbot edited a comment on pull request #17111: URL: https://github.com/apache/flink/pull/17111#issuecomment-911126675 ## CI report: * f4b4b598c81f921d1547f83c92ea12757573ad55 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23449) * 5690d85244d8151cfe4e10dcccbf020331d5fe30 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23525) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17000: [FLINK-23946][clients] Application mode should shutdown gracefully on…
flinkbot edited a comment on pull request #17000: URL: https://github.com/apache/flink/pull/17000#issuecomment-906394364 ## CI report: * 2c738ac974ca8873f142279cfce6e8a8659c370f UNKNOWN * 49eba9e46aa029bffa4c8df1786e3942fae678cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23521) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17126: [FLINK-24090][docs] Added Troubleshooting section with ignoring in-fl…
flinkbot edited a comment on pull request #17126: URL: https://github.com/apache/flink/pull/17126#issuecomment-911781874 ## CI report: * 6675abefda4deb11e7774014f77ad2f6280cd13d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23426) * 002396c2b89a35277bb192e9ec9ae00daeb0459f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23524) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17103: [FLINK-24069][tests] Fail IgnoreInFlightData test when there is not enough data for it for all checkpoints not only the first one
flinkbot edited a comment on pull request #17103: URL: https://github.com/apache/flink/pull/17103#issuecomment-910422814 ## CI report: * 15effce4e18b4b4b62b0eab352bab10a542379d5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23336) * 8e9b56137ccaf9a804e3e317db26096db3ef3f7c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23523) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
flinkbot edited a comment on pull request #17111: URL: https://github.com/apache/flink/pull/17111#issuecomment-911126675 ## CI report: * f4b4b598c81f921d1547f83c92ea12757573ad55 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23449) * 5690d85244d8151cfe4e10dcccbf020331d5fe30 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17102: [FLINK-23960][streaming] checkScheduledTimestamps changed according to semantic of the calculation processing time delay
flinkbot edited a comment on pull request #17102: URL: https://github.com/apache/flink/pull/17102#issuecomment-910365614 ## CI report: * 81402821c3377da928cbe1dea5cd3c22b24abf1b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23391) * 7a88172bfdf610fe669d46a10fa62fe5db22f2b8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23522) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FLINK-24156) BlobServer crashes due to SocketTimeoutException in Java 11
Ryan Scudellari created FLINK-24156:
---
Summary: BlobServer crashes due to SocketTimeoutException in Java
11
Key: FLINK-24156
URL: https://issues.apache.org/jira/browse/FLINK-24156
Project: Flink
Issue Type: Bug
Components: Runtime / Network
Affects Versions: 1.13.2, 1.12.4
Environment: Java 11
CentOS 7.6
Reporter: Ryan Scudellari
h3. Overview
We have seen the BlobServer crash due to a *SocketTimeoutException* while
running on JRE 11. This is likely caused by a [JDK bug present in JDK
11|https://bugs.openjdk.java.net/browse/JDK-8237858] (fixed in version 16) that
erroneously throws _SocketTimeoutException_ when _ServerSocket.accept()_ is
interrupted by any UNIX signal. The BlobServer calls _accept()_ when
establishing connections with clients and is expected to block indefinitely.
[The BlobServer currently shuts down when it catches a
Throwable|https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java#L267].
We do not see this behavior when running the same steps in JRE 8.
h3. Reproducing the issue
To reproduce, send a _SIGPIPE_ to the BlobServer _PID_. You will need to be
running a Flink cluster on JRE 11 and have tools _jps_ and _jstack_ available
to find the relevant pid.
One-liner:
{code:bash}
kill -SIGPIPE $(jstack $(jps -v | grep StandaloneApplicationClusterEntryPoint |
cut -f 1 -d ' ') | grep BLOB | awk '\{print $13}' | awk -F'[=]' '\{print $2}' |
xargs printf "%d")
{code}
# Run
{code:bash}
jstack [PID] | grep BLOB
{code}
where *PID* is the process ID of the job manager.
# Find the *nid=[HEX]* value and convert the HEX to decimal.
# Run
{code:bash}
kill -SIGPIPE [DNID]
{code}
where *DNID* is the converted decimal value of *HEX nid* from the previous step.
# Observe the following error in the job manager logs:
{noformat}
2021-09-03 09:56:12.517 [BLOB Server listener at 6124] ERROR
org.apache.flink.runtime.blob.BlobServer - BLOB server stopped working.
Shutting down
at java.base/java.net.PlainSocketImpl.socketAccept
at java.base/java.net.AbstractPlainSocketImpl.accept
at java.base/java.net.ServerSocket.implAccept
at java.base/java.net.ServerSocket.accept
at org.apache.flink.runtime.blob.BlobServer.run(BlobServer.java:266)
2021-09-03 09:56:12.527 [BLOB Server listener at 6124] INFO
org.apache.flink.runtime.blob.BlobServer - Stopped BLOB server at 0.0.0.0:6124
{noformat}
h3. Proposed Fix
To protect ourselves from this JDK bug, we propose the workaround of catching
_SocketTimeoutException_ and retrying the _ServerSocket.accept()_ call
indefinitely.
Thanks to [~bsanders-wf] for helping track this down.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] stevenzwu commented on a change in pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
stevenzwu commented on a change in pull request #17111:
URL: https://github.com/apache/flink/pull/17111#discussion_r702108667
##
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceEnumeratorStateSerializer.java
##
@@ -54,12 +44,9 @@ public int getVersion() {
try (ByteArrayOutputStream baos = new ByteArrayOutputStream();
DataOutputStream out = new DataOutputStream(baos)) {
out.writeInt(enumState.getCurrentSourceIndex());
-SimpleVersionedSerializer serializer =
-serializerOf(enumState.getCurrentSourceIndex());
-out.writeInt(serializer.getVersion());
-byte[] enumStateBytes =
serializer.serialize(enumState.getWrappedState());
-out.writeInt(enumStateBytes.length);
-out.write(enumStateBytes);
+out.writeInt(enumState.wrappedStateSerializerVersion());
+out.writeInt(enumState.getWrappedState().length);
Review comment:
@tweise I have thought about adding the optimization (of limiting the
number of splits) for streaming read in the future. for bounded job, we can't.
on the other hand, bounded job may not need to have checkpoint enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17126: [FLINK-24090][docs] Added Troubleshooting section with ignoring in-fl…
flinkbot edited a comment on pull request #17126: URL: https://github.com/apache/flink/pull/17126#issuecomment-911781874 ## CI report: * 6675abefda4deb11e7774014f77ad2f6280cd13d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23426) * 002396c2b89a35277bb192e9ec9ae00daeb0459f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17103: [FLINK-24069][tests] Fail IgnoreInFlightData test when there is not enough data for it for all checkpoints not only the first one
flinkbot edited a comment on pull request #17103: URL: https://github.com/apache/flink/pull/17103#issuecomment-910422814 ## CI report: * 15effce4e18b4b4b62b0eab352bab10a542379d5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23336) * 8e9b56137ccaf9a804e3e317db26096db3ef3f7c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17102: [FLINK-23960][streaming] checkScheduledTimestamps changed according to semantic of the calculation processing time delay
flinkbot edited a comment on pull request #17102: URL: https://github.com/apache/flink/pull/17102#issuecomment-910365614 ## CI report: * 81402821c3377da928cbe1dea5cd3c22b24abf1b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23391) * 7a88172bfdf610fe669d46a10fa62fe5db22f2b8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tweise commented on a change in pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
tweise commented on a change in pull request #17111:
URL: https://github.com/apache/flink/pull/17111#discussion_r702106135
##
File path:
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplitEnumeratorTest.java
##
@@ -147,11 +147,16 @@ public void
testHandleSplitRequestAfterSwitchAndReaderReset() {
assertThat(underlyingEnumeratorWrapper.handleSplitRequests,
Matchers.emptyIterable());
enumerator.handleSplitRequest(SUBTASK0, "fakehostname");
+HybridSourceSplitSerializer.SwitchedSources switchedSources =
+(HybridSourceSplitSerializer.SwitchedSources)
+Whitebox.getInternalState(enumerator,
"switchedSources");
+
Review comment:
Eliminated the need for that access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] tweise commented on a change in pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
tweise commented on a change in pull request #17111:
URL: https://github.com/apache/flink/pull/17111#discussion_r702105580
##
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceEnumeratorStateSerializer.java
##
@@ -54,12 +44,9 @@ public int getVersion() {
try (ByteArrayOutputStream baos = new ByteArrayOutputStream();
DataOutputStream out = new DataOutputStream(baos)) {
out.writeInt(enumState.getCurrentSourceIndex());
-SimpleVersionedSerializer serializer =
-serializerOf(enumState.getCurrentSourceIndex());
-out.writeInt(serializer.getVersion());
-byte[] enumStateBytes =
serializer.serialize(enumState.getWrappedState());
-out.writeInt(enumStateBytes.length);
-out.write(enumStateBytes);
+out.writeInt(enumState.wrappedStateSerializerVersion());
+out.writeInt(enumState.getWrappedState().length);
Review comment:
I also wonder if we would hit other issues with such large state
serialized in the coordinator? Can IcebergSource limit the number of splits it
keeps in the checkpoint and only add more once some have been processed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] tweise commented on a change in pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
tweise commented on a change in pull request #17111:
URL: https://github.com/apache/flink/pull/17111#discussion_r702102984
##
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplit.java
##
@@ -57,38 +69,64 @@ public boolean equals(Object o) {
return false;
}
HybridSourceSplit that = (HybridSourceSplit) o;
-return sourceIndex == that.sourceIndex &&
wrappedSplit.equals(that.wrappedSplit);
+return sourceIndex == that.sourceIndex
+&& Arrays.equals(wrappedSplitBytes, that.wrappedSplitBytes);
}
@Override
public int hashCode() {
-return Objects.hash(wrappedSplit, sourceIndex);
+return Objects.hash(wrappedSplitBytes, sourceIndex);
}
@Override
public String toString() {
return "HybridSourceSplit{"
+ "realSplit="
-+ wrappedSplit
++ wrappedSplitBytes
+ ", sourceIndex="
+ sourceIndex
Review comment:
Done. I also removed `wrappedSplitBytes` because it doesn't provide
meaningful information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] tweise commented on a change in pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
tweise commented on a change in pull request #17111:
URL: https://github.com/apache/flink/pull/17111#discussion_r702094970
##
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplit.java
##
@@ -57,38 +69,64 @@ public boolean equals(Object o) {
return false;
}
HybridSourceSplit that = (HybridSourceSplit) o;
-return sourceIndex == that.sourceIndex &&
wrappedSplit.equals(that.wrappedSplit);
+return sourceIndex == that.sourceIndex
+&& Arrays.equals(wrappedSplitBytes, that.wrappedSplitBytes);
Review comment:
Not needed because `splitId` is already part of `wrappedSplitBytes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] tweise commented on a change in pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
tweise commented on a change in pull request #17111:
URL: https://github.com/apache/flink/pull/17111#discussion_r702094543
##
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplit.java
##
@@ -19,33 +19,45 @@
package org.apache.flink.connector.base.source.hybrid;
import org.apache.flink.api.connector.source.SourceSplit;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import java.io.IOException;
import java.util.ArrayList;
+import java.util.Arrays;
import java.util.List;
import java.util.Objects;
/** Source split that wraps the actual split type. */
public class HybridSourceSplit implements SourceSplit {
-private final SourceSplit wrappedSplit;
+private final byte[] wrappedSplitBytes;
+private final int wrappedSplitSerializerVersion;
Review comment:
Considered that as well and prefer the verbose name to make clear that
this is the serializer version for the underlying state vs that of
`HybridSourceSplit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] tweise commented on a change in pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
tweise commented on a change in pull request #17111:
URL: https://github.com/apache/flink/pull/17111#discussion_r702094188
##
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceEnumeratorState.java
##
@@ -21,18 +21,25 @@
/** The state of hybrid source enumerator. */
public class HybridSourceEnumeratorState {
private final int currentSourceIndex;
-private final Object wrappedState;
+private byte[] wrappedStateBytes;
+private final int wrappedStateSerializerVersion;
Review comment:
Considered that as well and prefer the verbose name to make clear that
this is the serializer version for the underlying state vs that of
`HybridSourceEnumeratorState`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16865: [FLINK-23836][doc-zh]Translate "/dev/datastream/execution/execution_c…
flinkbot edited a comment on pull request #16865: URL: https://github.com/apache/flink/pull/16865#issuecomment-900450716 ## CI report: * b715167d64bffd32d57db1e047faa36b76a5babe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23519) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #17103: [FLINK-24069][tests] Fail IgnoreInFlightData test when there is not enough data for it for all checkpoints not only the first one
akalash commented on a change in pull request #17103: URL: https://github.com/apache/flink/pull/17103#discussion_r702079973 ## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java ## @@ -68,13 +70,15 @@ .build()); @Rule public final SharedObjects sharedObjects = SharedObjects.create(); +@Rule public Timeout timeout = new Timeout(30, TimeUnit.SECONDS); Review comment: Ok, I have removed commit with timeotu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17000: [FLINK-23946][clients] Application mode should shutdown gracefully on…
flinkbot edited a comment on pull request #17000: URL: https://github.com/apache/flink/pull/17000#issuecomment-906394364 ## CI report: * 15d30aac920aebb42c8f437972f38e10dce5aa7b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23322) * 2c738ac974ca8873f142279cfce6e8a8659c370f UNKNOWN * 49eba9e46aa029bffa4c8df1786e3942fae678cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23521) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17140: [hotfix][docs] Try Flink Improvements
flinkbot edited a comment on pull request #17140: URL: https://github.com/apache/flink/pull/17140#issuecomment-912563200 ## CI report: * 206206faef5e0c5af500f92cd77b67ec181354d5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23514) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17137: [FLINK-21853][e2e] Harden common_ha.sh#ha_tm_watchdog
flinkbot edited a comment on pull request #17137: URL: https://github.com/apache/flink/pull/17137#issuecomment-912545933 ## CI report: * c8c132cb9688244505ed35ad1e61a42db5c8a1ab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23508) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17139: [BP-1.13][FLINK-21853][e2e] Harden common_ha.sh#ha_tm_watchdog
flinkbot edited a comment on pull request #17139: URL: https://github.com/apache/flink/pull/17139#issuecomment-912546148 ## CI report: * 777d90a47aa243f9b6fa4a5de8dcf15fc8e4fa40 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23510) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17141: Revert "[FLINK-22770][docs] Update usage of SET in docs to use quotes"
flinkbot edited a comment on pull request #17141: URL: https://github.com/apache/flink/pull/17141#issuecomment-912590106 ## CI report: * 35581d67069db4a2403fb37e73f2a40173b2779b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23516) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17000: [FLINK-23946][clients] Application mode should shutdown gracefully on…
flinkbot edited a comment on pull request #17000: URL: https://github.com/apache/flink/pull/17000#issuecomment-906394364 ## CI report: * 15d30aac920aebb42c8f437972f38e10dce5aa7b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23322) * 2c738ac974ca8873f142279cfce6e8a8659c370f UNKNOWN * 49eba9e46aa029bffa4c8df1786e3942fae678cc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] nicolasraga1 edited a comment on pull request #16946: [FLINK-23654][runtime] Splitting IO and future threadpools and adding advanced configurations
nicolasraga1 edited a comment on pull request #16946: URL: https://github.com/apache/flink/pull/16946#issuecomment-912299502 Oh I missed that you were going to address your own comments! I have already made the changes as well : ). I'll update with changes made from your comments! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] nicolasraga1 edited a comment on pull request #16946: [FLINK-23654][runtime] Splitting IO and future threadpools and adding advanced configurations
nicolasraga1 edited a comment on pull request #16946: URL: https://github.com/apache/flink/pull/16946#issuecomment-912299502 Oh I missed that you were going to address your own commets! I have already made the changes already as well : ). I'll update with changes made from your comments! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17142: [FLINK-24148] Add bloom filter option in RocksDBConfiguredOptions
flinkbot edited a comment on pull request #17142: URL: https://github.com/apache/flink/pull/17142#issuecomment-912651118 ## CI report: * 27b71d7c937e087f515908b5575852a14c0bcdd0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23520) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17138: [BP-1.14][FLINK-21853][e2e] Harden common_ha.sh#ha_tm_watchdog
flinkbot edited a comment on pull request #17138: URL: https://github.com/apache/flink/pull/17138#issuecomment-912546041 ## CI report: * 2fe1214aa91b0e4016bae9d213187fcae3136f8a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23509) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17000: [FLINK-23946][clients] Application mode should shutdown gracefully on…
flinkbot edited a comment on pull request #17000: URL: https://github.com/apache/flink/pull/17000#issuecomment-906394364 ## CI report: * 15d30aac920aebb42c8f437972f38e10dce5aa7b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23322) * 2c738ac974ca8873f142279cfce6e8a8659c370f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] hililiwei commented on a change in pull request #17142: [FLINK-24148] Add bloom filter option in RocksDBConfiguredOptions
hililiwei commented on a change in pull request #17142:
URL: https://github.com/apache/flink/pull/17142#discussion_r702022015
##
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/DefaultConfigurableOptionsFactory.java
##
@@ -156,6 +158,15 @@ public ColumnFamilyOptions createColumnOptions(
blockBasedTableConfig.setBlockCacheSize(getBlockCacheSize());
}
+if (isOptionConfigured(USE_BLOOM_FILTER)) {
+final boolean enabled =
Boolean.parseBoolean(getInternal(USE_BLOOM_FILTER.key()));
+if (enabled) {
+BloomFilter bloomFilter = new BloomFilter();
Review comment:
Can provide an option to allow users to set the value of bitsperkey？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] dmvk commented on a change in pull request #17000: [FLINK-23946][clients] Application mode should shutdown gracefully on…
dmvk commented on a change in pull request #17000:
URL: https://github.com/apache/flink/pull/17000#discussion_r702022088
##
File path:
flink-clients/src/test/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrapTest.java
##
@@ -386,59 +385,85 @@ public void
testApplicationIsStoppedWhenStoppingBootstrap() throws Exception {
bootstrap.stop();
-// we call the error handler
-assertException(errorHandlerFuture, CancellationException.class);
+// we didn't call the error handler
+assertFalse(errorHandlerFuture.isDone());
-// we return a future that is completed exceptionally
-assertException(shutdownFuture, CancellationException.class);
+// shutdown future gets completed normally
+shutdownFuture.get();
+
+// verify that we didn't shut down the cluster
+assertFalse(shutdownCalled.get());
// verify that the application task is being cancelled
assertThat(applicationExecutionFuture.isCancelled(), is(true));
+assertThat(applicationExecutionFuture.isDone(), is(true));
}
@Test
-public void testErrorHandlerIsCalledWhenStoppingBootstrap() throws
Exception {
+public void testClusterIsShutdownCalledWhenSubmissionThrowsAnException()
throws Exception {
Review comment:
Thanks, I've missed this one Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17142: [FLINK-24148] Add bloom filter option in RocksDBConfiguredOptions
flinkbot commented on pull request #17142: URL: https://github.com/apache/flink/pull/17142#issuecomment-912651118 ## CI report: * 27b71d7c937e087f515908b5575852a14c0bcdd0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17123: [FLINK-24096][checkpoint] Skip the complete notification for checkpoints before task startup
flinkbot edited a comment on pull request #17123: URL: https://github.com/apache/flink/pull/17123#issuecomment-911684941 ## CI report: * 9fb75a2cb7ee8b79e49b2ca23a1ddd5a71866f64 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23504) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23476) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16865: [FLINK-23836][doc-zh]Translate "/dev/datastream/execution/execution_c…
flinkbot edited a comment on pull request #16865: URL: https://github.com/apache/flink/pull/16865#issuecomment-900450716 ## CI report: * cdc22b558456e9aec9691352768440ca594994d9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23384) * b715167d64bffd32d57db1e047faa36b76a5babe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23519) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (FLINK-23822) Test config state ttl in Python DataStream API
[ https://issues.apache.org/jira/browse/FLINK-23822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-23822. -- Resolution: Fixed > Test config state ttl in Python DataStream API > -- > > Key: FLINK-23822 > URL: https://issues.apache.org/jira/browse/FLINK-23822 > Project: Flink > Issue Type: Improvement > Components: API / Python >Reporter: Huang Xingbo >Assignee: Yun Tang >Priority: Blocker > Labels: release-testing > Fix For: 1.14.0 > > > The newly feature allows users to config the state ttl in Python DataStream > API. > In order to test this new feature I recommend to follow the documentation[1] > [1] > https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/datastream/fault-tolerance/state/#state-time-to-live-ttl -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-23822) Test config state ttl in Python DataStream API
[ https://issues.apache.org/jira/browse/FLINK-23822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409585#comment-17409585 ] Yun Tang commented on FLINK-23822: -- Verify the state TTL in python API via docs. Found two problems and created related sub-tasks. After resolved all problems, it proved to work as expected on both HashMapStateBackend and EmbeddedRocksDBStateBackend. > Test config state ttl in Python DataStream API > -- > > Key: FLINK-23822 > URL: https://issues.apache.org/jira/browse/FLINK-23822 > Project: Flink > Issue Type: Improvement > Components: API / Python >Reporter: Huang Xingbo >Assignee: Yun Tang >Priority: Blocker > Labels: release-testing > Fix For: 1.14.0 > > > The newly feature allows users to config the state ttl in Python DataStream > API. > In order to test this new feature I recommend to follow the documentation[1] > [1] > https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/datastream/fault-tolerance/state/#state-time-to-live-ttl -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] stevenzwu commented on a change in pull request #17111: [FLINK-24064][connector/common] HybridSource restore from savepoint
stevenzwu commented on a change in pull request #17111:
URL: https://github.com/apache/flink/pull/17111#discussion_r70270
##
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/SwitchedSources.java
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.source.hybrid;
+
+import org.apache.flink.api.connector.source.Source;
+import org.apache.flink.api.connector.source.SourceSplit;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import org.apache.flink.util.Preconditions;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/** Sources that participated in switching with cached serializers. */
+class SwitchedSources {
+private final Map sources = new HashMap<>();
+private final Map>
cachedSerializers =
+new HashMap<>();
+
+public Source sourceOf(int sourceIndex) {
+return Preconditions.checkNotNull(
+sources.get(sourceIndex), "Source for index=%s not available",
sourceIndex);
+}
+
+public SimpleVersionedSerializer serializerOf(int
sourceIndex) {
+return cachedSerializers.computeIfAbsent(
Review comment:
I see. Originally I was imagining the singleton pattern from file
source. Then this caching is not necessary.
```
@Override
public SimpleVersionedSerializer getSplitSerializer() {
return FileSourceSplitSerializer.INSTANCE;
}
```
I guess it depends on the implementation. Some source impls may construct a
new object in this method and hence this caching might be beneficial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17136: [FLINK-24149][runtime][checkpoint] Make checkpoint relocatable
flinkbot edited a comment on pull request #17136: URL: https://github.com/apache/flink/pull/17136#issuecomment-912480698 ## CI report: * 1a599eb022078bc22dc3d8369f8f63e79b632bda Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23505) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16865: [FLINK-23836][doc-zh]Translate "/dev/datastream/execution/execution_c…
flinkbot edited a comment on pull request #16865: URL: https://github.com/apache/flink/pull/16865#issuecomment-900450716 ## CI report: * cdc22b558456e9aec9691352768440ca594994d9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23384) * b715167d64bffd32d57db1e047faa36b76a5babe UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17142: [FLINK-24148] Add bloom filter option in RocksDBConfiguredOptions
flinkbot commented on pull request #17142: URL: https://github.com/apache/flink/pull/17142#issuecomment-912625103 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 27b71d7c937e087f515908b5575852a14c0bcdd0 (Fri Sep 03 15:32:44 UTC 2021) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-24148) Add bloom filter policy option in RocksDBConfiguredOptions
[ https://issues.apache.org/jira/browse/FLINK-24148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24148: --- Labels: pull-request-available (was: ) > Add bloom filter policy option in RocksDBConfiguredOptions > -- > > Key: FLINK-24148 > URL: https://issues.apache.org/jira/browse/FLINK-24148 > Project: Flink > Issue Type: Improvement > Components: Runtime / State Backends >Affects Versions: 1.13.2, 1.14.1 >Reporter: Jiayi Liao >Assignee: Jiayi Liao >Priority: Minor > Labels: pull-request-available > > Bloom filter can efficiently enhance the read on RocksDB, especially for the > reading among L0 files. (more details see > https://github.com/facebook/rocksdb/wiki/RocksDB-Bloom-Filter) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] Jiayi-Liao opened a new pull request #17142: [FLINK-24148] Add bloom filter option in RocksDBConfiguredOptions
Jiayi-Liao opened a new pull request #17142: URL: https://github.com/apache/flink/pull/17142 ## What is the purpose of the change This change provides bloom filter option in `RocksDBConfigurableOptions`. (more details see https://github.com/facebook/rocksdb/wiki/RocksDB-Bloom-Filter) ## Brief change log * Add a bloom filter option in `RocksDBConfigurableOptions`. ## Verifying this change `RocksDBStateBackendConfigTest` help to verify the legality. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? yes - If yes, how is the feature documented? docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] hapihu commented on a change in pull request #16865: [FLINK-23836][doc-zh]Translate "/dev/datastream/execution/execution_c…
hapihu commented on a change in pull request #16865:
URL: https://github.com/apache/flink/pull/16865#discussion_r701969182
##
File path:
docs/content.zh/docs/dev/datastream/execution/execution_configuration.md
##
@@ -45,46 +45,45 @@ var executionConfig = env.getConfig
{{< /tab >}}
{{< /tabs >}}
-The following configuration options are available: (the default is bold)
+以下是可用的配置选项：（默认为粗体）
-- `setClosureCleanerLevel()`. The closure cleaner level is set to
`ClosureCleanerLevel.RECURSIVE` by default. The closure cleaner removes
unneeded references to the surrounding class of anonymous functions inside
Flink programs.
-With the closure cleaner disabled, it might happen that an anonymous user
function is referencing the surrounding class, which is usually not
Serializable. This will lead to exceptions by the serializer. The settings are:
-`NONE`: disable the closure cleaner completely, `TOP_LEVEL`: clean only the
top-level class without recursing into fields, `RECURSIVE`: clean all the
fields recursively.
+- `setClosureCleanerLevel()`。closure cleaner 的级别默认设置为
`ClosureCleanerLevel.RECURSIVE`。closure cleaner 删除 Flink 程序中对匿名 function
的调用类的不必要引用。禁用 closure cleaner 后，用户的匿名 function
可能正引用一些不可序列化的调用类。这将导致序列化器出现异常。可设置的值是：
+`NONE`：完全禁用 closure cleaner ，`TOP_LEVEL`：只清理顶级类而不递归到字段中，`RECURSIVE`：递归清理所有字段。
-- `getParallelism()` / `setParallelism(int parallelism)` Set the default
parallelism for the job.
+- `getParallelism()` / `setParallelism(int parallelism)`。为作业设置默认的并行度。
-- `getMaxParallelism()` / `setMaxParallelism(int parallelism)` Set the default
maximum parallelism for the job. This setting determines the maximum degree of
parallelism and specifies the upper limit for dynamic scaling.
+- `getMaxParallelism()` / `setMaxParallelism(int
parallelism)`。为作业设置默认的最大并行度。此设置决定最大并行度并指定动态缩放的上限。
-- `getNumberOfExecutionRetries()` / `setNumberOfExecutionRetries(int
numberOfExecutionRetries)` Sets the number of times that failed tasks are
re-executed. A value of zero effectively disables fault tolerance. A value of
`-1` indicates that the system default value (as defined in the configuration)
should be used. This is deprecated, use [restart strategies]({{< ref
"docs/ops/state/task_failure_recovery" >}}#restart-strategies) instead.
+- `getNumberOfExecutionRetries()` / `setNumberOfExecutionRetries(int
numberOfExecutionRetries)`。设置失败任务重新执行的次数。值为零会有效地禁用容错。`-1`
表示使用系统默认值（在配置中定义）。该配置已弃用，请改用[重启策略]({{< ref
"docs/ops/state/task_failure_recovery" >}}#restart-strategies) 。
-- `getExecutionRetryDelay()` / `setExecutionRetryDelay(long
executionRetryDelay)` Sets the delay in milliseconds that the system waits
after a job has failed, before re-executing it. The delay starts after all
tasks have been successfully stopped on the TaskManagers, and once the delay is
past, the tasks are re-started. This parameter is useful to delay re-execution
in order to let certain time-out related failures surface fully (like broken
connections that have not fully timed out), before attempting a re-execution
and immediately failing again due to the same problem. This parameter only has
an effect if the number of execution re-tries is one or more. This is
deprecated, use [restart strategies]({{< ref
"docs/ops/state/task_failure_recovery" >}}#restart-strategies) instead.
+- `getExecutionRetryDelay()` / `setExecutionRetryDelay(long
executionRetryDelay)`。设置系统在作业失败后重新执行之前等待的延迟（以毫秒为单位）。在 TaskManagers
上成功停止所有任务后，开始计算延迟，一旦延迟过去，任务会被重新启动。此参数对于延迟重新执行很有用，以便在尝试重新执行并由于相同的问题立即再次失败之前，让某些超时相关的故障完全浮出水面（例如尚未完全超时的断开连接）。此参数仅在执行重试次数为一次或多次时有效。该配置已被弃用，请改用[重启策略]({{<
ref "docs/ops/state/task_failure_recovery" >}}#restart-strategies) 。
-- `getExecutionMode()` / `setExecutionMode()`. The default execution mode is
PIPELINED. Sets the execution mode to execute the program. The execution mode
defines whether data exchanges are performed in a batch or on a pipelined
manner.
+- `getExecutionMode()` / `setExecutionMode()`。默认的执行模式是
PIPELINED。设置执行模式以执行程序。执行模式定义了数据交换是以批处理方式还是以流方式执行。
-- `enableForceKryo()` / **`disableForceKryo`**. Kryo is not forced by default.
Forces the GenericTypeInformation to use the Kryo serializer for POJOs even
though we could analyze them as a POJO. In some cases this might be preferable.
For example, when Flink's internal serializers fail to handle a POJO properly.
+- `enableForceKryo()` / **`disableForceKryo`**。默认情况下不强制使用 Kryo。强制
GenericTypeInformation 对 POJO 使用 Kryo 序列化器，即使我们可以将它们作为 POJO
进行分析。在某些情况下，这可能更可取。例如，当 Flink 的内部序列化器无法正确处理 POJO 时。
Review comment:
I thought about it.How about the following translation ?
```txt
在某些情况下这样配置可能更可取。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (FLINK-24152) Exactly-once semantics should be configurable through Flink configuration only
[ https://issues.apache.org/jira/browse/FLINK-24152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409546#comment-17409546 ] Seth Wiesman edited comment on FLINK-24152 at 9/3/21, 3:12 PM: --- +1 There is a fairly large caveats section for exactly once writes to Kafka, but if we can come up with sensible defaults I think this would be a huge win. [https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/connectors/datastream/kafka/#caveats] was (Author: sjwiesman): +1 There is a fairly large caveats section for exactly once writes to Kafka, but if we can come up with sensible defaults I think this would be a huge win. I also wonder if this should be the default for all connectors that support exactly-once writes; JDBC today and pulsar (I think in 1.15). https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/connectors/datastream/kafka/#caveats > Exactly-once semantics should be configurable through Flink configuration only > -- > > Key: FLINK-24152 > URL: https://issues.apache.org/jira/browse/FLINK-24152 > Project: Flink > Issue Type: Improvement > Components: API / Core, Connectors / Common >Reporter: Matthias >Priority: Major > > Exactly-once constraint needs to be configured in multiple locations: > 1. Flink configuration > 2. Kafka connector configuration > As a user, I would expect to set this configuration parameter in Flink. The > Kafka connector should be able to derive this configuration parameter from > the Flink configuration by default. Setting it on the connector level could > be considered as an advanced configuration parameter which would overwrite > the default configuration. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] hapihu commented on a change in pull request #16865: [FLINK-23836][doc-zh]Translate "/dev/datastream/execution/execution_c…
hapihu commented on a change in pull request #16865:
URL: https://github.com/apache/flink/pull/16865#discussion_r701966309
##
File path:
docs/content.zh/docs/dev/datastream/execution/execution_configuration.md
##
@@ -45,46 +45,45 @@ var executionConfig = env.getConfig
{{< /tab >}}
{{< /tabs >}}
-The following configuration options are available: (the default is bold)
+以下是可用的配置选项：（默认为粗体）
-- `setClosureCleanerLevel()`. The closure cleaner level is set to
`ClosureCleanerLevel.RECURSIVE` by default. The closure cleaner removes
unneeded references to the surrounding class of anonymous functions inside
Flink programs.
-With the closure cleaner disabled, it might happen that an anonymous user
function is referencing the surrounding class, which is usually not
Serializable. This will lead to exceptions by the serializer. The settings are:
-`NONE`: disable the closure cleaner completely, `TOP_LEVEL`: clean only the
top-level class without recursing into fields, `RECURSIVE`: clean all the
fields recursively.
+- `setClosureCleanerLevel()`。closure cleaner 的级别默认设置为
`ClosureCleanerLevel.RECURSIVE`。closure cleaner 删除 Flink 程序中对匿名 function
的调用类的不必要引用。禁用 closure cleaner 后，用户的匿名 function
可能正引用一些不可序列化的调用类。这将导致序列化器出现异常。可设置的值是：
+`NONE`：完全禁用 closure cleaner ，`TOP_LEVEL`：只清理顶级类而不递归到字段中，`RECURSIVE`：递归清理所有字段。
-- `getParallelism()` / `setParallelism(int parallelism)` Set the default
parallelism for the job.
+- `getParallelism()` / `setParallelism(int parallelism)`。为作业设置默认的并行度。
-- `getMaxParallelism()` / `setMaxParallelism(int parallelism)` Set the default
maximum parallelism for the job. This setting determines the maximum degree of
parallelism and specifies the upper limit for dynamic scaling.
+- `getMaxParallelism()` / `setMaxParallelism(int
parallelism)`。为作业设置默认的最大并行度。此设置决定最大并行度并指定动态缩放的上限。
-- `getNumberOfExecutionRetries()` / `setNumberOfExecutionRetries(int
numberOfExecutionRetries)` Sets the number of times that failed tasks are
re-executed. A value of zero effectively disables fault tolerance. A value of
`-1` indicates that the system default value (as defined in the configuration)
should be used. This is deprecated, use [restart strategies]({{< ref
"docs/ops/state/task_failure_recovery" >}}#restart-strategies) instead.
+- `getNumberOfExecutionRetries()` / `setNumberOfExecutionRetries(int
numberOfExecutionRetries)`。设置失败任务重新执行的次数。值为零会有效地禁用容错。`-1`
表示使用系统默认值（在配置中定义）。该配置已弃用，请改用[重启策略]({{< ref
"docs/ops/state/task_failure_recovery" >}}#restart-strategies) 。
-- `getExecutionRetryDelay()` / `setExecutionRetryDelay(long
executionRetryDelay)` Sets the delay in milliseconds that the system waits
after a job has failed, before re-executing it. The delay starts after all
tasks have been successfully stopped on the TaskManagers, and once the delay is
past, the tasks are re-started. This parameter is useful to delay re-execution
in order to let certain time-out related failures surface fully (like broken
connections that have not fully timed out), before attempting a re-execution
and immediately failing again due to the same problem. This parameter only has
an effect if the number of execution re-tries is one or more. This is
deprecated, use [restart strategies]({{< ref
"docs/ops/state/task_failure_recovery" >}}#restart-strategies) instead.
+- `getExecutionRetryDelay()` / `setExecutionRetryDelay(long
executionRetryDelay)`。设置系统在作业失败后重新执行之前等待的延迟（以毫秒为单位）。在 TaskManagers
上成功停止所有任务后，开始计算延迟，一旦延迟过去，任务会被重新启动。此参数对于延迟重新执行很有用，以便在尝试重新执行并由于相同的问题立即再次失败之前，让某些超时相关的故障完全浮出水面（例如尚未完全超时的断开连接）。此参数仅在执行重试次数为一次或多次时有效。该配置已被弃用，请改用[重启策略]({{<
ref "docs/ops/state/task_failure_recovery" >}}#restart-strategies) 。
Review comment:
I thought about it. How about the following translation?
```txt
此参数对于延迟重新执行的场景很有用，当尝试重新执行作业时，由于相同的问题，作业会立刻再次失败，该参数便于作业再次失败之前让某些超时相关的故障完全浮出水面（例如尚未完全超时的断开连接）。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] infoverload commented on a change in pull request #16871: [FLINK-23832][docs] Update DataStream API Integration page
infoverload commented on a change in pull request #16871:
URL: https://github.com/apache/flink/pull/16871#discussion_r701960875
##
File path: docs/content/docs/dev/table/data_stream_api.md
##
@@ -725,11 +732,17 @@ to an insert-only changelog stream.
{{< hint info >}}
Since batch processing can be considered as *a special case of stream
processing*, we recommend implementing
a streaming pipeline first as it is the most general implementation for both
bounded and unbounded data.
+
+In theory, a streaming pipeline can execute all operators. However, in
practice, some operations might
+not make much sense as they would lead to ever-growing state and are therefore
not supported. A global
+sort would be an example that is only available in batch mode. Simply put: it
should be possible to
+run a working streaming pipeline in batch and but not necessarily vice versa.
Review comment:
```suggestion
run a working streaming pipeline in batch mode but not necessarily vice
versa.
```
##
File path: docs/content/docs/dev/table/data_stream_api.md
##
@@ -2695,7 +2708,7 @@ correctly via the DataStream API's reflective type
extraction facilities. If the
schema.
{{< hint warning >}}
-Many times the DataStream API is unable to extract a more specific
`TypeInformation` based on reflection.
+Many times the DataStream API is unable to extract a more specific
`TypeInformation` based on
[reflection](https://www.oracle.com/technical-resources/articles/java/javareflection.html).
Review comment:
```suggestion
The DataStream API is not always able to extract a more specific
`TypeInformation` based on
[reflection](https://www.oracle.com/technical-resources/articles/java/javareflection.html).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17141: Revert "[FLINK-22770][docs] Update usage of SET in docs to use quotes"
flinkbot edited a comment on pull request #17141: URL: https://github.com/apache/flink/pull/17141#issuecomment-912590106 ## CI report: * 35581d67069db4a2403fb37e73f2a40173b2779b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23516) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
