[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1248008592
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
> Another way is flink keep commons-collections 3.x remained and add
commons-collections4. then kafka connector in this repo update to
commons-collections4 (just replace package name, no dependency import), and
flink remove commons-collections 3.x. it's
[flink-side](https://issues.apache.org/jira/browse/FLINK-side) solution. what
do u think?
@MartijnVisser Whether we can keep these 2 versions in flink temporarily?
In fact, spark also encounters similar problems (but not reference loop),
and currently two versions coexist.
https://github.com/apache/spark/pull/35257
https://github.com/apache/spark/pull/36009/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1248008592
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
> Another way is flink keep commons-collections 3.x remained and add
commons-collections4. then kafka connector in this repo update to
commons-collections4 (just replace package name, no dependency import), and
flink remove commons-collections 3.x. it's
[flink-side](https://issues.apache.org/jira/browse/FLINK-side) solution. what
do u think?
@MartijnVisser Whether we can keep these 2 version in flink temporarily?
In fact, spark also encounters similar problems (but not reference loop),
and currently two versions coexist.
https://github.com/apache/spark/pull/35257
https://github.com/apache/spark/pull/36009/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1247988699
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
@MartijnVisser understand this, but now it'a circular.
flink-python test case in flink reference flink-sql-connector-kafka（not uber
jar, without commons-collections class）, so search it in flink and cause
ClassNotFoundException.
And this kafka connector also reference flink-core.
Must break circular references from one side. Then it will be removed when
flink update finished.
Is there a better way？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1247988699
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
@MartijnVisser understand this, but now it'a circular.
flink-python test case in flink reference flink-sql-connector-kafka（not uber
jar, without commons-collections class）, so search it in flink and cause
ClassNotFoundException.
And this kafka connector also reference flink-core.
Must break circular references from side. Then it will be removed when flink
update finished.
Is there a better way？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r124799
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
Another way is flink keep commons-collections 3.x remained and add
commons-collections4.
then kafka connector in this repo update to commons-collections4 (just
replace package name, no dependency import), and flink remove
commons-collections 3.x. it's flink-side solution. what do u think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r124799
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
Another way is flink keep commons-collections 3.x remained and add
commons-collections4.
then kafka connector in this repo update to commons-collections4 (just
replace package name, no dependency import), and flink remove
commons-collections 3.x. it's flink-side way. what do u think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r124799
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
Another way is flink keep commons-collections 3.x remained and add
commons-collections4.
then kafka connector in this repo update to commons-collections4 (just
replace package name, no dependency), and flink remove commons-collections 3.x.
it's flink-side way. what do u think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r124799
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
Another way is flink keep commons-collections 3.x remained and add
commons-collections4.
then kafka connector in this repo update to commons-collections4, and flink
remove commons-collections 3.x. it's flink-side way. what do u think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1247988699
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
@MartijnVisser it will be removed when flink update finished. Now it'a
circular.
flink-python test case in flink reference flink-sql-connector-kafka（not uber
jar, without commons-collections class）, so search it in flink and cause
ClassNotFoundException.
And this kafka connector also reference flink-core.
Must break circular references from side. Is there a better way？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
