[GitHub] flink pull request: [FLINK-2694] [test-stability] Hardens the JobM...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1145


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2694] [test-stability] Hardens the JobM...

[uce]

Github user uce commented on the pull request:

https://github.com/apache/flink/pull/1145#issuecomment-142553329
  
This is more robust, because Akka has retry loop when trying to bind to the 
randomly picked port, right? The change looks good and works fine. +1

Optional: I would add two comments to test: one that the log4j log level 
needs to be >= INFO and that the log message needs to be "Starting 
JobManager...". If one of these two things changes, the test will not work 
anymore and it might be helpful for debugging if it every happens.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2694] [test-stability] Hardens the JobM...

[tillrohrmann]

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/1145#issuecomment-142554024
  
I think that the Akka will just randomly pick a free port. Thus, there is 
no need for retrying.

I'll add the comments to the test. That's a good point :-)

Merging this then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2694] [test-stability] Hardens the JobM...

[uce]

Github user uce commented on the pull request:

https://github.com/apache/flink/pull/1145#issuecomment-142554920
  
Ah yeah they directly bind the socket :D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2694] [test-stability] Hardens the JobM...

[tillrohrmann]

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/1145#issuecomment-141923403
  
Failing test case is 
`org.apache.flink.yarn.YARNSessionFIFOITCase.testJavaAPI` and, thus, unrelated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2694] [test-stability] Hardens the JobM...

[tillrohrmann]

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/1145

[FLINK-2694] [test-stability] Hardens the 
JobManagerProcessReapingTest.testReapProcessOnFailure test case

The `JobManagerProcessReapingTest.testReapProcessOnFailure` predetermines 
the port for the `JobManager` which is started by using 
`NetUtils.getAvailablePort`. This can cause problems if in the meantime another 
process has opened a socket binding to this port. In order to harden this test 
case, the `JobManager` is now allowed to pick itself a free port. The selected 
port is extracted from the logging output of the `JobManager`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink 
fixJobManagerProcessReapingTest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1145


commit 4332b8e8aafd43f766be5357e505297322d109c7
Author: Till Rohrmann 
Date:   2015-09-18T13:49:24Z

[FLINK-2694] [test-stability] Hardens the 
JobManagerProcessReapingTest.testReapProcessOnFailure test case by letting the 
JobManager choose its port instead of predetermining it via the 
NetUtils.getAvailablePort.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---