[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704606#comment-16704606 ] ASF GitHub Bot commented on FLINK-11015: yanghua commented on a change in pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#discussion_r237829660 ## File path: flink-connectors/flink-connector-kafka-base/pom.xml ## @@ -44,12 +44,6 @@ under the License. - Review comment: OK. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated methods and classes about table from all the Kafka > connectors > --- > > Key: FLINK-11015 > URL: https://issues.apache.org/jira/browse/FLINK-11015 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > This is to make the "Disentangle flink-connector-kafka from flink-table and > flink-json" (FLINK-9461) plan more smoothly. For more details, please refer > to the discussion of FLINK-9461. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704592#comment-16704592 ] ASF GitHub Bot commented on FLINK-11015: twalthr commented on a change in pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#discussion_r237827433 ## File path: flink-connectors/flink-connector-kafka-base/pom.xml ## @@ -44,12 +44,6 @@ under the License. - Review comment: We need to reintroduce this dependency as `org.apache.flink.streaming.util.serialization.JSONKeyValueDeserializationSchema` still requires Jackson. I discussed this with Chesnay. I will reintroduce it while merging. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated methods and classes about table from all the Kafka > connectors > --- > > Key: FLINK-11015 > URL: https://issues.apache.org/jira/browse/FLINK-11015 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > This is to make the "Disentangle flink-connector-kafka from flink-table and > flink-json" (FLINK-9461) plan more smoothly. For more details, please refer > to the discussion of FLINK-9461. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704325#comment-16704325 ] ASF GitHub Bot commented on FLINK-11015: yanghua commented on issue #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#issuecomment-443107227 @twalthr Let's merge this PR? thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated methods and classes about table from all the Kafka > connectors > --- > > Key: FLINK-11015 > URL: https://issues.apache.org/jira/browse/FLINK-11015 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > This is to make the "Disentangle flink-connector-kafka from flink-table and > flink-json" (FLINK-9461) plan more smoothly. For more details, please refer > to the discussion of FLINK-9461. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702905#comment-16702905 ] ASF GitHub Bot commented on FLINK-11015: zentol commented on issue #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#issuecomment-442763346 +1 to the pom changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated methods and classes about table from all the Kafka > connectors > --- > > Key: FLINK-11015 > URL: https://issues.apache.org/jira/browse/FLINK-11015 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > This is to make the "Disentangle flink-connector-kafka from flink-table and > flink-json" (FLINK-9461) plan more smoothly. For more details, please refer > to the discussion of FLINK-9461. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702916#comment-16702916 ] ASF GitHub Bot commented on FLINK-11015: twalthr commented on issue #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#issuecomment-442765466 Thank you @zentol. I will take care of merging this... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated methods and classes about table from all the Kafka > connectors > --- > > Key: FLINK-11015 > URL: https://issues.apache.org/jira/browse/FLINK-11015 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > This is to make the "Disentangle flink-connector-kafka from flink-table and > flink-json" (FLINK-9461) plan more smoothly. For more details, please refer > to the discussion of FLINK-9461. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[
https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702914#comment-16702914
]
ASF GitHub Bot commented on FLINK-11015:
twalthr commented on a change in pull request #7182: [FLINK-11015] Remove
deprecated methods and classes about table from all the Kafka connectors
URL: https://github.com/apache/flink/pull/7182#discussion_r237408152
##
File path: flink-connectors/flink-connector-kafka-0.10/pom.xml
##
@@ -86,40 +86,8 @@ under the License.
true
-
- org.apache.flink
- flink-avro
- ${project.version}
-
- true
-
-
-
- org.apache.flink
- flink-json
- ${project.version}
-
- true
-
-
-
- org.apache.flink
- flink-avro
- ${project.version}
- test
- test-jar
-
-
-
- org.apache.flink
- flink-json
- ${project.version}
- test-jar
Review comment:
@yanghua I'm waiting for the OK from @zentol. Dependency changes should
always be reviewed by a couple of people.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove deprecated methods and classes about table from all the Kafka
> connectors
> ---
>
> Key: FLINK-11015
> URL: https://issues.apache.org/jira/browse/FLINK-11015
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
> Labels: pull-request-available
>
> This is to make the "Disentangle flink-connector-kafka from flink-table and
> flink-json" (FLINK-9461) plan more smoothly. For more details, please refer
> to the discussion of FLINK-9461.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702802#comment-16702802 ] ASF GitHub Bot commented on FLINK-11015: yanghua commented on issue #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#issuecomment-442730853 @twalthr Any other changes? If not, I look forward to merging it as soon as possible to advance FLINK-9461. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated methods and classes about table from all the Kafka > connectors > --- > > Key: FLINK-11015 > URL: https://issues.apache.org/jira/browse/FLINK-11015 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > This is to make the "Disentangle flink-connector-kafka from flink-table and > flink-json" (FLINK-9461) plan more smoothly. For more details, please refer > to the discussion of FLINK-9461. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[
https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702017#comment-16702017
]
ASF GitHub Bot commented on FLINK-11015:
yanghua commented on a change in pull request #7182: [FLINK-11015] Remove
deprecated methods and classes about table from all the Kafka connectors
URL: https://github.com/apache/flink/pull/7182#discussion_r237131756
##
File path: flink-connectors/flink-connector-kafka-0.10/pom.xml
##
@@ -86,40 +86,8 @@ under the License.
true
-
- org.apache.flink
- flink-avro
- ${project.version}
-
- true
-
-
-
- org.apache.flink
- flink-json
- ${project.version}
-
- true
-
-
-
- org.apache.flink
- flink-avro
- ${project.version}
- test
- test-jar
-
-
-
- org.apache.flink
- flink-json
- ${project.version}
- test-jar
Review comment:
My own Travis has turned green (Can not make sure if you can see this
[link](https://travis-ci.org/yanghua/flink/builds/460738230)). OK, It would be
better to wait and see Travis's result to verify the judgment.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove deprecated methods and classes about table from all the Kafka
> connectors
> ---
>
> Key: FLINK-11015
> URL: https://issues.apache.org/jira/browse/FLINK-11015
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
> Labels: pull-request-available
>
> This is to make the "Disentangle flink-connector-kafka from flink-table and
> flink-json" (FLINK-9461) plan more smoothly. For more details, please refer
> to the discussion of FLINK-9461.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[
https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702014#comment-16702014
]
ASF GitHub Bot commented on FLINK-11015:
yanghua commented on a change in pull request #7182: [FLINK-11015] Remove
deprecated methods and classes about table from all the Kafka connectors
URL: https://github.com/apache/flink/pull/7182#discussion_r237131756
##
File path: flink-connectors/flink-connector-kafka-0.10/pom.xml
##
@@ -86,40 +86,8 @@ under the License.
true
-
- org.apache.flink
- flink-avro
- ${project.version}
-
- true
-
-
-
- org.apache.flink
- flink-json
- ${project.version}
-
- true
-
-
-
- org.apache.flink
- flink-avro
- ${project.version}
- test
- test-jar
-
-
-
- org.apache.flink
- flink-json
- ${project.version}
- test-jar
Review comment:
OK, It would be better to wait and see Travis's result to verify the
judgment.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove deprecated methods and classes about table from all the Kafka
> connectors
> ---
>
> Key: FLINK-11015
> URL: https://issues.apache.org/jira/browse/FLINK-11015
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
> Labels: pull-request-available
>
> This is to make the "Disentangle flink-connector-kafka from flink-table and
> flink-json" (FLINK-9461) plan more smoothly. For more details, please refer
> to the discussion of FLINK-9461.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[
https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701985#comment-16701985
]
ASF GitHub Bot commented on FLINK-11015:
yanghua commented on a change in pull request #7182: [FLINK-11015] Remove
deprecated methods and classes about table from all the Kafka connectors
URL: https://github.com/apache/flink/pull/7182#discussion_r237120052
##
File path: flink-connectors/flink-connector-kafka-0.10/pom.xml
##
@@ -86,40 +86,8 @@ under the License.
true
-
- org.apache.flink
- flink-avro
- ${project.version}
-
- true
-
-
-
- org.apache.flink
- flink-json
- ${project.version}
-
- true
-
-
-
- org.apache.flink
- flink-avro
- ${project.version}
- test
- test-jar
-
-
-
- org.apache.flink
- flink-json
- ${project.version}
- test-jar
Review comment:
@twalthr The specific test cases have been removed and there is no error
when building by maven. Did I miss anything else?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove deprecated methods and classes about table from all the Kafka
> connectors
> ---
>
> Key: FLINK-11015
> URL: https://issues.apache.org/jira/browse/FLINK-11015
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
> Labels: pull-request-available
>
> This is to make the "Disentangle flink-connector-kafka from flink-table and
> flink-json" (FLINK-9461) plan more smoothly. For more details, please refer
> to the discussion of FLINK-9461.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[
https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701997#comment-16701997
]
ASF GitHub Bot commented on FLINK-11015:
twalthr commented on a change in pull request #7182: [FLINK-11015] Remove
deprecated methods and classes about table from all the Kafka connectors
URL: https://github.com/apache/flink/pull/7182#discussion_r237124239
##
File path: flink-connectors/flink-connector-kafka-0.10/pom.xml
##
@@ -86,40 +86,8 @@ under the License.
true
-
- org.apache.flink
- flink-avro
- ${project.version}
-
- true
-
-
-
- org.apache.flink
- flink-json
- ${project.version}
-
- true
-
-
-
- org.apache.flink
- flink-avro
- ${project.version}
- test
- test-jar
-
-
-
- org.apache.flink
- flink-json
- ${project.version}
- test-jar
Review comment:
In order to share test classes across modules a module must build
`test-jar`s. If the test jar of `flink-json` and `flink-avro` are not necessary
anymore, we can remove the jar building section from those `pom.xml`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove deprecated methods and classes about table from all the Kafka
> connectors
> ---
>
> Key: FLINK-11015
> URL: https://issues.apache.org/jira/browse/FLINK-11015
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
> Labels: pull-request-available
>
> This is to make the "Disentangle flink-connector-kafka from flink-table and
> flink-json" (FLINK-9461) plan more smoothly. For more details, please refer
> to the discussion of FLINK-9461.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[
https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701904#comment-16701904
]
ASF GitHub Bot commented on FLINK-11015:
twalthr commented on a change in pull request #7182: [FLINK-11015] Remove
deprecated methods and classes about table from all the Kafka connectors
URL: https://github.com/apache/flink/pull/7182#discussion_r237089823
##
File path: flink-connectors/flink-connector-kafka-0.10/pom.xml
##
@@ -86,40 +86,8 @@ under the License.
true
-
- org.apache.flink
- flink-avro
- ${project.version}
-
- true
-
-
-
- org.apache.flink
- flink-json
- ${project.version}
-
- true
-
-
-
- org.apache.flink
- flink-avro
- ${project.version}
- test
- test-jar
-
-
-
- org.apache.flink
- flink-json
- ${project.version}
- test-jar
Review comment:
@yanghua Do we need to generate test jars for `flink-json` and `flink-avro`
anymore?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove deprecated methods and classes about table from all the Kafka
> connectors
> ---
>
> Key: FLINK-11015
> URL: https://issues.apache.org/jira/browse/FLINK-11015
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
> Labels: pull-request-available
>
> This is to make the "Disentangle flink-connector-kafka from flink-table and
> flink-json" (FLINK-9461) plan more smoothly. For more details, please refer
> to the discussion of FLINK-9461.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701784#comment-16701784 ] ASF GitHub Bot commented on FLINK-11015: yanghua commented on a change in pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#discussion_r237055489 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkBase.java ## @@ -57,12 +55,11 @@ protected final Properties properties; /** Serialization schema for encoding records to Kafka. */ - protected Optional> serializationSchema; + protected final Optional> serializationSchema; /** Partitioner to select Kafka partition for each item. */ protected final Optional> partitioner; - // legacy variables protected String[] fieldNames; Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated methods and classes about table from all the Kafka > connectors > --- > > Key: FLINK-11015 > URL: https://issues.apache.org/jira/browse/FLINK-11015 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > This is to make the "Disentangle flink-connector-kafka from flink-table and > flink-json" (FLINK-9461) plan more smoothly. For more details, please refer > to the discussion of FLINK-9461. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701662#comment-16701662 ] ASF GitHub Bot commented on FLINK-11015: twalthr commented on a change in pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#discussion_r237019737 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkBase.java ## @@ -57,12 +55,11 @@ protected final Properties properties; /** Serialization schema for encoding records to Kafka. */ - protected Optional> serializationSchema; + protected final Optional> serializationSchema; /** Partitioner to select Kafka partition for each item. */ protected final Optional> partitioner; - // legacy variables protected String[] fieldNames; Review comment: I think we also don't need these variables anymore. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated methods and classes about table from all the Kafka > connectors > --- > > Key: FLINK-11015 > URL: https://issues.apache.org/jira/browse/FLINK-11015 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > This is to make the "Disentangle flink-connector-kafka from flink-table and > flink-json" (FLINK-9461) plan more smoothly. For more details, please refer > to the discussion of FLINK-9461. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[
https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701617#comment-16701617
]
ASF GitHub Bot commented on FLINK-11015:
yanghua commented on a change in pull request #7182: [FLINK-11015] Remove
deprecated methods and classes about table from all the Kafka connectors
URL: https://github.com/apache/flink/pull/7182#discussion_r237006592
##
File path:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011ITCase.java
##
@@ -1,699 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.streaming.connectors.kafka;
-
-import org.apache.flink.api.common.ExecutionConfig;
-import
org.apache.flink.api.common.serialization.TypeInformationSerializationSchema;
-import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
-import org.apache.flink.api.common.typeutils.base.IntSerializer;
-import org.apache.flink.runtime.checkpoint.OperatorSubtaskState;
-import org.apache.flink.runtime.checkpoint.StateObjectCollection;
-import org.apache.flink.runtime.jobgraph.OperatorID;
-import org.apache.flink.runtime.state.OperatorStateHandle;
-import org.apache.flink.streaming.api.operators.StreamSink;
-import org.apache.flink.streaming.util.OneInputStreamOperatorTestHarness;
-import org.apache.flink.streaming.util.serialization.KeyedSerializationSchema;
-import
org.apache.flink.streaming.util.serialization.KeyedSerializationSchemaWrapper;
-
-import kafka.server.KafkaServer;
-import org.apache.kafka.common.errors.ProducerFencedException;
-import org.junit.Before;
-import org.junit.Test;
-
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Optional;
-import java.util.Properties;
-import java.util.UUID;
-import java.util.stream.Collectors;
-import java.util.stream.IntStream;
-
-import static
org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducer011.Semantic;
-import static
org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducer011.Semantic.AT_LEAST_ONCE;
-import static
org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducer011.Semantic.EXACTLY_ONCE;
-import static org.apache.flink.util.ExceptionUtils.findThrowable;
-import static org.apache.flink.util.Preconditions.checkState;
-import static org.hamcrest.Matchers.lessThan;
-import static org.junit.Assert.assertThat;
-import static org.junit.Assert.fail;
-
-/**
- * IT cases for the {@link FlinkKafkaProducer011}.
- */
-@SuppressWarnings("serial")
-public class FlinkKafkaProducer011ITCase extends KafkaTestBase {
Review comment:
Sorry This is an operational mistake, I should be more careful.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove deprecated methods and classes about table from all the Kafka
> connectors
> ---
>
> Key: FLINK-11015
> URL: https://issues.apache.org/jira/browse/FLINK-11015
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
> Labels: pull-request-available
>
> This is to make the "Disentangle flink-connector-kafka from flink-table and
> flink-json" (FLINK-9461) plan more smoothly. For more details, please refer
> to the discussion of FLINK-9461.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701616#comment-16701616 ] ASF GitHub Bot commented on FLINK-11015: yanghua commented on issue #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#issuecomment-442383678 @twalthr thanks for your suggestion. I have checked the list you gave. I found the builder in org.apache.flink.streaming.connectors.kafka.KafkaTableSourceBase has been deleted before you point. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated methods and classes about table from all the Kafka > connectors > --- > > Key: FLINK-11015 > URL: https://issues.apache.org/jira/browse/FLINK-11015 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > This is to make the "Disentangle flink-connector-kafka from flink-table and > flink-json" (FLINK-9461) plan more smoothly. For more details, please refer > to the discussion of FLINK-9461. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[
https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701534#comment-16701534
]
ASF GitHub Bot commented on FLINK-11015:
twalthr commented on a change in pull request #7182: [FLINK-11015] Remove
deprecated methods and classes about table from all the Kafka connectors
URL: https://github.com/apache/flink/pull/7182#discussion_r236982074
##
File path:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011ITCase.java
##
@@ -1,699 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.streaming.connectors.kafka;
-
-import org.apache.flink.api.common.ExecutionConfig;
-import
org.apache.flink.api.common.serialization.TypeInformationSerializationSchema;
-import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
-import org.apache.flink.api.common.typeutils.base.IntSerializer;
-import org.apache.flink.runtime.checkpoint.OperatorSubtaskState;
-import org.apache.flink.runtime.checkpoint.StateObjectCollection;
-import org.apache.flink.runtime.jobgraph.OperatorID;
-import org.apache.flink.runtime.state.OperatorStateHandle;
-import org.apache.flink.streaming.api.operators.StreamSink;
-import org.apache.flink.streaming.util.OneInputStreamOperatorTestHarness;
-import org.apache.flink.streaming.util.serialization.KeyedSerializationSchema;
-import
org.apache.flink.streaming.util.serialization.KeyedSerializationSchemaWrapper;
-
-import kafka.server.KafkaServer;
-import org.apache.kafka.common.errors.ProducerFencedException;
-import org.junit.Before;
-import org.junit.Test;
-
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Optional;
-import java.util.Properties;
-import java.util.UUID;
-import java.util.stream.Collectors;
-import java.util.stream.IntStream;
-
-import static
org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducer011.Semantic;
-import static
org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducer011.Semantic.AT_LEAST_ONCE;
-import static
org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducer011.Semantic.EXACTLY_ONCE;
-import static org.apache.flink.util.ExceptionUtils.findThrowable;
-import static org.apache.flink.util.Preconditions.checkState;
-import static org.hamcrest.Matchers.lessThan;
-import static org.junit.Assert.assertThat;
-import static org.junit.Assert.fail;
-
-/**
- * IT cases for the {@link FlinkKafkaProducer011}.
- */
-@SuppressWarnings("serial")
-public class FlinkKafkaProducer011ITCase extends KafkaTestBase {
Review comment:
This change has nothing to do with a `flink-table` free Kafka module. It
should be moved to a separate PR or at least separate commit. Why can we remove
this class now?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove deprecated methods and classes about table from all the Kafka
> connectors
> ---
>
> Key: FLINK-11015
> URL: https://issues.apache.org/jira/browse/FLINK-11015
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
> Labels: pull-request-available
>
> This is to make the "Disentangle flink-connector-kafka from flink-table and
> flink-json" (FLINK-9461) plan more smoothly. For more details, please refer
> to the discussion of FLINK-9461.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701531#comment-16701531 ] ASF GitHub Bot commented on FLINK-11015: yanghua commented on issue #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#issuecomment-442363596 cc @pnowojski This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated methods and classes about table from all the Kafka > connectors > --- > > Key: FLINK-11015 > URL: https://issues.apache.org/jira/browse/FLINK-11015 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > This is to make the "Disentangle flink-connector-kafka from flink-table and > flink-json" (FLINK-9461) plan more smoothly. For more details, please refer > to the discussion of FLINK-9461. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701478#comment-16701478 ] ASF GitHub Bot commented on FLINK-11015: yanghua commented on issue #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#issuecomment-442345726 @twalthr Can you review this PR? It blocks FLINK-9461. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated methods and classes about table from all the Kafka > connectors > --- > > Key: FLINK-11015 > URL: https://issues.apache.org/jira/browse/FLINK-11015 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > This is to make the "Disentangle flink-connector-kafka from flink-table and > flink-json" (FLINK-9461) plan more smoothly. For more details, please refer > to the discussion of FLINK-9461. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700686#comment-16700686 ] ASF GitHub Bot commented on FLINK-11015: yanghua opened a new pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182 ## What is the purpose of the change *This pull request removes deprecated methods and classes about table from all the Kafka connectors* ## Brief change log - *Remove deprecated methods and classes about table from all the Kafka connectors* ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated methods and classes about table from all the Kafka > connectors > --- > > Key: FLINK-11015 > URL: https://issues.apache.org/jira/browse/FLINK-11015 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > This is to make the "Disentangle flink-connector-kafka from flink-table and > flink-json" (FLINK-9461) plan more smoothly. For more details, please refer > to the discussion of FLINK-9461. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
