[jira] [Commented] (FLINK-14114) Shift down ClusterClient#timeout to RestClusterClient
[
https://issues.apache.org/jira/browse/FLINK-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937901#comment-16937901
]
Zhu Zhu commented on FLINK-14114:
-
Currently it's "akka.client.timeout" which is not a real Akka config and is
only used by Flink client.
And agreed that the usage of the {{timeout}} should be reconsidered, as it is
only used for {{cancel}} and {{getAccumulators}}, and does not apply some other
requests like {{listJobs}} or {{stopWithSavepoint}}. Let the caller to decide
the timeout looks good as some operations are not expected to follow a same
timeout.
> Shift down ClusterClient#timeout to RestClusterClient
> -
>
> Key: FLINK-14114
> URL: https://issues.apache.org/jira/browse/FLINK-14114
> Project: Flink
> Issue Type: Sub-task
> Components: Client / Job Submission
>Reporter: tison
>Assignee: Zhu Zhu
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{ClusterClient#timeout}} is only used in {{RestClusterClient}}, even without
> this prerequisite we can always shift down {{timeout}} field to subclasses of
> {{ClusterClient}}. It is towards an interface-ized {{ClusterClient}}. By side
> effect, we could reduce the dependency to parsing duration with Scala
> Duration on the fly.
> CC [~till.rohrmann] [~zhuzh]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14114) Shift down ClusterClient#timeout to RestClusterClient
[
https://issues.apache.org/jira/browse/FLINK-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937893#comment-16937893
]
tison commented on FLINK-14114:
---
With another investigation I think this timeout, whose value is the same as
akka timeout, is a default value without good reason. During the effort of
FLIP-74 we possibly replace all synchronous methods of ClusterClient with
their asynchronous version. If so, this timeout can be removed, where users of
these method should make the decision about the exact timeout at place.
> Shift down ClusterClient#timeout to RestClusterClient
> -
>
> Key: FLINK-14114
> URL: https://issues.apache.org/jira/browse/FLINK-14114
> Project: Flink
> Issue Type: Sub-task
> Components: Client / Job Submission
>Reporter: tison
>Assignee: Zhu Zhu
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{ClusterClient#timeout}} is only used in {{RestClusterClient}}, even without
> this prerequisite we can always shift down {{timeout}} field to subclasses of
> {{ClusterClient}}. It is towards an interface-ized {{ClusterClient}}. By side
> effect, we could reduce the dependency to parsing duration with Scala
> Duration on the fly.
> CC [~till.rohrmann] [~zhuzh]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14114) Shift down ClusterClient#timeout to RestClusterClient
[
https://issues.apache.org/jira/browse/FLINK-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932275#comment-16932275
]
TisonKun commented on FLINK-14114:
--
I've assigned the issue to you [~zhuzh] :-)
> Shift down ClusterClient#timeout to RestClusterClient
> -
>
> Key: FLINK-14114
> URL: https://issues.apache.org/jira/browse/FLINK-14114
> Project: Flink
> Issue Type: Sub-task
> Components: Client / Job Submission
>Reporter: TisonKun
>Assignee: Zhu Zhu
>Priority: Major
> Fix For: 1.10.0
>
>
> {{ClusterClient#timeout}} is only used in {{RestClusterClient}}, even without
> this prerequisite we can always shift down {{timeout}} field to subclasses of
> {{ClusterClient}}. It is towards an interface-ized {{ClusterClient}}. By side
> effect, we could reduce the dependency to parsing duration with Scala
> Duration on the fly.
> CC [~till.rohrmann] [~zhuzh]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14114) Shift down ClusterClient#timeout to RestClusterClient
[
https://issues.apache.org/jira/browse/FLINK-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932266#comment-16932266
]
Zhu Zhu commented on FLINK-14114:
-
Thanks [~Tison] for the information.
Glad to work on this.
> Shift down ClusterClient#timeout to RestClusterClient
> -
>
> Key: FLINK-14114
> URL: https://issues.apache.org/jira/browse/FLINK-14114
> Project: Flink
> Issue Type: Sub-task
> Components: Client / Job Submission
>Reporter: TisonKun
>Priority: Major
> Fix For: 1.10.0
>
>
> {{ClusterClient#timeout}} is only used in {{RestClusterClient}}, even without
> this prerequisite we can always shift down {{timeout}} field to subclasses of
> {{ClusterClient}}. It is towards an interface-ized {{ClusterClient}}. By side
> effect, we could reduce the dependency to parsing duration with Scala
> Duration on the fly.
> CC [~till.rohrmann] [~zhuzh]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14114) Shift down ClusterClient#timeout to RestClusterClient
[
https://issues.apache.org/jira/browse/FLINK-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932256#comment-16932256
]
TisonKun commented on FLINK-14114:
--
Hi [~zhuzh] if you'd like to work on this coordinate with FLINK-14070 I'm glad
to assign this to you.
[~Zentol] [~kkl0u] I'm not sure if this breaks user cases that programming
directly to {{ClusterClient}}...Anyway if we towards an interface-ized
{{ClusterClient}} there should be no fields, but maybe we can do that all at
once to prevent multiple bump from those users.
> Shift down ClusterClient#timeout to RestClusterClient
> -
>
> Key: FLINK-14114
> URL: https://issues.apache.org/jira/browse/FLINK-14114
> Project: Flink
> Issue Type: Sub-task
> Components: Client / Job Submission
>Reporter: TisonKun
>Priority: Major
> Fix For: 1.10.0
>
>
> {{ClusterClient#timeout}} is only used in {{RestClusterClient}}, even without
> this prerequisite we can always shift down {{timeout}} field to subclasses of
> {{ClusterClient}}. It is towards an interface-ized {{ClusterClient}}. By side
> effect, we could reduce the dependency to parsing duration with Scala
> Duration on the fly.
> CC [~till.rohrmann] [~zhuzh]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
