[jira] [Commented] (FLINK-16023) jdbc connector's 'connector.table' property should be optional rather than required

2021-04-22 Thread Flink Jira Bot (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17328050#comment-17328050
 ] 

Flink Jira Bot commented on FLINK-16023:


This major issue is unassigned and itself and all of its Sub-Tasks have not 
been updated for 30 days. So, it has been labeled "stale-major". If this ticket 
is indeed "major", please either assign yourself or give an update. Afterwards, 
please remove the label. In 7 days the issue will be deprioritized.

> jdbc connector's 'connector.table' property should be optional rather than 
> required
> ---
>
> Key: FLINK-16023
> URL: https://issues.apache.org/jira/browse/FLINK-16023
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / JDBC
>Reporter: Bowen Li
>Priority: Major
>  Labels: stale-major
> Fix For: 1.13.0
>
>
> jdbc connector's 'connector.table' property should be optional rather than 
> required.
> connector should assume the table name in dbms is the same as that in Flink 
> when this property is not present
> The fundamental reason is that such a design didn't consider integration with 
> catalogs. Once introduced catalog, the flink table's name should be just the 
> 'table''s name in corresponding external system. 
> cc [~ykt836]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-16023) jdbc connector's 'connector.table' property should be optional rather than required

2020-02-13 Thread Jingsong Lee (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036023#comment-17036023
 ] 

Jingsong Lee commented on FLINK-16023:
--

I understand that this is a user-friendly optimization, not a design defect.

> jdbc connector's 'connector.table' property should be optional rather than 
> required
> ---
>
> Key: FLINK-16023
> URL: https://issues.apache.org/jira/browse/FLINK-16023
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / JDBC
>Reporter: Bowen Li
>Assignee: Jingsong Lee
>Priority: Major
> Fix For: 1.11.0
>
>
> jdbc connector's 'connector.table' property should be optional rather than 
> required.
> connector should assume the table name in dbms is the same as that in Flink 
> when this property is not present
> The fundamental reason is that such a design didn't consider integration with 
> catalogs. Once introduced catalog, the flink table's name should be just the 
> 'table''s name in corresponding external system. 
> cc [~ykt836]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-16023) jdbc connector's 'connector.table' property should be optional rather than required

2020-02-13 Thread Jark Wu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036011#comment-17036011
 ] 

Jark Wu commented on FLINK-16023:
-

Btw, it's not always possible to use the kafka topic as the registered table 
name, because Kafka topic can use dash(-), however, dash(-) is not allowed as 
an indentifier in SQL. That means a "log-events" topic, may should be 
registered as "log_events" table.

> jdbc connector's 'connector.table' property should be optional rather than 
> required
> ---
>
> Key: FLINK-16023
> URL: https://issues.apache.org/jira/browse/FLINK-16023
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / JDBC
>Reporter: Bowen Li
>Assignee: Jingsong Lee
>Priority: Major
> Fix For: 1.11.0
>
>
> jdbc connector's 'connector.table' property should be optional rather than 
> required.
> connector should assume the table name in dbms is the same as that in Flink 
> when this property is not present
> The fundamental reason is that such a design didn't consider integration with 
> catalogs. Once introduced catalog, the flink table's name should be just the 
> 'table''s name in corresponding external system. 
> cc [~ykt836]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-16023) jdbc connector's 'connector.table' property should be optional rather than required

2020-02-12 Thread Jark Wu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035943#comment-17035943
 ] 

Jark Wu commented on FLINK-16023:
-

You can just set the mysql table's name to both the 'connector.table' and the 
registered name. Then what's the problem for current design? [~phoenixjiangnan]

> jdbc connector's 'connector.table' property should be optional rather than 
> required
> ---
>
> Key: FLINK-16023
> URL: https://issues.apache.org/jira/browse/FLINK-16023
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / JDBC
>Reporter: Bowen Li
>Assignee: Jingsong Lee
>Priority: Major
> Fix For: 1.11.0
>
>
> jdbc connector's 'connector.table' property should be optional rather than 
> required.
> connector should assume the table name in dbms is the same as that in Flink 
> when this property is not present
> The fundamental reason is that such a design didn't consider integration with 
> catalogs. Once introduced catalog, the flink table's name should be just the 
> 'table''s name in corresponding external system. 
> cc [~ykt836]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-16023) jdbc connector's 'connector.table' property should be optional rather than required

2020-02-12 Thread Bowen Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035919#comment-17035919
 ] 

Bowen Li commented on FLINK-16023:
--

[~jark]  The fundamental reason is that such a design didn't consider 
integration with catalogs. Once introduced catalog, the flink table's name 
should be just the 'table''s name in corresponding external system.

this is not specific to jdbc, but general to kafka and hbase sql connector as 
well. I just created FLINK-16027 and FLINK-16028 to track them

> jdbc connector's 'connector.table' property should be optional rather than 
> required
> ---
>
> Key: FLINK-16023
> URL: https://issues.apache.org/jira/browse/FLINK-16023
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / JDBC
>Reporter: Bowen Li
>Assignee: Jingsong Lee
>Priority: Major
> Fix For: 1.11.0
>
>
> jdbc connector's 'connector.table' property should be optional rather than 
> required.
> connector should assume the table name in dbms is the same as that in Flink 
> when this property is not present
> The fundamental reason is that such a design didn't consider integration with 
> catalogs. Once introduced catalog, the flink table's name should be just the 
> 'table''s name in corresponding external system. 
> cc [~ykt836]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-16023) jdbc connector's 'connector.table' property should be optional rather than required

2020-02-12 Thread Jingsong Lee (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035843#comment-17035843
 ] 

Jingsong Lee commented on FLINK-16023:
--

It seems that we need new interface in FLINK-15912

> jdbc connector's 'connector.table' property should be optional rather than 
> required
> ---
>
> Key: FLINK-16023
> URL: https://issues.apache.org/jira/browse/FLINK-16023
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / JDBC
>Reporter: Bowen Li
>Assignee: Jingsong Lee
>Priority: Major
> Fix For: 1.11.0
>
>
> jdbc connector's 'connector.table' property should be optional rather than 
> required.
> connector should assume the table name in dbms is the same as that in Flink 
> when this property is not present
>  
> cc [~ykt836]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-16023) jdbc connector's 'connector.table' property should be optional rather than required

2020-02-12 Thread Jark Wu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035840#comment-17035840
 ] 

Jark Wu commented on FLINK-16023:
-

What's the problem if 'connector.table' is required?

> jdbc connector's 'connector.table' property should be optional rather than 
> required
> ---
>
> Key: FLINK-16023
> URL: https://issues.apache.org/jira/browse/FLINK-16023
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / JDBC
>Reporter: Bowen Li
>Assignee: Jingsong Lee
>Priority: Major
> Fix For: 1.11.0
>
>
> jdbc connector's 'connector.table' property should be optional rather than 
> required.
> connector should assume the table name in dbms is the same as that in Flink 
> when this property is not present
>  
> cc [~ykt836]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)