[jira] [Commented] (FLINK-1774) Remove the redundant code in try{} block

2015-03-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386611#comment-14386611
 ] 

ASF GitHub Bot commented on FLINK-1774:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/522


> Remove the redundant code in try{} block
> 
>
> Key: FLINK-1774
> URL: https://issues.apache.org/jira/browse/FLINK-1774
> Project: Flink
>  Issue Type: Improvement
>Affects Versions: master
>Reporter: Sibao Hong
>Assignee: Sibao Hong
>Priority: Minor
> Fix For: master
>
>
> Remove the redundant code of "fos.close(); fos = null;" in try block because 
> the fos,close() code will always executes in finally block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1774) Remove the redundant code in try{} block

2015-03-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377584#comment-14377584
 ] 

ASF GitHub Bot commented on FLINK-1774:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/522#issuecomment-85425753
  
Looks good, the finally block actually takes care of the cleanup.

+1 to merge


> Remove the redundant code in try{} block
> 
>
> Key: FLINK-1774
> URL: https://issues.apache.org/jira/browse/FLINK-1774
> Project: Flink
>  Issue Type: Improvement
>Affects Versions: master
>Reporter: Sibao Hong
>Assignee: Sibao Hong
>Priority: Minor
> Fix For: master
>
>
> Remove the redundant code of "fos.close(); fos = null;" in try block because 
> the fos,close() code will always executes in finally block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1774) Remove the redundant code in try{} block

2015-03-23 Thread Robert Metzger (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376407#comment-14376407
 ] 

Robert Metzger commented on FLINK-1774:
---

Hi [~matadorhong], I gave you "Contributor" permissions in our JIRA so that you 
can assign issues to yourself.
I've assigned this one for you.



> Remove the redundant code in try{} block
> 
>
> Key: FLINK-1774
> URL: https://issues.apache.org/jira/browse/FLINK-1774
> Project: Flink
>  Issue Type: Improvement
>Affects Versions: master
>Reporter: Sibao Hong
>Priority: Minor
> Fix For: master
>
>
> Remove the redundant code of "fos.close(); fos = null;" in try block because 
> the fos,close() code will always executes in finally block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1774) Remove the redundant code in try{} block

2015-03-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376130#comment-14376130
 ] 

ASF GitHub Bot commented on FLINK-1774:
---

GitHub user matadorhong opened a pull request:

https://github.com/apache/flink/pull/522

[FLINK-1774]Remove the redundant code in try{} block.

Remove the redundant code of "fos.close(); fos = null;" in try block 
because the fos,close() code will always executes in finally block.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matadorhong/flink RemoveRedundantCode

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #522


commit 353705fd21466f1ad09dbd7222c0f897357060ee
Author: hongsibao 
Date:   2015-03-23T16:23:57Z

Remove the redundant code in try{} block.




> Remove the redundant code in try{} block
> 
>
> Key: FLINK-1774
> URL: https://issues.apache.org/jira/browse/FLINK-1774
> Project: Flink
>  Issue Type: Improvement
>Affects Versions: master
>Reporter: Sibao Hong
>Priority: Minor
> Fix For: master
>
>
> Remove the redundant code of "fos.close(); fos = null;" in try block because 
> the fos,close() code will always executes in finally block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)