[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295476#comment-17295476 ] Chesnay Schepler commented on FLINK-20632: -- [~peperg] This is not an issue with our distribution channels, but our release process. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Blocker > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289481#comment-17289481 ] Piotr Gwiazda commented on FLINK-20632: --- Hi. It might be worth hosting the image somwhere else so that it is available on the day of the release. This will allow the developers use it right away. At the same time for some production systems only veridied official images may be allowed, so having an official image will bring value. However, these systems will wait for the offcial image and won't even use the latest version anyway. pon., 28 gru 2020, 13:43 użytkownik Xintong Song (Jira) > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Blocker > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271746#comment-17271746 ] Xintong Song commented on FLINK-20632: -- I tried sign the images for 1.12.1, but couldn't find a way to sign with my PGP key. I can sign an image with a key generated by the command `docker trust key generate`, but that would be different from what we put in the KEYS file. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Blocker > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271280#comment-17271280 ] Robert Metzger commented on FLINK-20632: I agree that we should sign the images! I wasn't even are that this is possible. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Blocker > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261846#comment-17261846 ] Xintong Song commented on FLINK-20632: -- Thanks for driving the efforts, [~rmetzger]. I'm wondering, shall we also secure the `apache/flink` images with our release manager's signatures? I noticed that the previous official-images are signed with administrative keys, while our new images are not. {code:java} $ docker trust inspect flink:1.11.3 [ { "Name": "flink:1.11.3", "SignedTags": [], "Signers": [], "AdministrativeKeys": [ { "Name": "Root", "Keys": [ { "ID": "84dec8c7bc650432d83c84920cb15bc016100d846320377fe43a0c5722e31740" } ] }, { "Name": "Repository", "Keys": [ { "ID": "00916cd7c07d6bf463c4b71e5bb119c3a9350a0637dee74416d34852c18fc03a" } ] } ] } ] $ docker trust inspect apache/flink:1.12 [] No signatures or cannot access apache/flink:1.12 {code} > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Blocker > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261271#comment-17261271 ] Robert Metzger commented on FLINK-20632: NOTE TO USERS LOOKING FOR FLINK 1.12 DOCKER IMAGES: They are available here: https://hub.docker.com/r/apache/flink The image is available as "apache/flink" instead of "flink". Running "docker run -it apache/flink:1.12 jobmanager" starts a JobManager > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Blocker > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261267#comment-17261267 ] Robert Metzger commented on FLINK-20632: Merged updated docker image location to release-1.12 in https://github.com/apache/flink/commit/104feeba1946f018388345ffe56633507540721c Merged updated docker image location to master in https://github.com/apache/flink/commit/03ca39937b406c6db21938e95843b6b290c4a81c I will soon merge the updated release script as well. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Blocker > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259827#comment-17259827 ] Robert Metzger commented on FLINK-20632: There's actually another option: We can request an "apache/flink" DockerHub repository from the "apache" user: https://hub.docker.com/u/apache (via INFRA) That's probably the cleanest solution. I understand your argument Chesnay, but [~peperg] raised the point that some companies are only using official images. For that reason, I believe we should, at least for now, go with the ugly approach of publishing the images to two locations. I will request an "apache/flink" DockerHub repo. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Blocker > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259719#comment-17259719 ] Chesnay Schepler commented on FLINK-20632: -- Well 3 is simply not an option then is it; we can't require uses to need github credentials. I'm currently leaning towards 2). IMO, once we start going down the road of 1 or 2, we should just stop dealing with official-images imo to avoid confusion and overhead. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Blocker > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259705#comment-17259705 ] Robert Metzger commented on FLINK-20632: I don't think that we will be able to use the GitHub Container Registry with the official Apache GitHub account, because Infra won't allow it. I see the following options (ordered by my preference) 1. Use GitHub Container Registry from any GitHub account (project-flink), or "flinkbot" which is an account controlled by the PMC Downsides: Flink committers won't be able to push images there: They need to be added manually to the account. Also, the name of the container will be a bit weird: docker.pkg.github.com/project-flink/flink/flink:1.12.0-scala_2.11. 2. Use a 3rd party DockerHub account (create new "flink" account) Downsides: There are potentially confusions because there will be a real official and a semi official image on Docker Hub. Committers won't have access immediately (like approach 1). 3. (current) Use GitHub Packages of apache/flink: Users need to provide Image Pull Credentials with their GitHub Account Downsides: users have a poor experience, because GitHub credentials are needed to pull. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Blocker > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259675#comment-17259675 ] Robert Metzger commented on FLINK-20632: I just realized that the images pushed to the legacy GitHub Packages are not pullable by unauthenticated users. You need to be logged in to GitHub to pull the images, even if they are public. GitHub Container Registry supports pulling images without authentication. See also: INFRA-20959 > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Blocker > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259639#comment-17259639 ] Xintong Song commented on FLINK-20632: -- Thanks [~rmetzger], I got the following error when trying to pull the image. {code:java} $ docker pull docker.pkg.github.com/apache/flink/flink:1.11-scala_2.11-java11 Error response from daemon: Head https://docker.pkg.github.com/v2/apache/flink/flink/manifests/1.11-scala_2.11-java11: no basic auth credentials {code} And I noticed that Github puts a `Latest version` green tag besides `1.11-scala_2.11-java11 Latest version`, on the all versions page. Does that mean people get this image when pulling with `docker.pkg.github.com/apache/flink/flink:latest`? > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Critical > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259625#comment-17259625 ] Robert Metzger commented on FLINK-20632: I've pushed the 1.12.0 release to GitHub Packages for apache/flink: https://github.com/apache/flink/packages/561356/versions Pushing there will be part of the official release process. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Critical > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259005#comment-17259005 ] Piotr Gwiazda commented on FLINK-20632: --- Hi It might be worth hosting the image somwhere else so that it is available on the day of the release. This will allow the developers use it right away. At the same time for some production systems only verified official images may be allowed, so having an official image will bring value. However, these systems will wait for the offcial image and won't even use the latest version anyway. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Critical > Labels: pull-request-available > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258857#comment-17258857 ] Robert Metzger commented on FLINK-20632: I will investigate hosting our images on GitHub. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Assignee: Robert Metzger >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258225#comment-17258225 ] Yang Wang commented on FLINK-20632: --- I am also in favor of hosting the docker image on a self-controlled registry(e.g. github or Alibaba Cloud Container Registry). The only advantage of docker hub official image is that users could save the words when specifying image name(e.g. flink:1.11.3 vs ghcr.io/apache/flink:1.11.3). > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258107#comment-17258107 ] Xintong Song commented on FLINK-20632: -- +1 on hosting the image on a registry that we control. [~fly_in_gis] and I were also discussing this. We noticed that we might need to change {{KubernetesConfigOptions#getDefaultFlinkImage}} to point to our registry by default. I'd like to include this code change in 1.12.1, unless the 1.12.0 image got approved before this (indicating we probably won't have problems with the 1.12.1 image). Of course we need to first investigate, decide and setup the new register. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258079#comment-17258079 ] Till Rohrmann commented on FLINK-20632: --- I think the lack of responsiveness is due to Christmas and New Years. However, it shows our dependence on these guys. Hence, I am more and more inclined to host the Docker images on a registry which we control or can at least upload images at our need. So maybe the answer is to not host the Flink images as official images on hub.docker.com. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256929#comment-17256929 ] Xintong Song commented on FLINK-20632: -- The docker guys are still not responding to our 1.12.0 image PR, neither the [previous one|https://github.com/docker-library/official-images/pull/9249] nor the [new one|https://github.com/docker-library/official-images/pull/9345]. I'm not sure is this is because of the Christmas vacation or not. I do see there are new PRs got merged recently. Shall we consider hosting the Docker image ourselves starting 1.12.1? > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255585#comment-17255585 ] Till Rohrmann commented on FLINK-20632: --- I think that Robert's proposal with hosting the Docker image ourselves could work and solve the problem of having the release and the Docker image currently separated. The down side of this approach is that we might lose visibility which we currently have with https://hub.docker.com/ as a well known Docker image registry. But we could still publish our images to this registry as well at the cost of a duplicated Docker image which might confuse users. Alternatively we could keep things as they are and hope that the future review process won't take that long. With Chesnay's proposal to move most of the entrypoint script into the Flink repository we might be able to reduce the number of things maintainers of https://github.com/docker-library/official-images might comment on. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255569#comment-17255569 ] Xintong Song commented on FLINK-20632: -- True, it's hard to explain to users that the official docker image is not part of the release. Is it possible to include an image (e.g., a tar file) in our release, so that the K8s integration can work out of box? That would make the docker hub official image an available choice rather than a release dependency. I guess it's a trade-off between the complexity to maintain and ship our own image and the risk of depending our release on a third-party process. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255546#comment-17255546 ] Till Rohrmann commented on FLINK-20632: --- Given that Flink's K8s integration does not work w/o an official Flink Docker image, I do believe that the Docker image is kind of part of the Apache Flink release. At least from the user perspective it seems odd to me that Flink 1.12 has been released but it does not work out of the box with K8s. This is also illustrated by three duplicated tickets which have been opened for the missing Docker images. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255545#comment-17255545 ] Xintong Song commented on FLINK-20632: -- {quote}While it would solve the issue I do somewhat like going through the official-images review process as an additional QA. We aren't really familiar with docker conventions, and the issue they pointed out does make sense after all. {quote} I kind of agree with thinking the official image as an additional QA. Technically speaking the official docker image is not even part of the Apache Flink release. {quote}Note: Docker Official Images are an intellectual property of Docker. Distributing Docker Official Images without a prior agreement can constitute a violation of Docker Terms of Service. --- https://docs.docker.com/docker-hub/official_images/ {quote} > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255539#comment-17255539 ] Chesnay Schepler commented on FLINK-20632: -- ??maybe it is enough to postpone the release announcement until the Docker PR is merged. That way we can first complete the Flink release, then update the Docker image and lastly announce the release which makes it effectively available to our users. Would we have delayed the release for 2+ weeks because the docker images aren't being released? ??Does our PMC has the authority to remove artifacts from the apache release svn repository, say if we have not announced it??? Yes, we can do that. ??But maybe hosting the Flink docker images somewhere else will decouple our release process from Dockerhub which already does the trick. While it would solve the issue I do somewhat like going through the official-images review process as an additional QA. We aren't _really_ familiar with docker conventions, and the issue they pointed out does make sense after all. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255503#comment-17255503 ] Till Rohrmann commented on FLINK-20632: --- But maybe hosting the Flink docker images somewhere else will decouple our release process from Dockerhub which already does the trick. In any case, I think we need to solve this problem for the next release, because it is now already 2 weeks since the 1.12.0 release and people trying out the K8s integration will fail because of the missing Docker image. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255500#comment-17255500 ] Till Rohrmann commented on FLINK-20632: --- Ideally, we wouldn't have to modify Flink because of the Docker image. I guess that the main part which is being reviewed are the {{Dockerfile}} and the entrypoint start script. If a change to Flink's source code is needed, then we could also create a new bug fix release right away. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255493#comment-17255493 ] Xintong Song commented on FLINK-20632: -- Does our PMC has the authority to remove artifacts from the apache *release* svn repository, say if we have not announced it? I'm asking because, IIUC building docker images requires downloading the release from the *release* svn repository. And if the official-image review process requires updating Flink's source codes, we would need to remove the invalid release from the repository. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255477#comment-17255477 ] Till Rohrmann commented on FLINK-20632: --- [~chesnay] maybe it is enough to postpone the release announcement until the Docker PR is merged. That way we can first complete the Flink release, then update the Docker image and lastly announce the release which makes it effectively available to our users. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254187#comment-17254187 ] Chesnay Schepler commented on FLINK-20632: -- [~fly_in_gis] It's not that we can't have snapshot images, but that we can't advertise them to users; so it wouldn't really help in this situation. We do have to find a way though to ensure we can release the docker images on the day of the release, but it's a bit of a chicken-egg problem. We can't open a proper PR against the official images repo before the release is out (because the image couldn't download the corresponding release), but we don't to release before the image being accepted. I'm wondering whether we could just move all of the docker logic into a script that lives in the distribution, and we just defer to that script in the image. If we could make this work we could ourselves a lot of hassle from keeping Flink and flink-docker in sync. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251526#comment-17251526 ] Yang Wang commented on FLINK-20632: --- I remember [~chesnay] said in the ML that apache does not allow publishing snapshot images. Correct me if I am wrong. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251070#comment-17251070 ] Dian Fu commented on FLINK-20632: - Providing snapshot docker images seems a good idea. Otherwise, I'm afraid that the release process may still not be rolled back even when we find that there are some problems during publishing to official images as artifacts such as the jars may have already been deployed to the maven central repo. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251063#comment-17251063 ] Till Rohrmann commented on FLINK-20632: --- If this works better then this could also be the way forward. The current problem with releasing before the docker image is available is that the native K8s integration does not work. Providing snapshot docker images is a very good improvement imo. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251040#comment-17251040 ] Robert Metzger commented on FLINK-20632: If it does not delay the release too much, yes. What we could also consider hosting the Flink images in another registry (for example GitHub). The command for pulling the image would be something like docker pull ghcr.io/apache/flink:1.12.0. We could even extend this to nightly builds as well. > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251005#comment-17251005 ] Xintong Song commented on FLINK-20632: -- bq. As a meta comment: Should we wait with release announcements until the docker image is approved in the future? +1 > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250989#comment-17250989 ] Till Rohrmann commented on FLINK-20632: --- As a meta comment: Should we wait with release announcements until the docker image is approved in the future? > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Critical > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20632) Missing docker images for 1.12 release
[ https://issues.apache.org/jira/browse/FLINK-20632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250824#comment-17250824 ] Robert Metzger commented on FLINK-20632: As a temporary workaround, you can build the docker image yourself, with these steps: git clone https://github.com/apache/flink-docker cd flink-docker/ cd 1.12/scala_2.12-java8-debian/ docker build -t flink:1.12.0 . I also pushed an image to DockerHub as: "rmetzger/flink:1.12.0-unofficial". This is an unofficial image, not an official apache release! > Missing docker images for 1.12 release > -- > > Key: FLINK-20632 > URL: https://issues.apache.org/jira/browse/FLINK-20632 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes >Affects Versions: 1.12.0 >Reporter: Piotr Gwiazda >Priority: Major > > Images for Flink 1.12 are missing in Docker hub > https://hub.docker.com/_/flink. As a result Kubernetes deployment as in the > documentation example is not working. > https://ci.apache.org/projects/flink/flink-docs-release-1.12/deployment/resource-providers/native_kubernetes.html -- This message was sent by Atlassian Jira (v8.3.4#803005)