[jira] [Commented] (FLINK-2526) Add catch{} for task when it stop running
[
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698556#comment-14698556
]
ASF GitHub Bot commented on FLINK-2526:
---
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1020#issuecomment-131495368
@StephanEwen Thanks. I think you pull request has fixes this.I will close
my pull request and view your code.
Add catch{} for task when it stop running
--
Key: FLINK-2526
URL: https://issues.apache.org/jira/browse/FLINK-2526
Project: Flink
Issue Type: Bug
Components: Streaming
Affects Versions: 0.8.1
Reporter: fangfengbin
Assignee: fangfengbin
Priority: Minor
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2526) Add catch{} for task when it stop running
[
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698557#comment-14698557
]
ASF GitHub Bot commented on FLINK-2526:
---
Github user ffbin closed the pull request at:
https://github.com/apache/flink/pull/1020
Add catch{} for task when it stop running
--
Key: FLINK-2526
URL: https://issues.apache.org/jira/browse/FLINK-2526
Project: Flink
Issue Type: Bug
Components: Streaming
Affects Versions: 0.8.1
Reporter: fangfengbin
Assignee: fangfengbin
Priority: Minor
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2526) Add catch{} for task when it stop running
[
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698160#comment-14698160
]
ASF GitHub Bot commented on FLINK-2526:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1020#discussion_r37134398
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/OneInputStreamTask.java
---
@@ -100,9 +100,27 @@ public void invoke() throws Exception {
this.isRunning = false;
// Cleanup
inputProcessor.clearBuffers();
- inputProcessor.cleanup();
- outputHandler.flushOutputs();
- clearBuffers();
+
+ try {
+ inputProcessor.cleanup();
+ }
+ catch (Exception e) {
+ LOG.warn(Clean up input processor failed.);
--- End diff --
the exception message shouldn't be discarded.
Add catch{} for task when it stop running
--
Key: FLINK-2526
URL: https://issues.apache.org/jira/browse/FLINK-2526
Project: Flink
Issue Type: Bug
Components: Streaming
Affects Versions: 0.8.1
Reporter: fangfengbin
Assignee: fangfengbin
Priority: Minor
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2526) Add catch{} for task when it stop running
[
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698179#comment-14698179
]
ASF GitHub Bot commented on FLINK-2526:
---
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1020#issuecomment-131314931
@zentol Hello! Thank you for your suggestion.I have add exception message
in log.
Add catch{} for task when it stop running
--
Key: FLINK-2526
URL: https://issues.apache.org/jira/browse/FLINK-2526
Project: Flink
Issue Type: Bug
Components: Streaming
Affects Versions: 0.8.1
Reporter: fangfengbin
Assignee: fangfengbin
Priority: Minor
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2526) Add catch{} for task when it stop running
[
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698153#comment-14698153
]
ASF GitHub Bot commented on FLINK-2526:
---
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/1020
[FLINK-2526]Add try-catch for task when it stop running
inputProcessor cleanup() may throw IOException.If do not catch it, the next
line outputHandler .flushOutputs() will not work and cause output data loss.So
i think add some try-catch is necessary.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ffbin/flink FLINK-2526
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1020.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1020
commit f846f56198c921f9285bce4fb25392d9d6e2a827
Author: ffbin 869218...@qq.com
Date: 2015-08-15T06:40:16Z
[FLINK-2526]Add catch{} for task when it stop running
Add catch{} for task when it stop running
--
Key: FLINK-2526
URL: https://issues.apache.org/jira/browse/FLINK-2526
Project: Flink
Issue Type: Bug
Components: Streaming
Affects Versions: 0.8.1
Reporter: fangfengbin
Assignee: fangfengbin
Priority: Minor
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2526) Add catch{} for task when it stop running
[
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698306#comment-14698306
]
ASF GitHub Bot commented on FLINK-2526:
---
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1020#issuecomment-131390701
The pull request #1017 actually fixes this as well, together with a lot of
other things (similar problems are in many places).
Can you have a look at #1017 and see if that would solve your concern?
Add catch{} for task when it stop running
--
Key: FLINK-2526
URL: https://issues.apache.org/jira/browse/FLINK-2526
Project: Flink
Issue Type: Bug
Components: Streaming
Affects Versions: 0.8.1
Reporter: fangfengbin
Assignee: fangfengbin
Priority: Minor
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
