[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[Matthias J. Sax (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944902#comment-14944902
 ] 

Matthias J. Sax commented on FLINK-2566:


Fixed via 7a67a60f934123863ca96a95e30471c99bb8088a

> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944900#comment-14944900
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1135


> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941386#comment-14941386
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

Github user mjsax commented on the pull request:

https://github.com/apache/flink/pull/1135#issuecomment-145085340
  
Just updated this PR. It additionally contains the maven module 
restructuring and internal code cleanup in a second commit. If no objects, I 
will push this into master.


> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941388#comment-14941388
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

Github user mjsax commented on the pull request:

https://github.com/apache/flink/pull/1135#issuecomment-145085684
  
Prove reading for README, Web documenation, and examples JavaDoc would be 
appreciated ;) It's a lot if renaming going on and I might have missed 
something.


> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14768876#comment-14768876
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1135#issuecomment-140730955
  
There is a test failure
```
 StormWrapperSetupHelperTest.testCreateTopologyContext:190 » ClassCast 
class su...
```


> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14768870#comment-14768870
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

Github user rmetzger commented on a diff in the pull request:

https://github.com/apache/flink/pull/1135#discussion_r39624182
  
--- Diff: 
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopology.java
 ---
@@ -28,17 +28,14 @@
  * cannot be executed directly, but must be handed over to a {@link 
FlinkLocalCluster}, {@link FlinkSubmitter}, or
  * {@link FlinkClient}.
  */
-class FlinkTopology extends StreamExecutionEnvironment {
+public class FlinkTopology extends StreamExecutionEnvironment {
--- End diff --

While trying out the Storm compat, I stumbled across the fact that the 
FlinkTopology was only package visible
--> Good fix ;)


> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790672#comment-14790672
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

Github user mjsax commented on the pull request:

https://github.com/apache/flink/pull/1135#issuecomment-140795134
  
I know. See dev mailing list "Java 8 JDK issue".


> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790669#comment-14790669
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

Github user mjsax commented on a diff in the pull request:

https://github.com/apache/flink/pull/1135#discussion_r39652292
  
--- Diff: 
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopology.java
 ---
@@ -28,17 +28,14 @@
  * cannot be executed directly, but must be handed over to a {@link 
FlinkLocalCluster}, {@link FlinkSubmitter}, or
  * {@link FlinkClient}.
  */
-class FlinkTopology extends StreamExecutionEnvironment {
+public class FlinkTopology extends StreamExecutionEnvironment {
--- End diff --

That was on purpose on no bug. Because, a user should on call `new 
FlinkTopology()`.

But now I need it to be public. Furthermore, and I am going to change some 
stuff and allow `new FlinkTopology()` (so I did not include a private 
constructor either in this PR -- for future purpose).


> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791134#comment-14791134
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1135#issuecomment-140898273
  
Tricky bug :-)
If it does not depend on #1046, why not merge it?
Or would you like to have somebody else looking over the code?


> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791165#comment-14791165
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1135#issuecomment-140901138
  
#1046 seems to be almost done. Porting to the ExecutionConfig, shouldn't be 
too hard. I'd rather try to drive #1046 forward and merge it first, but it's up 
to you.


> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791124#comment-14791124
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

Github user mjsax commented on the pull request:

https://github.com/apache/flink/pull/1135#issuecomment-140895609
  
Fixed. Please let me know if I can merge this. Or should I wait for #1046 ?


> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791144#comment-14791144
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

Github user mjsax commented on the pull request:

https://github.com/apache/flink/pull/1135#issuecomment-140899681
  
I use the config that is introduced in #1046 already... See TODO in 
StormWrapperSetupHelper.java and StormWrapperSetupHelperTest.java ... Not sure 
if it is cleaver to merge this first (of course #1046 can just fix this up 
after a rebase). And I applied package restructuring which might require a 
tricky rebase for #1046 

Would like to get advice about a good way to handle this (or if I can 
ignore this and just merge). And comments about the code are always welcome :)


> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791168#comment-14791168
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

Github user mjsax commented on the pull request:

https://github.com/apache/flink/pull/1135#issuecomment-140901671
  
Thanks. I agree with you. Just wanted to get a second opinion.


> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746405#comment-14746405
 ] 

ASF GitHub Bot commented on FLINK-2566:
---

GitHub user mjsax opened a pull request:

https://github.com/apache/flink/pull/1135

[FLINK-2566] FlinkTopologyContext not populated completely

  - extended FlinkTopologyContext to be populted with all supportable 
attributes
  - added JUnit test
  - updated README.md
additionally: module restructuring to get cleaner package structure

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mjsax/flink flink-2566-topologyContext

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1135


commit 07473990fcbe06cff2305afcd78d5aef74895736
Author: mjsax 
Date:   2015-09-15T21:59:31Z

[FLINK-2566] FlinkTopologyContext not populated completely
  - extended FlinkTopologyContext to be populted with all supportable 
attributes
  - added JUnit test
  - updated README.md
additionally: module restructuring to get cleaner package structure




> FlinkTopologyContext not populated completely
> -
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2566) FlinkTopologyContext no populated completely

[Matthias J. Sax (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741223#comment-14741223
 ] 

Matthias J. Sax commented on FLINK-2566:


The PR for this feature is almost ready. It depend on FLINK-2525. Thus, I need 
to wait until this is merged, so I can rebase and finish the code.

> FlinkTopologyContext no populated completely
> 
>
> Key: FLINK-2566
> URL: https://issues.apache.org/jira/browse/FLINK-2566
> Project: Flink
>  Issue Type: Improvement
>  Components: Storm Compatibility
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)