[jira] [Commented] (FLINK-3248) RMQSource does not provide a constructor for credentials or other options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155718#comment-15155718
 ] 

ASF GitHub Bot commented on FLINK-3248:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1670


> RMQSource does not provide a constructor for credentials or other options
> -
>
> Key: FLINK-3248
> URL: https://issues.apache.org/jira/browse/FLINK-3248
> Project: Flink
>  Issue Type: Bug
>  Components: Streaming Connectors
>Affects Versions: 1.0.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.0.0
>
>
> We could either add a new constructor for credentials (username and password) 
> or let the user pass a {{ConnectionFactory}} to the source. The latter would 
> enable us to support all potential options for the connection. Note that, 
> {{ConnectionFactory}} is not serializable. It would have to be serialized to 
> a byte array for shipping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3248) RMQSource does not provide a constructor for credentials or other options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15152810#comment-15152810
 ] 

ASF GitHub Bot commented on FLINK-3248:
---

GitHub user mxm opened a pull request:

https://github.com/apache/flink/pull/1670

 [FLINK-3248] add constructor params and generic ConnectionFactory

This adds more default constructor parameters to the RMQSource. In addition,
users may override the setupConnectionFactory() method to return their own
configured factory.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mxm/flink FLINK-3248

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1670


commit 3795ba62e1cbc825329238669d5a79490bde1ced
Author: Maximilian Michels 
Date:   2016-02-17T09:34:01Z

[FLINK-3248] add constructor params and generic ConnectionFactory

This adds more default constructor parameters to the RMQSource. In addition,
users may override the setupConnectionFactory() method to return their onwn
configured factory.

commit 4112074f6340e57d66fe38fa203748a93d39ad88
Author: Maximilian Michels 
Date:   2016-02-18T16:33:00Z

remove RMQTopology file




> RMQSource does not provide a constructor for credentials or other options
> -
>
> Key: FLINK-3248
> URL: https://issues.apache.org/jira/browse/FLINK-3248
> Project: Flink
>  Issue Type: Bug
>  Components: Streaming Connectors
>Affects Versions: 1.0.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.0.0
>
>
> We could either add a new constructor for credentials (username and password) 
> or let the user pass a {{ConnectionFactory}} to the source. The latter would 
> enable us to support all potential options for the connection. Note that, 
> {{ConnectionFactory}} is not serializable. It would have to be serialized to 
> a byte array for shipping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3248) RMQSource does not provide a constructor for credentials or other options

[Stephan Ewen (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106767#comment-15106767
 ] 

Stephan Ewen commented on FLINK-3248:
-

It often works to simply create the factory {{Class.newInstance()}} only in the 
{{open()}} method. Then you only need to ship the class, not a (potentially 
non-serializable) object.

> RMQSource does not provide a constructor for credentials or other options
> -
>
> Key: FLINK-3248
> URL: https://issues.apache.org/jira/browse/FLINK-3248
> Project: Flink
>  Issue Type: Bug
>  Components: Streaming Connectors
>Affects Versions: 1.0.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.0.0
>
>
> We could either add a new constructor for credentials (username and password) 
> or let the user pass a {{ConnectionFactory}} to the source. The latter would 
> enable us to support all potential options for the connection. Note that, 
> {{ConnectionFactory}} is not serializable. It would have to be serialized to 
> a byte array for shipping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3248) RMQSource does not provide a constructor for credentials or other options

[Maximilian Michels (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106934#comment-15106934
 ] 

Maximilian Michels commented on FLINK-3248:
---

That's the current state. The problem is that you'll have to provide a 
constructor for every option of the factory.

> RMQSource does not provide a constructor for credentials or other options
> -
>
> Key: FLINK-3248
> URL: https://issues.apache.org/jira/browse/FLINK-3248
> Project: Flink
>  Issue Type: Bug
>  Components: Streaming Connectors
>Affects Versions: 1.0.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.0.0
>
>
> We could either add a new constructor for credentials (username and password) 
> or let the user pass a {{ConnectionFactory}} to the source. The latter would 
> enable us to support all potential options for the connection. Note that, 
> {{ConnectionFactory}} is not serializable. It would have to be serialized to 
> a byte array for shipping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3248) RMQSource does not provide a constructor for credentials or other options

[Robert Metzger (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105076#comment-15105076
 ] 

Robert Metzger commented on FLINK-3248:
---

I would prefer the {{ConnectionFactory}} variant. How would you serialize the 
factory? (Using Kryo? manually?)

> RMQSource does not provide a constructor for credentials or other options
> -
>
> Key: FLINK-3248
> URL: https://issues.apache.org/jira/browse/FLINK-3248
> Project: Flink
>  Issue Type: Bug
>  Components: Streaming Connectors
>Affects Versions: 1.0.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.0.0
>
>
> We could either add a new constructor for credentials (username and password) 
> or let the user pass a {{ConnectionFactory}} to the source. The latter would 
> enable us to support all potential options for the connection. Note that, 
> {{ConnectionFactory}} is not serializable. It would have to be serialized to 
> a byte array for shipping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3248) RMQSource does not provide a constructor for credentials or other options

[Maximilian Michels (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105195#comment-15105195
 ] 

Maximilian Michels commented on FLINK-3248:
---

Yes, that approach is more future proof. I would use Kryo.

> RMQSource does not provide a constructor for credentials or other options
> -
>
> Key: FLINK-3248
> URL: https://issues.apache.org/jira/browse/FLINK-3248
> Project: Flink
>  Issue Type: Bug
>  Components: Streaming Connectors
>Affects Versions: 1.0.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.0.0
>
>
> We could either add a new constructor for credentials (username and password) 
> or let the user pass a {{ConnectionFactory}} to the source. The latter would 
> enable us to support all potential options for the connection. Note that, 
> {{ConnectionFactory}} is not serializable. It would have to be serialized to 
> a byte array for shipping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)