[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754763#comment-15754763
]
ASF GitHub Bot commented on FLINK-4704:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2958
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Anton Mushin
>Priority: Blocker
> Fix For: 1.2.0
>
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754681#comment-15754681
]
ASF GitHub Bot commented on FLINK-4704:
---
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2958
I looked over the changes again. LGTM also from my side.
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Anton Mushin
>Priority: Blocker
> Fix For: 1.2.0
>
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754514#comment-15754514
]
ASF GitHub Bot commented on FLINK-4704:
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2958
Merging this PR
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Anton Mushin
>Priority: Blocker
> Fix For: 1.2.0
>
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751425#comment-15751425
]
ASF GitHub Bot commented on FLINK-4704:
---
Github user ex00 commented on the issue:
https://github.com/apache/flink/pull/2958
Thank you Fabian!
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Anton Mushin
>Priority: Blocker
> Fix For: 1.2.0
>
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751415#comment-15751415
]
ASF GitHub Bot commented on FLINK-4704:
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2958
Thanks for the update @ex00!
I'll do a few additional minor refactorings and merge the PR later.
Thanks, Fabian
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Anton Mushin
>Priority: Blocker
> Fix For: 1.2.0
>
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748549#comment-15748549
]
ASF GitHub Bot commented on FLINK-4704:
---
Github user ex00 commented on the issue:
https://github.com/apache/flink/pull/2958
PR has been updated.
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Anton Mushin
>Priority: Blocker
> Fix For: 1.2.0
>
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747714#comment-15747714
]
ASF GitHub Bot commented on FLINK-4704:
---
Github user ex00 commented on the issue:
https://github.com/apache/flink/pull/2958
Hi @fhueske and @twalthr, thanks for your comments.
I will update PR
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Anton Mushin
>Priority: Blocker
> Fix For: 1.2.0
>
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747705#comment-15747705
]
ASF GitHub Bot commented on FLINK-4704:
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2958
OK @twalthr. Sounds good to me.
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Anton Mushin
>Priority: Blocker
> Fix For: 1.2.0
>
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747658#comment-15747658
]
ASF GitHub Bot commented on FLINK-4704:
---
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2958
@fhueske I would move `src/main/scala/org/apache/flink/table/Types.scala`
to `src/main/scala/org/apache/flink/table/api/`. This class is API only and and
not used internally.
And `src/main/scala/org/apache/flink/table/table.scala` ->
`src/main/scala/org/apache/flink/table/api/`.
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Anton Mushin
>Priority: Blocker
> Fix For: 1.2.0
>
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745638#comment-15745638
]
ASF GitHub Bot commented on FLINK-4704:
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2958
Thanks for the PR @ex00!
I would like to suggest to move a few more files:
- move `flink-table` examples: `org/apache/flink/examples` ->
`org/apache/flink/table/examples` (for Java and Scala)
- move `src/main/scala/org/apache/flink/table/windows.scala` ->
`src/main/scala/org/apache/flink/table/api/windows.scala`
- move `src/main/scala/org/apache/flink/table/Types.scala` ->
`src/main/scala/org/apache/flink/table/typeutils/Types.scala`
- move `src/main/scala/org/apache/flink/table/trees/TreeNode.scala` ->
`src/main/scala/org/apache/flink/table/plan/TreeNode.scala` and remove the
empty `trees` package / folder
- create a new package `org.apache.flink.table.calcite` and move
`CalciteConfig.scala`, `FlinkCalciteSqlValidator.scala`,
`FlinkPlannerImpl.scala`, `FlinkRelBuilder.scala`, `FlinkTypeFactory.scala`,
and `FlinkTypeSystem.scala` from `src/main/scala/org/apache/flink/table` to
`src/main/scala/org/apache/flink/table/calcite`
What do you think @ex00 and @twalthr?
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Anton Mushin
>Priority: Blocker
> Fix For: 1.2.0
>
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728764#comment-15728764
]
ASF GitHub Bot commented on FLINK-4704:
---
GitHub user ex00 opened a pull request:
https://github.com/apache/flink/pull/2958
[FLINK-4704] Move Table API to org.apache.flink.table
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
The PR about moving table api and sql classes to org.apache.flink.table
package
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ex00/flink FLINK-4704
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2958.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2958
commit ea305475f1ed625041870fe0cd5712fe3310ac70
Author: Anton Mushin
Date: 2016-12-07T12:42:42Z
[FLINK-4704] Move Table API to org.apache.flink.table
move table api to org.apache.flink.table package
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Anton Mushin
>Priority: Blocker
> Fix For: 1.2.0
>
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721533#comment-15721533
]
Fabian Hueske commented on FLINK-4704:
--
+1 Let's do this before the 1.2 release.
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535169#comment-15535169
]
Jark Wu commented on FLINK-4704:
+1
Table API is still in beta, so it's not too late to do this now.
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table
[
https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532176#comment-15532176
]
Liwei Lin commented on FLINK-4704:
--
+1 on this!
> Move Table API to org.apache.flink.table
>
>
> Key: FLINK-4704
> URL: https://issues.apache.org/jira/browse/FLINK-4704
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>
> This would be a large change. But maybe now is still a good time to do it.
> Otherwise we will never fix this.
> Actually, the Table API is in the wrong package. At the moment it is in
> {{org.apache.flink.api.table}} and the actual Scala/Java APIs are in
> {{org.apache.flink.api.java/scala.table}}. All other APIs such as Python,
> Gelly, Flink ML do not use the {{org.apache.flink.api}} namespace.
> I suggest the following packages:
> {code}
> org.apache.flink.table
> org.apache.flink.table.api.java
> org.apache.flink.table.api.scala
> {code}
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
