[jira] [Commented] (FLINK-4877) Refactorings around FLINK-3674 (User Function Timers)
[ https://issues.apache.org/jira/browse/FLINK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262336#comment-16262336 ] ASF GitHub Bot commented on FLINK-4877: --- Github user vim-wj closed the pull request at: https://github.com/apache/flink/pull/4877 > Refactorings around FLINK-3674 (User Function Timers) > - > > Key: FLINK-4877 > URL: https://issues.apache.org/jira/browse/FLINK-4877 > Project: Flink > Issue Type: Sub-task > Components: Streaming >Reporter: Aljoscha Krettek > Fix For: 1.2.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-4877) Refactorings around FLINK-3674 (User Function Timers)
[ https://issues.apache.org/jira/browse/FLINK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262333#comment-16262333 ] ASF GitHub Bot commented on FLINK-4877: --- Github user vim-wj commented on the issue: https://github.com/apache/flink/pull/4877 @greghogan , @StephanEwen ,sorry fo my late reply.I will close this pull request. > Refactorings around FLINK-3674 (User Function Timers) > - > > Key: FLINK-4877 > URL: https://issues.apache.org/jira/browse/FLINK-4877 > Project: Flink > Issue Type: Sub-task > Components: Streaming >Reporter: Aljoscha Krettek > Fix For: 1.2.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-4877) Refactorings around FLINK-3674 (User Function Timers)
[ https://issues.apache.org/jira/browse/FLINK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261566#comment-16261566 ] ASF GitHub Bot commented on FLINK-4877: --- Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4877 @vim-wj if you are okay with Stephan's suggestion could you close this pull request? Also, a small note: `FLINK-4877` references a [Jira ticket](https://issues.apache.org/jira/browse/FLINK-4877) rather than a pull request (use `[hotfix]` for simple issues not requiring a ticket). > Refactorings around FLINK-3674 (User Function Timers) > - > > Key: FLINK-4877 > URL: https://issues.apache.org/jira/browse/FLINK-4877 > Project: Flink > Issue Type: Sub-task > Components: Streaming >Reporter: Aljoscha Krettek > Fix For: 1.2.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-4877) Refactorings around FLINK-3674 (User Function Timers)
[ https://issues.apache.org/jira/browse/FLINK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217024#comment-16217024 ] ASF GitHub Bot commented on FLINK-4877: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4877 Thanks for opening this pull request. I think it is correct that `SourceFunction` is not required to implement `Serializable`. But I think it does not cause any problems, as far as I know, it has no implication at all on the runtime or behavior. It does serve as a "reminder" that sources need to be serializable, so it could actually be helpful to keep it. Given that it makes no difference, should we keep it? > Refactorings around FLINK-3674 (User Function Timers) > - > > Key: FLINK-4877 > URL: https://issues.apache.org/jira/browse/FLINK-4877 > Project: Flink > Issue Type: Sub-task > Components: Streaming >Reporter: Aljoscha Krettek > Fix For: 1.2.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
