[jira] [Commented] (FLINK-5444) Flink UI uses absolute URLs.

2017-01-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821183#comment-15821183
 ] 

ASF GitHub Bot commented on FLINK-5444:
---

Github user uce commented on the issue:

https://github.com/apache/flink/pull/3093
  
Thanks! LGTM, going to merge this now.


> Flink UI uses absolute URLs.
> 
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
>  Issue Type: Bug
>Reporter: Joerg Schad
>Assignee: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example 
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
>  sizes="16x16"> 
> 
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links 
> are preffered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5444) Flink UI uses absolute URLs.

2017-01-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821199#comment-15821199
 ] 

ASF GitHub Bot commented on FLINK-5444:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3093


> Flink UI uses absolute URLs.
> 
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
>  Issue Type: Bug
>Reporter: Joerg Schad
>Assignee: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example 
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
>  sizes="16x16"> 
> 
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links 
> are preffered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5444) Flink UI uses absolute URLs.

2017-01-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821007#comment-15821007
 ] 

ASF GitHub Bot commented on FLINK-5444:
---

Github user joerg84 commented on the issue:

https://github.com/apache/flink/pull/3093
  
@sachingoel0101 PTAL


> Flink UI uses absolute URLs.
> 
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
>  Issue Type: Bug
>Reporter: Joerg Schad
>Assignee: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example 
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
>  sizes="16x16"> 
> 
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links 
> are preffered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5444) Flink UI uses absolute URLs.

2017-01-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820921#comment-15820921
 ] 

ASF GitHub Bot commented on FLINK-5444:
---

Github user joerg84 commented on a diff in the pull request:

https://github.com/apache/flink/pull/3093#discussion_r95783168
  
--- Diff: 
flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee 
---
@@ -167,7 +167,7 @@ angular.module('flinkApp')
 $scope.uploader['success'] = null
   else
 $scope.uploader['success'] = "Uploaded!"
-  xhr.open("POST", "/jars/upload")
+  xhr.open("POST", "jars/upload")
--- End diff --

Thx for the explanation!


> Flink UI uses absolute URLs.
> 
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
>  Issue Type: Bug
>Reporter: Joerg Schad
>Assignee: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example 
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
>  sizes="16x16"> 
> 
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links 
> are preffered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5444) Flink UI uses absolute URLs.

2017-01-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820553#comment-15820553
 ] 

ASF GitHub Bot commented on FLINK-5444:
---

Github user sachingoel0101 commented on a diff in the pull request:

https://github.com/apache/flink/pull/3093#discussion_r95749646
  
--- Diff: 
flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee 
---
@@ -167,7 +167,7 @@ angular.module('flinkApp')
 $scope.uploader['success'] = null
   else
 $scope.uploader['success'] = "Uploaded!"
-  xhr.open("POST", "/jars/upload")
+  xhr.open("POST", "jars/upload")
--- End diff --

Primarily, this makes all server side requests consistent. Further, if you 
check in index.coffee, the jobserver URL is set to empty for production, and a 
local host string for development purposes. This helps with streamlining 
dashboard dev without having to rebuild the maven modules again and again. 
This particular case was disabling the dev on submit page. Best to get this 
in while you're fixing all urls. 


> Flink UI uses absolute URLs.
> 
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
>  Issue Type: Bug
>Reporter: Joerg Schad
>Assignee: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example 
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
>  sizes="16x16"> 
> 
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links 
> are preffered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5444) Flink UI uses absolute URLs.

2017-01-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820456#comment-15820456
 ] 

ASF GitHub Bot commented on FLINK-5444:
---

Github user joerg84 commented on a diff in the pull request:

https://github.com/apache/flink/pull/3093#discussion_r95741031
  
--- Diff: 
flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee 
---
@@ -167,7 +167,7 @@ angular.module('flinkApp')
 $scope.uploader['success'] = null
   else
 $scope.uploader['success'] = "Uploaded!"
-  xhr.open("POST", "/jars/upload")
+  xhr.open("POST", "jars/upload")
--- End diff --

Thx, @sachingoel0101 could you provide me some more details on why that is 
preferrable? Happy to change it, just want to understand the details it :-).


> Flink UI uses absolute URLs.
> 
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
>  Issue Type: Bug
>Reporter: Joerg Schad
>Assignee: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example 
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
>  sizes="16x16"> 
> 
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links 
> are preffered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5444) Flink UI uses absolute URLs.

2017-01-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820447#comment-15820447
 ] 

ASF GitHub Bot commented on FLINK-5444:
---

Github user sachingoel0101 commented on a diff in the pull request:

https://github.com/apache/flink/pull/3093#discussion_r95740581
  
--- Diff: 
flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee 
---
@@ -167,7 +167,7 @@ angular.module('flinkApp')
 $scope.uploader['success'] = null
   else
 $scope.uploader['success'] = "Uploaded!"
-  xhr.open("POST", "/jars/upload")
+  xhr.open("POST", "jars/upload")
--- End diff --

Can you use `flinkConfig.jobServer + "jars/upload"` here? Otherwise, looks 
good to me.


> Flink UI uses absolute URLs.
> 
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
>  Issue Type: Bug
>Reporter: Joerg Schad
>Assignee: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example 
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
>  sizes="16x16"> 
> 
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links 
> are preffered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5444) Flink UI uses absolute URLs.

2017-01-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819609#comment-15819609
 ] 

ASF GitHub Bot commented on FLINK-5444:
---

Github user joerg84 commented on the issue:

https://github.com/apache/flink/pull/3093
  
Please retest!


> Flink UI uses absolute URLs.
> 
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
>  Issue Type: Bug
>Reporter: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example 
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
>  sizes="16x16"> 
> 
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links 
> are preffered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5444) Flink UI uses absolute URLs.

2017-01-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819240#comment-15819240
 ] 

ASF GitHub Bot commented on FLINK-5444:
---

Github user joerg84 commented on the issue:

https://github.com/apache/flink/pull/3093
  
@zentol thanks and yes I verified the expected behavior. 


> Flink UI uses absolute URLs.
> 
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
>  Issue Type: Bug
>Reporter: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example 
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
>  sizes="16x16"> 
> 
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links 
> are preffered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5444) Flink UI uses absolute URLs.

2017-01-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818561#comment-15818561
 ] 

ASF GitHub Bot commented on FLINK-5444:
---

Github user joerg84 commented on the issue:

https://github.com/apache/flink/pull/3093
  
@zentol Thx! Could you check again?


> Flink UI uses absolute URLs.
> 
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
>  Issue Type: Bug
>Reporter: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example 
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
>  sizes="16x16"> 
> 
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links 
> are preffered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5444) Flink UI uses absolute URLs.

2017-01-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818535#comment-15818535
 ] 

ASF GitHub Bot commented on FLINK-5444:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3093
  
These changes will be overridden the next time someone builds the 
web-dashboard. You have to modify the .jade files.


> Flink UI uses absolute URLs.
> 
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
>  Issue Type: Bug
>Reporter: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example 
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
>  sizes="16x16"> 
> 
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links 
> are preffered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5444) Flink UI uses absolute URLs.

2017-01-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818506#comment-15818506
 ] 

ASF GitHub Bot commented on FLINK-5444:
---

GitHub user joerg84 opened a pull request:

https://github.com/apache/flink/pull/3093

[FLINK-5444] Made Flink UI links relative.

Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful 
description of your changes.

- [x] General
  - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
  - The pull request addresses only one issue
  - Each commit in the PR has a meaningful commit message (including the 
JIRA id)

- [ ] Documentation
  - Documentation has been added for new functionality
  - Old documentation affected by the pull request has been updated
  - JavaDoc for public methods has been added

- [x] Tests & Build
  - Functionality added by the pull request is covered by tests
  - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joerg84/flink master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3093.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3093


commit fa9b0c3642248d4329acb19bf0ac2ef461dbac66
Author: Joerg Schad 
Date:   2017-01-11T13:58:54Z

Made Flink UI links relative.




> Flink UI uses absolute URLs.
> 
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
>  Issue Type: Bug
>Reporter: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example 
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
>  sizes="16x16"> 
> 
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links 
> are preffered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)