[jira] [Commented] (FLINK-5497) remove duplicated tests
[ https://issues.apache.org/jira/browse/FLINK-5497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873909#comment-15873909 ] ASF GitHub Bot commented on FLINK-5497: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3089 > remove duplicated tests > --- > > Key: FLINK-5497 > URL: https://issues.apache.org/jira/browse/FLINK-5497 > Project: Flink > Issue Type: Improvement > Components: Tests >Reporter: Alexey Diomin >Priority: Minor > > Now we have test which run the same code 4 times, every run 17+ seconds. > Need do small refactoring and remove duplicated code. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-5497) remove duplicated tests
[ https://issues.apache.org/jira/browse/FLINK-5497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872163#comment-15872163 ] ASF GitHub Bot commented on FLINK-5497: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3089 Thank you for fixing this! > remove duplicated tests > --- > > Key: FLINK-5497 > URL: https://issues.apache.org/jira/browse/FLINK-5497 > Project: Flink > Issue Type: Improvement > Components: Tests >Reporter: Alexey Diomin >Priority: Minor > > Now we have test which run the same code 4 times, every run 17+ seconds. > Need do small refactoring and remove duplicated code. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-5497) remove duplicated tests
[ https://issues.apache.org/jira/browse/FLINK-5497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872162#comment-15872162 ] ASF GitHub Bot commented on FLINK-5497: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3089 Okay, I finally found the time to double check this. The changes are good, merging this... > remove duplicated tests > --- > > Key: FLINK-5497 > URL: https://issues.apache.org/jira/browse/FLINK-5497 > Project: Flink > Issue Type: Improvement > Components: Tests >Reporter: Alexey Diomin >Priority: Minor > > Now we have test which run the same code 4 times, every run 17+ seconds. > Need do small refactoring and remove duplicated code. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-5497) remove duplicated tests
[
https://issues.apache.org/jira/browse/FLINK-5497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823884#comment-15823884
]
ASF GitHub Bot commented on FLINK-5497:
---
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3089
@StephanEwen
Hi, I did check more than double time
This two part of code fully equals:
```java
Tuple2 record;
final Tuple2 recordReuse = new Tuple2<>();
if (record = buildSide.next(recordReuse) != null ) { .. }
while (record = buildSide.next(record) != null ) { .. }
```
```java
Tuple2 record;
final Tuple2 recordReuse = new Tuple2<>();
if (record = buildSide.next(recordReuse) != null ) { .. }
while (record = buildSide.next(recordReuse) != null ) { .. }
```
after `if` record and recordReuse are pointing to one object.
Other point it's comment:
'This test is basically identical to the
"testSpillingHashJoinWithMassiveCollisions" test, only that the number',
but when @aljoscha did refactoring (2 years ago) he replaced record =>
recordReuse for one function (both place), but for second function replaced
only in one place.
p.s. i spent evening until unraveled this code from first commits =\
> remove duplicated tests
> ---
>
> Key: FLINK-5497
> URL: https://issues.apache.org/jira/browse/FLINK-5497
> Project: Flink
> Issue Type: Improvement
> Components: Tests
>Reporter: Alexey Diomin
>Priority: Minor
>
> Now we have test which run the same code 4 times, every run 17+ seconds.
> Need do small refactoring and remove duplicated code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5497) remove duplicated tests
[ https://issues.apache.org/jira/browse/FLINK-5497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823826#comment-15823826 ] ASF GitHub Bot commented on FLINK-5497: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3089 Thanks you for the effort to increase testing performance. I think we have to look very closely here, because it may easily decrease the test coverage. I think there were subtle differences between the tests concerning reusability of result holder objects. The hash table classes are at the core of many DataSet operations and had subtle bugs before that we caught and fixed by massively expanding test coverage. We must absolutely preserve that. That being said, removing exact duplicates makes total sense - we simply need to double check that these are in fact exact duplicates and not fuzzy duplicates. > remove duplicated tests > --- > > Key: FLINK-5497 > URL: https://issues.apache.org/jira/browse/FLINK-5497 > Project: Flink > Issue Type: Improvement > Components: Tests >Reporter: Alexey Diomin >Priority: Minor > > Now we have test which run the same code 4 times, every run 17+ seconds. > Need do small refactoring and remove duplicated code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
