[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225932#comment-16225932
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4774


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Piotr Nowojski
>Priority: Blocker
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225173#comment-16225173
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user NicoK commented on a diff in the pull request:

https://github.com/apache/flink/pull/4774#discussion_r147743853
  
--- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala ---
@@ -257,6 +257,20 @@ object AkkaUtils {
 ConfigFactory.parseString(config)
   }
 
+  private def validateHeartbeat(pauseParamName: String,
+pauseValue: String,
+intervalParamName: String,
+intervalValue: String) = {
+if (Duration.apply(pauseValue).lteq(Duration.apply(intervalValue))) {
+  throw new IllegalConfigurationException(
+"%s [%s] must greater then %s [%s]",
--- End diff --

this should actually be "than", not "then"


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Piotr Nowojski
>Priority: Blocker
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196754#comment-16196754
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user pnowojski commented on the issue:

https://github.com/apache/flink/pull/4774
  
Made requested changes to fixed delay strategy and added one more hot fix 
regarding akka's documentation (last commit).


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196724#comment-16196724
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user pnowojski commented on a diff in the pull request:

https://github.com/apache/flink/pull/4774#discussion_r143416770
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FixedDelayRestartStrategy.java
 ---
@@ -82,7 +82,7 @@ public static FixedDelayRestartStrategyFactory 
createFactory(Configuration confi
int maxAttempts = 
configuration.getInteger(ConfigConstants.RESTART_STRATEGY_FIXED_DELAY_ATTEMPTS, 
1);
 
String timeoutString = configuration.getString(
-   AkkaOptions.WATCH_HEARTBEAT_INTERVAL);
+   AkkaOptions.WATCH_HEARTBEAT_PAUSE);
--- End diff --

I will fix the inconsistency in other way: fixing exception message instead 
of this getter.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196719#comment-16196719
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user pnowojski commented on a diff in the pull request:

https://github.com/apache/flink/pull/4774#discussion_r143416489
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/IllegalConfigurationException.java
 ---
@@ -42,6 +42,17 @@ public IllegalConfigurationException(String message) {
 
/**
 * Constructs an new IllegalConfigurationException with the given error 
message
+* format and arguments.
+*
+* @param format The error message format for the exception.
+* @param arguments The arguments for the format.
+*/
+   public IllegalConfigurationException(String format, Object... 
arguments) {
--- End diff --

Convenience - reduces boiler plate. I prefer this:
```
throw new IllegalConfigurationException("%s %s", foo, bar);
```
to that:
```
throw new IllegalConfigurationException(String.format("%s %s", foo, bar));
```
same as it is done in loggers.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194896#comment-16194896
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/4774#discussion_r143246933
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/IllegalConfigurationException.java
 ---
@@ -42,6 +42,17 @@ public IllegalConfigurationException(String message) {
 
/**
 * Constructs an new IllegalConfigurationException with the given error 
message
+* format and arguments.
+*
+* @param format The error message format for the exception.
+* @param arguments The arguments for the format.
+*/
+   public IllegalConfigurationException(String format, Object... 
arguments) {
--- End diff --

Curious: Why introduce the extra constructor and not call 
`String.format(...)` where the exception is created?


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194895#comment-16194895
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/4774#discussion_r143248194
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FixedDelayRestartStrategy.java
 ---
@@ -82,7 +82,7 @@ public static FixedDelayRestartStrategyFactory 
createFactory(Configuration confi
int maxAttempts = 
configuration.getInteger(ConfigConstants.RESTART_STRATEGY_FIXED_DELAY_ATTEMPTS, 
1);
 
String timeoutString = configuration.getString(
-   AkkaOptions.WATCH_HEARTBEAT_INTERVAL);
+   AkkaOptions.WATCH_HEARTBEAT_PAUSE);
--- End diff --

We cannot make this change, this introduces crazy delay on each recovery.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192786#comment-16192786
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user pnowojski commented on the issue:

https://github.com/apache/flink/pull/4774
  
I have added runtime check for that. To be clear, this was not the reason 
for Kafka tests instabilities and I'm not aware if this was causing any issues. 
But it definitely could and should be fixed anyway (IMO that should be a 
release blocker)


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192078#comment-16192078
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4774
  
Given that this caused instabilities shouldn't we introduce a runtime check 
to make sure these options are configure correctly in relation to each other? 
We should also properly document it in the javadocs that these values have a 
strong relationship.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191503#comment-16191503
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

GitHub user pnowojski opened a pull request:

https://github.com/apache/flink/pull/4774

[FLINK-6495] Fix Akka's default value for heartbeat pause

## Brief change log

This PR consists of two hotfixes regarding akka's heartbeat pause. The 
critical one is reverting it's default value from 10s back to 60s (bug 
introduced by #3935)

## Verifying this change

This change is already covered by existing tests

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (yes / **no**)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (**yes (default config values)** / no)
  - The serializers: (yes / **no** / don't know)
  - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)

## Documentation

  - Does this pull request introduce a new feature? (yes / **no**)
  - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pnowojski/flink akka

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4774


commit 0f17a2998d343bc78bb01533a6fcf847d657c38c
Author: Piotr Nowojski 
Date:   2017-10-02T17:33:46Z

[hotfix][config] Revert heartbeat pause back to 60s

This fixes an important bug introduced by FLINK-6495. Heartbeat pause MUST 
be
significantly larger then heartbeat interval.

commit 07fd359be00c8de6c1473c6c5631b4bdeee0c586
Author: Piotr Nowojski 
Date:   2017-10-04T11:26:16Z

[hotfix][runtime] Fix default value for restart delay

1. Previously default value didn't match with an exception message being 
thrown.
2. HEARTBEAT_PAUSE is more sane default value for the delay, becauce we 
want to
wait long enough before restart, for actors to realize about previous crash.




> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020060#comment-16020060
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3935


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019355#comment-16019355
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3935
  
Thanks for addressing my comments, I will merge this today.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019102#comment-16019102
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/3935
  
@zentol Thank you for your suggestions, and I have fixed the problems you 
mentioned :)


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017169#comment-16017169
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user tillrohrmann commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117447913
  
--- Diff: 
flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingUtils.scala
 ---
@@ -28,7 +28,7 @@ import com.google.common.util.concurrent.MoreExecutors
 import com.typesafe.config.ConfigFactory
 import grizzled.slf4j.Logger
 import org.apache.flink.api.common.time.Time
-import org.apache.flink.configuration.{ConfigConstants, Configuration, 
HighAvailabilityOptions, TaskManagerOptions}
+import org.apache.flink.configuration._
--- End diff --

I don't think so @zentol.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017141#comment-16017141
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117441680
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobSubmissionClientActor.java
 ---
@@ -119,7 +119,7 @@ public void handleCustomMessage(Object message) {
client.tell(
decorateMessage(new 
Status.Failure(
new 
JobClientActorSubmissionTimeoutException("Job submission to the JobManager 
timed out. " +
-   "You may 
increase '" + ConfigConstants.AKKA_CLIENT_TIMEOUT + "' in case the JobManager " 
+
+   "You may 
increase '" + AkkaOptions.AKKA_CLIENT_TIMEOUT + "' in case the JobManager " +
--- End diff --

replace ConfigOption with actual key


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017135#comment-16017135
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117443837
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java ---
@@ -55,4 +55,88 @@
public static final ConfigOption AKKA_WATCH_HEARTBEAT_PAUSE = 
ConfigOptions
.key("akka.watch.heartbeat.pause")
.defaultValue("60 s");
+
+   /**
+* Timeout for the startup of the actor system
--- End diff --

The javadocs should all end with a `.`.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017143#comment-16017143
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117442464
  
--- Diff: 
flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingUtils.scala
 ---
@@ -28,7 +28,7 @@ import com.google.common.util.concurrent.MoreExecutors
 import com.typesafe.config.ConfigFactory
 import grizzled.slf4j.Logger
 import org.apache.flink.api.common.time.Time
-import org.apache.flink.configuration.{ConfigConstants, Configuration, 
HighAvailabilityOptions, TaskManagerOptions}
+import org.apache.flink.configuration._
--- End diff --

@aljoscha @tillrohrmann Do we have a policy in place for scala wilcard 
imports (in tests)?


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017140#comment-16017140
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117441909
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FixedDelayRestartStrategy.java
 ---
@@ -87,7 +87,7 @@ public static FixedDelayRestartStrategyFactory 
createFactory(Configuration confi
} catch (NumberFormatException nfe) {
if (delayString.equals(timeoutString)) {
throw new Exception("Invalid config value for " 
+
-   
ConfigConstants.AKKA_WATCH_HEARTBEAT_PAUSE + ": " + timeoutString +
+   
AkkaOptions.AKKA_WATCH_HEARTBEAT_PAUSE + ": " + timeoutString +
--- End diff --

replace with key.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017137#comment-16017137
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117442054
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java
 ---
@@ -146,7 +147,7 @@ public static TaskManagerConfiguration 
fromConfiguration(Configuration configura
timeout = 
Time.milliseconds(AkkaUtils.getTimeout(configuration).toMillis());
} catch (Exception e) {
throw new IllegalArgumentException(
-   "Invalid format for '" + 
ConfigConstants.AKKA_ASK_TIMEOUT +
+   "Invalid format for '" + 
AkkaOptions.AKKA_ASK_TIMEOUT +
--- End diff --

replace with key


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017139#comment-16017139
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117441984
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateClient.java
 ---
@@ -114,13 +114,11 @@ public QueryableStateClient(
LeaderRetrievalService leaderRetrievalService = 
highAvailabilityServices.getJobManagerLeaderRetriever(HighAvailabilityServices.DEFAULT_JOB_ID);
 
// Get the ask timeout
-   String askTimeoutString = config.getString(
-   ConfigConstants.AKKA_ASK_TIMEOUT,
-   ConfigConstants.DEFAULT_AKKA_ASK_TIMEOUT);
+   String askTimeoutString = 
config.getString(AkkaOptions.AKKA_ASK_TIMEOUT);
 
Duration timeout = FiniteDuration.apply(askTimeoutString);
if (!timeout.isFinite()) {
-   throw new 
IllegalConfigurationException(ConfigConstants.AKKA_ASK_TIMEOUT
+   throw new 
IllegalConfigurationException(AkkaOptions.AKKA_ASK_TIMEOUT
--- End diff --

replace with key


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017142#comment-16017142
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117441942
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyFactory.java
 ---
@@ -100,7 +100,7 @@ public static RestartStrategyFactory 
createRestartStrategyFactory(Configuration
} catch (NumberFormatException nfe) {
if (delayString.equals(pauseString)) {
throw new Exception("Invalid 
config value for " +
-   
ConfigConstants.AKKA_WATCH_HEARTBEAT_PAUSE + ": " + pauseString +
+   
AkkaOptions.AKKA_WATCH_HEARTBEAT_PAUSE + ": " + pauseString +
--- End diff --

replace with key


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017136#comment-16017136
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117441051
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java ---
@@ -27,7 +27,7 @@
  */
 @PublicEvolving
 public class AkkaOptions {
-
+   
--- End diff --

revert


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017138#comment-16017138
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117441386
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobAttachmentClientActor.java
 ---
@@ -114,7 +114,7 @@ else if 
(JobClientMessages.getRegistrationTimeout().equals(message)) {
client.tell(
decorateMessage(new 
Status.Failure(
new 
JobClientActorRegistrationTimeoutException("Registration for Job at the 
JobManager " +
-   "timed out. " + 
"You may increase '" + ConfigConstants.AKKA_CLIENT_TIMEOUT +
+   "timed out. " + 
"You may increase '" + AkkaOptions.AKKA_CLIENT_TIMEOUT +
--- End diff --

`ConfigConstants.AKKA_CLIENT_TIMEOUT` is only the key, so we should only 
contain the key of the ConfigOption, i.e 
`AkkaOptions.AKKA_CLIENT_TIMEOUT.key()`.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016789#comment-16016789
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zjureel commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117390018
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java ---
@@ -28,31 +28,143 @@
 @PublicEvolving
 public class AkkaOptions {
 
+   public static String DEFAULT_AKKA_TRANSPORT_HEARTBEAT_INTERVAL = "1000 
s";
+
+   public static String DEFAULT_AKKA_TCP_TIMEOUT = "20 s";
+
+   public static String DEFAULT_AKKA_WATCH_HEARTBEAT_INTERVAL = "10 s";
--- End diff --

Thank you for your suggestion, and I was also bothered by the 
`DEFAULT_AKKA_*` fields while the default value is used. 
`ConfigOption#defaultValue()` sounds good.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015773#comment-16015773
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user tillrohrmann commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117252282
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FailureRateRestartStrategy.java
 ---
@@ -92,7 +92,7 @@ public static FailureRateRestartStrategyFactory 
createFactory(Configuration conf
String failuresIntervalString = configuration.getString(

ConfigConstants.RESTART_STRATEGY_FAILURE_RATE_FAILURE_RATE_INTERVAL, 
Duration.apply(1, TimeUnit.MINUTES).toString()
);
-   String timeoutString = 
configuration.getString(ConfigConstants.AKKA_WATCH_HEARTBEAT_INTERVAL, 
ConfigConstants.DEFAULT_AKKA_ASK_TIMEOUT);
--- End diff --

Yes, since it does not make much sense to set the heartbeat interval to a 
smaller value than the akka ask timeout if not explicitly set.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015698#comment-16015698
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117237209
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FailureRateRestartStrategy.java
 ---
@@ -92,7 +92,7 @@ public static FailureRateRestartStrategyFactory 
createFactory(Configuration conf
String failuresIntervalString = configuration.getString(

ConfigConstants.RESTART_STRATEGY_FAILURE_RATE_FAILURE_RATE_INTERVAL, 
Duration.apply(1, TimeUnit.MINUTES).toString()
);
-   String timeoutString = 
configuration.getString(ConfigConstants.AKKA_WATCH_HEARTBEAT_INTERVAL, 
ConfigConstants.DEFAULT_AKKA_ASK_TIMEOUT);
--- End diff --

@tillrohrmann Is it intended that the default for 
`AKKA_WATCH_HEARTBEAT_INTERVAL` is inherently tied to 
`DEFAULT_AKKA_ASK_TIMEOUT`?


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015697#comment-16015697
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117236057
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java ---
@@ -28,31 +28,143 @@
 @PublicEvolving
 public class AkkaOptions {
 
+   public static String DEFAULT_AKKA_TRANSPORT_HEARTBEAT_INTERVAL = "1000 
s";
+
+   public static String DEFAULT_AKKA_TCP_TIMEOUT = "20 s";
+
+   public static String DEFAULT_AKKA_WATCH_HEARTBEAT_INTERVAL = "10 s";
--- End diff --

These should be moved into the `defaultValue` clause of the config option. 
They can be accessed from the ConfigOption using `ConfigOption#defaultValue()`.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015686#comment-16015686
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/3935#discussion_r117235231
  
--- Diff: 
flink-tests/src/test/java/org/apache/flink/test/recovery/ProcessFailureCancelingITCase.java
 ---
@@ -42,10 +41,8 @@
 import org.apache.flink.runtime.testingUtils.TestingUtils;
 import org.apache.flink.runtime.testutils.CommonTestUtils;
 import org.apache.flink.util.NetUtils;
-
--- End diff --

please revert all changes to imports in this file and others. This includes 
not removing empty lines, re-ordering imports or replacing `*` imports.


> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015191#comment-16015191
 ] 

ASF GitHub Bot commented on FLINK-6495:
---

GitHub user zjureel opened a pull request:

https://github.com/apache/flink/pull/3935

[FLINK-6495] Migrate Akka configuration options

Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful 
description of your changes.

- [ ] General
  - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
  - The pull request addresses only one issue
  - Each commit in the PR has a meaningful commit message (including the 
JIRA id)

- [ ] Documentation
  - Documentation has been added for new functionality
  - Old documentation affected by the pull request has been updated
  - JavaDoc for public methods has been added

- [ ] Tests & Build
  - Functionality added by the pull request is covered by tests
  - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjureel/flink FLINK-6495

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3935.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3935


commit c87718694052e499875d78c7ef2bc9573dc0cc4e
Author: zjureel 
Date:   2017-05-18T04:34:40Z

[FLINK-6495] Migrate Akka configuration options




> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

[Fang Yong (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004313#comment-16004313
 ] 

Fang Yong commented on FLINK-6495:
--

[~Zentol], I'd like to pick this issue and create a PR to fix it later, thanks.

> Migrate Akka configuration options
> --
>
> Key: FLINK-6495
> URL: https://issues.apache.org/jira/browse/FLINK-6495
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination, Network
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)