[jira] [Commented] (FLINK-6810) Add Some built-in Scalar Function supported
[ https://issues.apache.org/jira/browse/FLINK-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563646#comment-16563646 ] Fabian Hueske commented on FLINK-6810: -- Hi [~hequn8128], thanks for adding contribution instructions! That's a great idea. I'll add another point about testing. Thanks, Fabian > Add Some built-in Scalar Function supported > --- > > Key: FLINK-6810 > URL: https://issues.apache.org/jira/browse/FLINK-6810 > Project: Flink > Issue Type: New Feature > Components: Table API SQL >Affects Versions: 1.4.0 >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Labels: starter > > In this JIRA, will create some sub-task for add specific scalar function, > such as mathematical-function {{LOG}}, date-functions > {{DATEADD}},string-functions {{LPAD}}, etc. > *How To Contribute a build-in scalar function* > Thank you very much for contributing a build-in function. In order to make > sure your contributions are in a good direction, it is recommended to read > the following instructions. > # Research the behavior of the function which you are going to contribute in > major DBMSs. This is very import since we have to understand the exact > semantics of the function. > # It is recommended to add function both for sql and talbe-api. > # Every scalar function should add TableAPI docs in > {{./docs/dev/table/tableApi.md#built-in-functions}}. Add SQL docs in > {{./docs/dev/table/sql.md#built-in-functions}}. When add docs for table-api, > you should add both scala docs and java docs. Make sure your description of > the function is accurate. Please do not copy documentation from other > projects. Especially if other projects are not Apache licensed. > # Take overflow, NullPointerException and other exceptions into consideration. > Welcome anybody to add the sub-task about standard database scalar function. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-6810) Add Some built-in Scalar Function supported
[ https://issues.apache.org/jira/browse/FLINK-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560665#comment-16560665 ] Hequn Cheng commented on FLINK-6810: Hi all, I added an instruction about how to contribute a build-in scalar function in this Jira description. Hope it helps you when you going to make a contribute. > Add Some built-in Scalar Function supported > --- > > Key: FLINK-6810 > URL: https://issues.apache.org/jira/browse/FLINK-6810 > Project: Flink > Issue Type: New Feature > Components: Table API SQL >Affects Versions: 1.4.0 >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Labels: starter > > In this JIRA, will create some sub-task for add specific scalar function, > such as mathematical-function {{LOG}}, date-functions > {{DATEADD}},string-functions {{LPAD}}, etc. > *How To Contribute a build-in scalar function* > Thank you very much for contributing a build-in function. In order to make > sure your contributions are in a good direction, it is recommended to read > the following instructions. > # Research the behavior of the function which you are going to contribute in > major DBMSs. This is very import since we have to understand the exact > semantics of the function. > # It is recommended to add function both for sql and talbe-api. > # Every scalar function should add TableAPI docs in > {{./docs/dev/table/tableApi.md#built-in-functions}}. Add SQL docs in > {{./docs/dev/table/sql.md#built-in-functions}}. When add docs for table-api, > you should add both scala docs and java docs. Make sure your description of > the function is accurate. Please do not copy documentation from other > projects. Especially if other projects are not Apache licensed. > # Take overflow, NullPointerException and other exceptions into consideration. > Welcome anybody to add the sub-task about standard database scalar function. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-6810) Add Some built-in Scalar Function supported
[ https://issues.apache.org/jira/browse/FLINK-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397874#comment-16397874 ] Fabian Hueske commented on FLINK-6810: -- Hi [~fdiazgon], sure :). I suggest to pick one that does not have an open PR and no dependencies. You can have a look at the resolved issues to get an idea of what changes are necessary. Best, Fabian > Add Some built-in Scalar Function supported > --- > > Key: FLINK-6810 > URL: https://issues.apache.org/jira/browse/FLINK-6810 > Project: Flink > Issue Type: New Feature > Components: Table API SQL >Affects Versions: 1.4.0 >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Labels: starter > > In this JIRA, will create some sub-task for add specific scalar function, > such as mathematical-function {{LOG}}, date-functions > {{DATEADD}},string-functions {{LPAD}}, etc. > I think is good way to let SQL work, and then add TableAPI to supported. So I > suggest one scalar function create two sub-task, one is for SQL. another for > TableAPI. > *Note:* > Every scalar function should add TableAPI doc in > {{./docs/dev/table/tableApi.md#built-in-functions}}. > Add SQL doc in {{./docs/dev/table/sql.md#built-in-functions}}. > Welcome anybody to add the sub-task about standard database scalar function. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-6810) Add Some built-in Scalar Function supported
[ https://issues.apache.org/jira/browse/FLINK-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397512#comment-16397512 ] Fernando Díaz commented on FLINK-6810: -- Hi. I would like to work on any of these. They seem OK for a newcomer ;) > Add Some built-in Scalar Function supported > --- > > Key: FLINK-6810 > URL: https://issues.apache.org/jira/browse/FLINK-6810 > Project: Flink > Issue Type: New Feature > Components: Table API SQL >Affects Versions: 1.4.0 >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Labels: starter > > In this JIRA, will create some sub-task for add specific scalar function, > such as mathematical-function {{LOG}}, date-functions > {{DATEADD}},string-functions {{LPAD}}, etc. > I think is good way to let SQL work, and then add TableAPI to supported. So I > suggest one scalar function create two sub-task, one is for SQL. another for > TableAPI. > *Note:* > Every scalar function should add TableAPI doc in > {{./docs/dev/table/tableApi.md#built-in-functions}}. > Add SQL doc in {{./docs/dev/table/sql.md#built-in-functions}}. > Welcome anybody to add the sub-task about standard database scalar function. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-6810) Add Some built-in Scalar Function supported
[ https://issues.apache.org/jira/browse/FLINK-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038438#comment-16038438 ] sunjincheng commented on FLINK-6810: Hi, [~wheat9] We need to do this with calcite. So, frankly I don't have a very detailed time plan, but I think these features should be completed in 1.4 release. What do you think? > Add Some built-in Scalar Function supported > --- > > Key: FLINK-6810 > URL: https://issues.apache.org/jira/browse/FLINK-6810 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL >Affects Versions: 1.4.0 >Reporter: sunjincheng > > In this JIRA, will create some sub-task for add specific scalar function, > such as mathematical-function {{LOG}}, date-functions > {{DATEADD}},string-functions {{LPAD}}, etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6810) Add Some built-in Scalar Function supported
[ https://issues.apache.org/jira/browse/FLINK-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037492#comment-16037492 ] Haohui Mai commented on FLINK-6810: --- Thanks for creating these jira. They are quite useful. Is it possible to share the timeline of when they will be implemented? Thanks. > Add Some built-in Scalar Function supported > --- > > Key: FLINK-6810 > URL: https://issues.apache.org/jira/browse/FLINK-6810 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL >Affects Versions: 1.4.0 >Reporter: sunjincheng > > In this JIRA, will create some sub-task for add specific scalar function, > such as mathematical-function {{LOG}}, date-functions > {{DATEADD}},string-functions {{LPAD}}, etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346)