[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550283#comment-16550283
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/6120


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548931#comment-16548931
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/6120
  
Thank you @aljoscha. I will add a test for `flapMap` and the bug that I 
just noticed and merge this.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548808#comment-16548808
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user twalthr commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r203605524
  
--- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
 ---
@@ -545,15 +543,15 @@ public IntervalJoined(
 
TypeInformation resultType = 
TypeExtractor.getBinaryOperatorReturnType(
cleanedUdf,
-   ProcessJoinFunction.class,// 
ProcessJoinFunction
-   0, //   
012
+   ProcessJoinFunction.class,
+   0,
1,
2,
-   TypeExtractor.NO_INDEX, // output arg 
indices
-   left.getType(), // input 1 type 
information
-   right.getType(),// input 2 type 
information
-   INTERVAL_JOIN_FUNC_NAME ,
-   false
+   TypeExtractor.NO_INDEX,
+   left.getType(),
+   right.getType(),
+   Utils.getCallLocationName(),
+   true
--- End diff --

Just saw that this should be false. Will correct that.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546826#comment-16546826
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user twalthr commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r203083498
  
--- Diff: 
flink-core/src/test/java/org/apache/flink/api/java/typeutils/LambdaExtractionTest.java
 ---
@@ -271,19 +214,20 @@ public void testKeySelectorLambda() {
public void testLambdaTypeErasure() {
MapFunction, Tuple1> f = (i) -> null;
TypeInformation ti = TypeExtractor.getMapReturnTypes(f, new 
TypeHint>(){}.getTypeInfo(), null, true);
-   Assert.assertTrue(ti instanceof MissingTypeInfo);
+   assertTrue(ti instanceof MissingTypeInfo);
}
 
@Test
public void testPartitionerLambda() {
Partitioner> partitioner = (key, 
numPartitions) -> key.f1.length() % numPartitions;
-   final TypeInformation ti = 
TypeExtractor.getPartitionerTypes(partitioner);
-
-   Assert.assertTrue(ti.isTupleType());
-   Assert.assertEquals(2, ti.getArity());
-   Assert.assertEquals(((TupleTypeInfo) ti).getTypeAt(0), 
BasicTypeInfo.INT_TYPE_INFO);
-   Assert.assertEquals(((TupleTypeInfo) ti).getTypeAt(1), 
BasicTypeInfo.STRING_TYPE_INFO);
+   final TypeInformation ti = 
TypeExtractor.getPartitionerTypes(partitioner, null, true);
 
+   if (!(ti instanceof MissingTypeInfo)) {
--- End diff --

In case a compiler adds generics, this case would be activated. Otherwise 
testing for `MissingTypInfo` is correct.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546758#comment-16546758
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user aljoscha commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r203060212
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
 ---
@@ -102,15 +104,62 @@ public void TestAnonymousInnerClassTrick4() throws 
Exception {
jfc.addClass(NestedAnonymousInnerClass.class)
.createJarFile();
 
-   Set ans = new HashSet();
+   Set ans = new HashSet<>();

ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass.class");

ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$1$1.class");

ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$1.class");

ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$A.class");
 
Assert.assertTrue("Jar file for Anonymous Inner Class is not 
correct", validate(ans, out));
 
-   out.delete();
+   Assert.assertTrue(out.delete());
+   }
+
+   @Ignore // this is currently not supported (see FLINK-9520)
+   @Test
+   public void testFilterWithMethodReference() throws Exception {
--- End diff --

It was a util for programmatically creating Jar files. I think it's only 
used in tests right now, for example `ClassLoaderUtilsTest`.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546681#comment-16546681
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user twalthr commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r203040441
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
 ---
@@ -102,15 +104,62 @@ public void TestAnonymousInnerClassTrick4() throws 
Exception {
jfc.addClass(NestedAnonymousInnerClass.class)
.createJarFile();
 
-   Set ans = new HashSet();
+   Set ans = new HashSet<>();

ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass.class");

ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$1$1.class");

ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$1.class");

ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$A.class");
 
Assert.assertTrue("Jar file for Anonymous Inner Class is not 
correct", validate(ans, out));
 
-   out.delete();
+   Assert.assertTrue(out.delete());
+   }
+
+   @Ignore // this is currently not supported (see FLINK-9520)
+   @Test
+   public void testFilterWithMethodReference() throws Exception {
--- End diff --

No this has never worked. I just noticed this bug when I looked at the 
test. What is this `JarFileCreator` good for actually?


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546614#comment-16546614
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user twalthr commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r203021961
  
--- Diff: 
flink-core/src/test/java/org/apache/flink/api/java/typeutils/LambdaExtractionTest.java
 ---
@@ -50,12 +41,12 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
-import static org.junit.Assert.fail;
+import static org.junit.Assert.assertTrue;
 
 /**
- * Tests the type extractor for lambda functions.
+ * Tests the type extractor for lambda functions. Many tests only work if 
the compiler supports
--- End diff --

A flat map can not work by definition because it contains generics. I will 
add some tests for the `returns`.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546533#comment-16546533
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user aljoscha commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r203002928
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
 ---
@@ -102,15 +104,62 @@ public void TestAnonymousInnerClassTrick4() throws 
Exception {
jfc.addClass(NestedAnonymousInnerClass.class)
.createJarFile();
 
-   Set ans = new HashSet();
+   Set ans = new HashSet<>();

ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass.class");

ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$1$1.class");

ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$1.class");

ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$A.class");
 
Assert.assertTrue("Jar file for Anonymous Inner Class is not 
correct", validate(ans, out));
 
-   out.delete();
+   Assert.assertTrue(out.delete());
+   }
+
+   @Ignore // this is currently not supported (see FLINK-9520)
+   @Test
+   public void testFilterWithMethodReference() throws Exception {
--- End diff --

Did these also not work when they were still in the java8 module?


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546531#comment-16546531
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user aljoscha commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r203001399
  
--- Diff: 
flink-core/src/test/java/org/apache/flink/api/java/typeutils/LambdaExtractionTest.java
 ---
@@ -271,19 +214,20 @@ public void testKeySelectorLambda() {
public void testLambdaTypeErasure() {
MapFunction, Tuple1> f = (i) -> null;
TypeInformation ti = TypeExtractor.getMapReturnTypes(f, new 
TypeHint>(){}.getTypeInfo(), null, true);
-   Assert.assertTrue(ti instanceof MissingTypeInfo);
+   assertTrue(ti instanceof MissingTypeInfo);
}
 
@Test
public void testPartitionerLambda() {
Partitioner> partitioner = (key, 
numPartitions) -> key.f1.length() % numPartitions;
-   final TypeInformation ti = 
TypeExtractor.getPartitionerTypes(partitioner);
-
-   Assert.assertTrue(ti.isTupleType());
-   Assert.assertEquals(2, ti.getArity());
-   Assert.assertEquals(((TupleTypeInfo) ti).getTypeAt(0), 
BasicTypeInfo.INT_TYPE_INFO);
-   Assert.assertEquals(((TupleTypeInfo) ti).getTypeAt(1), 
BasicTypeInfo.STRING_TYPE_INFO);
+   final TypeInformation ti = 
TypeExtractor.getPartitionerTypes(partitioner, null, true);
 
+   if (!(ti instanceof MissingTypeInfo)) {
--- End diff --

Why did you need to add this?


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546532#comment-16546532
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user aljoscha commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r203003680
  
--- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
 ---
@@ -237,19 +248,81 @@ private boolean 
validateKeyTypeIsHashable(TypeInformation type) {
}
 
/**
-* Gets the type of the key by which the stream is partitioned.
-* @return The type of the key by which the stream is partitioned.
+* Tries to fill in the type information. Type information can be 
filled in
+* later when the program uses a type hint. This method checks whether 
the
+* type information has ever been accessed before and does not allow
+* modifications if the type was accessed already. This ensures 
consistency
+* by making sure different parts of the operation do not assume 
different
+* type information.
+*
+* @param keyType The type information to fill in.
+*
+* @throws IllegalStateException Thrown, if the type information has 
been accessed before.
+*/
+   private void setKeyType(TypeInformation keyType) {
+   if (typeUsed) {
+   throw new IllegalStateException(
+   "TypeInformation cannot be filled in 
for the type after it has been used. "
+   + "Please make sure 
that the type info hints are the first call after "
+   + "the keyBy() function 
before any other access.");
+   }
+   this.keyType = keyType;
+   }
+
+   /**
+* Returns the key type of this {@code KeyedStream} as a {@link 
TypeInformation}. Once
+* this is used once the key type cannot be changed anymore using 
{@link #returns(TypeInformation)}.
+*
+* @return The output type of this {@code KeyedStream}
 */
@Internal
public TypeInformation getKeyType() {
-   return keyType;
+   if (keyType instanceof MissingTypeInfo) {
+   MissingTypeInfo typeInfo = (MissingTypeInfo) 
this.keyType;
+   throw new InvalidTypesException(
+   "The key type of key selector '"
+   + 
typeInfo.getFunctionName()
+   + "' could not be 
determined automatically, due to type erasure. "
+   + "You can give type 
information hints by using the returns(...) "
+   + "method on the result 
of the transformation call, or by letting "
+   + "your selector 
implement the 'ResultTypeQueryable' "
+   + "interface.", 
typeInfo.getTypeException());
+   }
+
+   // perform the validation when the type is used for the first 
time
+   if (!typeUsed) {
+   typeUsed = true;
+   validateKeyType(keyType);
+   }
+
+   return this.keyType;
}
 
@Override
protected DataStream setConnectionType(StreamPartitioner 
partitioner) {
throw new UnsupportedOperationException("Cannot override 
partitioning for KeyedStream.");
}
 
+   // 

+   //  Type hinting
+   // 

+
+   /**
+* Adds a type information hint about the key type of a key selector. 
This method
+* can be used in cases where Flink cannot determine automatically what 
the produced
+* type of a key selector is. That can be the case if the selector uses 
generic type variables
+* in the return type that cannot be inferred from the input type.
+*
+* @param typeInfo type information as a key type hint
+* @return This operator with a given key type hint.
+*/
+   public KeyedStream returns(TypeInformation typeInfo) {
--- End diff --

Should probably make this `@PublicEvolving` for now.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546530#comment-16546530
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user aljoscha commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r203001023
  
--- Diff: 
flink-core/src/test/java/org/apache/flink/api/java/typeutils/LambdaExtractionTest.java
 ---
@@ -50,12 +41,12 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
-import static org.junit.Assert.fail;
+import static org.junit.Assert.assertTrue;
 
 /**
- * Tests the type extractor for lambda functions.
+ * Tests the type extractor for lambda functions. Many tests only work if 
the compiler supports
--- End diff --

Some tests, like `flatMapLambda()` are not there anymore? It's because we 
don't use Tycho anymore but do theses tests now reside somewhere else? If not, 
we should probably have a new module `flink-tycho-lambda-tests` where we test 
those things that only work with Tycho. Otherwise we lose that coverage.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544663#comment-16544663
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user twalthr commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r202553410
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java 
---
@@ -584,21 +581,6 @@ private static void registerFactory(Type t, Class fac
// number of parameters the SAM of implemented 
interface has; the parameter indexing applies to this range
final int baseParametersLen = 
sam.getParameterTypes().length;
 
-   // executable references "this" implicitly
-   if (paramLen <= 0) {
-   // executable declaring class can also 
be a super class of the input type
-   // we only validate if the executable 
exists in input type
-   validateInputContainsExecutable(exec, 
inType);
-   }
-   else {
-   final Type input = 
TypeExtractionUtils.extractTypeFromLambda(
-   exec,
-   lambdaInputTypeArgumentIndices,
--- End diff --

Good point. I will remove it.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544657#comment-16544657
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user twalthr commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r202552984
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java 
---
@@ -584,21 +581,6 @@ private static void registerFactory(Type t, Class fac
// number of parameters the SAM of implemented 
interface has; the parameter indexing applies to this range
final int baseParametersLen = 
sam.getParameterTypes().length;
 
-   // executable references "this" implicitly
-   if (paramLen <= 0) {
--- End diff --

The input validation caused more errors than it solved. Especially with 
generic types. For lambdas this validation is limited anyway in a JDK compiler.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539988#comment-16539988
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r201655466
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java 
---
@@ -584,21 +581,6 @@ private static void registerFactory(Type t, Class fac
// number of parameters the SAM of implemented 
interface has; the parameter indexing applies to this range
final int baseParametersLen = 
sam.getParameterTypes().length;
 
-   // executable references "this" implicitly
-   if (paramLen <= 0) {
--- End diff --

Why you removed checking the input type information?


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539987#comment-16539987
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r201657797
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java 
---
@@ -695,29 +678,14 @@ private static void registerFactory(Type t, Class fac
Preconditions.checkArgument(
lambdaOutputTypeArgumentIndices != null,
"Indices for output type arguments 
within lambda not provided");
-   // check for lambda type erasure
-   validateLambdaGenericParameters(exec);
 
final Method sam = 
TypeExtractionUtils.getSingleAbstractMethod(baseClass);
final int baseParametersLen = 
sam.getParameterTypes().length;
 
// parameters must be accessed from behind, 
since JVM can add additional parameters e.g. when using local variables inside 
lambda function
final int paramLen = 
exec.getParameterTypes().length;
 
-   final Type input1 = 
TypeExtractionUtils.extractTypeFromLambda(
--- End diff --

Same comments as above. Why don't check the input types, if not checking 
them the lambda input indices not necessary.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539989#comment-16539989
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r201662934
  
--- Diff: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java ---
@@ -119,19 +120,15 @@ public boolean filter(Event value) throws Exception {
}
});
 
-   DataStream result = CEP.pattern(input, 
pattern).select(new PatternSelectFunction() {
+   DataStream result = CEP.pattern(input, 
pattern).flatSelect((p, o) -> {
--- End diff --

We should also have one test with `select` and lambda.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539990#comment-16539990
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user dawidwys commented on a diff in the pull request:

https://github.com/apache/flink/pull/6120#discussion_r201655890
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java 
---
@@ -584,21 +581,6 @@ private static void registerFactory(Type t, Class fac
// number of parameters the SAM of implemented 
interface has; the parameter indexing applies to this range
final int baseParametersLen = 
sam.getParameterTypes().length;
 
-   // executable references "this" implicitly
-   if (paramLen <= 0) {
-   // executable declaring class can also 
be a super class of the input type
-   // we only validate if the executable 
exists in input type
-   validateInputContainsExecutable(exec, 
inType);
-   }
-   else {
-   final Type input = 
TypeExtractionUtils.extractTypeFromLambda(
-   exec,
-   lambdaInputTypeArgumentIndices,
--- End diff --

If you removed checking the input type info the parameter 
`lambdaInputTypeArgumentIndices` is no longer necessary.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505944#comment-16505944
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/6120
  
@StephanEwen could you take a look?


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501507#comment-16501507
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/6120
  
I checked the docs. They do not change with these changes. However, we 
should verify that the docs about the Eclipse JDT compiler are still correct 
maybe even with an end-to-end test.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501502#comment-16501502
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/6120
  
@twalthr I think you only have to update the java8 docs: 
https://ci.apache.org/projects/flink/flink-docs-master/dev/java8.html


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501492#comment-16501492
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/6120
  
@zentol are there other locations where I have to remove the `flink-java8` 
module?


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501491#comment-16501491
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

GitHub user twalthr opened a pull request:

https://github.com/apache/flink/pull/6120

[FLINK-7251] [types] Remove the flink-java8 module and improve lambda type 
extraction

## What is the purpose of the change

This PR merge the `flink-java8` module into `flink-core`/`flink-runtime`. 
It also fixes issues with lambda extraction that occurred outside of 
`flink-java8` which used a different compiler.

Lambdas are still difficult to use in Flink. I'm working on an experimental 
solution that I will publish soon.

## Brief change log

- Integration of some lambda functions into existing examples/tests
- Removal of error-prone lambda input validation
- Removal of `flink-java8`
- Code clean up (remove warnings at several places)

## Verifying this change

This change is already covered by existing tests, such as 
`LambdaExtractionTest`.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): yes
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
  - The serializers: no
  - The runtime per-record code paths (performance sensitive): no
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  - The S3 file system connector: no

## Documentation

  - Does this pull request introduce a new feature? no
  - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twalthr/flink FLINK-7251_1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6120


commit 0710fd42c321964dbf523878f59f82624baee597
Author: Timo Walther 
Date:   2018-06-04T10:49:43Z

[FLINK-7251] [types] Remove the flink-java8 module and improve lambda type 
extraction




> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Timo Walther
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[Timo Walther (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479236#comment-16479236
 ] 

Timo Walther commented on FLINK-7251:
-

I will take care of this issue.

> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216174#comment-16216174
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/4455
  
@zentol Thank you for your reply, and I agree with you that the risk will 
be a little high for this PR. I'd like to close this PR if there's no better 
solution, thanks


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216175#comment-16216175
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zjureel closed the pull request at:

https://github.com/apache/flink/pull/4455


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209444#comment-16209444
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4455
  
We will have to revert every change that requires the tycho plugin to be 
moved into any other module. Using a different for these modules may have 
performance impacts and possibly subtle bugs.

Sorry that i didn't notice it earlier.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114119#comment-16114119
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/4475
  
@tillrohrmann I create `CommandLineParser` instead of `ParameterTool` in 
`ClusterEntrypoint#parseArguments`, please have a look when you're free, thanks


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114108#comment-16114108
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

GitHub user zjureel opened a pull request:

https://github.com/apache/flink/pull/4475

[FLINK-7251] Add proper command line parsing tool to ClusterEntrypoint

## What is the purpose of the change

Add a proper command line parsing tool `CommandLineParser` to the entry 
point of the ClusterEntrypoint#parseArguments


## Brief change log

  - *Add command line parsing tool `CommandLineParser`*
  - *Use `CommandLineParser` instead of `ParameterTool` in 
ClusterEntrypoint#parseArguments*


## Verifying this change

*(Please pick either of the following options)*
This change added tests and can be verified as follows:

*(example:)*
  - *Added test case `CommandLineParserTest`*

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / not documented)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjureel/flink FLINK-7307

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4475.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4475


commit 7f0e67daf9f66d68201b9e660a3ba8328fad2ce2
Author: zjureel 
Date:   2017-08-04T08:08:05Z

[FLINK-7251][improvement] Add proper command line parsing tool to 
ClusterEntrypoint




> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112113#comment-16112113
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/4455
  
1. For the `StateBackendITCase`, it can be resolved by bumping the tycho 
compiler version to 1.0.0, but when I try to use tycho compiler version 1.0.0 
in `flink-java`, it will cause lambda exception for `LambdaExtractionTest`. I 
think it's better to stay in the same version of tycho compiler in different 
flink project, so I try to modify the code of StateBackendITCase to resolve the 
problem directly.

2. For the `JobRetrievalITCase`, I try every version of tycho compiler, the 
problem always exists. I think tycho compiler may be incompatible with 
`Seq.last()` method. I try to use another method in `Seq` to get the last 
element in `JobRetrievalITCase`, and it would be ok

@zentol What do you think? Thanks :)


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110690#comment-16110690
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4455
  
Are you talking about things like `FlatMapITCase`? I would suggest to 
integrate these into the existing ITCase in `flink-tests`.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110683#comment-16110683
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/4455
  
Maybe it's better to move *ITCase to `Flink-java` project and rename them 
to *Test, I find it will be alright, what do you think? @zentol 


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110660#comment-16110660
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/4455
  
The `JobRetrievalITCase` is ok when I remove the tycho-compiler completely, 
I think it may be a bug of the tycho-compiler :(


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110539#comment-16110539
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4455
  
Could you check what happens when you remove the tycho-compiler completely?


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110526#comment-16110526
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4455
  
The StateBackendITCase can be resolved by bumping the tycho compiler 
version to 1.0.0, but the scala one remains.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110509#comment-16110509
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4455
  
There's a compilation failure in flink-tests:
```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile 
(default-testCompile) on project flink-tests_2.11: Compilation failure: 
Compilation failure:
[ERROR] 
/home/travis/build/apache/flink/flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/StateBackendITCase.java:[67]
[ERROR] .map(new RichMapFunction, String>() {
[ERROR] ^^^
[ERROR] The method map(MapFunction,R>) in the type 
DataStream> is not applicable for the arguments (new 
RichMapFunction,String>(){})
[ERROR] 
/home/travis/build/apache/flink/flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java:[99]
[ERROR] final ActorSystem actorSystem = actorSystemSeq.last();
[ERROR] 
[ERROR] The method last() is ambiguous for the type Seq
```


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110362#comment-16110362
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zjureel commented on the issue:

https://github.com/apache/flink/pull/4455
  
@zentol Thank you for your suggestion, it sounds good to me and I have 
fixed them, thanks


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109064#comment-16109064
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4455
  
This would be easier to review (and for git to keep track of) if the 
individual commits would actually move a file, and not just copy them.


> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108949#comment-16108949
 ] 

ASF GitHub Bot commented on FLINK-7251:
---

GitHub user zjureel opened a pull request:

https://github.com/apache/flink/pull/4455

[FLINK-7251] Merge the flink-java8 project into corresponding flink project

## What is the purpose of the change

Merge the codes in flink-java8 project into corresponding flink project

## Brief change log
  - *Merge examples into flink-examples project*
  - *Merge runtime test into flink-runtime project*
  - *Merge test case into flink-tests project*
  - *Remove flink-java8 project*


## Verifying this change

*(Please pick either of the following options)*

This changes are examples and test cases without any test coverage

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): no
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
  - The serializers: no
  - The runtime per-record code paths (performance sensitive): no
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no

## Documentation

  - Does this pull request introduce a new feature? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjureel/flink FLINK-7251

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4455


commit 39d0ed7a31f98d2d16beeaf0ff6418252933afc8
Author: zjureel 
Date:   2017-08-01T10:03:23Z

[FLINK-7251] mv examples to flink-examples

commit b11eb22793f2c28faa5765c817e83f7e79929e1b
Author: zjureel 
Date:   2017-08-01T10:08:06Z

[FLINK-7251] mv test case to flink-runtime

commit 544fbef0450155135ba52d5f4e9dde567ed3de80
Author: zjureel 
Date:   2017-08-01T10:11:57Z

[FLINK-7251] mv examples to flink-tests

commit 1f944726995b3173aaf24fd26a6a91b8f2d7f7e7
Author: zjureel 
Date:   2017-08-01T10:13:11Z

[FLINK-7251] mv test cases to flink-cep and flink-java

commit 645fa92fa4a5f3c9a6e0f49d77ebf9bbda6f5b01
Author: zjureel 
Date:   2017-08-01T10:14:10Z

[FLINK-7251] remove flink-java8 project




> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Fang Yong
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

[Chesnay Schepler (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098225#comment-16098225
 ] 

Chesnay Schepler commented on FLINK-7251:
-

The JIRA title doesn't seem accurate. The {{java8}} module only contains 
examples and tests.

The examples should (naturally) be merged into the flink-example submodules.
The tests should be divided across {{flink-java}} (LambdaExtractionTest), 
{{flink-cep}} (CEPLambdaTest),  {{flink-runtime}} (JarFileCreatorLambdaTest) 
and probably {{flink-tests}} (*ITCase).

> Merge the flink-java8 project into flink-core
> -
>
> Key: FLINK-7251
> URL: https://issues.apache.org/jira/browse/FLINK-7251
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Reporter: Stephan Ewen
> Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)